[Kicad-developers] [PATCH 11/19] ElectricPinType: Rename PIN_NMAX to PINTYPE_COUNT

--- eeschema/dialogs/dialog_erc.cpp | 18 +- eeschema/dialogs/dialog_erc.h | 4 ++-- eeschema/erc.cpp| 6 +++--- eeschema/lib_pin.cpp| 6 +++--- eeschema/pin_type.h | 2 +- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git

[Kicad-developers] [PATCH 05/19] PinShape: move enum to own header

--- eeschema/lib_pin.h| 21 +-- eeschema/pin_shape.h | 50 +++ eeschema/widgets/pin_shape_combobox.h | 2 +- 3 files changed, 52 insertions(+), 21 deletions(-) create mode 100644 eeschema/pin_shape.h diff --git

[Kicad-developers] [PATCH 12/19] ElectricPinType: Separate PINTYPE_COUNT from enum

This allows us to use compiler warnings for enum coverage in switch statements. --- eeschema/lib_pin.cpp | 6 +++--- eeschema/pin_type.h | 7 +-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/eeschema/lib_pin.cpp b/eeschema/lib_pin.cpp index e210d11..99be160 100644 ---

[Kicad-developers] [PATCH 14/19] PinTypeComboBox: fully initialize in c'tor

--- eeschema/dialogs/dialog_lib_edit_pin.cpp | 13 - eeschema/dialogs/dialog_lib_edit_pin.h | 1 - eeschema/pinedit.cpp | 2 -- eeschema/widgets/pin_type_combobox.cpp | 15 +++ 4 files changed, 15 insertions(+), 16 deletions(-) diff --git

[Kicad-developers] [PATCH 19/19] TypeSheetLabel: use enum

--- eeschema/class_netlist_object.h | 2 +- eeschema/dialogs/dialog_edit_label.cpp | 3 ++- eeschema/dialogs/dialog_sch_edit_sheet_pin.h | 8 ++-- eeschema/edit_label.cpp | 8 eeschema/sch_sheet_pin.cpp | 2 +-

[Kicad-developers] [PATCH 18/19] ElectricPinType: move bitmap lookup

--- eeschema/lib_pin.cpp | 28 +- eeschema/lib_pin.h | 8 --- eeschema/pin_type.cpp | 43 ++ eeschema/pin_type.h| 2 ++ eeschema/widgets/pin_type_combobox.cpp | 4

[Kicad-developers] [PATCH 17/19] ElectricPinType: remove list interfaces

--- eeschema/lib_pin.cpp | 11 --- eeschema/lib_pin.h | 6 -- eeschema/widgets/pin_type_combobox.cpp | 5 +++-- 3 files changed, 3 insertions(+), 19 deletions(-) diff --git a/eeschema/lib_pin.cpp b/eeschema/lib_pin.cpp index cbea37c..d7a83f7

[Kicad-developers] [PATCH 16/19] ElectricPinType: move text lookup

--- eeschema/CMakeLists.txt | 1 + eeschema/erc.cpp| 8 +++--- eeschema/lib_pin.cpp| 27 ++ eeschema/lib_pin.h | 9 +- eeschema/pin_type.cpp | 73 + eeschema/pin_type.h | 5 6 files changed, 86

[Kicad-developers] [PATCH 08/19] PinShape: move bitmap lookup

This moves the bitmaps out of the data model as well. --- eeschema/lib_pin.cpp| 22 eeschema/lib_pin.h | 7 --- eeschema/pin_shape.cpp | 37 + eeschema/pin_shape.h

[Kicad-developers] [PATCH 04/19] PinShapeComboBox: typesafe Get/Set

These overrides provide typed access to the current selection, overriding the regular integer-based accessor/mutator. --- eeschema/dialogs/dialog_lib_edit_pin.h | 2 +- eeschema/widgets/pin_shape_combobox.cpp | 12 eeschema/widgets/pin_shape_combobox.h | 5 + 3 files

[Kicad-developers] [PATCH 13/19] PinTypeComboBox: Introduce widget

plyToAllParts; diff --git a/eeschema/widgets/pin_type_combobox.cpp b/eeschema/widgets/pin_type_combobox.cpp new file mode 100644 index 000..3c2ac7e --- /dev/null +++ b/eeschema/widgets/pin_type_combobox.cpp @@ -0,0 +1,43 @@ +/* + * This program source code file is part of KiCad, a free EDA CAD

[Kicad-developers] [PATCH 15/19] PinTypeComboBox: typesafe Get/Set

--- eeschema/dialogs/dialog_lib_edit_pin.h | 2 +- eeschema/widgets/pin_type_combobox.cpp | 12 eeschema/widgets/pin_type_combobox.h | 5 + 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin.h

[Kicad-developers] [PATCH 06/19] PinShape: move text lookup

--- eeschema/CMakeLists.txt | 1 + eeschema/lib_pin.cpp| 29 +++-- eeschema/pin_shape.cpp | 67 + eeschema/pin_shape.h| 5 4 files changed, 76 insertions(+), 26 deletions(-) create mode 100644 eeschema/pin_shape.cpp

[Kicad-developers] [PATCH 10/19] ElectricPinType: Use enum rather than int where possible

--- eeschema/class_netlist_object.cpp| 6 +++--- eeschema/class_netlist_object.h | 8 ++-- eeschema/dialogs/dialog_lib_edit_pin.cpp | 2 +- eeschema/dialogs/dialog_lib_edit_pin.h | 6 +++--- eeschema/erc.cpp | 10 +- eeschema/lib_pin.cpp

[Kicad-developers] [PATCH 03/19] PinShapeComboBox: Fully initialize in c'tor

This makes the widget universally usable without special initialisation. --- eeschema/dialogs/dialog_lib_edit_pin.cpp | 12 eeschema/dialogs/dialog_lib_edit_pin.h | 1 - eeschema/pinedit.cpp | 1 - eeschema/widgets/pin_shape_combobox.cpp | 12 4

[Kicad-developers] [PATCH] Add icons to pin table's type column

. Simon Simon Richter (1): Add icon to pin type column eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 51 -- 1 file changed, 47 insertions(+), 4 deletions(-) -- 2.1.4 ___ Mailing list: https://launchpad.net/~kicad-developers

[Kicad-developers] [PATCH] Add icon to pin type column

--- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 51 -- 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index 5a6202e..294ee09 100644 ---

[Kicad-developers] [PATCH] Enable C++11

This enables C++11 support, if either CMake is sufficiently new to have this feature built in, or the compiler is supported by the workaround code (gcc or clang). --- CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index

[Kicad-developers] C++11 support

Hi, after all the C++11 discussion, here is a patch to use C++11 as default, tested on Linux and MSYS2. Simon Simon Richter (1): Enable C++11 CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) -- 2.1.4 ___ Mailing

Re: [Kicad-developers] [PATCH] Enable C++11

Hi, On 12.03.2016 18:04, Mark Roszko wrote: > But o well, screw it, undoubtedly someone will get the issue > eventually later but screw wasting time finding what it was. Agreed. One thing we should look into though is actually getting Ubuntu bug reports. I know that there are several people

Re: [Kicad-developers] [PATCH] Enable C++11

Hi, On 11.03.2016 17:48, Wayne Stambaugh wrote: > It still sounds to me that boost needs to be bumped to 1.55 and possibly > some definitions need to added to the build configuration for Boost to > build properly. Hm, compiling worked for me with Boost 1.55 on Debian with no further changes.

[Kicad-developers] [PATCH 0/2] Two small portability patches

Hi, these should be fairly obvious: - all Windows platforms use declspec(dllexport) - MSVC does not set a symbol called "MSVC" - use wxFileName to access the FS rather than POSIX Simon Simon Richter (2): Fix condition for Windows-style DLL export Make file test more por

[Kicad-developers] [PATCH 1/2] Fix condition for Windows-style DLL export

--- include/plugins/3dapi/ifsg_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/plugins/3dapi/ifsg_defs.h b/include/plugins/3dapi/ifsg_defs.h index 0523bf1..d0fd56d 100644 --- a/include/plugins/3dapi/ifsg_defs.h +++ b/include/plugins/3dapi/ifsg_defs.h @@ -31,7

[Kicad-developers] 3D merge: new warnings

Hi, first Jenkins builds after the merge went through, we have a few new warnings. The msys build is rather silent[1]: ogl_legacy_utils.cpp:209 variable 'end' set but not used [-Wunused-but-set-variable] The MSVC build has a few more new warnings[2], sorted by category here: vrml.cpp:185

Re: [Kicad-developers] [PATCH] Enable C++11

Hi, On 06.04.2016 05:19, Simon Richter wrote: > This enables C++11 support, if either CMake is sufficiently new to have > this feature built in, or the compiler is supported by the workaround code > (gcc or clang). Meh, that patch was still in the temp dir where I stage mails befor

[Kicad-developers] [PATCH] Drop dependency on mm_malloc.h

Hi, apparently, the only mention of the string "mm_malloc" in the entire codebase is this include, so there should be no ill effects from dropping it. Simon Simon Richter (1): Drop dependency on include/plugins/3dapi/xv3d_types.h | 1 - 1 file changed, 1 deletion(-)

[Kicad-developers] [PATCH] Drop dependency on

This appears to be unused. --- include/plugins/3dapi/xv3d_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/plugins/3dapi/xv3d_types.h b/include/plugins/3dapi/xv3d_types.h index 630d057..43222d6 100644 --- a/include/plugins/3dapi/xv3d_types.h +++

[Kicad-developers] [PATCH] Enable C++11

This enables C++11 support, if either CMake is sufficiently new to have this feature built in, or the compiler is supported by the workaround code (gcc or clang). --- CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index

Re: [Kicad-developers] [PATCH] Enable C++11

Hi Wayne, On 17.03.2016 20:35, Wayne Stambaugh wrote: > @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and > clang instead of the -gnu-c++11. This seems to be an issue that should > be addressed. Maybe this is what is breaking @Mark's builds. I would > feel more comfortable

Re: [Kicad-developers] [PATCH 3/8] Use PATH to search for shared libraries on Windows

Hi, On 01.03.2016 16:58, jp charras wrote: > I do no see what issue patch 1 fixes. That is one half of the things I did -- the Windows API offers InterlockedIncrement and InterlockedDecrement only for unsigned types, while gcc's intrinsic is overloaded, so I had to change that in a common

Re: [Kicad-developers] 3D file relative paths

Hi, On 13.04.2016 02:40, David Godfrey wrote: > The use of Env Vars is the only sensible and portable method that can be > used. From a distribution point of view: this is unusable. We need to ship something that can be started from a desktop icon, without extra setup, and users need to be able

Re: [Kicad-developers] dyn_cast

Hi, On 13.04.2016 18:13, Chris Pavlina wrote: > What is the purpose of dyn_cast<> in include/core/typeinfo.h? Why don't we > just > use dynamic_cast<>? And can we either replace the former with the latter, or > add a comment to the former explaining its purpose? It uses the parallel type

Re: [Kicad-developers] Net Ties

Hi, On 22.04.2016 22:28, Jean-Paul Louis wrote: > Please give us an example where you would need to connect more than 2 nets. You can also use net ties to help with the layout of star topologies, length controlled splits and decoupling capacitors. Star Topologies: Connect the diode and

Re: [Kicad-developers] Net Ties

Hi Wayne, On 22.04.2016 15:04, Wayne Stambaugh wrote: >> I've added UI[1] and save support in eeschema already, still needs >> mapping to the netlist and pcbnew support. > Are you aware that changes to the current schematic file format are > forbidden until we (I) finish implementing the new

Re: [Kicad-developers] Net Ties

On 22.04.2016 15:23, Tomasz Wlostowski wrote: > IMHO it can be done without any changes on the eeschema side by adding a > special component to the standard library (just like GND/power ports). Yes, but that'd feel like more of a hack. > PCBnew could interpret it as a zero-sized copper pad.

[Kicad-developers] Net Ties

Hi, as wxWidgets is getting on my nerves with editing widgets in the pin table not rendering properly, I've started on support for net ties. In the current iteration, they would be placed the same way as junctions. Rules: - Any wire or pin connected to a net tie is in a separate net (unless

Re: [Kicad-developers] [PATCH] Make EDA_ITEM::Clone() abstract

Hi, On 20.04.2016 22:15, Mark Roszko wrote: > Since we have C++11 now...why not use the override specifier? :D We still have to make it abstract though if we want to be told off when we forget to implement it. Simon signature.asc Description: OpenPGP digital signature

[Kicad-developers] [PATCH v2] Make EDA_ITEM::Clone() abstract

--- 3d-viewer/3d_material.h| 3 +++ 3d-viewer/3d_struct.h | 2 ++ common/base_struct.cpp | 7 --- eeschema/class_libentry.h | 6 ++ eeschema/class_sch_screen.h| 3 +++ gerbview/class_gbr_screen.h

[Kicad-developers] [PATCH 2/3] Replace unshared boost::shared_array with std::unique_ptr

These are never shared, so std::unique_ptr works fine. --- common/gal/opengl/opengl_gal.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/gal/opengl/opengl_gal.cpp b/common/gal/opengl/opengl_gal.cpp index 4325fe7..330e390 100644 ---

[Kicad-developers] [PATCH 1/3] Replace boost::shared_ptr with std::shared_ptr

--- 3d-viewer/3d_mesh_model.h | 4 ++-- common/gal/opengl/opengl_gal.cpp | 2 +- common/geometry/hetriang.cpp | 34 +- eeschema/class_libentry.h | 7 +++ eeschema/sch_component.h | 5 ++---

[Kicad-developers] [PATCH 0/3] Deboostify shared_ptr

(so std::unique_ptr has the correct semantics), and one is used in place of a more sensible allocator. Simon Simon Richter (3): Replace boost::shared_ptr with std::shared_ptr Replace unshared boost::shared_array with std::unique_ptr Replace last instance of boost::shared_array 3d

[Kicad-developers] [PATCH 3/3] Replace last instance of boost::shared_array

This is a bit tricky, because the smart pointer is actually used only for delayed deletion, and no users of the object are involved. This code could probably be replaced with a pool allocator that flushes the entire pool after rendering is complete, to improve performance. ---

Re: [Kicad-developers] Optimization

Hi, On 27.04.2016 08:42, Lorenzo Marcantonio wrote: > First guess is that in modern CPUs pipelining, branch prediction and > cache locality have a bigger effect than raw computation. FWIW, the fully optimized code even has the compiler replacing the separate sin() and cos() invocations by a

[Kicad-developers] [PATCH] Use std::atomic for portable locale init counting

--- common/common.cpp | 10 +++--- include/common.h | 4 +++- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/common/common.cpp b/common/common.cpp index 09a2103..4be1988 100644 --- a/common/common.cpp +++ b/common/common.cpp @@ -68,14 +68,12 @@ EDA_COLOR_Tg_GhostColor;

[Kicad-developers] [PATCH] Fix spelling "propage" -> "propagate"

--- eeschema/class_netlist_object.h | 2 +- eeschema/netlist.cpp| 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/eeschema/class_netlist_object.h b/eeschema/class_netlist_object.h index d47ebbd..9608f90 100644 --- a/eeschema/class_netlist_object.h

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

Hi, On 20.05.2016 00:25, Thor-Arne wrote: > Delete wire is on the delete button. and delete segment is on the > backspace key. Ah, that makes (some) sense. To me, the behaviour of the delete key looks fairly nonsensical, because it will stop at corners, but not at junctions, while I'd expect

Re: [Kicad-developers] changing language

Hi, On 19.05.2016 09:42, Marco Ciampa wrote: > Changing language IMHO should pop-up a dialog warning that some items > could continue to show as last translation option setting until closing > and reopening of all kicad sessions. I'm still not sure why we actually need that option. It is 2016,

[Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

--- eeschema/bus-wire-junction.cpp | 3 +++ eeschema/sch_screen.cpp| 18 ++ 2 files changed, 21 insertions(+) diff --git a/eeschema/bus-wire-junction.cpp b/eeschema/bus-wire-junction.cpp index 44dcdf3..36a416d 100644 --- a/eeschema/bus-wire-junction.cpp +++

[Kicad-developers] [PATCH v2] Rewrite loop conditions in SchematicCleanUp

These are a tiny bit more readable, and do not depend on all branches to correctly advance the loop variable. --- eeschema/sch_screen.cpp | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index

Re: [Kicad-developers] [PATCH] Schematic Cleanup: Split lines at junctions

Hi jp, On 19.05.2016 19:44, jp charras wrote: > It could be worth to *clearly* explain in your patches what bug you want to > fix, or what enhancement > you are adding. Good point. The last batch has two goals: 1. fix a long-standing annoyance that deleting a line segment will delete the

[Kicad-developers] Who is responsible for adding to the eeschema draw list?

Hi, I'm touching a bit of eeschema code and am unsure who is responsible for adding SCH_ITEM objects to SCH_SCREEN's m_DrawList. Looking at the AddJunction function, it adds the junction to the draw list if it is also added to the undo list, while the caller adds it unconditionally. Where would

[Kicad-developers] [PATCH] Clarify ERC: we're iterating netlist items, not nets

--- eeschema/dialogs/dialog_erc.cpp | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/eeschema/dialogs/dialog_erc.cpp b/eeschema/dialogs/dialog_erc.cpp index f9d2ca6..3d0b31d 100644 --- a/eeschema/dialogs/dialog_erc.cpp +++

[Kicad-developers] [PATCH] Explain how ERC works.

--- eeschema/dialogs/dialog_erc.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/eeschema/dialogs/dialog_erc.cpp b/eeschema/dialogs/dialog_erc.cpp index 9a850e5..681a4db 100644 --- a/eeschema/dialogs/dialog_erc.cpp +++ b/eeschema/dialogs/dialog_erc.cpp @@ -496,6 +496,15 @@ void

[Kicad-developers] [PATCH] Check sorting of netlist during ERC

The ERC code depends on netlist items to be sorted by net code, so verify that in debug builds. While this condition is stricter than necessary, it should still hold with the current code, and provide a good canary if a change to the sorting code might break ERC. ---

[Kicad-developers] [PATCH 5/5] Schematic cleanup: shortcut if no match can happen

--- eeschema/sch_screen.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index 52e86f1..a2655a7 100644 --- a/eeschema/sch_screen.cpp +++ b/eeschema/sch_screen.cpp @@ -454,6 +454,9 @@ bool SCH_SCREEN::SchematicCleanUp() const

[Kicad-developers] [PATCH 1/5] Rewrite loop conditions in SchematicCleanUp

These are a tiny bit more readable, and do not depend on all branches to correctly advance the loop variable. --- eeschema/sch_screen.cpp | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index

[Kicad-developers] [PATCH 4/5] Schematic Cleanup: Introduce shorthand for rhs line/junction tests

--- eeschema/sch_screen.cpp | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index 182bba7..52e86f1 100644 --- a/eeschema/sch_screen.cpp +++ b/eeschema/sch_screen.cpp @@ -449,7 +449,12 @@ bool

[Kicad-developers] [PATCH 3/5] Schematic Cleanup: Move lhs == rhs test to beginning of loop

--- eeschema/sch_screen.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index fd9b9b2..182bba7 100644 --- a/eeschema/sch_screen.cpp +++ b/eeschema/sch_screen.cpp @@ -446,6 +446,9 @@ bool SCH_SCREEN::SchematicCleanUp()

[Kicad-developers] [PATCH 2/5] Schematic Cleanup: introduce shorthand for line/junction tests

--- eeschema/sch_screen.cpp | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index bb3ebe1..fd9b9b2 100644 --- a/eeschema/sch_screen.cpp +++ b/eeschema/sch_screen.cpp @@ -432,7 +432,12 @@ bool

[Kicad-developers] [PATCH] SCH_LINE: Split mergeability test and actual merge

--- eeschema/sch_line.cpp | 58 ++--- eeschema/sch_line.h | 16 ++ eeschema/sch_screen.cpp | 3 ++- 3 files changed, 45 insertions(+), 32 deletions(-) diff --git a/eeschema/sch_line.cpp b/eeschema/sch_line.cpp index 72efb5c..372885b

Re: [Kicad-developers] [PATCH] Rework OpenSSL mutex workaround

Hi Wayne, On 05.05.2016 22:51, Wayne Stambaugh wrote: > Is this patch for the stable branch, the product branch, or both? Currently, for the product branch, and ideally it should be trivial to backport to the stable branch afterwards (it removes a lot of code that doesn't exist in the stable

[Kicad-developers] [PATCH] Rework OpenSSL mutex workaround

This allows compiling KiCad without OpenSSL. If CURL uses OpenSSL in the background, we serialize requests to avoid a bug there, which degrades performance. Given that no one should link KiCad against OpenSSL really because of licence conflicts, this is not so bad. --- common/CMakeLists.txt

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

Hi, On 05.05.2016 20:01, Bernhard Stegmaier wrote: > Just a note… I may be wrong, but I guess for OS X this is only true if you > build against the curl supplied by OS X natively? Would it make sense to serialize the network accesses if libcurl tells us that it is using the OpenSSL backend (at

[Kicad-developers] [PATCH 1/4] Warn about missing override specifiers, if supported (gcc 5.1, clang 3.5)

--- CMakeLists.txt | 12 1 file changed, 12 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index f077de3..130b1cc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -152,6 +152,18 @@ if( CMAKE_VERSION VERSION_LESS 3.1 AND ( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_C

[Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

l overriding methods Simon Simon Richter (4): Warn about missing override specifiers, if supported (gcc 5.1, clang 3.5) Don't clear compiler flags in 3d_cache directory Add "virtual" keyword on implicitly virtual methods Add C++11 "override" specifie

[Kicad-developers] [PATCH 2/4] Don't clear compiler flags in 3d_cache directory

--- 3d-viewer/3d_cache/CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/3d-viewer/3d_cache/CMakeLists.txt b/3d-viewer/3d_cache/CMakeLists.txt index 82ed6de..cc06e9d 100644 --- a/3d-viewer/3d_cache/CMakeLists.txt +++ b/3d-viewer/3d_cache/CMakeLists.txt @@ -1,3 +1 @@ -# unset

[Kicad-developers] [PATCH 4/4] Remove unused FindOpenSSL.cmake

--- CMakeModules/FindOpenSSL.cmake | 342 - 1 file changed, 342 deletions(-) delete mode 100644 CMakeModules/FindOpenSSL.cmake diff --git a/CMakeModules/FindOpenSSL.cmake b/CMakeModules/FindOpenSSL.cmake deleted file mode 100644 index de91787..000 ---

[Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

ble by calling .reserve() which should give a far better guarantee. 2. Added copy to clipboard information for curl 3. Removed some openssl references in compiling.md 4. Renamed struct vars to be uppercase to match "public var" code style policy Simon Richter (2):

[Kicad-developers] [PATCH 1/4] Replace the avhttp library used by the github plugin with libcurl.

From: Mark Roszko --- CMakeLists.txt| 5 + common/CMakeLists.txt | 6 +- common/kicad_curl/kicad_curl.cpp | 54 +++ common/kicad_curl/kicad_curl_easy.cpp | 163 +

[Kicad-developers] [PATCH 2/4] Add missing dependency github_plugin -> pcbcommon

The GitHub plugin needs the generated PCB parser code. --- pcbnew/CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pcbnew/CMakeLists.txt b/pcbnew/CMakeLists.txt index 1249069..6fa6ede 100644 --- a/pcbnew/CMakeLists.txt +++ b/pcbnew/CMakeLists.txt @@ -536,6 +536,8 @@

[Kicad-developers] [PATCH 3/4] Replace avhttp with libcurl: Some fixes: 1. Fixed an assumption somebody originally made in the plugin that std::string had contiguous storage. This is not specced behav

From: unknown --- Documentation/development/compiling.md | 12 +--- common/basicframe.cpp | 3 +++ common/kicad_curl/kicad_curl.cpp | 26 ++ common/kicad_curl/kicad_curl_easy.cpp | 26 +-

[Kicad-developers] [PATCH] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets

This function is unused, and looks similar to the tree builder above, so it might likely be left over from a refactoring effort. --- .../netlist_exporters/netlist_exporter_generic.cpp | 73 -- .../netlist_exporters/netlist_exporter_generic.h | 7 --- 2 files changed, 80

Re: [Kicad-developers] Debian and Ubuntu packaging.

On 02.05.2016 21:44, Chris Pavlina wrote: > Perhaps we could provide our own Debian and Ubuntu packages, like the Ubuntu > nightly PPA. That still wouldn't be legal, though -- the OpenSSL licence is incompatible with the GPL, and the result is undistributable, so any time the KiCad project ships

Re: [Kicad-developers] [RFC] On net ties, microwave tools & custom pad shapes, altogether.

Hi, On 03.05.2016 14:40, Tomasz Wlostowski wrote: > - net_tie: DRC treats the primitive as non-conducting and doesn't throw > a short circuit error (see drawing A) That requires the net tie to have a size that is at least larger than the minimum clearance of any of the netclasses involved. My

Re: [Kicad-developers] Debian and Ubuntu packaging.

Hi Wayne, On 02.05.2016 21:09, Wayne Stambaugh wrote: > Do we have any Debian developers on our mailing list? I though I saw a > Simon Richter on Planet Debian. Is that you Simon? Yes. > Can someone tell me > why the Debian package devs decided to build KiCad with the Git

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

Hi Wayne, On 05.05.2016 16:15, Wayne Stambaugh wrote: > Thanks Simon! Nice work. I just tested this on windows and it appears > to work fine. I'm assuming you tested this on Linux. Yes, briefly. These are just the two "switch to CURL" patches from the devel branch, and one small fix, so not

Re: [Kicad-developers] Bitmap fonts

Hi, On 14.04.2016 20:27, Vesa Solonen wrote: > Orson, please have a look how rendering is done on gEDA gschem. IIRC > font rendering is by Peter Clifton and he went on to optimize stroke > (pixel)grid fitting, etc. The actual renderer is Cairo, but could we use > Cairo to make the font textures

Re: [Kicad-developers] Bitmap fonts

Hi, On 14.04.2016 11:33, Maciej Sumiński wrote: > Currently, the most expensive thing to draw is stroked text, as there > are lots of labels on tracks and pads. To reduce the drawing cost (and > memory requirements), texts that are not targeted to Gerber files (i.e. > pad & track labels) might

[Kicad-developers] [PATCH] Make EDA_ITEM::Clone() abstract

Make this function abstract in the base, and provide private functions emitting error messages in all types that are actually instantiated. --- 3d-viewer/3d_material.h| 3 +++ 3d-viewer/3d_struct.h | 2 ++ common/base_struct.cpp | 7

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

Hi Wayne, On 12.07.2016 16:07, Wayne Stambaugh wrote: > I was looking over this patch set and before I apply it I want to be > sure that all base class functions declared as virtual are explicitly > declared as override in the derived classes. It's a very large patch > set and I don't have time

[Kicad-developers] Project Wiki?

Hi, one of the outcomes at CERN was that we want to use the Blueprints system in Launchpad more, and get consensus on major developments before they are started. For this, it would be great if there was a wiki, but I'm not sure who would or should host it. The alternative would be to develop the

Re: [Kicad-developers] Project Wiki?

Hi, On 25.07.2016 17:12, Nick Østergaard wrote: > Using pads we have no content control, but it is very easy to > brainstorm stuff. That would be fine if we can at some point finalize a proposal and archive it. > Using hugo, it will be done via github such that > pull request can be made from

[Kicad-developers] [PATCH] Remove definition of log10(double)

This is also defined in , and likely to be a compiler intrinsic. --- common/widgets/mathplot.cpp | 6 -- 1 file changed, 6 deletions(-) diff --git a/common/widgets/mathplot.cpp b/common/widgets/mathplot.cpp index 3a1896b..f9de3ae 100644 --- a/common/widgets/mathplot.cpp +++

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

Hi, On 13.07.2016 01:32, Brano Panak wrote: > - m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ); > + m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL , _T("Cancel")); This will break Alt-C as Cancel on the other architectures. Not a big loss in my opinion (does the Escape key work?),

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

Hi, On 14.07.2016 16:17, Mark Roszko wrote: > If you put virtual blah() in struct C without override, you can be > creating a new virtual function if the signature does not match and > its completely valid. Right, but that is something we can catch with "override". The reason I like to have

Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation

Hi, On 18.07.2016 21:18, Simon Richter wrote: > If we don't care about the branch history, I've attached a diff between > the current product branch tip and Mario's branch (fixing one conflict > in a comment and reverting the bitmaps). It seems the list dropped the attachment. Lin

Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation

Hi, On 18.07.2016 19:54, Wayne Stambaugh wrote: > I could not merge your branch into the product branch. Here is the > merge error message: Rebasing that branch is going to be difficult because of all the backmerges from mainline. If we don't care about the branch history, I've attached a

Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation

Hi Mário, > I've updated my branch with latest changes and clean the conflicts, > As I am not an expert, I am not sure how can I revert the old generated > bitmaps, > would you mind to make a new branch for me? With bzr, that is difficult. > I don't mind (and I prefer) that my branch history

Re: [Kicad-developers] [PATCH] Fix memory leaks with improper wxBaseConfig* usage (model ownership and ownership-transfer with std::unique_ptr)

Hi, On 28.06.2016 21:30, Michael Steinberg wrote: > Now I only need to know how I should go about your concerns. Maybe using > something along the lines of > > using WX_CONFIG_PTR = std::unique_ptr< wxConfigBase >; No, that isn't readable either, because it doesn't communicate the

Re: [Kicad-developers] Regarding [PATCH] refactor_profile.patch

Hi, On 05.07.2016 01:45, Michael Steinberg wrote: > I was made aware that MinGW's implementation of std::chrono might be > lacking, but my testbed is not including that yet, so I cannot > double-check the implementation. I've started a build on Jenkins, but it will take a while until the system

Re: [Kicad-developers] Stable release 5 road map.

Hi, On 05.07.2016 09:55, Wayne Stambaugh wrote: > If you are > working on new features that are not in the version 5 road map, please > inform me of what you working on and whether or not it will be ready to > release by FOSDEM 2017. My current branches: 1. writeable pin table This could

Re: [Kicad-developers] KiCad library installation (in Linux and others)

Hi, On 29.06.2016 15:03, Wayne Stambaugh wrote: > Sounds like we need separate installation instructions for Debian and > it's derivatives and the PPA and some helpful notes about the differences. I'm going to poke Jean-Samuel and Georges about this. It is a rather annoying state of affairs.

[Kicad-developers] [PATCH] Add FindSWIG.cmake from CMake 3.5 for swig 3.0 support

The FindSWIG.cmake shipped with CMake 3.0 does not yet look for the "cmake3.0" binary, this was added shortly after the 3.0 release. This file can be removed once the minimum CMake version is 3.1 or greater. --- CMakeModules/FindSWIG.cmake | 96 + 1

[Kicad-developers] [PATCH v2] Add FindSWIG.cmake from CMake 3.5 for swig 3.0 support

The FindSWIG.cmake shipped with CMake 3.0 does not yet look for the "cmake3.0" binary, this was added shortly after the 3.0 release. This file can be removed once the minimum CMake version is 3.1 or greater. --- CMakeModules/FindSWIG.cmake | 96 + 1

Re: [Kicad-developers] [PATCH v2] Add FindSWIG.cmake from CMake 3.5 for swig 3.0 support

Difference in v2: Drop the ".cmake" suffix on the included files so they are looked for on the full search path. That one only became apparent after I removed the build dir and re-configured the project. Simon signature.asc Description: OpenPGP digital signature

[Kicad-developers] [PATCH] Replace boost::shared_ptr with std::shared_ptr

This is a simple 1:1 replacement for all cases where shared_ptr is not used to point at an array (array handling is not in C++11). --- 3d-viewer/3d_mesh_model.h | 4 ++-- common/gal/opengl/opengl_gal.cpp | 2 +- common/geometry/hetriang.cpp | 34

Re: [Kicad-developers] [PATCH 5/5] Replace boost::shared_ptr with std::shared_ptr

Hi Wayne, On 29.06.2016 15:57, Wayne Stambaugh wrote: > I hate to ask you again but this patch no longer applies cleanly. > Please rebase it and resubmit it when you get a chance. No problem, that happens almost automatically with git. :) Simon signature.asc Description: OpenPGP digital

Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

Hi Wayne, On 29.06.2016 17:29, Wayne Stambaugh wrote: > This patch needs rebased as well. Please include the patch as an > attachment rather than inline. Bazaar doesn't play as nicely with > inline mail merges as git does. The "Rewrite loop conditions" one, or the "BOOST_FOREACH" one? The

[Kicad-developers] [PATCH 1/2] Rewrite loop conditions in SchematicCleanUp

These are a tiny bit more readable, and do not depend on all branches to correctly advance the loop variable. --- eeschema/sch_screen.cpp | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index

Re: [Kicad-developers] KiCad library installation (in Linux and others)

Hi, On 29.06.2016 11:26, Fabrizio Tappero wrote: > sudo apt-get install kicad > ​D > oing so kicad libs do not get installed and furthermore the version of > KiCad that you get will inevitably complain about libs not being installed > ​. S​ > ome people have complained about it. In Debian, you

<    1   2   3   4   5   6   7   8   9   >