Re: [Kicad-developers] [PATCH] Add progress reporting for GerbView file loading

It's dependent on the data in the files, which is why I decided to use the time based delay method. On my machine it normally doesn't show up, but a full set of Gerbers from a very large board is slow enough to show it. -Jon On Feb 21, 2018 00:07, "Andrey Kuznetsov" wrote:

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Yes, but not for 5.0. See https://bugs.launchpad.net/kicad/+bug/1748680 (most of the Kicad menu items will be app settings). But this reminds me that I should probably add a task to tabularize pcbnew’s preferences like we did with eeschema.

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Before you commit to that, I had wanted to make an argument in favor of tree view preferences instead of tabs. I think we will quickly exceed a reasonable number of tabs in order to accommodate having all the preferences in one place, especially given that we will only have more and more features

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

I’m not a fan of tree controls for preferences, but there’s also the compromise of a list + tabs (a la QTCreator). > On 21 Feb 2018, at 14:28, Jon Evans wrote: > > Before you commit to that, I had wanted to make an argument in favor of tree > view preferences instead of

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

List+Tabs can work well too. I just think we will benefit from multiple levels of hierarchy, and from having the first level of hierarchy be a vertical list that can have some kind of logical grouping (section headers, horizontal lines, etc) To be honest, I don't find Qt Creator to be a shining

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Yes, the JetBrains stuff did that too. I remember being quite a fan of it. > On 21 Feb 2018, at 14:42, Jon Evans wrote: > > List+Tabs can work well too. I just think we will benefit from multiple > levels of hierarchy, and from having the first level of hierarchy be a >

Re: [Kicad-developers] IPC-2581

I'm not opposed to KiCad taking part in this it's just a simple matter of lack of time. If someone else is interested in representing KiCad at these meetings, I would not be opposed to that it's just not going to be me. I am completely out of free time to do any more than my current work load.

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

Here's a patch that fixes the issues observed. I have changed the algorithm to a simpler one that should be more bulletproof. I think the optimal approach for complicated footprints is still not this way, but that would require more time to tweak and optimize (i.e. generating some kind of bounding

[Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Hi all, This patch rearranges the Render panel to be in a more logical order, and adds some whitespace. I divided it into three groupings: 1) footprint related 2) other board objects 3) non-board stuff like grid, ratlines, etc. I also bumped out the default size so that scrollbars aren't needed

Re: [Kicad-developers] IPC-2581

On Wed, Feb 21, 2018 at 3:37 PM, Wayne Stambaugh wrote: > I'm not opposed to KiCad taking part in this it's just a simple matter > of lack of time. If someone else is interested in representing KiCad at > these meetings, I would not be opposed to that it's just not going

[Kicad-developers] [PATCH] Don't recache items unnecessarily when toggling D-code display

Hi all, This patch improves the logic for d-code display in GerbView so that there is now no cost in toggling the codes on or off. They are still slow to render in huge files, but at least we only have the hit once when the file first is loaded. -Jon From

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

On 2018-02-21 15:08, Jeff Young wrote: > Yes, but not for 5.0. > > See https://bugs.launchpad.net/kicad/+bug/1748680 (most of the Kicad menu > items will be app settings). > > But this reminds me that I should probably add a task to tabularize pcbnew’s > preferences like we did with eeschema.

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

Andrzej, You have not replied to my last message about your original patch that you sent to the developers mailing list[1]. I need that one so I can apply and test the rest of your layer visibility patches. If you want these to make it into rc1, please send me this patch as an attachment soon.

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi, Just to mention… it has been like this before the patches. At least on macOS, there is still a “Preferences” menu entry below the “KiCad” menu bar entry (the “General Settings” dialog). Then, there is the “Preferences” menu… without those “General Setting”. Because there is a “Preferences”

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

But I notice it is broken on the macos nightly. It can not import the wx python module and hence we get an empty string for the toolkit from wxpython, (osx_cocoa vs ). http://ci.kicad-pcb.org/job/osx-kicad-adam-head/576/console 2018-02-20 23:55 GMT+01:00 Nick Østergaard : >

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

Gah, I would expect there is a consistent way to do the checks. I made the check Linux specific, as actually it is the only platform that can have wxWidgets built against different toolkits. Thanks for the report. Cheers, Orson On 02/21/2018 11:30 AM, Nick Østergaard wrote: > But I notice it is

Re: [Kicad-developers] IPC-2581

This might be a good time to discuss industry standards and how they are currently undergoing a massive change that the Kicad team could help with. Standards have in the past been created by large formal organizations like the IEEE for the entire industry.They were written in a very strict and

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

Seems to happen when there is no closed outline drawn in the footprint. Another test cases in an attachment. Andrzej W dniu 2018-02-21 o 17:41, Andrzej Wolski pisze: After this patch, I can no longer select some footprints by clicking inside their area. Please see the board in an attachment.

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

After this patch, I can no longer select some footprints by clicking inside their area. Please see the board in an attachment. Andrzej W dniu 2018-02-20 o 16:44, Wayne Stambaugh pisze: Jon, I merged your patch. Thanks, Wayne On 2/18/2018 7:01 PM, Jon Evans wrote: Hi Wayne, In my testing

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

Wayne, in attachment all 3 patches I have, rebased. Cheers, Andrzej On 02/21/2018 05:45 PM, Wayne Stambaugh wrote: Andrzej, This patch does not apply cleanly. Please rebase and resubmit it when you get a chance. Thanks, Wayne On 2/21/2018 11:27 AM, Andrzej Wolski wrote: Wayne, I have

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Bernhard, do you mean this bug [1] existed before the 3b085f0 "Pcbnew new menubar structure" commit? [1] https://bugs.launchpad.net/kicad/+bug/1750494 On 21 February 2018 at 13:07, Bernhard Stegmaier wrote: > Hi, > > Just to mention… it has been like this before the

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

If you could get it done by Friday before I roll out rc1, that's fine. Wayne On 2/21/2018 1:37 PM, Jon Evans wrote: > I'll be able to look at it this evening.  Can report then whether or not > I will have a patch tonight.  Up to you whether or not that is too long > of a delay. > > -Jon > > On

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

I can’t tell, I didn’t look for that bug. I didn’t follow the restructuring on the ML. My comment was just about the “Preferences” menu entry in KiCad menu. I did search it for some time before the restructuring and wondered a bit that it still like that after. > On 21. Feb 2018, at 19:13,

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

Jon, Would you please take a look at this as soon as possible? If you cannot get to it in a reasonable amount of time, please let me know so I can back out your polygon hit test patch. We need to be able to select footprints. Thanks, Wayne On 2/21/2018 11:41 AM, Andrzej Wolski wrote: > After

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

Andrzej, I merged your patches. Hopefully this will tamp down some of the layer visibility complaints. Thank you for your contribution to KiCad. Cheers, Wayne On 2/21/2018 12:44 PM, Andrzej Wolski wrote: > Wayne, > > in attachment all 3 patches I have, rebased. > > Cheers, > Andrzej > >

Re: [Kicad-developers] [PATCH] Add progress reporting for GerbView file loading

Patch merged. Thanks! On 2/20/2018 10:21 PM, Jon Evans wrote: > Hi all, > > This patch adds the progress reporter dialog to GerbView file loading, > when loading multiple files and the total load time goes over 1 second.  > I've also done some refactoring to share code between loading multiple

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

I'll be able to look at it this evening. Can report then whether or not I will have a patch tonight. Up to you whether or not that is too long of a delay. -Jon On Wed, Feb 21, 2018 at 1:32 PM, Wayne Stambaugh wrote: > Jon, > > Would you please take a look at this as