Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

​Sorry about the broke builds.  I've adjusted the FindOCE section to a
better override, restoring how it searched previously.  OpenCascade changes
should now only affect builds specifically requesting KICAD_USE_OCC.

-Seth



Am Di., 15. Mai 2018 um 05:42 Uhr schrieb Simon Richter <
simon.rich...@hogyros.de>:

> Hi,
>
> On 15.05.2018 10:40, Nick Østergaard wrote:
>
> > The occ patch makes the build fail on macos when enabling oce. I don't
> > understanf why the error message suggest the occ path instead of the occ
> > one. Also I don't understand why the defualt would not work as before.
>
> FWIW, it also makes MSVC builds fail as the script only looks at the
> registry to find OCE, not at -DOCE_DIR=...
>
> Even if OCE paths are stored in the registry, this seems to be lacking
> 32/64 bit distinction, so the upstream script needs to be improved as well.
>
>Simon
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Simon Richter]

Hi,

On 15.05.2018 10:40, Nick Østergaard wrote:

> The occ patch makes the build fail on macos when enabling oce. I don't
> understanf why the error message suggest the occ path instead of the occ
> one. Also I don't understand why the defualt would not work as before.

FWIW, it also makes MSVC builds fail as the script only looks at the
registry to find OCE, not at -DOCE_DIR=...

Even if OCE paths are stored in the registry, this seems to be lacking
32/64 bit distinction, so the upstream script needs to be improved as well.

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Nick Østergaard]

The occ patch makes the build fail on macos when enabling oce. I don't
understanf why the error message suggest the occ path instead of the occ
one. Also I don't understand why the defualt would not work as before.

http://ci.kicad-pcb.org/job/osx-kicad-adam-head/659/console


tir. 20. mar. 2018 00.50 skrev Seth Hillbrand :

> Nick, as always, thanks for the detailed helpful comments.  To specify the
> installation, we will need to set -DOCC_LIBRARY_DIR and -DOCC_INCLUDE_DIR.
> That works on my machine and the docker file.
>
> I'll implement your suggestions and give people another few days to test
> if they're interested in this topic before merging.
>
> Best-
> Seth
>
> 2018-03-18 15:57 GMT-07:00 Nick Østergaard :
>
>> Hi Seth,
>>
>> I tried to test your patch. It bascially works. Some observations follows:
>>
>> I think the message printed from cmake
>> "from /opt/oce/lib/libTKernel.so I found /opt/oce/lib"
>> should be removed from the output, it looks liek a debug message to me. I
>> guess the same information is available in the CMakeCache.txt if needed
>> later on.
>>
>> It defaults to OCE as expected, builds, and runs.
>>
>> If I remove OCE it will find my normal opencascade installation, builds
>> and runs.
>>
>> I think it also did use OCC if I set KICAD_USE_OCC=ON, where it built and
>> ran fine. But when this happens I still see KICAD_USE_OCE=ON in the cache.
>> This might be ok, but could be confusing.
>>
>> I canẗ make it use an alterntive install location of OCC, I tried to set
>> OCC_INCLUDE_DIR=/opt/opencascade7/inc. This fails. What variable do I need
>> to set to select another version of opencascade?
>>
>> I tested this on archlinux. I think it could be improved to be less
>> errorprone, but could possibly be comitted as is if that debug log is
>> removed. It seems to work fine if you are not switching between OCE and OCC
>> in the same build dir, that is, a clean config.
>>
>> Nick
>>
>>
>> 2018-03-17 0:51 GMT+01:00 Nick Østergaard :
>>
>>> Thank you very much, I will try to remember it after the weekend.
>>>
>>> 2018-03-17 <20%2018%2003%2017> 0:46 GMT+01:00 Seth Hillbrand <
>>> seth.hillbr...@gmail.com>:
>>>
 Hi Nick-

 I finally found a moment to figure out Docker and get this up and
 running in your build configuration.

 Please take a look when you have a chance and let me know if you have
 any issues with this patch.

 Best-
 Seth

 2018-02-10 <20%2018%2002%2010> 7:12 GMT-08:00 Seth Hillbrand <
 seth.hillbr...@gmail.com>:

> Nick was having an unknown issue but I haven't heard back from him on
> whether the issue was resolved by doing a clean cmake.  If it isn't then
> I'll need to address that.
>
> Nick did you have a chance to test that?
>
> -S
>
> 2018-02-10 <20%2018%2002%2010> 6:18 GMT-08:00 Wayne Stambaugh <
> stambau...@gmail.com>:
>
>> Seth,
>>
>> What is the current status of this patch?  I would like to get it
>> merged
>> before rc1 so the package devs can test it.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
>> > Nick-
>> >
>> > Thanks for the test.  I'm attaching revised patch that allows
>> multiple
>> > OpenCASCADE installations on a single machine.
>> >
>> > I've tested with a few different OpenCASCADE versions down to 6.8
>> with
>> > no issues installed alongside OCE 0.17.  You can choose which you
>> want
>> > to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If
>> both
>> > are specified, "-DKICAD_USE_OCC" will override.
>> >
>> > I corrected the cmake message display to be less doubled and
>> correctly
>> > show the library location.
>> >
>> > I've also added the OCC version and type to the about window
>> version info.
>> >
>> > The "Based on" line was taken from
>> > (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h)
>> when
>> > trying to determine how FreeCAD likes to refer to themselves.  The
>> > actual FindOpenCascade.cmake file did not have a copyright header
>> > attached but falls under the license from
>> > (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note
>> that I
>> > had it written as "FreeCAD CADx development system".  I've corrected
>> > this to read "FreeCAD CAx development system".
>> >
>> > I'm not sure to what the "CheckSymbolExists" line is referring.  I
>> don't
>> > see it on my machine.
>> >
>> > -Seth
>> >
>> > 2018-01-29 14:30 GMT-08:00 Nick Østergaard > > >:
>> >
>> > Hi Seth,
>> >
>> > I just took the patch for a testrun and will state some
>> comments below.
>> >
>> > This looks a bit strange:
>> >
>> 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Nick, as always, thanks for the detailed helpful comments.  To specify the
installation, we will need to set -DOCC_LIBRARY_DIR and -DOCC_INCLUDE_DIR.
That works on my machine and the docker file.

I'll implement your suggestions and give people another few days to test if
they're interested in this topic before merging.

Best-
Seth

2018-03-18 15:57 GMT-07:00 Nick Østergaard :

> Hi Seth,
>
> I tried to test your patch. It bascially works. Some observations follows:
>
> I think the message printed from cmake
> "from /opt/oce/lib/libTKernel.so I found /opt/oce/lib"
> should be removed from the output, it looks liek a debug message to me. I
> guess the same information is available in the CMakeCache.txt if needed
> later on.
>
> It defaults to OCE as expected, builds, and runs.
>
> If I remove OCE it will find my normal opencascade installation, builds
> and runs.
>
> I think it also did use OCC if I set KICAD_USE_OCC=ON, where it built and
> ran fine. But when this happens I still see KICAD_USE_OCE=ON in the cache.
> This might be ok, but could be confusing.
>
> I canẗ make it use an alterntive install location of OCC, I tried to set
> OCC_INCLUDE_DIR=/opt/opencascade7/inc. This fails. What variable do I
> need to set to select another version of opencascade?
>
> I tested this on archlinux. I think it could be improved to be less
> errorprone, but could possibly be comitted as is if that debug log is
> removed. It seems to work fine if you are not switching between OCE and OCC
> in the same build dir, that is, a clean config.
>
> Nick
>
>
> 2018-03-17 0:51 GMT+01:00 Nick Østergaard :
>
>> Thank you very much, I will try to remember it after the weekend.
>>
>> 2018-03-17 <20%2018%2003%2017> 0:46 GMT+01:00 Seth Hillbrand <
>> seth.hillbr...@gmail.com>:
>>
>>> Hi Nick-
>>>
>>> I finally found a moment to figure out Docker and get this up and
>>> running in your build configuration.
>>>
>>> Please take a look when you have a chance and let me know if you have
>>> any issues with this patch.
>>>
>>> Best-
>>> Seth
>>>
>>> 2018-02-10 <20%2018%2002%2010> 7:12 GMT-08:00 Seth Hillbrand <
>>> seth.hillbr...@gmail.com>:
>>>
 Nick was having an unknown issue but I haven't heard back from him on
 whether the issue was resolved by doing a clean cmake.  If it isn't then
 I'll need to address that.

 Nick did you have a chance to test that?

 -S

 2018-02-10 <20%2018%2002%2010> 6:18 GMT-08:00 Wayne Stambaugh <
 stambau...@gmail.com>:

> Seth,
>
> What is the current status of this patch?  I would like to get it
> merged
> before rc1 so the package devs can test it.
>
> Cheers,
>
> Wayne
>
> On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
> > Nick-
> >
> > Thanks for the test.  I'm attaching revised patch that allows
> multiple
> > OpenCASCADE installations on a single machine.
> >
> > I've tested with a few different OpenCASCADE versions down to 6.8
> with
> > no issues installed alongside OCE 0.17.  You can choose which you
> want
> > to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If
> both
> > are specified, "-DKICAD_USE_OCC" will override.
> >
> > I corrected the cmake message display to be less doubled and
> correctly
> > show the library location.
> >
> > I've also added the OCC version and type to the about window version
> info.
> >
> > The "Based on" line was taken from
> > (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h) when
> > trying to determine how FreeCAD likes to refer to themselves.  The
> > actual FindOpenCascade.cmake file did not have a copyright header
> > attached but falls under the license from
> > (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note
> that I
> > had it written as "FreeCAD CADx development system".  I've corrected
> > this to read "FreeCAD CAx development system".
> >
> > I'm not sure to what the "CheckSymbolExists" line is referring.  I
> don't
> > see it on my machine.
> >
> > -Seth
> >
> > 2018-01-29 14:30 GMT-08:00 Nick Østergaard  > >:
> >
> > Hi Seth,
> >
> > I just took the patch for a testrun and will state some comments
> below.
> >
> > This looks a bit strange:
> >
> > -- Boost version: 1.66.0
> > -- -- OpenCASCADE Community Edition has been found.
> > -- -- Found OCE/OpenCASCADE version: 6.8.0
> > -- -- OCE/OpenCASCADE include directory:
> > /opt/oce/lib/oce-0.17/../../include/oce
> > -- -- OCE/OpenCASCADE shared libraries directory:
> > -- Check for installed Python Interpreter -- found
> >
> > The messages are with double -- and the shared libs.
> >
> > But an improvement with your 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Nick Østergaard]

Hi Seth,

I tried to test your patch. It bascially works. Some observations follows:

I think the message printed from cmake
"from /opt/oce/lib/libTKernel.so I found /opt/oce/lib"
should be removed from the output, it looks liek a debug message to me. I
guess the same information is available in the CMakeCache.txt if needed
later on.

It defaults to OCE as expected, builds, and runs.

If I remove OCE it will find my normal opencascade installation, builds and
runs.

I think it also did use OCC if I set KICAD_USE_OCC=ON, where it built and
ran fine. But when this happens I still see KICAD_USE_OCE=ON in the cache.
This might be ok, but could be confusing.

I canẗ make it use an alterntive install location of OCC, I tried to set
OCC_INCLUDE_DIR=/opt/opencascade7/inc. This fails. What variable do I need
to set to select another version of opencascade?

I tested this on archlinux. I think it could be improved to be less
errorprone, but could possibly be comitted as is if that debug log is
removed. It seems to work fine if you are not switching between OCE and OCC
in the same build dir, that is, a clean config.

Nick

2018-03-17 0:51 GMT+01:00 Nick Østergaard :

> Thank you very much, I will try to remember it after the weekend.
>
> 2018-03-17 <20%2018%2003%2017> 0:46 GMT+01:00 Seth Hillbrand <
> seth.hillbr...@gmail.com>:
>
>> Hi Nick-
>>
>> I finally found a moment to figure out Docker and get this up and running
>> in your build configuration.
>>
>> Please take a look when you have a chance and let me know if you have any
>> issues with this patch.
>>
>> Best-
>> Seth
>>
>> 2018-02-10 <20%2018%2002%2010> 7:12 GMT-08:00 Seth Hillbrand <
>> seth.hillbr...@gmail.com>:
>>
>>> Nick was having an unknown issue but I haven't heard back from him on
>>> whether the issue was resolved by doing a clean cmake.  If it isn't then
>>> I'll need to address that.
>>>
>>> Nick did you have a chance to test that?
>>>
>>> -S
>>>
>>> 2018-02-10 <20%2018%2002%2010> 6:18 GMT-08:00 Wayne Stambaugh <
>>> stambau...@gmail.com>:
>>>
 Seth,

 What is the current status of this patch?  I would like to get it merged
 before rc1 so the package devs can test it.

 Cheers,

 Wayne

 On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
 > Nick-
 >
 > Thanks for the test.  I'm attaching revised patch that allows multiple
 > OpenCASCADE installations on a single machine.
 >
 > I've tested with a few different OpenCASCADE versions down to 6.8 with
 > no issues installed alongside OCE 0.17.  You can choose which you want
 > to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If
 both
 > are specified, "-DKICAD_USE_OCC" will override.
 >
 > I corrected the cmake message display to be less doubled and correctly
 > show the library location.
 >
 > I've also added the OCC version and type to the about window version
 info.
 >
 > The "Based on" line was taken from
 > (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h) when
 > trying to determine how FreeCAD likes to refer to themselves.  The
 > actual FindOpenCascade.cmake file did not have a copyright header
 > attached but falls under the license from
 > (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note
 that I
 > had it written as "FreeCAD CADx development system".  I've corrected
 > this to read "FreeCAD CAx development system".
 >
 > I'm not sure to what the "CheckSymbolExists" line is referring.  I
 don't
 > see it on my machine.
 >
 > -Seth
 >
 > 2018-01-29 14:30 GMT-08:00 Nick Østergaard  >:
 >
 > Hi Seth,
 >
 > I just took the patch for a testrun and will state some comments
 below.
 >
 > This looks a bit strange:
 >
 > -- Boost version: 1.66.0
 > -- -- OpenCASCADE Community Edition has been found.
 > -- -- Found OCE/OpenCASCADE version: 6.8.0
 > -- -- OCE/OpenCASCADE include directory:
 > /opt/oce/lib/oce-0.17/../../include/oce
 > -- -- OCE/OpenCASCADE shared libraries directory:
 > -- Check for installed Python Interpreter -- found
 >
 > The messages are with double -- and the shared libs.
 >
 > But an improvement with your patch over what is currently in kicad
 > is that it found OCE on my system without explicitly specifind
 > OCE_DIR. But how do I make it use OCCT when I also have OCE
 installed?
 >
 > What does CADx mean in that header?
 >
 > What is this about?
 > -- Looking for
 > /home/amazingdude/kicad-source-mirror/build_seths_occt_patc
 h_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
 > -- Looking for
 > /home/amazingdude/kicad-source-mirror/build_seths_occt_patc
 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Nick Østergaard]

Thank you very much, I will try to remember it after the weekend.

2018-03-17 0:46 GMT+01:00 Seth Hillbrand :

> Hi Nick-
>
> I finally found a moment to figure out Docker and get this up and running
> in your build configuration.
>
> Please take a look when you have a chance and let me know if you have any
> issues with this patch.
>
> Best-
> Seth
>
> 2018-02-10 <20%2018%2002%2010> 7:12 GMT-08:00 Seth Hillbrand <
> seth.hillbr...@gmail.com>:
>
>> Nick was having an unknown issue but I haven't heard back from him on
>> whether the issue was resolved by doing a clean cmake.  If it isn't then
>> I'll need to address that.
>>
>> Nick did you have a chance to test that?
>>
>> -S
>>
>> 2018-02-10 <20%2018%2002%2010> 6:18 GMT-08:00 Wayne Stambaugh <
>> stambau...@gmail.com>:
>>
>>> Seth,
>>>
>>> What is the current status of this patch?  I would like to get it merged
>>> before rc1 so the package devs can test it.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
>>> > Nick-
>>> >
>>> > Thanks for the test.  I'm attaching revised patch that allows multiple
>>> > OpenCASCADE installations on a single machine.
>>> >
>>> > I've tested with a few different OpenCASCADE versions down to 6.8 with
>>> > no issues installed alongside OCE 0.17.  You can choose which you want
>>> > to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If
>>> both
>>> > are specified, "-DKICAD_USE_OCC" will override.
>>> >
>>> > I corrected the cmake message display to be less doubled and correctly
>>> > show the library location.
>>> >
>>> > I've also added the OCC version and type to the about window version
>>> info.
>>> >
>>> > The "Based on" line was taken from
>>> > (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h) when
>>> > trying to determine how FreeCAD likes to refer to themselves.  The
>>> > actual FindOpenCascade.cmake file did not have a copyright header
>>> > attached but falls under the license from
>>> > (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note
>>> that I
>>> > had it written as "FreeCAD CADx development system".  I've corrected
>>> > this to read "FreeCAD CAx development system".
>>> >
>>> > I'm not sure to what the "CheckSymbolExists" line is referring.  I
>>> don't
>>> > see it on my machine.
>>> >
>>> > -Seth
>>> >
>>> > 2018-01-29 14:30 GMT-08:00 Nick Østergaard >> > >:
>>> >
>>> > Hi Seth,
>>> >
>>> > I just took the patch for a testrun and will state some comments
>>> below.
>>> >
>>> > This looks a bit strange:
>>> >
>>> > -- Boost version: 1.66.0
>>> > -- -- OpenCASCADE Community Edition has been found.
>>> > -- -- Found OCE/OpenCASCADE version: 6.8.0
>>> > -- -- OCE/OpenCASCADE include directory:
>>> > /opt/oce/lib/oce-0.17/../../include/oce
>>> > -- -- OCE/OpenCASCADE shared libraries directory:
>>> > -- Check for installed Python Interpreter -- found
>>> >
>>> > The messages are with double -- and the shared libs.
>>> >
>>> > But an improvement with your patch over what is currently in kicad
>>> > is that it found OCE on my system without explicitly specifind
>>> > OCE_DIR. But how do I make it use OCCT when I also have OCE
>>> installed?
>>> >
>>> > What does CADx mean in that header?
>>> >
>>> > What is this about?
>>> > -- Looking for
>>> > /home/amazingdude/kicad-source-mirror/build_seths_occt_patc
>>> h_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
>>> > -- Looking for
>>> > /home/amazingdude/kicad-source-mirror/build_seths_occt_patc
>>> h_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
>>> > - not found
>>> >
>>> > I tried to test it with removing oce and just have occt installed
>>> > and got something like this:
>>> > -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
>>> > -- -- Found OCE/OpenCASCADE version: 6.9.1
>>> > -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
>>> > -- -- OCE/OpenCASCADE shared libraries directory:
>>> /opt/opencascade/lib
>>> >
>>> > It did not build against community/opencascade 6.9.1-7. I got the
>>> > following error in a clean build dir.
>>> >
>>> > $ make kicad2step -j1
>>> > [  0%] Linking CXX executable kicad2step
>>> > /usr/bin/ld: cannot find -lTKMesh
>>> > /usr/bin/ld: cannot find -lTKernel
>>> > /usr/bin/ld: cannot find -lTKG2d
>>> > /usr/bin/ld: cannot find -lTKG3d
>>> > /usr/bin/ld: cannot find -lTKMath
>>> > /usr/bin/ld: cannot find -lTKIGES
>>> > /usr/bin/ld: cannot find -lTKSTL
>>> > /usr/bin/ld: cannot find -lTKXSBase
>>> > /usr/bin/ld: cannot find -lTKBin
>>> > /usr/bin/ld: cannot find -lTKBO
>>> > /usr/bin/ld: cannot find -lTKCDF
>>> > /usr/bin/ld: cannot find -lTKBRep
>>> > /usr/bin/ld: cannot find -lTKTopAlgo
>>> > /usr/bin/ld: cannot find -lTKGeomAlgo
>>> > /usr/bin/ld: cannot find -lTKGeomBase
>>> 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Nick-

I finally found a moment to figure out Docker and get this up and running
in your build configuration.

Please take a look when you have a chance and let me know if you have any
issues with this patch.

Best-
Seth

2018-02-10 7:12 GMT-08:00 Seth Hillbrand :

> Nick was having an unknown issue but I haven't heard back from him on
> whether the issue was resolved by doing a clean cmake.  If it isn't then
> I'll need to address that.
>
> Nick did you have a chance to test that?
>
> -S
>
> 2018-02-10 6:18 GMT-08:00 Wayne Stambaugh :
>
>> Seth,
>>
>> What is the current status of this patch?  I would like to get it merged
>> before rc1 so the package devs can test it.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
>> > Nick-
>> >
>> > Thanks for the test.  I'm attaching revised patch that allows multiple
>> > OpenCASCADE installations on a single machine.
>> >
>> > I've tested with a few different OpenCASCADE versions down to 6.8 with
>> > no issues installed alongside OCE 0.17.  You can choose which you want
>> > to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If both
>> > are specified, "-DKICAD_USE_OCC" will override.
>> >
>> > I corrected the cmake message display to be less doubled and correctly
>> > show the library location.
>> >
>> > I've also added the OCC version and type to the about window version
>> info.
>> >
>> > The "Based on" line was taken from
>> > (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h) when
>> > trying to determine how FreeCAD likes to refer to themselves.  The
>> > actual FindOpenCascade.cmake file did not have a copyright header
>> > attached but falls under the license from
>> > (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note that
>> I
>> > had it written as "FreeCAD CADx development system".  I've corrected
>> > this to read "FreeCAD CAx development system".
>> >
>> > I'm not sure to what the "CheckSymbolExists" line is referring.  I don't
>> > see it on my machine.
>> >
>> > -Seth
>> >
>> > 2018-01-29 14:30 GMT-08:00 Nick Østergaard > > >:
>> >
>> > Hi Seth,
>> >
>> > I just took the patch for a testrun and will state some comments
>> below.
>> >
>> > This looks a bit strange:
>> >
>> > -- Boost version: 1.66.0
>> > -- -- OpenCASCADE Community Edition has been found.
>> > -- -- Found OCE/OpenCASCADE version: 6.8.0
>> > -- -- OCE/OpenCASCADE include directory:
>> > /opt/oce/lib/oce-0.17/../../include/oce
>> > -- -- OCE/OpenCASCADE shared libraries directory:
>> > -- Check for installed Python Interpreter -- found
>> >
>> > The messages are with double -- and the shared libs.
>> >
>> > But an improvement with your patch over what is currently in kicad
>> > is that it found OCE on my system without explicitly specifind
>> > OCE_DIR. But how do I make it use OCCT when I also have OCE
>> installed?
>> >
>> > What does CADx mean in that header?
>> >
>> > What is this about?
>> > -- Looking for
>> > /home/amazingdude/kicad-source-mirror/build_seths_occt_
>> patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
>> > -- Looking for
>> > /home/amazingdude/kicad-source-mirror/build_seths_occt_
>> patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
>> > - not found
>> >
>> > I tried to test it with removing oce and just have occt installed
>> > and got something like this:
>> > -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
>> > -- -- Found OCE/OpenCASCADE version: 6.9.1
>> > -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
>> > -- -- OCE/OpenCASCADE shared libraries directory:
>> /opt/opencascade/lib
>> >
>> > It did not build against community/opencascade 6.9.1-7. I got the
>> > following error in a clean build dir.
>> >
>> > $ make kicad2step -j1
>> > [  0%] Linking CXX executable kicad2step
>> > /usr/bin/ld: cannot find -lTKMesh
>> > /usr/bin/ld: cannot find -lTKernel
>> > /usr/bin/ld: cannot find -lTKG2d
>> > /usr/bin/ld: cannot find -lTKG3d
>> > /usr/bin/ld: cannot find -lTKMath
>> > /usr/bin/ld: cannot find -lTKIGES
>> > /usr/bin/ld: cannot find -lTKSTL
>> > /usr/bin/ld: cannot find -lTKXSBase
>> > /usr/bin/ld: cannot find -lTKBin
>> > /usr/bin/ld: cannot find -lTKBO
>> > /usr/bin/ld: cannot find -lTKCDF
>> > /usr/bin/ld: cannot find -lTKBRep
>> > /usr/bin/ld: cannot find -lTKTopAlgo
>> > /usr/bin/ld: cannot find -lTKGeomAlgo
>> > /usr/bin/ld: cannot find -lTKGeomBase
>> > /usr/bin/ld: cannot find -lTKPrim
>> > /usr/bin/ld: cannot find -lTKSTEP
>> > /usr/bin/ld: cannot find -lTKSTEPBase
>> > /usr/bin/ld: cannot find -lTKSTEPAttr
>> > /usr/bin/ld: cannot find -lTKFeat
>> > /usr/bin/ld: cannot find -lTKCAF
>> > /usr/bin/ld: cannot find -lTKXCAF
>> > /usr/bin/ld: 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Nick was having an unknown issue but I haven't heard back from him on
whether the issue was resolved by doing a clean cmake.  If it isn't then
I'll need to address that.

Nick did you have a chance to test that?

-S

2018-02-10 6:18 GMT-08:00 Wayne Stambaugh :

> Seth,
>
> What is the current status of this patch?  I would like to get it merged
> before rc1 so the package devs can test it.
>
> Cheers,
>
> Wayne
>
> On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
> > Nick-
> >
> > Thanks for the test.  I'm attaching revised patch that allows multiple
> > OpenCASCADE installations on a single machine.
> >
> > I've tested with a few different OpenCASCADE versions down to 6.8 with
> > no issues installed alongside OCE 0.17.  You can choose which you want
> > to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If both
> > are specified, "-DKICAD_USE_OCC" will override.
> >
> > I corrected the cmake message display to be less doubled and correctly
> > show the library location.
> >
> > I've also added the OCC version and type to the about window version
> info.
> >
> > The "Based on" line was taken from
> > (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h) when
> > trying to determine how FreeCAD likes to refer to themselves.  The
> > actual FindOpenCascade.cmake file did not have a copyright header
> > attached but falls under the license from
> > (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note that I
> > had it written as "FreeCAD CADx development system".  I've corrected
> > this to read "FreeCAD CAx development system".
> >
> > I'm not sure to what the "CheckSymbolExists" line is referring.  I don't
> > see it on my machine.
> >
> > -Seth
> >
> > 2018-01-29 14:30 GMT-08:00 Nick Østergaard  > >:
> >
> > Hi Seth,
> >
> > I just took the patch for a testrun and will state some comments
> below.
> >
> > This looks a bit strange:
> >
> > -- Boost version: 1.66.0
> > -- -- OpenCASCADE Community Edition has been found.
> > -- -- Found OCE/OpenCASCADE version: 6.8.0
> > -- -- OCE/OpenCASCADE include directory:
> > /opt/oce/lib/oce-0.17/../../include/oce
> > -- -- OCE/OpenCASCADE shared libraries directory:
> > -- Check for installed Python Interpreter -- found
> >
> > The messages are with double -- and the shared libs.
> >
> > But an improvement with your patch over what is currently in kicad
> > is that it found OCE on my system without explicitly specifind
> > OCE_DIR. But how do I make it use OCCT when I also have OCE
> installed?
> >
> > What does CADx mean in that header?
> >
> > What is this about?
> > -- Looking for
> > /home/amazingdude/kicad-source-mirror/build_seths_
> occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
> > -- Looking for
> > /home/amazingdude/kicad-source-mirror/build_seths_
> occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
> > - not found
> >
> > I tried to test it with removing oce and just have occt installed
> > and got something like this:
> > -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
> > -- -- Found OCE/OpenCASCADE version: 6.9.1
> > -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
> > -- -- OCE/OpenCASCADE shared libraries directory:
> /opt/opencascade/lib
> >
> > It did not build against community/opencascade 6.9.1-7. I got the
> > following error in a clean build dir.
> >
> > $ make kicad2step -j1
> > [  0%] Linking CXX executable kicad2step
> > /usr/bin/ld: cannot find -lTKMesh
> > /usr/bin/ld: cannot find -lTKernel
> > /usr/bin/ld: cannot find -lTKG2d
> > /usr/bin/ld: cannot find -lTKG3d
> > /usr/bin/ld: cannot find -lTKMath
> > /usr/bin/ld: cannot find -lTKIGES
> > /usr/bin/ld: cannot find -lTKSTL
> > /usr/bin/ld: cannot find -lTKXSBase
> > /usr/bin/ld: cannot find -lTKBin
> > /usr/bin/ld: cannot find -lTKBO
> > /usr/bin/ld: cannot find -lTKCDF
> > /usr/bin/ld: cannot find -lTKBRep
> > /usr/bin/ld: cannot find -lTKTopAlgo
> > /usr/bin/ld: cannot find -lTKGeomAlgo
> > /usr/bin/ld: cannot find -lTKGeomBase
> > /usr/bin/ld: cannot find -lTKPrim
> > /usr/bin/ld: cannot find -lTKSTEP
> > /usr/bin/ld: cannot find -lTKSTEPBase
> > /usr/bin/ld: cannot find -lTKSTEPAttr
> > /usr/bin/ld: cannot find -lTKFeat
> > /usr/bin/ld: cannot find -lTKCAF
> > /usr/bin/ld: cannot find -lTKXCAF
> > /usr/bin/ld: cannot find -lTKLCAF
> > /usr/bin/ld: cannot find -lTKXDESTEP
> > /usr/bin/ld: cannot find -lTKXDEIGES
> > collect2: error: ld returned 1 exit status
> > make[3]: ***
> > [utils/kicad2step/CMakeFiles/kicad2step.dir/build.make:355:
> > utils/kicad2step/kicad2step] Error 1
> > make[2]: *** [CMakeFiles/Makefile2:3007:
> > utils/kicad2step/CMakeFiles/kicad2step.dir/all] Error 2
> > make[1]: 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Wayne Stambaugh]

Seth,

What is the current status of this patch?  I would like to get it merged
before rc1 so the package devs can test it.

Cheers,

Wayne

On 01/30/2018 02:12 PM, Seth Hillbrand wrote:
> Nick-
> 
> Thanks for the test.  I'm attaching revised patch that allows multiple
> OpenCASCADE installations on a single machine.
> 
> I've tested with a few different OpenCASCADE versions down to 6.8 with
> no issues installed alongside OCE 0.17.  You can choose which you want
> to link by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If both
> are specified, "-DKICAD_USE_OCC" will override.  
> 
> I corrected the cmake message display to be less doubled and correctly
> show the library location.
> 
> I've also added the OCC version and type to the about window version info.
> 
> The "Based on" line was taken from
> (https://github.com/FreeCAD/FreeCAD/blob/master/src/FCConfig.h) when
> trying to determine how FreeCAD likes to refer to themselves.  The
> actual FindOpenCascade.cmake file did not have a copyright header
> attached but falls under the license from
> (https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note that I
> had it written as "FreeCAD CADx development system".  I've corrected
> this to read "FreeCAD CAx development system".
> 
> I'm not sure to what the "CheckSymbolExists" line is referring.  I don't
> see it on my machine.
> 
> -Seth
> 
> 2018-01-29 14:30 GMT-08:00 Nick Østergaard  >:
> 
> Hi Seth,
> 
> I just took the patch for a testrun and will state some comments below.
> 
> This looks a bit strange:
> 
> -- Boost version: 1.66.0
> -- -- OpenCASCADE Community Edition has been found.
> -- -- Found OCE/OpenCASCADE version: 6.8.0
> -- -- OCE/OpenCASCADE include directory:
> /opt/oce/lib/oce-0.17/../../include/oce
> -- -- OCE/OpenCASCADE shared libraries directory:
> -- Check for installed Python Interpreter -- found
> 
> The messages are with double -- and the shared libs.
> 
> But an improvement with your patch over what is currently in kicad
> is that it found OCE on my system without explicitly specifind
> OCE_DIR. But how do I make it use OCCT when I also have OCE installed?
> 
> What does CADx mean in that header?
> 
> What is this about?
> -- Looking for
> 
> /home/amazingdude/kicad-source-mirror/build_seths_occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
> -- Looking for
> 
> /home/amazingdude/kicad-source-mirror/build_seths_occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
> - not found
> 
> I tried to test it with removing oce and just have occt installed
> and got something like this:
> -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
> -- -- Found OCE/OpenCASCADE version: 6.9.1
> -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
> -- -- OCE/OpenCASCADE shared libraries directory: /opt/opencascade/lib
> 
> It did not build against community/opencascade 6.9.1-7. I got the
> following error in a clean build dir.
> 
> $ make kicad2step -j1
> [  0%] Linking CXX executable kicad2step
> /usr/bin/ld: cannot find -lTKMesh
> /usr/bin/ld: cannot find -lTKernel
> /usr/bin/ld: cannot find -lTKG2d
> /usr/bin/ld: cannot find -lTKG3d
> /usr/bin/ld: cannot find -lTKMath
> /usr/bin/ld: cannot find -lTKIGES
> /usr/bin/ld: cannot find -lTKSTL
> /usr/bin/ld: cannot find -lTKXSBase
> /usr/bin/ld: cannot find -lTKBin
> /usr/bin/ld: cannot find -lTKBO
> /usr/bin/ld: cannot find -lTKCDF
> /usr/bin/ld: cannot find -lTKBRep
> /usr/bin/ld: cannot find -lTKTopAlgo
> /usr/bin/ld: cannot find -lTKGeomAlgo
> /usr/bin/ld: cannot find -lTKGeomBase
> /usr/bin/ld: cannot find -lTKPrim
> /usr/bin/ld: cannot find -lTKSTEP
> /usr/bin/ld: cannot find -lTKSTEPBase
> /usr/bin/ld: cannot find -lTKSTEPAttr
> /usr/bin/ld: cannot find -lTKFeat
> /usr/bin/ld: cannot find -lTKCAF
> /usr/bin/ld: cannot find -lTKXCAF
> /usr/bin/ld: cannot find -lTKLCAF
> /usr/bin/ld: cannot find -lTKXDESTEP
> /usr/bin/ld: cannot find -lTKXDEIGES
> collect2: error: ld returned 1 exit status
> make[3]: ***
> [utils/kicad2step/CMakeFiles/kicad2step.dir/build.make:355:
> utils/kicad2step/kicad2step] Error 1
> make[2]: *** [CMakeFiles/Makefile2:3007:
> utils/kicad2step/CMakeFiles/kicad2step.dir/all] Error 2
> make[1]: *** [CMakeFiles/Makefile2:3019:
> utils/kicad2step/CMakeFiles/kicad2step.dir/rule] Error 2
> make: *** [Makefile:979: kicad2step] Error 2
> 
> But those libs do existm, searched for the last one;
> $ yaourt  -Ql opencascade | grep TKXDEIGES
> opencascade /opt/opencascade/lib/libTKXDEIGES.so
> opencascade /opt/opencascade/lib/libTKXDEIGES.so.0
> opencascade /opt/opencascade/lib/libTKXDEIGES.so.0.0.0
> 
> I got these variables set in the CMakeCache
> 
> cat 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Thomas-

That makes sense.  The REGEX fails because you haven't installed
OpenCascade.  You've only built it.  When you install it,
Standard_Version.hxx will be correct and the REGEX will match.  In the
build directory, it only includes the header from the source directory.

I suspect (but haven't tested yet) that the library linking issue will also
be resolved by a full install.

-S

2018-02-08 9:10 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:

> I’ve attached the output from when I try to configure with the original
> file.
>
> The version checking didn’t work for 7.1 for me either. It should be
> noted, that
>
> I built OpenCascade from source, and I’ve tried to manually change it to
> point
>
> to the Standard_Version header, but it still doesn’t parse it correctly
> with the same
>
> error outputted.
>
>
>
> -Thomas
>
>
>
> *From:* Seth Hillbrand <seth.hillbr...@gmail.com>
> *Sent:* Thursday, February 08, 2018 10:49 AM
> *To:* Thomas Figueroa <tom_figue...@hotmail.com>
>
> *Cc:* kicad-developers@lists.launchpad.net
> *Subject:* Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard
> edition
>
>
>
> Hi Thomas-
>
>
>
> I will add this library to the include.  Odd that it wasn't required on
> Linux.  Can you send me your CMakeOutput.log?  The version checking is
> pretty important and those files don't change, so I'd like to track down
> why it would work for 7.1 but not for 7.2.
>
>
>
> -S
>
>
>
> 2018-02-08 7:29 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:
>
> Hey Seth,
>
>
>
> Working great with OpenCascade 7.2! I had to modify the Cmake file, though,
>
> to include TKV3d in the library list. I get unresolved external link
> errors when compiling
>
> s3d_plugin_oce otherwise (unresolved symbols SelectMgr_Selection,
> PrsMgr_PresentableObject, and AIS_InteractiveObject respectively).
>
> I also had to remove the version checking, as it was unable to get the
> version via regex matching for some reason.
>
>
>
> -Thomas
>
>
>
>
>
> *From: *Seth Hillbrand <seth.hillbr...@gmail.com>
> *Sent: *Tuesday, February 6, 2018 2:34 PM
> *To: *kicad-developers@lists.launchpad.net
>
>
> *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard
> edition
>
>
>
> I've updated this to allow use of OpenCascade 7.2 as well.
>
>
>
> Nick, I added a few more helpful error messages to CMake file.  Let me
> know if you are still seeing the configure error with a clean cmake.
>
>
>
> -Seth
>
>
>
> 2018-02-02 12:47 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:
>
> Hey Seth,
>
>
>
> I was able to successfully use OpenCascade 7.1 and export using kicad2step!
>
>
>
> Now to find out why…
>
>
>
> -Thomas
>
>
>
> *From: *Seth Hillbrand <seth.hillbr...@gmail.com>
> *Sent: *Friday, February 2, 2018 11:10 AM
> *To: *Thomas Figueroa <tom_figue...@hotmail.com>
> *Cc: *kicad-developers@lists.launchpad.net
> *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard
> edition
>
>
>
> Hi Thomas-
>
>
>
> I located a windows machine to try this.  I suspect that this is an
> artifact of OpenCascade 7.2.  Can you test with OpenCascade 7.1?  I haven't
> tracked down exactly what changed in 7.2 but it appears that 7.0 and 7.1
> work but 7.2 will require additional work in kicad2step.
>
>
>
> Of note, OCCT 6.8 also works but 6.9 (and OCE 0.18, which is based on 6.9)
> do not work either.  This is due to a compiler optimization but appears to
> be a different issue than the 7.2 one.
>
>
>
> -Seth
>
>
>
>
>
>
>
> 2018-01-31 19:04 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:
>
> Hello Seth,
>
>
>
> I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the
> same issue with MSYS2).
>
> STEP models work great in the 3D viewer, and in the footprint module
> editor, just as in OCE.
>
> Unfortunately, I cannot get the STEP export to work. I’ve had a run at
> using OpenCascade before
>
> and encountered this exact same issue. As an example, I’ve attached an
> outputted file.
>
> The following output is from the command line kicad2step:
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> fileType: 163
>
>   * no such file: ''
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> PCBMODEL::AddComponent: 574
>
>   * no model for filename for ‘’
>
>
>
> This repeats for every model. If you have any ideas, I’d be very willing
> to try them

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Thomas Figueroa]

I’ve attached the output from when I try to configure with the original file.
The version checking didn’t work for 7.1 for me either. It should be noted, that
I built OpenCascade from source, and I’ve tried to manually change it to point
to the Standard_Version header, but it still doesn’t parse it correctly with 
the same
error outputted.

-Thomas

From: Seth Hillbrand <seth.hillbr...@gmail.com>
Sent: Thursday, February 08, 2018 10:49 AM
To: Thomas Figueroa <tom_figue...@hotmail.com>
Cc: kicad-developers@lists.launchpad.net
Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

Hi Thomas-

I will add this library to the include.  Odd that it wasn't required on Linux.  
Can you send me your CMakeOutput.log?  The version checking is pretty important 
and those files don't change, so I'd like to track down why it would work for 
7.1 but not for 7.2.

-S

2018-02-08 7:29 GMT-08:00 Thomas Figueroa 
<tom_figue...@hotmail.com<mailto:tom_figue...@hotmail.com>>:
Hey Seth,

Working great with OpenCascade 7.2! I had to modify the Cmake file, though,
to include TKV3d in the library list. I get unresolved external link errors 
when compiling
s3d_plugin_oce otherwise (unresolved symbols SelectMgr_Selection, 
PrsMgr_PresentableObject, and AIS_InteractiveObject respectively).
I also had to remove the version checking, as it was unable to get the version 
via regex matching for some reason.

-Thomas


From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com>
Sent: Tuesday, February 6, 2018 2:34 PM
To: 
kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>

Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

I've updated this to allow use of OpenCascade 7.2 as well.

Nick, I added a few more helpful error messages to CMake file.  Let me know if 
you are still seeing the configure error with a clean cmake.

-Seth

2018-02-02 12:47 GMT-08:00 Thomas Figueroa 
<tom_figue...@hotmail.com<mailto:tom_figue...@hotmail.com>>:
Hey Seth,

I was able to successfully use OpenCascade 7.1 and export using kicad2step!

Now to find out why…

-Thomas

From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com>
Sent: Friday, February 2, 2018 11:10 AM
To: Thomas Figueroa<mailto:tom_figue...@hotmail.com>
Cc: 
kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>
Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

Hi Thomas-

I located a windows machine to try this.  I suspect that this is an artifact of 
OpenCascade 7.2.  Can you test with OpenCascade 7.1?  I haven't tracked down 
exactly what changed in 7.2 but it appears that 7.0 and 7.1 work but 7.2 will 
require additional work in kicad2step.

Of note, OCCT 6.8 also works but 6.9 (and OCE 0.18, which is based on 6.9) do 
not work either.  This is due to a compiler optimization but appears to be a 
different issue than the 7.2 one.

-Seth



2018-01-31 19:04 GMT-08:00 Thomas Figueroa 
<tom_figue...@hotmail.com<mailto:tom_figue...@hotmail.com>>:
Hello Seth,

I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the same 
issue with MSYS2).
STEP models work great in the 3D viewer, and in the footprint module editor, 
just as in OCE.
Unfortunately, I cannot get the STEP export to work. I’ve had a run at using 
OpenCascade before
and encountered this exact same issue. As an example, I’ve attached an 
outputted file.
The following output is from the command line kicad2step:

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: fileType: 
163
  * no such file: ''

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: 
PCBMODEL::AddComponent: 574
  * no model for filename for ‘’

This repeats for every model. If you have any ideas, I’d be very willing to try 
them out.

- Thomas

From: Kicad-developers 
<kicad-developers-bounces+tom_figueroa=hotmail@lists.launchpad.net<mailto:hotmail@lists.launchpad.net>>
 On Behalf Of Seth Hillbrand
Sent: Monday, January 29, 2018 12:55 PM
To: KiCad Developers 
<kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>>
Subject: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

​Hi All-

Currently, the build requires the opencascade community edition.  For various 
reasons, I need to have the current non-community edition of OpenCASCADE 
installed on my work machine.

The attached patch allows compiling KiCad with either the OpenCASCADE community 
edition or standard edition.

I've tested on a homebrew-based Mac install as well as Linux but haven't 
verified MSW, if someone would be willing to test it there, that would be 
great!  The basic search routines are lightly modified from FreeCAD's logic and 
keep their LGPL copyright on the CMake file.

-Seth​








cmake-error.log
Description: cmake-error.log
___
Ma

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Thomas-

I will add this library to the include.  Odd that it wasn't required on
Linux.  Can you send me your CMakeOutput.log?  The version checking is
pretty important and those files don't change, so I'd like to track down
why it would work for 7.1 but not for 7.2.

-S

2018-02-08 7:29 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:

> Hey Seth,
>
>
>
> Working great with OpenCascade 7.2! I had to modify the Cmake file, though,
>
> to include TKV3d in the library list. I get unresolved external link
> errors when compiling
>
> s3d_plugin_oce otherwise (unresolved symbols SelectMgr_Selection,
> PrsMgr_PresentableObject, and AIS_InteractiveObject respectively).
>
> I also had to remove the version checking, as it was unable to get the
> version via regex matching for some reason.
>
>
>
> -Thomas
>
>
>
>
>
> *From: *Seth Hillbrand <seth.hillbr...@gmail.com>
> *Sent: *Tuesday, February 6, 2018 2:34 PM
> *To: *kicad-developers@lists.launchpad.net
>
> *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard
> edition
>
>
>
> I've updated this to allow use of OpenCascade 7.2 as well.
>
>
>
> Nick, I added a few more helpful error messages to CMake file.  Let me
> know if you are still seeing the configure error with a clean cmake.
>
>
>
> -Seth
>
>
>
> 2018-02-02 12:47 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:
>
> Hey Seth,
>
>
>
> I was able to successfully use OpenCascade 7.1 and export using kicad2step!
>
>
>
> Now to find out why…
>
>
>
> -Thomas
>
>
>
> *From: *Seth Hillbrand <seth.hillbr...@gmail.com>
> *Sent: *Friday, February 2, 2018 11:10 AM
> *To: *Thomas Figueroa <tom_figue...@hotmail.com>
> *Cc: *kicad-developers@lists.launchpad.net
> *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard
> edition
>
>
>
> Hi Thomas-
>
>
>
> I located a windows machine to try this.  I suspect that this is an
> artifact of OpenCascade 7.2.  Can you test with OpenCascade 7.1?  I haven't
> tracked down exactly what changed in 7.2 but it appears that 7.0 and 7.1
> work but 7.2 will require additional work in kicad2step.
>
>
>
> Of note, OCCT 6.8 also works but 6.9 (and OCE 0.18, which is based on 6.9)
> do not work either.  This is due to a compiler optimization but appears to
> be a different issue than the 7.2 one.
>
>
>
> -Seth
>
>
>
>
>
>
>
> 2018-01-31 19:04 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:
>
> Hello Seth,
>
>
>
> I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the
> same issue with MSYS2).
>
> STEP models work great in the 3D viewer, and in the footprint module
> editor, just as in OCE.
>
> Unfortunately, I cannot get the STEP export to work. I’ve had a run at
> using OpenCascade before
>
> and encountered this exact same issue. As an example, I’ve attached an
> outputted file.
>
> The following output is from the command line kicad2step:
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> fileType: 163
>
>   * no such file: ''
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> PCBMODEL::AddComponent: 574
>
>   * no model for filename for ‘’
>
>
>
> This repeats for every model. If you have any ideas, I’d be very willing
> to try them out.
>
>
>
> - Thomas
>
>
>
> *From:* Kicad-developers <kicad-developers-bounces+tom_figueroa=
> hotmail@lists.launchpad.net> *On Behalf Of *Seth Hillbrand
> *Sent:* Monday, January 29, 2018 12:55 PM
> *To:* KiCad Developers <kicad-developers@lists.launchpad.net>
> *Subject:* [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition
>
>
>
> ​Hi All-
>
>
>
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
>
>
>
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.
>
>
>
> I've tested on a homebrew-based Mac install as well as Linux but haven't
> verified MSW, if someone would be willing to test it there, that would be
> great!  The basic search routines are lightly modified from FreeCAD's logic
> and keep their LGPL copyright on the CMake file.
>
>
>
> -Seth​
>
>
>
>
>
>
>
>
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

I've updated this to allow use of OpenCascade 7.2 as well.

Nick, I added a few more helpful error messages to CMake file.  Let me know
if you are still seeing the configure error with a clean cmake.

-Seth

2018-02-02 12:47 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:

> Hey Seth,
>
>
>
> I was able to successfully use OpenCascade 7.1 and export using kicad2step!
>
>
>
> Now to find out why…
>
>
>
> -Thomas
>
>
>
> *From: *Seth Hillbrand <seth.hillbr...@gmail.com>
> *Sent: *Friday, February 2, 2018 11:10 AM
> *To: *Thomas Figueroa <tom_figue...@hotmail.com>
> *Cc: *kicad-developers@lists.launchpad.net
> *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard
> edition
>
>
>
> Hi Thomas-
>
>
>
> I located a windows machine to try this.  I suspect that this is an
> artifact of OpenCascade 7.2.  Can you test with OpenCascade 7.1?  I haven't
> tracked down exactly what changed in 7.2 but it appears that 7.0 and 7.1
> work but 7.2 will require additional work in kicad2step.
>
>
>
> Of note, OCCT 6.8 also works but 6.9 (and OCE 0.18, which is based on 6.9)
> do not work either.  This is due to a compiler optimization but appears to
> be a different issue than the 7.2 one.
>
>
>
> -Seth
>
>
>
>
>
>
>
> 2018-01-31 19:04 GMT-08:00 Thomas Figueroa <tom_figue...@hotmail.com>:
>
> Hello Seth,
>
>
>
> I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the
> same issue with MSYS2).
>
> STEP models work great in the 3D viewer, and in the footprint module
> editor, just as in OCE.
>
> Unfortunately, I cannot get the STEP export to work. I’ve had a run at
> using OpenCascade before
>
> and encountered this exact same issue. As an example, I’ve attached an
> outputted file.
>
> The following output is from the command line kicad2step:
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> fileType: 163
>
>   * no such file: ''
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> PCBMODEL::AddComponent: 574
>
>   * no model for filename for ‘’
>
>
>
> This repeats for every model. If you have any ideas, I’d be very willing
> to try them out.
>
>
>
> - Thomas
>
>
>
> *From:* Kicad-developers <kicad-developers-bounces+tom_figueroa=
> hotmail@lists.launchpad.net> *On Behalf Of *Seth Hillbrand
> *Sent:* Monday, January 29, 2018 12:55 PM
> *To:* KiCad Developers <kicad-developers@lists.launchpad.net>
> *Subject:* [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition
>
>
>
> ​Hi All-
>
>
>
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
>
>
>
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.
>
>
>
> I've tested on a homebrew-based Mac install as well as Linux but haven't
> verified MSW, if someone would be willing to test it there, that would be
> great!  The basic search routines are lightly modified from FreeCAD's logic
> and keep their LGPL copyright on the CMake file.
>
>
>
> -Seth​
>
>
>
>
>
>
>
From 11cd74c38f98682b7b5e7908f1d39fd20b301968 Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <hillbr...@ucdavis.edu>
Date: Thu, 25 Jan 2018 16:38:29 -0800
Subject: [PATCH] Allow Kicad to use OpenCascade

Adds the option of using OpenCascade not just the community edition.
---
 CMakeLists.txt   |  29 +-
 CMakeModules/FindOpenCASCADE.cmake   | 197 +++
 common/dialog_about/dialog_about.cpp |  18 
 plugins/3d/oce/CMakeLists.txt|   4 +-
 plugins/3d/oce/loadmodel.cpp |   2 -
 utils/kicad2step/CMakeLists.txt  |   4 +-
 utils/kicad2step/pcb/oce_utils.cpp   |   4 +
 7 files changed, 247 insertions(+), 11 deletions(-)
 create mode 100644 CMakeModules/FindOpenCASCADE.cmake

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 967927fb5..65085aff3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -70,9 +70,13 @@ option( KICAD_SCRIPTING_ACTION_MENU
 )
 
 option( KICAD_USE_OCE
-"Build tools and plugins related to OpenCascade Community Edition (default OFF)"
+"Build tools and plugins related to OpenCascade Community Edition (default ON)"
 ON )
 
+option( KICAD_USE_OCC
+"Build tools and plugins related to OpenCascade Technology (overrides KICAD_USE_OCE, default OFF)"
+OFF )
+
 option( KICAD_INSTALL_DEMOS
 "Install kicad demos and examples (default ON)"
 ON )
@@ -321,6 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Thomas Figueroa]

Hey Seth,

I was able to successfully use OpenCascade 7.1 and export using kicad2step!

Now to find out why…

-Thomas

From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com>
Sent: Friday, February 2, 2018 11:10 AM
To: Thomas Figueroa<mailto:tom_figue...@hotmail.com>
Cc: 
kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>
Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

Hi Thomas-

I located a windows machine to try this.  I suspect that this is an artifact of 
OpenCascade 7.2.  Can you test with OpenCascade 7.1?  I haven't tracked down 
exactly what changed in 7.2 but it appears that 7.0 and 7.1 work but 7.2 will 
require additional work in kicad2step.

Of note, OCCT 6.8 also works but 6.9 (and OCE 0.18, which is based on 6.9) do 
not work either.  This is due to a compiler optimization but appears to be a 
different issue than the 7.2 one.

-Seth



2018-01-31 19:04 GMT-08:00 Thomas Figueroa 
<tom_figue...@hotmail.com<mailto:tom_figue...@hotmail.com>>:
Hello Seth,

I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the same 
issue with MSYS2).
STEP models work great in the 3D viewer, and in the footprint module editor, 
just as in OCE.
Unfortunately, I cannot get the STEP export to work. I’ve had a run at using 
OpenCascade before
and encountered this exact same issue. As an example, I’ve attached an 
outputted file.
The following output is from the command line kicad2step:

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: fileType: 
163
  * no such file: ''

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: 
PCBMODEL::AddComponent: 574
  * no model for filename for ‘’

This repeats for every model. If you have any ideas, I’d be very willing to try 
them out.

- Thomas

From: Kicad-developers 
<kicad-developers-bounces+tom_figueroa=hotmail@lists.launchpad.net<mailto:hotmail@lists.launchpad.net>>
 On Behalf Of Seth Hillbrand
Sent: Monday, January 29, 2018 12:55 PM
To: KiCad Developers 
<kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>>
Subject: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

​Hi All-

Currently, the build requires the opencascade community edition.  For various 
reasons, I need to have the current non-community edition of OpenCASCADE 
installed on my work machine.

The attached patch allows compiling KiCad with either the OpenCASCADE community 
edition or standard edition.

I've tested on a homebrew-based Mac install as well as Linux but haven't 
verified MSW, if someone would be willing to test it there, that would be 
great!  The basic search routines are lightly modified from FreeCAD's logic and 
keep their LGPL copyright on the CMake file.

-Seth​



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Nick-

Thanks.  Can you clear your build directory, re-run your Cmake command and
send the full output?  The snippet suggests that it is finding a library in
your kicad-source-mirror directory.

-Seth

2018-02-01 13:03 GMT-08:00 Nick Østergaard :

> Hi Seth
>
> The second patch seems more broken.
>
> I get something like this when configuring:
> ...
> -- Found OCC: /opt/oce/lib/oce-0.18/../../include/oce (found version
> "6.9.1")
> -- Found OpenCASCADE Community Edition version: 6.9.1
> --  ++ OpenCASCADE Community Edition include directory:
> /opt/oce/include/oce
> --  ++ OpenCASCADE Community Edition shared libraries directory:
> /home/nickoe/kicad-source-mirror
> ...
> CMake Error: The following variables are used in this project, but they
> are set to NOTFOUND.
> Please set them or make sure they are set and tested correctly in the
> CMake files:
> OCC_TEMP_LIB
> linked by target "s3d_plugin_oce" in directory
> /home/nickoe/kicad-source-mirror/plugins/3d/oce
> ...
> linked by target "s3d_plugin_oce" in directory
> /home/nickoe/kicad-source-mirror/plugins/3d/oce
> linked by target "kicad2step" in directory /home/nickoe/kicad-source-
> mirror/utils/kicad2step
> ...
> linked by target "kicad2step" in directory /home/nickoe/kicad-source-
> mirror/utils/kicad2step
>
> -- Configuring incomplete, errors occurred!
> See also "/home/nickoe/kicad-source-mirror/test/CMakeFiles/
> CMakeOutput.log".
> See also "/home/nickoe/kicad-source-mirror/test/CMakeFiles/
> CMakeError.log".
>
>
> If you like I can share a Dockerfile which tries to replicate my
> environment with archlinux.
>
>
>
> 2018-01-30 20:12 GMT+01:00 Seth Hillbrand :
>
>> Nick-
>>
>> Thanks for the test.  I'm attaching revised patch that allows multiple
>> OpenCASCADE installations on a single machine.
>>
>> I've tested with a few different OpenCASCADE versions down to 6.8 with no
>> issues installed alongside OCE 0.17.  You can choose which you want to link
>> by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If both are
>> specified, "-DKICAD_USE_OCC" will override.
>>
>> I corrected the cmake message display to be less doubled and correctly
>> show the library location.
>>
>> I've also added the OCC version and type to the about window version info.
>>
>> The "Based on" line was taken from (https://github.com/FreeCAD/Fr
>> eeCAD/blob/master/src/FCConfig.h) when trying to determine how FreeCAD
>> likes to refer to themselves.  The actual FindOpenCascade.cmake file did
>> not have a copyright header attached but falls under the license from (
>> https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note that I
>> had it written as "FreeCAD CADx development system".  I've corrected this
>> to read "FreeCAD CAx development system".
>>
>> I'm not sure to what the "CheckSymbolExists" line is referring.  I don't
>> see it on my machine.
>>
>> -Seth
>>
>> 2018-01-29 14:30 GMT-08:00 Nick Østergaard :
>>
>>> Hi Seth,
>>>
>>> I just took the patch for a testrun and will state some comments below.
>>>
>>> This looks a bit strange:
>>>
>>> -- Boost version: 1.66.0
>>> -- -- OpenCASCADE Community Edition has been found.
>>> -- -- Found OCE/OpenCASCADE version: 6.8.0
>>> -- -- OCE/OpenCASCADE include directory: /opt/oce/lib/oce-0.17/../../in
>>> clude/oce
>>> -- -- OCE/OpenCASCADE shared libraries directory:
>>> -- Check for installed Python Interpreter -- found
>>>
>>> The messages are with double -- and the shared libs.
>>>
>>> But an improvement with your patch over what is currently in kicad is
>>> that it found OCE on my system without explicitly specifind OCE_DIR. But
>>> how do I make it use OCCT when I also have OCE installed?
>>>
>>> What does CADx mean in that header?
>>>
>>> What is this about?
>>> -- Looking for /home/amazingdude/kicad-source
>>> -mirror/build_seths_occt_patch_occt/CMakeFiles/CMakeTmp/
>>> CheckSymbolExists.cxx
>>> -- Looking for /home/amazingdude/kicad-source
>>> -mirror/build_seths_occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
>>> - not found
>>>
>>> I tried to test it with removing oce and just have occt installed and
>>> got something like this:
>>> -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
>>> -- -- Found OCE/OpenCASCADE version: 6.9.1
>>> -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
>>> -- -- OCE/OpenCASCADE shared libraries directory: /opt/opencascade/lib
>>>
>>> It did not build against community/opencascade 6.9.1-7. I got the
>>> following error in a clean build dir.
>>>
>>> $ make kicad2step -j1
>>> [  0%] Linking CXX executable kicad2step
>>> /usr/bin/ld: cannot find -lTKMesh
>>> /usr/bin/ld: cannot find -lTKernel
>>> /usr/bin/ld: cannot find -lTKG2d
>>> /usr/bin/ld: cannot find -lTKG3d
>>> /usr/bin/ld: cannot find -lTKMath
>>> /usr/bin/ld: cannot find -lTKIGES
>>> /usr/bin/ld: cannot find -lTKSTL
>>> /usr/bin/ld: cannot find -lTKXSBase
>>> /usr/bin/ld: cannot find -lTKBin
>>> 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Thomas-

I located a windows machine to try this.  I suspect that this is an
artifact of OpenCascade 7.2.  Can you test with OpenCascade 7.1?  I haven't
tracked down exactly what changed in 7.2 but it appears that 7.0 and 7.1
work but 7.2 will require additional work in kicad2step.

Of note, OCCT 6.8 also works but 6.9 (and OCE 0.18, which is based on 6.9)
do not work either.  This is due to a compiler optimization but appears to
be a different issue than the 7.2 one.

-Seth



2018-01-31 19:04 GMT-08:00 Thomas Figueroa :

> Hello Seth,
>
>
>
> I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the
> same issue with MSYS2).
>
> STEP models work great in the 3D viewer, and in the footprint module
> editor, just as in OCE.
>
> Unfortunately, I cannot get the STEP export to work. I’ve had a run at
> using OpenCascade before
>
> and encountered this exact same issue. As an example, I’ve attached an
> outputted file.
>
> The following output is from the command line kicad2step:
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> fileType: 163
>
>   * no such file: ''
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> PCBMODEL::AddComponent: 574
>
>   * no model for filename for ‘’
>
>
>
> This repeats for every model. If you have any ideas, I’d be very willing
> to try them out.
>
>
>
> - Thomas
>
>
>
> *From:* Kicad-developers  hotmail@lists.launchpad.net> *On Behalf Of *Seth Hillbrand
> *Sent:* Monday, January 29, 2018 12:55 PM
> *To:* KiCad Developers 
> *Subject:* [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition
>
>
>
> ​Hi All-
>
>
>
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
>
>
>
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.
>
>
>
> I've tested on a homebrew-based Mac install as well as Linux but haven't
> verified MSW, if someone would be willing to test it there, that would be
> great!  The basic search routines are lightly modified from FreeCAD's logic
> and keep their LGPL copyright on the CMake file.
>
>
>
> -Seth​
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Nick Østergaard]

Hi Seth

The second patch seems more broken.

I get something like this when configuring:
...
-- Found OCC: /opt/oce/lib/oce-0.18/../../include/oce (found version
"6.9.1")
-- Found OpenCASCADE Community Edition version: 6.9.1
--  ++ OpenCASCADE Community Edition include directory: /opt/oce/include/oce
--  ++ OpenCASCADE Community Edition shared libraries directory:
/home/nickoe/kicad-source-mirror
...
CMake Error: The following variables are used in this project, but they are
set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake
files:
OCC_TEMP_LIB
linked by target "s3d_plugin_oce" in directory
/home/nickoe/kicad-source-mirror/plugins/3d/oce
...
linked by target "s3d_plugin_oce" in directory
/home/nickoe/kicad-source-mirror/plugins/3d/oce
linked by target "kicad2step" in directory
/home/nickoe/kicad-source-mirror/utils/kicad2step
...
linked by target "kicad2step" in directory
/home/nickoe/kicad-source-mirror/utils/kicad2step

-- Configuring incomplete, errors occurred!
See also "/home/nickoe/kicad-source-mirror/test/CMakeFiles/CMakeOutput.log".
See also "/home/nickoe/kicad-source-mirror/test/CMakeFiles/CMakeError.log".


If you like I can share a Dockerfile which tries to replicate my
environment with archlinux.



2018-01-30 20:12 GMT+01:00 Seth Hillbrand :

> Nick-
>
> Thanks for the test.  I'm attaching revised patch that allows multiple
> OpenCASCADE installations on a single machine.
>
> I've tested with a few different OpenCASCADE versions down to 6.8 with no
> issues installed alongside OCE 0.17.  You can choose which you want to link
> by using either "-DKICAD_USE_OCE" or "-DKICAD_USE_OCC".  If both are
> specified, "-DKICAD_USE_OCC" will override.
>
> I corrected the cmake message display to be less doubled and correctly
> show the library location.
>
> I've also added the OCC version and type to the about window version info.
>
> The "Based on" line was taken from (https://github.com/FreeCAD/
> FreeCAD/blob/master/src/FCConfig.h) when trying to determine how FreeCAD
> likes to refer to themselves.  The actual FindOpenCascade.cmake file did
> not have a copyright header attached but falls under the license from (
> https://github.com/FreeCAD/FreeCAD/blob/master/COPYING).  I note that I
> had it written as "FreeCAD CADx development system".  I've corrected this
> to read "FreeCAD CAx development system".
>
> I'm not sure to what the "CheckSymbolExists" line is referring.  I don't
> see it on my machine.
>
> -Seth
>
> 2018-01-29 14:30 GMT-08:00 Nick Østergaard :
>
>> Hi Seth,
>>
>> I just took the patch for a testrun and will state some comments below.
>>
>> This looks a bit strange:
>>
>> -- Boost version: 1.66.0
>> -- -- OpenCASCADE Community Edition has been found.
>> -- -- Found OCE/OpenCASCADE version: 6.8.0
>> -- -- OCE/OpenCASCADE include directory: /opt/oce/lib/oce-0.17/../../in
>> clude/oce
>> -- -- OCE/OpenCASCADE shared libraries directory:
>> -- Check for installed Python Interpreter -- found
>>
>> The messages are with double -- and the shared libs.
>>
>> But an improvement with your patch over what is currently in kicad is
>> that it found OCE on my system without explicitly specifind OCE_DIR. But
>> how do I make it use OCCT when I also have OCE installed?
>>
>> What does CADx mean in that header?
>>
>> What is this about?
>> -- Looking for /home/amazingdude/kicad-source-mirror/build_seths_occt_
>> patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
>> -- Looking for /home/amazingdude/kicad-source-mirror/build_seths_occt_
>> patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx - not found
>>
>> I tried to test it with removing oce and just have occt installed and got
>> something like this:
>> -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
>> -- -- Found OCE/OpenCASCADE version: 6.9.1
>> -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
>> -- -- OCE/OpenCASCADE shared libraries directory: /opt/opencascade/lib
>>
>> It did not build against community/opencascade 6.9.1-7. I got the
>> following error in a clean build dir.
>>
>> $ make kicad2step -j1
>> [  0%] Linking CXX executable kicad2step
>> /usr/bin/ld: cannot find -lTKMesh
>> /usr/bin/ld: cannot find -lTKernel
>> /usr/bin/ld: cannot find -lTKG2d
>> /usr/bin/ld: cannot find -lTKG3d
>> /usr/bin/ld: cannot find -lTKMath
>> /usr/bin/ld: cannot find -lTKIGES
>> /usr/bin/ld: cannot find -lTKSTL
>> /usr/bin/ld: cannot find -lTKXSBase
>> /usr/bin/ld: cannot find -lTKBin
>> /usr/bin/ld: cannot find -lTKBO
>> /usr/bin/ld: cannot find -lTKCDF
>> /usr/bin/ld: cannot find -lTKBRep
>> /usr/bin/ld: cannot find -lTKTopAlgo
>> /usr/bin/ld: cannot find -lTKGeomAlgo
>> /usr/bin/ld: cannot find -lTKGeomBase
>> /usr/bin/ld: cannot find -lTKPrim
>> /usr/bin/ld: cannot find -lTKSTEP
>> /usr/bin/ld: cannot find -lTKSTEPBase
>> /usr/bin/ld: cannot find -lTKSTEPAttr
>> /usr/bin/ld: cannot find -lTKFeat
>> /usr/bin/ld: cannot find 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Thomas Figueroa]

I’m using OCCT 7.2.0. I’ve also tried from the master branch.  Both built with 
MSVC.
I’m able to export using OCE just fine.  With OCE, I do get missing model 
messages when using
kicad2step from command line.  I hadn’t tried it from the command line before 
with OCE, so the
output from the prior message is probably not relevant.

-Thomas



From: Seth Hillbrand<mailto:seth.hillbr...@gmail.com>
Sent: Thursday, February 1, 2018 12:15 PM
To: Thomas Figueroa<mailto:tom_figue...@hotmail.com>
Cc: 
kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>
Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

Hi Thomas-

Thanks for testing!  Couple questions:
- Which version of OCCT are you testing?
- Are you able to correctly export the board when using OCE?
- Do you not see the missing model messages when using OCE?

-Seth

2018-01-31 19:04 GMT-08:00 Thomas Figueroa 
<tom_figue...@hotmail.com<mailto:tom_figue...@hotmail.com>>:
Hello Seth,

I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the same 
issue with MSYS2).
STEP models work great in the 3D viewer, and in the footprint module editor, 
just as in OCE.
Unfortunately, I cannot get the STEP export to work. I’ve had a run at using 
OpenCascade before
and encountered this exact same issue. As an example, I’ve attached an 
outputted file.
The following output is from the command line kicad2step:

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: fileType: 
163
  * no such file: ''

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: 
PCBMODEL::AddComponent: 574
  * no model for filename for ‘’

This repeats for every model. If you have any ideas, I’d be very willing to try 
them out.

- Thomas

From: Kicad-developers 
<kicad-developers-bounces+tom_figueroa=hotmail@lists.launchpad.net<mailto:hotmail@lists.launchpad.net>>
 On Behalf Of Seth Hillbrand
Sent: Monday, January 29, 2018 12:55 PM
To: KiCad Developers 
<kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net>>
Subject: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

​Hi All-

Currently, the build requires the opencascade community edition.  For various 
reasons, I need to have the current non-community edition of OpenCASCADE 
installed on my work machine.

The attached patch allows compiling KiCad with either the OpenCASCADE community 
edition or standard edition.

I've tested on a homebrew-based Mac install as well as Linux but haven't 
verified MSW, if someone would be willing to test it there, that would be 
great!  The basic search routines are lightly modified from FreeCAD's logic and 
keep their LGPL copyright on the CMake file.

-Seth​



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Thomas-

Thanks for testing!  Couple questions:
- Which version of OCCT are you testing?
- Are you able to correctly export the board when using OCE?
- Do you not see the missing model messages when using OCE?

-Seth

2018-01-31 19:04 GMT-08:00 Thomas Figueroa :

> Hello Seth,
>
>
>
> I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the
> same issue with MSYS2).
>
> STEP models work great in the 3D viewer, and in the footprint module
> editor, just as in OCE.
>
> Unfortunately, I cannot get the STEP export to work. I’ve had a run at
> using OpenCascade before
>
> and encountered this exact same issue. As an example, I’ve attached an
> outputted file.
>
> The following output is from the command line kicad2step:
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> fileType: 163
>
>   * no such file: ''
>
>
>
> 20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp:
> PCBMODEL::AddComponent: 574
>
>   * no model for filename for ‘’
>
>
>
> This repeats for every model. If you have any ideas, I’d be very willing
> to try them out.
>
>
>
> - Thomas
>
>
>
> *From:* Kicad-developers  hotmail@lists.launchpad.net> *On Behalf Of *Seth Hillbrand
> *Sent:* Monday, January 29, 2018 12:55 PM
> *To:* KiCad Developers 
> *Subject:* [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition
>
>
>
> ​Hi All-
>
>
>
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
>
>
>
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.
>
>
>
> I've tested on a homebrew-based Mac install as well as Linux but haven't
> verified MSW, if someone would be willing to test it there, that would be
> great!  The basic search routines are lightly modified from FreeCAD's logic
> and keep their LGPL copyright on the CMake file.
>
>
>
> -Seth​
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Thomas Figueroa]

Hello Seth,

I’ve had the opportunity to test this on Windows (MSVC, but I’ve had the same 
issue with MSYS2).
STEP models work great in the 3D viewer, and in the footprint module editor, 
just as in OCE.
Unfortunately, I cannot get the STEP export to work. I’ve had a run at using 
OpenCascade before
and encountered this exact same issue. As an example, I’ve attached an 
outputted file.
The following output is from the command line kicad2step:

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: fileType: 
163
  * no such file: ''

20:31:07: C:\dev\kicad-personal\utils\kicad2step\pcb\oce_utils.cpp: 
PCBMODEL::AddComponent: 574
  * no model for filename for ‘’

This repeats for every model. If you have any ideas, I’d be very willing to try 
them out.

- Thomas

From: Kicad-developers 
 On 
Behalf Of Seth Hillbrand
Sent: Monday, January 29, 2018 12:55 PM
To: KiCad Developers 
Subject: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

​Hi All-

Currently, the build requires the opencascade community edition.  For various 
reasons, I need to have the current non-community edition of OpenCASCADE 
installed on my work machine.

The attached patch allows compiling KiCad with either the OpenCASCADE community 
edition or standard edition.

I've tested on a homebrew-based Mac install as well as Linux but haven't 
verified MSW, if someone would be willing to test it there, that would be 
great!  The basic search routines are lightly modified from FreeCAD's logic and 
keep their LGPL copyright on the CMake file.

-Seth​



nil.step
Description: nil.step
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Nick Østergaard]

I get the same issue with OCCT 7.2.0.

2018-01-29 23:30 GMT+01:00 Nick Østergaard :

> Hi Seth,
>
> I just took the patch for a testrun and will state some comments below.
>
> This looks a bit strange:
>
> -- Boost version: 1.66.0
> -- -- OpenCASCADE Community Edition has been found.
> -- -- Found OCE/OpenCASCADE version: 6.8.0
> -- -- OCE/OpenCASCADE include directory: /opt/oce/lib/oce-0.17/../../
> include/oce
> -- -- OCE/OpenCASCADE shared libraries directory:
> -- Check for installed Python Interpreter -- found
>
> The messages are with double -- and the shared libs.
>
> But an improvement with your patch over what is currently in kicad is that
> it found OCE on my system without explicitly specifind OCE_DIR. But how do
> I make it use OCCT when I also have OCE installed?
>
> What does CADx mean in that header?
>
> What is this about?
> -- Looking for /home/amazingdude/kicad-source-mirror/build_seths_
> occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
> -- Looking for /home/amazingdude/kicad-source-mirror/build_seths_
> occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx - not found
>
> I tried to test it with removing oce and just have occt installed and got
> something like this:
> -- Found OCC: /opt/opencascade/inc (found version "6.9.1")
> -- -- Found OCE/OpenCASCADE version: 6.9.1
> -- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
> -- -- OCE/OpenCASCADE shared libraries directory: /opt/opencascade/lib
>
> It did not build against community/opencascade 6.9.1-7. I got the
> following error in a clean build dir.
>
> $ make kicad2step -j1
> [  0%] Linking CXX executable kicad2step
> /usr/bin/ld: cannot find -lTKMesh
> /usr/bin/ld: cannot find -lTKernel
> /usr/bin/ld: cannot find -lTKG2d
> /usr/bin/ld: cannot find -lTKG3d
> /usr/bin/ld: cannot find -lTKMath
> /usr/bin/ld: cannot find -lTKIGES
> /usr/bin/ld: cannot find -lTKSTL
> /usr/bin/ld: cannot find -lTKXSBase
> /usr/bin/ld: cannot find -lTKBin
> /usr/bin/ld: cannot find -lTKBO
> /usr/bin/ld: cannot find -lTKCDF
> /usr/bin/ld: cannot find -lTKBRep
> /usr/bin/ld: cannot find -lTKTopAlgo
> /usr/bin/ld: cannot find -lTKGeomAlgo
> /usr/bin/ld: cannot find -lTKGeomBase
> /usr/bin/ld: cannot find -lTKPrim
> /usr/bin/ld: cannot find -lTKSTEP
> /usr/bin/ld: cannot find -lTKSTEPBase
> /usr/bin/ld: cannot find -lTKSTEPAttr
> /usr/bin/ld: cannot find -lTKFeat
> /usr/bin/ld: cannot find -lTKCAF
> /usr/bin/ld: cannot find -lTKXCAF
> /usr/bin/ld: cannot find -lTKLCAF
> /usr/bin/ld: cannot find -lTKXDESTEP
> /usr/bin/ld: cannot find -lTKXDEIGES
> collect2: error: ld returned 1 exit status
> make[3]: *** [utils/kicad2step/CMakeFiles/kicad2step.dir/build.make:355:
> utils/kicad2step/kicad2step] Error 1
> make[2]: *** [CMakeFiles/Makefile2:3007: 
> utils/kicad2step/CMakeFiles/kicad2step.dir/all]
> Error 2
> make[1]: *** [CMakeFiles/Makefile2:3019: 
> utils/kicad2step/CMakeFiles/kicad2step.dir/rule]
> Error 2
> make: *** [Makefile:979: kicad2step] Error 2
>
> But those libs do existm, searched for the last one;
> $ yaourt  -Ql opencascade | grep TKXDEIGES
> opencascade /opt/opencascade/lib/libTKXDEIGES.so
> opencascade /opt/opencascade/lib/libTKXDEIGES.so.0
> opencascade /opt/opencascade/lib/libTKXDEIGES.so.0.0.0
>
> I got these variables set in the CMakeCache
>
> cat CMakeCache.txt  | grep "OCE\|OCC"
> KICAD_USE_OCE:BOOL=ON
> OCC_INCLUDE_DIR:PATH=/opt/opencascade/inc
> OCC_LIBRARY:FILEPATH=/opt/opencascade/lib/libTKernel.so
> //The directory containing a CMake configuration file for OCE.
> OCE_DIR:PATH=OCE_DIR-NOTFOUND
> //Details about finding OCC
> FIND_PACKAGE_MESSAGE_DETAILS_OCC:INTERNAL=[/opt/opencascade/inc][v6.9.1()]
>
> This is tested on archlinux.
>
> 2018-01-29 19:54 GMT+01:00 Seth Hillbrand :
>
>> ​Hi All-
>>
>> Currently, the build requires the opencascade community edition.  For
>> various reasons, I need to have the current non-community edition of
>> OpenCASCADE installed on my work machine.
>>
>> The attached patch allows compiling KiCad with either the OpenCASCADE
>> community edition or standard edition.
>>
>> I've tested on a homebrew-based Mac install as well as Linux but haven't
>> verified MSW, if someone would be willing to test it there, that would be
>> great!  The basic search routines are lightly modified from FreeCAD's logic
>> and keep their LGPL copyright on the CMake file.
>>
>> -Seth​
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Cirilo Bernardo]

OCCT is usually quite a few commits ahead of OCE; in fact OCE is
usually based on the earlier release of OCCT. In addition to that,
since we build in MSYS on MSWin, a patch (which is an ugly hack) is
required to support non-ASCII characters in file names.

- Cirilo

On Mon, Jan 29, 2018 at 8:08 PM, Simon Wells  wrote:
> please see https://lists.launchpad.net/kicad-developers/msg31544.html
>
> There are different minimum versions required of OCCT and nick also had
> issues with occt working iirc
>
> i think i would still prefer being able to set whether to allow occ in place
> of oce as was my initial thoughts but i have not worked on this due to the
> issues experienced by nick
>
>
> btw as oce is just a fork of occt would that not have the same issues?
>
> On 30/01/2018, at 9:04 AM, Wayne Stambaugh  wrote:
>
> Hey Seth,
>
> One of us missed something.  Here is my interpretation:
>
> The opencascade website license states:
>
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional exception."
>
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
>
> According to the folks at the FSF:
>
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
>
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
>
> Thanks,
>
> Wayne
>
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
>
> Hi Wayne-
>
> My reading of your links is different.  Here's the relevant quote:
>
> "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
> is the previous version of the LGPL: a free software license, but not a
> strong copyleft license, because it permits linking with nonfree
> modules. It is compatible with GPLv2 and GPLv3."
>
> Did I miss something?
>
> -Seth
>
> 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh  >:
>
>Seth,
>
>There maybe licensing issues involved with this.  OpenCascade is
>licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
>compatible with GPL 3[2].  If OpenCascade is willing to change their
>license LPGL 2.1 or later or if this is just an oversight on their part,
>than I can include this patch.  Please verify the OpenCascade license
>with something that I can verify to ensure we are not violating and
>licensing terms.
>
>Cheers,
>
>Wayne
>
>[1]: https://www.opencascade.com/content/licensing
>
>[2]:
>https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses
>
>
>On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
>
> Hi All-
>
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
>
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.
>
> I've tested on a homebrew-based Mac install as well as Linux but
>
>haven't
>
> verified MSW, if someone would be willing to test it there, that would
> be great!  The basic search routines are lightly modified from
>
>FreeCAD's
>
> logic and keep their LGPL copyright on the CMake file.
>
> -Seth
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
>
>
>
> Post to : kicad-developers@lists.launchpad.net
>
>
>
> Unsubscribe : https://launchpad.net/~kicad-developers
>
>
>
> More help   : https://help.launchpad.net/ListHelp
>
>
>
>
>
>___
>Mailing list: https://launchpad.net/~kicad-developers
>
>Post to : 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Wayne Stambaugh]

Please ignore this, I see that you've chosen occ as the fallback.  Sorry 
about the noise.


Wayne

On 01/29/2018 05:28 PM, Wayne Stambaugh wrote:

Seth,

Looking at the information at hand, I'm comfortable adding occ.  I was
working under the assumption that you were making occ and option for oce
but after looking at the patch, I see that is not the case.  Please
revise your patch to make occ an optional replacement for oce and keep
oce as the default.  There are (were?) known issues with occ the last I
heard and I believe we have all platforms working fine with oce.  I
would be more comfortable with making occ optional.

Thanks,

Wayne

On 01/29/2018 03:24 PM, Seth Hillbrand wrote:

Maybe the confusion is between LGPL v2.1, which is compatible with GPL3
and GPL2, which is not.  There are two aspects here:

- Clause 3 states that we can substitute GPL v2 or any newer version
instead of LGPL v2.1.  That would apply if we decided to use a copy of
the library (e.g. static linking)

- But there is also Clause 6 that covers us: "As an exception to the
Sections above, you may also combine or link a "work that uses the
Library" with the Library to produce a work containing portions of the
Library, and distribute that work under terms of your choice, provided
that the terms permit modification of the work for the customer's own
use and reverse engineering for debugging such modifications."

-S

2018-01-29 12:04 GMT-08:00 Wayne Stambaugh >:

 Hey Seth,

 One of us missed something.  Here is my interpretation:

 The opencascade website license states:

 "Open CASCADE Technology version 6.7.0 and later are governed by GNU
 Lesser General Public License (LGPL) version 2.1 with additional
 exception."

 It makes no mention of later versions of the LGPL (including the
 exception) so I am interpreting this as v2.1 only.  I do not have a copy
 (and I'm not going to sign up to get a copy so please check the
 copyright in the source to see if it matches the website) of the
 opencascade source archive to see if the license in the source
 specifically states "v2.1 or (at your option) any later version" which
 is typically how the GPL and LGPL are used.  If it does, than I can
 safely add this patch because I can make the claim that I am using
 opencascade under at later version of the LGPL which is compatible with
 the GPL 3 used by kicad.

 According to the folks at the FSF:

 "Please note that GPLv2 is, by itself, not compatible with GPLv3.
 However, most software released under GPLv2 allows you to use the terms
 of later versions of the GPL as well. When this is the case, you can use
 the code under GPLv3 to make the desired combination. To learn more
 about compatibility between GNU licenses, please see our FAQ."

 I hope this clarifies why I am hesitant to merge this patch and what
 needs to clarified.  Isn't licensing fun! ;)

 Thanks,

 Wayne

 On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
 > Hi Wayne-
 >
 > My reading of your links is different.  Here's the relevant quote:
 >
 > "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
 > is the previous version of the LGPL: a free software license, but not a
 > strong copyleft license, because it permits linking with nonfree
 > modules. It is compatible with GPLv2 and GPLv3."
 >
 > Did I miss something?
 >
 > -Seth
 >
 > 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh 
 > >>:
 >
 >     Seth,
 >
 >     There maybe licensing issues involved with this.  OpenCascade is
 >     licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
 >     compatible with GPL 3[2].  If OpenCascade is willing to change
 their
 >     license LPGL 2.1 or later or if this is just an oversight on
 their part,
 >     than I can include this patch.  Please verify the OpenCascade
 license
 >     with something that I can verify to ensure we are not
 violating and
 >     licensing terms.
 >
 >     Cheers,
 >
 >     Wayne
 >
 >     [1]: https://www.opencascade.com/content/licensing
 
 >     >
 >     [2]:
 >
  https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses
 
 >
  >
 >
 >     On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
 >     > ​Hi All-
 >     >

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Nick Østergaard]

Hi Seth,

I just took the patch for a testrun and will state some comments below.

This looks a bit strange:

-- Boost version: 1.66.0
-- -- OpenCASCADE Community Edition has been found.
-- -- Found OCE/OpenCASCADE version: 6.8.0
-- -- OCE/OpenCASCADE include directory:
/opt/oce/lib/oce-0.17/../../include/oce
-- -- OCE/OpenCASCADE shared libraries directory:
-- Check for installed Python Interpreter -- found

The messages are with double -- and the shared libs.

But an improvement with your patch over what is currently in kicad is that
it found OCE on my system without explicitly specifind OCE_DIR. But how do
I make it use OCCT when I also have OCE installed?

What does CADx mean in that header?

What is this about?
-- Looking for
/home/amazingdude/kicad-source-mirror/build_seths_occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
-- Looking for
/home/amazingdude/kicad-source-mirror/build_seths_occt_patch_occt/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
- not found

I tried to test it with removing oce and just have occt installed and got
something like this:
-- Found OCC: /opt/opencascade/inc (found version "6.9.1")
-- -- Found OCE/OpenCASCADE version: 6.9.1
-- -- OCE/OpenCASCADE include directory: /opt/opencascade/inc
-- -- OCE/OpenCASCADE shared libraries directory: /opt/opencascade/lib

It did not build against community/opencascade 6.9.1-7. I got the following
error in a clean build dir.

$ make kicad2step -j1
[  0%] Linking CXX executable kicad2step
/usr/bin/ld: cannot find -lTKMesh
/usr/bin/ld: cannot find -lTKernel
/usr/bin/ld: cannot find -lTKG2d
/usr/bin/ld: cannot find -lTKG3d
/usr/bin/ld: cannot find -lTKMath
/usr/bin/ld: cannot find -lTKIGES
/usr/bin/ld: cannot find -lTKSTL
/usr/bin/ld: cannot find -lTKXSBase
/usr/bin/ld: cannot find -lTKBin
/usr/bin/ld: cannot find -lTKBO
/usr/bin/ld: cannot find -lTKCDF
/usr/bin/ld: cannot find -lTKBRep
/usr/bin/ld: cannot find -lTKTopAlgo
/usr/bin/ld: cannot find -lTKGeomAlgo
/usr/bin/ld: cannot find -lTKGeomBase
/usr/bin/ld: cannot find -lTKPrim
/usr/bin/ld: cannot find -lTKSTEP
/usr/bin/ld: cannot find -lTKSTEPBase
/usr/bin/ld: cannot find -lTKSTEPAttr
/usr/bin/ld: cannot find -lTKFeat
/usr/bin/ld: cannot find -lTKCAF
/usr/bin/ld: cannot find -lTKXCAF
/usr/bin/ld: cannot find -lTKLCAF
/usr/bin/ld: cannot find -lTKXDESTEP
/usr/bin/ld: cannot find -lTKXDEIGES
collect2: error: ld returned 1 exit status
make[3]: *** [utils/kicad2step/CMakeFiles/kicad2step.dir/build.make:355:
utils/kicad2step/kicad2step] Error 1
make[2]: *** [CMakeFiles/Makefile2:3007:
utils/kicad2step/CMakeFiles/kicad2step.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:3019:
utils/kicad2step/CMakeFiles/kicad2step.dir/rule] Error 2
make: *** [Makefile:979: kicad2step] Error 2

But those libs do existm, searched for the last one;
$ yaourt  -Ql opencascade | grep TKXDEIGES
opencascade /opt/opencascade/lib/libTKXDEIGES.so
opencascade /opt/opencascade/lib/libTKXDEIGES.so.0
opencascade /opt/opencascade/lib/libTKXDEIGES.so.0.0.0

I got these variables set in the CMakeCache

cat CMakeCache.txt  | grep "OCE\|OCC"
KICAD_USE_OCE:BOOL=ON
OCC_INCLUDE_DIR:PATH=/opt/opencascade/inc
OCC_LIBRARY:FILEPATH=/opt/opencascade/lib/libTKernel.so
//The directory containing a CMake configuration file for OCE.
OCE_DIR:PATH=OCE_DIR-NOTFOUND
//Details about finding OCC
FIND_PACKAGE_MESSAGE_DETAILS_OCC:INTERNAL=[/opt/opencascade/inc][v6.9.1()]

This is tested on archlinux.

2018-01-29 19:54 GMT+01:00 Seth Hillbrand :

> ​Hi All-
>
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
>
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.
>
> I've tested on a homebrew-based Mac install as well as Linux but haven't
> verified MSW, if someone would be willing to test it there, that would be
> great!  The basic search routines are lightly modified from FreeCAD's logic
> and keep their LGPL copyright on the CMake file.
>
> -Seth​
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Wayne Stambaugh]

Seth,

Looking at the information at hand, I'm comfortable adding occ.  I was
working under the assumption that you were making occ and option for oce
but after looking at the patch, I see that is not the case.  Please
revise your patch to make occ an optional replacement for oce and keep
oce as the default.  There are (were?) known issues with occ the last I
heard and I believe we have all platforms working fine with oce.  I
would be more comfortable with making occ optional.

Thanks,

Wayne

On 01/29/2018 03:24 PM, Seth Hillbrand wrote:
> Maybe the confusion is between LGPL v2.1, which is compatible with GPL3
> and GPL2, which is not.  There are two aspects here:
> 
> - Clause 3 states that we can substitute GPL v2 or any newer version
> instead of LGPL v2.1.  That would apply if we decided to use a copy of
> the library (e.g. static linking)
> 
> - But there is also Clause 6 that covers us: "As an exception to the
> Sections above, you may also combine or link a "work that uses the
> Library" with the Library to produce a work containing portions of the
> Library, and distribute that work under terms of your choice, provided
> that the terms permit modification of the work for the customer's own
> use and reverse engineering for debugging such modifications."
> 
> -S
> 
> 2018-01-29 12:04 GMT-08:00 Wayne Stambaugh  >:
> 
> Hey Seth,
> 
> One of us missed something.  Here is my interpretation:
> 
> The opencascade website license states:
> 
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional
> exception."
> 
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
> 
> According to the folks at the FSF:
> 
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
> 
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
> 
> Thanks,
> 
> Wayne
> 
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > My reading of your links is different.  Here's the relevant quote:
> >
> > "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
> > is the previous version of the LGPL: a free software license, but not a
> > strong copyleft license, because it permits linking with nonfree
> > modules. It is compatible with GPLv2 and GPLv3."
> >
> > Did I miss something?
> >
> > -Seth
> >
> > 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh  
> > >>:
> >
> >     Seth,
> >
> >     There maybe licensing issues involved with this.  OpenCascade is
> >     licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
> >     compatible with GPL 3[2].  If OpenCascade is willing to change
> their
> >     license LPGL 2.1 or later or if this is just an oversight on
> their part,
> >     than I can include this patch.  Please verify the OpenCascade
> license
> >     with something that I can verify to ensure we are not
> violating and
> >     licensing terms.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     [1]: https://www.opencascade.com/content/licensing
> 
> >      >
> >     [2]:
> >   
>  https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses
> 
> >   
>   >
> >
> >     On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> >     > ​Hi All-
> >     >
> >    

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Maybe the confusion is between LGPL v2.1, which is compatible with GPL3 and
GPL2, which is not.  There are two aspects here:

- Clause 3 states that we can substitute GPL v2 or any newer version
instead of LGPL v2.1.  That would apply if we decided to use a copy of the
library (e.g. static linking)

- But there is also Clause 6 that covers us: "As an exception to the
Sections above, you may also combine or link a "work that uses the Library"
with the Library to produce a work containing portions of the Library, and
distribute that work under terms of your choice, provided that the terms
permit modification of the work for the customer's own use and reverse
engineering for debugging such modifications."

-S

2018-01-29 12:04 GMT-08:00 Wayne Stambaugh :

> Hey Seth,
>
> One of us missed something.  Here is my interpretation:
>
> The opencascade website license states:
>
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional
> exception."
>
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
>
> According to the folks at the FSF:
>
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
>
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
>
> Thanks,
>
> Wayne
>
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > My reading of your links is different.  Here's the relevant quote:
> >
> > "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
> > is the previous version of the LGPL: a free software license, but not a
> > strong copyleft license, because it permits linking with nonfree
> > modules. It is compatible with GPLv2 and GPLv3."
> >
> > Did I miss something?
> >
> > -Seth
> >
> > 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh  > >:
> >
> > Seth,
> >
> > There maybe licensing issues involved with this.  OpenCascade is
> > licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
> > compatible with GPL 3[2].  If OpenCascade is willing to change their
> > license LPGL 2.1 or later or if this is just an oversight on their
> part,
> > than I can include this patch.  Please verify the OpenCascade license
> > with something that I can verify to ensure we are not violating and
> > licensing terms.
> >
> > Cheers,
> >
> > Wayne
> >
> > [1]: https://www.opencascade.com/content/licensing
> > 
> > [2]:
> > https://www.gnu.org/licenses/license-list.en.html#
> GPLCompatibleLicenses
> >  GPLCompatibleLicenses>
> >
> > On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> > > ​Hi All-
> > >
> > > Currently, the build requires the opencascade community edition.
> For
> > > various reasons, I need to have the current non-community edition
> of
> > > OpenCASCADE installed on my work machine.
> > >
> > > The attached patch allows compiling KiCad with either the
> OpenCASCADE
> > > community edition or standard edition.
> > >
> > > I've tested on a homebrew-based Mac install as well as Linux but
> > haven't
> > > verified MSW, if someone would be willing to test it there, that
> would
> > > be great!  The basic search routines are lightly modified from
> > FreeCAD's
> > > logic and keep their LGPL copyright on the CMake file.
> > >
> > > -Seth​
> > >
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Wayne Stambaugh]

We might actually have an out.  The exception specifies:

"Open CASCADE exception (version 1.0) to GNU LGPL version 2.1.

The object code (i.e. not a source) form of a "work that uses the
Library" can incorporate material from a header file that is part of the
Library.  As a special exception to the GNU Lesser General Public
License version 2.1, you may distribute such object code incorporating
material from header files provided with the Open CASCADE Technology
libraries (including code of CDL generic classes) under terms of your
choice, provided that you give prominent notice in supporting
documentation to this code that it makes use of or is based on
facilities provided by the Open CASCADE Technology software."

So it appears since we are only using oce as a library and we are afaik
not modifying any of the oce or opencascade source files, we should be
able to use it with any license of our choice.  Anyone interpreting this
differently than I am?


On 1/29/2018 3:12 PM, José Ignacio wrote:
> I think you might be confusing the GPL with the *L*GPL, they are very
> different licenses in practice
> 
> On Mon, Jan 29, 2018 at 2:04 PM, Wayne Stambaugh  > wrote:
> 
> Hey Seth,
> 
> One of us missed something.  Here is my interpretation:
> 
> The opencascade website license states:
> 
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional
> exception."
> 
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
> 
> According to the folks at the FSF:
> 
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
> 
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
> 
> Thanks,
> 
> Wayne
> 
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > My reading of your links is different.  Here's the relevant quote:
> >
> > "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
> > is the previous version of the LGPL: a free software license, but not a
> > strong copyleft license, because it permits linking with nonfree
> > modules. It is compatible with GPLv2 and GPLv3."
> >
> > Did I miss something?
> >
> > -Seth
> >
> > 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh  
> > >>:
> >
> >     Seth,
> >
> >     There maybe licensing issues involved with this.  OpenCascade is
> >     licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
> >     compatible with GPL 3[2].  If OpenCascade is willing to change
> their
> >     license LPGL 2.1 or later or if this is just an oversight on
> their part,
> >     than I can include this patch.  Please verify the OpenCascade
> license
> >     with something that I can verify to ensure we are not
> violating and
> >     licensing terms.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     [1]: https://www.opencascade.com/content/licensing
> 
> >      >
> >     [2]:
> >   
>  https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses
> 
> >   
>   >
> >
> >     On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> >     > ​Hi All-
> >     >
> >     > Currently, the build requires the opencascade community
> edition.  For
> >     > various reasons, I need to have the current non-community
> edition 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[José Ignacio]

I think you might be confusing the GPL with the *L*GPL, they are very
different licenses in practice

On Mon, Jan 29, 2018 at 2:04 PM, Wayne Stambaugh 
wrote:

> Hey Seth,
>
> One of us missed something.  Here is my interpretation:
>
> The opencascade website license states:
>
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional
> exception."
>
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
>
> According to the folks at the FSF:
>
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
>
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
>
> Thanks,
>
> Wayne
>
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
> > Hi Wayne-
> >
> > My reading of your links is different.  Here's the relevant quote:
> >
> > "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
> > is the previous version of the LGPL: a free software license, but not a
> > strong copyleft license, because it permits linking with nonfree
> > modules. It is compatible with GPLv2 and GPLv3."
> >
> > Did I miss something?
> >
> > -Seth
> >
> > 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh  > >:
> >
> > Seth,
> >
> > There maybe licensing issues involved with this.  OpenCascade is
> > licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
> > compatible with GPL 3[2].  If OpenCascade is willing to change their
> > license LPGL 2.1 or later or if this is just an oversight on their
> part,
> > than I can include this patch.  Please verify the OpenCascade license
> > with something that I can verify to ensure we are not violating and
> > licensing terms.
> >
> > Cheers,
> >
> > Wayne
> >
> > [1]: https://www.opencascade.com/content/licensing
> > 
> > [2]:
> > https://www.gnu.org/licenses/license-list.en.html#
> GPLCompatibleLicenses
> >  GPLCompatibleLicenses>
> >
> > On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> > > ​Hi All-
> > >
> > > Currently, the build requires the opencascade community edition.
> For
> > > various reasons, I need to have the current non-community edition
> of
> > > OpenCASCADE installed on my work machine.
> > >
> > > The attached patch allows compiling KiCad with either the
> OpenCASCADE
> > > community edition or standard edition.
> > >
> > > I've tested on a homebrew-based Mac install as well as Linux but
> > haven't
> > > verified MSW, if someone would be willing to test it there, that
> would
> > > be great!  The basic search routines are lightly modified from
> > FreeCAD's
> > > logic and keep their LGPL copyright on the CMake file.
> > >
> > > -Seth​
> > >
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
> >
> >
> >
> > ___
> > Mailing list: 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Andrew Zonenberg]

My understanding is that LGPL can be DYNAMICALLY linked with arbitrarily
licensed code (GPL of any version, proprietary, permissive, etc) as long as:

1) any modifications to the LGPL'd module are redistributed under the
copyleft terms of the LGPL, and
2) patched/updated versions of the LGPL module can be freely swapped for
the original (no signature checks etc)

Static linking is a whole other can of worms because now you have a new
derived work which is a combination of the two. It may indeed be the
case that LGPL 2.1-only and GPL 3+ cannot be STATICALLY linked. But my
reading of the license does not in any way prohibit dynamic linking.

On 29/01/18 12:04, Wayne Stambaugh wrote:
> Hey Seth,
> 
> One of us missed something.  Here is my interpretation:
> 
> The opencascade website license states:
> 
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional exception."
> 
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
> 
> According to the folks at the FSF:
> 
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
> 
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
> 
> Thanks,
> 
> Wayne
> 
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
>> Hi Wayne-
>>
>> My reading of your links is different.  Here's the relevant quote:
>>
>> "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
>> is the previous version of the LGPL: a free software license, but not a
>> strong copyleft license, because it permits linking with nonfree
>> modules. It is compatible with GPLv2 and GPLv3."
>>
>> Did I miss something?
>>
>> -Seth
>>
>> 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh > >:
>>
>> Seth,
>>
>> There maybe licensing issues involved with this.  OpenCascade is
>> licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
>> compatible with GPL 3[2].  If OpenCascade is willing to change their
>> license LPGL 2.1 or later or if this is just an oversight on their part,
>> than I can include this patch.  Please verify the OpenCascade license
>> with something that I can verify to ensure we are not violating and
>> licensing terms.
>>
>> Cheers,
>>
>> Wayne
>>
>> [1]: https://www.opencascade.com/content/licensing
>> 
>> [2]:
>> https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses
>> 
>>
>> On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
>> > ​Hi All-
>> >
>> > Currently, the build requires the opencascade community edition.  For
>> > various reasons, I need to have the current non-community edition of
>> > OpenCASCADE installed on my work machine.
>> >
>> > The attached patch allows compiling KiCad with either the OpenCASCADE
>> > community edition or standard edition.  
>> >
>> > I've tested on a homebrew-based Mac install as well as Linux but
>> haven't
>> > verified MSW, if someone would be willing to test it there, that would
>> > be great!  The basic search routines are lightly modified from
>> FreeCAD's
>> > logic and keep their LGPL copyright on the CMake file.
>> >
>> > -Seth​
>> >
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> 
>> > Post to     : kicad-developers@lists.launchpad.net
>> 
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> > More help   : https://help.launchpad.net/ListHelp
>> 
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Simon Wells]

please see https://lists.launchpad.net/kicad-developers/msg31544.html 


There are different minimum versions required of OCCT and nick also had issues 
with occt working iirc

i think i would still prefer being able to set whether to allow occ in place of 
oce as was my initial thoughts but i have not worked on this due to the issues 
experienced by nick


btw as oce is just a fork of occt would that not have the same issues?

> On 30/01/2018, at 9:04 AM, Wayne Stambaugh  wrote:
> 
> Hey Seth,
> 
> One of us missed something.  Here is my interpretation:
> 
> The opencascade website license states:
> 
> "Open CASCADE Technology version 6.7.0 and later are governed by GNU
> Lesser General Public License (LGPL) version 2.1 with additional exception."
> 
> It makes no mention of later versions of the LGPL (including the
> exception) so I am interpreting this as v2.1 only.  I do not have a copy
> (and I'm not going to sign up to get a copy so please check the
> copyright in the source to see if it matches the website) of the
> opencascade source archive to see if the license in the source
> specifically states "v2.1 or (at your option) any later version" which
> is typically how the GPL and LGPL are used.  If it does, than I can
> safely add this patch because I can make the claim that I am using
> opencascade under at later version of the LGPL which is compatible with
> the GPL 3 used by kicad.
> 
> According to the folks at the FSF:
> 
> "Please note that GPLv2 is, by itself, not compatible with GPLv3.
> However, most software released under GPLv2 allows you to use the terms
> of later versions of the GPL as well. When this is the case, you can use
> the code under GPLv3 to make the desired combination. To learn more
> about compatibility between GNU licenses, please see our FAQ."
> 
> I hope this clarifies why I am hesitant to merge this patch and what
> needs to clarified.  Isn't licensing fun! ;)
> 
> Thanks,
> 
> Wayne
> 
> On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
>> Hi Wayne-
>> 
>> My reading of your links is different.  Here's the relevant quote:
>> 
>> "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
>> is the previous version of the LGPL: a free software license, but not a
>> strong copyleft license, because it permits linking with nonfree
>> modules. It is compatible with GPLv2 and GPLv3."
>> 
>> Did I miss something?
>> 
>> -Seth
>> 
>> 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh > >>:
>> 
>>Seth,
>> 
>>There maybe licensing issues involved with this.  OpenCascade is
>>licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
>>compatible with GPL 3[2].  If OpenCascade is willing to change their
>>license LPGL 2.1 or later or if this is just an oversight on their part,
>>than I can include this patch.  Please verify the OpenCascade license
>>with something that I can verify to ensure we are not violating and
>>licensing terms.
>> 
>>Cheers,
>> 
>>Wayne
>> 
>>[1]: https://www.opencascade.com/content/licensing
>>> >
>>[2]:
>>https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses 
>> 
>>> >
>> 
>>On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
>>> ​Hi All-
>>> 
>>> Currently, the build requires the opencascade community edition.  For
>>> various reasons, I need to have the current non-community edition of
>>> OpenCASCADE installed on my work machine.
>>> 
>>> The attached patch allows compiling KiCad with either the OpenCASCADE
>>> community edition or standard edition.  
>>> 
>>> I've tested on a homebrew-based Mac install as well as Linux but
>>haven't
>>> verified MSW, if someone would be willing to test it there, that would
>>> be great!  The basic search routines are lightly modified from
>>FreeCAD's
>>> logic and keep their LGPL copyright on the CMake file.
>>> 
>>> -Seth​
>>> 
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> >
>>> Post to : kicad-developers@lists.launchpad.net 
>>> 
>>> >
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> 
>>> >
>>> More help   : 

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Wayne Stambaugh]

Hey Seth,

One of us missed something.  Here is my interpretation:

The opencascade website license states:

"Open CASCADE Technology version 6.7.0 and later are governed by GNU
Lesser General Public License (LGPL) version 2.1 with additional exception."

It makes no mention of later versions of the LGPL (including the
exception) so I am interpreting this as v2.1 only.  I do not have a copy
(and I'm not going to sign up to get a copy so please check the
copyright in the source to see if it matches the website) of the
opencascade source archive to see if the license in the source
specifically states "v2.1 or (at your option) any later version" which
is typically how the GPL and LGPL are used.  If it does, than I can
safely add this patch because I can make the claim that I am using
opencascade under at later version of the LGPL which is compatible with
the GPL 3 used by kicad.

According to the folks at the FSF:

"Please note that GPLv2 is, by itself, not compatible with GPLv3.
However, most software released under GPLv2 allows you to use the terms
of later versions of the GPL as well. When this is the case, you can use
the code under GPLv3 to make the desired combination. To learn more
about compatibility between GNU licenses, please see our FAQ."

I hope this clarifies why I am hesitant to merge this patch and what
needs to clarified.  Isn't licensing fun! ;)

Thanks,

Wayne

On 1/29/2018 2:47 PM, Seth Hillbrand wrote:
> Hi Wayne-
> 
> My reading of your links is different.  Here's the relevant quote:
> 
> "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This
> is the previous version of the LGPL: a free software license, but not a
> strong copyleft license, because it permits linking with nonfree
> modules. It is compatible with GPLv2 and GPLv3."
> 
> Did I miss something?
> 
> -Seth
> 
> 2018-01-29 11:18 GMT-08:00 Wayne Stambaugh  >:
> 
> Seth,
> 
> There maybe licensing issues involved with this.  OpenCascade is
> licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
> compatible with GPL 3[2].  If OpenCascade is willing to change their
> license LPGL 2.1 or later or if this is just an oversight on their part,
> than I can include this patch.  Please verify the OpenCascade license
> with something that I can verify to ensure we are not violating and
> licensing terms.
> 
> Cheers,
> 
> Wayne
> 
> [1]: https://www.opencascade.com/content/licensing
> 
> [2]:
> https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses
> 
> 
> On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> > ​Hi All-
> >
> > Currently, the build requires the opencascade community edition.  For
> > various reasons, I need to have the current non-community edition of
> > OpenCASCADE installed on my work machine.
> >
> > The attached patch allows compiling KiCad with either the OpenCASCADE
> > community edition or standard edition.  
> >
> > I've tested on a homebrew-based Mac install as well as Linux but
> haven't
> > verified MSW, if someone would be willing to test it there, that would
> > be great!  The basic search routines are lightly modified from
> FreeCAD's
> > logic and keep their LGPL copyright on the CMake file.
> >
> > -Seth​
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Seth Hillbrand]

Hi Wayne-

My reading of your links is different.  Here's the relevant quote:

"GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This is
the previous version of the LGPL: a free software license, but not a strong
copyleft license, because it permits linking with nonfree modules. It is
compatible with GPLv2 and GPLv3."

Did I miss something?

-Seth

2018-01-29 11:18 GMT-08:00 Wayne Stambaugh :

> Seth,
>
> There maybe licensing issues involved with this.  OpenCascade is
> licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
> compatible with GPL 3[2].  If OpenCascade is willing to change their
> license LPGL 2.1 or later or if this is just an oversight on their part,
> than I can include this patch.  Please verify the OpenCascade license
> with something that I can verify to ensure we are not violating and
> licensing terms.
>
> Cheers,
>
> Wayne
>
> [1]: https://www.opencascade.com/content/licensing
> [2]: https://www.gnu.org/licenses/license-list.en.html#
> GPLCompatibleLicenses
>
> On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> > ​Hi All-
> >
> > Currently, the build requires the opencascade community edition.  For
> > various reasons, I need to have the current non-community edition of
> > OpenCASCADE installed on my work machine.
> >
> > The attached patch allows compiling KiCad with either the OpenCASCADE
> > community edition or standard edition.
> >
> > I've tested on a homebrew-based Mac install as well as Linux but haven't
> > verified MSW, if someone would be willing to test it there, that would
> > be great!  The basic search routines are lightly modified from FreeCAD's
> > logic and keep their LGPL copyright on the CMake file.
> >
> > -Seth​
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

[Wayne Stambaugh]

Seth,

There maybe licensing issues involved with this.  OpenCascade is
licensed using LGPL v2.1 not v2.1[1] or later.  LGPL v2.1 is not
compatible with GPL 3[2].  If OpenCascade is willing to change their
license LPGL 2.1 or later or if this is just an oversight on their part,
than I can include this patch.  Please verify the OpenCascade license
with something that I can verify to ensure we are not violating and
licensing terms.

Cheers,

Wayne

[1]: https://www.opencascade.com/content/licensing
[2]: https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses

On 1/29/2018 1:54 PM, Seth Hillbrand wrote:
> ​Hi All-
> 
> Currently, the build requires the opencascade community edition.  For
> various reasons, I need to have the current non-community edition of
> OpenCASCADE installed on my work machine.
> 
> The attached patch allows compiling KiCad with either the OpenCASCADE
> community edition or standard edition.  
> 
> I've tested on a homebrew-based Mac install as well as Linux but haven't
> verified MSW, if someone would be willing to test it there, that would
> be great!  The basic search routines are lightly modified from FreeCAD's
> logic and keep their LGPL copyright on the CMake file.
> 
> -Seth​
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp