[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer changed: What|Removed |Added CC||tmis...@gmail.com ---

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Martin Renvoize changed: What|Removed |Added Blocks||23809 Referenced Bugs:

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Jonathan Druart changed: What|Removed |Added Blocks||23265 Referenced Bugs:

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #91 from Katrin Fischer --- *** Bug 12353 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Nick Clemens changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marc Véron changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #90 from Katrin Fischer --- Also, what changes for libraries not using the cronjob to automatically expire holds? We don't use this because libraries often want to leave the book on a few days

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #89 from Katrin Fischer --- I think it would be good to have the "Text to go in the release notes" filled for this one, describing the change to the libraries updating. -- You are receiving

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer changed: What|Removed |Added Resolution|---

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #85 from Marcel de Rooy --- Created attachment 63099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63099=edit Bug 12063: [QA Follow-up] Small change of two test scripts

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #63057|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #84 from Marcel de Rooy --- Created attachment 63098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63098=edit Bug 12063: [QA Follow-up] Adjustments to db revision Replace

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #62002|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #62004|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #62474|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #62005|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #62001|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Attachment #62003|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #76 from Alex Arnaud --- Created attachment 63057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63057=edit Bug 12063 - Remove checking of ExpireReservesMaxPickUpDelay in

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #75 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #73) > And note that CancelExpiredReserves is only caled by the script > misc/cronjobs/holds/cancel_expired_holds.pl. Nowhere

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #74 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #72) > (In reply to Marcel de Rooy from comment #71) > > The situation I described is independent of this pref. You could use

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #73 from Alex Arnaud --- And note that CancelExpiredReserves is only caled by the script misc/cronjobs/holds/cancel_expired_holds.pl. Nowhere else if i'm not wrong. So if we remove the check of

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #72 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #71) > The situation I described is independent of this pref. You could use the > cron job to remove expired reserves based on

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #71 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #69) > (In reply to Marcel de Rooy from comment #68) > > sub CancelExpiredReserves { > > +return unless

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #70 from Alex Arnaud --- (In reply to Alex Arnaud from comment #69) > (In reply to Marcel de Rooy from comment #68) > > sub set_waiting { > > [...] > > +if (

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #69 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #68) > Still working on this one now. > Preliminary results: > > sub CancelExpiredReserves { > +return unless

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #68 from Marcel de Rooy --- Still working on this one now. Preliminary results: sub CancelExpiredReserves { +return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); This may

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #67 from Alex Arnaud --- Created attachment 62474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62474=edit Bug 12063 - make perl atomic update follow skeleton.perl -- You

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #66 from Marcel de Rooy --- Could you please have another look at comment60 for the two atomic update files? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #61735|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #61461|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #59162|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #61401|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #59161|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #58 from Alex Arnaud --- Created attachment 61735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61735=edit Bug 12063 - Fix QA failures - Remove expiration date calculation

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #57 from Alex Arnaud --- Yup, good catch Marcel. Will fix that asap -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #55 from Marcel de Rooy --- About the atomic update (db revision): You add the pref, but we should also take into account all waiting reserves now and look at/calculate their expiration date.

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #56 from Marcel de Rooy --- New sub days_foward: Please add a unit test for this routine. In Calendar.t? Or Holidays.t? Also note that the while loop is very dangerous if you would pass a

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #54 from Marcel de Rooy --- Also please look here in circ/waitingreserves.pl ( $waiting_year, $waiting_month, $waiting_day ) = Add_Delta_Days( $waiting_year, $waiting_month,

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #53 from Marcel de Rooy --- Please look at this code in C4/Letters.pm: if ( $table eq 'reserves' && $values->{'waitingdate'} ) { my @waitingdate = split /-/,

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #52 from Marcel de Rooy --- Well, holds patches are not simple at least. Submitting a few comments collected so far. Do not give up. We are improving on the way. -- You are receiving this mail

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #51 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #50 from Alex Arnaud --- It should be ok now (Sorry Marcel and ths for the review) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #61440|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #48 from Andreas Hedström Mace --- (In reply to Marcel de Rooy from comment #44) > (In reply to Andreas Hedström Mace from comment #41) > > And yes that is the same settings I was using.

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #46 from Alex Arnaud --- Created attachment 61440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61440=edit Bug 12063 - Fix unit tests -- You are receiving this mail

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #44 from Marcel de Rooy --- (In reply to Andreas Hedström Mace from comment #41) > And yes that is the same settings I was using. Since it works for both of > you, I'm going to assume that

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace changed: What|Removed |Added Attachment #59165|0

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #43 from Marcel de Rooy --- Ah great. I will be looking again at this one very soon. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #40 from Koha Team Lyon 3 --- hello Andreas, I have tested one more time but I can't reproduce your issue. you said : "one might want to exclude holidays but still apply a fee for those who doesn’t

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #39 from Alex Arnaud --- (In reply to Andreas Hedström Mace from comment #37) > Tested and everything works as intended, except that it is not possible to > cancel holds with the cronjob in >

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace changed: What|Removed |Added Status|Patch doesn't

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #38 from Marcel de Rooy --- (In reply to Andreas Hedström Mace from comment #37) > Tested and everything works as intended, except that it is not possible to > cancel holds with the cronjob in >

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #59163|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #53100|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #34 from Alex Arnaud --- Created attachment 59163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59163=edit Bug 12063 - Keep patron's requested expiration date if it is prior

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What|Removed |Added Attachment #53101|0 |1

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #31 from Andreas Hedström Mace --- Brilliant! I hope this is doable, and we are also able to test and (possibly) sign off! -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #30 from Koha Team Lyon 3 --- Hurrah! We have an agreement ;-) Is it difficult to add this verification to the patch ? We can re-test it and it can pursue his way toward the "Pushed to master"

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #29 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #28) > > Hello Sonia, > > I'm not comfortable with having two expirationdate fields. And i think we > can spare ourselves from

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #28 from Alex Arnaud --- (In reply to Koha Team Lyon 3 from comment #27) > Hello, > I'm afraid that we are mired in a never ending discussion. > For me, as I have already sayd, there's no reason

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #27 from Koha Team Lyon 3 --- Hello, I'm afraid that we are mired in a never ending discussion. For me, as I have already sayd, there's no reason to keep expirationday after the hold is available and

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Christopher Davis changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Lisette changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #26 from Alex Arnaud --- (In reply to Viccy Kemp from comment #25) > I do not understand what Alex and Marcel are working on here. All I know is > it appears that reserves do not take into

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #25 from Viccy Kemp --- I do not understand what Alex and Marcel are working on here. All I know is it appears that reserves do not take into account the dates when the library is closed.

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #24 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #23) > (In reply to Alex Arnaud from comment #22) > > For me there is two case: > > > > 1) The expiration date set by the

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #23 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #22) > For me there is two case: > > 1) The expiration date set by the patron is higher than the calculated > expiration date

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #22 from Alex Arnaud --- For me there is two case: 1) The expiration date set by the patron is higher than the calculated expiration date (that take into account pickup delay and holiday). In

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #21 from Andreas Hedström Mace --- (In reply to Marcel de Rooy from comment #19) > Hi Andreas, > Thx for your feedback. > I read it again too now. This patch tries to achieve its goal by

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Sally Healey changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Viccy Kemp changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #19 from Marcel de Rooy --- (In reply to Andreas Hedström Mace from comment #18) > Without having actually tested this bug, only reading the discussion, I > would say that I have to agree with

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Ola Andersson changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Andreas Hedström Mace changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #17 from Koha Team Lyon 3 --- Hi Katrin, Hi Marcel, >From what I have understood, but I may be wrong, patrons can put an expirationdate to say that they're not interested in this reservation if it's

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #16 from Koha Team Lyon 3 --- Hi Katrin, Hi Marcel, For what I have understood, but I maybe wrong, patrons can put an expirationdate to say that they're not interstesting in this reservation if it's

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #15 from Katrin Fischer --- I wonder if it could be irritatng to the user to find the date entered changed. I am not sure if libraries print those in notices, but they show up in the OPAC. --

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What|Removed |Added CC|

  1   2   >