https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Blocks||28353
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Blocks||27525
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Blocks||25469
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Chris Slone changed:
What|Removed |Added
CC||cslone@camdencountylibrary.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Blocks||25718
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Barton Chittenden changed:
What|Removed |Added
CC|barton...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #97 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #96 from Jonathan Druart
---
Created attachment 104682
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104682=edit
Bug 8132: Fix failing tests
* Add missing html filter (xt/find-missing-filters.t)
*
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #95 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #94 from Marcel de Rooy ---
Okay, last chance for string freeze.
@RM: As my latest comments indicate, I am not completely enthusiastic about
aspects of this patch set. But no definitive blocker on the other hand..
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #93 from Marcel de Rooy ---
Created attachment 104571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104571=edit
Bug 8132: (QA follow-up) Missing filter
Signed-off-by: Marcel de Rooy
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Attachment #103169|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Attachment #103166|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Attachment #103168|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Attachment #103167|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #88 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #87)
Again, the only things this change does is:
* Add feedback on the interface about items that cannot be deleted (existing
behaviour with the 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #87 from Marcel de Rooy ---
The second patch here actually says that it is not 'safe to delete' the only
remaining item where the biblio has a biblio level hold.
I do not agree with that statement. The item can perfectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #86
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #85 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #84)
> (In reply to Jonathan Druart from comment #83)
> > (In reply to Marcel de Rooy from comment #82)
> > > (In reply to Jonathan Druart from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #84 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #83)
> (In reply to Marcel de Rooy from comment #82)
> > (In reply to Jonathan Druart from comment #81)
> > > What do you suggest?
> >
> > Maybe we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #83 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #82)
> (In reply to Jonathan Druart from comment #81)
> > What do you suggest?
>
> Maybe we should stick to the scope that the title suggests. Do not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #82 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #81)
> What do you suggest?
Maybe we should stick to the scope that the title suggests. Do not delete items
with holds. Biblio level holds are out of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #81 from Jonathan Druart
---
Hi Marcel,
Thanks for taking a look at this.
(In reply to Marcel de Rooy from comment #79)
> "If an item is the last one of a biblio that have biblio-level hold
> placed on it, we should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #80
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #79 from Marcel de Rooy ---
"If an item is the last one of a biblio that have biblio-level hold
placed on it, we should block the deletion."
Well, this is quite arguable. Imo probably cleanup_database could remove holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #78 from Marcel de Rooy ---
Bit weird that sub safe_to_delete returns 1 or a string.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #77
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #75 from Victor Grousset/tuxayo ---
Thanks Kelly for the double check, I wasn't confident about how holds should
work.
So, 2nd sign off and minor details added to the test plan:
- about apply all the patches at the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #103150|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #103149|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #103148|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #103147|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
ByWater Sandboxes changed:
What|Removed |Added
Attachment #101406|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
ByWater Sandboxes changed:
What|Removed |Added
Attachment #101405|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
ByWater Sandboxes changed:
What|Removed |Added
Attachment #101407|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Kelly McElligott changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
ByWater Sandboxes changed:
What|Removed |Added
Attachment #101404|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #66 from Victor Grousset/tuxayo ---
> "Has been effective", so you should be on the next screen, not the
> confirmation screen.
Okay, indeed after confirmation the deletion works.
>> I guess that's not an issue. But I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #65 from Jonathan Druart
---
(In reply to Victor Grousset/tuxayo from comment #64)
> > => delete of item from B4 is *not* blocked - there is a hold but it is not
> > found
>
> I don't get it. No sign of something not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #64 from Victor Grousset/tuxayo ---
> => delete of item from B4 is *not* blocked - there is a hold but it is not
> found
I don't get it. No sign of something not being found.
I have this:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #63 from Jonathan Druart
---
(In reply to Victor Grousset/tuxayo from comment #62)
> Trying to signoff.
>
> > Create Biblio B3 with 1+ item
>
> Does this mean that B3 *must* have more than on item?
At least one item.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #60 from Jonathan Druart
---
This patch is an enhancement in the sense that it displays useful info about
"deletion impossible", but can be considered as a bugfix (and so backported) as
it will prevent phantom holds.
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #59 from Kelly McElligott ---
I agree with Sonia. Although yes the scope of the bug is to
Block deletion of the last item for a Biblio on which a hold is placed on, to
avoid phantom holds (original issue reported)
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #58 from Jonathan Druart
---
Thanks for testing Sonia!
What this change does basically is:
* Improve feedback to the end user: why this item cannot be deleted
* Block deletion of the last item for a biblio on which a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Koha Team University Lyon 3 changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
URL|https://gitlab.com/joubu/Ko |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #55 from Jonathan Druart
---
Created attachment 101406
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101406=edit
Bug 8132: Delete the items in a transaction and rollback if something wrong
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #56 from Jonathan Druart
---
Created attachment 101407
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101407=edit
Bug 8132: Adding message when deleting from the UI
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Attachment #98694|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #54 from Jonathan Druart
---
Created attachment 101405
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101405=edit
Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion
If an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #50 from Jonathan Druart
---
Created attachment 98697
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98697=edit
Bug 8132: Adding message when deleting from the UI
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #48 from Jonathan Druart
---
Created attachment 98695
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98695=edit
Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion
If an item is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Attachment #96147|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #49 from Jonathan Druart
---
Created attachment 98696
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98696=edit
Bug 8132: Delete the items in a transaction and rollback if something wrong
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #46 from Martin Renvoize ---
Looks promising, but needs a rebase I'm afraid.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #45 from Jonathan Druart
---
(In reply to Kelly McElligott from comment #44)
> Hi Martin,
> Attempted to sign off on this bug Martin,
> Looks like something in the Bug that this is dependant (23463) on has
> changed, I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #44 from Kelly McElligott ---
Hi Martin,
Attempted to sign off on this bug Martin,
Looks like something in the Bug that this is dependant (23463) on has changed,
I received this error while testing:
Template process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #43 from Martin Renvoize ---
Still testing this Kelly?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #42 from Kelly McElligott ---
Let me test again, using the back button did not save my barcodes in the Batch
Item Deletion tool. I will attempt this again.
I understand what you mean with the non-triggered holds and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #41 from Jonathan Druart
---
(In reply to Kelly McElligott from comment #39)
> Jonathan,
> Two issues that I have with this:
>
> In this step:
>
> 2/ Select them and confirm the deletion
> => Nothing happened and you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #40 from Jonathan Druart
---
(In reply to Kelly McElligott from comment #39)
> Jonathan,
> Two issues that I have with this:
>
> In this step:
>
> 2/ Select them and confirm the deletion
> => Nothing happened and you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #39 from Kelly McElligott ---
Jonathan,
Two issues that I have with this:
In this step:
2/ Select them and confirm the deletion
=> Nothing happened and you get a message saying that one of the 2 items
from B2 is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #31 from Jonathan Druart
---
(In reply to Kelly McElligott from comment #29)
> I did not see the message that is indicated in step 2. " Nothing happened
> and you get a message saying that one of the 2 items
> from B2 is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #38 from Jonathan Druart
---
I have adjusted the test plan and updated the patch (remote branch is still
up-to-date).
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Attachment #95936|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #37 from Jonathan Druart
---
Created attachment 96150
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96150=edit
Bug 8132: Adding message when deleting from the UI
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #35 from Jonathan Druart
---
Created attachment 96148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96148=edit
Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion
If an item is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #36 from Jonathan Druart
---
Created attachment 96149
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96149=edit
Bug 8132: Delete the items in a transaction and rollback if something wrong
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #32 from Jonathan Druart
---
Update test plan:
> 0/ Setup
> Create Biblio B1 with 1 item
> Create Biblio B2 with 2 items
> Create Biblio B3 with 1+ item
> Create Biblio B4 with 1+ item
> Place a biblio-level hold on B1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #33
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #30 from Kelly McElligott ---
Created attachment 95997
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95997=edit
delete message
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Kelly McElligott changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Depends on||23463
URL|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #27 from Jonathan Druart
---
Created attachment 95939
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95939=edit
Bug 8132: Adding message when deleting from the UI
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #26 from Jonathan Druart
---
Created attachment 95938
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95938=edit
Bug 8132: Delete the items in a transaction and rollback if something wrong
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #25 from Jonathan Druart
---
Created attachment 95937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95937=edit
Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion
If an item is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #24 from Jonathan Druart
---
Created attachment 95936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95936=edit
Bug 8132: No changes but disable checkboxes
When the list of items is displayed we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Jonathan Druart changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Martin Renvoize changed:
What|Removed |Added
Severity|critical|major
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_05_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Katrin Fischer changed:
What|Removed |Added
Summary|batch delete tool deletes |Batch delete tool deletes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #23 from Katrin Fischer ---
(In reply to Christopher Brannon from comment #22)
> (In reply to Jonathan Druart from comment #21)
> > Trying to get back to this.
> >
> > Are we supposed to silently delete an item with an
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #22 from Christopher Brannon ---
(In reply to Jonathan Druart from comment #21)
> Trying to get back to this.
>
> Are we supposed to silently delete an item with an item-level hold that is
> not found (W or T)?
In my
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
--- Comment #21 from Jonathan Druart
---
Trying to get back to this.
Are we supposed to silently delete an item with an item-level hold that is not
found (W or T)?
--
You are receiving this mail because:
You are the assignee for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132
Pulugurtha durga srinivas sarama changed:
What|Removed |Added
QA Contact|
1 - 100 of 124 matches
Mail list logo