[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||36072

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||26638


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638
[Bug 26638] pref ArticleRequestsMandatoryFieldsItemsOnly is never used
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||22068

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21575


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21575
[Bug 21575] Fix ArticleRequestsMandatoryFieldsItem(s)Only variants
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #270 from Pedro Amorim  ---
Jonathan thank you for your reply, it got me on the right track:

Turns out the problem has nothing to do with this (what threw me off was the
null in the database, because I always saw it defined for the password recovery
e-mail for example).

The problem I'm having is actually related to the cronjob itself, more
precisely https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 it
seems.
Sorry for posting here as it turns out it's not related.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #269 from Jonathan Druart  
---
Pedro, the email is picked when the emails are going to be sent, see
C4::Letters::_send_message_by_email:

1258 my $patron = Koha::Patrons->find( $message->{borrowernumber} );
1259 my $to_address = $message->{'to_address'};
1260 unless ($to_address) {

Are you sure the user has a valid email address? If yes, please open a new bug
report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Pedro Amorim  changed:

   What|Removed |Added

 CC||pjamori...@gmail.com

--- Comment #268 from Pedro Amorim  ---
Hello everyone, after using this feature I noticed that e-mails are not being
sent for patrons upon status update for the article requests.

I checked the database and the to_address field is NULL in the message_queue
table.

Could it be that we need to define

to_address => $borrower{'email'},
from_address =>   C4::Context->preference('KohaAdminEmailAddress'),

in the EnqueueLetter call in

https://github.com/Koha-Community/Koha/blob/master/Koha/ArticleRequest.pm#L124

Or am I missing something else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20459


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20459
[Bug 20459] Correct message for cancelling an article request
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Michael Kuhn  changed:

   What|Removed |Added

 CC||m...@adminkuhn.ch

--- Comment #267 from Michael Kuhn  ---
It actually got (after 16.11) again into the release notes for Koha 17.05 (
https://koha-community.org/koha-17-05-released/ ) even if it is not a new
feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #266 from Katrin Fischer  ---
Be careful, just created release notes for 17.05 for a test and this is listed
as new features (follow up pushed after release of 16.11 with this bug
number...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18466


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466
[Bug 18466] No article requests breaks the opac-user-views block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18476

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18395

--- Comment #265 from Jonathan Druart  
---
There is something very wrong with the new subroutines, they have been added to
both Koha::Patron and Koha::Patrons:

% git grep 'sub article_request' Koha/Patron*.pm
Koha/Patron.pm:sub article_requests {
Koha/Patron.pm:sub article_requests_current {
Koha/Patron.pm:sub article_requests_finished {
Koha/Patrons.pm:sub article_requests {
Koha/Patrons.pm:sub article_requests_current {
Koha/Patrons.pm:sub article_requests_finished {

See bug 18395.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395
[Bug 18395] Wrong article request methods in Koha::Patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #264 from Katrin Fischer  ---
(In reply to David Cook from comment #263)
> I'm curious why the "date" field has a "text" type. I haven't seen an
> example of "date" in this patch, so I'm curious as to how it gets used...

Can be a year or the date an issue was published, doesn't have to be a
formatted date. (iirc)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #263 from David Cook  ---
I'm curious why the "date" field has a "text" type. I haven't seen an example
of "date" in this patch, so I'm curious as to how it gets used...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #262 from Katrin Fischer  ---
Follow-up 6b0562eee87e80532d6abb423177c76062be84cc has been pushed to 16.11.x
and will be in 16.11.2.

Please don't reuse bug numbers like this - it will make release notes be wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17709
[Bug 17709] Article request broken - 'internal server error'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #261 from Mason James  ---
(In reply to Kyle M Hall from comment #257)
> Pushed to master for 16.11, thanks for the followups Katrin!

new feature, passing for 16.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
  Text to go in the||Add ability to place
  release notes||article requests in Koha.
   ||Article Requests are
   ||somewhat similar to holds,
   ||but are not requests for an
   ||item to check out. Instead,
   ||article requests are
   ||requests for a photocopy of
   ||a particular section of a
   ||book ( most often ). This
   ||is very common in academic
   ||libraries where researchers
   ||may request a copy of a
   ||single article found in a
   ||journal.
   ||This patch set
   ||adds the ability to place
   ||article requests in Koha.
   ||It allows the control of
   ||what can be requested via
   ||the circulation rules.
   ||Since article requests of
   ||electronic resources are
   ||not outside the realm of
   ||possibility, the feature
   ||will check not only the
   ||items for requstability,
   ||but the record itself as
   ||well ( i.e. both
   ||items.itype and
   ||biblio.itemtype ).
   ||Article
   ||requests can be placed for
   ||patrons from the opac and
   ||staff intranet and can be
   ||viewed in most areas where
   ||holds are viewed ( e.g.
   ||patron details, record
   ||details, etc ).
   ||There is a
   ||script to view article
   ||requests in progress within
   ||the circulation module.
   ||Article requests can be
   ||Open ( i.e. new ), In
   ||Processing, Completed, or
   ||Canceled. The status of a
   ||given request can be
   ||updated from this script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17522

--- Comment #260 from Jonathan Druart  
---
These patches have introduced bug 17522.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
[Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Owen Leonard  changed:

   What|Removed |Added

 Blocks||17601


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601
[Bug 17601] Regression: Incomplete CSS update introduced by Bug 14610
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #259 from Jonathan Druart  
---
The methods Koha::Biblio->article_request_type_for_items and
Koha::Biblio->article_request_type_for_bib are not covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #258 from Jonathan Druart  
---
This patch set (in particular  bf1563e60b31244f4ea977eb84954fb8501ed59a Bug
14610 - Add and update modules) breaks several tests.

See bug 17591

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17591


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591
[Bug 17591] Use fully qualified C4::Items function names in C4::Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Component|Architecture, internals,|Circulation
   |and plumbing|
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539
[Bug 17539] t/db_dependent/Reserves.t is failing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17530


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
[Bug 17530] Don't show 'article request' link when no article requests are
permitted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17517


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17517
[Bug 17517] "your summary" page in OPAC is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #257 from Kyle M Hall  ---
Pushed to master for 16.11, thanks for the followups Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #256 from Katrin Fischer  ---
Hi Kyle, I have added another follow-up - please check the 2 last patches!

Because I forgot to mention in the second commit message: the one class was
renamed because otherwise there was a double up between article title and
record title class names! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56785|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56784|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56783|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56778|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56782|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56777|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56780|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56779|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56776|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56775|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #255 from Katrin Fischer  ---
Created attachment 56865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56865=edit
Bug 14610: Follow-up 2

- Fixes typo "Recieve" in the sample notices
- Adds new notices to it-IT installer
- Turns off feature for existing installations, leaves it
  on for new installations
- Fixes typo "cancelation"
- Fixes ids in  of new pages
- Adds/fixes classes in th elements of tables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #252 from Katrin Fischer  ---
Created attachment 56862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56862=edit
[PASSED QA] Bug 14610 [QA Followup] - Fix publishercode issue

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #56816|0   |1
is obsolete||

--- Comment #254 from Katrin Fischer  ---
Created attachment 56864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56864=edit
Bug 14610 - Follow-up

Patch fixes some smaller problems:

- Adds new notices to the it-IT installer (xt/sample_notices.t)
- Renames one of the classes used in the table to avoid double up
- Fixes POD of Bilbio.pm by removing a doubled up line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #253 from Katrin Fischer  ---
Created attachment 56863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56863=edit
[PASSED QA] Bug 14610 - Update Schema files

Signed-off-by: Kyle M Hall 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #250 from Katrin Fischer  ---
Created attachment 56860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56860=edit
[PASSED QA] Bug 14610 [QA Followup] - Add notices to all language files

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #249 from Katrin Fischer  ---
Created attachment 56859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56859=edit
[PASSED QA] Bug 14610 [QA Followup] - Implement staff patron tab

Also fixes a few other minor issues

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #251 from Katrin Fischer  ---
Created attachment 56861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56861=edit
[PASSED QA] Bug 14610 [QA Followup] - Add classes to table headers

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #246 from Katrin Fischer  ---
Created attachment 56856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56856=edit
[PASSED QA] Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #248 from Katrin Fischer  ---
Created attachment 56858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56858=edit
[PASSED QA] Bug 14610 - Update opac.css via less

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #245 from Katrin Fischer  ---
Created attachment 56855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56855=edit
[PASSED QA] Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #247 from Katrin Fischer  ---
Created attachment 56857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56857=edit
[PASSED QA] Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #244 from Katrin Fischer  ---
Created attachment 56854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56854=edit
[PASSED QA] Bug 14610 - Add ability to place article requests in Koha - Update
database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
ArticleRequestsMandatoryFields
ArticleRequestsMandatoryFieldsItemsOnly
ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #243 from Katrin Fischer  ---
Thx! Back to testing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #242 from Kyle M Hall  ---
The guarantor method was accidentally added by this patch set initially, but
between the time the follow removed it and now, the guarantor method was added
by a different bug patch set that actually uses it! I've obsoleted the patch
that removed the guarantor method and now everything is working!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #56781|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #241 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #240)
> Hi Kyle, I wrote a follow-up fixing some smaller issues. Can you please take
> a look? 
> 
> The bigger issue here is that the patches currently break the member page:
> http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1
> Software error:
> 
> The method guarantor is not covered by tests!
> 
> Patches now add and remove a guarantor method, while I am not sure why it's
> there at all. - I don't see what's going wrong there. Please check.

That was an accidental inclusion. I'll get that fixed asap!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #240 from Katrin Fischer  ---
Hi Kyle, I wrote a follow-up fixing some smaller issues. Can you please take a
look? 

The bigger issue here is that the patches currently break the member page:
http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1
Software error:

The method guarantor is not covered by tests!

Patches now add and remove a guarantor method, while I am not sure why it's
there at all. - I don't see what's going wrong there. Please check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #239 from Katrin Fischer  ---
Created attachment 56816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56816=edit
Bug 14610 - Follow-up

Patch fixes some smaller problems:

- Adds new notices to the it-IT installer (xt/sample_notices.t)
- Renames one of the classes used in the table to avoid double up
- Fixes POD of Bilbio.pm by removing a doubled up line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #234 from Kyle M Hall  ---
Created attachment 56781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56781=edit
Bug 14610 [QA Followup] - Remove Koha::Patron::guarantor addition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #233 from Kyle M Hall  ---
Created attachment 56780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56780=edit
Bug 14610 [QA Followup] - Implement staff patron tab

Also fixes a few other minor issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #238 from Kyle M Hall  ---
Created attachment 56785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56785=edit
Bug 14610 - Update Schema files

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #236 from Kyle M Hall  ---
Created attachment 56783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56783=edit
Bug 14610 [QA Followup] - Add classes to table headers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #235 from Kyle M Hall  ---
Created attachment 56782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56782=edit
Bug 14610 [QA Followup] - Add notices to all language files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #237 from Kyle M Hall  ---
Created attachment 56784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56784=edit
Bug 14610 [QA Followup] - Fix publishercode issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #230 from Kyle M Hall  ---
Created attachment 56777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56777=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #231 from Kyle M Hall  ---
Created attachment 56778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56778=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #232 from Kyle M Hall  ---
Created attachment 56779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56779=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #229 from Kyle M Hall  ---
Created attachment 56776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56776=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #56318|0   |1
is obsolete||
  Attachment #56319|0   |1
is obsolete||
  Attachment #56320|0   |1
is obsolete||
  Attachment #56321|0   |1
is obsolete||
  Attachment #56322|0   |1
is obsolete||
  Attachment #56323|0   |1
is obsolete||
  Attachment #56324|0   |1
is obsolete||
  Attachment #56325|0   |1
is obsolete||
  Attachment #56326|0   |1
is obsolete||
  Attachment #56327|0   |1
is obsolete||
  Attachment #56328|0   |1
is obsolete||

--- Comment #228 from Kyle M Hall  ---
Created attachment 56775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56775=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
ArticleRequestsMandatoryFields
ArticleRequestsMandatoryFieldsItemsOnly
ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #227 from Katrin Fischer  ---
Still applies, next on my list!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Irma Birchall  changed:

   What|Removed |Added

 CC||i...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #226 from Kyle M Hall  ---
Created attachment 56328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56328=edit
Bug 14610 [QA Followup] - Fix publishercode issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #225 from Kyle M Hall  ---
Created attachment 56327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56327=edit
Bug 14610 [QA Followup] - Add classes to table headers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #224 from Kyle M Hall  ---
Created attachment 56326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56326=edit
Bug 14610 [QA Followup] - Add notices to all language files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #221 from Kyle M Hall  ---
Created attachment 56323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56323=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #220 from Kyle M Hall  ---
Created attachment 56322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56322=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #222 from Kyle M Hall  ---
Created attachment 56324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56324=edit
Bug 14610 [QA Followup] - Implement staff patron tab

Also fixes a few other minor issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #223 from Kyle M Hall  ---
Created attachment 56325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56325=edit
Bug 14610 [QA Followup] - Remove Koha::Patron::guarantor addition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #219 from Kyle M Hall  ---
Created attachment 56321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56321=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #217 from Kyle M Hall  ---
Created attachment 56319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56319=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #218 from Kyle M Hall  ---
Created attachment 56320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56320=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #56084|0   |1
is obsolete||
  Attachment #56085|0   |1
is obsolete||
  Attachment #56086|0   |1
is obsolete||
  Attachment #56087|0   |1
is obsolete||
  Attachment #56088|0   |1
is obsolete||
  Attachment #56089|0   |1
is obsolete||
  Attachment #56090|0   |1
is obsolete||

--- Comment #216 from Kyle M Hall  ---
Created attachment 56318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56318=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
ArticleRequestsMandatoryFields
ArticleRequestsMandatoryFieldsItemsOnly
ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #215 from Katrin Fischer  ---
Checked the source code and got some questions:

To discuss:

1) Why did you put the new routines like can_article_request in Biblio.pm? I
think Circulation.pm seems like a more obvious choice to me, as it already has
CanBookBeIssued, CanBookBeReturned etc.

2) There is another routine with the same name 'can_article_request' in
Items.pm - I know one is for record and one is for item level, but is that
intentional?

To fix:

3) In Patrons.pm there seems to have some extra code slipped in that shouldn't
be part of this patch set: guarantor

4) Please add the new notices and slip to the other non-english installer
directories as well!

5) Can you please put classes on the th elements in patron-article-requests.inc
as well? The td are already all classed up :)

6) This little piece of code gives me trouble, publishercode is filled in the
database, but it's not showing up. Same for pages in the same part of the code.
It looks like the values from biblioitems specifically are not showing up.
Also: if you catalog MARC21 there already is a ',', so there is no need to add
another in the template. The comma can be removed.

+
+[%
ar.biblio.biblioitem.publishercode %]
+
+[% IF
ar.biblio.biblioitem.publicationyear %]
+, [%
ar.biblio.biblioitem.publicationyear %]

6) Patch uniminifies opac.css!

7) Test fails... perl t/db_dependent/ArticleRequests.t
1..49
Bareword "C4::Context::only_my_library" not allowed while "strict subs" in use
at Koha/Libraries.pm line 52.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #214 from Katrin Fischer  ---
Please fix:
- As not all of libraries are offering article requests, please turn the
  feature off by default when updating. Leaving it on for new installations
  should be alright.
- In the OPAC patron account, the td-cells already have a class on the
  article request table, can you add thoes to the th-cells as well please?
  This will make it possible to hide columns that the library doesn't
  want to use easily.
- Change cancelation to cancellation.


Would be nice to see fixed:
- maybe show 'Only' or some other indication in staff to differentiate 
  item and record level article requests a bit more clearly from each 
  other in the tabbed display (similar to how holds display)


Wish list for the future, to be turned into separate bugs:

- On the article request summary page the table could be styled a bit
  better. The columns are very small to begin with, especially for
  the title and the article information this can be a bit irritating.
- After cancelling a request there is no way to see those any longer.
  It would be nice to have a separate tab showing  'cancelled today' or
  'cancelled within x days'
- Similar for completed requests a 'completed today' or 'completed within 
  x days' tab could prove useful.
- When you don't use scans but provide copies for the patron to be 
  picked up, it would be nice to have a visual clue about those
  waiting copies on the check out and check in pages. One way to 
  achieve this could be an additional optional status "ready for pick-up"
  that would trigger a note to display. Once you hand out the copies
  you should be able to click a link or something and then the status
  would switch to completed.
- It could be nice to be able to switch back from 'processing' to 
  'pending' to undo a possible mistake made by the staff or if it turns
  out that the requested resource is not available at the branch (book
  is missing, serial issue is not complete etc.)
- Include a 'cancel' option in the patron form that leads back to the
  record. This could also apply to the holds page.
- Include the 'title of the record' as part of the breadcrumbs, so you 
  can go back as on other pages. This could also apply to the holds page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #213 from Kyle M Hall  ---
Created attachment 56090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56090=edit
Bug 14610 [QA Followup] - Implement staff patron tab

Also fixes a few other minor issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #209 from Kyle M Hall  ---
Created attachment 56086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56086=edit
Bug 14610 - Add and update scripts

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #212 from Kyle M Hall  ---
Created attachment 56089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56089=edit
Bug 14610 - Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #208 from Kyle M Hall  ---
Created attachment 56085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56085=edit
Bug 14610 - Add and update modules

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #210 from Kyle M Hall  ---
Created attachment 56087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56087=edit
Bug 14610 - Add unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #6|0   |1
is obsolete||
  Attachment #7|0   |1
is obsolete||
  Attachment #8|0   |1
is obsolete||
  Attachment #9|0   |1
is obsolete||
  Attachment #55560|0   |1
is obsolete||
  Attachment #55561|0   |1
is obsolete||
  Attachment #55569|0   |1
is obsolete||

--- Comment #207 from Kyle M Hall  ---
Created attachment 56084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56084=edit
Bug 14610 - Add ability to place article requests in Koha - Update database

Article Requests are somewhat similar to holds, but are not requests for
an item to check out. Instead, article requests are requests for a
photocopy of a particular section of a book ( most often ). This is very
common in academic libraries where researchers may request a copy of a
single article found in a journal.

This patch set adds the ability to place article requests in Koha. It
allows the control of what can be requested via the circulation rules.
Since article requests of electronic resources are not outside the realm
of possibility, the feature will check not only the items for
requstability, but the record itself as well ( i.e. both items.itype and
biblio.itemtype ).

Article requests can be placed for patrons from the opac and staff
intranet and can be viewed in most areas where holds are viewed ( e.g.
patron details, record details, etc ).

There is a script to view article requests in progress within the
circulation module. Article requests can be Open ( i.e. new ), In
Processing, Completed, or Canceled. The status of a given request can be
updated from this script.

Test Plan:
1) Apply the patch set
2) Run updatedatabase.pl
3) Enable the system preference ArticleRequests
4) Set up some required fields in:
ArticleRequestsMandatoryFields
ArticleRequestsMandatoryFieldsItemsOnly
ArticleRequestsMandatoryFieldsRecordOnly
5) Edit your circ rules, set article requests to 'yes' for something
6) Test the ability to add an article request from the opac ( required fields
enforced )
7) Test the ability to add an article request from the staff interface (
required fields no enforced )
8) Note you can choose item level or record level requests
9) Change the rule to "record only"
10) Repeat 6 and 7
11) Note you cannot choose items
12) Change the rule to "item only"
13) Repeat 6 and 7
14) Note you must choose an item
15) Note that the 'new request' message is queued for each new request
16) Browse to /cgi-bin/koha/circ/article-requests.pl
17) Note requests are split by pickup branch
18) Test slip printing via the "Print slip" action
19) Process request vai "Process request" action
20) Note an email notice is queued for patron
21) Refresh /cgi-bin/koha/circ/article-requests.pl
22) Note request has moved to "processing" tab.
23) Complete request with "Complete request" action
24) Note message is queued for patron
25) Cancel a request, add cancelation note.
26) Note message is queued for patron

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #211 from Kyle M Hall  ---
Created attachment 56088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56088=edit
Bug 14610 - Update opac.css via less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #206 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #205)
> Thx for working on this Marcel!
> From reading your comments I feel like the 'scan' feature might be dealt
> with better later on, as it sounds like an enhancement to the initial patch.
> Would you agree with that? Some libraries might not want the user to be able
> to pick, only offer one thing etc.. it might complicate things here and this
> is already quite big.

Yes, this could be put under the "future directed" comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #205 from Katrin Fischer  ---
Thx for working on this Marcel!
>From reading your comments I feel like the 'scan' feature might be dealt with
better later on, as it sounds like an enhancement to the initial patch. Would
you agree with that? Some libraries might not want the user to be able to pick,
only offer one thing etc.. it might complicate things here and this is already
quite big.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #204 from Marcel de Rooy  ---
Nice addition ! (We are locally interested in such a feature too, but it would
need some extensions. )
Some comments from testing (no full QA). The first ones need immediate
attention. Some others are more future directed.

After updatedatabase feature is already enabled?
Distinction between record level and item level may not be clear for everybody.
Biblio level ?
Item level: if a biblio has no items, it is not useful to show Request Article
on results and detail.
Checking status: If an item has been checked out, I can still process and
complete an item based article request? You do not check statuses. Should we?
Or at least warn in the process to prevent mistakes? 
OPAC Detail menu: no icon for Request Article.
opac-request-article.tt:  bodyid='opac-holds' ? copy-pasted (did not look
further) 
The new request message does NOT contain the pages that I entered in the OPAC
(though saved in the database). AR_PENDING
Typo in that notice: Article Request Recieved
Note that AR_PROCESSING did contain the entered page range in the second
notice. At first sight I do not see any difference between these notices for
pages. (The field name pages might be problematic in the TT environment just
like size?) 
circ/circulation.pl: Just from a code glance:
+$patron = Koha::Patrons->find( $borrowernumber );
 $borrower = GetMemberDetails( $borrowernumber, 0 );
I understand that you will not be refactoring the script here, but seeing those
two calls here together does not look good. (Just mentioning)

General
In the new request, I am missing a field for the type of service: Do you want a
photocopy, a scan or still some other service ? These service types should be
controlled somewhere. For instance, one library only copies and the other
scans.
The message "You may pick your article up at RMA." only refers to photocopies?
A scan should be included in the mail (at least a URL where to download the
scanned portion of the biblio). This might be a local upload, but could well be
some external transfer service too. 

Future extensions?
I think we need some threshhold on the number of requests per patron. I saw
libraries offering one or two scans per day, additional requests being queued.
A maximum number of requests and a number to process per day might be a good
start. The second number could be used in reporting the pending requests to
pick next.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/