https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Resolution|--- |WONTFIX
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Tomás Cohen Arazi changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #90 from Martin Renvoize ---
Caveat.. if you're wanting related (JOINed) data you'll wan't to call
'prefetch' in the actual search call too...
I'm not entirely sure how Koha::Objects plays games here as it just adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #89 from Martin Renvoize ---
I'd be interested to see exactly what Koha::Object search call you were making
for comparison...
I've always found the SQL::Abstract query compilation really pretty quick..
it's the result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #88 from David Cook ---
Maybe this would be a compromise for Ere's situation:
https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Arbitrary-SQL-through-a-custom-ResultSource
It wouldn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #87 from Ere Maijala ---
David, you're right about the placeholders for itemnumbers, though the change
will only be necessary if the code will actually be used instead of Koha
objects.
About benchmarks, I find them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #86 from David Cook ---
(In reply to Marcel de Rooy from comment #84)
> +# This is so much faster than using Koha::Items->search that it makes
> sense even if it's ugly.
> +my $query = 'SELECT * FROM items WHERE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #85 from David Cook ---
Comment on attachment 86002
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86002
Bug 20664: Optimize retrieval of biblio and item data
Review of attachment 86002:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #82 from Josef Moravec ---
Created attachment 86008
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86008=edit
Bug 20664: (follow-up) Switch to Koha objects for retrieving items
Signed-off-by: Josef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #83 from Josef Moravec ---
Created attachment 86009
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86009=edit
Bug 20664: (follow-up) Add tests for UseHidingRulesWithBorrowerCategory
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #81 from Josef Moravec ---
Created attachment 86007
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86007=edit
Bug 20664: (follow-up) Fix tests on rebase
Signed-off-by: Josef Moravec
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #80 from Josef Moravec ---
Created attachment 86006
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86006=edit
Bug 20664: (follow-up) Fix QA whitespace errors
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #79 from Josef Moravec ---
Created attachment 86005
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86005=edit
Bug 20664: (follow-up) Fix test for GetMarcItemFields
Without this patch I got this error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Josef Moravec changed:
What|Removed |Added
Attachment #85898|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #78 from Josef Moravec ---
Created attachment 86004
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86004=edit
Bug 20664: Unit tests for GetMarcItemFields
To test:
prove -v t/db_dependent/Items.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #77 from Josef Moravec ---
Created attachment 86003
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86003=edit
Bug 20664: Add unit tests for GetMarcItem
To test:
prove -v t/db_dependent/Items.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85781|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85780|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #74 from Ere Maijala ---
Created attachment 85904
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85904=edit
Bug 20664: (follow-up) Switch to Koha objects for retrieving items
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85776|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85778|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #75 from Ere Maijala ---
Created attachment 85905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85905=edit
Bug 20664: (follow-up) Add tests for UseHidingRulesWithBorrowerCategory
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85779|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85777|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #67 from Ere Maijala ---
Yes, but originally all the item type checking could be avoided unless
item-level_itypes was false or item didn't have itype.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #66 from Jonathan Druart
---
(In reply to Ere Maijala from comment #65)
> Caching in GetMarcFromKohaField is indeed useless, I'll remove it. Also the
> test missing is something I need to fix. I can also make the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|Passed QA |ASSIGNED
--- Comment #65
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #64 from Jonathan Druart
---
I am not convinced by the changes made to GetMarcFromKohaField. I would not
cache anything here as GetMarcSubfieldStructure already cached it.
In my test it does not bring any performances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85109|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85110|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85106|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #63 from Ere Maijala ---
Created attachment 85781
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85781=edit
Bug 20664: (follow-up) Fix tests on rebase
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85107|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #85108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #56 from David Cook ---
(In reply to Ere Maijala from comment #55)
> This should provide a nice performance improvement also for exports for
> indexing.
>
Excellent.
> MySQL is quick to prepare statements, that's why
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #55 from Ere Maijala ---
This should provide a nice performance improvement also for exports for
indexing.
MySQL is quick to prepare statements, that's why we can get away with it. Other
databases may have different
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #54 from David Cook ---
Does this affect the export of biblios/items for Zebra indexing?
I'm watching a rebuild_zebra.pl crawling along exporting the bib records, and
thinking how surely it should be able to be faster
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #53 from David Cook ---
(In reply to Ere Maijala from comment #52)
> Caching during a batch operation would be useful, but it's harder to do
> without messing the architecture. And there's still a chance that something
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #52 from Ere Maijala ---
Caching during a batch operation would be useful, but it's harder to do without
messing the architecture. And there's still a chance that something hickups
during a batch process and automatic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #51 from David Cook ---
(In reply to Ere Maijala from comment #50)
> Unfortunately cached prepared statements don't work well with Plack where
> the process can outlive the MySQL connection. We found that reconnection to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #50 from Ere Maijala ---
> I was really excited when I read that you were going to use cached prepared
> statements (as I've used them to gain huge performance boosts on other Perl
> projects), so I'm saddened to see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Attachment #84517|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Attachment #84519|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Attachment #84516|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Attachment #84520|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
Attachment #84518|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #79276|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #41 from Ere Maijala ---
Created attachment 84520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84520=edit
Bug 20664: (follow-up) Fix QA whitespace errors
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #79279|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #42 from Ere Maijala ---
Sorry for the delay. Now rebased and fixed the whitespace issues.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #79277|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #79278|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Bug 20664 depends on bug 14385, which changed state.
Bug 14385 Summary: Extend OpacHiddenItems to allow specifying exempt borrower
categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #33 from Ere Maijala ---
(In reply to M. Tompsett from comment #32)
> ::: C4/Biblio.pm
> @@ -310,4 @@
> >
> > $frameworkcode = "" if !$frameworkcode || $frameworkcode eq "Default";
> > # XXX
> >
> > -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #32 from M. Tompsett ---
Comment on attachment 79276
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79276
Bug 20664: Optimize retrieval of biblio and item data
Review of attachment 79276:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Josef Moravec changed:
What|Removed |Added
Attachment #79227|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #30 from Josef Moravec ---
Created attachment 79278
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79278=edit
Bug 20664: Unit tests for GetMarcItemFields
To test:
prove -v t/db_dependent/Items.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #31 from Josef Moravec ---
Created attachment 79279
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79279=edit
Bug 20664: (follow-up) Fix test for GetMarcItemFields
Without this patch I got this error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #29 from Josef Moravec ---
Created attachment 79277
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79277=edit
Bug 20664: Add unit tests for GetMarcItem
To test:
prove -v t/db_dependent/Items.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #78869|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #78870|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #79225|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #23 from Ere Maijala ---
The latest version now incorporates the functionality added in bug 14385.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #78868|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Depends on||14385
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #19 from M. Tompsett ---
Comment on attachment 78868
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78868
Bug 20664: Optimize retrieval of biblio and item data
Review of attachment 78868:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #18 from Ere Maijala ---
I shamelessly lifted Nick's tests from bug 21006.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Attachment #76669|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #16 from Ere Maijala ---
Created attachment 78869
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78869=edit
Bug 20664: Add unit tests for GetMarcItem
To test:
prove -v t/db_dependent/Items.t
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #17 from Ere Maijala ---
Created attachment 78870
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78870=edit
Bug 20664: Unit tests for GetMarcItemFields
To test:
prove -v t/db_dependent/Items.t
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #14 from Ere Maijala ---
The latest patch is more simple and avoids any attempts at caching prepared
statements. Fortunately MySQL prepares quickly, so the performance improvement
is still good.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #13 from Ere Maijala ---
Created attachment 76669
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76669=edit
Bug 20664: Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are
1 - 100 of 118 matches
Mail list logo
