[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #35

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #33 from Marcel de Rooy --- QA Comment: First well done! This code is a minefield. Before passing QA, please look at my question under [1]. [1] Last question? -C4::Items::ModItemTransfer( -

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #32 from Marcel de Rooy --- Created attachment 166103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166103=edit Bug 34972: (QA follow-up) Remove second transfer from Circulation.t Removing the manual

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #31 from Marcel de Rooy --- Created attachment 166102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166102=edit Bug 34972: (QA follow-up) Remove some ModReserveCancelAll imports Not used? Dont

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy changed: What|Removed |Added Attachment #166029|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy changed: What|Removed |Added Attachment #166028|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #28 from Marcel de Rooy --- (In reply to Emily Lamancusa from comment #22) > To test: > 1. Place 2 bib-level holds for 2 different patrons (Patron A and Patron > B) on the same record, both for pickup at the

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #27

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #26 from David Nind --- (In reply to Emily Lamancusa from comment #21) Thanks Emily! I have now signed off. (I hope I tested it correctly!) David -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Attachment #166024|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Attachment #164392|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #164393|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #21 from Emily Lamancusa --- Thank you for testing and the detailed notes, David! > - Step 4: When I cancel the hold, there is a message saying "Please retain > this item and check it in to process the hold." for

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|BLOCKED |Needs Signoff ---

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #163730|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #163729|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #163728|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #17 from Emily Lamancusa --- Created attachment 164393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164393=edit Bug 34972: Remove GetOtherReserves GetOtherReserves attempts to set the

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #16 from Emily Lamancusa --- Created attachment 164392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164392=edit Bug 34972: Add tests for ModReservesCancelAll To test: 1. Apply this patch only 2.

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #15 from Emily Lamancusa --- Hi Marcel, thanks for taking a look! > I am just wondering how much sense it makes to still have GetOtherReserves. > Couldnt we just obsolete it here now? I agree that GetOtherReserves

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #14 from Marcel de Rooy --- Hi Emily, Brave effort to try improve here :) This code is a mine field. Some small observations: my $patron = Koha::Patrons->find( $nextreservinfo ); Does not look good. We should just pass

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #163473|0 |1 is

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #163471|0 |1 is

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #163472|0 |1 is

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #9 from Emily Lamancusa --- Created attachment 163473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163473=edit Bug 34972: (follow-up) Update returns.pl to initiate item transfer directly returns.pl

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #160776|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #160775|0 |1 is obsolete|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Christine changed: What|Removed |Added CC||ch...@pascolibraries.org --

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Laura Escamilla changed: What|Removed |Added CC|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #6 from Emily Lamancusa --- Thanks for testing, David! It looks like returns.pl is using GetOtherReserves to initiate the item transfer (i.e. add it to the branchtransfers table) - but not to put the hold into the

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC|

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #4 from Emily Lamancusa --- Created attachment 160776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160776=edit Bug 34972: GetOtherReserves should not alter hold states GetOtherReserves attempts to

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #3 from Emily Lamancusa --- Created attachment 160775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160775=edit Bug 34972: Add unit tests for GetOtherReserves To test: 1. Apply this patch only 2.

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #2 from Emily Lamancusa --- Also making a note for later: GetOtherReserves should probably be removed entirely. Once the bad code is removed, it's basically just a wrapper for CheckReserves that returns a trivial

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #1 from Emily Lamancusa --- It looks like the immediate bug is in GetOtherReserves in C4::Reserves. GetOtherReserves is written as though it should update the matched hold to be either waiting or in-transit, but it

[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun