[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Blocks||28353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 [Bug 28353] regression: Batch Item Deletion no longer shows which items were not removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Blocks||27525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 [Bug 27525] 'wich' instead of a 'with' in a sentence -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Blocks||25469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 [Bug 25469] Typo: Item does not belongs to your library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Blocks||25718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25718 [Bug 25718] Correct typo in additem.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #98 from Joy Nelson --- not backported to 19.11 - missing dependencies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Barton Chittenden changed: What|Removed |Added CC|barton...@gmail.com |bar...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #97 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #96 from Jonathan Druart --- Created attachment 104682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104682=edit Bug 8132: Fix failing tests * Add missing html filter (xt/find-missing-filters.t) * Fix AddReserve call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #95 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #94 from Marcel de Rooy --- Okay, last chance for string freeze. @RM: As my latest comments indicate, I am not completely enthusiastic about aspects of this patch set. But no definitive blocker on the other hand.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #93 from Marcel de Rooy --- Created attachment 104571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104571=edit Bug 8132: (QA follow-up) Missing filter Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Attachment #103169|0 |1 is obsolete|| --- Comment #92 from Marcel de Rooy --- Created attachment 104570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104570=edit Bug 8132: Adding message when deleting from the UI Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Attachment #103166|0 |1 is obsolete|| --- Comment #89 from Marcel de Rooy --- Created attachment 104567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104567=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Attachment #103168|0 |1 is obsolete|| --- Comment #91 from Marcel de Rooy --- Created attachment 104569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104569=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Attachment #103167|0 |1 is obsolete|| --- Comment #90 from Marcel de Rooy --- Created attachment 104568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104568=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Apply the patches Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold from B2 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #88 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #87) Again, the only things this change does is: * Add feedback on the interface about items that cannot be deleted (existing behaviour with the 4 error codes: book_on_loan, not_same_branch, book_reserved, linked_analytics). Note that "book_reserved" means that an item with item-level hold on it that is W or T cannot be deleted (*existing behaviour*) * Prevent phantom holds that are created when the last item of a bibliographic record that with a [biblio-level] hold on it is deleted. In that case we forbid the deletion. Nothing else. It is the implementation of the need described several times in this bug report and this has been waited for a long time now. I should not that, in master, you are not allowed to "delete all items" for the bibliographic record: "1 hold(s) on this record. You must delete all holds before deleting all items." Individual deletion is allowed however. If I misunderstood the need or if the implementation does not answer it, then feel free to obsolete the patches and provide another approach. But I think it is what we want here. If this is considered an improvement to the existing behaviour, but not perfect, then it should be pushed and improved later (your "And even to discuss" part is far behind what we are doing here). It would be good to get opinions from other contributors as it seems we are stuck :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #87 from Marcel de Rooy --- The second patch here actually says that it is not 'safe to delete' the only remaining item where the biblio has a biblio level hold. I do not agree with that statement. The item can perfectly be deleted. The biblio level hold may be filled by a future item and can be removed too. This might be a preferential thing. The critical or major aspect of this bug imo is that the batch delete tool still deletes an item with an ITEM level hold. Note btw that the remark about phantom holds in comment1 is not valid in this case (or at least any more). The item delete cascades to reserves. And a biblio delete cascades to reserves too. So we have no phantom holds. Might depend on the definition of 'phantom'.. And even to discuss: What if we said that an item delete should convert an item level hold to biblio level instead of deleting the hold ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #86 from Marcel de Rooy --- Resetting status, but not continuing here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #85 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #84) > (In reply to Jonathan Druart from comment #83) > > (In reply to Marcel de Rooy from comment #82) > > > (In reply to Jonathan Druart from comment #81) > > > > What do you suggest? > > > > > > Maybe we should stick to the scope that the title suggests. Do not delete > > > items with holds. Biblio level holds are out of scope. > > > > No, it's the main point of this bug report. > > > > We want to prevent deletion of the last item of a bibliographic record with > > a biblio-level hold on it. > > Sorry, I can't agree on that reading comments and patches. See comment 0: """ I don't think it always did this - but I tested today on 3.8 and it deleted an item and a bib record (cause I checked that box) that had holds on it. """ Then comment 1: """ This is how you end up with phantom holds that can never be deleted. """ And comment 20. I can confirm that I wrote those patches to prevent such deletion, and so phantom holds. That's why I rebuilt a bit the interface to display the why an item cannot be deleted, and so introduced the new "last_item_for_hold" error code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #84 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #83) > (In reply to Marcel de Rooy from comment #82) > > (In reply to Jonathan Druart from comment #81) > > > What do you suggest? > > > > Maybe we should stick to the scope that the title suggests. Do not delete > > items with holds. Biblio level holds are out of scope. > > No, it's the main point of this bug report. > > We want to prevent deletion of the last item of a bibliographic record with > a biblio-level hold on it. Sorry, I can't agree on that reading comments and patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #83 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #82) > (In reply to Jonathan Druart from comment #81) > > What do you suggest? > > Maybe we should stick to the scope that the title suggests. Do not delete > items with holds. Biblio level holds are out of scope. No, it's the main point of this bug report. We want to prevent deletion of the last item of a bibliographic record with a biblio-level hold on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #82 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #81) > What do you suggest? Maybe we should stick to the scope that the title suggests. Do not delete items with holds. Biblio level holds are out of scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #81 from Jonathan Druart --- Hi Marcel, Thanks for taking a look at this. (In reply to Marcel de Rooy from comment #79) > "If an item is the last one of a biblio that have biblio-level hold > placed on it, we should block the deletion." > > Well, this is quite arguable. Imo probably cleanup_database could remove > holds that make no sense like biblio level holds when there are no items. > The same commit says: > "Note that there is something a bit weird as we are blocking items > from a biblio that has biblio-level holds on it (not found), but we > do not blocking the deletion of an item with a waiting item-level hold." > > Lets not push inconsistency but resolve it? What do you suggest? I'd like to repeat that this bug is about preventing phantom holds, nothing else. I don't think we should fix other inconsistencies on this bug report (it has been considered critical during years...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #80 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #79) > "If an item is the last one of a biblio that have biblio-level hold > placed on it, we should block the deletion." > > Well, this is quite arguable. Imo probably cleanup_database could remove > holds that make no sense like biblio level holds when there are no items. > The same commit says: > "Note that there is something a bit weird as we are blocking items > from a biblio that has biblio-level holds on it (not found), but we > do not blocking the deletion of an item with a waiting item-level hold." > > Lets not push inconsistency but resolve it? Additional thought: Note that the user also has the choice to delete a biblio. If he wants to delete the biblio, the biblio level hold will be deleted too. So you could say that a choice to not delete the biblio, is a choice to keep the hold. Perhaps new items are to be expected here and the hold can be filled later. So delete the item. If you choose delete biblio too, we should not block the deletion of the hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #79 from Marcel de Rooy --- "If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion." Well, this is quite arguable. Imo probably cleanup_database could remove holds that make no sense like biblio level holds when there are no items. The same commit says: "Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold." Lets not push inconsistency but resolve it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #78 from Marcel de Rooy --- Bit weird that sub safe_to_delete returns 1 or a string. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #77 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #76 from Marcel de Rooy --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt FAIL filters missing_filter at line 127 () missing_filter at line 261 ([% cannot_delete_reason %]) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #75 from Victor Grousset/tuxayo --- Thanks Kelly for the double check, I wasn't confident about how holds should work. So, 2nd sign off and minor details added to the test plan: - about apply all the patches at the beginning - about that the biblio-level hold to remove is on b2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103150|0 |1 is obsolete|| --- Comment #74 from Victor Grousset/tuxayo --- Created attachment 103169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103169=edit Bug 8132: Adding message when deleting from the UI Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103149|0 |1 is obsolete|| --- Comment #73 from Victor Grousset/tuxayo --- Created attachment 103168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103168=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103148|0 |1 is obsolete|| --- Comment #72 from Victor Grousset/tuxayo --- Created attachment 103167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103167=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Apply the patches Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold from B2 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103147|0 |1 is obsolete|| --- Comment #71 from Victor Grousset/tuxayo --- Created attachment 103166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103166=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 ByWater Sandboxes changed: What|Removed |Added Attachment #101406|0 |1 is obsolete|| --- Comment #69 from ByWater Sandboxes --- Created attachment 103149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103149=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 ByWater Sandboxes changed: What|Removed |Added Attachment #101405|0 |1 is obsolete|| --- Comment #68 from ByWater Sandboxes --- Created attachment 103148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103148=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 ByWater Sandboxes changed: What|Removed |Added Attachment #101407|0 |1 is obsolete|| --- Comment #70 from ByWater Sandboxes --- Created attachment 103150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103150=edit Bug 8132: Adding message when deleting from the UI Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 ByWater Sandboxes changed: What|Removed |Added Attachment #101404|0 |1 is obsolete|| --- Comment #67 from ByWater Sandboxes --- Created attachment 103147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103147=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #66 from Victor Grousset/tuxayo --- > "Has been effective", so you should be on the next screen, not the > confirmation screen. Okay, indeed after confirmation the deletion works. >> I guess that's not an issue. But I still have a item I can't delete. > If the reason makes sense, yes it's expected. That's the point of the > patchset. Indeed, the item-level hold is the cause. From what I understand, no issue found, so I will sign it off. Later in the day I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #65 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #64) > > => delete of item from B4 is *not* blocked - there is a hold but it is not > > found > > I don't get it. No sign of something not being found. > > I have this: https://pic.infini.fr/RLxIM2cL/eYdtLmXE.png (temporary hosting > for 90 days) So it's not blocked, which is expected. > > 4/ Repeat 1 > > => The deletion has been effective! > > Is that the expected result? > > https://pic.infini.fr/WaQVV1Gg/rTGE1oG3.png (temporary hosting for 90 days) "Has been effective", so you should be on the next screen, not the confirmation screen. > I guess that's not an issue. But I still have a item I can't delete. If the reason makes sense, yes it's expected. That's the point of the patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #64 from Victor Grousset/tuxayo --- > => delete of item from B4 is *not* blocked - there is a hold but it is not > found I don't get it. No sign of something not being found. I have this: https://pic.infini.fr/RLxIM2cL/eYdtLmXE.png (temporary hosting for 90 days) > 3/ Remove the biblio-level hold The biblio-level hold on B2 right? I removed also the biblio-level hold on B1. > 4/ Repeat 1 > => The deletion has been effective! Is that the expected result? https://pic.infini.fr/WaQVV1Gg/rTGE1oG3.png (temporary hosting for 90 days) I guess that's not an issue. But I still have a item I can't delete. I'm not comfortable with the steps so I might have misinterpreted few things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #63 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #62) > Trying to signoff. > > > Create Biblio B3 with 1+ item > > Does this mean that B3 *must* have more than on item? At least one item. > IIUC, the patch must be applied from the start, right? Apply all the patches to test, yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #62 from Victor Grousset/tuxayo --- Trying to signoff. > Create Biblio B3 with 1+ item Does this mean that B3 *must* have more than on item? IIUC, the patch must be applied from the start, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #61 from Jonathan Druart --- Switching back to NSO. Thanks for the feedback, Sonia and Kelly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #60 from Jonathan Druart --- This patch is an enhancement in the sense that it displays useful info about "deletion impossible", but can be considered as a bugfix (and so backported) as it will prevent phantom holds. I would deal with a behavior change on a separate bug report. IMO it's not obvious that everybody wants to block items (that have holds) deletion (there is an alert already to tell that holds will be deletion along with the item). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #59 from Kelly McElligott --- I agree with Sonia. Although yes the scope of the bug is to Block deletion of the last item for a Biblio on which a hold is placed on, to avoid phantom holds (original issue reported) I would say we would want the same behavior on item level holds. Is this another bug or the grand scope of batch item deletion? If I have 1 item level hold on a bib with 2 items, Koha will let me delete both items with no problem. Koha should stop this behavior, in my opinion as well. If Koha knows when I am deleting all the items off a record, shouldn't that be able to stop it? That being said, the test plan does work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #58 from Jonathan Druart --- Thanks for testing Sonia! What this change does basically is: * Improve feedback to the end user: why this item cannot be deleted * Block deletion of the last item for a biblio on which a hold is placed on, to avoid phantom holds (original issue reported) (In reply to Koha Team University Lyon 3 from comment #57) > When you confirm the deletion, you have an alert for the case of the > biblio-level-hold with 2 items that were selected for deletion : "Last item > for bibliographic record wich biblio-level hold on it" and another message > saying "At least one item blocked the deletion. The operation rolled back > and nothing happened! " > So the deletion is cancelled for all the items selected. Yes, the problem is that we cannot (easily) know that we are going to remove the last item on the biblio if we are going to remove several items from this biblio. We only know it when we remove the last one. That is why everything is rollbacked and no deletion was effective. > Could we not prevent to tick all the 1/1 case in the first table in addition > of > what exists already? If we want to change the behavior on item's level holds, I think it should be decided on a separate bug report, unless everybody agrees. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Koha Team University Lyon 3 changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||k...@univ-lyon3.fr --- Comment #57 from Koha Team University Lyon 3 --- Hi, I've tested following the test plan and I added a case when a items is in transit (T status in reserves table) for an hold. When you are in the first table in the deletion items tool, there's the column called "holds" where you can see : 1/1 : if there's an item-level-hold on this item OR if the item is waiting to serve a hold OR the item is in transit to serve a hold 0/1 : if there's a biblio-level-hold but that this item isn't waiting or in transit for this hold 0 : if there's no hold It's not a really clear notation, but I have nothing better to offer.. In this table, you can't tick nor the items with the waiting or transit status nor the one where is a biblio-level-hold but only one item on this biblio. When you confirm the deletion, you have an alert for the case of the biblio-level-hold with 2 items that were selected for deletion : "Last item for bibliographic record wich biblio-level hold on it" and another message saying "At least one item blocked the deletion. The operation rolled back and nothing happened! " So the deletion is cancelled for all the items selected. It works as described in the test plan but, for me, it isn't consistent to block the deletion of an item because there's a biblio-level-hold on it but not block the deletion of an item with a item-level-hold on it. Could we not prevent to tick all the 1/1 case in the first table in addition of what exists already? I must admit that I haven't read all the comments above but I can't see a good reason to allow deletion of item with an item-level-hold if you don't allow the deletion of a biblio-level-hold. I hope that my explanations are clear.. Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added URL|https://gitlab.com/joubu/Ko | |ha/commits/bug_8132 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #55 from Jonathan Druart --- Created attachment 101406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101406=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #56 from Jonathan Druart --- Created attachment 101407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101407=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Attachment #98694|0 |1 is obsolete|| Attachment #98695|0 |1 is obsolete|| Attachment #98696|0 |1 is obsolete|| Attachment #98697|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 101404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101404=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #54 from Jonathan Druart --- Created attachment 101405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101405=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #52 from Jonathan Druart --- (In reply to David Nind from comment #51) > Patch no longer applies: > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 8132: No changes but disable checkboxes > error: sha1 information is lacking or useless (tools/batchMod.pl). > error: could not build fake ancestor > Patch failed at 0001 Bug 8132: No changes but disable checkboxes It depends on bug 23463. It's FQA but you can still test this patchset if you like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #51 from David Nind --- Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8132: No changes but disable checkboxes error: sha1 information is lacking or useless (tools/batchMod.pl). error: could not build fake ancestor Patch failed at 0001 Bug 8132: No changes but disable checkboxes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #50 from Jonathan Druart --- Created attachment 98697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98697=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #48 from Jonathan Druart --- Created attachment 98695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98695=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Attachment #96147|0 |1 is obsolete|| Attachment #96148|0 |1 is obsolete|| Attachment #96149|0 |1 is obsolete|| Attachment #96150|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart --- Created attachment 98694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98694=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #49 from Jonathan Druart --- Created attachment 98696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98696=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #46 from Martin Renvoize --- Looks promising, but needs a rebase I'm afraid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #45 from Jonathan Druart --- (In reply to Kelly McElligott from comment #44) > Hi Martin, > Attempted to sign off on this bug Martin, > Looks like something in the Bug that this is dependant (23463) on has > changed, I received this error while testing: > > > Template process failed: undef error - The method Koha::Item->safe_to_delete > is not covered by tests! Hi Kelly, are you able to use the remote branch? You should be able to specify it if you are using the sandboxes. The problem is that the patches from bug 23463 are not attached to the bug report (but also on a remote branch). The remote branch https://gitlab.com/joubu/Koha/commits/bug_8132 contains all the necessary commits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #44 from Kelly McElligott --- Hi Martin, Attempted to sign off on this bug Martin, Looks like something in the Bug that this is dependant (23463) on has changed, I received this error while testing: Template process failed: undef error - The method Koha::Item->safe_to_delete is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #43 from Martin Renvoize --- Still testing this Kelly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #42 from Kelly McElligott --- Let me test again, using the back button did not save my barcodes in the Batch Item Deletion tool. I will attempt this again. I understand what you mean with the non-triggered holds and agree that this would be different than other Koha procedures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #41 from Jonathan Druart --- (In reply to Kelly McElligott from comment #39) > Jonathan, > Two issues that I have with this: > > In this step: > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > This does block the whole process! So all the item that could be deleted - > don't get deleted, the button to return to Batch Item Deletion, results in > having to re-enter all the items that could have been deleted but weren't > because of 1 item. Could the return to deletion button bring back the > screen prior to this. This is just a lot of extra work. Browser back button will do the job correctly, it will even keep the selection. Isn't it enough? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #40 from Jonathan Druart --- (In reply to Kelly McElligott from comment #39) > Jonathan, > Two issues that I have with this: > > In this step: > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > This does block the whole process! So all the item that could be deleted - > don't get deleted, the button to return to Batch Item Deletion, results in > having to re-enter all the items that could have been deleted but weren't > because of 1 item. Could the return to deletion button bring back the > screen prior to this. This is just a lot of extra work. I will see what I can do. But yes, I do expect the whole process to be blocked. If something is wrong, the whole transaction is rolled back. > In this step: > 3/ Remove the biblio-level hold > 4/ Repeat 1 > => The deletion has been effective! > > Koha is deleting both items on Bib4 - one of which had an item level hold > (not triggered). The hold does not get orphaned, because it too is deleted. > Is this what you would like to see happen, a library can delete an item with > an item level hold if it isn't triggered? It is how it works so far. That's why I added a note in the commit message about this behavior. The hold has to be found (waiting or in transfer) to see the deletion blocked. I guess it's how it works as well in the cataloguing module. It's not a behavior's change I want to introduce with this patchset, if we decide to modify it we should do it on its own bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #39 from Kelly McElligott --- Jonathan, Two issues that I have with this: In this step: 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process This does block the whole process! So all the item that could be deleted - don't get deleted, the button to return to Batch Item Deletion, results in having to re-enter all the items that could have been deleted but weren't because of 1 item. Could the return to deletion button bring back the screen prior to this. This is just a lot of extra work. In this step: 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! Koha is deleting both items on Bib4 - one of which had an item level hold (not triggered). The hold does not get orphaned, because it too is deleted. Is this what you would like to see happen, a library can delete an item with an item level hold if it isn't triggered? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #31 from Jonathan Druart --- (In reply to Kelly McElligott from comment #29) > I did not see the message that is indicated in step 2. " Nothing happened > and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process" . > > This would be an extremely helpful message. I received a message that 2 > items were deleted. Yes, they were the correct items to be deleted and left > the item with the hold along. I am not sure with this test plan, if this > message that you note in step 2 should be see. > > See my screenshot. > > Kelly Hi Kelly, thanks for testing. Can you confirm the holds were "found"? So far we prevent deletion if reserves.found is W or T. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #38 from Jonathan Druart --- I have adjusted the test plan and updated the patch (remote branch is still up-to-date). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Attachment #95936|0 |1 is obsolete|| Attachment #95937|0 |1 is obsolete|| Attachment #95938|0 |1 is obsolete|| Attachment #95939|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 96147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96147=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #37 from Jonathan Druart --- Created attachment 96150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96150=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #35 from Jonathan Druart --- Created attachment 96148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96148=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #36 from Jonathan Druart --- Created attachment 96149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96149=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #32 from Jonathan Druart --- Update test plan: > 0/ Setup > Create Biblio B1 with 1 item > Create Biblio B2 with 2 items > Create Biblio B3 with 1+ item > Create Biblio B4 with 1+ item > Place a biblio-level hold on B1 and B2 > Place an item-level hold on B3 > Confirm the holds (to mark them waiting) Read: Confirm the item-level hold, the one placed on B3 only. > 1/ Use the 5 items and delete them in a batch. > => delete of item from B1 is blocked on first screen > => delete of items from B2 is *not* blocked on first screen > => delete of item from B3 is blocked on first screen > => delete of item from B4 is *not* blocked > > Note that you can only select items from B2 and B4 > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > 3/ Remove the biblio-level hold > 4/ Repeat 1 > => The deletion has been effective! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #33 from Jonathan Druart --- (In reply to Kelly McElligott from comment #29) > I did not see the message that is indicated in step 2. " Nothing happened > and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process" . > > This would be an extremely helpful message. I received a message that 2 > items were deleted. Yes, they were the correct items to be deleted and left > the item with the hold along. I am not sure with this test plan, if this > message that you note in step 2 should be see. > > See my screenshot. > > Kelly There is something wrong indeed, working on it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #30 from Kelly McElligott --- Created attachment 95997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95997=edit delete message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #29 from Kelly McElligott --- I did not see the message that is indicated in step 2. " Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process" . This would be an extremely helpful message. I received a message that 2 items were deleted. Yes, they were the correct items to be deleted and left the item with the hold along. I am not sure with this test plan, if this message that you note in step 2 should be see. See my screenshot. Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Depends on||23463 URL||https://gitlab.com/joubu/Ko ||ha/commits/bug_8132 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #28 from Jonathan Druart --- Here is a try to fix this long standing issue. It is based on top of bug 23463. A remote branch is available for testing on my gitlab repop: https://gitlab.com/joubu/Koha/commits/bug_8132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #27 from Jonathan Druart --- Created attachment 95939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95939=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #26 from Jonathan Druart --- Created attachment 95938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95938=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #25 from Jonathan Druart --- Created attachment 95937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95937=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 Confirm the holds (to mark them waiting) 1/ Use the 5 items and delete them in a batch. => delete of item from B1 is blocked on first screen => delete of items from B2 is *not* blocked on first screen => delete of item from B3 is blocked on first screen => delete of item from B4 is *not* blocked Note that you can only select items from B2 and B4 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #24 from Jonathan Druart --- Created attachment 95936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95936=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What|Removed |Added Severity|critical|major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Katrin Fischer changed: What|Removed |Added Summary|batch delete tool deletes |Batch delete tool deletes |items with holds on them|items with holds on them -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #23 from Katrin Fischer --- (In reply to Christopher Brannon from comment #22) > (In reply to Jonathan Druart from comment #21) > > Trying to get back to this. > > > > Are we supposed to silently delete an item with an item-level hold that is > > not found (W or T)? > > In my opinion, staff or patron should be notified. At least staff, because > they could make a decision to move the hold to another record, order the > item, or notify the patron that the item is no longer available. I think a notification in the GUI would be good, Maybe at the top, sth like: Following items can't be deleted because they have holds on them? What if it's a record level hold and it's the last item? Maybe we should just check for items in general. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #22 from Christopher Brannon --- (In reply to Jonathan Druart from comment #21) > Trying to get back to this. > > Are we supposed to silently delete an item with an item-level hold that is > not found (W or T)? In my opinion, staff or patron should be notified. At least staff, because they could make a decision to move the hold to another record, order the item, or notify the patron that the item is no longer available. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #21 from Jonathan Druart --- Trying to get back to this. Are we supposed to silently delete an item with an item-level hold that is not found (W or T)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Pulugurtha durga srinivas sarama changed: What|Removed |Added QA Contact||testo...@bugs.koha-communit ||y.org CC||ganesh_19...@yahoo.co.in Component|Hold requests |Database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
