Re: [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held

The containing function is called from several places. At one of them, in the function __sigp_stop, the spin lock fi-lock is held. [...] Signed-off-by: Julia Lawall ju...@diku.dk Acked-by: Christian Borntraeger borntrae...@de.ibm.com [...] --- a/arch/s390/kvm/sigp.c +++ b/arch/s390/kvm

[PATCH] kvm-s390: fix memsize =4G on linus git head

Avi, Marcelo, commit 628eb9b8a8f3ef31d8316112a4596b1a21b38159 KVM: s390: streamline memslot handling introduced kvm_s390_vcpu_get_memsize. This broke guests =4G, since this function returned an int. This patch changes the return value to a long. Signed-off-by: Christian Borntraeger

Re: [PATCH] qemu-kvm: fix __user export

Am Montag 30 November 2009 13:02:08 schrieb Michael S. Tsirkin: __user macro does not appear in exported headers and should not be in headers qemu-kvm includes. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm/include/linux/kvm.h |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] qemu-kvm: fix __user export

This is in the copy of the headers that qemu-kvm.git carries, not the kernel master. Right, I missed that. Thanks -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] virtio_blk: fix endianess annotations

Since commit 72e61eb40b55dd57031ec5971e810649f82b0259 (virtio: change config to guest endian) config space is no longer fixed endian. Lets change the virtio_blk_config variables. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- include/linux/virtio_blk.h |8 1 file

Re: [RFC] kvm-s390: userspace snapshot

Am Donnerstag, 12. Juni 2008 schrieb Oliver Paukstadt: On Thu, 2008-06-12 at 00:14 +0200, Christian Borntraeger wrote: Ok, I got an idea. Does that patch fix the handle_should_not_happen PANIC? Patch does not fit, because my code contains vcpu-arch.sie_block-gmsor = 0x

Re: KVM: pvmmu breakage with gcc 4.3.0

Am Donnerstag, 26. Juni 2008 schrieb Anthony Liguori: Marcelo Tosatti wrote: Some pvmmu functions store their commands on stack, and newer GCC versions conclude that these commands are unused. So stick an inline asm statement to convince the compiler otherwise. I think a better

Re: KVM: pvmmu breakage with gcc 4.3.0

Am Donnerstag, 26. Juni 2008 schrieb Anthony Liguori: Christian Borntraeger wrote: Am Donnerstag, 26. Juni 2008 schrieb Avi Kivity: I don't think p should force the contents into memory? Perhaps m(*(char *)buffer)? Anthony, I don't see why a memory clobber would tell gcc

Re: Freeze with KVM_CLOCK, undocumented dependency VIRTIO_BLK - VIRTIO_PCI

Am Montag, 23. Juni 2008 schrieb Bernhard Schmidt: I don't quite understand. VIRTIO_BLK can be selected in the kernel without selecting VIRTIO_PCI, it does not generate any build error but the virtual blockdevice simply does appear. Does VIRTIO_BLK have any use without VIRTIO_PCI? Yes, it

Re: [PATCH 2/5] kvmtrace: make cycle calculation architecture aware

Am Sonntag, 13. Juli 2008 schrieb Avi Kivity: Carsten Otte wrote: Avi Kivity wrote: What is the overhead of ktime_get()? I think I'd like an arch specific timestamp. This way we could use our clock-cycle-granularity-non-privileged-timestamp instruction ;-). If we need a common

Re: [PATCH] libkvm-s390

That patch was Carstens last job before he left into vacation. I promised to look after it, so I will sent an updated patch soon. +/* + * This header is for functions variables that will ONLY be + * used inside libkvm for s390x. + * THESE ARE NOT EXPOSED TO THE USER AND ARE ONLY FOR USE

Re: [PATCH] libkvm-s390

Am Montag, 14. Juli 2008 schrieb Avi Kivity: Certainly. I suggest exposing this via a KVM_CAP_blah and adapting at runtime. Placing the guest at offset zero is dangerous, since all a guest has to do is place a function at guest physical address zero and wait for a kernel bug that calls

[PATCH 0/2] kvm-s390: small fixes

Hello Avi, here are two small patches for kvm on s390: 1. kvm-s390: Fix guest kconfig for virtio 2. kvm-s390: change help text of guest Kconfig Christian -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2/2] kvm-s390: change help text of guest Kconfig

The current help text for CONFIG_S390_GUEST is not very helpful. Add more text. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- arch/s390/Kconfig |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Index: kvm/arch/s390/Kconfig

Re: [PATCH 1/2] kvm-s390: Fix guest kconfig for virtio

Am Dienstag, 15. Juli 2008 schrieb Avi Kivity: This leads to confusion if CONFIG_VIRTIO is unset but CONFIG_S390_GUEST is set. What about having CONFIG_S390_GUEST select CONFIG_VIRTIO instead? That is already the case. S390_GUEST has bool s390 guest support (EXPERIMENTAL) depends

Re: [PATCH 2/2] kvm-s390: change help text of guest Kconfig

Am Dienstag, 15. Juli 2008 schrieb Avi Kivity: Christian Borntraeger wrote: The current help text for CONFIG_S390_GUEST is not very helpful. Add more text. Doesn't apply (even with -C0)? What tree are based on? Hmm, I think the problem stems from the virtio_console patches which

[PATCH v2/RFC] libkvm-s390

in config.mak. Its predefined in gcc. o add some callbacks (done by Carsten, but not yet posted) From: Carsten Otte [EMAIL PROTECTED] From: Christian Borntraeger [EMAIL PROTECTED] Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- Makefile|2 libkvm/config-s390.mak

[PATCH v3] libkvm-s390

From: Carsten Otte [EMAIL PROTECTED] From: Christian Borntraeger [EMAIL PROTECTED] This is an update patch for libkvm to build and work on s390. It should address Avis and Christians comments. Tested on s390. Compile tested on i386. Avi please consider to apply. Signed-off-by: Christian

[PATCH 1/6] kvm-s390: Advertise KVM_CAP_USER_MEMORY

From: Carsten Otte [EMAIL PROTECTED] KVM_CAP_USER_MEMORY is used by s390, therefore, we should advertise it. Signed-off-by: Carsten Otte [EMAIL PROTECTED] Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- arch/s390/kvm/kvm-s390.c |7 ++- 1 file changed, 6 insertions(+), 1

[PATCH] kvm-userspace: fix memslot assignment

Hello Avi, seems that I mixed up the slot initialization, instead of making the first slot always 0 I made it always 1. Lets go back to Carstens variant, since I dont like nested ifdefs. The compiler will remove the dead code anyway. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED

Re: [PATCH] kvm-userspace: fix memslot assignment

Am Sonntag, 27. Juli 2008 schrieb Avi Kivity: This is really a no-op, since s390 will nack a KVM_CAP_SET_TSS_ADDR query. Of course, the change is an improvement. @@ -92,8 +92,11 @@ int get_free_slot(kvm_context_t kvm) if (tss_ext 0) i = 0; else +#if

[PATCH] kvm-s390: Fix facility bits for guest

Am Dienstag, 29. Juli 2008 schrieb Christian Borntraeger: @@ -158,6 +158,7 @@ static int handle_stfl(struct kvm_vcpu * vcpu-stat.instruction_stfl++; facility_list = ~(1UL24); /* no stfle */ + facility_list = ~(1UL23); /* no large pages */ rc = copy_to_guest(vcpu

Re: [PATCH] kvm-userspace: fix memslot assignment

, if * KVM_CAP_SET_TSS_ADDR is not available or * The ioctl VM_CAP_SET_TSS_ADDR returns =0 Since my opteron box died recently I cannot test that on x86 at the moment. What do you think about the following patch Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- libkvm/libkvm.c | 28

Re: KVM compile fails on s390x

Am Samstag, 2. August 2008 schrieb Robin Atwood: On Friday 01 Aug 2008, Christian Borntraeger wrote: Am Donnerstag, 31. Juli 2008 schrieb Robin Atwood: I guess I am doing something very dumb, but when I try to compile kvm-72 on z900 architecture (actually Hercules) I immediately get

Re: [RFC] [PATCH] SCSI passthrough for virtio-blk

Am Freitag, 29. August 2008 schrieb Hannes Reinecke: So when using '-drive file=/dev/sgXX,if=virtio,format=host_device' you can happily call any sg_XX command on the resulting vdX device. Quite neat, methinks. And it's even backwards compatible, so each of these patches should work without the

[PATCH 1/2] kvm-s390: Rework facility bits

From: Christian Borntraeger [EMAIL PROTECTED] Heiko Carstens pointed out, that its safer to activate working facilities instead of disabling problematic facilities. The new code uses the host facility bits and masks it with known good ones. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED

[PATCH 2/2] kvm-s390: change help text of guest Kconfig

The current help text for CONFIG_S390_GUEST is not very helpful. Lets add more text. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- arch/s390/Kconfig |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Index: kvm/arch/s390/Kconfig

Re: [RFC] [PATCH] SCSI passthrough for virtio-blk

Am Freitag, 29. August 2008 schrieb Hannes Reinecke: Hmm. Works here, using an unpatched kvm-73. Which version did you use? I use the s390 userspace prototype kuli which uses an virtio transport similar to lguest. I retried and it seems to race. Most of the time it works fine, but sometimes

Re: [RFC] [PATCH] SCSI passthrough for virtio-blk

Thanks for your feedback. Here is a second try to allows to propagate scsi error code from host-guest. Makes sense? Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- drivers/block/virtio_blk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: kvm/drivers/block

Re: Network poblems using virtio and tap.

Am Montag, 1. September 2008 schrieb Fabian Deutsch: Hey. I'm observing some network problems when using virtio and a tap if. The trouble is a drop of network troughput from abot 90Mbit/s to about 90kbit/s, after about 1.7 TB of transferred data. Setup Host: - Fedora 8, nearly all

Re: s390 kvm and slot 0

Am Dienstag, 14. Oktober 2008 schrieb Glauber Costa: Hi Carsten, libkvm/libkvm.c, in function get_free_slot(), we see: #if defined(KVM_CAP_SET_TSS_ADDR) !defined(__s390__) tss_ext = ioctl(kvm-fd, KVM_CHECK_EXTENSION, KVM_CAP_SET_TSS_ADDR); #else tss_ext = 0; #endif

Re: [PATCH] kvm-userspace: add ibm archs to unifdef header

on s390 and s390x in the kernel config. This looks right. Acked-by: Christian Borntraeger [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Activate Virtualization On Demand v2

Am Mittwoch, 5. November 2008 schrieb Alexander Graf: printk(KERN_INFO kvm: disabling virtualization on CPU%d\n, cpu); [...] printk(KERN_INFO kvm: disabling virtualization on CPU%d\n, cpu); [...]

[PATCH] kvm-s390: Fix problem state handling in guest sigp handler

Hello Avi, this patch should go into 2.6.28-rcx. It fixes an important guest bug. - From: Christian Borntraeger [EMAIL PROTECTED] We can get an exit for instructions starting with 0xae, even if the guest is in userspace. Lets make sure, that the signal processor handler is only called in guest

[RFC/PATCH 0/2] virtio console resize support

Hello Rusty, this patch set adds virtio console resize support. Patch 1 implements the necessary changes in virtio_console Patch 2 implements the config_changed callback for the s390 virtio transport Patch 1 needs an additional patch against hvc_console ( http://lkml.org/lkml/2008/11/18/121 )

[PATCH 1/2] virtio_console: support console resizing

From: Christian Borntraeger [EMAIL PROTECTED] this patch uses the new hvc callback hvc_resize to set the window site which allows to change the tty size of hvc_console via a hvc_resize function. I have added a new feature bit VIRTIO_CONSOLE_F_SIZE. The driver will change the window size

[PATCH 2/2] kvm-s390: implement config_changed for virtio on s390

From: Christian Borntraeger [EMAIL PROTECTED] This patch implements config_changed for the s390 virtio transport. We use the least significant bit of the interrupt parameter field to decide, if this interrupt should call the virtio virtqueue callback or the config_changed callback

Re: [PATCH 2/2] kvm-s390: implement config_changed for virtio on s390

compatibility. - [PATCH 2/2] kvm-s390: implement config_changed for virtio on s390 From: Christian Borntraeger [EMAIL PROTECTED] This patch implements config_changed for the s390 virtio transport. We use the least significant bit of the interrupt parameter field to decide, if this interrupt should call

Re: [PATCH] Fix kvm-79 userland for separate kernel objdir

Am Donnerstag, 20. November 2008 schrieb Andi Kleen: --- kvm-79/Makefile~ 2008-11-12 12:48:01.0 +0100 +++ kvm-79/Makefile 2008-11-20 14:06:57.0 +0100 @@ -33,7 +33,7 @@ header-sync-n: header-sync-y: - make -C kernel LINUX=$(KERNELDIR) header-sync + make -C

Re: [PATCH] Fix kvm-79 userland for separate kernel objdir

Am Donnerstag, 20. November 2008 schrieb Andi Kleen: How about this variant? Does it work for you? -Andi --- kvm-79/Makefile~ 2008-11-12 12:48:01.0 +0100 +++ kvm-79/Makefile 2008-11-20 14:36:54.0 +0100 @@ -33,7 +33,9 @@ header-sync-n: header-sync-y: - make -C

[PATCH/RFC] kvm: fix refcounting race release vs. module unload

Hello Avi, while fixing a module reference counting problem for s390 I spotted another problem in the kvm main code. Any comments on the patch? From: Christian Borntraeger [EMAIL PROTECTED] There is a race between a close of the file descriptors and module unload in the kvm module. You can

Re: [PATCH/RFC] kvm: fix refcounting race release vs. module unload

--- kvm.orig/virt/kvm/kvm_main.c +++ kvm/virt/kvm/kvm_main.c @@ -1303,7 +1303,7 @@ static int kvm_vcpu_release(struct inode return 0; } -static const struct file_operations kvm_vcpu_fops = { +static struct file_operations kvm_vcpu_fops = { .release=

Re: [PATCH/RFC 2] kvm: fix module refcount issues with anon_inodegetfd

function will do a module_put. This makes the open/release symmetric. What do you think? I also CCed fs-devel, since fs/* is affected From: Christian Borntraeger [EMAIL PROTECTED] There is a race between a close of the file descriptors and module unload in the kvm module. You can easily trigger

[PATCH 0/2] two refcount and leak fixes for kvm on s390

Hello Avi, here are two fixes for kvm on s390. [PATCH 1/2] kvm-s390: Fix refcounting and allow module unload [PATCH 2/2] kvm-s390: Fix memory leak of vcpu-run None of the fixed problems is severe. So I guess this should be scheduled for the next merge window. Thanks Christian -- To

[PATCH 1/2] kvm-s390: Fix refcounting and allow module unload

From: Christian Borntraeger [EMAIL PROTECTED] Currently it is impossible to unload the kvm module on s390. This patch fixes kvm_arch_destroy_vm to release all cpus. This make it possible to unload the module. In addition we stop messing with the module refcount in arch code. Signed-off

[PATCH 2/2] kvm-s390: Fix memory leak of vcpu-run

From: Christian Borntraeger [EMAIL PROTECTED] The s390 backend of kvm never calls kvm_vcpu_uninit. This causes a memory leak of vcpu-run pages. Lets call kvm_vcpu_uninit in kvm_arch_vcpu_destroy to free the vcpu-run. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] Acked-by: Carsten Otte

[PATCH/Request for review]: check for fops-owner in anon_inode_getfd

for easier review: From: Christian Borntraeger [EMAIL PROTECTED] There is an imbalance for anonymous inodes. If the fops-owner field is set, the module reference count of owner is decreases on release. (filp_close -- __fput --- fops_put) On the other hand, anon_inode_getfd does not increase the module

[PATCH v2]: check for fops-owner in anon_inode_getfd

, well spotted. I have added a fixup label. From: Christian Borntraeger [EMAIL PROTECTED] There is an imbalance for anonymous inodes. If the fops-owner field is set, the module reference count of owner is decreases on release. (filp_close -- __fput --- fops_put) On the other hand

Re: [PATCH v2]: check for fops-owner in anon_inode_getfd

Am Donnerstag, 27. November 2008 schrieb Davide Libenzi: === --- kvm.orig/fs/anon_inodes.c +++ kvm/fs/anon_inodes.c @@ -79,9 +79,12 @@ int anon_inode_getfd(const char *name, c if (IS_ERR(anon_inode_inode))

[PATCH 2/2] kvm: set owner of cpu and vm file operations

as there is an open file. kvm_destroy_vm will be called by the release function of the last closed file - before the VFS drops the module refcount. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- virt/kvm/kvm_main.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Index: kvm

[PATCH 1/2] anon_inodes: use fops-owner for module refcount

nobody has seen the module refcount negative. The refcounting was tested with a patched and unpatched KVM module.(see patch 2/2) I also did an epoll_open/close test. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] Reviewed-by: Davide Libenzi [EMAIL PROTECTED] --- fs/anon_inodes.c |7

[PATCH 0/2] module_refcounting and anonymous inodes

Hello Avi, here is the latest respin of my fixes for the kvm module unload problem: [PATCH 1/2] anon_inodes: use fops-owner for module refcount [PATCH 2/2] kvm: set owner of cpu and vm file operations Both patches fix module reference counting problems and only matter for module unload -

Re: [PATCH 0/2] module_refcounting and anonymous inodes

Am Dienstag, 9. Dezember 2008 schrieb Avi Kivity: Sheng Yang wrote: Should we push the first patch to 2.6.28? It's not a recent regression, so no. I got some trouble with the separate 2nd patch, for I am using Linus' tree and make KVM as modules, so the reference count reduced to

kvm-s390: Dont exit SIE on SIGP sense running

Avi, Marcello, Newer (guest) kernels use sigp sense running in their spinlock implementation to check if the other cpu is running before yielding the processor. This revealed some wrong guest settings, causing unnecessary exits for every sigp sense running. Signed-off-by: Christian Borntraeger

Re: kvm-s390: Dont exit SIE on SIGP sense running

Am Montag 21 Juni 2010, 10:27:50 schrieb Avi Kivity: [...] VCPU_EVENT(vcpu, 3, %s, free cpu); + clear_bit(63 - vcpu-vcpu_id, (unsigned long *)vcpu-kvm-arch.sca-mcn); if (vcpu-kvm-arch.sca-cpu[vcpu-vcpu_id].sda == (__u64) vcpu-arch.sie_block)

[PATCH] kvm-s390: fix potential array overrun in intercept handling

array overflow if code == 0x48. Since the table is only populated up to (0x28 2), we can reduce the jump table size while fixing the off-by-one. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- (patch was refreshed with -U8 to see the full jump table.) arch/s390/kvm/intercept.c

[PATCHv2] kvm-s390: fix potential array overrun in intercept handling

which would cause an off-by-one array overflow if code == 0x48. Use the compiler and ARRAY_SIZE to automatically set the limits. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- (patch was refreshed with -U8 to see the full jump table.) arch/s390/kvm/intercept.c |4 ++-- 1

Re: [PATCHv2] kvm-s390: fix potential array overrun in intercept handling

Am Donnerstag 21 Januar 2010 12:24:18 schrieb Heiko Carstens: - if (code 3 || code 0x48) + if (code 3 || (code 2) = ARRAY_SIZE(intercept_funcs)) return -ENOTSUPP; Not that it matters for this patch, but -ENOTSUPP should not leak to userspace. Not sure if it does

Re: [PATCH] KVM: Clean up vm creation and release

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 985d825..d8d1877 100644 --- a/arch/s390/kvm/kvm-s390.c +++ b/arch/s390/kvm/kvm-s390.c @@ -164,24 +164,18 @@ long kvm_arch_vm_ioctl(struct file *filp, return r; } -struct kvm *kvm_arch_create_vm(void) +int

[PATCH 0/3] kvm-s390: three kernel fixes

Hello Avi, here are small fixes for KVM on s390: 1. Fix printk on SIGP set arch 2. Fix problem state check for b2 intercepts 3. Fix SIGP set prefix ioctl I dont think any of the fixes is critical, but patch 1 allows a malicious guest to flood the host dmesg. Therefore, I want to push patch 1

[PATCH 2/3] kvm-s390: Fix problem state check for b2 intercepts

From: Christian Borntraeger borntrae...@de.ibm.com The kernel handles some priviledged instruction exits. While I was unable to trigger such an exit from guest userspace, the code should check for supervisor state before emulating a priviledged instruction. I also renamed kvm_s390_handle_priv

[PATCH 3/3] kvm-s390: Fix SIGP set prefix ioctl

From: Christian Borntraeger borntrae...@de.ibm.com This patch fixes the SET PREFIX interrupt if triggered by userspace. Until now, it was not necessary, but life migration will need it. In addition, it helped me creating SMP support for my kvm_crashme tool (lets kvm execute random guest memory

[PATCH 1/3] kvm-s390: Fix printk on SIGP set arch

From: Christian Borntraeger borntrae...@de.ibm.com KVM on s390 does not support the ESA/390 architecture. We refuse to change the architecture mode and print a warning. While testing a crashme for kvm, I spotted two problems with the printk: o A malicious can flood host dmesg o

[PATCH 1/3 v2] kvm-s390: Fix printk on SIGP set arch

Am Thursday 22 January 2009 12:58:57 schrieb Avi Kivity: Right, either inject an exception to the guest (if appropriate for the arch), or return -ESOMETHING from ioctl(KVM_RUN). Ok. What about: [PATCH] kvm-s390: fix printk on SIGP set arch From: Christian Borntraeger borntrae...@de.ibm.com

[PATCH] kvm: declare kvm_ioapic in kvm_host.h

this definition or declaration, which is probably not what you want [...] Declaring struct kvm_ioapic should help. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- include/linux/kvm_host.h |1 + 1 file changed, 1 insertion(+) Index: kvm/include/linux/kvm_host.h

Re: [PATCH] kvm: declare kvm_ioapic in kvm_host.h

on affected hardware From: Christian Borntraeger borntrae...@de.ibm.com Since KVM: Unify the delivery of IOAPIC and MSI interrupts I get the following warnings: CC [M] arch/s390/kvm/kvm-s390.o In file included from arch/s390/kvm/kvm-s390.c:22: include/linux/kvm_host.h:357: warning: 'struct

virtio_net: MAC address releated breakage if there is no MAC area in config

Hello, commit 9c46f6d42f1b5627c49a5906cb5b315ad8716ff0 Author: Alex Williamson alex.william...@hp.com Date: Wed Feb 4 16:36:34 2009 -0800 virtio_net: Allow setting the MAC address of the NIC Introduced an unconditional config-set to the MAC address field of the device config. + } else

Re: virtio_net: MAC address releated breakage if there is no MAC area in config

Am Thursday 02 April 2009 18:06:25 schrieb Alex Williamson: On Thu, 2009-04-02 at 13:33 +0200, Christian Borntraeger wrote: I read this as the mac config field is optional (similar to all the optional fields we added in virtio_blk later). [...] Sorry for the breakage. My interpretation

Re: [PATCH] virtio_blk: SG_IO passthru support

test with the kuli loader (s390 userspace). You can consider the VIRTIO_BLK_F_SCSI not available case Tested-by: Christian Borntraeger borntrae...@de.ibm.com Christian -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

Am Monday 27 April 2009 14:31:36 schrieb Michael S. Tsirkin: Add optional MSI-X support: use a vector per virtqueue with fallback to a common vector and finally to regular interrupt. Teach all drivers to use it. I added 2 new virtio operations: request_vqs/free_vqs because MSI needs to know

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

Am Monday 27 April 2009 16:32:56 schrieb Michael S. Tsirkin: I dont know, if that is feasible for MSI, but the transport(virtio_pci) should already know the number of virtqueues, which should match the number of vectors, no? I think no, the transport can find out the max number of

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

Am Monday 27 April 2009 17:39:36 schrieb Michael S. Tsirkin: So we'll probably need to rename request_vqs to request_vectors, but we probably still need the driver to pass the number of vectors it wants to the transport. Right? This might be a stupid idea, but would something like the

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

Am Tuesday 28 April 2009 18:37:01 schrieb Anthony Liguori: Christoph Hellwig wrote: Should we be handling some SCSI cmds internally to QEMU (like eject operations) and supporting media=cdrom in -drive for if=virtio? Not quite yet. Eventually I want to support a virtio-scsi

Re: [PATCH 1/2] S390: take a full byte as ext_param indicator

Am 23.08.2010 23:31, schrieb Alexander Graf: Currenty the ext_param field only distinguishes between config change and vring interrupt. We can do a lot more with it though, so let's enable a full byte of possible values and constants to #defines while at it. Makes a lot of sense. [...]

Re: [PATCH 2/2] S390: Add virtio hotplug add support

leverage the functionality. Signed-off-by: Alexander Graf ag...@suse.de With the minor nits below fixed: Acked-by: Christian Borntraeger borntrae...@de.ibm.com #define VIRTIO_PARAM_MASK0xff #define VIRTIO_PARAM_VRING_INTERRUPT 0x0 #define VIRTIO_PARAM_CONFIG_CHANGED 0x1 +#define

Re: [PATCH 1/2] S390: take a full byte as ext_param indicator

Am 24.08.2010 14:06, schrieb Alexander Graf: #define VIRTIO_SUBCODE_64 0x0D00 +#define VIRTIO_PARAM_MASK 0xff +#define VIRTIO_PARAM_VRING_INTERRUPT 0x0 +#define VIRTIO_PARAM_CONFIG_CHANGED0x1 Maybe this should be exported in a header, something like

Re: [PATCH 1/2] S390: take a full byte as ext_param indicator

Am 24.08.2010 14:22, schrieb Avi Kivity: First of all we need a virtio/s390 specification, like we have a virtio/pci spec. Here is something that I started a year ago but never finished. Christian guest/host interface for s390/virtio devices KVM_DEVICE_DESCRIPTOR PAGE

Re: 3.7-rc2 build failure on s390x

On 22/10/12 23:14, Alexander Graf wrote: Hi Christian, During our normal Factory kernel builds, s390x seems to choke: /home/abuild/rpmbuild/BUILD/kernel-default-3.7.rc2/linux-3.7-rc2/arch/s390/include/asm/kvm_para.h:147:99: error: redefinition of 'kvm_arch_para_features'

Re: 3.7-rc2 build failure on s390x

On 31/10/12 11:32, Alexander Graf wrote: On 23.10.2012, at 08:20, Christian Borntraeger borntrae...@de.ibm.com wrote: On 22/10/12 23:14, Alexander Graf wrote: Hi Christian, During our normal Factory kernel builds, s390x seems to choke: /home/abuild/rpmbuild/BUILD/kernel-default-3.7

[PATCH 0/1] s390 fix

Marcelo, here is a kvm related fix for s390. Please consider for the next merge window. Since it is s390 core kernel, I will also push it into Martins s390 tree. Christian Borntraeger (1): Subject: [PATCH] s390/kvm: Fix address space mixup arch/s390/kernel/entry64.S | 25

[PATCH 1/1] Subject: [PATCH] s390/kvm: Fix address space mixup

. (Otherwise we have a kernel bug anyway). We also have to compensate the rewinding, since the C-level handlers will do that. Therefore we need to add a nop with the same length as SIE before the sie_loop. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com CC: sta...@vger.kernel.org CC: Martin

Re: [PATCH 8/8] s390: Add new channel I/O based virtio transport.

On 11/12/12 11:53, Alexander Graf wrote: On 07.12.2012, at 13:50, Cornelia Huck wrote: Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that uses this virtio-ccw transport and make it the default machine for s390.

Re: [PATCH 4/4] KVM: s390: Add a channel I/O based virtio transport driver.

On 12/12/12 19:31, Alexander Graf wrote: +static inline long do_kvm_notify(struct subchannel_id schid, + unsigned long queue_index) +{ +register unsigned long __nr asm(1) = KVM_S390_VIRTIO_CCW_NOTIFY; +register struct subchannel_id __schid asm(2) = schid; How does

Re: [PATCH 4/4] KVM: s390: Add a channel I/O based virtio transport driver.

On 13/12/12 12:06, Alexander Graf wrote: On 12.12.2012, at 21:12, Christian Borntraeger wrote: On 12/12/12 19:31, Alexander Graf wrote: +static inline long do_kvm_notify(struct subchannel_id schid, + unsigned long queue_index) +{ +register unsigned long __nr asm(1

Re: [PATCH 4/4] KVM: s390: Add a channel I/O based virtio transport driver.

On 13/12/12 12:19, Alexander Graf wrote: On 13.12.2012, at 12:13, Christian Borntraeger wrote: On 13/12/12 12:06, Alexander Graf wrote: On 12.12.2012, at 21:12, Christian Borntraeger wrote: On 12/12/12 19:31, Alexander Graf wrote: +static inline long do_kvm_notify(struct subchannel_id

Re: [PATCH v5 0/3] s390: Guest support for virtio-ccw.

On 17/12/12 16:00, Alexander Graf wrote: On 14.12.2012, at 17:02, Cornelia Huck wrote: Hi, here's the virtio-ccw guest support for kvm/next again. The not-kvm specific patches have made their way upstream via the s390 tree in the meantime. Patch 2 fixes an inconsistency there. Patch 3

Re: [PATCH 2/5] KVM: s390: Add support for machine checks.

need to do exactly the same for the kvm gaccess functions. So __guestaddr_to_user() should just map all error codes to -EFAULT. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/gaccess.h | 7 +-- 1 file

Re: [PATCH 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

Have you written an appendix for the virtio specification for virtio-ccw? I think it would be good to include in this series for the purposes of review. Might be nice, but don't get fancy about it. Text will be fine and I can cut paste it in once it's finalized. There was a patch

Re: [PATCH v2 7/7] s390/kvm: In-kernel channel subsystem support.

On 19/09/12 16:47, Alexander Graf wrote: On 04.09.2012, at 17:13, Cornelia Huck wrote: Handle most support for channel I/O instructions in the kernel itself. Only asynchronous functions (such as the start function) need to be handled by userspace. Phew. This is a lot of code for

Re: [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', declared with attribute warn_unused_result

On 20/09/12 07:22, Michael S. Tsirkin wrote: On Thu, Sep 20, 2012 at 08:16:08AM +0800, Fengguang Wu wrote: Hi Michael, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/virt/kvm/kvm.git queue head: 879238fecc051d95037ae76332916209a7770709 commit:

[PATCH] s390/kvm: Fix vcpu_load handling in interrupt code

. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/interrupt.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 7556231..ff1e2f8 100644

[PATCH 0/3] s390/kvm: misc fixes

Avi, Marcelo, here are some fixes for kvm on s390. Would be good if we could add s390/kvm: dont announce RRBM support for 3.7 since the current kvm claims a feature that we currently dont support. Everything else can be queued for the next merge window. Thanks Christian Borntraeger (1

[PATCH 3/3] s390/kvm: dont announce RRBM support

+0x6c/0x27c) [ 2150.713749] [00233812] page_referenced+0x32a/0x410 [...] CC: sta...@vger.kernel.org CC: Alex Graf ag...@suse.de Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 2 +- 1 file

[PATCH 1/3] s390/kvm: Interrupt injection bugfix

Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/interrupt.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 7556231..744ac1b 100644

[PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.

From: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- Documentation/virtual/kvm/api.txt | 33 + 1

Re: [PATCH] virtio-blk: set QUEUE_ORDERED_DRAIN by default

-by: Christian Borntraeger borntrae...@de.ibm.com [...] - /* If barriers are supported, tell block layer that queue is ordered */ + /* + * If barriers are supported, tell block layer that queue is ordered. + * + * If no barriers are supported assume the host uses

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

Am Tuesday 28 April 2009 11:51:54 schrieb Christoph Hellwig: Not quite yet. Eventually I want to support a virtio-scsi kind of transport which would use the same virtio-blk protocol but only send scsi commands. We'd need a different driver on the Linux side for it that registers to the scsi

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

Am Wednesday 29 April 2009 12:50:04 schrieb Christoph Hellwig: On Tue, Apr 28, 2009 at 09:09:52PM +0200, Christian Borntraeger wrote: Yes, virtio-scsi is also something we were thinking of. The last time we discussed this idea of SCSI passthrough internally, we stumbled over error

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

Am Wednesday 29 April 2009 13:11:19 schrieb Paul Brook: On Wednesday 29 April 2009, Christoph Hellwig wrote: On Tue, Apr 28, 2009 at 11:37:01AM -0500, Anthony Liguori wrote: Ah, excellent. I think that's a great thing to do. So do you think virtio-scsi would deprecate virtio-blk? I

Re: [PATCH 2/6] kvm-s390: use hrtimer for clock wakeup from idle

Am Wednesday 06 May 2009 14:10:07 schrieb Avi Kivity: ehrha...@linux.vnet.ibm.com wrote: From: Christian Borntraeger borntrae...@de.ibm.com This patch reworks the s390 clock comparator wakeup to hrtimer. The clock comparator is a per-cpu value that is compared against the TOD clock

  1   2   3   4   5   6   7   8   9   10   >