On Wed, 2008-09-17 at 11:49 +0100, Mark McLoughlin wrote:
On Tue, 2008-09-16 at 22:24 +0300, Ben-Ami Yassour wrote:
On Tue, 2008-09-16 at 09:16 -0500, Anthony Liguori wrote:
Ben-Ami Yassour wrote:
I am running virtio with the latest KVM code, and see a significant
performance issue
I am running virtio with the latest KVM code, and see a significant
performance issue.
Ping to the host (or any other close machine) reports a 4ms delay.
In the same setup with an e1000 emulation (just changing model=virtio to
model=e1000 in the KVM command line), ping reports 0.177ms delay.
On Tue, 2008-09-16 at 09:16 -0500, Anthony Liguori wrote:
Ben-Ami Yassour wrote:
I am running virtio with the latest KVM code, and see a significant
performance issue.
Ping to the host (or any other close machine) reports a 4ms delay.
What kvm version and what host kernel version
On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote:
From: Or Sagi [EMAIL PROTECTED]
From: Nir Peleg [EMAIL PROTECTED]
From: Amit Shah [EMAIL PROTECTED]
From: Ben-Ami Yassour [EMAIL PROTECTED]
From: Glauber de Oliveira Costa [EMAIL PROTECTED]
With this patch, we can assign a device
On Thu, 2008-08-21 at 12:13 +0530, Amit Shah wrote:
* On Thursday 07 Aug 2008 19:44:47 Ben-Ami Yassour wrote:
Based on a patch by: Kay, Allen M [EMAIL PROTECTED]
This patch enables pci device assignment based on VT-d support.
When a device is assigned to the guest, the guest memory
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
Avi,
I am re-sending the VT-d patches, please apply.
The following two patches contains the VT-d support for device
assignment.
The first patch contains the changes that are required to the generic
VT-d code.
The second patch contains the changes to KVM.
Regards,
Ben
--
To unsubscribe from
-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/Makefile |3 +
arch/x86/kvm/vtd.c | 203
arch/x86/kvm/x86.c | 10 ++
include/asm-x86/kvm_host.h |3 +
include/linux/kvm_host.h
On Thu, 2008-08-07 at 09:21 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
On Wed, 2008-08-06 at 17:12 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
On Wed, 2008-08-06 at 14:18 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
On Tue, 2008-08-05 at 22:46 +0800, Han, Weidong wrote
-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/Makefile |3 +
arch/x86/kvm/vtd.c | 203
arch/x86/kvm/x86.c | 10 ++
include/asm-x86/kvm_host.h |3 +
include/linux/kvm_host.h
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
On Wed, 2008-08-06 at 17:12 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
On Wed, 2008-08-06 at 14:18 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
On Tue, 2008-08-05 at 22:46 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
[Ben: fixed memory pinning]
Signed-off-by: Kay
On Fri, 2008-08-01 at 11:09 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
+#define assigned_dev_ioport_write(suffix)
\
+static void assigned_dev_ioport_write##suffix(void *opaque,
\ + uint32_t addr
On Tue, 2008-08-05 at 14:01 +0800, Yang, Sheng wrote:
On Tuesday 29 July 2008 00:26:28 Ben-Ami Yassour wrote:
[Ben: fixed memory pinning]
kvm_free_physmem_slot(old, new);
+
+ /* map the pages in iommu page table */
+ if (intel_iommu_found())
+ kvm_iommu_map_pages
On Tue, 2008-08-05 at 22:46 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
+
+int kvm_iommu_map_guest
On Tue, 2008-07-29 at 14:49 +0530, Amit Shah wrote:
* On Monday 28 Jul 2008 21:56:26 Ben-Ami Yassour wrote:
+static int kvm_vm_ioctl_assign_device(struct kvm *kvm,
+ struct kvm_assigned_pci_dev *assigned_dev)
+{
+ if (pci_enable_device(dev
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
In some cases it is not enough to identify mmio memory slots by
pfn_valid. This patch adds checking the PageReserved as well.
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
Signed-off-by: Muli Ben-Yehuda [EMAIL PROTECTED]
---
virt/kvm/kvm_main.c | 22 +++---
1 files changed
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/Makefile |2 +-
arch/x86/kvm/vtd.c | 180
arch
Follwing is the patch for the userspace part
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
the kvm module (accompanied kernel changes are
necessary).
Signed-off-by: Amit Shah [EMAIL PROTECTED]
Signed-off-by: Nir Peleg [EMAIL PROTECTED]
Signed-off-by: Glauber de Oliveira Costa [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
libkvm/libkvm-x86.c | 13 +
libkvm
On Mon, 2008-07-28 at 14:49 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
From: Kay, Allen M [EMAIL PROTECTED]
{
if (pfn_valid(pfn))
return PageReserved(pfn_to_page(pfn));
I cannot find this is_mmio_pfn() definition on main KVM tree, and failed
to patch
On Mon, 2008-07-28 at 15:27 +0800, Yang, Sheng wrote:
On Tuesday 22 July 2008 20:13:53 Ben-Ami Yassour wrote:
-int kvm_pic_read_irq(struct kvm_pic *s)
+int kvm_pic_read_irq(struct kvm *kvm)
{
int irq, irq2, intno;
+ struct kvm_pic *s = pic_irqchip(kvm);
irq
On Wed, 2008-07-23 at 19:07 +0530, Amit Shah wrote:
* On Wednesday 16 Jul 2008 18:47:01 Ben-Ami Yassour wrote:
This patch fixes a few problems with the interrupt handling for
passthrough devices.
1. Pass the interrupt handler the pointer to the device, so we do not
need to lock
On Thu, 2008-07-24 at 19:01 +0530, Amit Shah wrote:
* On Thursday 24 Jul 2008 16:58:57 Ben-Ami Yassour wrote:
On Wed, 2008-07-23 at 19:07 +0530, Amit Shah wrote:
* On Wednesday 16 Jul 2008 18:47:01 Ben-Ami Yassour wrote:
if (irqchip_in_kernel(kvm)) {
+ match
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
Following are the device assignment patches with the fixes of the
comments that were sent for the previous version.
Here is the list of changes that were made with respect to the previous
version:
1. Replace the interrupt ack hook patches with the notifiers list patch
by Avi.
2. Remove code from
From: Kay, Allen M [EMAIL PROTECTED]
This patch includes the functions to support VT-d for passthrough
devices.
[Ben: fixed memory pinning, cleanup]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED
the device to perform DMA.
Another alternative is PVDMA.
Signed-off-by: Amit Shah [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
---
arch/x86/kvm/i8259.c |5 +-
arch/x86/kvm/irq.c |2 +-
arch/x86/kvm/irq.h
Followed is the userspace patch for device assignment
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
the kvm module (accompanied kernel changes are
necessary).
Signed-off-by: Amit Shah [EMAIL PROTECTED]
Signed-off-by: Nir Peleg [EMAIL PROTECTED]
Signed-off-by: Glauber de Oliveira Costa [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
libkvm/libkvm-x86.c |8 +
libkvm
Sheng,
Thanks for the comments, I sent an updated version of the patches.
Please see reply below.
Thanks,
Ben
On Thu, 2008-07-17 at 10:00 +0800, Yang, Sheng wrote:
Some comments below. :)
On Wednesday 16 July 2008 23:56:50 Ben-Ami Yassour wrote:
+ __func__
On Thu, 2008-07-17 at 15:52 +0800, Han, Weidong wrote:
Ben-Ami Yassour wrote:
From: Or Sagi [EMAIL PROTECTED]
From: Nir Peleg [EMAIL PROTECTED]
From: Amit Shah [EMAIL PROTECTED]
From: Glauber de Oliveira Costa [EMAIL PROTECTED]
We can assign a device from the host machine
On Thu, 2008-07-17 at 09:02 +0300, Avi Kivity wrote:
Han, Weidong wrote:
Avi Kivity wrote:
+static void kvm_pci_pt_work_fn(struct work_struct *work) +{
+ struct kvm_pci_pt_dev_list *match;
+ struct kvm_pci_pt_work *int_work;
+ int source;
+ unsigned long flags;
+ int guest_irq;
On Thu, 2008-07-10 at 16:57 +0300, Avi Kivity wrote:
Ben-Ami Yassour wrote:
On Mon, 2008-07-07 at 13:08 +0300, Avi Kivity wrote:
Amit Shah wrote:
This will be useful for acking irqs of assigned devices
And also for improving time drift tracking.
Please make
On Thu, 2008-07-17 at 11:31 +0300, Avi Kivity wrote:
Ben-Ami Yassour wrote:
+
+/* FIXME: Implement the OR logic needed to make shared interrupts
on + * this line behave properly + */
Isn't this a showstopper? There is no easy way for a user to avoid
sharing
In last few tests that we made with PCI-passthrough and VT-d using
iperf, we were able to get the same throughput as on native OS with a 1G
NIC (with higher CPU utilization).
The following patches are the PCI-passthrough patches that Amit sent
(re-based on the last kvm tree), followed by a few
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/x86.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8d25b4a..65b307d 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -343,9 +343,9 @@ static void
handler before
cleaning queued work.
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/x86.c | 156 ++-
include/asm-x86/kvm_host.h |5 +-
virt/kvm/ioapic.c |5 +-
3 files changed, 69 insertions(+), 97 deletions(-)
diff
This patch includes the functions to support VT-d for passthrough
devices.
[Ben: fixed memory pinning, cleanup]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/Makefile |2
Avoid mapping mmio memory slots.
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/vtd.c | 20 +---
include/asm-x86/kvm_host.h |2 ++
virt/kvm/kvm_main.c|2 +-
3 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kvm
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
From: Amit Shah [EMAIL PROTECTED]
This will be useful for acking irqs of assigned devices
Signed-off-by: Amit Shah [EMAIL PROTECTED]
---
virt/kvm/ioapic.c |3 +++
virt/kvm/ioapic.h |1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
On Wed, 2008-07-16 at 17:36 +0300, Avi Kivity wrote:
Ben-Ami Yassour wrote:
In last few tests that we made with PCI-passthrough and VT-d using
iperf, we were able to get the same throughput as on native OS with a 1G
NIC
Excellent!
(with higher CPU utilization).
How much
the device to perform DMA.
Another alternative is PVDMA.
Signed-off-by: Amit Shah [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
Signed-off-by: Han, Weidong [EMAIL PROTECTED]
---
arch/x86/kvm/x86.c | 267
include/asm-x86
the device to perform DMA.
Another alternative is PVDMA.
Signed-off-by: Amit Shah [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
Signed-off-by: Han, Weidong [EMAIL PROTECTED]
---
arch/x86/kvm/x86.c | 267
include/asm-x86
Please ignore this repeated patch
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 2008-07-13 at 10:34 +0300, Avi Kivity wrote:
Muli Ben-Yehuda wrote:
On the other hand, this means that you will not be able to assign
devices unless you specified this when creating the VM; but I think
this is fair.
It will be nice to support hot-plugged pass-through
From: Kay, Allen M [EMAIL PROTECTED]
This patch includes the functions to support VT-d for passthrough
devices.
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
On Wed, 2008-07-09 at 10:49 -0500, Anthony Liguori wrote:
Ben-Ami Yassour wrote:
From: Kay, Allen M [EMAIL PROTECTED]
This patch includes the functions to support VT-d for passthrough
devices.
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off
From: Kay, Allen M [EMAIL PROTECTED]
This patch includes the functions to support VT-d for passthrough
devices.
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86
On Sat, 2008-07-05 at 13:55 +0300, Avi Kivity wrote:
Ben-Ami Yassour wrote:
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c
On Sat, 2008-07-05 at 14:05 +0300, Avi Kivity wrote:
Amit Shah wrote:
This function injects an interrupt into the guest given the kvm struct,
the (guest) irq number and the interrupt level.
Signed-off-by: Amit Shah [EMAIL PROTECTED]
---
arch/x86/kvm/irq.c | 11 +++
check that an injected pic irq is between 0 and 15.
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86/kvm/i8259.c |6 --
arch/x86/kvm/irq.h |2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index 3ba5e5c
Weidong,
There seems to be line wrapping issues with the patch.
Please resend it.
Thanks,
Ben
On Thu, 2008-07-03 at 17:05 +0800, Han, Weidong wrote:
Multiple devices may under different IOMMUs, so one dmar_domain cannot
cover this. This patch abstracts a structure kvm_vtd_domain, which let
From: Kay, Allen M [EMAIL PROTECTED]
This patch extends the VT-d driver to support KVM
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
drivers/pci/dmar.c |4
From: Kay, Allen M [EMAIL PROTECTED]
This patch includes the functions to support VT-d for passthrough
devices.
[Ben: fixed memory pinning]
Signed-off-by: Kay, Allen M [EMAIL PROTECTED]
Signed-off-by: Weidong Han [EMAIL PROTECTED]
Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED]
---
arch/x86
On Thu, 2008-06-19 at 16:59 +0800, Han, Weidong wrote:
[EMAIL PROTECTED] wrote:
From: Ben-Ami Yassour [EMAIL PROTECTED]
When changing the VT-d context mapping, according to the spec, it is
required
to first set the context to not present, flush and only then apply the
new context
Amit,
With the current implementation we have an issue if the driver on the
host was never loaded.
To be able to run kvm with passthrough we have to load and then unload
the driver on the host at least once. After that it works ok.
Note that after doing the load and unload the irq as reported
On Tue, 2008-06-03 at 13:39 +0200, Andrea Arcangeli wrote:
On Tue, Jun 03, 2008 at 02:17:55PM +0300, Ben-Ami Yassour wrote:
Anthony Liguori [EMAIL PROTECTED] wrote on 04/29/2008 05:32:09 PM:
Subject
[PATCH] Handle vma regions with no backing page
This patch allows VMA's that contain
Anthony Liguori [EMAIL PROTECTED] wrote on 04/29/2008 05:32:09 PM:
Subject
[PATCH] Handle vma regions with no backing page
This patch allows VMA's that contain no backing page to be used for guest
memory. This is a drop-in replacement for Ben-Ami's first page in his direct
mmio series.
From 8fe13bcea014a3b896a79fca5d15ddd32050694c Mon Sep 17 00:00:00 2001
From: Ben-Ami Yassour [EMAIL PROTECTED]
Date: Tue, 3 Jun 2008 12:34:51 +0300
Subject: [PATCH] KVM: PCIPT: direct mmio
This patch for PCI passthrough devices enables a guest to access a
device's memory mapped I/O regions
case.
Regards,
Ben
From 0c28d1bb1d79049f3ffdf96965829a47eb2e9199 Mon Sep 17 00:00:00 2001
From: Ben-Ami Yassour [EMAIL PROTECTED]
Date: Tue, 3 Jun 2008 12:22:17 +0300
Subject: [PATCH] KVM: PCIPT: VT-d: avoid mapping memory slots with no backing
page
This patch is for the VT-d support for pci
and it seems to work ok.
Please let me know if you have comments.
Regards,
Ben
From b847cef27c6c6dfff15b8fc9682e4c6563e997f3 Mon Sep 17 00:00:00 2001
From: Ben-Ami Yassour [EMAIL PROTECTED]
Date: Thu, 29 May 2008 19:39:14 +0300
Subject: [PATCH] KVM: PCIPT: interrupt work structure per device
66 matches
Mail list logo
