Re: [PATCH] kvm/s390: drop unpaired smp_mb

On 01/05/2016 05:20 PM, Michael S. Tsirkin wrote: > smp_mb on vcpu destroy isn't paired with anything, violating pairing > rules, and seems to be useless. > > Drop it. > > Signed-off-by: Michael S. Tsirkin Applied. (I had to fix this up a little to match kvm/next) Thanks >

Re: [PATCH 3/4] KVM: renumber architecture-dependent requests

On 01/07/2016 03:17 PM, Paolo Bonzini wrote: > Leave room for 4 more arch-independent requests. > The patch subject is wrong. "renumber architecture-dependent requests" --> "renumber kvm requests" as we also renumber the architecture independent ones. -- To unsubscribe from this list: send

Re: [PATCH 4/4] KVM: move architecture-dependent requests to arch/

On 01/07/2016 03:17 PM, Paolo Bonzini wrote: Can you add at least a one line patch description? > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > arch/powerpc/include/asm/kvm_host.h | 4 >

[GIT PULL 2/4] KVM: s390: obey kptr_restrict in traces

; Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 9 + arch/s390/kvm/trace-s390.h | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 6dec01d..c14845c 100644 --- a/arch

[GIT PULL 1/4] KVM: s390: use assignment instead of memcpy

Replace two memcpy with proper assignment. Suggested-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch

[GIT PULL 0/4] KVM: s390 features and fixes for 4.5 (kvm/next)

, e.g. 3 levels for a 2GB guest instead of 2 levels) - We now ask the machine about the max. supported guest address and limit accordingly. Christian Borntraeger (2): KVM: s390: use assignment instead of memcpy KVM: s390

[GIT PULL 3/4] KVM: s390: fix mismatch between user and in-kernel guest limit

David Hildenbrand <d...@linux.vnet.ibm.com> Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- Documentation/virtual/kvm/devices/vm.txt | 3 ++- ar

[GIT PULL 4/4] KVM: s390: consider system MHA for guest storage

Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Guenther Hutzl <hu...@linux.vnet.ibm.com> Signed-off-by: Dominik Dingel <din...@linux.vnet.ibm.com> [adopt to match recent limit,size changes] Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com&g

[GIT PULL 02/23] KVM: use heuristic for fast VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Usually, VCPU ids match the array index. So let's try a fast lookup first before falling back to the slow iteration. Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ib

[GIT PULL 14/23] KVM: s390: we always have a SCA

ff-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 16c19fb..5c58127 100644

[GIT PULL 01/23] KVM: Use common function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's reuse the new common function for VPCU lookup by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

[GIT PULL 10/23] KVM: s390: Make provisions for ESCA utilization

ESCA cases. Also the kvm.arch.use_esca flag is provided. The actual functionality is kept the same. Signed-off-by: Eugene (jno) Dvurechenski <j...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 3 +- arch/s390

[GIT PULL 17/23] KVM: s390: cleanup sca_add_vcpu

From: David Hildenbrand <d...@linux.vnet.ibm.com> Now that we already have kvm and the VCPU id set for the VCPU, we can convert sda_add_vcpu to look much more like sda_del_vcpu. Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeg

[GIT PULL 19/23] s390/sclp: introduce check for SIE

..@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/sclp.h | 6 +- drivers/s390/char/sclp_early.c | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/s390/include/asm/sclp.h b/arch/s390/include/asm/sclp.h

[GIT PULL 23/23] KVM: s390: remove redudant assigment of error code

rc already contains -ENOMEM, no need to assign it twice. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> --- arch/s390/kvm/kvm-s390.c | 4 +--- 1 file ch

[GIT PULL 08/23] KVM: s390: Provide SCA-aware helpers for VCPU add/del

: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 44 +++- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch

[GIT PULL 05/23] s390/sclp: introduce checks for ESCA and HVS

gt; Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/sclp.h | 2 ++ drivers/s390/char/sclp_early.c | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/s390/incl

[GIT PULL 11/23] KVM: s390: Introduce switching code

@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 1 + arch/s390/kvm/gaccess.c | 30 arch/s390/kvm/interrupt.c| 6 arch/s390/kvm/kvm-s390.c | 75 +

[GIT PULL 15/23] KVM: s390: fix SCA related races and double use

y been registered at the VM. We also have to make sure to update ECB at that point. Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 11 +-- 1 file changed, 5 insertions(+), 6 deleti

[GIT PULL 21/23] KVM: s390: don't load kvm without virtualization support

vid Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 539d385..49d3319 100644 --- a/arch/s390/kvm/kvm-s390.c

[GIT PULL 12/23] KVM: s390: Enable up to 248 VCPUs per VM

@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 2 +- arch/s390/kvm/kvm-s390.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_h

[GIT PULL 03/23] KVM: Remove unnecessary debugfs dentry references

remove them by using debugfs_remove_recursive(kvm_debugfs_dir). Therefore we don't need the extra tracking in the kvm_stats_debugfs_item anymore. Signed-off-by: Janosch Frank <fran...@linux.vnet.ibm.com> Reviewed-By: Sascha Silbe <si...@linux.vnet.ibm.com> Acked-by: Christian Bor

[GIT PULL 06/23] KVM: s390: Generalize access to IPTE controls

ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/gaccess.c | 10 +- arch/s390/kvm/kvm-s390.h | 5 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c index a7559f7..06f7edb 100644 -

[GIT PULL 16/23] KVM: s390: always set/clear the SCA sda field

and <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 2ba5978..7e0092b 100644 -

[GIT PULL 09/23] KVM: s390: Introduce new structures

rols were turned into bitfields instead of hardcoded bitmasks. Signed-off-by: Eugene (jno) Dvurechenski <j...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 47 +++- arch/s390

[GIT PULL 18/23] KVM: s390: don't switch to ESCA for ucontrol

tructures are safe as well. Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390

[GIT PULL 04/23] KVM: s390: rewrite vcpu_post_run and drop out early

rcepts to the place where it belongs and convert it to -EREMOTE. Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...

[GIT PULL 07/23] KVM: s390: Generalize access to SIGP controls

ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/interrupt.c | 72 +-- 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 6a75352..2a4718

[GIT PULL 00/23] KVM: s390 features, kvm_get_vcpu_by_id and stat for 4.5

== No. VCPU Christian Borntraeger (1): KVM: s390: remove redudant assigment of error code David Hildenbrand (12): KVM: Use common function for VCPU lookup by id KVM: use heuristic for fast VCPU lookup by id KVM

[GIT PULL 22/23] KVM: s390: remove pointless test_facility(2) check

From: Heiko Carstens <heiko.carst...@de.ibm.com> This evaluates always to 'true'. Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch

[GIT PULL 13/23] KVM: s390: fast path for sca_ext_call_pending

From: David Hildenbrand <d...@linux.vnet.ibm.com> If CPUSTAT_ECALL_PEND isn't set, we can't have an external call pending, so we can directly avoid taking the lock. Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.

[GIT PULL 20/23] s390: show virtualization support in /proc/cpuinfo

ist. The content is simply concatenated to the existing features when printing /proc/cpuinfo. We also add the defines to elf.h to keep the hwcap stuff at a common place. Acked-by: Martin Schwidefsky <schwidef...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com

Re: [GIT PULL 04/23] KVM: s390: rewrite vcpu_post_run and drop out early

On 12/02/2015 01:20 PM, Paolo Bonzini wrote: > > > On 02/12/2015 12:06, Christian Borntraeger wrote: >> +memcpy(>run->s.regs.gprs[14], >arch.sie_block->gg14, 16); > > This is preexisting but... boy it's ugly. :) > > Do you gain much over the simpl

Re: [GIT PULL 04/23] KVM: s390: rewrite vcpu_post_run and drop out early

On 12/02/2015 02:05 PM, Paolo Bonzini wrote: > > > On 02/12/2015 14:04, Christian Borntraeger wrote: >>>> Do you gain much over the simpler >>>> >>>>vcpu->run->s.regs.gprs[14] = vcpu->arch.sie_block->gg14; >>>>vcpu

Re: [PATCH v2] vhost: replace % with & on data path

On 11/30/2015 10:15 AM, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. Makes a lot of sense and virtio_ring.c seems to use the same logic. Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > > Signed-off-by:

Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

On 11/27/2015 09:42 PM, Tyler Baker wrote: > On 27 November 2015 at 10:53, Tyler Baker <tyler.ba...@linaro.org> wrote: >> On 27 November 2015 at 09:08, Tyler Baker <tyler.ba...@linaro.org> wrote: >>> On 27 November 2015 at 00:54, Christian Borntraeger >>> <

Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

On 11/26/2015 09:47 PM, Christian Borntraeger wrote: > On 11/26/2015 05:17 PM, Tyler Baker wrote: >> Hi Christian, >> >> The kernelci.org bot recently has been reporting kvm guest boot >> failures[1] on various arm64 platforms in next-20151126. The bot >> bisec

Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

On 11/26/2015 05:17 PM, Tyler Baker wrote: > Hi Christian, > > The kernelci.org bot recently has been reporting kvm guest boot > failures[1] on various arm64 platforms in next-20151126. The bot > bisected[2] the failures to the commit in -next titled "KVM: Create > debugfs dir and stat files for

[PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

.ibm.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Cc: Dan Carpenter <dan.carpen...@oracle.com> [multiple fixes] Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/kvm_host.h | 7 ++ virt/kvm/kvm_main.c | 194

[PATCH v2 0/2] RFC: kvm stat enhancements

Paolo, here is an updated version of the kvm_stat enhancements. (containing the fixes from Dan Carpenter) I am preparing a pull request for s390 and I could add these patches into the pull request. Shall I defer these patches until further review, or are we confident enough to add them to queue

[PATCH 1/2] KVM: Remove unnecessary debugfs dentry references

remove them by using debugfs_remove_recursive(kvm_debugfs_dir). Therefore we don't need the extra tracking in the kvm_stats_debugfs_item anymore. Signed-off-by: Janosch Frank <fran...@linux.vnet.ibm.com> Reviewed-By: Sascha Silbe <si...@linux.vnet.ibm.com> Acked-by: Christian Bor

Re: linux-next: manual merge of the kvms390 tree with the kvm tree

On 11/20/2015 02:47 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the kvms390 tree got a conflict in: > > include/linux/kvm_host.h > arch/s390/kvm/interrupt.c > arch/s390/kvm/sigp.c > > between commits: > > db27a7a37aa0 ("KVM: Provide function for VCPU lookup by

[PATCH 4/4] KVM: Use common function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's reuse the new common function for VPCU lookup by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

[PATCH 2/4] KVM: s390: fix wrong lookup of VCPUs by array index

by id, not array index. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> [split stable/non-stable parts] Cc: sta...@vger.kernel.org # c3853a8: KVM: P

[PATCH 3/4] KVM: use heuristic for fast VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Usually, VCPU ids match the array index. So let's try a fast lookup first before falling back to the slow iteration. Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ib

[PATCH 1/4] KVM: Provide function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's provide a function to lookup a VCPU by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

[PATCH 2/4] KVM: s390: fix wrong lookup of VCPUs by array index

by id, not array index. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> [split stable/non-stable parts] Cc: sta...@vger.kernel.org # c3853a8: KVM: P

[PATCH 1/4] KVM: Provide function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's provide a function to lookup a VCPU by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

[PATCH 0/4] Preview: vcpu lookup by id changes

Paolo, some more patches for review before I add them in my next pull request. Can you review the common code changes and Ack/Nack? Alex, Paul, can you review the power changes and Ack/Nack? As I want to have patch 2 in 4.4, I splitted up Davids patch into smaller chunks. David, can you double

[PATCH 3/4] KVM: use heuristic for fast VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Usually, VCPU ids match the array index. So let's try a fast lookup first before falling back to the slow iteration. Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ib

[PATCH 0/4] Preview: vcpu lookup by id changes

Paolo, some more patches for review before I add them in my next pull request. Can you review the common code changes and Ack/Nack? Alex, Paul, can you review the power changes and Ack/Nack? As I want to have patch 2 in 4.4, I splitted up Davids patch into smaller chunks. David, can you double

[PATCH 4/4] KVM: Use common function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's reuse the new common function for VPCU lookup by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

Re: [PATCH 0/4] Preview: vcpu lookup by id changes

On 11/19/2015 10:38 AM, Paolo Bonzini wrote: > > > On 19/11/2015 09:37, Christian Borntraeger wrote: >> >> some more patches for review before I add them in my next pull request. >> Can you review the common code changes and Ack/Nack? >> >> Alex, Paul, >

Re: [PATCH 0/4] Preview: vcpu lookup by id changes

On 11/19/2015 10:38 AM, Paolo Bonzini wrote: > > > On 19/11/2015 09:37, Christian Borntraeger wrote: >> >> some more patches for review before I add them in my next pull request. >> Can you review the common code changes and Ack/Nack? >> >> Alex, Paul, >

Re: [PATCH 2/4] KVM: s390: fix wrong lookup of VCPUs by array index

Sigh. Seems that my mail script got confused by the # after stable. So please strip down the cc list. On 11/19/2015 09:37 AM, Christian Borntraeger wrote: > From: David Hildenbrand <d...@linux.vnet.ibm.com> > > For now, VCPUs were always created sequentially with incremen

Re: [PATCH 2/4] KVM: s390: fix wrong lookup of VCPUs by array index

Sigh. Seems that my mail script got confused by the # after stable. So please strip down the cc list. On 11/19/2015 09:37 AM, Christian Borntraeger wrote: > From: David Hildenbrand <d...@linux.vnet.ibm.com> > > For now, VCPUs were always created sequentially with incremen

Re: [patch 1/2] KVM: fix error handling in kvm_create_vm_debugfs()

On 11/19/2015 01:40 PM, Dan Carpenter wrote: > The "goto out_err" is buggy because we forgot to set the return code. > > The other issue is that if the kmalloc() fails, we should remove the > debugfs directory before returning. > > Fixes: 7805f53a85ec ('KVM: Create debugfs dir and stat files for

Re: [PATCH 1/4] KVM: Provide function for VCPU lookup by id

On 11/19/2015 02:13 PM, Paolo Bonzini wrote: > > > On 19/11/2015 13:55, David Hildenbrand wrote: I'm pretty sure this will cause confusion in the future! ==> Could you maybe name the new function something like "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? >> Had

Re: [PATCH 1/4] KVM: Provide function for VCPU lookup by id

On 11/19/2015 02:13 PM, Paolo Bonzini wrote: > > > On 19/11/2015 13:55, David Hildenbrand wrote: I'm pretty sure this will cause confusion in the future! ==> Could you maybe name the new function something like "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? >> Had

[GIT PULL 3/5] KVM: Provide function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's provide a function to lookup a VCPU by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

[GIT PULL 5/5] KVM: s390: fix wrong lookup of VCPUs by array index

by id, not array index. Let's also use kvm_lookup_vcpu() for validation of the sending VCPU on external call injection. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <bornt

[GIT PULL 4/5] KVM: s390: avoid memory overwrites on emergency signal injection

he bitmap. Let's take care of this case and check that the id is in the valid range. Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Cc: sta...@vger.kernel.org # v3.19+ db27a7a KVM: Provide function for VCPU lookup by id Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com&

[GIT PULL 1/5] KVM: s390: enable SIMD only when no VCPUs were created

enable SIMD, undefined behaviour could be possible (e.g. vector save area not being set up). Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christi

[GIT PULL 2/5] KVM: s390: fix pfmf intercept handler

From: Heiko Carstens <heiko.carst...@de.ibm.com> The pfmf intercept handler should check if the EDAT 1 facility is installed in the guest, not if it is installed in the host. Signed-off-by: Heiko Carstens <heiko.carst...@de.ibm.com> Signed-off-by: Christian Borntraeger <borntra

[GIT PULL 0/5] KVM: s390: Fixes for 4.4

Paolo, The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-master-4.4-1 for you to fetch changes up to

[PATCH 1/2] KVM: Remove unnecessary debugfs dentry references

remove them by using debugfs_remove_recursive(kvm_debugfs_dir). Therefore we don't need the extra tracking in the kvm_stats_debugfs_item anymore. Signed-off-by: Janosch Frank <fran...@linux.vnet.ibm.com> Reviewed-by: Sascha Silbe <si...@linux.vnet.ibm.com> Acked-by: Christian Bor

[PATCH 0/2] kvm: provide kvm stat per process

Paolo, I plan to submit these patches via my next s390 pull request. Basic idea is: we already have all kvm_stats per cpu and per vm, lets provide some additional debugfs folders to get kvm_stats also per VM to detect cases where only one guest goes wild. (no per vCPU stats yet. Do we want those

[PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

.ibm.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/kvm_host.h | 7 ++ virt/kvm/kvm_main.c | 188 +-- 2 files changed, 187 insertions(+), 8 dele

Re: [PATCH] mm: Loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390

(something); == EINVAL; seems strange. So I think changing the kernel is the better approach. > > Glad to hear KVM postcopy live migration is already running on s390 too. > > Thanks, > Andrea > >> >> Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com> Acke

Re: [PATCH] mm: Loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390

Am 11.11.2015 um 18:30 schrieb Andrea Arcangeli: > Hi Jason, > > On Wed, Nov 11, 2015 at 10:35:16AM -0500, Jason J. Herne wrote: >> MADV_NOHUGEPAGE processing is too restrictive. kvm already disables >> hugepage but hugepage_madvise() takes the error path when we ask to turn >> on the

Re: [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

Am 02.11.2015 um 10:40 schrieb James Hogan: > On Mon, Nov 02, 2015 at 05:26:42PM +0800, Haozhong Zhang wrote: >> The value of the migrated vcpu's TSC rate is determined as below. >> 1. If a TSC rate is specified by the cpu option 'tsc-freq', then this >> user-specified value will be used. >>

Re: [PATCH 3/3] s390/dma: Allow per device dma ops

Am 03.11.2015 um 13:26 schrieb Cornelia Huck: > On Tue, 3 Nov 2015 12:54:39 +0100 > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> As virtio-ccw now has dma ops, we can no longer default to the PCI ones. >> Make use of dev_archdata to keep the dma_ops

[GIT PULL v4 2/3] alpha/dma: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> --- arch/alpha/kernel/pci-noop.c | 46 1 fil

[GIT PULL v4 0/3] dma and virtio prep patches

/linux.git dma for you to fetch changes up to fc7f9754db6ce0c12281da4055281f731d36bdee: s390/dma: Allow per device dma ops (2015-11-05 21:02:40 +0100) Christian Borntraeger (3): dma: Provide simple noop dma ops alpha/dma

[GIT PULL v4 1/3] dma: Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe..

[GIT PULL v4 3/3] s390/dma: Allow per device dma ops

. To compile without PCI support we will enable HAS_DMA all the time, via the default config in lib/Kconfig. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> Acked-by: Sebastian Ott <seb...@linux.vnet.ibm.com> ---

Re: [PATCH/RFC 0/4] dma ops and virtio

Am 02.11.2015 um 21:23 schrieb Andy Lutomirski: > On Mon, Nov 2, 2015 at 3:16 AM, Cornelia Huck > wrote: >> On Fri, 30 Oct 2015 13:33:07 -0700 >> Andy Lutomirski wrote: >> >>> On Fri, Oct 30, 2015 at 1:25 AM, Cornelia Huck

[PATCH 1/3] dma: Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/dma-mapping.h | 2 +

[PATCH 2/3] alpha/dma: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> --- arch/alpha/kernel/pci-noop.c | 46 1 fil

[PATCHv3 0/3] dma ops and virtio

loc - prefix patches with *dma* v1->v2: - initial testing - always use dma_noop_ops if device has no private dma_ops - get rid of setup in virtio_ccw,kvm_virtio - set CONFIG_HAS_DMA(ATTRS) for virtio (fixes compile for !PCI) - rename s390_dma_ops to s390_pci_dma_ops Christian Borntraeger (3): dma: P

[PATCH 3/3] s390/dma: Allow per device dma ops

also have to enable the DMA api with virtio. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> Acked-by: Sebastian Ott <seb...@linux.vnet.ibm.com> --- arch/s390/Kconfig | 3 ++- arch/s390/include/asm

Re: [PATCH 1/3] Provide simple noop dma ops

Am 02.11.2015 um 16:16 schrieb Joerg Roedel: > On Fri, Oct 30, 2015 at 02:20:35PM +0100, Christian Borntraeger wrote: >> +static void *dma_noop_alloc(struct device *dev, size_t size, >> +dma_addr_t *dma_handle, gfp_t gfp, >> +st

Re: [PATCH v4 2/6] virtio_ring: Support DMA APIs

Am 30.10.2015 um 13:01 schrieb Cornelia Huck: > On Thu, 29 Oct 2015 18:09:47 -0700 > Andy Lutomirski wrote: > >> virtio_ring currently sends the device (usually a hypervisor) >> physical addresses of its I/O buffers. This is okay when DMA >> addresses and physical addresses are

[PATCHv2 0/3] dma ops and virtio

tio (fixes compile for !PCI) - rename s390_dma_ops to s390_pci_dma_ops Christian Borntraeger (3): Provide simple noop dma ops alpha: use common noop dma ops s390/dma: Allow per device dma ops arch/alpha/kernel/pci-noop.c| 46 ++ arch/s390/Kcon

Re: [PATCH v4 1/6] virtio-net: Stop doing DMA from the stack

Am 30.10.2015 um 02:09 schrieb Andy Lutomirski: > From: "Michael S. Tsirkin" > > Once virtio starts using the DMA API, we won't be able to safely DMA > from the stack. virtio-net does a couple of config DMA requests > from small stack buffers -- switch to using

Re: [PATCH 4/4] s390/virtio: use noop dma ops

Am 30.10.2015 um 13:17 schrieb Cornelia Huck: > On Tue, 27 Oct 2015 23:48:51 +0100 > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> With all infrastructure in place, lets provide dma_ops for virtio >> devices on s390. >> >> Signed-off-by: Christ

Re: [PATCH 1/4] Provide simple noop dma ops

Am 28.10.2015 um 01:41 schrieb Joerg Roedel: > Hi Christian, > > On Tue, Oct 27, 2015 at 11:48:48PM +0100, Christian Borntraeger wrote: >> +static dma_addr_t dma_noop_map_page(struct device *dev, struct page *page, >> + unsigned lon

Re: [PATCH 4/4] s390/virtio: use noop dma ops

Am 28.10.2015 um 01:43 schrieb Joerg Roedel: > On Tue, Oct 27, 2015 at 11:48:51PM +0100, Christian Borntraeger wrote: >> @@ -1093,6 +1094,7 @@ static void virtio_ccw_auto_online(void *data, >> async_cookie_t cookie) >> struct ccw_device *cdev = data; >>

[PATCH 1/3] Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/dma-mapping.h | 2 +

[PATCH 2/3] alpha: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/alpha/kernel/pci-noop.c | 46 1 file changed, 4 insertions(+), 42 deletions(-) diff --git

[PATCH 3/3] s390/dma: Allow per device dma ops

also have to enable the DMA api with virtio. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/Kconfig | 3 ++- arch/s390/include/asm/device.h | 6 +- arch/s390/include/asm/dma-mapping.h | 6 -- arch/s390/pci/pci.c | 1 +

Re: [PATCH v4 0/6] virtio core DMA API conversion

Am 30.10.2015 um 02:09 schrieb Andy Lutomirski: > This switches virtio to use the DMA API unconditionally. I'm sure > it breaks things, but it seems to work on x86 using virtio-pci, with > and without Xen, and using both the modern 1.0 variant and the > legacy variant. > > This appears to work

[GIT PULL 0/3] KVM: s390: Bugfix and cleanups for kvm/next (4.4)

ins two cleanups. ---- Christian Borntraeger (2): KVM: s390: drop useless newline in debugging data KVM: s390: use simple switch statement as multiplexer David Hildenbrand (1): KVM: s390: SCA must not cross page boundar

[GIT PULL 3/3] KVM: s390: use simple switch statement as multiplexer

--368 Right now my gcc does conditional branches instead of jump tables. The inlining seems to give us enough cycles as some micro-benchmarking shows minimal improvements, but still in noise. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Cornelia Huck <c

[GIT PULL 2/3] KVM: s390: drop useless newline in debugging data

the s390 debug feature does not need newlines. In fact it will result in empty lines. Get rid of 4 leftovers. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 8 1 file changed,

[GIT PULL 1/3] KVM: s390: SCA must not cross page boundaries

lls via SIGP IF. Especially the 2. happens regularly. So this could produce two problems: 1. The guest losing/getting external calls. 2. Random memory overwrites in the host. So this problem happens on every 127 + 128 created VM with 64 VCPUs. Cc: sta...@vger.kernel.org # v3.15+ Acked-by: Chr

Re: [PATCH v2 2/3] virtio_ring: Support DMA APIs

Am 28.10.2015 um 15:04 schrieb David Woodhouse: > On Wed, 2015-10-28 at 14:52 +0900, Christian Borntraeger wrote: >>0059b25a: e3201024 lg %r2,32(%r1) >> #0059b260: e310b0a4 lg %r1,160(%r11) >> >00

Re: [PATCH v3 0/3] virtio DMA API core stuff

Am 28.10.2015 um 16:17 schrieb Michael S. Tsirkin: > On Tue, Oct 27, 2015 at 11:38:57PM -0700, Andy Lutomirski wrote: >> This switches virtio to use the DMA API unconditionally. I'm sure >> it breaks things, but it seems to work on x86 using virtio-pci, with >> and without Xen, and using both the

Re: [PATCH/RFC 0/4] dma ops and virtio

Am 29.10.2015 um 07:22 schrieb Andy Lutomirski: > On Tue, Oct 27, 2015 at 3:48 PM, Christian Borntraeger > <borntrae...@de.ibm.com> wrote: >> This is an RFC to check if I am on the right track. There >> are some attempts to unify the dma ops (Christoph) as well >> a

[PATCH 1/4] Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/dma-mapping.h | 2 +

  1   2   3   4   5   6   7   8   9   10   >