Marcelo Tosatti wrote:
the cr3 variable is now inside the vcpu-arch structure.
Applied, thanks.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-
This SF.net email is sponsored by: Microsoft
Glauber de Oliveira Costa wrote:
I think this version addresses avi's last comments.
I'm not resending userspace since it is unchanged
Applied, thanks. Added structure packing for kvm_wall_clock.
--
Any sufficiently difficult bug is indistinguishable from a feature.
Zhang, Xiantao wrote:
From: Xiantao Zhang [EMAIL PROTECTED]
Date: Fri, 15 Feb 2008 10:50:22 +0800
Subject: [PATCH] qemu: IA64 also need to workaround tcg code.
Applied, thanks.
--
Any sufficiently difficult bug is indistinguishable from a feature.
Avi Kivity wrote:
Marcelo Tosatti wrote:
Hypercall based pte updates are faster than faults, and also allow use
of the lazy MMU mode to batch operations.
Don't report the feature if two dimensional paging is enabled.
Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED]
+/*
+ * We only need
Marcelo Tosatti wrote:
Issue is the paravirt_ops code in Linux does not cover all pte updates
(bit updates, ptep_get_and_clear, etc).
The plan is to get the basic infrastructure merged into KVM first (which
is a significant improvement already) and then later have paravirt_ops
cover all
Ryan Harper wrote:
I just tested the latest BOCHS from cvs, which includes the DMI/SMBIOS
patch from Filip, with qemu cvs HEAD, and kvm as well and the export DMI
tables are fully functional. Running dmidecide in the guest displays
all of the appropriate information. I was wondering what the
Andrew Morton wrote:
How important is this feature to KVM?
Very. kvm pins pages that are referenced by the guest; a 64-bit guest
will easily pin its entire memory with the kernel map. So this is
critical for guest swapping to actually work.
Other nice features like page migration are
Hollis Blanchard wrote:
On Wed, 2008-02-13 at 08:58 +0200, Avi Kivity wrote:
It'll need to be built against your kernel tree; please provide a URL.
curl http://penguinppc.org/~hollisb/kvm/kvm-powerpc.mbox | git-am
Unfortunately I wasn't able to get an F8 ppc rescue cd ISO
Alexander Graf wrote:
While enabling gfxboot over vmx is very desirable, I'd like to avoid
guest-specific hacks. IMO the correct fix is to set a
non_vt_friendly
flag when switching from real mode to protected mode, then continue
emulation, re-computing the flag after every instruction.
Andrew Morton wrote:
Very. kvm pins pages that are referenced by the guest;
hm. Why does it do that?
It was deemed best not to allow the guest to write to a page that has
been swapped out and assigned to an unrelated host process.
One way to view the kvm shadow page tables
Hollis Blanchard wrote:
We're having a hard time tracking down a PowerPC bug that seems to be
related to KVM's signal handling (SIGALRM in particular), so we're
trying to understand the overall signal handling design.
It looks like the run sequence goes something like this:
1. qemu:
Glauber Costa wrote:
+static void kvm_write_wall_clock(struct kvm_vcpu *v, gpa_t wall_clock)
+{
+int version = 1;
+struct kvm_wall_clock wc;
+unsigned long flags;
+struct timespec wc_ts;
+
+local_irq_save(flags);
+kvm_get_msr(v, MSR_IA32_TIME_STAMP_COUNTER,
+
Joerg Roedel wrote:
While installing Windows XP 64 bit wants to access the DEBUGCTL and the last
branch record (LBR) MSRs. Don't allowing this in KVM causes the installation
to
crash. This patch allow the access to these MSRs and fixes the issue.
Applied, thanks.
--
Any sufficiently
Ryan Harper wrote:
I posted[1] a dmi patches a bit ago on qemu-devel for this. There was a
better solution that involved fixing up the BIOS bits (bochs and qemu).
That patch is available as well on qemu-devel. I've not see any
indication of when either bochs or qemu will pick up the DMI
Alexander Graf wrote:
I would really love to see this as well. Mac OS X is rather picky on
the DMI tables, so I'm pretty sure I'll be able to find some bugs in
the implementation when it's posted.
I also have several bios changes to include support for newer
hardware, which was required
Joerg Roedel wrote:
This patch set enables the virtualization of the last branch record in SVM if
this feature is supported by the hardware. To the previous post the fix for
the
XP 64 bit install crash has been removed from this series and was posted
seperatly to keep it small enough for
Alexander Graf wrote:
I do, yes. The patches are already lying around on the qemu ML but
have not received any comments or commits. If you have any idea how to
get them into qemu, please tell me. I'd love to see them included.
The only method that seems to work is to keep resending;
Joerg Roedel wrote:
This still has the same issue as the previous patchset: if the guest
enables some other bit
in MSR_IA32_DEBUCTLMSR, we silently ignore it. We should either pr_unimpl()
on such bits or
not handle them (ultimately injecting a #GP).
Thats not true.
Joerg Roedel wrote:
@@ -1224,6 +1261,15 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, unsigned
ecx, u64 data)
if (data != 0)
goto unhandled;
break;
+ case MSR_IA32_DEBUGCTLMSR:
+ svm-vmcb-save.dbgctl = data;
+
Glauber de Oliveira Costa wrote:
This is the host part of kvm clocksource implementation. As it does
not include clockevents, it is a fairly simple implementation. We
only have to register a per-vcpu area, and start writting to it periodically.
The area is binary compatible with xen, as we
Anders Melchiorsen wrote:
I am wondering about this commit,
http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commit;h=b4e392c21c4b98c1c13af353caa3d6e6bcb6b8af
which adds signals on tap I/O. It seems a bit half-done to me. For one
thing, it is mixing timers with I/O.
The signal
Marcelo Tosatti wrote:
+ /*
+* If its a largepage mapping, there could be a previous
+* pointer to a PTE page hanging there, which will falsely
+* set was_rmapped.
+*/
+ if (largepage)
+ was_rmapped = is_large_pte(*shadow_pte);
+
But that pte page
Hollis Blanchard wrote:
On Tue, 2008-02-12 at 12:45 +0200, Avi Kivity wrote:
Hollis Blanchard wrote:
Long term, one option is to try to define a new qemu target that
completely bypasses the code generation parts of qemu. Anthony did that
for x86 once, but there are at least a couple
Anthony Liguori wrote:
In the short term we'll have to fork a working userspace, since we're in
the middle of some other stuff (such as real guest IO, which I think is
pretty important :) .
Long term, one option is to try to define a new qemu target that
completely bypasses the code
Andrea Arcangeli wrote:
Hello,
this GETTER stuff looks a bit tricky... (we've just to cope with it).
Anyway this allows building again and perhaps there's something good
in the patch (not sure about the = 2.6.25 side that I didn't touch)
Signed-off-by: Andrea Arcangeli [EMAIL PROTECTED]
Hollis Blanchard wrote:
Hi Avi, we're having a problem with the qemu merge you just did in
kvm-userspace.
Upstream qemu recently added the TCG code generator to phase out dyngen.
When he did that, Fabrice explicitly broke the build every non-x86
architecture, and since you've now pulled that
Marcelo Tosatti wrote:
Ok, how does the following look. Still need to plug in large page
creation in the nonpaging case, but this should be enough for comments.
Most of the comments are cosmetic, but a couple have some meat.
+#define HPAGE_ALIGN_OFFSET(x)
Joerg Roedel wrote:
Injecting an GP when accessing this MSR lets Windows crash when running some
stress test tools in KVM. So this patch emulates access to this MSR.
Applied, thanks.
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index dee6bce..817cad0 100644
---
Ryan Harper wrote:
Looking at Intel Volume 3b, page 148, table 20-11 and noticed
that the field name is 'Deliver' not 'Deliever'. Attached patch changes
the define name and its user in vmx.c
Applied, thanks.
--
error compiling committee.c: too many arguments to function
Jerone Young wrote:
So the recent code in qemu cvs has problem powerpc. So what I have done
is mainly work around this in the build system, by creating
ppcemb_kvm-sofmmu target. Along with this is a fake-exec.c that stubs
out the functions that are no longer defined (something done by Anthony
Andrea Arcangeli wrote:
On Thu, Jan 31, 2008 at 01:58:42PM +0100, Andrea Arcangeli wrote:
It might also be something stale in the buildsystem (perhaps a distcc
of ccache glitch?), I also cleared 1G of ccache just to be sure in
My build problem might have been related to the fact the
[EMAIL PROTECTED] wrote:
Hi,
Thanks for the speedy reply. I looked in all of the places you
mentioned, but no file. Are the major/minor numbers static. If so,
where can I find them?
http://www.lanana.org/docs/device-list/devices-2.6+.txt (char major 10,
minor 232)
--
error compiling
Guillaume Thouvenin wrote:
As using the emulator is likely to be slower than VT, we can call the
emulator only if we are in a VT unfriendly state, so the code might
look like
if (vmx-rmode.active big_real_mode(vmx))
...
In addition, there are some
Andrea Arcangeli wrote:
I created a more complete patch below, this will solve all my silent
time-wasting miscompilations (currnently when building kvm.git on a
newer mainline kernels, certain kvm*.h $KERNELDIR headers are included
instead of my modified ones in $LINUX, so the build can crash
Michael Tokarev wrote:
I first tried 64bit HOST kernel and 32bit host userspace. It didn't matter
what to use as guest - it doesn't even try to boot.
Okay. Fixed that bit for kvm-61.
--
error compiling committee.c: too many arguments to function
Anthony Liguori wrote:
So the new ioctl() has the extra data and the old ioctl() is just a
compat interface which calls the new ioctl with a NULL extra data. I
think this is the better approach if you're going this route.
However, I still don't think that supporting asymmetric cores is
Andrea Arcangeli wrote:
On Mon, Feb 04, 2008 at 04:01:31PM -0500, Chris Lalancette wrote:
Hello,
The merge with upstream changeset:
af5ca3f4ec5cc4432a42a73b050dd8898ce8fd00
broke building an external module against 2.6.23:
CC [M] /root/kvm-userspace/kernel/kvm_main.o
Paul Knowles wrote:
Whilst working on getting a VM to initialize in to IA32e mode I found
this issue. set_cr0 relies on comparing the old cr0 to the new one to
work correctly.
Applied, thanks. I moved the assignment below rather than deleting it
to be a little more conservative
Andrea Arcangeli wrote:
Hello,
there's a small glitch in the preempt notifier external module
emulation. The overloaded debug handler will not detect when a debug
exception has been generated by ptrace and it'll crash the host by
calling the preempt emulator like if this was a KVM preempt
Avi Kivity wrote:
Thanks, applied that. I added an include-compat/asm symlink so that
it builds.
Actually I applied the second version you sent.
--
error compiling committee.c: too many arguments to function
Joerg Roedel wrote:
On Sun, Jan 27, 2008 at 10:57:07AM +0200, Avi Kivity wrote:
Very nice patchset; small, simple, and clean. Apart from the comments
I already posted, I'd like to avoid the term 'hap': I find it
non-descriptive, and it reminds me of another hypervisor. I suggest
'tlp
Izik Eidus wrote:
Index: qemu/cpu-all.h
===
--- qemu.orig/cpu-all.h 2008-02-01 15:24:45.0 -0600
+++ qemu/cpu-all.h 2008-02-01 15:28:48.0 -0600
@@ -695,7 +695,7 @@
/* page related stuff */
-#define
Hollis Blanchard wrote:
On Mon, 2008-01-28 at 23:38 -0600, Jerone Young wrote:
A patch I submitted yesterday to use the call qemu_kvm_cpu_env() in
the dcr handles is not needed since in kvm_arch_post_kvm_run variable
cpu_single_env is set to env. So just use cpu_single_env to get env.
Jerone Young wrote:
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED]
# Date 1201818508 21600
# Node ID 739668b2f1913a381899d82912517a6568b6f30c
# Parent 5b553559aa641bf36b190541f775396ecdbf0e78
Update Copyrights on PowerPC KVM Qemu code.
I missed a copyright that needed to be in
Michael Tokarev wrote:
Ok, I finally got it working.
The problem was 32/64 bits issue. I'm so used to 64bits kernel and 32bits
userland - not a single thought occured to me that this might be problematic
of some sort. I was always trying 32bits kvm usermode tools with 64bits
kernels. Now
Bob Tennent wrote:
I'm experimenting with kvm on a Fedora 8 system. I've installed the
necessary packages, have a suitable CPU etc. I'll eventually aim for
a Windows guest, but am trying out a virtual Fedora 8 guest. When I
try to install a Fedora guest, it threatens to wipe and re-partition
Anthony Liguori wrote:
So what we would like to do, is instead of setting up vm86 mode for the
guest to execute real mode, use x86_emulate() to just emulate the code.
This means that we wouldn't be using the vmlaunch instruction when in
real mode and instead would be doing an x86_emulate()
Anthony Liguori wrote:
Avi Kivity wrote:
From: Avi Kivity [EMAIL PROTECTED]
Signed-off-by: Avi Kivity [EMAIL PROTECTED]
Can you also add one for qemu-kvm-x86.c?
Sure, added.
--
error compiling committee.c: too many arguments to function
Joerg Roedel wrote:
Hi,
here is the improved patchset which adds support for the Nested Paging
feature of the AMD Barcelona and Phenom processors to KVM. The patch set
was successfully install- and runtime-tested with various guest
operating systems (64 bit, 32 bit legacy and 32 bit PAE
Paul Brook wrote:
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
It fixes TARGET_PAGE_MASK, defined one line downscreen.
Paul Brook wrote:
On Sunday 10 February 2008, Avi Kivity wrote:
Paul Brook wrote:
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
Amit Shah wrote:
On Sunday 10 February 2008 17:01:46 Avi Kivity wrote:
Michael Tokarev wrote:
Ok, I finally got it working.
The problem was 32/64 bits issue. I'm so used to 64bits kernel and
32bits userland - not a single thought occured to me that this might be
problematic
I will be offline for the entire week of Feb 2 - Feb 9. I will only be
reachable by specially trained St. Bernards.
Andrew, if kvm.git gives you undue trouble, please drop it and I'll sort
out the mess when I return.
--
Any sufficiently difficult bug is indistinguishable from a feature.
Anthony Liguori wrote:
Fabrice Bellard wrote:
Anthony Liguori wrote:
+/* above 4giga memory allocation */
+if (above_4g_mem_size 0) {
+ram_addr = qemu_ram_alloc(above_4g_mem_size);
+cpu_register_physical_memory(0x1,
above_4g_mem_size, ram_addr);
+}
+
Zhang, Xiantao wrote:
Avi Kivity wrote:
Zhang, Xiantao wrote:
+#define TO_LEGACY_IO(addr) (((addr0x3ff) 12 2)|((addr)
0x3))
Please change to a function. Other than that, patch looks good.
Thanks ! Attached. :)
Xiantao
From: Zhang Xiantao [EMAIL
Carlo Marcelo Arenas Belon wrote:
[I forgot to reply to the this:]
--- kvm-60/user/test/x86/access.c
+++ kvm-60/user/test/x86/access.c 2008/01/24 15:14:16
@@ -1,6 +1,7 @@
#include smp.h
#include printf.h
+#include string.h
#define true 1
#define false 0
@@ -569,7 +570,7 @@
Andrea Arcangeli wrote:
On Thu, Jan 31, 2008 at 08:50:01AM +0200, Avi Kivity wrote:
This is surprising. pagefault_disable() is really a preempt_disable(), and
kvm_read_guest_atomic() should only be called from atomic contexts (with
preemption already disabled), no?
_spin_lock
Carlo Marcelo Arenas Belon wrote:
On Thu, Jan 24, 2008 at 06:21:56PM +0200, Avi Kivity wrote:
Bernhard Kaindl wrote:
I did not test this patch as I did not find documentation on how to run the
test cases and I could not find a make target to run them from make.
make
Chris Lalancette wrote:
All,
Attached is a patch that fixes the first (of at least a couple) migration
problem that I am running into. Basically, using the setup I described in my
last post, I was always getting Disabling IRQ #11 once the guest reached the
destination side, and then no
Gerd Hoffmann wrote:
Gerd Hoffmann wrote:
I've passed in a physical address. The vmx_cr3_cache_msr() function has
a gva_to_page() call which makes me suspect it expects a virtual
address.
Confirmed. When passing in a virtual address it works.
And it gives me a nice speedup for
Avi Kivity wrote:
Anthony Liguori wrote:
This patch attempts to clean up the interactions between KVM and QEMU. Sorry
for such a big patch, but I don't think there's a better way to approach this
such that it's still bisect friendly. I think this is most of what's needed
to
get basic
Carlo Marcelo Arenas Belon wrote:
prevents reusing tmp.bin for both BIOS-bochs-legacy and BIOS-bochs-latest
targets.
committed upstream in revision 1.27 of Makefile.in to fix bug 1799877.
patch applied as well to generated Makefile.
Applied, thanks.
--
error compiling committee.c: too
Balaji Rao wrote:
Hello,
I was trying to enable the use of nmi watchdog within a linux guest running
in kvm. I have done it
by allowing direct access to perfmon msrs using the MSR_BITMAP field in vmcs
region.
Most of the times the NMI Watchdog Test in the guest fails, but with a finite
Joerg Roedel wrote:
To allow access to the EFER register in 32bit KVM the EFER specific code has
to
be exported to the x86 generic code. This patch does this in a backwards
compatible manner.
Signed-off-by: Joerg Roedel [EMAIL PROTECTED]
---
arch/x86/kvm/vmx.c | 10 ++
1 files
Joerg Roedel wrote:
This patch makes the EFER register accessible on a 32bit KVM host. This is
necessary to boot 32 bit PAE guests under SVM.
static void set_efer(struct kvm_vcpu *vcpu, u64 efer)
{
if (efer EFER_RESERVED_BITS) {
@@ -432,12 +430,19 @@ static void
Jerone Young wrote:
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED]
# Date 1201568508 21600
# Node ID a568d031723942e1baf77077031d2b77795cbd8a
# Parent 5ce532cf9a1f711d1fecb42814d301abd37aa378
Cleanup extern declerations for now removed vcpu_env in Qemu
This patch removes
Anthony Liguori wrote:
This removes an unnecessary include of linux/kvm.h which happens to silence
a warning introduced by my previous patch :-) We have to move the ABI check
too until we've included libkvm.h.
Doesn't apply, please check.
--
error compiling committee.c: too many
Balaji Rao wrote:
On Wednesday 30 January 2008 04:13:58 pm Avi Kivity wrote:
@@ -790,6 +795,18 @@ static int apic_mmio_range(struct kvm_io_device
*this, gpa_t addr) return ret;
}
+static int nmi_notify(struct notifier_block *self,unsigned long val,
void *data) { +
+struct kvm
Carsten Otte wrote:
We have similar restrictions than you're naming here. Our guest may
start at a (userspace-) page boundary, and has a fixed 1:1 mapping to
userspace for a given length. We do that by just having one memory
slot which has to start at virtual address zero in kvm.
I thought
Balaji Rao wrote:
On Wednesday 30 January 2008 08:09:32 pm Avi Kivity wrote:
I intended to do this here. Looks like its not the right way to check for
presence in vcpu context. How do i do it ? please explain.
+static void vmx_inject_nmi(struct kvm_vcpu *vcpu) {
+
+ struct
Chris Lalancette wrote:
Avi Kivity wrote:
Excellent catch, but the fix is wrong. Instead of partially restoring
the ioapic state in the kernel, you should fully save it in qemu.
This is a trap that many fall into: considering kvm and qemu as one
entity and making sure they work well
userspace memory for older userspace
KVM: Fix gfn_to_page() acquiring mmap_sem twice
Avi Kivity (91):
KVM: VMX: Further reduce efer reloads
KVM: Allow not-present guest page faults to bypass kvm
KVM: MMU: Make flooding detection work when guest page faults are bypassed
KVM
Markus Armbruster wrote:
System-wide profiling of the *virtual* machine is related to profiling
just a process. That's hard. I guess building on Perfmon2 would make
sense there, but as long as it's out of tree... Can we wait for it?
If not, what then?
Give the guest access to the
Balaji Rao wrote:
On Wednesday 30 January 2008 11:11:51 pm Avi Kivity wrote:
Markus Armbruster wrote:
System-wide profiling of the *virtual* machine is related to profiling
just a process. That's hard. I guess building on Perfmon2 would make
sense there, but as long as it's out
Joerg Roedel wrote:
On Tue, Jan 29, 2008 at 07:20:12PM +0200, Avi Kivity wrote:
Here's a rough sketch of my proposal:
- For every memory slot, allocate an array containing one int for every
potential large page included within that memory slot. Each entry in
the array contains
Anders Melchiorsen wrote:
Hi Avi,
is it on purpose that this part of my qemu rearm rework was left out
when the rest was merged into KVM a few days ago? If there is still a
problem with it for KVM, I would like to know.
It was unintentional; a by product of the automatic merge. Thanks
Andrea Arcangeli wrote:
Ok, I think I found one first deadlock source during swapping with the
mmu notifiers and it's a KVM bug. I got a deadlock inversion between
PT lock and mmu_lock because of this bug. With PREEMPT=n it's not
enough to spin_lock(mmu_lock) to disable preempt and in turn the
Markus Armbruster wrote:
Avi Kivity [EMAIL PROTECTED] writes:
Markus Armbruster wrote:
System-wide profiling of the *virtual* machine is related to profiling
just a process. That's hard. I guess building on Perfmon2 would make
sense there, but as long as it's out of tree... Can
Zhang, Xiantao wrote:
From: Zhang Xiantao [EMAIL PROTECTED]
Date: Thu, 31 Jan 2008 09:06:21 +0800
Subject: [PATCH] kvm: qemu: Covert the mmio address space to port io in
userspace.
IA64 also have no port io, but chipset is responsible for converting
some mmio to port io for keeping
Jeremy Fitzhardinge wrote:
Marcelo Tosatti wrote:
Forgot to copy you... Ideally all pte updates should be done via the
paravirt interface.
Hm, are you sure?
It has the advantage of not falsely triggering any unshadowing
heuristics, and of avoiding the lovely x86 emulator.
Chris Lalancette wrote:
Another version of the patch, done by changing the on-the-wire protocol
as Avi suggested. I've tested this with:
old - old - Migration works, but runs into the bug I'm trying to fix
old - new - Migration works, but runs into the bug I'm trying to fix
new - old -
Yang, Sheng wrote:
From db6524fb36bbf1f297ae171f18de382c32ed6840 Mon Sep 17 00:00:00 2001
From: Sheng Yang [EMAIL PROTECTED]
Date: Tue, 29 Jan 2008 08:17:57 +0800
Subject: [PATCH] KVM: VMX: Fix invalid opcode of VPID
Add the missing memory in VPID clobber list, otherwise it would cause
Hollis Blanchard wrote:
This allows kvm_host.h to be #included even when struct preempt_notifier is
undefined. This is needed to build asm-offsets.h.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
Carsten Otte wrote:
#include linux/kvm.h
@@ -118,6 +119,7 @@ struct kvm {
struct kvm_io_bus pio_bus;
struct kvm_vm_stat stat;
struct kvm_arch arch;
+struct mmu_notifier mmu_notifier;
};
/* The guest did something we don't support. */
This should not be in
Andrea Arcangeli wrote:
Didn't realize s390 doesn't need those at all. Do you think
mmu_notifier.h should also go in asm/mmu_notifier? We can always move
them there later after merging with some compat code if needed.
s390 is the odd bird, not x86, so I'd like a solution that doesn't
Carsten Otte wrote:
Avi Kivity wrote:
Every arch except s390 needs it. An ugly #ifndef
CONFIG_KVM_HARDWARE_TLB_SYNC is preferred to duplicating the code.
BTW, from reading AMDs spec I don't expect NPT to need this vehicle
for swapping either. They can just let core-vm page out guest pages
Andrea Arcangeli wrote:
On Tue, Jan 29, 2008 at 05:35:34PM +0100, Carsten Otte wrote:
Avi Kivity wrote:
Every arch except s390 needs it. An ugly #ifndef
CONFIG_KVM_HARDWARE_TLB_SYNC is preferred to duplicating the code.
BTW, from reading AMDs spec I don't expect NPT
Andrea Arcangeli wrote:
duplication for x86, ppc, and ia64.
There is a few lines of duplication yes, the bulk of the code was
already only in x86.c and it has to stay there. It's only the few
lines of registration we're talking about it, so I don't think the
#ifdef would save enough.
The npt patches started me thinking on large page support (2MB/4MB
pages), and I think we can implement them even when npt/ept are not
available.
Here's a rough sketch of my proposal:
- For every memory slot, allocate an array containing one int for every
potential large page included within
Anthony Liguori wrote:
Avi Kivity wrote:
Anthony Liguori wrote:
PCI-e has a common reset concept (warm and cold). I've been looking
around and I can't seem to find any common reset mechanism for PCI.
Is FLR something that is per-device or a standard PCI mechanism? If
it's the former
Joerg Roedel wrote:
Explicitly enable the NM intercept in svm_set_cr0 if we enable TS in the guest
copy of CR0 for lazy FPU switching. This fixes guest SMP with Linux under SVM.
Without that patch Linux deadlocks or panics right after trying to boot the
other CPUs.
Applied, thanks.
--
Christoph Lameter wrote:
On Tue, 29 Jan 2008, Andrea Arcangeli wrote:
+ struct mmu_notifier_head mmu_notifier; /* MMU notifier list */
};
Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a
regression (a minor one though).
Andrew does not like #ifdefs
Anthony Liguori wrote:
This ABI breakage is worrying. While it is expected to take some
time for the ABI to congeal, we need some way to prevent mismatched
guests and hosts from running. Perhaps something like the kvm abi
version, storedin the pci revision field? Keep incrementing it
Jerone Young wrote:
This set of patches is to enable PowerPC embedded KVM capablities to be taken
advantage of by qemu.
The code currently boots a ungziped uImage of the Linux kernel complied for
PowerPC 440 AMCC Bamboo evalution board. We have not fully tested userspace,
but fixes will
Jeremy Fitzhardinge wrote:
Avi Kivity wrote:
I find it non-descriptive, and it reminds me of another hypervisor.
I suggest 'tlp' for two-level paging.
That has its own ambiguity; without other context it reads like
two-level pagetable. Anyway, using the same term for the same
Yang, Sheng wrote:
From af5d9ee2a189c2f0998c5c46d1fcd25c5cb72f8c Mon Sep 17 00:00:00 2001
From: Sheng Yang [EMAIL PROTECTED]
Date: Mon, 28 Jan 2008 05:10:22 +0800
Subject: [PATCH] KVM: In-kernel PIT model
The patch moved PIT from userspace to kernel, and increase the timer accuracy
Yang, Sheng wrote:
+void kvm_create_pit(kvm_context_t kvm)
+{
+ int r;
+
+ if (!kvm-no_pit_creation) {
+ r = ioctl(kvm-fd, KVM_CHECK_EXTENSION, KVM_CAP_PIT);
+ if (r 0) {
+ r = ioctl(kvm-vm_fd, KVM_CREATE_PIT);
+ if
Yang, Sheng wrote:
Hi,
Here is the updated in-kernel PIT model. The main improvements are:
Looking good; apart from some very minor comments all that is missing is
save/restore support.
--
error compiling committee.c: too many arguments to function
Anthony Liguori wrote:
I'm worried about the ramp up to 2.6.25 causing confusion among users
as before that things will break left and right, if we don't provide
a tighter check.
Well, using the PCI revision ID isn't a bad idea. It wouldn't have
helped this last problem because that
Marcelo Tosatti wrote:
So the questions are, why the benefit is not similar (vm-exit's are now
way cheaper?) and is it worth to merge this given the results?
Yes, vmexits are now about 5 times faster compared to older kvm.
+
+/*
+ * Avoid the VM exit upon cr3 load by using the cached
801 - 900 of 3824 matches
Mail list logo
