Re: ledger.el 3.1 destroys syntax

2014-11-15 Thread Christophe Rhodes
[ sorry if you get this twice; I think I got my `reply' commands in a twist. ] Craig Earls ender...@gmail.com writes: OK, I have gotten all of these. I will look into handling block comments as blocks. Right now it only honors them as line when overlaying the highlight. Thank you! It's

Re: ledger.el 3.1 destroys syntax

2014-11-15 Thread Craig Earls
I will look into these. M-p and M-n are really next and previous xact, not directive. But it should be consistent. On Sat, Nov 15, 2014 at 2:37 PM, Christophe Rhodes cs...@cantab.net wrote: [ sorry if you get this twice; I think I got my `reply' commands in a twist. ] Craig Earls

Re: ledger.el 3.1 destroys syntax

2014-11-15 Thread Craig Earls
The navigation issues are fixed. Fixing the highlighting of partial entries will take more thought. On Sat, Nov 15, 2014 at 9:17 PM, Craig Earls ender...@gmail.com wrote: I will look into these. M-p and M-n are really next and previous xact, not directive. But it should be consistent. On

Re: ledger.el 3.1 destroys syntax

2014-11-09 Thread Christophe Rhodes
Craig Earls ender...@gmail.com writes: I think I have figured out what is going on here. I pushed a fix to the entity boundary detection code and fixes all of Christoper's issue with his example file. Thank you! Things are certainly much, much better. I still see some more minor problems,

Re: ledger.el 3.1 destroys syntax

2014-11-09 Thread Craig Earls
OK, I have gotten all of these. I will look into handling block comments as blocks. Right now it only honors them as line when overlaying the highlight. On Sun, Nov 9, 2014 at 2:12 AM, Christophe Rhodes cs...@cantab.net wrote: Craig Earls ender...@gmail.com writes: I think I have figured out

Re: ledger.el 3.1 destroys syntax

2014-11-07 Thread Craig Earls
I think I have figured out what is going on here. I pushed a fix to the entity boundary detection code and fixes all of Christoper's issue with his example file. On Tue, Nov 4, 2014 at 3:25 PM, Craig Earls ender...@gmail.com wrote: I would be fine with rolling it back to previous version and I

Re: ledger.el 3.1 destroys syntax

2014-11-04 Thread Paul W. Rankin
p.s. Rolling back to v3.0.3 fixes all fontifaction problems. Obviously finding a middle-ground between there and v3.1 would be the better outcome. -- Paul W. Rankin http://www.paulwrankin.com -- --- You received this message because you are subscribed to the Google Groups Ledger group. To

Re: ledger.el 3.1 destroys syntax

2014-11-04 Thread John Wiegley
Paul W Rankin he...@paulwrankin.com writes: p.s. Rolling back to v3.0.3 fixes all fontifaction problems. Obviously finding a middle-ground between there and v3.1 would be the better outcome. This is somewhat concerning. Craig, perhaps we should make both schemes available, in case users have

Re: ledger.el 3.1 destroys syntax

2014-11-04 Thread Craig Earls
I would be fine with rolling it back to previous version and I can continue to work with it. I just don't have any time to spare this week. Could you roll it back? On Tuesday, November 4, 2014, John Wiegley jo...@newartisans.com wrote: Paul W Rankin he...@paulwrankin.com javascript:; writes:

Re: ledger.el 3.1 destroys syntax

2014-11-04 Thread John Wiegley
Craig Earls ender...@gmail.com writes: I would be fine with rolling it back to previous version and I can continue to work with it. I just don't have any time to spare this week. Could you roll it back? Is the work confined to a single commit? I don't want to rollback too much. John --

Re: ledger.el 3.1 destroys syntax

2014-11-03 Thread Paul W. Rankin
Craig Earls ender...@gmail.com writes: I don't have time right now to back out the change, if someone else can back it out, feel free. As I said, it works for me very well. Without a test file I cannot troubleshoot your problems. I received many requests for highlighting the entire

Re: ledger.el 3.1 destroys syntax

2014-11-02 Thread Christophe Rhodes
Christophe Rhodes cs...@cantab.net writes: My report of 16th October included a ledger file that exhibits problems for me, along with a description of the problems. It can be found here: http://article.gmane.org/gmane.comp.finance.ledger.general/6829. Some observations, based on a little bit

Re: ledger.el 3.1 destroys syntax

2014-11-02 Thread Stefano Zacchiroli
On Sat, Nov 01, 2014 at 01:25:12PM +1000, Paul W. Rankin wrote: The problems are myriad, but I'll try to summarise: FWIW, I'm also experiencing several highlighting issues with ledger-mode 3.1. Some of them which I believe haven't yet been mentioned in this thread (for info: I'm using Emacs

Re: ledger.el 3.1 destroys syntax

2014-11-02 Thread David Glasser
I've been seeing these symptoms too, but haven't had the time to investigate or report. --dave On Nov 2, 2014 8:45 AM, Stefano Zacchiroli z...@upsilon.cc wrote: On Sat, Nov 01, 2014 at 01:25:12PM +1000, Paul W. Rankin wrote: The problems are myriad, but I'll try to summarise: FWIW, I'm also

Re: ledger.el 3.1 destroys syntax

2014-11-02 Thread Craig Earls
I will try to figure this out this week On Sunday, November 2, 2014, David Glasser glas...@davidglasser.net wrote: I've been seeing these symptoms too, but haven't had the time to investigate or report. --dave On Nov 2, 2014 8:45 AM, Stefano Zacchiroli z...@upsilon.cc wrote: On Sat, Nov

Re: ledger.el 3.1 destroys syntax

2014-11-02 Thread Paul W. Rankin
Craig Earls ender...@gmail.com writes: As I said, the fontification works very well for me. By way of history, there have been complaints about ledger fontification for longer than I have been using ledger. emacs font-lock-mode is very good at highlighting languages that do not have lots of

Re: ledger.el 3.1 destroys syntax

2014-11-02 Thread Craig Earls
I don't have time right now to back out the change, if someone else can back it out, feel free. As I said, it works for me very well. Without a test file I cannot troubleshoot your problems. I received many requests for highlighting the entire transaction based on the cleared status.

Re: ledger.el 3.1 destroys syntax

2014-11-01 Thread Eric Abrahamsen
Craig Earls ender...@gmail.com writes: I use it every day and don't see anything like this. What emacs are you using? Yeah, I'd definitely assume gremlins of some sort -- we'd have heard about it if things were really broken that bad as a general case. -- --- You received this message

Re: ledger.el 3.1 destroys syntax

2014-11-01 Thread Christophe Rhodes
Eric Abrahamsen e...@ericabrahamsen.net writes: Craig Earls ender...@gmail.com writes: I use it every day and don't see anything like this. What emacs are you using? Yeah, I'd definitely assume gremlins of some sort -- we'd have heard about it if things were really broken that bad as a

Re: ledger.el 3.1 destroys syntax

2014-11-01 Thread Craig Earls
Christopher, I apologize, I have been incredibly busy with work and family the last few weeks, ledger-mode maintenance is very low on my priority list. As I said, the fontification works very well for me. By way of history, there have been complaints about ledger fontification for longer than I

ledger.el 3.1 destroys syntax

2014-10-31 Thread Paul W. Rankin
Sorry to say, but the changes from 3.0 to 3.1 have utterly destroyed syntax highlighting in ledger.el. I've had a perusal of the commits on GitHub and it looks like there has been an attempt to switch away from Font Lock Mode. I gotta say, this development has not produced a stable version of