Re: [libav-devel] [PATCH 2/2] H.264: avoid redundant alpha/beta calculations in loopfilter

2011-07-10 Thread Ronald S. Bultje
Hi, On Sun, Jul 10, 2011 at 5:28 PM, Jason Garrett-Glaser wrote: > On Sun, Jul 10, 2011 at 4:59 PM, Ronald S. Bultje wrote: >> On Sun, Jul 10, 2011 at 2:46 AM, Jason Garrett-Glaser wrote: >>> --- >>>  libavcodec/h264_loopfilter.c |  243 >>> +- >>>  1 fil

Re: [libav-devel] [PATCH] vp8/mt: flush worker thread, not application thread context, on seek.

2011-07-10 Thread Alexander Strange
On Sun, Jul 10, 2011 at 9:23 PM, Ronald S. Bultje wrote: > This prevents a crash when seeking. OK. > --- >  libavcodec/pthread.c |    8 +--- >  libavcodec/utils.c   |    2 +- >  2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c > in

[libav-devel] [PATCH] vp8/mt: flush worker thread, not application thread context, on seek.

2011-07-10 Thread Ronald S. Bultje
This prevents a crash when seeking. --- libavcodec/pthread.c |8 +--- libavcodec/utils.c |2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c index bb8a343..7c5f8fd 100644 --- a/libavcodec/pthread.c +++ b/libavcodec/pthread

Re: [libav-devel] [PATCH] mt: proper locking around release_buffer calls.

2011-07-10 Thread Alexander Strange
On Sun, Jul 10, 2011 at 5:28 PM, Ronald S. Bultje wrote: > This fixes a crash when seeking in some webm files with many > threads (e.g. 8). OK, except there's a whitespace change. > --- >  libavcodec/pthread.c |    7 +-- >  1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/li

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Luca Barbato
On 7/10/11 1:29 PM, Kostya wrote: On Sun, Jul 10, 2011 at 01:10:47PM -0500, Luca Barbato wrote: On 7/10/11 11:13 AM, Ronald S. Bultje wrote: From: Anton Mitrofanov ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte aligned and thus at a different offset than intended. Using

Re: [libav-devel] [PATCH 2/2] H.264: avoid redundant alpha/beta calculations in loopfilter

2011-07-10 Thread Jason Garrett-Glaser
On Sun, Jul 10, 2011 at 4:59 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 10, 2011 at 2:46 AM, Jason Garrett-Glaser wrote: >> --- >>  libavcodec/h264_loopfilter.c |  243 >> +- >>  1 files changed, 122 insertions(+), 121 deletions(-) > > Is this faster

[libav-devel] [PATCH] mt: proper locking around release_buffer calls.

2011-07-10 Thread Ronald S. Bultje
This fixes a crash when seeking in some webm files with many threads (e.g. 8). --- libavcodec/pthread.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c index 08ef4ba..bb8a343 100644 --- a/libavcodec/pthread.c +++ b/libavcod

Re: [libav-devel] [PATCH 2/2] H.264: avoid redundant alpha/beta calculations in loopfilter

2011-07-10 Thread Ronald S. Bultje
Hi, On Sun, Jul 10, 2011 at 2:46 AM, Jason Garrett-Glaser wrote: > --- >  libavcodec/h264_loopfilter.c |  243 > +- >  1 files changed, 122 insertions(+), 121 deletions(-) Is this faster? Ronald ___ libav-devel

Re: [libav-devel] [PATCH 1/2] H.264: optimize intra/inter loopfilter decision

2011-07-10 Thread Ronald S. Bultje
Hi, actually, one nit-pick: On Sun, Jul 10, 2011 at 2:46 AM, Jason Garrett-Glaser wrote: > -#define FILTER(hv,dir,edge)\ > +#define FILTER(hv,dir,edge,i)\ >         if(AV_RN64A(bS[dir][edge])) {                                   \ > -            filter_mb_edge##hv( &img_y[4*edge*(dir?linesize:1)

Re: [libav-devel] [PATCH 1/2] H.264: optimize intra/inter loopfilter decision

2011-07-10 Thread Ronald S. Bultje
Hi, On Sun, Jul 10, 2011 at 2:46 AM, Jason Garrett-Glaser wrote: > --- >  libavcodec/h264_loopfilter.c |  233 > +- >  1 files changed, 117 insertions(+), 116 deletions(-) LGTM. Ronald ___ libav-devel mailing li

Re: [libav-devel] [PATCH] build: Do not link binaries against libpostproc.

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > On Sun, Jul 10, 2011 at 11:44:53PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > None of the compiled binaries use any of libpostproc's symbols except >> > for trivial ones that print version information. Thus the dependency >> > yields no benefit and it

Re: [libav-devel] [PATCH] xvmc: fix some leftover uses of struct Picture with FF_COMMON_FRAME

2011-07-10 Thread Ronald S. Bultje
Hi, On Sun, Jul 10, 2011 at 3:56 PM, Diego Biurrun wrote: > --- >  libavcodec/mpegvideo_xvmc.c |   14 +++--- >  1 files changed, 7 insertions(+), 7 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.

Re: [libav-devel] [PATCH] DxVA2: unbreak build after [657ccb5ac75ce34e62bd67f228d9bd36db72189e]

2011-07-10 Thread Ronald S. Bultje
Hi, On Sun, Jul 10, 2011 at 4:13 PM, Jean-Baptiste Kempf wrote: > --- >  libavcodec/dxva2.c       |    2 +- >  libavcodec/dxva2_h264.c  |   18 +- >  libavcodec/dxva2_mpeg2.c |    8 >  libavcodec/dxva2_vc1.c   |    8 >  4 files changed, 18 insertions(+), 18 deleti

[libav-devel] [PATCH] DxVA2: unbreak build after [657ccb5ac75ce34e62bd67f228d9bd36db72189e]

2011-07-10 Thread Jean-Baptiste Kempf
--- libavcodec/dxva2.c |2 +- libavcodec/dxva2_h264.c | 18 +- libavcodec/dxva2_mpeg2.c |8 libavcodec/dxva2_vc1.c |8 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c index 25b021a..e5

Re: [libav-devel] [PATCH] build: Do not link binaries against libpostproc.

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 11:44:53PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > None of the compiled binaries use any of libpostproc's symbols except > > for trivial ones that print version information. Thus the dependency > > yields no benefit and it is preferable to drop it. > > -

Re: [libav-devel] [PATCH] hwaccel: unbreak build

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 11:55:22PM +0100, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/mpegvideo_xvmc.c | 14 +++--- > libavcodec/vaapi_h264.c | 10 +- > libavcodec/vaapi_internal.h |2 +- > libavcodec/vaapi_mpeg4.c|2 +- > libavcodec/

[libav-devel] [PATCH] xvmc: fix some leftover uses of struct Picture with FF_COMMON_FRAME

2011-07-10 Thread Diego Biurrun
--- libavcodec/mpegvideo_xvmc.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegvideo_xvmc.c b/libavcodec/mpegvideo_xvmc.c index 29d8bbb..159fe21 100644 --- a/libavcodec/mpegvideo_xvmc.c +++ b/libavcodec/mpegvideo_xvmc.c @@ -41,7 +41,7 @@ */

[libav-devel] [PATCH] hwaccel: unbreak build

2011-07-10 Thread Mans Rullgard
Signed-off-by: Mans Rullgard --- libavcodec/mpegvideo_xvmc.c | 14 +++--- libavcodec/vaapi_h264.c | 10 +- libavcodec/vaapi_internal.h |2 +- libavcodec/vaapi_mpeg4.c|2 +- libavcodec/vdpau.c | 40 5 files cha

Re: [libav-devel] [PATCH] build: Do not link binaries against libpostproc.

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > None of the compiled binaries use any of libpostproc's symbols except > for trivial ones that print version information. Thus the dependency > yields no benefit and it is preferable to drop it. > --- > Makefile |6 -- > cmdutils.c |2 -- > 2 files changed,

[libav-devel] [PATCH] build: Do not link binaries against libpostproc.

2011-07-10 Thread Diego Biurrun
None of the compiled binaries use any of libpostproc's symbols except for trivial ones that print version information. Thus the dependency yields no benefit and it is preferable to drop it. --- Makefile |6 -- cmdutils.c |2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [libav-devel] [PATCH 1/2] build: use generic build rules for FATE programs

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > --- > Makefile |3 ++- > libavfilter/Makefile |3 ++- > libavformat/Makefile |1 + > subdir.mak |4 ++-- > tests/Makefile |3 --- > 5 files changed, 7 insertions(+), 7 deletions(-) An alternative to this would be moving see

Re: [libav-devel] [PATCH 2/2] Move lavfi-showfiltfmts.c to the tests/ subdirectory.

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > The file is part of the FATE suite, so it belongs there. It could conceivably be useful outside of fate too. I suppose that was the idea behind putting it in tools/ in the first place. -- Måns Rullgård m...@mansr.com ___ liba

[libav-devel] [PATCH 2/2] Move lavfi-showfiltfmts.c to the tests/ subdirectory.

2011-07-10 Thread Diego Biurrun
The file is part of the FATE suite, so it belongs there. --- .gitignore |2 +- tests/Makefile |2 +- tests/lavfi-regression.sh |2 +- tests/lavfi-showfiltfmts.c | 99 tools/lavfi-showfiltfmts.c | 99 -

[libav-devel] [PATCH 1/2] build: use generic build rules for FATE programs

2011-07-10 Thread Diego Biurrun
--- Makefile |3 ++- libavfilter/Makefile |3 ++- libavformat/Makefile |1 + subdir.mak |4 ++-- tests/Makefile |3 --- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 2518d61..7ae6763 100644 --- a/Makefile ++

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
Hi, 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: > >> Hi, >> >> 2011/7/10 Måns Rullgård : >>> "Ronald S. Bultje" writes: >>> From: Anton Mitrofanov ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte aligned and thus at a different offset than in

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > 2011/7/10 Måns Rullgård : >> "Ronald S. Bultje" writes: >> >>> From: Anton Mitrofanov >>> >>> ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte >>> aligned and thus at a different offset than intended. Forcing 8-byte >>> alignment forces

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
Hi, 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: > >> From: Anton Mitrofanov >> >> ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte >> aligned and thus at a different offset than intended. Forcing 8-byte >> alignment forces equal offset of dither16/32 on x86-32 an

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: Anton Mitrofanov > > ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte > aligned and thus at a different offset than intended. Forcing 8-byte > alignment forces equal offset of dither16/32 on x86-32 and x86-64. > > Signed-off-by: Ronald S.

[libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
From: Anton Mitrofanov ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte aligned and thus at a different offset than intended. Forcing 8-byte alignment forces equal offset of dither16/32 on x86-32 and x86-64. Signed-off-by: Ronald S. Bultje --- libswscale/swscale_internal.

Re: [libav-devel] [PATCH] matroskadec: fix stupid typo (!= -> ==)

2011-07-10 Thread Måns Rullgård
Anton Khirnov writes: > --- > libavformat/matroskadec.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index e1e555d..70bb765 100644 > --- a/libavformat/matroskadec.c > +++ b/libavformat/matroskadec.c > @@ -1

Re: [libav-devel] [FFmpeg-devel] ESA Summer of Code in Space 2011

2011-07-10 Thread Stefano Sabatini
On date Saturday 2011-07-09 21:26:25 +0200, Stefano Sabatini encoded: [...] > |Communication is a key aspect in space programs, being able to > |communicate effectively and reliably, even in extreme conditions, is > |a fundamental prerequisite. > | > |FFmpeg/Libav is highly focused on providing the

Re: [libav-devel] [PATCH] build: rework rules for things in the tools dir

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 08:26:41PM +0100, Mans Rullgard wrote: > Declaring tools associated with each library in their respective > makefiles allows these tools to easily depend on the correct > prerequisites and link against the libs they need. Good work, thank you. Patch OK. > --- a/tests/Make

[libav-devel] [PATCH] matroskadec: fix stupid typo (!= -> ==)

2011-07-10 Thread Anton Khirnov
--- libavformat/matroskadec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index e1e555d..70bb765 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -1200,7 +1200,7 @@ static void matroska_par

[libav-devel] [PATCH] build: rework rules for things in the tools dir

2011-07-10 Thread Mans Rullgard
Declaring tools associated with each library in their respective makefiles allows these tools to easily depend on the correct prerequisites and link against the libs they need. Signed-off-by: Mans Rullgard --- Makefile | 21 - common.mak |6 ++

Re: [libav-devel] [PATCH] build: remove duplicates from order-only directory prerequisite list

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > This reduces startup latency for make invocations, which is especially > noticeable on that are slow or have slow I/O, like Windows. ^ On what? > --- > common.mak |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/common.mak

[libav-devel] [PATCH] build: remove duplicates from order-only directory prerequisite list

2011-07-10 Thread Diego Biurrun
This reduces startup latency for make invocations, which is especially noticeable on that are slow or have slow I/O, like Windows. --- common.mak |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common.mak b/common.mak index bd21046..1a7c00a 100644 --- a/common.mak +++

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
We can al On Jul 10, 2011 9:28 AM, "Måns Rullgård" wrote: > > "Ronald S. Bultje" writes: > > > Hi, > > > > 2011/7/10 Måns Rullgård : > >> "Ronald S. Bultje" writes: > >>> 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: > > 2011/7/10 Måns Rullgård : > >> "Ronald S. Bultje" w

Re: [libav-devel] [PATCH] build: fix dependency file generation for binaries in the tools directory

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 07:29:43PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > --- a/Makefile > > +++ b/Makefile > > @@ -127,9 +127,7 @@ alltools: $(TOOLS) > > > > -$(TOOLOBJS): %.o: %.c | tools > > - $(CC) $(CPPFLAGS) $(CFLAGS) -c $(CC_O) $< > > - > > +$(TOOLOBJS): | tools > > OBJD

Re: [libav-devel] [PATCH] build: fix dependency file generation for binaries in the tools directory

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > --- > Makefile |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index a35d58e..6a6e9fb 100644 > --- a/Makefile > +++ b/Makefile > @@ -127,9 +127,7 @@ alltools: $(TOOLS) > tools/%$(EXESUF): tools/%.o > $(LD) $(FF

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Kostya
On Sun, Jul 10, 2011 at 01:10:47PM -0500, Luca Barbato wrote: > On 7/10/11 11:13 AM, Ronald S. Bultje wrote: > >From: Anton Mitrofanov > > > >ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte > >aligned and thus at a different offset than intended. Using a fixed 8-byte > >eleme

Re: [libav-devel] [PATCH] build: fix dependencies for binaries in the tools directory

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > On Sun, Jul 10, 2011 at 05:18:38PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > On Sun, Jul 10, 2011 at 02:42:16AM +0100, Måns Rullgård wrote: >> >> Diego Biurrun writes: >> >> >> >> > On Fri, Jul 08, 2011 at 06:15:29PM +0100, Måns Rullgård wrote: >> >>

Re: [libav-devel] [PATCH] build: fix dependencies for binaries in the tools directory

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 05:18:38PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > On Sun, Jul 10, 2011 at 02:42:16AM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > >> > On Fri, Jul 08, 2011 at 06:15:29PM +0100, Måns Rullgård wrote: > >> >> Diego Biurrun writes: > >> >

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Luca Barbato
On 7/10/11 11:13 AM, Ronald S. Bultje wrote: From: Anton Mitrofanov ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte aligned and thus at a different offset than intended. Using a fixed 8-byte element for uv_off_px/byte fixes that. Would be possible remove the dithering fo

Re: [libav-devel] The exact meaning/definition of PIX_FMT_PAL (and is it necessary to keep this flag?)

2011-07-10 Thread Måns Rullgård
Fredrik Mellbin writes: > I was talking to BBB about adding colorspace flags to > AVPixFmtDescriptor and how to do it. While doing this we tried to > figure out the exact meaning of the PIX_FMT_PAL flag that already > exists, however we failed to come up with an explanation. > > Currently it just

Re: [libav-devel] [libav-commits] matroskadec: defer parsing of cues element until we seek.

2011-07-10 Thread Måns Rullgård
"Aaron Colwell " writes: > Module: libav > Branch: master > Commit: 31ad14c21e0735387ba8082c6e3436241f7ccfc8 > > Author:Aaron Colwell > Committer: Anton Khirnov > Date: Sat Jul 9 07:48:43 2011 +0200 > > matroskadec: defer parsing of cues element until we seek. > > This decreases start

[libav-devel] The exact meaning/definition of PIX_FMT_PAL (and is it necessary to keep this flag?)

2011-07-10 Thread Fredrik Mellbin
I was talking to BBB about adding colorspace flags to AVPixFmtDescriptor and how to do it. While doing this we tried to figure out the exact meaning of the PIX_FMT_PAL flag that already exists, however we failed to come up with an explanation. Currently it just seems to be a property applied to al

[libav-devel] [PATCH 4/4] cmdutils: replace opt_default with opt_default2() and remove set_context_opts

2011-07-10 Thread Anton Khirnov
--- cmdutils.c | 108 +--- cmdutils.h |3 -- 2 files changed, 1 insertions(+), 110 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 18cc02b..330d33e 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -49,9 +49,6 @@ #include #endif

[libav-devel] [PATCH 2/4] ffplay: use new avcodec_open2 and avformat_find_stream_info API.

2011-07-10 Thread Anton Khirnov
--- cmdutils.c | 17 + cmdutils.h |5 + ffplay.c | 38 ++ 3 files changed, 40 insertions(+), 20 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 74bcfaf..18cc02b 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -904,6 +904,23 @@

[libav-devel] [PATCH 3/4] ffmpeg: use new avcodec_open2 and avformat_find_stream_info API.

2011-07-10 Thread Anton Khirnov
--- ffmpeg.c | 46 +- 1 files changed, 21 insertions(+), 25 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 38bac0b..1f20b07 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -290,6 +290,7 @@ typedef struct OutputStream { #endif int sws_flags; + AV

[libav-devel] [PATCH 1/4] cmdutils: store all codec options in one dict instead of video/audio/sub

2011-07-10 Thread Anton Khirnov
Split them when codec id is known. --- cmdutils.c | 49 - cmdutils.h |7 ++- 2 files changed, 34 insertions(+), 22 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index bd64909..74bcfaf 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -55,7 +

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > 2011/7/10 Måns Rullgård : >> "Ronald S. Bultje" writes: >>> 2011/7/10 Måns Rullgård : "Ronald S. Bultje" writes: > 2011/7/10 Måns Rullgård : >> "Ronald S. Bultje" writes: >> >>> From: Anton Mitrofanov >>> >>> ptrdiff_t can be 4

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
Hi, 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: >> 2011/7/10 Måns Rullgård : >>> "Ronald S. Bultje" writes: 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: > >> From: Anton Mitrofanov >> >> ptrdiff_t can be 4 bytes, which leads to the next element bei

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > 2011/7/10 Måns Rullgård : >> "Ronald S. Bultje" writes: >>> 2011/7/10 Måns Rullgård : "Ronald S. Bultje" writes: > From: Anton Mitrofanov > > ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte > aligned and thus

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
Hi, 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: >> 2011/7/10 Måns Rullgård : >>> "Ronald S. Bultje" writes: >>> From: Anton Mitrofanov ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte aligned and thus at a different offset than intended. Usin

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > 2011/7/10 Måns Rullgård : >> "Ronald S. Bultje" writes: >> >>> From: Anton Mitrofanov >>> >>> ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte >>> aligned and thus at a different offset than intended. Using a fixed 8-byte >>> element fo

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
Hi, 2011/7/10 Måns Rullgård : > "Ronald S. Bultje" writes: > >> From: Anton Mitrofanov >> >> ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte >> aligned and thus at a different offset than intended. Using a fixed 8-byte >> element for uv_off_px/byte fixes that. >> >> Signed

Re: [libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: Anton Mitrofanov > > ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte > aligned and thus at a different offset than intended. Using a fixed 8-byte > element for uv_off_px/byte fixes that. > > Signed-off-by: Ronald S. Bultje > --- > libsw

Re: [libav-devel] [PATCH] build: fix dependencies for binaries in the tools directory

2011-07-10 Thread Måns Rullgård
Diego Biurrun writes: > On Sun, Jul 10, 2011 at 02:42:16AM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> >> > On Fri, Jul 08, 2011 at 06:15:29PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun writes: >> >> > >> >> > --- a/Makefile >> >> > +++ b/Makefile >> >> > @@ -124,11 +124,10 @@

[libav-devel] [PATCH] swscale: fix crash with dithering due incorrect offset calculation.

2011-07-10 Thread Ronald S. Bultje
From: Anton Mitrofanov ptrdiff_t can be 4 bytes, which leads to the next element being 4-byte aligned and thus at a different offset than intended. Using a fixed 8-byte element for uv_off_px/byte fixes that. Signed-off-by: Ronald S. Bultje --- libswscale/swscale_internal.h |4 ++-- 1 files

Re: [libav-devel] [PATCH] build: fix dependencies for binaries in the tools directory

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 02:42:16AM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > On Fri, Jul 08, 2011 at 06:15:29PM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > > >> > --- a/Makefile > >> > +++ b/Makefile > >> > @@ -124,11 +124,10 @@ TOOLS:= $(TOOLS:%=tools/%$(EX

Re: [libav-devel] [PATCH] configure: fix --cpu=host with gcc 4.6

2011-07-10 Thread Diego Biurrun
On Sun, Jul 10, 2011 at 04:18:02PM +0100, Mans Rullgard wrote: > The output from -v with gcc 4.6 has changed such that the search > pattern matches too soon without making it more strict. OK Diego ___ libav-devel mailing list libav-devel@libav.org https

Re: [libav-devel] [PATCH] segafilm: add support for videos with cri adx adpcm

2011-07-10 Thread Mike Melanson
On 7/9/2011 6:27 PM, Ronald S. Bultje wrote: Fate-suite admins, should I add md5sum files for each? I didn't see them in h264/, but did see it in h264-conformance/ and film/. The md5sums are an artifact of Attila's mphq-- there was some script that automatically generated them all over the sam

[libav-devel] [PATCH] configure: fix --cpu=host with gcc 4.6

2011-07-10 Thread Mans Rullgard
The output from -v with gcc 4.6 has changed such that the search pattern matches too soon without making it more strict. Signed-off-by: Mans Rullgard --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index f5b4a5c..02bcd09 100755 --- a/

Re: [libav-devel] [libav-commits] build: create output directories as needed

2011-07-10 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Wed, Jun 29, 2011 at 1:15 AM, Mans Rullgard wrote: >> Module: libav >> Branch: master >> Commit: 5e27ec28f0aa263fc6af60ea88677e2c40631920 >> >> Author:    Mans Rullgard >> Committer: Mans Rullgard >> Date:      Tue Jun 28 18:45:13 2011 +0100 >> >> build:

Re: [libav-devel] [libav-commits] build: create output directories as needed

2011-07-10 Thread Ronald S. Bultje
Hi, On Wed, Jun 29, 2011 at 1:15 AM, Mans Rullgard wrote: > Module: libav > Branch: master > Commit: 5e27ec28f0aa263fc6af60ea88677e2c40631920 > > Author:    Mans Rullgard > Committer: Mans Rullgard > Date:      Tue Jun 28 18:45:13 2011 +0100 > > build: create output directories as needed > > Si

Re: [libav-devel] [PATCH] build: unify/sort directory lists which OBJS/HOSTOBJS/TESTOBJS depend on

2011-07-10 Thread Måns Rullgård
golgol writes: > Hi. > > This patch fixes the problem that ’make’ may almost get stuck for long time > before actual compiling starts. > > From 4fe4c8f8ce2b915fbc2529d4ee3a279ee4c25f89 Mon Sep 17 00:00:00 2001 > From: golgol > Date: Sun, 10 Jul 2011 16:23:01 +0900 > Subject: [PATCH] build: u

[libav-devel] [PATCH] build: unify/sort directory lists which OBJS/HOSTOBJS/TESTOBJS depend on

2011-07-10 Thread golgol
Hi. This patch fixes the problem that ’make’ may almost get stuck for long time before actual compiling starts. 0001-build-unify-sort-directory-lists-which-OBJS-HOSTOBJS.patch Description: Binary data ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 2/2] H.264: avoid redundant alpha/beta calculations in loopfilter

2011-07-10 Thread Jason Garrett-Glaser
--- libavcodec/h264_loopfilter.c | 243 +- 1 files changed, 122 insertions(+), 121 deletions(-) diff --git a/libavcodec/h264_loopfilter.c b/libavcodec/h264_loopfilter.c index 350c619..15731b9 100644 --- a/libavcodec/h264_loopfilter.c +++ b/libavcodec/h264_

[libav-devel] [PATCH 1/2] H.264: optimize intra/inter loopfilter decision

2011-07-10 Thread Jason Garrett-Glaser
--- libavcodec/h264_loopfilter.c | 233 +- 1 files changed, 117 insertions(+), 116 deletions(-) diff --git a/libavcodec/h264_loopfilter.c b/libavcodec/h264_loopfilter.c index 6eba8dc..350c619 100644 --- a/libavcodec/h264_loopfilter.c +++ b/libavcodec/h264_