Re: [libav-devel] [PATCH] rtsp: Don't use a locale dependent format string

2011-03-23 Thread Ronald S. Bultje
Hi, On Wed, Mar 23, 2011 at 5:36 AM, Luca Barbato lu_z...@gentoo.org wrote: On 03/23/2011 09:26 AM, Martin Storsjö wrote: In this particular case, we aren't ever printing anything else than 0.000 anyway. Patch ok =) Queued. Ronald ___ libav-devel

Re: [libav-devel] [PATCH] matroskaenc: remove a variable that's unused after bc17bd9.

2011-03-23 Thread Ronald S. Bultje
Hi, On Wed, Mar 23, 2011 at 6:24 AM, Kostya kostya.shish...@gmail.com wrote: On Wed, Mar 23, 2011 at 11:09:34AM +0100, Anton Khirnov wrote: ---  libavformat/matroskaenc.c |    1 -  1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/libavformat/matroskaenc.c

[libav-devel] [PATCH] mpeg12.c: disable threading for mpeg2 field picture mode.

2011-03-23 Thread Ronald S. Bultje
Fixes make THREADS=2 fate-mpeg2-field-enc. --- libavcodec/mpeg12.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index c60826b..b77688c 100644 --- a/libavcodec/mpeg12.c +++ b/libavcodec/mpeg12.c @@ -2359,6 +2359,7 @@ static int

Re: [libav-devel] [PATCH] mpeg12.c: disable threading for mpeg2 field picture mode.

2011-03-24 Thread Ronald S. Bultje
Hi, On Wed, Mar 23, 2011 at 5:07 PM, Luca Barbato lu_z...@gentoo.org wrote: On 03/23/2011 09:49 PM, Ronald S. Bultje wrote: Fixes make THREADS=2 fate-mpeg2-field-enc. --- Ok, might be useful adding a TODO comment as well Nevermind, fixed it properly. Ronald

[libav-devel] [PATCH] mpeg12.c: fix slice threading for mpeg2 field picture mode.

2011-03-24 Thread Ronald S. Bultje
Fixes make THREADS=2 fate-mpeg2-field-enc. --- libavcodec/mpeg12.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index c60826b..c47b6e2 100644 --- a/libavcodec/mpeg12.c +++ b/libavcodec/mpeg12.c @@ -1882,7 +1882,9

Re: [libav-devel] [PATCH] Chronomaster DFA decoder

2011-03-25 Thread Ronald S. Bultje
Hi, On Fri, Mar 25, 2011 at 6:14 AM, Kostya kostya.shish...@gmail.com wrote: [..] Current patch looks OK to me, I'll give others one more day to comment and will apply tomorrow. Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] Warnings patrol

2011-03-25 Thread Ronald S. Bultje
Hi, On Fri, Mar 25, 2011 at 2:44 PM, Sean McGovern gsean...@gmail.com wrote: I'd like to ask permission to go on warnings patrol based on the reports submitted to FATE. Some targets have over 700+ now. The immediate aim being only to squelch noisy warnings without changing code. If this is

Re: [libav-devel] Query : h264 decoder optimizations

2011-03-27 Thread Ronald S. Bultje
Hi, On Sun, Mar 27, 2011 at 6:01 AM, @R0Y rahuljain@gmail.com wrote: Hiii... I wanna apply for Gsoc 2011 under this project h264 decoder optimizations . is any one else Doing this project ? the Qualifaction task is  :  make our decoder 1% faster Give me some idea related to

Re: [libav-devel] [PATCH] Add MxPEG video decoder

2011-03-27 Thread Ronald S. Bultje
Hi, On Mar 27, 2011, at 3:34 PM, Reinhard Tartler siret...@tauware.de wrote: I've tested this patch with these two samples, both seem to work OK. http://dissovet.ru/mxpeg-samples/livestream1.mxg http://dissovet.ru/mxpeg-samples/livestream2.mxg Yeah I wanted to look further into the

Re: [libav-devel] [PATCH] SMUSH decoder, v0 and 1

2011-03-28 Thread Ronald S. Bultje
Hi, On Wed, Mar 23, 2011 at 2:03 PM, Kostya kostya.shish...@gmail.com wrote: On Tue, Mar 22, 2011 at 06:54:38PM +0100, Diego Biurrun wrote: On Sun, Mar 20, 2011 at 11:02:23AM +0100, Kostya wrote: [...] The usual nits.. reordered, added whitespaces, broke some long lines (even if I don't

[libav-devel] [PATCH] mimic: implement multithreading.

2011-03-28 Thread Ronald S. Bultje
From: Alexander Strange astra...@ithinksw.com --- libavcodec/mimic.c | 60 ++- 1 files changed, 49 insertions(+), 11 deletions(-) diff --git a/libavcodec/mimic.c b/libavcodec/mimic.c index a12f638..133d26f 100644 --- a/libavcodec/mimic.c +++

Re: [libav-devel] [PATCH 1/2] lavf: update AVStream.nb_frames when muxing.

2011-03-29 Thread Ronald S. Bultje
Hi, On Tue, Mar 29, 2011 at 3:20 AM, Anton Khirnov an...@khirnov.net wrote: On Mon, Mar 28, 2011 at 09:56:07PM -0700, Ronald S. Bultje wrote: Hi, On Mon, Mar 28, 2011 at 3:36 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/matroskaenc.c |    2 +-  libavformat/utils.c

Re: [libav-devel] [PATCH] dfa: protect pointer range checks against overflows.

2011-03-29 Thread Ronald S. Bultje
Hi, On Tue, Mar 29, 2011 at 7:22 AM, Kostya kostya.shish...@gmail.com wrote: On Tue, Mar 29, 2011 at 07:14:55AM -0700, Ronald S. Bultje wrote: ---  libavcodec/dfa.c |    6 +++---  1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/dfa.c b/libavcodec/dfa.c index

Re: [libav-devel] [PATCH] Remove unnecessary parameter from ff_thread_init() and fix behavior

2011-03-29 Thread Ronald S. Bultje
Hi, On Tue, Mar 29, 2011 at 2:23 PM, Alexander Strange astra...@ithinksw.com wrote: thread_count passed to ff_thread_init() is only used to set AVCodecContext. thread_count, and can be removed. Instead move it to the legacy implementation of avcodec_thread_init(). This also fixes the problem

Re: [libav-devel] [PATCH] sndio bug fix

2011-03-29 Thread Ronald S. Bultje
Hi, On Tue, Mar 29, 2011 at 4:37 PM, Brad b...@comstyle.com wrote: Since the code already supports both little- and big-endian audio for recording, do not fail just because the endianness is not what we expect. diff --git a/libavdevice/sndio_common.c b/libavdevice/sndio_common.c index

Re: [libav-devel] Support for high bit depth h264 decoding v2

2011-03-29 Thread Ronald S. Bultje
Hi, On Tue, Mar 29, 2011 at 3:23 PM, Oskar Arvidsson os...@irock.se wrote: On Tue, Mar 29, 2011 at 11:06:50PM +0100, Måns Rullgård wrote: Oskar Arvidsson os...@irock.se writes: Hi, On Tue, Mar 29, 2011 at 05:48:45PM +0200, Oskar Arvidsson wrote: Also, I've done some basic benchmarking

Re: [libav-devel] [PATCH 7/9] avio: move ff_crc04C11DB7_update() from avio.h - avio_internal.h

2011-03-29 Thread Ronald S. Bultje
Hi, On Thu, Mar 17, 2011 at 6:03 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h          |    2 --  libavformat/avio_internal.h |    2 ++  2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index 0d75d30..0e4e93e 100644

Re: [libav-devel] [PATCH 4/9] avio: avio_ prefix for url_fdopen

2011-03-29 Thread Ronald S. Bultje
Hi, On Thu, Mar 17, 2011 at 6:03 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h         |    3 ++-  libavformat/aviobuf.c      |    8 ++--  libavformat/rtpenc_chain.c |    2 +-  3 files changed, 9 insertions(+), 4 deletions(-) url_fdopen() publicness depends on

Re: [libav-devel] Support for high bit depth h264 decoding v2

2011-03-30 Thread Ronald S. Bultje
Hi, On Tue, Mar 29, 2011 at 10:52 PM, Oskar Arvidsson os...@irock.se wrote: On Tue, Mar 29, 2011 at 09:25:13PM -0700, Ronald S. Bultje wrote: Hi, On Tue, Mar 29, 2011 at 3:23 PM, Oskar Arvidsson os...@irock.se wrote: On Tue, Mar 29, 2011 at 11:06:50PM +0100, Måns Rullgård wrote: Oskar

Re: [libav-devel] [PATCH] APIChanges: mark the place where 0.6 was branched.

2011-03-30 Thread Ronald S. Bultje
Hi, On Wed, Mar 30, 2011 at 7:57 AM, Anton Khirnov an...@khirnov.net wrote: ---  doc/APIchanges |    6 ++  1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 2932028..d242791 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -453,16

Re: [libav-devel] [PATCH] mpegts: propagate avio EOF in read_packet()

2011-03-31 Thread Ronald S. Bultje
Hi, 2011/3/31 Jindřich Makovička makov...@gmail.com: currently, libav mpeg-ts demuxer returns AVERROR(EIO) on both error and EOF conditions. This patch changes its behavior to return AVERROR_EOF on the End of File. [..] len = avio_read(pb, buf, TS_PACKET_SIZE); -if (len !=

Re: [libav-devel] [PATCH] mpegts: propagate avio EOF in read_packet()

2011-03-31 Thread Ronald S. Bultje
Hi, 2011/3/31 Jindřich Makovička makov...@gmail.com: 2011/3/31 Ronald S. Bultje rsbul...@gmail.com: Hi, 2011/3/31 Jindřich Makovička makov...@gmail.com: currently, libav mpeg-ts demuxer returns AVERROR(EIO) on both error and EOF conditions. This patch changes its behavior to return

Re: [libav-devel] [PATCH] mpegts: propagate avio EOF in read_packet()

2011-03-31 Thread Ronald S. Bultje
Hi, 2011/3/31 Jindřich Makovička makov...@gmail.com: 2011/3/31 Ronald S. Bultje rsbul...@gmail.com: Right, this can happen with a partial packet at the end. But I think it would be better to consider this case an EOF too, i.e. +            if (len == AVERROR_EOF || len = 0

Re: [libav-devel] [PATCH 5/9] avio: deprecate url_fileno

2011-03-31 Thread Ronald S. Bultje
Hi, 2011/3/31 Jindřich Makovička makov...@gmail.com: Hi, is there an official way to access the underlying URL context from a user app which obtained an AVFormatContext using av_open_input_file() ? I used this to control some aspects of my custom URLContexts on the fly, which is a bit

Re: [libav-devel] [PATCH] avio: document avio_alloc_context.

2011-04-01 Thread Ronald S. Bultje
Hi, On Fri, Apr 1, 2011 at 9:21 AM, Anton Khirnov an...@khirnov.net wrote: + * @param buffer Memory block for input/output operations via AVIOContext _buffered_ i/o, not just regular i/o. Then as param for buffer_size, you should mention why the size is important. For optimal performance on

Re: [libav-devel] [PATCH] lavc: deprecate rate_emu

2011-04-02 Thread Ronald S. Bultje
Hi, On Sat, Apr 2, 2011 at 3:53 AM, Anton Khirnov an...@khirnov.net wrote: It's not used anywhere and apparrently hasn't been for a very long time. ---  libavcodec/avcodec.h |    4 +++-  libavcodec/options.c |    2 ++  libavcodec/version.h |    3 +++  3 files changed, 8 insertions(+), 1

Re: [libav-devel] [PATCH 2/2] lavc: deprecate AVCodecContext.antialias_algo

2011-04-02 Thread Ronald S. Bultje
Hi, On Sat, Apr 2, 2011 at 7:37 AM, Anton Khirnov an...@khirnov.net wrote: It's been unused since mp3float decoder was added. ---  libavcodec/avcodec.h |    5 -  libavcodec/options.c |    2 ++  libavcodec/version.h |    3 +++  3 files changed, 9 insertions(+), 1 deletions(-) OK.

Re: [libav-devel] [PATCH 1/2] lavc: mark mb_qmin/mb_qmax for removal on next major bump.

2011-04-02 Thread Ronald S. Bultje
Hi, On Sat, Apr 2, 2011 at 7:37 AM, Anton Khirnov an...@khirnov.net wrote: They've been unused and deprecated for about five years. ---  libavcodec/avcodec.h |    6 --  libavcodec/options.c |    2 ++  libavcodec/version.h |    3 +++  3 files changed, 9 insertions(+), 2 deletions(-) OK.

Re: [libav-devel] [PATCH 01/15] avio: deprecate url_poll and URLPollEntry

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: They're unimplemented and nobody cared to do anything with that for 10 years. ---  libavformat/avio.h |    6 +-  1 files changed, 5 insertions(+), 1 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH] avio: make url_open_dyn_packet_buf internal.

2011-04-03 Thread Ronald S. Bultje
Hi, On Sun, Apr 3, 2011 at 2:31 PM, Anton Khirnov an...@khirnov.net wrote: It doesn't look fit to be a part of the public API. Adding a temporary hack to ffserver to be able to use it, should be cleaned up when somebody is up for it. ---  ffserver.c                  |    6 --  

Re: [libav-devel] [PATCH 14/15] avio: deprecate url_max_packet_size().

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: URLContext.max_packet_size should be used directly. ---  libavformat/avio.c      |    9 -  libavformat/avio.h      |   11 +--  libavformat/aviobuf.c   |    2 +-  libavformat/rtmpproto.c |    2 +-  

Re: [libav-devel] [PATCH] Avio cleanup II

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: One thing we might want to keep is some way of enumerating the protocols, so apps can check whether a specific protocol is available. Why wouldn't people use the buffer API for that also? As long as we make sure (we

Re: [libav-devel] [PATCH 04/15] avio: make url_connect internal.

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.c |   10 +++---  libavformat/avio.h |    6 +-  libavformat/mmsh.c |    4 ++--  libavformat/rtsp.c |    4 ++--  libavformat/url.h  |    5 +  5 files changed, 17 insertions(+), 12

Re: [libav-devel] [PATCH 06/15] avio: make url_read() internal.

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/applehttpproto.c |    2 +-  libavformat/avio.c           |    6 +-  libavformat/avio.h           |   12 +---  libavformat/aviobuf.c        |    2 +-  libavformat/concat.c         |    2

Re: [libav-devel] [PATCH 07/15] avio: make url_read_complete() internal.

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.c      |    6 +-  libavformat/avio.h      |   10 +-  libavformat/mmsh.c      |   10 +-  libavformat/mmst.c      |    8  libavformat/rtmppkt.c   |   16

Re: [libav-devel] [PATCH 12/15] avio: make url_filesize() internal.

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.c   |    6 +-  libavformat/avio.h   |    8 +---  libavformat/concat.c |    2 +-  libavformat/url.h    |    7 +++  4 files changed, 14 insertions(+), 9 deletions(-) [..] + * Return

Re: [libav-devel] [PATCH 11/15] avio: make url_close() internal.

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/applehttpproto.c |    4 ++--  libavformat/avio.c           |   12  libavformat/avio.h           |   10 +-  libavformat/aviobuf.c        |    4 ++--  libavformat/concat.c        

Re: [libav-devel] [PATCH 15/15] avio: deprecate url_get_filename().

2011-04-03 Thread Ronald S. Bultje
Hi, On Thu, Mar 31, 2011 at 9:14 AM, Anton Khirnov an...@khirnov.net wrote: URLContext.filename should be used directly. ---  libavformat/avio.c |   10 --  libavformat/avio.h |    8 +---  2 files changed, 5 insertions(+), 13 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH] lavc: move some flac-specific options to its private context.

2011-04-03 Thread Ronald S. Bultje
Hi, On Sun, Apr 3, 2011 at 7:09 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 04/02/2011 01:19 PM, Anton Khirnov wrote: ---  libavcodec/avcodec.h |   29 ++  libavcodec/flacenc.c |  104 +++--  libavcodec/options.c |   18

Re: [libav-devel] [PATCH] Use consistent condition for whether to run slice-threading execute function.

2011-04-03 Thread Ronald S. Bultje
Hi, On Sun, Apr 3, 2011 at 12:00 PM, Benjamin Larsson ba...@ludd.ltu.se wrote: On 04/02/2011 02:24 AM, Alexander Strange wrote: From: Reimar Döffinger reimar.doeffin...@gmx.de ---  libavcodec/mpeg12.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libav-devel] [PATCH 03/15] avio: make url_alloc internal.

2011-04-04 Thread Ronald S. Bultje
Hi, On Mon, Apr 4, 2011 at 11:23 AM, Martin Storsjö mar...@martin.st wrote: Of these, url_open is the only one used normally, while url_alloc+url_connect are called explicitly when setting private options. url_open_protocol is deprecated now, and I don't see too much a need to keep a public

Re: [libav-devel] [PATCH 2/9] avio: deprecate av_url_read_pause

2011-04-04 Thread Ronald S. Bultje
Hi, On Mon, Apr 4, 2011 at 2:43 PM, Anton Khirnov an...@khirnov.net wrote: It's not used anywhere internally. ---  libavformat/avio.c |    2 ++  libavformat/avio.h |    8 +---  2 files changed, 3 insertions(+), 7 deletions(-) No reason to save the docs for ffio_read_pause() or so? OK

Re: [libav-devel] [PATCH] Remove unnecessary parameter from ff_thread_init() and fix behavior

2011-04-05 Thread Ronald S. Bultje
Hi, On Sat, Apr 2, 2011 at 12:17 AM, Alexander Strange astra...@ithinksw.com wrote: On Tue, Mar 29, 2011 at 9:43 PM, Ronald S. Bultje rsbul...@gmail.com wrote: On Tue, Mar 29, 2011 at 2:23 PM, Alexander Strange astra...@ithinksw.com wrote: thread_count passed to ff_thread_init() is only used

Re: [libav-devel] [PATCH] avio: always compile dyn_buf functions

2011-04-05 Thread Ronald S. Bultje
Hi, On Tue, Apr 5, 2011 at 1:06 PM, Anton Khirnov an...@khirnov.net wrote: Fixes build with --disable-muxers --disable-network. Thanks to Hendrik Leppkes for noticing. ---  libavformat/aviobuf.c |    4  1 files changed, 0 insertions(+), 4 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH] matroskaenc: don't write an empty Cues element.

2011-04-06 Thread Ronald S. Bultje
Hi, On Wed, Apr 6, 2011 at 1:19 AM, Anton Khirnov an...@khirnov.net wrote: On Mon, Apr 04, 2011 at 09:38:32PM +0100, Måns Rullgård wrote: Anton Khirnov an...@khirnov.net writes: ---  libavformat/matroskaenc.c |    9 ++---  1 files changed, 6 insertions(+), 3 deletions(-) diff

Re: [libav-devel] [PATCH 7/9] avio: deprecate av_protocol_next().

2011-04-06 Thread Ronald S. Bultje
Hi, On Tue, Apr 5, 2011 at 4:14 AM, Stefano Sabatini stefano.sabatini-l...@poste.it wrote: On date Tuesday 2011-04-05 00:32:07 +0200, Anton Khirnov wrote: On Mon, Apr 04, 2011 at 11:21:51PM +0200, Stefano Sabatini wrote: [...] Stupid question, what's wrong with av_protocol_next()? And

Re: [libav-devel] [PATCH 2/6] avio: avio_ prefix for url_exist().

2011-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 7, 2011 at 4:40 PM, Anton Khirnov an...@khirnov.net wrote: On Thu, Apr 07, 2011 at 04:34:39PM -0400, Ronald S. Bultje wrote: On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: ---  ffmpeg.c           |    2 +-  ffserver.c         |    4

Re: [libav-devel] [PATCH] Experimental DCA encoder

2011-04-07 Thread Ronald S. Bultje
Hi, 2011/4/7 Benjamin Larsson ba...@ludd.ltu.se: +static inline int32_t mul32(int32_t a, int32_t b) +{ +/* on =i686, gcc compiles this into a single imull instruction */ +int64_t r = (int64_t)a * b; +/* round the result before truncating - improves accuracy */ +return (r +

Re: [libav-devel] [PATCH 2/2] add MicroDVD muxer and demuxer

2011-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 7, 2011 at 1:01 AM, Alexander Strange astra...@ithinksw.com wrote: On Apr 6, 2011, at 5:44 PM, Ronald S. Bultje wrote: On Tue, Apr 5, 2011 at 3:08 PM, Luca Barbato lu_z...@gentoo.org wrote: +    if (buffer[0] !(res = av_new_packet(pkt, len))) { +        memcpy(pkt-data

Re: [libav-devel] [PATCH 5/6] avio: make URLContext internal.

2011-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: ---  ffserver.c                   |    6 ++--  libavformat/applehttp.c      |    2 +-  libavformat/applehttpproto.c |   10 +++---  libavformat/avio.c           |   76 +-  

Re: [libav-devel] [PATCH 6/6] avio: make URLProtocol internal.

2011-04-07 Thread Ronald S. Bultje
Hi, On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/allformats.c     |    2 +-  libavformat/applehttpproto.c |    2 +-  libavformat/avio.c           |   26 +-  libavformat/avio.h           |    6 +-  libavformat/concat.c    

Re: [libav-devel] [PATCH 1/2] avio: make URLContext internal.

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 1:22 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h          |    3 ++-  libavformat/avio_internal.h |    1 +  libavformat/file.c          |    1 +  libavformat/http.h          |    2 +-  libavformat/librtmp.c       |    1 +  libavformat/mms.h

Re: [libav-devel] [PATCH 1/5] lavf: mark av_pkt_dump(_log) for remove on $next+1 bump.

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 5:48 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avformat.h |    4 +++-  libavformat/utils.c    |    4  libavformat/version.h  |    3 +++  3 files changed, 10 insertions(+), 1 deletions(-) Any reason we don't want to remove it at the next one

Re: [libav-devel] [PATCH 3/5] lavf: get rid of ffm-specific stuff in avformat.h

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 5:48 AM, Anton Khirnov an...@khirnov.net wrote: ---  ffmpeg.c               |    2 ++  ffserver.c             |    1 +  libavformat/avformat.h |    6 --  libavformat/ffm.h      |    5 +  4 files changed, 8 insertions(+), 6 deletions(-) diff --git

Re: [libav-devel] [PATCH 2/2] avio: make URLProtocol internal.

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 1:22 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h |    6 +-  libavformat/url.h  |   17 +  2 files changed, 22 insertions(+), 1 deletions(-) OK. This compiles after the bump, right? Ronald

Re: [libav-devel] [PATCH] Experimental DCA encoder

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 5:02 AM, Benjamin Larsson ba...@ludd.ltu.se wrote: On 04/08/2011 03:58 AM, Ronald S. Bultje wrote: 2011/4/7 Benjamin Larsson ba...@ludd.ltu.se: +static void qmf_decompose(DCAContext *c, int32_t in[32], int32_t out[32], int channel) +{ +    int band, i, j, k

Re: [libav-devel] [PATCH 3/5] lavf: get rid of ffm-specific stuff in avformat.h

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 9:47 AM, Anton Khirnov an...@khirnov.net wrote: On Fri, Apr 08, 2011 at 07:43:35AM -0400, Ronald S. Bultje wrote: On Fri, Apr 8, 2011 at 5:48 AM, Anton Khirnov an...@khirnov.net wrote: ---  ffmpeg.c               |    2 ++  ffserver.c             |    1

Re: [libav-devel] [PATCH 1/5] lavf: mark av_pkt_dump(_log) for remove on $next+1 bump.

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 9:43 AM, Anton Khirnov an...@khirnov.net wrote: On Fri, Apr 08, 2011 at 07:39:52AM -0400, Ronald S. Bultje wrote: On Fri, Apr 8, 2011 at 5:48 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avformat.h |    4 +++-  libavformat/utils.c    |    4

Re: [libav-devel] [PATCH] Last bits of avio cleanup

2011-04-08 Thread Ronald S. Bultje
Hi, On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: Hi, with those patches, the avio cleanup is finally complete. I'm not very sure about url_exist. It's used in ffmpeg, ffserver and img2, but there were some problems with it [1]. There were patches from Stefano

Re: [libav-devel] [PATCH 2/5] lavf: make av_guess_image2_codec internal

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 5:48 AM, Anton Khirnov an...@khirnov.net wrote: It doesn't look very useful as a public function. ---  libavformat/avformat.h |    4 +++-  libavformat/img2.c     |    8  libavformat/internal.h |    2 ++  libavformat/utils.c    |    4 ++--  

Re: [libav-devel] [PATCH 3/5] lavf: get rid of ffm-specific stuff in avformat.h

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 10:42 AM, Anton Khirnov an...@khirnov.net wrote: On Fri, Apr 08, 2011 at 10:07:32AM -0400, Ronald S. Bultje wrote: Hi, On Fri, Apr 8, 2011 at 9:47 AM, Anton Khirnov an...@khirnov.net wrote: On Fri, Apr 08, 2011 at 07:43:35AM -0400, Ronald S. Bultje wrote: On Fri

Re: [libav-devel] [PATCH 3/5] lavf: get rid of ffm-specific stuff in avformat.h

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 10:45 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Can we expose this somehow through private API? Can you think of other solutions? Private API == AVOption or so, not ff_*() API. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/2] avio: deprecate av_protocol_next().

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 10:54 AM, Anton Khirnov an...@khirnov.net wrote: ---  cmdutils.c         |   20  libavformat/avio.c |    2 ++  libavformat/avio.h |    4 +++-  3 files changed, 13 insertions(+), 13 deletions(-) This one is surely OK. Ronald

Re: [libav-devel] [PATCH 1/2] avio: add a function for iterating though protocol names.

2011-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2011 at 10:54 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.c |   10 ++  libavformat/avio.h |   13 +  2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index e043058..ab7a7f5

Re: [libav-devel] [PATCH] pthread: validate_thread_parameters() ignored slice-threading being intentionally off

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 12:08 AM, Alexander Strange astra...@ithinksw.com wrote: On Sun, Apr 3, 2011 at 6:25 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sun, Apr 3, 2011 at 1:56 PM, Luca Barbato lu_z...@gentoo.org wrote: On 04/03/2011 10:15 PM, Alexander Strange wrote

Re: [libav-devel] [PATCH 23/27] mpegts: Replace defines in with AVOptions

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:50 AM, Reinhard Tartler siret...@tauware.de wrote: From: Georgi Chorbadzhiyski g...@unixsol.org This patch adds support for setting transport_stream_id, original_network_id, service_id, pmt_start_pid and start_pid in mpegts muxer. Signed-off-by: Ronald S

Re: [libav-devel] [PATCH 2/7] avio: cosmetics, move AVIOContext to start of the file.

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 8:57 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h |   77 ++-  1 files changed, 39 insertions(+), 38 deletions(-) OK. Ronald ___ libav-devel mailing

Re: [libav-devel] [PATCH 3/7] avio: cosmetics, merge all the FF_API_OLD_AVIO blocks.

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 8:57 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h |  196 ++--  1 files changed, 84 insertions(+), 112 deletions(-) Looks OK to me (no strong opinion). Ronald

Re: [libav-devel] [PATCH 4/7] avio: cosmetics, group the reading functions.

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 8:57 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h |   20 ++--  1 files changed, 14 insertions(+), 6 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 19/27] patch checklist:git format-patch Signed-off-by: Michael Niedermayer michae...@gmx.at

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:50 AM, Reinhard Tartler siret...@tauware.de wrote: From: Michael Niedermayer michae...@gmx.at ---  doc/developer.texi |    7 +--  1 files changed, 1 insertions(+), 6 deletions(-) [..]  @item -    Is the patch a unified diff? +    Was the patch generated

Re: [libav-devel] [PATCH 20/27] patch checklist:uggest fate instead of regression tests Signed-off-by: Michael Niedermayer michae...@gmx.at

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:50 AM, Reinhard Tartler siret...@tauware.de wrote: From: Michael Niedermayer michae...@gmx.at ---  doc/developer.texi |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) [..] -    Do the regression tests pass with the patch applied? +    Does fate pass

Re: [libav-devel] [PATCH 11/27] eval: add support for trunc, ceil, and floor functions

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:49 AM, Reinhard Tartler siret...@tauware.de wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it Signed-off-by: Stefano Sabatini stefano.sabatini-l...@poste.it ---  doc/eval.texi      |   12  libavutil/avutil.h |    2 +-  libavutil/eval.c  

Re: [libav-devel] [PATCH 05/27] documentation: add setdar and setsar description to filters.texi

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:49 AM, Reinhard Tartler siret...@tauware.de wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it ---  doc/filters.texi |   56 ++  1 files changed, 56 insertions(+), 0 deletions(-) Looks OK to me.

Re: [libav-devel] [PATCH 07/27] documentation: sort filter descriptions in filters.texi

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:49 AM, Reinhard Tartler siret...@tauware.de wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it Change position of the fade filter description, put it between drawtext and fifo descriptions. [..] +@section drawtext The log message is wrong, this patch

Re: [libav-devel] [PATCH 08/27] drawtext: add documentation for the shadow parameters

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:49 AM, Reinhard Tartler siret...@tauware.de wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it ---  doc/filters.texi |   11 +++  1 files changed, 11 insertions(+), 0 deletions(-) You can squash this with 7. Ronald

Re: [libav-devel] [PATCH 09/27] drawtext: extend/clarify examples in the filter description

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:49 AM, Reinhard Tartler siret...@tauware.de wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it ---  doc/filters.texi |   18 ++  1 files changed, 14 insertions(+), 4 deletions(-) Please squash this with 7 also. Ronald

Re: [libav-devel] [PATCH 10/27] drawtext: fix wrong reference in boxcolor option description

2011-04-09 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 7:49 AM, Reinhard Tartler siret...@tauware.de wrote: From: Stefano Sabatini stefano.sabatini-l...@poste.it ---  doc/filters.texi |    3 +--  1 files changed, 1 insertions(+), 2 deletions(-) Here also, please squash with 7. Ronald

Re: [libav-devel] [PATCH 6/7] avio: cosmetics, vertically align comments.

2011-04-10 Thread Ronald S. Bultje
Hi, On Sun, Apr 10, 2011 at 2:15 AM, Anton Khirnov an...@khirnov.net wrote: On Sat, Apr 09, 2011 at 05:03:34PM -0400, Ronald S. Bultje wrote: Hi, On Sat, Apr 9, 2011 at 8:57 AM, Anton Khirnov an...@khirnov.net wrote: ---  libavformat/avio.h |   10 +-  1 files changed, 5

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Ronald S. Bultje
Hi, On Mon, Apr 11, 2011 at 10:01 AM, Luca Barbato lu_z...@gentoo.org wrote: On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: This isn't right. You're declaring empty functions for stuff that is supposed to do something. In x86/yuv2rgb_mmx.c, you'll see these functions are only called under

Re: [libav-devel] [PATCH 4/5] swscale: further cleanup swscale.c

2011-04-12 Thread Ronald S. Bultje
Hi, On Mon, Apr 11, 2011 at 4:01 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Josh Allmann joshua.allm...@gmail.com Move x86-specific constants out of swscale.c ---  libswscale/swscale.c              |   57 -  libswscale/x86/swscale_template.c |  

Re: [libav-devel] [PATCH 01/12] libopencore-amr: Remove unused code fragments

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: This parts are heritage from the encoder part from the old libamr code removed in SVN rev 19365. ---  libavcodec/libopencore-amr.c |   11 ---  1 files changed, 0 insertions(+), 11 deletions(-) OK. (Although

Re: [libav-devel] [PATCH 02/12] libopencore-amr: Make the opaque encoder pointer a void*

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libopencore-amr.c b/libavcodec/libopencore-amr.c index c11c924..52dfe10 100644 ---

Re: [libav-devel] [PATCH 03/12] libopencore-amr: Remove a useless debugging variable and commented out logging

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |   15 ---  1 files changed, 0 insertions(+), 15 deletions(-) [..] diff --git a/libavcodec/libopencore-amr.c b/libavcodec/libopencore-amr.c [..] -    /* av_log(NULL,

Re: [libav-devel] [PATCH 06/12] libopencore-amr, libvo-amrwbenc: Return proper error return codes in most places

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |   16  libavcodec/libvo-amrwbenc.c  |    8  2 files changed, 12 insertions(+), 12 deletions(-) All OK.     if (avctx-sample_rate != 8000) {        

Re: [libav-devel] [PATCH 07/12] libopencore-amr: Make the bitrate/mode mapping array static const

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libopencore-amr.c b/libavcodec/libopencore-amr.c index 8a8c18b..c04cf99 100644 ---

Re: [libav-devel] [PATCH 09/12] libopencore-amr, libvo-amrbwenc: Rename variables and functions

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |   26 +-  libavcodec/libvo-amrwbenc.c  |    6 +++---  2 files changed, 16 insertions(+), 16 deletions(-) OK. Ronald

Re: [libav-devel] [PATCH 10/12] libopencore-amr: Cosmetics: Rewrap and align

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |   20  1 files changed, 8 insertions(+), 12 deletions(-) OK. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH 12/12] libopencore-amr, libvo-amrwbenc: Dynamically print the bitrate error message

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 5:58 PM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libopencore-amr.c |   18 --  libavcodec/libvo-amrwbenc.c  |   17 ++---  2 files changed, 14 insertions(+), 21 deletions(-) [..] -static const char nb_bitrate_unsupported[]

Re: [libav-devel] [PATCH] Check for successful h263 init in msmpeg4 init

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 7:38 PM, Alberto Delmás adel...@gmail.com wrote: This prevents crashes on malloc failures and the like, and helps catch other problems earlier. Looks OK, queued locally. Ronald ___ libav-devel mailing list

Re: [libav-devel] [PATCH] Prevent crash with bogus VC-1 display extension info

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 7:33 PM, Alberto Delmás adel...@gmail.com wrote: In the current code, the display extension info (if present) is used to set avctx-width and height. These in turn determine the size of the allocated picture buffer, so if they're too small the decoder will write

Re: [libav-devel] [PATCH 2/2] applehttp: Handle AES-128 encrypted streams

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 4:08 AM, Martin Storsjö mar...@martin.st wrote: This should hopefully fix roundup issue 2586. This commit only implements it in the demuxer, not in the protocol handler. If desired, some of the code could be refactored to be shared by both implementations. Is

Re: [libav-devel] [PATCH 3/3] libvo-aacenc: Only produce extradata if the global header flag is set

2011-04-12 Thread Ronald S. Bultje
Hi, On Tue, Apr 12, 2011 at 3:44 AM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libvo-aacenc.c |   18 ++  1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/libvo-aacenc.c b/libavcodec/libvo-aacenc.c index 3c7dde7..7c1738d 100644 ---

Re: [libav-devel] [RFC] log_level_offset and av_log changes

2011-04-12 Thread Ronald S. Bultje
Hi, On Sat, Apr 9, 2011 at 11:14 PM, Luca Barbato lu_z...@gentoo.org wrote: Today I planned to add to av_log() some optional features in order to track file, line and function. I noticed some strange code introduced with this commit[1] if(avc avc-version = (5016 | 158 | 2)

Re: [libav-devel] [PATCH] applehttp: Only check the discard flags if v-ctx actually is initialized

2011-04-12 Thread Ronald S. Bultje
Hi Martin, On Tue, Apr 12, 2011 at 3:57 AM, Martin Storsjö mar...@martin.st wrote: This code could be executed if the demuxer reads more than one segment before returning from av_open_input_stream. ---  libavformat/applehttp.c |   11 +++  1 files changed, 7 insertions(+), 4

Re: [libav-devel] [PATCH] lavc: move some flac-specific options to its private context.

2011-04-12 Thread Ronald S. Bultje
Hi, On Mon, Apr 4, 2011 at 11:35 AM, Justin Ruggles justin.rugg...@gmail.com wrote: On 04/04/2011 11:30 AM, Ronald S. Bultje wrote: On Mon, Apr 4, 2011 at 3:21 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 04/02/2011 01:19 PM, Anton Khirnov wrote: +#if FF_API_FLAC_GLOBAL_OPTS

Re: [libav-devel] [PATCH 3/3] libvo-aacenc: Only produce extradata if the global header flag is set

2011-04-13 Thread Ronald S. Bultje
Hi, On Wed, Apr 13, 2011 at 2:49 AM, Martin Storsjö mar...@martin.st wrote: On Tue, 12 Apr 2011, Ronald S. Bultje wrote: On Tue, Apr 12, 2011 at 3:44 AM, Martin Storsjö mar...@martin.st wrote: ---  libavcodec/libvo-aacenc.c |   18 ++  1 files changed, 10 insertions(+), 8

Re: [libav-devel] [PATCH 2/6] avio: add avio_check()

2011-04-13 Thread Ronald S. Bultje
Hi, On Wed, Apr 13, 2011 at 4:21 AM, Stefano Sabatini stefano.sabatini-l...@poste.it wrote: And of course thanks to Anton for the great work :). Indeed, thanks! Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 23/27] mpegts: Replace defines in with AVOptions

2011-04-13 Thread Ronald S. Bultje
Hi, On Wed, Apr 13, 2011 at 2:35 AM, Anton Khirnov an...@khirnov.net wrote: On Sun, Apr 10, 2011 at 07:42:46AM -0400, Ronald S. Bultje wrote: Hi, On Sun, Apr 10, 2011 at 4:09 AM, Anton Khirnov an...@khirnov.net wrote: On Sat, Apr 09, 2011 at 08:42:10AM -0400, Ronald S. Bultje wrote: Hi

Re: [libav-devel] [PATCH 1/2] introduce side information for AVPacket

2011-04-13 Thread Ronald S. Bultje
Hi, On Wed, Apr 13, 2011 at 11:14 AM, Kostya kostya.shish...@gmail.com wrote: On Wed, Apr 13, 2011 at 11:03:26AM -0400, Ronald S. Bultje wrote: On Wed, Apr 13, 2011 at 10:33 AM, Kostya kostya.shish...@gmail.com wrote: Here are improved patches. [..] +     * Additional packet data that can

Re: [libav-devel] [PATCH 1/2] introduce side information for AVPacket

2011-04-13 Thread Ronald S. Bultje
Hi, On Wed, Apr 13, 2011 at 11:37 AM, Kostya kostya.shish...@gmail.com wrote: On Wed, Apr 13, 2011 at 11:19:26AM -0400, Ronald S. Bultje wrote: Hi, On Wed, Apr 13, 2011 at 11:14 AM, Kostya kostya.shish...@gmail.com wrote: On Wed, Apr 13, 2011 at 11:03:26AM -0400, Ronald S. Bultje wrote

  1   2   3   4   5   6   7   8   9   10   >