[libav-devel] [PATCH] discard cropping values in a consistent way

2011-04-22 Thread Vittorio Giovara
: Vittorio Giovara vittorio.giov...@sisveltech.com Date: Fri, 22 Apr 2011 16:48:57 +0200 Subject: [PATCH] this patch makes the h264 decoder discard unusal cropping values in a consistent way --- libavcodec/h264.c|6 +++--- libavcodec/h264_ps.c |7 ++- 2 files changed, 5 insertions

Re: [libav-devel] [PATCH] discard cropping values in a consistent way

2011-04-26 Thread Vittorio Giovara
I can provide copyleft samples to evaluate this patch if needed. I hope the community finds this useful and that the patch can be safely committed :) Would be great, probably they could be part of fate-suite. lu As promised, here are the samples, with and without cropping values: I've

Re: [libav-devel] [PATCH] discard cropping values in a consistent way

2011-05-13 Thread Vittorio Giovara
: On Thu, May 05, 2011 at 10:16:43PM +0200, Luca Barbato wrote: On 05/05/2011 05:49 PM, Vittorio Giovara wrote: ping! No more comments means the patch is ok and can be committed, right? :) Yes, but sadly I had been busy so I could try it properly nor run fate over it. If somebody has time to push

Re: [libav-devel] [PATCH] discard cropping values in a consistent way

2011-05-18 Thread Vittorio Giovara
, Ronald S. Bultje wrote: Hi, On Fri, May 13, 2011 at 3:59 AM, Vittorio Giovara vittorio.giov...@sisveltech.com wrote: weekly ping :) as I explained in the first email this patch is not doing the right thing as the right thing(tm) would be to actually crop the resulting frame to the dimensions

Re: [libav-devel] [PATCH] discard cropping values in a consistent way

2011-05-18 Thread Vittorio Giovara
On 18/05/2011 15:43, Måns Rullgård wrote: Please explain how limiting to 8 lines could ever make any sense whatsoever. I'm not saying that it makes sense, I'm saying that it makes more sense to crop a maximum value (eg. 8 lines which is the most common case) independently of resolution and

Re: [libav-devel] Fwd: [FFmpeg-devel] [PATCH] provide an input parameter to specify 3d stereo format for mkv/webm 3d videos

2011-05-18 Thread Vittorio Giovara
imho it would be a nice addition for libav. An even more interesting option would be to carry on the stereoscopic signalling across the coding/decoding for the codecs that actually support it. Besides the ones quoted here, there should also be H264, via the avc_sei_frame_packing_type message

Re: [libav-devel] [PATCH] lavf: default .ogg audio to libvorbis if we can

2014-02-08 Thread Vittorio Giovara
On Sun, Feb 9, 2014 at 1:05 AM, Tim Walker tdskywal...@gmail.com wrote: On 08 Feb 2014, at 18:18, Andrew Kelley superjo...@gmail.com wrote: Since 2007, the Xiph.org Foundation recommends that .ogg only be used for Ogg Vorbis audio files. Source:

Re: [libav-devel] [PATCH 3/9] bytestream: add functions for accessing size of buffer

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 11:04 PM, Justin Ruggles justin.rugg...@gmail.com wrote: From: Paul B Mahol one...@gmail.com Signed-off-by: Paul B Mahol one...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Justin Ruggles justin.rugg...@gmail.com Crowded signed-off

Re: [libav-devel] [PATCH 4/9] bytestream: add bytestream2_copy_buffer() functions

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 11:04 PM, Justin Ruggles justin.rugg...@gmail.com wrote: This is basically an overread/overwrite-safe memcpy between a GetByteContext and a PutByteContext. CC:libav-sta...@libav.org --- libavcodec/bytestream.h | 26 ++ 1 files changed, 26

Re: [libav-devel] [PATCH 1/9] tiffdec: rename variables for consistency and fix variable shadowing

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 11:03 PM, Justin Ruggles justin.rugg...@gmail.com wrote: From: Jean First jeanfi...@gmail.com Signed-off-by: Justin Ruggles justin.rugg...@gmail.com --- libavcodec/tiff.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) Looks ok. Vittorio

Re: [libav-devel] [PATCH 2/9] tiffdec: use correct data type for palette entries and set alpha to 0xFF

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 11:03 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- libavcodec/tiff.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) Looks ok. Vittorio diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 9f8bc60..382f72c 100644 ---

Re: [libav-devel] [PATCH 6/9] tiffdec: use a single strip if RowsPerStrip is 0

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 11:04 PM, Justin Ruggles justin.rugg...@gmail.com wrote: The spec does not specify that 0 is an error condition, and there are samples which use 0 when the whole image is in one strip. Is it worth adding a test for those? --- libavcodec/tiff.c | 11 +++ 1

Re: [libav-devel] [PATCH 8/9] tiffdec: remove an unneeded variable

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 11:04 PM, Justin Ruggles justin.rugg...@gmail.com wrote: --- libavcodec/tiff.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) Ok. Vittorio diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index dc7357a..25acae2 100644 --- a/libavcodec/tiff.c +++

Re: [libav-devel] [PATCH] dnxhddec: return proper error code

2014-02-08 Thread Vittorio Giovara
On Sat, Feb 8, 2014 at 10:25 PM, Alexandra Khirnova alexandra.khirn...@gmail.com wrote: --- libavcodec/dnxhddec.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) LGTM Vittorio ___ libav-devel mailing list

Re: [libav-devel] [PATCH] arm: Remove a stray .fpu directive

2014-02-08 Thread Vittorio Giovara
On Sun, Feb 9, 2014 at 1:34 AM, Martin Storsjö mar...@martin.st wrote: --- libavcodec/arm/int_neon.S | 2 -- 1 file changed, 2 deletions(-) Looks harmless. Vittorio ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-08 Thread Vittorio Giovara
On Sun, Feb 9, 2014 at 2:21 AM, Andrew Kelley superjo...@gmail.com wrote: This patch adds the `compand` audio filter from ffmpeg master branch (currently at 7f0f47b3df9d92eea0d1de94df29971b49f10777) adapted to work with libav. My downstream library is successfully using this filter to allow

Re: [libav-devel] [PATCH] ogg: check and propagate memory allocation failures as appropriate

2014-02-08 Thread Vittorio Giovara
On Sun, Jan 12, 2014 at 7:55 PM, Diego Biurrun di...@biurrun.de wrote: From: Sean McGovern gsean...@gmail.com Signed-off-by: Diego Biurrun di...@biurrun.de --- I fixed the bits that I noted during my review. libavformat/oggdec.c | 71 +-

Re: [libav-devel] [PATCH] lavf: default .ogg audio to libvorbis if we can

2014-02-08 Thread Vittorio Giovara
On Sun, Feb 9, 2014 at 1:29 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: I'm not really keen on having that written in a commit message, but I cannot come up with any better wording. Queued with s/very/as/. Vittorio ___ libav-devel mailing

[libav-devel] [PATCH 3/9] bytestream: add functions for accessing size of buffer

2014-02-09 Thread Vittorio Giovara
On Sunday, February 9, 2014, Justin Ruggles justin.rugg...@gmail.comjavascript:_e(%7B%7D,'cvml','justin.rugg...@gmail.com'); wrote: On 02/08/2014 07:35 PM, Vittorio Giovara wrote: On Sat, Feb 8, 2014 at 11:04 PM, Justin Ruggles justin.rugg...@gmail.com wrote: From: Paul B Mahol one

Re: [libav-devel] [PATCH 1/5] ffv1: Remove unnecessary header

2014-02-09 Thread Vittorio Giovara
On Sunday, February 9, 2014, Luca Barbato lu_z...@gentoo.org wrote: --- libavcodec/ffv1dec.c | 2 -- 1 file changed, 2 deletions(-) IMHO squashing this with #2 with a 'headers cleanup' log would be enough. Vittorio diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index

[libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-11 Thread Vittorio Giovara
Compute the full rotatation angle exported by display_matrix. --- Micro optimization, don't do the math when you get the identity matrix! Part of the code based on how VLC does it (in modules/demux/mp4/libmp4.c). Cheers, Vittorio --- Changelog| 1 + doc/APIchanges | 4

Re: [libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-11 Thread Vittorio Giovara
On Tue, Feb 11, 2014 at 12:08 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: Compute the full rotatation angle exported by display_matrix. --- +/** + * An AV_PKT_DATA_SCREEN_ORIENTATION side data packet contains the full + * rotation angle as integer degrees

[libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-11 Thread Vittorio Giovara
Compute the full rotatation angle exported by display_matrix. --- Updated patch using u32le as descriptor and AV_WL32 instead of the memcpy. The side data apparently survives after probing. I do not think it's worthwhile adding a metadata entry too. Cheers, Vittorio Changelog| 1

[libav-devel] [PATCH 2/3] h264: store current_sps_id inside the current sps

2014-02-12 Thread Vittorio Giovara
--- FATE says it's fine with this change. Vittorio libavcodec/h264.c| 5 ++--- libavcodec/h264.h| 2 +- libavcodec/h264_ps.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 8595909..701a5b1 100644 --- a/libavcodec/h264.c

[libav-devel] [PATCH 3/3] h264: drop outdated comments

2014-02-12 Thread Vittorio Giovara
--- Or at least they look that way. Any other findings would be welcome. Vittorio libavcodec/h264.c | 1 - libavcodec/h264.h | 6 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 701a5b1..8f2a3f1 100644 --- a/libavcodec/h264.c +++

[libav-devel] [PATCH 1/3] h264: print values in case of error

2014-02-12 Thread Vittorio Giovara
Also uniform error style and drop redudant information. --- Moar debugging! Vittorio libavcodec/h264.c| 23 +++ libavcodec/h264_parser.c | 8 libavcodec/h264_ps.c | 10 +- 3 files changed, 20 insertions(+), 21 deletions(-) diff --git

[libav-devel] [PATCH] h264: name buffering period SEI type consistently

2014-02-12 Thread Vittorio Giovara
--- libavcodec/h264.h | 2 +- libavcodec/h264_sei.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264.h b/libavcodec/h264.h index 21b7996..f29bc6a 100644 --- a/libavcodec/h264.h +++ b/libavcodec/h264.h @@ -120,7 +120,7 @@ enum { * SEI message types */

[libav-devel] [PATCH] h264_sei: reorder headers

2014-02-13 Thread Vittorio Giovara
Also drop unsued assert.h. --- libavcodec/h264_sei.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/h264_sei.c b/libavcodec/h264_sei.c index 2e4017b..6fca2c3 100644 --- a/libavcodec/h264_sei.c +++ b/libavcodec/h264_sei.c @@ -25,12 +25,10 @@ * @author

Re: [libav-devel] [PATCH 1/1] mpeg12dec: do not add stereo3D side data to a non-existing frame

2014-02-13 Thread Vittorio Giovara
On Thu, Feb 13, 2014 at 11:29 AM, Janne Grunau janne-li...@jannau.net wrote: User data is usually coded before slice data. That means the frame the user data belongs to is not available while parsing the user data. The stereo3D side data has to use the same indirection over the private context

Re: [libav-devel] [PATCH] h264: Refactor ff_h264_decode_ref_pic_list_reordering

2014-02-13 Thread Vittorio Giovara
On Thu, Feb 13, 2014 at 3:33 PM, Luca Barbato lu_z...@gentoo.org wrote: In preparation for MVC support. --- libavcodec/h264_refs.c | 136 ++--- 1 file changed, 72 insertions(+), 64 deletions(-) Completely unbiased OK. Vittorio

[libav-devel] [PATCH] h264_parser: use enum values in h264_find_frame_end()

2014-02-13 Thread Vittorio Giovara
--- Readability++ Vittorio libavcodec/h264_parser.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index b086707..a16229a 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -58,13 +58,15 @@

[libav-devel] [PATCH][RFC] vf_interlace: deprecate lowpass option

2014-02-13 Thread Vittorio Giovara
--- Turning off the lowpass filter while interlacing is a terrible idea as it can easily gernerate terrible results; the effect would be similar to decimating vertically by dropping the odd lines. So I propose to remove this option from the filter and keep the lowpass filter always applied, like

Re: [libav-devel] [PATCH 1/3] AVOptions: deprecate unused AV_OPT_FLAG_METADATA

2014-02-15 Thread Vittorio Giovara
On Saturday, February 15, 2014, Anton Khirnov an...@khirnov.net wrote: It was never used since it was added and the things it was intended for are now exported differently. --- doc/APIchanges |3 +++ libavutil/opt.h |2 ++ libavutil/version.h |5 - 3 files

Re: [libav-devel] [PATCH 2/3] AVOptions: add flags for read/read-only options

2014-02-15 Thread Vittorio Giovara
On Saturday, February 15, 2014, Anton Khirnov an...@khirnov.net wrote: --- doc/APIchanges |4 libavutil/opt.c | 14 +++--- libavutil/opt.h |9 + libavutil/version.h |4 ++-- 4 files changed, 26 insertions(+), 5 deletions(-) diff --git

[libav-devel] [PATCH][RFC] vf_interlace: deprecate lowpass option

2014-02-15 Thread Vittorio Giovara
On Friday, February 14, 2014, Tim Walker tdskywal...@gmail.comjavascript:_e(%7B%7D,'cvml','tdskywal...@gmail.com'); wrote: On 14 Feb 2014, at 06:01, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Turning off the lowpass filter while interlacing is a terrible idea as it can easily

Re: [libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-15 Thread Vittorio Giovara
On Wednesday, February 12, 2014, Vittorio Giovara vittorio.giov...@gmail.com wrote: Compute the full rotatation angle exported by display_matrix. --- Updated patch using u32le as descriptor and AV_WL32 instead of the memcpy. The side data apparently survives after probing. I do not think

Re: [libav-devel] [PATCH 2/3] AVOptions: add flags for read/read-only options

2014-02-15 Thread Vittorio Giovara
On Sat, Feb 15, 2014 at 12:59 PM, Anton Khirnov an...@khirnov.net wrote: On Sat, 15 Feb 2014 12:10:24 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Saturday, February 15, 2014, Anton Khirnov an...@khirnov.net wrote: --- doc/APIchanges |4 libavutil/opt.c

[libav-devel] [PATCH] vf_interlace: deprecate lowpass option

2014-02-15 Thread Vittorio Giovara
--- I hope I have grasped every comment received. Vittorio doc/filters.texi | 7 ++ libavfilter/vf_interlace.c | 63 +- 2 files changed, 36 insertions(+), 34 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index

Re: [libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-15 Thread Vittorio Giovara
On Sat, Feb 15, 2014 at 3:24 PM, Tim Walker tdskywal...@gmail.com wrote: On 12 Feb 2014, at 00:13, Vittorio Giovara vittorio.giov...@gmail.com wrote: Compute the full rotatation angle exported by display_matrix. --- diff --git a/Changelog b/Changelog index 6c54281..178d55d 100644

Re: [libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-15 Thread Vittorio Giovara
On Sat, Feb 15, 2014 at 7:31 PM, Tim Walker tdskywal...@gmail.com wrote: On 15 Feb 2014, at 19:02, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Sat, Feb 15, 2014 at 3:24 PM, Tim Walker tdskywal...@gmail.com wrote: On 12 Feb 2014, at 00:13, Vittorio Giovara vittorio.giov...@gmail.com

Re: [libav-devel] [PATCH 2/5] ffv1: Remove unnecessary header

2014-02-15 Thread Vittorio Giovara
On Sat, Feb 15, 2014 at 8:09 PM, Luca Barbato lu_z...@gentoo.org wrote: --- libavcodec/ffv1dec.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 2ff1f8c..b93b007 100644 --- a/libavcodec/ffv1dec.c +++

Re: [libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-15 Thread Vittorio Giovara
On Sat, Feb 15, 2014 at 8:00 PM, Tim Walker tdskywal...@gmail.com wrote: On 15 Feb 2014, at 19:53, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Sat, Feb 15, 2014 at 7:31 PM, Tim Walker tdskywal...@gmail.com wrote: On 15 Feb 2014, at 19:02, Vittorio Giovara vittorio.giov...@gmail.com

[libav-devel] [PATCH 3/4] h264: deprecate very early unused profile

2014-02-16 Thread Vittorio Giovara
--- This profile got dropped in 2005, I think it should be not listed as supported profile. Vittorio libavcodec/avcodec.h | 2 ++ libavcodec/h264.c| 2 ++ libavcodec/h264_ps.c | 5 - libavcodec/version.h | 5 - 4 files changed, 12 insertions(+), 2 deletions(-) diff --git

[libav-devel] [PATCH 2/4] h264: replace profile_idc checks with full profile name

2014-02-16 Thread Vittorio Giovara
--- libavcodec/h264.c | 10 +++--- libavcodec/h264_mb_template.c | 3 ++- libavcodec/h264_ps.c | 9 ++--- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 421e12a..1c27f05 100644 --- a/libavcodec/h264.c +++

[libav-devel] [PATCH 1/4] h264: drop checks for unknown profiles

2014-02-16 Thread Vittorio Giovara
--- libavcodec/h264_ps.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 932c27a..2a850b3 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -330,9 +330,7 @@ int ff_h264_decode_seq_parameter_set(H264Context *h)

[libav-devel] [PATCH 4/4] h264: use avpriv_request_sample for choma_format_idc

2014-02-16 Thread Vittorio Giovara
--- libavcodec/h264_ps.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 562e0a0..bc8acf4 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -339,9 +339,8 @@ int ff_h264_decode_seq_parameter_set(H264Context

Re: [libav-devel] [PATCH 1/4] h264: drop checks for unknown profiles

2014-02-16 Thread Vittorio Giovara
On Sun, Feb 16, 2014 at 11:14 PM, Luca Barbato lu_z...@gentoo.org wrote: On 16/02/14 23:08, Vittorio Giovara wrote: --- libavcodec/h264_ps.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) What happens to them? Well the decoder just skips portions of the sps where chroma

Re: [libav-devel] [PATCH 4/4] h264: use avpriv_request_sample for choma_format_idc

2014-02-16 Thread Vittorio Giovara
On Sun, Feb 16, 2014 at 11:53 PM, Diego Biurrun di...@biurrun.de wrote: On Sun, Feb 16, 2014 at 11:08:45PM +0100, Vittorio Giovara wrote: --- libavcodec/h264_ps.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ch_R_oma Amended, thanks. Vittorio

[libav-devel] [PATCH] h264: replace profile_idc checks with full profile name

2014-02-16 Thread Vittorio Giovara
Also document origin of unknown profiles and complete checks in ff_h264_decode_seq_parameter_set(). --- Revised patch, with added comments instead of removal. Vittorio libavcodec/h264.c | 10 +++--- libavcodec/h264_mb_template.c | 3 ++- libavcodec/h264_ps.c | 14

Re: [libav-devel] [PATCH 3/4] h264: deprecate very early unused profile

2014-02-16 Thread Vittorio Giovara
On Sun, Feb 16, 2014 at 11:15 PM, Luca Barbato lu_z...@gentoo.org wrote: On 16/02/14 23:08, Vittorio Giovara wrote: --- This profile got dropped in 2005, I think it should be not listed as supported profile. Vittorio Do we support it? We support it, as in we treat it like a normal high

[libav-devel] [PATCH] h264: document Picture pointers

2014-02-17 Thread Vittorio Giovara
--- After a chat with Janne and Anton (thanks for the explanation). Please correct me if I misunderstood Vittorio libavcodec/h264.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264.h b/libavcodec/h264.h index 69a46ca..bd05599 100644 ---

Re: [libav-devel] [PATCH] x86: dca: Add missing multiple inclusion guards

2014-02-18 Thread Vittorio Giovara
On Tue, Feb 18, 2014 at 2:30 PM, Diego Biurrun di...@biurrun.de wrote: --- libavcodec/x86/dca.h | 5 + 1 file changed, 5 insertions(+) Looks ok. Vittorio ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 3/4] h264: deprecate very early unused profile

2014-02-18 Thread Vittorio Giovara
On Tue, Feb 18, 2014 at 5:44 PM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Tue, Feb 18, 2014 at 3:19 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Mon, Feb 17, 2014 at 8:38 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Mon, Feb 17, 2014 at 12:06 AM, Vittorio Giovara

Re: [libav-devel] [PATCH 2/2] nut: experimental pipe and broadcast mode

2014-02-18 Thread Vittorio Giovara
On Tuesday, February 18, 2014, Luca Barbato lu_z...@gentoo.org wrote: --- doc/muxers.texi | 14 ++ doc/nut.texi| 21 + libavformat/avformat.h | 6 ++ libavformat/nut.h | 9 - libavformat/nutdec.c

[libav-devel] [PATCH] h264: add MVCD to the list of High profiles in SPS

2014-02-18 Thread Vittorio Giovara
Also comment all previous profiles. --- This should be safe enough for everyone, let me know if you'd prefer the commenting and the addition in two separate patches. Cheers, Vittorio libavcodec/h264_ps.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git

Re: [libav-devel] [PATCH] hevc: Mention the missing SPS in the error message

2014-02-18 Thread Vittorio Giovara
On Tue, Feb 18, 2014 at 11:56 PM, Luca Barbato lu_z...@gentoo.org wrote: --- libavcodec/hevc_ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index 0c1550e..c3aabe7 100644 --- a/libavcodec/hevc_ps.c +++

[libav-devel] [PATCH] vf_interlace: deprecate lowpass option

2014-02-18 Thread Vittorio Giovara
--- Updated patch with changes requested. Vittorio doc/filters.texi | 7 ++--- libavfilter/version.h | 5 +++- libavfilter/vf_interlace.c | 64 +- 3 files changed, 41 insertions(+), 35 deletions(-) diff --git a/doc/filters.texi

[libav-devel] [PATCH 1/2] h264: parse two additional constraint flags

2014-02-18 Thread Vittorio Giovara
--- libavcodec/h264_ps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index cc80f35..94efaa2 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -306,7 +306,9 @@ int ff_h264_decode_seq_parameter_set(H264Context *h)

[libav-devel] [PATCH 2/2] h264: update flag name in ff_h264_decode_ref_pic_list_reordering()

2014-02-18 Thread Vittorio Giovara
--- libavcodec/h264_refs.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index a0b8f45..57c0ff0 100644 --- a/libavcodec/h264_refs.c +++ b/libavcodec/h264_refs.c @@ -224,12 +224,12 @@ int

[libav-devel] [PATCH] h264: update flag name in ff_h264_decode_ref_pic_list_reordering()

2014-02-18 Thread Vittorio Giovara
--- Now updating the correct variable... Vittorio libavcodec/h264_refs.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index a0b8f45..78bb7c4 100644 --- a/libavcodec/h264_refs.c +++ b/libavcodec/h264_refs.c @@

Re: [libav-devel] [PATCH 2/2] h264: update flag name in ff_h264_decode_ref_pic_list_reordering()

2014-02-19 Thread Vittorio Giovara
On Wednesday, February 19, 2014, Luca Barbato lu_z...@gentoo.org wrote: On 19/02/14 03:28, Vittorio Giovara wrote: --- Now updating the correct variable... You did not explain why doing that... This one updates flags name in the modification list reordering part

Re: [libav-devel] [PATCH] bugreports: Make apparent where the bugtracker is

2014-02-19 Thread Vittorio Giovara
On Wednesday, February 19, 2014, Luca Barbato lu_z...@gentoo.org wrote: --- src/bugreports | 5 + src/contact| 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/bugreports b/src/bugreports index 3e3b9c3..6fc8305 100644 --- a/src/bugreports +++

Re: [libav-devel] [PATCH 1/4] vf_framepack: set AVStereo3D.flags to 0

2014-02-19 Thread Vittorio Giovara
On Wed, Feb 19, 2014 at 10:57 PM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Wed, Feb 19, 2014 at 9:06 PM, Anton Khirnov an...@khirnov.net wrote: Newly created side data is not zeroed. Why isn't it? Sounds like a problem to be repeated frequently, I remember this coming up before in some

Re: [libav-devel] [RFC] exporting replaygain and other similar metadata

2014-02-19 Thread Vittorio Giovara
On Wed, Feb 19, 2014 at 9:16 PM, Anton Khirnov an...@khirnov.net wrote: Hi, there have been requests recently for handling various metadata-like container properties, e.g. replaygain tags or mov rotation properties. This patchset proposes one way of dealing with this, specifically for

[libav-devel] [PATCH] h264: lower bound check for slice offsets

2014-02-19 Thread Vittorio Giovara
And use the value from the specification. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind --- libavcodec/h264.c| 18 ++ libavcodec/h264_loopfilter.c | 8 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/h264.c

Re: [libav-devel] [PATCH 4/9] {v, a}f_showinfo: print frame side data

2014-02-24 Thread Vittorio Giovara
On Wed, Feb 19, 2014 at 9:16 PM, Anton Khirnov an...@khirnov.net wrote: --- libavfilter/af_ashowinfo.c | 91 libavfilter/vf_showinfo.c | 54 ++ 2 files changed, 145 insertions(+) Nice, I'd recommend these tags for

Re: [libav-devel] [PATCH 2/2] parser: Remove commented-out cruft

2014-02-24 Thread Vittorio Giovara
On Mon, Feb 24, 2014 at 12:39 PM, Diego Biurrun di...@biurrun.de wrote: --- If this is OK I think I will reorder it to go in before the KR patch. libavcodec/parser.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) I think it's ok, I'd remove the /*/

Re: [libav-devel] [PATCH 1/2] parser: KR formatting cosmetics

2014-02-24 Thread Vittorio Giovara
On Mon, Feb 24, 2014 at 12:39 PM, Diego Biurrun di...@biurrun.de wrote: From: Luca Barbato lu_z...@gentoo.org Signed-off-by: Diego Biurrun di...@biurrun.de --- libavcodec/parser.c | 216 ++- 1 file changed, 111 insertions(+), 105

Re: [libav-devel] [PATCH] h264: update flag name in ff_h264_decode_ref_pic_list_reordering()

2014-02-24 Thread Vittorio Giovara
On Wed, Feb 19, 2014 at 3:28 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Now updating the correct variable... Vittorio libavcodec/h264_refs.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) ping Vittorio

Re: [libav-devel] [PATCH 1/2] h264: parse two additional constraint flags

2014-02-24 Thread Vittorio Giovara
On Wed, Feb 19, 2014 at 3:23 AM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/h264_ps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ping Vittorio ___ libav-devel mailing list libav-devel@libav.org https

[libav-devel] [PATCH 1/2] doc: name correct header

2014-02-24 Thread Vittorio Giovara
--- doc/APIchanges | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 48b925b..d6134f9 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -78,7 +78,7 @@ API changes, most recent first: Add ITU-R BT.2020 and other not yet included values

[libav-devel] [PATCH 2/2] doc: fix one accented word

2014-02-24 Thread Vittorio Giovara
--- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 02f772f..e74f917 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -1427,7 +1427,7 @@ a float number which specifies chroma temporal strength, defaults to

Re: [libav-devel] [PATCH] h264: document Picture pointers

2014-02-24 Thread Vittorio Giovara
On Mon, Feb 17, 2014 at 5:41 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- After a chat with Janne and Anton (thanks for the explanation). Please correct me if I misunderstood Vittorio libavcodec/h264.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ping

Re: [libav-devel] [PATCH] Move {get, put}_bits.h and mathops.h from lavc to lavu

2014-02-25 Thread Vittorio Giovara
On Tue, Feb 25, 2014 at 2:21 PM, Diego Biurrun di...@biurrun.de wrote: On Tue, Feb 25, 2014 at 03:02:31PM +0200, Martin Storsjö wrote: On Tue, 25 Feb 2014, Vittorio Giovara wrote: --- This was identified as one of the last remaining functions that interweaved lavc and lavf badly, so at our

[libav-devel] [PATCH] put_bits: reorder and move headers

2014-02-25 Thread Vittorio Giovara
--- put_bits does not use any mathops functions, but ac3 needs the header somewhere. Vittorio libavcodec/ac3enc_template.c | 2 ++ libavcodec/put_bits.h| 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c

Re: [libav-devel] [PATCH] [RFC] HEVC muxing in Matroska/MPEG-4.

2014-02-26 Thread Vittorio Giovara
On Wed, Feb 26, 2014 at 2:43 AM, Tim Walker tdskywal...@gmail.com wrote: libavformat/Makefile |4 +- libavformat/hevc.c| 1062 + libavformat/hevc.h| 29 ++ libavformat/isom.c|1 + libavformat/matroskaenc.c |

[libav-devel] [PATCH 1/2] vf_frei0r: prevent a segfault when filter parameters are not set

2014-02-27 Thread Vittorio Giovara
--- libavfilter/vf_frei0r.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index 0d0866a..31d28cd 100644 --- a/libavfilter/vf_frei0r.c +++ b/libavfilter/vf_frei0r.c @@ -139,6 +139,9 @@ static int set_params(AVFilterContext *ctx, const char

[libav-devel] [PATCH 2/2] vf_frei0r: refactor library loading

2014-02-27 Thread Vittorio Giovara
strtok_r is not needed any more, so remove it from configure. --- Still somewhat puzzled that av_get_token modifies the input string into TOKEN+STRING instead of just STRING. Anyway, here is the strtok_r free version. Vittorio configure | 6 ++ libavfilter/vf_frei0r.c | 19

[libav-devel] [PATCH] vf_frei0r: prevent a segfault when filter parameters are not set

2014-02-27 Thread Vittorio Giovara
--- I actually like this vesion more. Vittorio libavfilter/vf_frei0r.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index 8a70a8f..54af518 100644 --- a/libavfilter/vf_frei0r.c +++ b/libavfilter/vf_frei0r.c @@ -466,6 +466,10 @@ static

[libav-devel] [PATCH] vf_frei0r: adjust error messages

2014-02-27 Thread Vittorio Giovara
--- libavfilter/vf_frei0r.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index 54af518..42e09eb 100644 --- a/libavfilter/vf_frei0r.c +++ b/libavfilter/vf_frei0r.c @@ -81,7 +81,7 @@ static void

[libav-devel] [PATCH] vf_frei0r: refactor library loading from env variable

2014-02-27 Thread Vittorio Giovara
strtok_r is not needed any more, so remove it from configure. --- Minor edits in the comments and commit log. Should the configure part be in a separate patch? Vittorio configure | 6 ++ libavfilter/vf_frei0r.c | 19 +-- 2 files changed, 15 insertions(+), 10

[libav-devel] [PATCH] h264: fix clang warning about uninitialized variable

2014-02-28 Thread Vittorio Giovara
--- libavcodec/h264_refs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index 78bb7c4..ccdb49b 100644 --- a/libavcodec/h264_refs.c +++ b/libavcodec/h264_refs.c @@ -535,7 +535,7 @@ static int check_opcodes(MMCO *mmco1, MMCO

Re: [libav-devel] [PATCH 1/8] qt-faststart: Increase the copy buffer size to 64 KB

2014-02-28 Thread Vittorio Giovara
On Fri, Feb 28, 2014 at 11:29 AM, Martin Storsjö mar...@martin.st wrote: Copying data in chunks of 1 KB is a little wasteful. 64 KB should still easily fit on the stack, so there's no need to allocate it dynamically. --- tools/qt-faststart.c | 2 +- 1 file changed, 1 insertion(+), 1

[libav-devel] [PATCH 10/10] h264 does not depend on mpegvideo anymore

2014-03-01 Thread Vittorio Giovara
--- libavcodec/h264.c| 1 - libavcodec/h264.h| 3 ++- libavcodec/h264_cavlc.c | 1 - libavcodec/h264_direct.c | 1 - libavcodec/h264_loopfilter.c | 1 - libavcodec/h264data.h| 1 - 6 files changed, 2 insertions(+), 6 deletions(-) diff --git

[libav-devel] [PATCH 01/10] svq3: remove unused ff_draw_horiz_band code

2014-03-01 Thread Vittorio Giovara
first_field is always 0 and the code always return from that condition. --- libavcodec/svq3.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index fac95ee..afbddc7 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -1266,11 +1266,6 @@ static

[libav-devel] [PATCH 06/10] h264: remove MotionEstContext and save relevant fields

2014-03-01 Thread Vittorio Giovara
--- libavcodec/h264.c | 17 - libavcodec/h264.h | 8 +++- libavcodec/h264_mb_template.c | 12 ++-- 3 files changed, 21 insertions(+), 16 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 991819e..040bf81 100644 ---

[libav-devel] [PATCH 09/10] mpegvideo: remove h264-only fields

2014-03-01 Thread Vittorio Giovara
--- libavcodec/mpegvideo.h | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h index da64d79..5e04045 100644 --- a/libavcodec/mpegvideo.h +++ b/libavcodec/mpegvideo.h @@ -119,21 +119,8 @@ typedef struct Picture{

[libav-devel] [PATCH 05/10] h264: use private H264_MAX_THREADS

2014-03-01 Thread Vittorio Giovara
--- libavcodec/h264.c | 8 libavcodec/h264.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 09f36aa..991819e 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1195,7 +1195,7 @@ static void

[libav-devel] [PATCH 03/10] h264: move relevant fields from Picture to H264Picture

2014-03-01 Thread Vittorio Giovara
A new function is introduced to support ERPicture. --- libavcodec/dxva2_h264.c | 10 +++--- libavcodec/h264.c| 81 +--- libavcodec/h264.h| 55 ++-- libavcodec/h264_direct.c | 8 ++--- libavcodec/h264_refs.c

[libav-devel] [PATCH 00/10] H264 FREEDOM

2014-03-01 Thread Vittorio Giovara
macros. Finally the patch set cleans up most of Picture itself (removing like +10 integers!) and removes mpegvideo.h from h264. Oracle has been an invaluable asset for testing this set across platforms, and it is now all green. Cheers, Vittorio Vittorio Giovara (10): svq3

[libav-devel] [PATCH 02/10] er: move relevant fields from Picture to ERPicture

2014-03-01 Thread Vittorio Giovara
A new function is introuduced to keep compatibility across the code. --- libavcodec/error_resilience.c | 6 +++--- libavcodec/error_resilience.h | 21 ++--- libavcodec/h264.c | 6 +++--- libavcodec/mpegvideo.c| 35 ---

[libav-devel] [PATCH 07/10] mpegvideo: move PICT_* macros into picttype.h

2014-03-01 Thread Vittorio Giovara
Also adjust the headers as needed. --- libavcodec/dxva2_h264.c | 1 + libavcodec/dxva2_mpeg2.c | 1 + libavcodec/dxva2_vc1.c| 1 + libavcodec/h264.h | 1 + libavcodec/mpeg12dec.c| 1 + libavcodec/mpegvideo.c| 1 + libavcodec/mpegvideo.h

[libav-devel] [PATCH 08/10] mpegvideo: move MB_TYPE_* and IS_* macros to mbtype.h

2014-03-01 Thread Vittorio Giovara
Also adjust the headers as needed. --- libavcodec/error_resilience.c | 1 + libavcodec/h261dec.c | 1 + libavcodec/h261enc.c | 1 + libavcodec/h263.c | 1 + libavcodec/h264.h | 1 + libavcodec/ituh263dec.c | 1 + libavcodec/mbtype.h

[libav-devel] [PATCH 04/10] h264: use private H264_MAX_PICTURE_COUNT

2014-03-01 Thread Vittorio Giovara
--- libavcodec/h264.c| 22 +++--- libavcodec/h264.h| 2 ++ libavcodec/h264_ps.c | 2 +- 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 51db23b..09f36aa 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@

[libav-devel] [PATCH 2/2] put_bits: headers cleanup

2014-03-01 Thread Vittorio Giovara
--- libavcodec/ac3enc.h| 4 +++- libavcodec/dca.c | 4 +++- libavcodec/lzwenc.c| 3 ++- libavcodec/mjpeg.h | 3 ++- libavcodec/nellymoserenc.c | 6 -- libavcodec/put_bits.h | 7 +-- libavcodec/ra144enc.c | 3 ++- libavcodec/vorbisenc.c | 2

[libav-devel] [PATCH 1/2] mathops: move macro to the only place it is used

2014-03-01 Thread Vittorio Giovara
This helps in disentangling lavf and lavc too. --- libavcodec/mathops.h | 9 - libavformat/mpegts.c | 8 +++- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/mathops.h b/libavcodec/mathops.h index 6c216c2..0489a60 100644 --- a/libavcodec/mathops.h +++

Re: [libav-devel] [PATCH] ituh263: reject b-frame with pp_time = 0

2014-03-01 Thread Vittorio Giovara
On Sat, Mar 1, 2014 at 8:17 PM, Keiji Costantini stri...@gmail.com wrote: avoid division by 0 at ff_mpeg4_set_one_direct_mv Sample-Id: 0168-google Reported-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC: libav-sta...@libav.org --- libavcodec/ituh263dec.c | 2 ++ 1 file changed, 2

Re: [libav-devel] [PATCH] nut: Experimental pipe and broadcast mode

2014-03-01 Thread Vittorio Giovara
On Sat, Mar 1, 2014 at 11:51 AM, Luca Barbato lu_z...@gentoo.org wrote: --- Now with the version bump. doc/muxers.texi | 16 doc/nut.texi| 21 + libavformat/avformat.h | 6 ++ libavformat/nut.h | 9

Re: [libav-devel] [PATCH] ogg: check and propagate memory allocation failures as appropriate

2014-03-01 Thread Vittorio Giovara
On Sun, Feb 9, 2014 at 4:59 AM, Luca Barbato lu_z...@gentoo.org wrote: On 09/02/14 02:45, Vittorio Giovara wrote: On Sun, Jan 12, 2014 at 7:55 PM, Diego Biurrun di...@biurrun.de wrote: From: Sean McGovern gsean...@gmail.com Signed-off-by: Diego Biurrun di...@biurrun.de --- I fixed the bits

Re: [libav-devel] [PATCH] nut: Experimental pipe and broadcast mode

2014-03-01 Thread Vittorio Giovara
On Sat, Mar 1, 2014 at 11:32 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Sat, Mar 1, 2014 at 11:51 AM, Luca Barbato lu_z...@gentoo.org wrote: --- Now with the version bump. doc/muxers.texi | 16 doc/nut.texi| 21

  1   2   3   4   5   6   7   8   9   10   >