[Libguestfs] libnbd | Failed pipeline for master | c7cba557

2022-09-30 Thread GitLab
Pipeline #655593783 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: c7cba557 ( https://gitlab.com/nbdkit/libnbd/-/commit/c7cba557049160d8f00d34f341d372a34770161a ) Commit Message: lib: Avoid leak if

[Libguestfs] libnbd | Failed pipeline for master | 7e329735

2022-09-30 Thread GitLab
Pipeline #655541954 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 7e329735 ( https://gitlab.com/nbdkit/libnbd/-/commit/7e329735cef740bd9dbb7c0c08a2c4531f070086 ) Commit Message: generator: Mark

Re: [Libguestfs] [libnbd PATCH] RFC: generator: Mark APIs with allocator/deallocator semantics

2022-09-30 Thread Eric Blake
On Fri, Sep 30, 2022 at 05:27:00PM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 10:42:01AM -0500, Eric Blake wrote: > > Modern GCC has two related attributes for functions returning a > > pointer: > > > > __attribute__((__malloc__)) - this function returns a new pointer, not > >

Re: [Libguestfs] [libnbd PATCH] RFC: generator: Mark APIs with allocator/deallocator semantics

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 10:42:01AM -0500, Eric Blake wrote: > Modern GCC has two related attributes for functions returning a > pointer: > > __attribute__((__malloc__)) - this function returns a new pointer, not > aliased to any existing pointer > > __attribute__((__malloc__(fn,1))) - call

[Libguestfs] [libnbd PATCH] RFC: generator: Mark APIs with allocator/deallocator semantics

2022-09-30 Thread Eric Blake
Modern GCC has two related attributes for functions returning a pointer: __attribute__((__malloc__)) - this function returns a new pointer, not aliased to any existing pointer __attribute__((__malloc__(fn,1))) - call fn(return_value) to avoid leaking memory allocated by this function With those

Re: [Libguestfs] [p2v PATCH 2/2] dependencies.m4: add librsvg2

2022-09-30 Thread Richard W.M. Jones
For the series: Reviewed-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 04:39:48PM +0200, Laszlo Ersek wrote: > On 09/30/22 16:03, Daniel P. Berrangé wrote: > > > There are a bunch of users who want you to fully express all the optional > > deps, so they're guaranteed everything is installed by default. There are > > another bunch of users who

Re: [Libguestfs] [p2v PATCH 2/2] dependencies.m4: add librsvg2

2022-09-30 Thread Laszlo Ersek
On 09/30/22 16:52, Laszlo Ersek wrote: > librsvg2 provides a plugin for GDK-Pixbuf, so that GDK-Pixbuf can load & > render SVG images for GTK3, so that GTK3 can display the spinner for > virt-p2v's Test Connection button. > > Clearly, this dependency chain is so trivial that no part of it has

[Libguestfs] [p2v PATCH 2/2] dependencies.m4: add librsvg2

2022-09-30 Thread Laszlo Ersek
librsvg2 provides a plugin for GDK-Pixbuf, so that GDK-Pixbuf can load & render SVG images for GTK3, so that GTK3 can display the spinner for virt-p2v's Test Connection button. Clearly, this dependency chain is so trivial that no part of it has been necessary to codify in package metafiles.

[Libguestfs] [p2v PATCH 1/2] Makefile.am: rectify target dependencies on package dependency files

2022-09-30 Thread Laszlo Ersek
The targets whose recipes invoke "virt-p2v-make-disk" should depend on "$(dependencies_files)", and not "dependencies.m4". The reason is that "virt-p2v-make-disk" consumes the filtered / processed files, not the original dependency list. We have a separate rule that invokes m4 for generating

[Libguestfs] [p2v PATCH 0/2] fix the spinner widget in the Live environment

2022-09-30 Thread Laszlo Ersek
Recently we've made GTK3 the sole GTK option; with that, the spinner widget is not displayed in the Live environment any more, at least when said environment is built on Fedora 35. It turns out we've been missing an obscure dependency. Laszlo Laszlo Ersek (2): Makefile.am: rectify target

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 16:03, Daniel P. Berrangé wrote: > There are a bunch of users who want you to fully express all the optional > deps, so they're guaranteed everything is installed by default. There are > another bunch of users who want everything to be optional so they can > make the most minimalist

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 03:57:15PM +0200, Laszlo Ersek wrote: > On 09/30/22 15:35, Daniel P. Berrangé wrote: > > On Fri, Sep 30, 2022 at 03:23:31PM +0200, Laszlo Ersek wrote: > >> On 09/30/22 14:11, Richard W.M. Jones wrote: > >>> On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > >>

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 03:57:15PM +0200, Laszlo Ersek wrote: > This is the same terrible "push" (or "registration") model (rather than > the "pull") model that plagues systemd: if a kernel module is missing > from the initrd that's needed for driving a device or a filesystem, the > boot gets

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 15:35, Daniel P. Berrangé wrote: > On Fri, Sep 30, 2022 at 03:23:31PM +0200, Laszlo Ersek wrote: >> On 09/30/22 14:11, Richard W.M. Jones wrote: >>> On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: >> (2d) I started icewm with "icewm --replace" (as recommended by the

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 02:58:19PM +0200, Laszlo Ersek wrote: > On 09/30/22 13:52, Daniel P. Berrangé wrote: > > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > >> On 09/30/22 11:46, Daniel P. Berrangé wrote: > >>> On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote:

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 03:23:31PM +0200, Laszlo Ersek wrote: > On 09/30/22 14:11, Richard W.M. Jones wrote: > > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > > >> (2d) I started icewm with "icewm --replace" (as recommended by the error > >> message from (2c)), and lo and

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 14:11, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: >> (2d) I started icewm with "icewm --replace" (as recommended by the error >> message from (2c)), and lo and behold, two changes had come into effect: >> >> - the spinner started working

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 14:18, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 01:11:50PM +0100, Richard W.M. Jones wrote: >> - availability in RHEL > > This is really required, and moving icewm into RHEL isn't > something that is easy to negotiate. I'm not so sure it is really that much required;

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 14:11, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: >> On 09/30/22 11:46, Daniel P. Berrangé wrote: >>> On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: Hmm, here's an interesting stackoverflow posting ...

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 13:52, Daniel P. Berrangé wrote: > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: >> On 09/30/22 11:46, Daniel P. Berrangé wrote: >>> On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: Hmm, here's an interesting stackoverflow posting ...

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 01:11:50PM +0100, Richard W.M. Jones wrote: > icewm is available in RHEL 9. Actually as Dan says, this isn't true. I checked and it comes from EPEL: # dnf install icewm Updating Subscription Management repositories. Unable to read consumer identity This system is not

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 01:11:50PM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > > On 09/30/22 11:46, Daniel P. Berrangé wrote: > > > On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > > >> > > >> Hmm, here's an interesting

Re: [Libguestfs] [v2v PATCH] convert_linux: include the BOCHS DRM driver in the initial ram disk

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 02:04:44PM +0200, Laszlo Ersek wrote: > UEFI RHEL-7 guests cannot be successfully converted from VMWare without > including the BOCHS DRM driver -- Plymouth ("rhgb") crashes during early > boot in the converted domain. > > Bugzilla:

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 01:01:09PM +0200, Laszlo Ersek wrote: > Also I reckon Rich does not use metacity -- originally a gtk2-based > window manager -- on his laptop, but the gnome shell. gnome shell could > similarly eliminate the issue. (Assuming we agree that the issue is *in* > metacity.)

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > On 09/30/22 11:46, Daniel P. Berrangé wrote: > > On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > >> > >> Hmm, here's an interesting stackoverflow posting ... > >> > >>

[Libguestfs] [v2v PATCH] convert_linux: include the BOCHS DRM driver in the initial ram disk

2022-09-30 Thread Laszlo Ersek
UEFI RHEL-7 guests cannot be successfully converted from VMWare without including the BOCHS DRM driver -- Plymouth ("rhgb") crashes during early boot in the converted domain. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2131123 Signed-off-by: Laszlo Ersek --- convert/convert_linux.ml |

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 01:50:43PM +0200, Laszlo Ersek wrote: > On 09/30/22 13:01, Laszlo Ersek wrote: > > > ... meant to add: this has proved Daniel's point that the WM is > > extremely important. For the record, I use IceWM locally, so when I > > run virt-p2v "directly", on my workstation, and

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 12:56:40PM +0200, Laszlo Ersek wrote: > On 09/30/22 11:46, Daniel P. Berrangé wrote: > > On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > >> > >> Hmm, here's an interesting stackoverflow posting ... > >> > >>

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 13:01, Laszlo Ersek wrote: > ... meant to add: this has proved Daniel's point that the WM is > extremely important. For the record, I use IceWM locally, so when I > run virt-p2v "directly", on my workstation, and forward X11 over SSH, > the reason for me seeing the spinner in the GTK3

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 12:56, Laszlo Ersek wrote: > On 09/30/22 11:46, Daniel P. Berrangé wrote: >> On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: >>> >>> Hmm, here's an interesting stackoverflow posting ... >>> >>> https://stackoverflow.com/questions/3301023/gtk-spinner-not-appearing

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 11:46, Daniel P. Berrangé wrote: > On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: >> >> Hmm, here's an interesting stackoverflow posting ... >> >> https://stackoverflow.com/questions/3301023/gtk-spinner-not-appearing >> >> The first point is "Make sure librsvg is

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 11:04, Daniel P. Berrangé wrote: > On Fri, Sep 30, 2022 at 09:41:02AM +0100, Richard W.M. Jones wrote: >> On Fri, Sep 30, 2022 at 08:55:02AM +0100, Daniel P. Berrangé wrote: >>> On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: On Thu, Sep 29, 2022 at 04:47:34PM

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 10:33:02AM +0100, Richard W.M. Jones wrote: > > Hmm, here's an interesting stackoverflow posting ... > > https://stackoverflow.com/questions/3301023/gtk-spinner-not-appearing > > The first point is "Make sure librsvg is installed". librsvg is _not_ > installed in the

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
Hmm, here's an interesting stackoverflow posting ... https://stackoverflow.com/questions/3301023/gtk-spinner-not-appearing The first point is "Make sure librsvg is installed". librsvg is _not_ installed in the ISO. Laszlo, can you try building an ISO with this package explicitly added to the

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 10:04:27AM +0100, Daniel P. Berrangé wrote: > As an idea to debug it more, try using the GTK inspector > >$ GTK_DEBUG=interactive > > this will popup a second window, which lets you browse the > widget hierarchy, view properties, etc. This might let you > see

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Fri, Sep 30, 2022 at 09:41:02AM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2022 at 08:55:02AM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: > > > On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek wrote: > > > >

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/30/22 09:55, Daniel P. Berrangé wrote: > On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: >> On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek wrote: >>> http://lacos.interhost.hu/livecd-p2v-202209291608-gitc213ae00a337.iso >>> >>> (built at c213ae00a337) >>> >>>

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2022 at 08:55:02AM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: > > On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek wrote: > > > http://lacos.interhost.hu/livecd-p2v-202209291608-gitc213ae00a337.iso > > > > > >

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Daniel P . Berrangé
On Thu, Sep 29, 2022 at 07:12:15PM +0100, Richard W.M. Jones wrote: > On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek wrote: > > http://lacos.interhost.hu/livecd-p2v-202209291608-gitc213ae00a337.iso > > > > (built at c213ae00a337) > > > > sha256:

Re: [Libguestfs] another GTK3 regression...

2022-09-30 Thread Laszlo Ersek
On 09/29/22 20:12, Richard W.M. Jones wrote: > On Thu, Sep 29, 2022 at 04:47:34PM +0200, Laszlo Ersek wrote: >> http://lacos.interhost.hu/livecd-p2v-202209291608-gitc213ae00a337.iso >> >> (built at c213ae00a337) >> >> sha256: f3a149aeab0179213d74bb1eac30d5d6f807d4c9cf3a548667903d5434d5699a > > No