[Libreoffice-commits] .: basegfx/source

2012-02-15 Thread Thorsten Behrens
basegfx/source/tools/unotools.cxx | 113 +++--- 1 file changed, 58 insertions(+), 55 deletions(-) New commits: commit d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 Author: Thorsten Behrens tbehr...@suse.com Date: Wed Feb 15 11:25:57 2012 +0100 Fix fdo#45779 -

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - basegfx/source

2012-02-15 Thread Michael Stahl
basegfx/source/tools/unotools.cxx | 113 +++--- 1 file changed, 58 insertions(+), 55 deletions(-) New commits: commit 3c65e1fef5a4b4e41b4b3846712d7e76e94a34e8 Author: Thorsten Behrens tbehr...@suse.com Date: Wed Feb 15 11:25:57 2012 +0100 Fix fdo#45779 -

[Libreoffice-commits] .: tools/inc tools/source unusedcode.easy

2012-02-15 Thread Caolán McNamara
tools/inc/tools/string.hxx | 55 tools/source/string/strimp.cxx | 513 --- tools/source/string/tstring.cxx | 50 --- tools/source/string/tustring.cxx | 513 +++ unusedcode.easy | 19 - 5

[Libreoffice-commits] .: binfilter/inc

2012-02-15 Thread Caolán McNamara
binfilter/inc/bf_tools/string.hxx |6 -- 1 file changed, 6 deletions(-) New commits: commit 1807578ea9f2d5518244839d4607316b7455fb20 Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 15 10:05:42 2012 + lock in those ByteString gains so there's no back-sliding diff

[Libreoffice-commits] .: configure.in

2012-02-15 Thread Tor Lillqvist
configure.in | 53 + 1 file changed, 25 insertions(+), 28 deletions(-) New commits: commit c1f5475bd626849fe7a98cb8986219990a526ce3 Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Feb 15 13:06:04 2012 +0200 Do try to use ccache

[Libreoffice-commits] .: vcl/source

2012-02-15 Thread Tor Lillqvist
vcl/source/app/svmain.cxx |5 - 1 file changed, 5 deletions(-) New commits: commit 2185849852aa4cdf4d288d4bd01be44ebd3b4433 Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Feb 15 13:14:38 2012 +0200 Revert temporary and not properly ifdeffed Android stuff diff --git

[Libreoffice-commits] .: desktop/source

2012-02-15 Thread Tor Lillqvist
desktop/source/app/app.cxx | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) New commits: commit 12f689687e3017bfe9ffaf6bbc4593eb3ca21c2b Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Feb 15 13:22:50 2012 +0200 Ifdefify temporary (?)

[Libreoffice-commits] .: desktop/source

2012-02-15 Thread Stephan Bergmann
desktop/source/app/app.cxx | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) New commits: commit bebd171db7735e3063f4cbb15b78f5436dde Author: Stephan Bergmann sberg...@redhat.com Date: Wed Feb 15 13:16:52 2012 +0100 PLASMA_NOW fix diff --git

[Libreoffice-commits] .: 3 commits - scp2/source sw/source

2012-02-15 Thread Michael Stahl
scp2/source/ooo/file_ooo.scp| 14 -- sw/source/filter/ww8/ww8par.cxx |3 +-- 2 files changed, 5 insertions(+), 12 deletions(-) New commits: commit 9c4581a6b61c0836c3a44eaaf454b9ba560e937a Author: Michael Stahl mst...@redhat.com Date: Wed Feb 15 13:13:29 2012 +0100

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - scp2/source

2012-02-15 Thread Jan Holesovsky
scp2/source/ooo/file_ooo.scp | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) New commits: commit 78a5d35ec1907e4b5add1014801dbac992cee48e Author: Michael Stahl mst...@redhat.com Date: Wed Feb 15 13:13:29 2012 +0100 fdo#45530: scp2: java accessibilty bridge cleanup:

[Libreoffice-commits] .: basic/source

2012-02-15 Thread Caolán McNamara
basic/source/sbx/sbxdec.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit a62395237ed78f982ae74efe5ed8ad7834a2f95b Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 15 13:00:08 2012 + WaE: moaning about unintialized variables diff --git

[Libreoffice-commits] .: svtools/inc svtools/source unusedcode.easy vcl/inc vcl/source

2012-02-15 Thread Caolán McNamara
svtools/inc/svtools/imap.hxx|3 --- svtools/source/edit/svmedit.cxx |6 -- svtools/source/misc/imap.cxx| 18 -- unusedcode.easy |6 -- vcl/inc/ilstbox.hxx |1 - vcl/inc/image.h |1 -

[Libreoffice-commits] .: sw/inc sw/source

2012-02-15 Thread Miklos Vajna
sw/inc/doc.hxx |1 + sw/inc/index.hxx |1 + sw/inc/ndindex.hxx |1 + sw/inc/ndtxt.hxx |2 +- sw/inc/pam.hxx |2 ++ sw/source/core/inc/hffrm.hxx |2 ++ sw/source/core/inc/pagefrm.hxx |1 +

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - oox/source

2012-02-15 Thread Petr Mladek
oox/source/ole/axcontrol.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 636abb692afb818b797794ff14384aefe16a7ae2 Author: Noel Power noel.po...@novell.com Date: Mon Feb 13 14:50:09 2012 + handle imported picture attribute from MSO Dialog ( fdo#45995 )

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - toolkit/inc toolkit/source

2012-02-15 Thread Petr Mladek
toolkit/inc/toolkit/controls/controlmodelcontainerbase.hxx |1 toolkit/inc/toolkit/controls/dialogcontrol.hxx |4 + toolkit/inc/toolkit/controls/unocontrols.hxx | 13 +++ toolkit/source/controls/controlmodelcontainerbase.cxx | 25 ---

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - Repository.mk

2012-02-15 Thread Andras Timar
Repository.mk |3 +++ 1 file changed, 3 insertions(+) New commits: commit 4161ce76cd0fa7135d1f51fbe89a9118cdee94bf Author: Andras Timar ati...@suse.com Date: Wed Feb 15 15:12:21 2012 +0100 fix build on Windows diff --git a/Repository.mk b/Repository.mk index 3c2c93e..863024f 100644

[Libreoffice-commits] .: 10 commits - android/qa Library_merged.mk sal/Library_sal.mk sal/Module_sal.mk sal/textenc sc/CppunitTest_sc_filters_test.mk sc/qa solenv/gbuild vcl/source

2012-02-15 Thread Tor Lillqvist
Library_merged.mk |6 +++--- android/qa/desktop/Makefile|7 --- android/qa/sc/Makefile |9 + sal/Library_sal.mk | 17 + sal/Module_sal.mk

[Libreoffice-commits] .: sw/source

2012-02-15 Thread Miklos Vajna
sw/source/filter/rtf/rtffly.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 4c8307053e3003af6cef5056e36a650f19c8cdb3 Author: Cédric Bosdonnat cedric.bosdonnat@free.fr Date: Mon Jun 27 14:46:16 2011 + n#695479: Remove properties when removing empty fly frame

[Libreoffice-commits] .: sal/Library_sal.mk sal/Module_sal.mk sal/textenc

2012-02-15 Thread Tor Lillqvist
sal/Library_sal.mk |2 +- sal/Module_sal.mk |2 +- sal/textenc/textenc.cxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 17bcaca217523916188b28914f99bcfb12debc4b Author: Tor Lillqvist t...@iki.fi Date: Wed Feb 15 16:36:31 2012 +0200

[Libreoffice-commits] .: sal/Library_sal.mk sal/Module_sal.mk sal/textenc

2012-02-15 Thread Tor Lillqvist
sal/Library_sal.mk |2 +- sal/Module_sal.mk |2 +- sal/textenc/textenc.cxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 42422f2599220b678aa41c4aadeec28df113c3ec Author: Tor Lillqvist t...@iki.fi Date: Wed Feb 15 16:36:31 2012 +0200

[Libreoffice-commits] .: binfilter/bf_svtools

2012-02-15 Thread Stephan Bergmann
binfilter/bf_svtools/source/filter.vcl/filter/svt_sgvtext.cxx | 31 -- 1 file changed, 15 insertions(+), 16 deletions(-) New commits: commit b0035dae18266c4fd219b29dbc635497c0fa53ec Author: Stephan Bergmann sberg...@redhat.com Date: Wed Feb 15 15:38:04 2012 +0100 Adapted to

[Libreoffice-commits] .: sw/source

2012-02-15 Thread Miklos Vajna
sw/source/filter/rtf/rtffly.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9efe123eec58bcf14faa7e18c2625bdd0c420fb7 Author: Miklos Vajna vmik...@suse.cz Date: Wed Feb 15 15:47:20 2012 +0100 sw: SvxRTFItemStack has been changed to std::deque in the

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/source

2012-02-15 Thread Miklos Vajna
sw/source/filter/rtf/rtffly.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit a12a832280db27877c30ee177e9a079cd9c2eed9 Author: Cédric Bosdonnat cedric.bosdonnat@free.fr Date: Mon Jun 27 14:46:16 2011 + n#695479: Remove properties when removing empty fly frame

[Libreoffice-commits] .: configure.in

2012-02-15 Thread Tor Lillqvist
configure.in |1 + 1 file changed, 1 insertion(+) New commits: commit de9c3dcb769bc2df9abaefbae4f8ed90131176e0 Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Feb 15 17:01:14 2012 +0200 Set SOLARLIB for Android diff --git a/configure.in b/configure.in index 437da5f..18adc1b

[Libreoffice-commits] .: 5 commits - extensions/source sfx2/source svx/source ucb/source vcl/inc vcl/source

2012-02-15 Thread Caolán McNamara
extensions/source/scanner/scanwin.cxx |4 sfx2/source/appl/app.cxx |2 sfx2/source/appl/shutdowniconw32.cxx |2 svx/source/dialog/sendreportw32.cxx |2 ucb/source/ucp/odma/odma.h|4 vcl/inc/vcl/settings.hxx | 191

[Libreoffice-commits] .: 2 commits - desktop/source solenv/bin

2012-02-15 Thread Michael Meeks
desktop/source/app/app.cxx | 35 solenv/bin/modules/installer/copyproject.pm |3 ++ solenv/bin/modules/installer/exiter.pm |3 ++ solenv/bin/modules/installer/files.pm |5 +++- solenv/bin/modules/installer/logger.pm |

[Libreoffice-commits] .: filter/source framework/source package/source svl/source

2012-02-15 Thread Takeshi Abe
filter/source/config/cache/typedetection.cxx |4 ++-- framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx |2 +- framework/source/uiconfiguration/uiconfigurationmanager.cxx |2 +- package/source/xstor/xfactory.cxx

[Libreoffice-commits] .: 2 commits - sd/source

2012-02-15 Thread Thorsten Behrens
sd/source/ui/func/fuoltext.cxx |5 + sd/source/ui/view/outlview.cxx |6 -- 2 files changed, 1 insertion(+), 10 deletions(-) New commits: commit 57e6f04066cfddfa79eb2b79cf5c45653c79eff3 Author: Thorsten Behrens tbehr...@suse.com Date: Wed Feb 15 16:51:52 2012 +0100 Fix

[Libreoffice-commits] .: package/source

2012-02-15 Thread Caolán McNamara
package/source/zipapi/Deflater.cxx |8 package/source/zipapi/Inflater.cxx |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 372a0d505c722fd8b39cf4f65487e7f08049896b Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 15 16:02:47 2012 +

[Libreoffice-commits] .: 2 commits - package/source zlib/zlib-1.2.3.patch zlib/zlib-valgrind.patch

2012-02-15 Thread Caolán McNamara
package/source/zipapi/CRC32.cxx | 12 +--- zlib/zlib-1.2.3.patch | 103 zlib/zlib-valgrind.patch| 78 -- 3 files changed, 3 insertions(+), 190 deletions(-) New commits: commit

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - Repository.mk

2012-02-15 Thread Jan Holesovsky
Repository.mk |1 + 1 file changed, 1 insertion(+) New commits: commit d532c1d111f76a581af6d3d1ccbeca7940bdb840 Author: Jan Holesovsky ke...@suse.cz Date: Wed Feb 15 17:55:45 2012 +0100 Fix Windows build. Signed-off-by: Petr Mladek pmla...@suse.cz diff --git a/Repository.mk

[Libreoffice-commits] .: bridges/source

2012-02-15 Thread Jani Monoses
bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 4e679ee2501a0babcdce498732d68428d46481e3 Author: Jani Monoses j...@ubuntu.com Date: Fri Feb 3 22:11:08 2012 +0200 Simplify code and use proper register

[Libreoffice-commits] .: bridges/source

2012-02-15 Thread Jani Monoses
bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx | 49 -- 1 file changed, 20 insertions(+), 29 deletions(-) New commits: commit a55fa2d0a8f709bd58e2729b66fd8ecc807c0286 Author: Jani Monoses j...@ubuntu.com Date: Wed Feb 8 21:23:50 2012 +0200 Remove unnecessary

[Libreoffice-commits] .: 2 commits - editeng/inc editeng/source

2012-02-15 Thread Ivan Timofeev
editeng/inc/editeng/forbiddencharacterstable.hxx | 27 +--- editeng/source/misc/forbiddencharacterstable.cxx | 50 +-- editeng/source/uno/UnoForbiddenCharsTable.cxx|7 +-- 3 files changed, 27 insertions(+), 57 deletions(-) New commits: commit

[Libreoffice-commits] .: sc/source

2012-02-15 Thread Kohei Yoshida
sc/source/ui/docshell/docfunc.cxx | 100 -- sc/source/ui/inc/docfunc.hxx |4 - sc/source/ui/inc/viewfunc.hxx |2 sc/source/ui/view/cellsh.cxx | 57 - sc/source/ui/view/viewfun2.cxx|4 - 5 files changed, 124

[Libreoffice-commits] .: svtools/source

2012-02-15 Thread Stephan Bergmann
svtools/source/misc/imap2.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 715ac8c1b402e33930317a69bbdd61ad88133740 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Feb 15 21:55:57 2012 +0100 Fixed some more apparent misuses of

[Libreoffice-commits] .: 4 commits - dbaccess/Module_dbaccess.mk sc/Module_sc.mk sc/qa test/inc test/source

2012-02-15 Thread Markus Mohrhard
dbaccess/Module_dbaccess.mk|6 +- sc/Module_sc.mk|1 + sc/qa/extras/scdatabaserangeobj.cxx|6 -- sc/qa/unit/filters-test.cxx|2 +- test/inc/test/sheet/xdatabaserange.hxx |2 ++ test/source/sheet/xdatabaserange.cxx |

[Libreoffice-commits] .: 2 commits - l10ntools/source sal/inc

2012-02-15 Thread Stephan Bergmann
l10ntools/source/srclex.l |1 + sal/inc/rtl/string.hxx| 16 sal/inc/rtl/ustring.hxx | 25 + 3 files changed, 42 insertions(+) New commits: commit 3ac780d8a2f8d1b94e9b4776d7f556274d3197dc Author: Stephan Bergmann sberg...@redhat.com Date:

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Stephan Bergmann
On 02/14/2012 02:33 PM, Michael Meeks wrote: On Tue, 2012-02-14 at 23:07 +1030, Josh Heidenreich wrote: What is the markup format to be used in the READMEs? It's a loose copy of the wikimedia syntax used in the wiki, so: - Paragraphs are separated by a blank line. - Headings are in the form

Re: [ANN] Referencing bugs in commits

2012-02-15 Thread Pierre-André Jacquod
hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean title line or would it works also as first line of

input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, I have quickly investigated the crash in fdo#45779 when saving an impress document. The reason of the crash is in basegfx/inc/basegfx/point/b2dpoint.hxx (line 82) where this is called: 2DPoint::B2DPoint (this=0xbfffc850, rPoint=...) : B2DTuple(rPoint) (from back-trace) It

Re: one-big library approach of mozilla ...

2012-02-15 Thread Taras Glek
On 2/14/2012 4:24 AM, Michael Meeks wrote: Hi Taras, We're running into some fun performance development iteration problems with LibreOffice as we plan to merge more libraries together; and I was wondering - how does Mozilla deal with that ? How long does it take your

Re: [Libreoffice-commits] Remove unused VolumeDevice functions and related code

2012-02-15 Thread Francois Tigeot
On Tue, Feb 14, 2012 at 06:18:52PM +0100, Stephan Bergmann wrote: On 02/05/2012 09:52 PM, François Tigeot wrote: Remove unused VolumeDevice functions and related code [...] diff --git a/sal/util/sal.map b/sal/util/sal.map index 472ea8f..338854d 100644 --- a/sal/util/sal.map +++

Re: poor little bug

2012-02-15 Thread Cedric Bosdonnat
On Tue, 2012-02-14 at 20:06 +0100, Luc Castermans wrote: I'm this poor little bug left alone in the corner. When will I be solved ? Feel free to have a look at the code! You seem to forget that I already spent days for a first fix that improves the situation. That's not the way I was told to say

Re: No page and Columns boundaries in 3.5

2012-02-15 Thread Cedric Bosdonnat
That was a design choice that was started long ago in the OpenOffice.org times, discussed at least lively with Christoph Noack (and most probably on the ux-advise list) a few months ago... I don't really like being asked to get some different feature back right after the release when people have

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Thorsten Behrens
Stephan Bergmann wrote: I wonder whether there's not some package to translate one of those newfangled lightweight markups into HTML which could be reused here? Sure - e.g. http://search.cpan.org/~rwstauner/Pod-Markdown-1.20/lib/Pod/Markdown.pm or http://pypi.python.org/pypi/Markdown

Re: [Libreoffice-commits] Remove unused VolumeDevice functions and related code

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 09:05 +0100, Francois Tigeot wrote: I may have been a bit too enthusiastic with sal.map; feel free to add the entries back if you think they are needed. Heh - so, we should of course leave the functions there so linking continues to work, but have dummy

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Michael Meeks
On Tue, 2012-02-14 at 23:01 +0100, Stephan Bergmann wrote: On 02/14/2012 10:39 PM, Josh Heidenreich wrote: Do we need licence blocks in a README? Can we just write the licence in on all pages generated by the script? My (naive?) take on it is that, technically, all the files committed to

Re: .: bin/get-bugzilla-attachments-by-mimetype

2012-02-15 Thread Michael Stahl
On 21/11/11 11:18, Caolán McNamara wrote: On Mon, 2011-11-21 at 02:04 +0100, Miklos Vajna wrote: On Mon, Nov 14, 2011 at 02:37:07AM -0800, Caolán McNamara cao...@kemper.freedesktop.org wrote: add script to download documents from various bugzillas i've pimped it a bit and it can now

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Thorsten Behrens
Pierre-André Jacquod wrote: B2DTuple(const B2DTuple rTup) ... Here you dereference the null pointer, which crash. Ok, the basic attitude would be to let B2DTuple be Null-pointer consistent: (checking that rTup is not NULL), but is it really a good idea? Hi Pierre-André, no, what's

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-15 Thread Caolán McNamara
On Tue, 2012-02-14 at 12:01 +, Caolán McNamara wrote: On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: Yes, I found that java code (the HelpIndexer I refer to). I'll work on a patch to replace the XInvocations of the Java code with calls to my code. I can try and

Re: .: bin/get-bugzilla-attachments-by-mimetype

2012-02-15 Thread Caolán McNamara
On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: that's the only thing that's still missing... should i file an easy hack? :) Indeed, that probably makes sense. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED-3-5] fdo#45995 fdo#45992

2012-02-15 Thread Noel Power
On 14/02/12 19:17, Petr Mladek wrote: It did not work because the test document used linked picture. It works well with the updated test document. The changes look reasonable. They work well = I have pushed them into the 3-5 branch, see

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Thorsten Behrens
Or should I look higher in the hierarchy, saying that a NULL point in a B2DPolygon has nothing to do and disallow it ? Yes, the calling code somehow accesses invalid elements. Let me have a look. Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to

[REVIEW-3-5] Fix for fdo#45779

2012-02-15 Thread Thorsten Behrens
Hi there, could someone please review cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 for -3-5? TIA, -- Thorsten pgpMmILR9mq7a.pgp Description: PGP signature ___ LibreOffice mailing list

Re: No page and Columns boundaries in 3.5

2012-02-15 Thread Tommy
On Tue, 14 Feb 2012 19:16:56 +0100, Fernand Vanrie s...@pmgroup.be wrote: On the user lists the first complaints about no page and column boundaries for LO Writer 3.5 are comming in. For some documents the new corner layout can be helpfull but without visible page and column boundaries it

Re: linking performance

2012-02-15 Thread Michael Stahl
On 14/02/12 13:30, Mark Wielaard wrote: Hi, Added Tom to the CC, see thread here: http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/24055/focus=24096 (Although it seems posts from non-subscribers, aka me, are not allowed, so you won't see my earlier reply there. I'll

Re: README.cross patch [REJECTED]

2012-02-15 Thread Tor Lillqvist
Ther autogen.lastrun samples in README.cross are *examples*. If should be obvious that: --with-android-ndk=/home/tml/android-ndk-r7 is an example and not to be used literally. Replacing it with --with-android-ndk= Location of ndk download doesn't really help much. Especially as ndk download

[PUSHED] Re: [REVIEW-3-5] Fix for fdo#45779

2012-02-15 Thread Michael Stahl
On 15/02/12 11:32, Thorsten Behrens wrote: Hi there, could someone please review cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 for -3-5? hmm.. dividing by 0 considered harmful indeed

[REVIEW] fdo#45553 fix RTF import of space-before/after tokens

2012-02-15 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=c32b9cd2139249f0c680f664a0ceac3702dd0e73 Could someone review and cherry-pick to -3-5, please? Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-15 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v St 15. 02. 2012 v 07:27 +0100: Pushed that, thank you a lot for that! http://cgit.freedesktop.org/libreoffice/core/commit/?id=80a72c4cc7edc6b4c0b88d841500617cd733cbf7 Kendy To my horror the behaviour of the pushed patch is not identical to the patch I

[PUSHED] Turn on strictures for some installer Perl modules

2012-02-15 Thread Michael Meeks
Hi Tim ! On Tue, 2012-02-14 at 23:02 +, Tim Retout wrote: I'd like to try to clean up some of the code in the solenv Perl modules Cool ! it is long overdue. - as a first task, I want to turn on 'use strict', which I'd consider a bare minimum for maintainable Perl. Longer-term,

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-15 Thread Winfried Donkers
Kendy wrote (15-02-2012 12.34) I only changed some (leading) tabs to spaces, it should not affect anything. But to be sure, just take the patch from git and diff it with your patch that works for you, and look at the differences. I thought so, but you never know. Thanks for checking. should I

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Tor Lillqvist
On 14 February 2012 19:23, Tor Lillqvist t...@iki.fi wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm, I experimented with this but apparently didn't commit and then did a git reset and lost the changes, or something. Will have a look again if I still have the

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-15 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v St 15. 02. 2012 v 13:15 +0100: should I revert the patch in the meantime? I understood from Markus Mohrhard that Tor had fixed the git/qa problem. I intend to look into it later this afternoon (UTC); I don't think reverting the patch is necessary, it's

connectivity::ORowSetValue cleanup and behaviour

2012-02-15 Thread Lionel Elie Mamane
Hi, The connectivity contains a ORowSetValue class, to hold a database value, along with its type. Obviously this class is used all over the place in our database-related code. I'm itching to change it in non-trivial ways, and I've hit some WTFs, so I thought I'd check if someone knows a good

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Matúš Kukan
On 15 February 2012 13:35, Tor Lillqvist t...@iki.fi wrote: On 14 February 2012 19:23, Tor Lillqvist t...@iki.fi wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). Hmm, I experimented with this but apparently didn't commit and then did a git reset and lost the

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-15 Thread Caolán McNamara
On Tue, 2012-02-14 at 22:27 +0100, Gert van Valkenhoef wrote: 1. how to convert the rtl::UOString to the TCHAR* that CLucene needs. 2. In xmlhelp/source/cxxhelp/provider/makefile.mk, I've hacked the include path to include l10ntools/source/help Attached patch hopefully basically takes care

[PUSHED 3-5] Re: [REVIEW][3-5] Re: Bug 45530 - Accessibility does not work

2012-02-15 Thread Jan Holesovsky
Hi Michael, Michael Stahl píše v St 15. 02. 2012 v 13:35 +0100: please somebody review and backport the following to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=fbe60c962259ae0449acd65e74fd790530045e93

Re: [PUSHED][PATCH] unusedcode.easy: Removed unused code

2012-02-15 Thread Caolán McNamara
On Fri, 2012-02-10 at 17:39 +0100, Alexander Bergmann wrote: --- editeng/source/editeng/editdoc.cxx |8 editeng/source/editeng/editdoc.hxx |1 - pushed this now, thanks for this. C. ___ LibreOffice mailing list

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Tor Lillqvist
It was something more than this: ? Umm, no, that was it. Now I am confused, why don't I see that in my master checkout after merging the branch to master? Git is a mystery. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Lionel Elie Mamane
On Wed, Feb 15, 2012 at 01:46:55PM +0100, Philipp Weissenbacher wrote: So, any developer wishes on what to translate next? In general, dbaccess/ and connectivity/ are the two modules of particular interest to me. I get the impression I'll have to dig into forms/ in the next months, just today,

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Stephan Bergmann
On 02/14/2012 06:23 PM, Tor Lillqvist wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, to reduce the overall number of dynamic libraries. But for other

Re: [PUSHED] Remove unused methods from PDFI

2012-02-15 Thread Michael Meeks
On Mon, 2012-02-13 at 19:48 +, Kate Goss wrote: I'm also contemplating tackling bugs in bugzilla assistant, if that would be helpful. Oh ! cool :-) yes very much so, Rainer has a number of tweaks and issues in there queued up for fixing if I remember correctly, it'd be just lovely

Re: [PATCH] [PUSHED] Translate German comments - final patch

2012-02-15 Thread Stefan Knorr (Astron)
Hi, pushed this with minor modifications. Thanks a lot for your work, Philipp! I hope you weren't already on this, Lionel... if yes, sorry. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PUSHED] Re: [PATCH] Help - minor updates

2012-02-15 Thread Jan Holesovsky
Hi Stanislav, Radek Doulik píše v Út 14. 02. 2012 v 17:53 +0100: Makes sense, thanks for clarification. Pushed. (master and 3-5 branches) Marking the thread as [PUSHED] :-) BTW - it is great that you are working on the help! Do you want to continue? I think some of the new 3.5 features

Re: changes in profile path in release notes for 3.5

2012-02-15 Thread Cor Nouws
Stephan Bergmann wrote (13-02-12 10:06) Introduced with http://cgit.freedesktop.org/libreoffice/core/commit/?id=9276f7d5740a28b342db2a9bcd8644ff2f4f5742 fdo#32263; should affect all Linux desktops. Thanks for the info, Stephan, -- - Cor - http://nl.libreoffice.org

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 13:46 +0100, Philipp Weissenbacher wrote: Find attached the patch that finalises my efforts to get rid of the German comments in sw/source/core/doc. Wonderful ! :-) Thanks Michael BTW for the mention in your Easy Hacks talk at FOSDEM. Much appreciated!

Re: connectivity::ORowSetValue cleanup and behaviour

2012-02-15 Thread Lionel Elie Mamane
On Wed, Feb 15, 2012 at 01:55:34PM +0100, Lionel Elie Mamane wrote: 2) Signed integers and unsigned integers never compare equal. But an unsigned integer compares equal to the corresponding float... Errr... They obviously should? I misread the code... Need coffee. integers never

[REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-15 Thread Stephan Bergmann
As per https://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python causes crash the master commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b1be1ce0e0ac7b34c4b73d53f4bf32ec5df7290 Reintroduce pyuno.so wrapper around libpyuno.so should please be

Re: [PUSHED] Code removal, first contribution

2012-02-15 Thread Jan Holesovsky
Hi Catalin Catalin Iacob píše v Po 13. 02. 2012 v 22:09 +0100: So it sounds like you did an excellent job; what's next ? an easy hack perhaps ? or more unused code ? :-) It would be cool to try an easy hack If you haven't chosen yet, the Easy Hack landing page is here:

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Philipp Weissenbacher
On 15 February 2012 14:56, Michael Meeks michael.me...@suse.com wrote: So, any developer wishes on what to translate next?        Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Luc Castermans
2012/2/15 Philipp Weissenbacher p.weissenbac...@gmail.com: On 15 February 2012 14:56, Michael Meeks michael.me...@suse.com wrote: So, any developer wishes on what to translate next?        Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Nicolas Christener
Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Nicolas Christener
Hi On Wed, 2012-02-15 at 13:56 +, Michael Meeks wrote: [...] So, any developer wishes on what to translate next? Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 03:11 PM, Tor Lillqvist wrote: I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? I wasn't sure about the status of --enable-mergelibs,

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Tor Lillqvist
I wasn't sure about the status of --enable-mergelibs, whether it is only something Android-specific or whether it is also used to enable that general merge/LTO endeavor. I don't know either, really. But anyway, I will make the sal_textenc+sal merge Android-specific and not mergelibs-specific;)

[PATCH] Translate German comments

2012-02-15 Thread Philipp Weissenbacher
Hi all, Lionel, Here are the files you mentioned earlier. Hope quality didn't suffer with this quick job. You might want to take a look at line num 2185 in DatabaseForm.cxx. Looks like commented out code. If you still find any German strings, please contact me and I'll help you. Cheers,

[PUSHED] Re: [PATCH] Remove unused code

2012-02-15 Thread Jan Holesovsky
Just adding [PUSHED] :-) Radek Doulik píše v Út 14. 02. 2012 v 19:03 +0100: Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy

Re: [PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

2012-02-15 Thread Noel Grandin
Hi Updated patch implementing Ivan's suggestion. Passes make and make check. Convert tools/table.hxx usage in editeng/inc/editeng/forbiddencharacterstable.hxx to std::map Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel. On

JRE warning on startup ...

2012-02-15 Thread Michael Meeks
Hi guys, There have been a number of complaints about JRE's being required during install, with the infamous and horribly unpleasant: LibreOffice requires a Java runtime environment (JRE) to perform this task. Please install a JRE and restart LibreOffice

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Philipp Weissenbacher
      Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will provide patches in a few days :) So I think we'll wait for that,

Re: [PATCH] SwDocStub now prints out parameters

2012-02-15 Thread Markus Mohrhard
Hey, thanks a lot for your great work here. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Translate German comments - final patch

2012-02-15 Thread Luc Castermans
2012/2/15 Philipp Weissenbacher p.weissenbac...@gmail.com:       Cedric was giving a personal plea for sw/source/core/layout/ which he wrestles with daily, is non-obvious code, and packed with impenetrable German ;-) ~2700 detected lines in there .. I'm already working on this and will

Re: JRE warning on startup ...

2012-02-15 Thread Caolán McNamara
On Wed, 2012-02-15 at 15:13 +, Michael Meeks wrote: Since we switched ~everything to passive registration, I believe this comes from the bundled extension help indexing on very-first-start. So, if its the case that its from extension help indexing, then this would probably be from

javadep.c Java 7

2012-02-15 Thread Ivan Timofeev
Hi, I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant pool entries, but... javadep.c:520:

RE: qa-build errros on clean code

2012-02-15 Thread Winfried Donkers
Tor already fixed it and after a pull you should be able to build. (http://cgit.freedesktop.org/libreoffice/core/commit/?id=49a4b4c32bda86b97ef48d1d2ce9bf8f02d3e2e3) Hope that your next build succeeds. Markus No such luck :( After git pull -r, the first clean build went ok, but the next build

more (caligra) test files ...

2012-02-15 Thread Michael Meeks
On Wed, 2012-02-15 at 10:15 +, Caolán McNamara wrote: On Wed, 2012-02-15 at 11:06 +0100, Michael Stahl wrote: that's the only thing that's still missing... should i file an easy hack? :) Indeed, that probably makes sense. If we're doing this systematically, we should prolly

Re: poor little bug

2012-02-15 Thread Michael Meeks
On Tue, 2012-02-14 at 20:06 +0100, Luc Castermans wrote: I'm this poor little bug left alone in the corner. When will I be solved ? This is in pretty poor taste, and doesn't belong on the developers list - which is for discussion of constructive development: hacking on fixes, code

Re: qa-build errros on clean code

2012-02-15 Thread Riccardo Magliocchetti
Hi Winfried, Il 15/02/2012 16:30, Winfried Donkers ha scritto: Value: 8 33formel: =A1+B1 3 ucalc.cxx:2924:Assertion Test name: N12_GLOBAL__N_14TestE::testPostIts assertion failed - Expression: m_pDoc-GetNote(rAddr) == NULL - note hasn't moved Any suggestions? I have this very same failure

  1   2   3   4   >