Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-08 Thread Norbert Thiebaud
I've had some success with the attached modifed version of you patch

Norbert


mesa.modified.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] convert Mesa to gbuild

2011-09-08 Thread Norbert Thiebaud
On Thu, Sep 8, 2011 at 1:03 AM, Norbert Thiebaud nthieb...@gmail.com wrote:
 I've had some success with the attached modifed version of you patch

btw Peter,

I ran a quick test on a Linux box that has SYSTEM_MESA_HEADERS=NO  ..
it would be nice to test that the case SYSTEM_MESA_HEADER=YES is not
borked...
If that work for you, feel free to re-submit a proper consolidated patch...
I am not in a position to (safely) push anything right now (tinderbox
issues), but I'm sure Bjoern or someone else will push it...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] LibreOffice website - maintainer required?

2011-09-08 Thread Norbert Thiebaud
On Thu, Sep 8, 2011 at 12:54 AM, Josh Heidenreich
josh.sickm...@gmail.com wrote:
 Hi All,

 As some people may have noticed, I have done a little bit of work in
 LibO recently, and submitted a few patches.

 Just a quick question. Is there currently a maintainer of the LibO website?

 I ask because while I do C/C++ programming as a hobby, my occupation
 involves wbesite programming using PHP/Javascript/CSS etc. It also
 involves some design work, and I am offering my skills and expertise
 in this area, if it's wanted, to improve and maintain the LibreOffice
 website.

Josh, you want to go there:
http://www.libreoffice.org/get-involved/web-administrators/

and join the website mailing list (there is a link on the page above.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Stephan Bergmann

On 09/08/2011 01:44 AM, Eike Rathke wrote:

Hi Korrawit,

On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote:


Attached patch will clear the cppcheck warning for duplicate
expression on both sides of ''.


Yup, good catch!
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a58ed493e572fef2c503bd329e924bb062ba9c96

Thanks
   Eike


Korrawit, Eike, did you check the context to verify that it should 
really read


  a.nChar1 == a.nChar2

instead of

  a.nChar1 == b.nChar1

in the second term of


(a.nChar1  b.nChar1) || ((a.nChar1 == a.nChar2)  (a.nChar2  b.nChar2))


?  Somehow, that expression still looks suspicious.  (At least, it does 
not implement a lexicographical less-than relation.  Not sure whether it 
should or not, however.)


-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Stephan Bergmann

On 09/08/2011 08:18 AM, Stephan Bergmann wrote:

On 09/08/2011 01:44 AM, Eike Rathke wrote:

Hi Korrawit,

On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote:


Attached patch will clear the cppcheck warning for duplicate
expression on both sides of ''.


Yup, good catch!
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a58ed493e572fef2c503bd329e924bb062ba9c96


Thanks
Eike


Korrawit, Eike, did you check the context to verify that it should
really read

a.nChar1 == a.nChar2

instead of

a.nChar1 == b.nChar1

in the second term of


(a.nChar1  b.nChar1) || ((a.nChar1 == a.nChar2)  (a.nChar2 
b.nChar2))


? Somehow, that expression still looks suspicious. (At least, it does
not implement a lexicographical less-than relation. Not sure whether it
should or not, however.)


Now actually looking at the context:  Given that CmpKernData in 
vcl/source/gdi/outdev3.cxx is (only) used as an argument to std::sort, 
I'm pretty sure it must read (a.nChar1 == b.nChar1) to make that a true 
strict weak ordering, as required by std::sort.  Pushed as 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b7978c822b11c53b4bd40bb0829e3ec205f1359.


-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files

2011-09-08 Thread Harald Kagerer
Hi,

 
 Hyperlinks in theese two location was wrong (as I already explaind in
 the bugreport):
 gsf cat buggy.doc WordDocument  # (I guess this is where FormFields are 
 located)
 gsf cat buggy.doc Data
 
 This was right:
 gsf cat buggy.doc DocumentSummaryInformation
 
 And that's what your patch is using. If LibreOffice would use anything
 else for this docs, it would be wrong. So if you change it again, I
 can not use it.
 
 Harald, can you confirm that this patch fixes the problem for your docs too?
 


I would like to confirm, that Knut's patch would solve a serious problem
we have to face at the Munic Limux Project converting *.doc documents
with hyperlinks to ODF. At the moment our only workaround is to use the
MSO buildin converter :-(  I really would prefer to use LO for this task
as soon as possible!!! 

Greetings

Harald Kagerer



-- 
Harald Kagerer har...@binder-kagerer.de

PGP
Key-ID: 0xB2792619
Fingerprint: 8763 31EA 65F8 D4BB 3501 E8D3 2728 CF77 B279 2619

()
/\



signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Nouvelles Astuces Pratiques semaine 36

2011-09-08 Thread Astuces Pratiques


Astuces Pratiques 

Vous recevez notre newsletter tous les mois en vous inscrivant à notre newsletter vous recevrez une newsletter toutes les semaines avec désinscription possible tous les semaines. N’hésitez pas envoyer l'email d'inscription à webmaster.netpratique-subscr...@domeus.fr sans rien n'y ajouter. Vous avez un ebook ou un site à promouvoir contactez nous àwebmaster.netprati...@laposte.net nous avons des solutions à bas prix ou gratuites.
Dépasser vos limites ebook gratuit 
E-book gratuit : Se protéger des champs électromagnétiques 
" Découvrez les Pires Erreurs à ne Pas Faire avec Google Adwords et Comment Obtenir 10 X Plus de Clics Ciblés... pour Moins Cher ! " 
Votre Chien Est-Il Entrain De Vous Rendre Fou? Les Secrets Du Dressage De Chien 
Faire du sport à la maison facilement avec ces 5 conseils. 
5 astuces pour une rentrée réussie 
Chaussures de sport : 6 conseils pour en changer
8 trucs faciles pour changer son alimentation en douceur 
Enceinte en été : 4 conseils
Dix astuces pour surfer en toute sécurité en vacances 
7 conseils pour aider son enfant à apprendre à lire. 
Découvrez l’Auto-Hypnose Le ebook gratuit destiné aux personnes qui veulent changer 
e-book gratuit : Débuter avec le Feng shui 
MINCIR AVEC PLAISIR - PERDEZ 7 KILOS EN 2 MOIS ! 
Les promos de la semaine 

Bonne lecture

Se désinscrire en envoyant l'email juste aprés avoir cliquer. Il y a eu un problème avec les désinscriptions passeés nous nous en excusons

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Background image in Mac 343 installer image disappeared ?

2011-09-08 Thread Alexander Thurgood
Hi all,

Just a heads up, haven't checked yet whether there's an fdo number for
this, but has anyone noticed that the TDF background image that used to
display in the Mac DMG is no longer there ?

Should I open an issue ?

I might add that this is also currently the case for the daily builds
from master.


Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Background image in Mac 343 installer image disappeared ?

2011-09-08 Thread Alexander Thurgood
Le 08/09/11 09:29, Alexander Thurgood a écrit :


 Just a heads up, haven't checked yet whether there's an fdo number for
 this, but has anyone noticed that the TDF background image that used to
 display in the Mac DMG is no longer there ?
 
 Should I open an issue ?
 
 I might add that this is also currently the case for the daily builds
 from master.
 

Additional info : in fact, it is not present in any of the 3.4.x images
I have downloaded from the public download page...

It is present in the 3.3.x images though, just checked with 3.3.4.


Alex




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] idlc/gbuild baddness and leaked /tmp files...

2011-09-08 Thread Bjoern Michaelsen
On Wed, 7 Sep 2011 20:03:20 -0500
Norbert Thiebaud nthieb...@gmail.com
wrote:

 in anycase, I'm enclined to revert for now... because, as is, I need
 to keep the tinderbox offline...

Please do for now. Michael Meeks noted the leakage too btw.

Best,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] idlc/gbuild baddness and leaked /tmp files...

2011-09-08 Thread Norbert Thiebaud
On Thu, Sep 8, 2011 at 2:48 AM, Bjoern Michaelsen
bjoern.michael...@gmail.com wrote:


 On Wed, 7 Sep 2011 20:03:20 -0500
 Norbert Thiebaud nthiebaud-re5jqeeqqe8avxtiumw...@public.gmane.org
 wrote:

 in anycase, I'm enclined to revert for now... because, as is, I need
 to keep the tinderbox offline...

 Please do for now. Michael Meeks noted the leakage too btw.

ok pushed...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Webdav lock support

2011-09-08 Thread Davide Dozza
Hi all,

I wonder to know the status of webdav implementation in LibO 3.4.3.

That is, I've open an issue (#39529) about support of lock file
feature that seems to be supported but not yet implemented.

Ciao

Davide
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Licensing

2011-09-08 Thread Norbert Thiebaud
On Wed, Sep 7, 2011 at 1:58 PM, Peter Foley pefol...@verizon.net wrote:
 On Wed, 7 Sep 2011, Peter Foley wrote:

 All of my patches are contributed under
 MPL 1.1/GLPv3+/LGPLv3+

 Thanks,

Thanks you for that, and thank you for having updated
http://wiki.documentfoundation.org/Development/Developers, much
appreciated :-)

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] idlc/gbuild baddness and leaked /tmp files...

2011-09-08 Thread Caolán McNamara
On Wed, 2011-09-07 at 20:03 -0500, Norbert Thiebaud wrote:
 PS: osl's qa is also leaking a /tmp/random/hello/world at each build

So *that's* where those are coming from. Great, fixed now.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] odd (master) style application bug ...

2011-09-08 Thread Michael Meeks
Hi Eike,

On Thu, 2011-09-08 at 01:27 +0200, Eike Rathke wrote:
 Classical copypaste error ;-)
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=7e1bafb2f1f324167e9b438fbf06e0ec346e55ca

Thanks ! :-) perhaps from an stl: conversion ?

Hi Cor,

On Wed, 2011-09-07 at 23:14 +0200, Cor Nouws wrote:
 It's already there for some time.
 Oldest build I have here, does show it too:
 2011-08-19  Build ID: 35913b9-4eb4f62-260b7c1

Goodness - you knew about it already ? :-)
 
 more findings:
   apply style fun  nothing happens (visible) document is dirty
   use bucket, then switch to page styles  no shows, swith to cell 
 styles  empty too
 
It's great to report these known regressions in master to the dev list
fast :-)

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PUSHED][REVIEW] new patch for svgwriter

2011-09-08 Thread Caolán McNamara
On Wed, 2011-09-07 at 14:34 -0700, julien2412 wrote:
 Hello,
 
 After having listened the advice of Caolán and Thorsten, here is a new patch
 for svgwriter.cxx (filter module).
 I hope having followed the guidelines and haven't missed anything this time.
 
 Julien.
 http://nabble.documentfoundation.org/file/n3318017/newpatchsvgwriter.txt
 newpatchsvgwriter.txt 
 
 PS : as usual, if it's ok, just tell me and I'll commit and push it on
 master repo.

nLen * sizeof(pDXArray[0]) or sizeof(sal_Int32) rather than
sizeof(pDXArray). Fixed up and pushed. Thanks for noticing this can of
worms.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] New Hunspell feature

2011-09-08 Thread R.J. Baars
Hunspell 1.3 introduced the 'warning' level of mistake.
To use this, an extra setting in the UI will be needed, and Hunspell to be
called accordingly.
In the UI, a differently colored underline is expected.

I am not a programmer, but have been working with Laszlo Nemeth on this
from a language support viewpoint.

Can anyone direct me to the correct way to get this new feature on the
to-do-list?

Thanks.

Ruud

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Build errors

2011-09-08 Thread Dmitry. A. Ashkadov

Hello!

I had tried to build LO, but thereare two errors during build:


Compiling: filter/source/graphicfilter/epict/epict.cxx
Making:epict.lib
Making:libeptlo.so
Making:all_epict.dpslo
Entering /home/user/projects/libreoffice/filter/source/svg

Compiling: filter/source/svg/parserfragments.cxx
Compiling: filter/source/svg/impsvgdialog.cxx
dmake:  Error: -- `svgscript.hxx' not found, and can't be made

---
Oh dear - something failed during the build - sorry !
  For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development

  internal build errors:

ERROR: error 65280 occurred while making 
/home/user/projects/libreoffice/filter/source/svg


 it seems that the error is inside 'filter', please re-run build
 inside this module to isolate the error and/or test your fix:
---

/bin/sh
cd /home/user/projects/libreoffice
source ./Env.Host.sh
cd filter
rm -Rf /home/user/projects/libreoffice/filter/unxlngi6 # optional 
module 'clean'

build

when the problem is isolated and fixed exit and re-run 'make' from the 
top-level


And next error:


Making:libpcrlo.so
../../unxlngi6/slo/MasterDetailLinkDialog.o:(.data.rel.ro._ZTVN3pcr22MasterDetailLinkDialogE[vtable 
for pcr::MasterDetailLinkDialog]+0x120): undefined reference to 
`cppu::OPropertySetHelper::enableChangeListenerNotification(unsigned 
char)'
../../unxlngi6/slo/MasterDetailLinkDialog.o:(.data.rel.ro._ZTVN3pcr22MasterDetailLinkDialogE[vtable 
for pcr::MasterDetailLinkDialog]+0x194): undefined reference to 
`non-virtual thunk to 
svt::OGenericUnoDialog::queryInterface(com::sun::star::uno::Type const)'
../../unxlngi6/slo/MasterDetailLinkDialog.o:(.data.rel.ro._ZTVN3pcr22MasterDetailLinkDialogE[vtable 
for pcr::MasterDetailLinkDialog]+0x1a0): undefined reference to 
`non-virtual thunk to 
cppu::OPropertySetHelper::enableChangeListenerNotification(unsigned char)'

collect2: ld returned 1 exit status
dmake:  Error code 1, while making '../../unxlngi6/lib/libpcrlo.so'

---
Oh dear - something failed during the build - sorry !
  For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development

  internal build errors:

ERROR: error 65280 occurred while making 
/home/user/projects/libreoffice/extensions/source/propctrlr


 it seems that the error is inside 'extensions', please re-run build
 inside this module to isolate the error and/or test your fix:
---

/bin/sh
cd /home/user/projects/libreoffice
source ./Env.Host.sh
cd extensions
rm -Rf /home/user/projects/libreoffice/extensions/unxlngi6 # optional 
module 'clean'

build

when the problem is isolated and fixed exit and re-run 'make' from the 
top-level


Are any ideas how to fix problems?

Thank you!

--
Best Regards,
Dmitry

attachment: dmitry_ashkadov.vcf___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Build errors

2011-09-08 Thread Caolán McNamara
On Thu, 2011-09-08 at 13:53 +0400, Dmitry. A. Ashkadov wrote:
 Hello!
 
 I had tried to build LO, but thereare two errors during build:

Its an incremental build isn't it ?, i.e. built, git pulled and
rebuild.

  Compiling: filter/source/graphicfilter/epict/epict.cxx
  Making:epict.lib
  Making:libeptlo.so
  Making:all_epict.dpslo
  Entering /home/user/projects/libreoffice/filter/source/svg
 
  Compiling: filter/source/svg/parserfragments.cxx
  Compiling: filter/source/svg/impsvgdialog.cxx
  dmake:  Error: -- `svgscript.hxx' not found, and can't be made

This is a common problem with a header is removed, and dependencies get
stuck. The problem is basically fixed for the newer gmake projects. For
the older ones you can throw away the depends for that dir and
regenerate them, like so...

source ./Env.Host.sh
cd filter/source/svg
dmake depend=t
dmake

  Making:libpcrlo.so
  ../../unxlngi6/slo/MasterDetailLinkDialog.o:(.data.rel.ro._ZTVN3pcr22MasterDetailLinkDialogE[vtable
   
  for pcr::MasterDetailLinkDialog]+0x120): undefined reference

Not sure *why* this one happened, but try.

touch extensions/source/propctrlr/MasterDetailLinkDialog.cxx
and re-make.

In either case the more aggressive rm -Rf in the error message should
work.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] New Hunspell feature

2011-09-08 Thread Cor Nouws

Hi Ruud,

R.J. Baars wrote (08-09-11 11:32)


Can anyone direct me to the correct way to get this new feature on the
to-do-list?


A clear issue does help.
  http://wiki.documentfoundation.org/BugReport

But more important is: who will have it on his/her to-do-list ...

Best,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] New Hunspell feature

2011-09-08 Thread Cor Nouws

Cor Nouws wrote (08-09-11 12:06)

R.J. Baars wrote (08-09-11 11:32)


Can anyone direct me to the correct way to get this new feature on the
to-do-list?


A clear issue does help.
http://wiki.documentfoundation.org/BugReport

But more important is: who will have it on his/her to-do-list ...


I could have been more specific:

Patches are always welcome - there is no list that has to be checked if 
the work is 'planned' or 'accepted'.

The core developers will be glad to assist to get the work done.

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PUSHED][REVIEW-3-4] Fix for hang in slideshow

2011-09-08 Thread Caolán McNamara
On Tue, 2011-09-06 at 16:48 +0200, Thorsten Behrens wrote:
 Hi,
 
 could someone please review  cherry-pick for 3-4 this fix:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=044c534b2deb985052e7977bba3290c5d2c3ad77

Looks reasonably sane, as sane as Reschedules go anyway. Pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] odd (master) style application bug ...

2011-09-08 Thread Cor Nouws

hi Michael,

Michael Meeks wrote (08-09-11 10:56)


Goodness - you knew about it already ? :-)


No, I checked it late yesterday evening.


It's great to report these known regressions in master to the dev list
fast :-)


Never seen my issues in BugZilla, here, or on IRC ?  Then there must be 
still some open, also from Master ;-)


Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] odd (master) style application bug ...

2011-09-08 Thread Eike Rathke
Hi Michael,

On Thursday, 2011-09-08 09:56:18 +0100, Michael Meeks wrote:

  Classical copypaste error ;-)
   Thanks ! :-) perhaps from an stl: conversion ?

Indirectly, while ScMarkData got a set iterator for selected sheets
instead of needing to loop through all existing sheets and asking
whether one is selected or not.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] idlc/gbuild baddness and leaked /tmp files...

2011-09-08 Thread Matúš Kukan
On 8 September 2011 03:03, Norbert Thiebaud nthieb...@gmail.com wrote:
 Recently my MacOSX tinderbox started to die for weir reason... (too
 many open pipe, etc)

 as it turned out there was massive leakage fo file in the temp
 directory with each build.. 150 or so per build... after a while
 mktemp was running out of filename and working very-very hard to find
 an empty slot.

Another missing $, this should fix it:

define gb_UnoApiPartTarget__command
$$(call gb_Output_announce,$(2),$(true),IDL,2)
mkdir -p $(call gb_UnoApiPartTarget_get_target,$(2))  \
-   RESPONSEFILE=$$(call var2file,$(shell $(gb_MKTEMP)),500,\
+   RESPONSEFILE=$$(call var2file,$$(shell $(gb_MKTEMP)),500,\
$$(call gb_Helper_convert_native,$$(INCLUDE) $$(DEFS)
-O $(call gb_UnoApiPartTarget_get_target,$(2)) -verbose -C $$?))  \
$(gb_UnoApiTarget_IDLCCOMMAND) @{RESPONSEFILE}  /dev/null  \
rm -f {RESPONSEFILE}  \

Matúš
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Build errors

2011-09-08 Thread Dmitry. A. Ashkadov

Hello, Caolán!

I had tried full rebuild:

$ make clean
$ make

but the problems are left.

For module 'filter' command dmake depend=t wokrs as 'touch' for extensions!

thank you!

08.09.2011 13:59, Caolán McNamara пишет:

On Thu, 2011-09-08 at 13:53 +0400, Dmitry. A. Ashkadov wrote:

Hello!

I had tried to build LO, but thereare two errors during build:

Its an incremental build isn't it ?, i.e. built, git pulled and
rebuild.


Compiling: filter/source/graphicfilter/epict/epict.cxx
Making:epict.lib
Making:libeptlo.so
Making:all_epict.dpslo
Entering /home/user/projects/libreoffice/filter/source/svg

Compiling: filter/source/svg/parserfragments.cxx
Compiling: filter/source/svg/impsvgdialog.cxx
dmake:  Error: -- `svgscript.hxx' not found, and can't be made

This is a common problem with a header is removed, and dependencies get
stuck. The problem is basically fixed for the newer gmake projects. For
the older ones you can throw away the depends for that dir and
regenerate them, like so...

source ./Env.Host.sh
cd filter/source/svg
dmake depend=t
dmake


Making:libpcrlo.so
../../unxlngi6/slo/MasterDetailLinkDialog.o:(.data.rel.ro._ZTVN3pcr22MasterDetailLinkDialogE[vtable
for pcr::MasterDetailLinkDialog]+0x120): undefined reference

Not sure *why* this one happened, but try.

touch extensions/source/propctrlr/MasterDetailLinkDialog.cxx
and re-make.

In either case the more aggressive rm -Rf in the error message should
work.

C.




--
Best Regards,
Dmitry

attachment: dmitry_ashkadov.vcf___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Korrawit Pruegsanusak
Hello Eike, Stephan, *

On Thu, Sep 8, 2011 at 17:23, Eike Rathke o...@erack.de wrote:
 It didn't occur to me that the original expression
 actually would had been wrong at two places..

Also for me too. My bad for didn't notice it.

 On Thursday, 2011-09-08 08:40:24 +0200, Stephan Bergmann wrote:
 Now actually looking at the context:  Given that CmpKernData in
 vcl/source/gdi/outdev3.cxx is (only) used as an argument to
 std::sort, I'm pretty sure it must read (a.nChar1 == b.nChar1) to
 make that a true strict weak ordering, as required by std::sort.
 Pushed as 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b7978c822b11c53b4bd40bb0829e3ec205f1359.

And thanks very much for pushing this. ;)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] configure.in monstrosity

2011-09-08 Thread Tomáš Chvátal
Hi guys,

I was editing the configure.in file in order to fix one tiny bug and
found out it is horrible scarry place.

It would be really nice if that huge file would be split into several
separate parts per-use.

So I would like to propose slow cleanup/splitting to have simple
configure.ac with
platform check, and then i would move each configure option and
switches into per feature
macros in m4/.

This way we could easily overview all the options, and it would also
improve the readability.

What do you think about this?

Cheers

Tom
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] configure.in monstrosity

2011-09-08 Thread Stephan Bergmann

On 09/08/2011 02:50 PM, Tomáš Chvátal wrote:

I was editing the configure.in file in order to fix one tiny bug and
found out it is horrible scarry place.

It would be really nice if that huge file would be split into several
separate parts per-use.

So I would like to propose slow cleanup/splitting to have simple
configure.ac with
platform check, and then i would move each configure option and
switches into per feature
macros in m4/.

This way we could easily overview all the options, and it would also
improve the readability.

What do you think about this?


Sounds sane.  Also, there are dependencies between some of the checks, 
forcing them into a specific order, which is rather brittle, anyway.


-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Background image in Mac 343 installer image disappeared ?

2011-09-08 Thread Alexander Thurgood
Le 08/09/11 09:33, Alexander Thurgood a écrit :

Now known as :

https://bugs.freedesktop.org/show_bug.cgi?id=40714



Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] configure.in monstrosity

2011-09-08 Thread Tor Lillqvist
 It would be really nice if that huge file would be split into several
 separate parts per-use.

But it is split up into separate parts that do different things. It is
even consistently indented nowadays. It isn't as if it was full of
random statements in no particular order. I really fail to see what we
would gain (except lots of m4 and shell debugging opportunities) by
splitting out stuff into m4 macros.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] configure.in monstrosity

2011-09-08 Thread Eike Rathke
Hi Tomáš,

On Thursday, 2011-09-08 14:50:00 +0200, Tomáš Chvátal wrote:

 It would be really nice if that huge file would be split into several
 separate parts per-use.
 
 So I would like to propose slow cleanup/splitting to have simple
 configure.ac with
 platform check, and then i would move each configure option and
 switches into per feature
 macros in m4/.

IMHO not so good, it's much easier to load that one file into the editor
and search for occurrences of variables than if it was split over
several places.

 This way we could easily overview all the options, and it would also
 improve the readability.

autoconf stuff isn't readable anyway, so.. ;-)

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Fix configure to not require java packages when passed --without-java

2011-09-08 Thread Tomáš Chvátal
As requested in the fdo#40687 attaching the from the bug.
From 86454d6b5b1c6aff1466b174ffcf2ad73ea8a5f9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Chv=C3=A1tal?= tchva...@suse.cz
Date: Thu, 8 Sep 2011 14:20:48 +0200
Subject: [PATCH] Do not search for java packages if --without-java is passed.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


Signed-off-by: Tomáš Chvátal tchva...@suse.cz
---
 configure.in |6 ++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/configure.in b/configure.in
index 1dc00d4..262fe00 100755
--- a/configure.in
+++ b/configure.in
@@ -4962,6 +4962,7 @@ AC_SUBST(DB_CPPLIB)
 dnl ===
 dnl Check for system lucene
 dnl ===
+if test $with_java != no; then
 AC_MSG_CHECKING([which lucene to use])
 if test -n $with_system_lucene -o -n $with_system_libs  \
 test $with_system_lucene != no  test $with_system_jars != no; then
@@ -5021,6 +5022,7 @@ else
 SYSTEM_LUCENE=NO
 BUILD_TYPE=$BUILD_TYPE LUCENE
 fi
+fi
 AC_SUBST(SYSTEM_LUCENE)
 AC_SUBST(LUCENE_CORE_JAR)
 AC_SUBST(LUCENE_ANALYZERS_JAR)
@@ -5189,6 +5191,7 @@ AC_SUBST(HSQLDB_JAR)
 dnl ===
 dnl Check for system beanshell
 dnl ===
+if test $with_java != no; then
 AC_MSG_CHECKING([which beanshell to use])
 if test -n $with_system_beanshell -o -n $with_system_libs  \
test $with_system_beanshell != no  test $with_system_jars != no; then
@@ -5204,6 +5207,7 @@ else
 SYSTEM_BSH=NO
 BUILD_TYPE=$BUILD_TYPE BSH
 fi
+fi
 AC_SUBST(SYSTEM_BSH)
 AC_SUBST(BSH_JAR)
 
@@ -5211,6 +5215,7 @@ AC_SUBST(BSH_JAR)
 dnl ===
 dnl Check for system saxon
 dnl ===
+if test $with_java != no; then
 AC_MSG_CHECKING([which saxon to use])
 if test -n $with_system_saxon -o -n $with_system_libs  \
test $with_system_saxon != no  test $with_system_jars != no; then
@@ -5310,6 +5315,7 @@ else
 SYSTEM_SAXON=NO
 NEED_SAXON=TRUE
 fi
+fi
 AC_SUBST(SYSTEM_SAXON)
 AC_SUBST(SAXON_JAR)
 
-- 
1.7.6.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Returned mail: Data format error

2011-09-08 Thread subscribe
This Message was undeliverable due to the following reason:

Your message was not delivered because the destination computer was
not reachable within the allowed queue period. The amount of time
a message is queued before it is returned depends on local configura-
tion parameters.

Most likely there is a network problem that prevented delivery, but
it is also possible that the computer is turned off, or does not
have a mail system running right now.

Your message was not delivered within 5 days:
Host 180.126.188.61 is not responding.

The following recipients did not receive this message:
libreoffice@lists.freedesktop.org

Please reply to postmas...@libreoffice.org
if you feel this message to be in error.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] endless build - pcre-config

2011-09-08 Thread Olivier Hallot
hi

I updated my linux to mandriva 2011 this  week  and now my build hangs
forever with process pcre-config taking most of the cpu cycles...

Did I missed something?

Thank's

-- 
Olivier Hallot
Founder and Steering Commitee Member
The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] minutes of tech. steering call ...

2011-09-08 Thread Michael Meeks
Present:
+ Norbert, David, Stephan, Cedric, Thorsten,
  Andras, Bjoern, Rainer, Michael, Kohei, Caolan

+ Completed Action Items
+ get Bjoern setup with a vhost for gerrit (Thorsten / Christian)
+ playground already constructed / public:
  at https://gerrit-test.libreoffice.org
+ close bug-voting with wontfix + rational (Rainer)
+ in-progress: get bugzilla query wrt. master regressions to Michael 
(Rainer)
+ check and enable new RTF import in master by default (Cedric)
+ fixup qa list configuration (Thorsten)
+ send Loic some ideas / design / interface work for bug filing 
(Michael)

+ Pending Action Items
+ default to TM safe (non-TDF) branding (Thorsten)
+ enable on-line updates for QA for dailies ... (Kendy)
+ write substance of what is needed wrt. the extensions
   templates announce  send to Florian (Andreas)
+ New extensions website: publish / tdf blog (Florian)
+ publicise / aggregate our list of ODF proposals / extensions 
(Thorsten)

* Agenda items
+ pending action items
+ Munich hack-fest report / roundup (Thorsten)
+ hack-fest page achivements:

http://wiki.documentfoundation.org/Hackfest2011#Achievements
+ wonderful, friendly, social atmosphere
+ too many people to fit in the room (30+)
+ several companies represented + Munich Gov't
+ patches from new contributors, some adding to their
  existing translating / documentation skills.
+ great infrastructure provision - icecream / server
+ some good UI designer - hacker interactions
+ hope for hosting an identical event next year
+ Many thanks to: The City of Munich + DBI GmbH
+ bus factor issues wrt. scattered projects ...
+ concern Fridrich + Kohei hit by a bus  their
  external projects.
AA: + mail details for new repo setup (for libtextcat) to Michael 
(Caolan)
+ benefits of controlling review (Kohei)
+ also of branding  separation (Kohei)
+ problems of fixing: commit, release, up-load, etc. (Michael)
+ concern mostly around maintainership handover (Caolan)
AA: + give mdds website / commit rights out more diversly (Kohei)
+ Cor's considerations on release timing
+ existing schedule is here:
  http://wiki.documentfoundation.org/ReleasePlan#3.5_release
+ very vague, lots of factors and no data / heuristics 
(Thorsten)
+ could try a slushy feature-freeze on master around an
  earlier release with new features (Norbert)
+ some new features have good QA coupling with their own
  builds eg. Jean Baptiste (Cedric)
+ lots of reasons already provided why next time would be
  better quality-wise than last time (Michael)
+ not too late to discuss at the conference and move
  freeze dates by a week or two (Norbert)
+ always a trade-off between quality, community fun,
  pace of development (Michael)
+ (default) internal gnumake re-hash ... (Michael)
+ having bootstrap make build is painful (Norbert)
+ not having it on the default path reduces usage (Michael)
+ on Linux performance gain not justified (Bjoern)
+ on Windows - there are big wins - fewer deps (Bjoern)
+ why not add it for windows-only ? (Bjoern)
+ have a binary that we just download (Thorsten)
+ dangers of having a fork of the build-tool (Thorsten)
+ slow in standard make - fix: get it up-stream (Stephan)
+ complexity added into the core breaks the idea
  of having a 'pure' configure / make in future (Norbert)
+ risk of depending on and maintaining a new custom 'make',
  combined with concern about continuing to require bootstrap,
  is more significant than -any- magnitude of developer
  productivity hit for new developers too unaware / lazy
  to download custom tools. (Bjoern, Stephan, Norbert)
+ unreliable vs reliable, slow vs. fast tests (Stephan)
+ subsequenttests - not ideal, but lots of them
+ problem: they require a complete LibreOffice install
+ problem: they connect via UNO = poor error reporting  
debugging
+ some rare / intermittent issues running tests  crashes
  during shutdown
+ discovered a number of bugs  regressions cleaning them
  up so they 

Re: [Libreoffice] minutes of tech. steering call ...

2011-09-08 Thread Kohei Yoshida
On Thu, 2011-09-08 at 16:28 +0100, Michael Meeks wrote:
 AA: + give mdds website / commit rights out more diversly
 (Kohei)

This is already done.  Now Caolan and David should have the same rights
as I do.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] License for my patches

2011-09-08 Thread Regina Henschel

Hi,

I want to add me to 
http://wiki.documentfoundation.org/Development/Developers and noticed 
that there is no public license statement yet. So for the records:
All my patches are under LGPLv3+/MPL. This holds for new patches too 
until I explicitly revoke this statement.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] 最新007专用数码/录像/手表抢购!(AD)libreoffice@lists.freedesktop.org

2011-09-08 Thread Xdazuv






 
最新007专用数码录像手表抢购

重要会议录音录像,隐性拍摄,交通事故记录,课堂记录,记者采访及时记录,重要采访录音


抢购进入





libreoffice@lists.freedesktop.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

vitriol vitriol_vitr...@katamail.com changed:

   What|Removed |Added

 Depends on||40701

--- Comment #200 from vitriol vitriol_vitr...@katamail.com 2011-09-08 
09:53:25 PDT ---
Nominating Bug 40701. Base crashes with runtime error when Find Record button
is clicked with certain documents. Crash and regression.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Documentation about building on Windows with Cygwin and MSVC Express

2011-09-08 Thread Regina Henschel

Hi all,

I have finished my build :) I have collected a lot of notices on 
http://wiki.documentfoundation.org/User:Regina/DraftParametersForAutogenForWindows
I think, that such information might help others starting on development 
on Windows and I suggest, that I move the content from my 'private' area 
to a more 'official' place. Do you agree? If yes:


(1) Please have a look, whether the content is correct. I have written 
it as beginner and have no deeper knowledge about building.


(2) My English is poor. So it would be nice, if a native speaker would 
correct my errors. Perhaps something for 'documentation'?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Documentation about building on Windows with Cygwin and MSVC Express

2011-09-08 Thread Bjoern Michaelsen
On Thu, 08 Sep 2011 19:05:02 +0200
Regina Henschel rb.hensc...@t-online.de
wrote:

  I suggest, that I move the content from my  'private' area to a more
 'official' place. Do you agree?

Yes!

 (1) Please have a look, whether the content is correct. I have
 written it as beginner and have no deeper knowledge about building.

Nothing wrong with that from what I see. Some points might have some
additional explanations, but thats what wikis are for.

Best,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Build errors

2011-09-08 Thread Dmitry. A. Ashkadov

Hello!


The building now reaches module 'tail_build' and fails:


=
(1/1) Building module tail_build
=
Entering /home/user/projects/libreoffice/tail_build/prj

cd ..  make -s -r -j2  make -s -r deliverlog
[ build MOD ] sc
[ build CUT ] hwpfilter_test_hwpfilter
[ build CUT ] lotuswordpro_test_lotuswordpro
[ build CUT ] sc_ucalc
[ build CUT ] sc_filters_test
[ build CUT ] sd_uimpress
Error: GetResultSet: Any other exception: No Content Provider 
available for URL: vnd.sun.star.help://?Language=enSystem= From File 
/home/user/projects/libreoffice/sfx2/source/bastyp/helper.cxx at Line 161
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: property value missing From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 207
Error: LoadConfig failed From File 
/home/user/projects/libreoffice/unotools/source/config/searchopt.cxx 
at Line 235

ods Test
filters-test.cxx:211:Assertion
Test name: FiltersTest::testRangeName
assertion failed
- Expression: xDocSh.Is()
- Failed to load named-ranges-global.ods.

filters-test.cxx:296:Assertion
Test name: FiltersTest::testContent
assertion failed
- Expression: xDocSh.Is()
- Failed to load universal-content.*

Failures !!!
Run: 3   Failure total: 2   Failures: 2   Errors: 0
make: *** 
[/home/user/projects/libreoffice/workdir/unxlngi6/CppunitTest/sc_filters_test.test] 
Error 1

make: *** Waiting for unfinished jobs
dmake:  Error code 2, while making 'all'

---
Oh dear - something failed during the build - sorry !
  For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development

  internal build errors:

ERROR: error 65280 occurred while making 
/home/user/projects/libreoffice/tail_build/prj


 it seems that the error is inside 'tail_build', please re-run build
 inside this module to isolate the error 

Re: [Libreoffice] Build errors

2011-09-08 Thread Markus Mohrhard
Execute: rm workdir/unxlngx6/RdbTarget/sc_filters_test.rdb or make clean in
sc
and run a new make in tail_build

It's the result of my makefile change yesterday evening.

Regards,
Markus

2011/9/8 Dmitry. A. Ashkadov dmitry.ashka...@gmail.com

 Hello!


 The building now reaches module 'tail_build' and fails:

  =
 (1/1) Building module tail_build
 =
 Entering /home/user/projects/**libreoffice/tail_build/prj

 cd ..  make -s -r -j2  make -s -r deliverlog
 [ build MOD ] sc
 [ build CUT ] hwpfilter_test_hwpfilter
 [ build CUT ] lotuswordpro_test_lotuswordpro
 [ build CUT ] sc_ucalc
 [ build CUT ] sc_filters_test
 [ build CUT ] sd_uimpress
 Error: GetResultSet: Any other exception: No Content Provider available
 for URL: vnd.sun.star.help://?Language=**enSystem= From File
 /home/user/projects/**libreoffice/sfx2/source/**bastyp/helper.cxx at Line
 161
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: property value missing From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 207
 Error: LoadConfig failed From File /home/user/projects/**
 libreoffice/unotools/source/**config/searchopt.cxx at Line 235
 ods Test
 filters-test.cxx:211:Assertion
 Test name: FiltersTest::testRangeName
 assertion failed
 - Expression: xDocSh.Is()
 - Failed to load named-ranges-global.ods.

 filters-test.cxx:296:Assertion
 Test name: FiltersTest::testContent
 assertion failed
 - Expression: xDocSh.Is()
 - Failed to load universal-content.*

 Failures !!!
 Run: 3   Failure total: 2   Failures: 2   Errors: 0
 make: *** [/home/user/projects/**libreoffice/workdir/unxlngi6/**
 CppunitTest/sc_filters_test.**test] Error 1
 make: *** Waiting for unfinished jobs
 dmake:  Error code 2, while making 'all'


 --**--**
 

[Libreoffice] o3tl/cow_wrapper.hxx not found

2011-09-08 Thread Simon Brouwer
Hi,

Trying to build LibreOffice on Windows XP, the build stops in o3tl with
the below error.

I do have ~/git/libo/o3tl/inc/03tl/cow_wrapper.hxx
and in ~/git/libo/o3tl/qa/cow_wrapper_clients.hxx it says

#include o3tl/cow_wrapper.hxx

Why is the file not found?

Best regards
Simon

Simon@LAPTOP_SIMON ~/git/libo/o3tl
$ make
[ build CXX ] o3tl/qa/cow_wrapper_clients
R=c:/cygwin/home/Simon/git  O=$R/libo/solver/wntmsci12.pro 
W=$R/libo/workdi
r/wntmsci12.pro  S=$R/libo   mkdir -p $W/CxxObject/o3tl/qa/
$W/Dep/CxxObject
/o3tl/qa/  /cygdrive/c/PROGRA~1/MICROS~1.0/VC/bin/cl.exe
-DBOOST_MEM_FN_ENABLE
_CDECL -DCPPU_ENV=msci -DCUI -DENABLE_GRAPHITE -DENABLE_GTK
-DENABLE_LAYOUT=0 -D
ENABLE_LAYOUT_EXPERIMENTAL=0 -DINTEL -DM1500 -DMSC -DNDEBUG -DNT351
-DOPTIMIZE -
DOSL_DEBUG_LEVEL=0 -DPRODUCT -DPRODUCT_FULL -DSOLAR_JAVA -DSUPD=350 -DVCL
-DWIN3
2 -DWINVER=0x0500 -DWNT -D_CRT_NONSTDC_NO_DEPRECATE
-D_CRT_NON_CONFORMING_SWPRIN
TFS -D_CRT_SECURE_NO_DEPRECATE -D_DLL -D_MT -D_REENTRANT
-D_WIN32_IE=0x0500 -D_X
86_=1  -D_DLL   -Gd -GR -Gs -GS -Gy -MD -nologo -Wall -wd4005 -wd4061
-wd4127 -w
d4180 -wd4189 -wd4191 -wd4217 -wd4250 -wd4251 -wd4275 -wd4290 -wd4294
-wd4350 -w
d4355 -wd4365 -wd4503 -wd4505 -wd4511 -wd4512 -wd4514 -wd4611 -wd4619
-wd4625 -w
d4626 -wd4640 -wd4668 -wd4675 -wd4692 -wd4710 -wd4711 -wd4738 -wd4786
-wd4800 -w
d4820 -wd4826 -wd4996 -Zc:forScope,wchar_t- -Zm500-DEXCEPTIONS_ON -EHa
 -Ob1
 -Oxs -Oy- -Fd  -showIncludes -I$S/o3tl/qa -IC:/cygwin$O/inc/stl
-IC:/cygwin$O/i
nc/external -IC:/cygwin$O/inc -IC:/cygwin$S/solenv/wntmsci12/inc
-IC:/cygwin$S/s
olenv/inc -IC:/cygwin$S/res -IC:/PROGRA~1/Java/JDK16~2.0_0/include/win32
-IC:/PR
OGRA~1/Java/JDK16~2.0_0/include
-IC:/PROGRA~1/MICROS~4/Windows/v7.1/include -IC:
/PROGRA~1/MICROS~1.0/VC/include -IC:/PROGRA~1/MI21AE~1/include -c
$S/o3tl/qa
/cow_wrapper_clients.cxx -Fo$W/CxxObject/o3tl/qa/cow_wrapper_clients.o |
C:/cygw
in/home/Simon/git/libo/solenv/gbuild/filter-showIncludes.pl
/home/Simon/git/libo
/workdir/wntmsci12.pro/Dep/CxxObject/o3tl/qa/cow_wrapper_clients.d
/home/Simon/g
it/libo/workdir/wntmsci12.pro/CxxObject/o3tl/qa/cow_wrapper_clients.o
/home/Simo
n/git/libo/o3tl/qa/cow_wrapper_clients.cxx; exit ${PIPESTATUS[0]}
c:\cygwin\home\simon\git\libo\o3tl\qa\cow_wrapper_clients.hxx(32) : fatal
error
C1083: Cannot open include file: 'o3tl/cow_wrapper.hxx': No such file or
directo
ry

-- 
Vriendelijke groet,

Simon Brouwer
-*- nl.openoffice.org -*- http://www.opentaal.org -*-

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Commit 66f05b5d5acc43e4615bc19045d3600ed93e328b breaks the build

2011-09-08 Thread Francois Tigeot
Hi,

This commit has added a file named filter/source/svg/js2hxx.py
which has the following shebang :

   #!/usr/bin/env python

Unfortunately, system python is not always named 'python'. On one of my
systems, it is named 'python2.6' and the build breaks when it encounters
this script...

Configure correctly detects the right python interpreter and puts it in
the PYTHON environment variable but I'm not sure how to exploit it to
correct this issue

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 40449, which changed state.

Bug 40449 Summary: SPELLCHECK does not recognize text language
https://bugs.freedesktop.org/show_bug.cgi?id=40449

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Build errors

2011-09-08 Thread Dmitry. A. Ashkadov

Good! The office was build successfully! :-)

Why «make dev-install»  works as simple «make» now? How can I install 
office to local directory?


Thank you.

--
Best Regards,
Dmitry

attachment: dmitry_ashkadov.vcf___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 39365, which changed state.

Bug 39365 Summary: Spell check does not work after copy / paste, modified 
language not recognized
https://bugs.freedesktop.org/show_bug.cgi?id=39365

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] cppcheck duplicateExpression

2011-09-08 Thread julien2412
Hello,

Cppcheck has detected a duplicateExpression in
vcl/ios/source/window/salframe.cxx, line 470
I checked on salframe.cxx of aqua, there's the same duplicate (line 631)
Here is the line :
 if( pState-mnMask  (SAL_FRAMESTATE_MASK_X | SAL_FRAMESTATE_MASK_X) )

I compared with gtk part and think the line should just be like this but
it's just a guess :
 if( pState-mnMask  (SAL_FRAMESTATE_MASK_X | SAL_FRAMESTATE_MASK_Y) )
 
I don't know why for the moment but cppcheck hasn't detected the duplicate
on aqua part. I just noticed that if I remove all the code
(variable/methods) until the method SetTitle included, duplicate expression
can be detected.

Julien.


--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-duplicateExpression-tp3321065p3321065.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] 3.5 release from QA to point-zero

2011-09-08 Thread Sophie Gautier
Hi Cor, all,

I jump to the point I would like to discuss:
[...]

 - development in the quality and the use of tools for testing

 - is attention in testing well spread over Windows / Linux / MacOS ?

 - are there other releases/tasks that need attention during that time ?

 - how many people are available for beta-RC testing and fixing bugs ?
  e.g. the time of the year (Christmas, Western New year)

 - can we attract many people for beta-testing
  (prize for the top-5 (clear, useful) issue submitting testers ?)

We need to change the way we involve the native-lang communities in
our testing process. They are currently a bit lost by the quick turn
over of the versions, but they are still willing to participate. So
may we could focus them on specific regression testing, or specific
functional testing that doesn't require a due short timeframe. I'm
just back this evening, but we are thinking about it with
Jean-Baptiste. I'll come later with a more formal proposal when
Jean-Baptiste and me will have discussed it further.

Kind regards
Sophie
-- 
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] 3.5 release from QA to point-zero

2011-09-08 Thread Cor Nouws

Hi Sophie,

Sophie Gautier wrote (08-09-11 22:38)


We need to change the way we involve the native-lang communities in
our testing process. They are currently a bit lost by the quick turn
over of the versions, [...]


Indeed, that is an extra load for the testers/ native-lang community 
members.
Recently I read a interview with someone from Mozilla QA who mentioned 
the same issue.
So, turning this a bit in positive direction definitely will help - 
regardless the outcome of this broader discussion.



Jean-Baptiste. I'll come later with a more formal proposal when
Jean-Baptiste and me will have discussed it further.


May also be a formal suggestion ;-)

Thanks,
Cor

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

2011-09-08 Thread julien2412
Hello,

Here is the pb :
if( 0 )--- Found duplicate if expressions.
{
nFontID = EE_CHAR_FONTINFO_CJK;
 nFontHeightID = EE_CHAR_FONTHEIGHT_CJK;
nWeightID = EE_CHAR_WEIGHT_CJK;
nPostureID = EE_CHAR_ITALIC_CJK;
}
else if( 0 )
{
nFontID = EE_CHAR_FONTINFO_CTL;
 nFontHeightID = EE_CHAR_FONTHEIGHT_CTL;
nWeightID = EE_CHAR_WEIGHT_CTL;
nPostureID = EE_CHAR_ITALIC_CTL;
}
I checked the history, it's there since 16/11/2000 (commit
5dc708093d1ee179099abdcbf0c6f649b1c4deeb)

could anyone explain to me the purpose of this ? Just a typo ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/cppcheck-duplicate-if-expressions-in-bulmaper-cxx-sd-part-tp3321094p3321094.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] A few questions for developers

2011-09-08 Thread Dmitry. A. Ashkadov

Hello!

I found that images as a resource defined in *.src file with parameter 
«MaskColor»:


Image RID_SVXBMP_SLIDERINCREASE
{
ImageBitmap = Bitmap
{
File = slidezoomin_11.png ;
};
MaskColor = STD_MASKCOLOR;
};

What does this parameter mean? Can I don't set MaskColor?


I found that some functions/methods is never used.  This functions are 
listed in «unusedcode.easy 
http://opengrok.libreoffice.org/xref/core/unusedcode.easy» file. Is 
this file generated automatically or I should modify it in case of 
removing unused functions?



How can I generate a patch (diff) which may be used to push changes to 
official repository? Should I make a commit to a local repository before 
generating a patch? And what I should do in case of modification of 
binary data (changed/added images)?


Thank You!

--
Best Regards,
Dmitry

attachment: dmitry_ashkadov.vcf___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] speed up localized builds by introducing po2lo

2011-09-08 Thread Miklos Vajna
I'm attaching an updated patch that fixes po2lo on Windows, where it did
not translate anything due to path translating (/ vs \) issues.
From a1e8bad75279a05bf6a061c53351898eea72433d Mon Sep 17 00:00:00 2001
From: Miklos Vajna vmik...@frugalware.org
Date: Wed, 7 Sep 2011 23:39:15 +0200
Subject: [PATCH] Add po2lo tool

---
 solenv/bin/po2lo |  202 ++
 1 files changed, 202 insertions(+), 0 deletions(-)
 create mode 100755 solenv/bin/po2lo

diff --git a/solenv/bin/po2lo b/solenv/bin/po2lo
new file mode 100755
index 000..08b5519
--- /dev/null
+++ b/solenv/bin/po2lo
@@ -0,0 +1,202 @@
+#!/usr/bin/env python
+# Version: MPL 1.1 / GPLv3+ / LGPLv3+
+#
+# The contents of this file are subject to the Mozilla Public License Version
+# 1.1 (the License); you may not use this file except in compliance with
+# the License or as specified alternatively below. You may obtain a copy of
+# the License at http://www.mozilla.org/MPL/
+#
+# Software distributed under the License is distributed on an AS IS basis,
+# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+# for the specific language governing rights and limitations under the
+# License.
+#
+# The Initial Developer of the Original Code is
+#   Miklos Vajna vmik...@frugalware.org
+# Portions created by the Initial Developer are Copyright (C) 2011 the
+# Initial Developer. All Rights Reserved.
+#
+# Major Contributor(s):
+#
+# For minor contributions see the git repository.
+#
+# Alternatively, the contents of this file may be used under the terms of
+# either the GNU General Public License Version 3 or later (the GPLv3+), or
+# the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
+# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
+# instead of those above.
+
+import getopt, sys, os, re
+
+class Options:
+Options of this script.
+
+def __init__(self):
+self.input = None
+self.output = None
+self.language = None
+self.template = None
+
+class Entry:
+Represents a single line in an SDF file.
+
+def __init__(self, items):
+self.items = items # list of 15 fields
+path = self.items[1].split('\\')
+self.po = %s/%s/%s.po % (options.input.replace('\\', '/'), 
self.items[0], /.join(path[:-1]))
+prefix = 
+if len(self.items[5]):
+prefix += %s. % self.items[5]
+if len(self.items[3]):
+prefix += %s. % self.items[3]
+self.keys = []
+# 10..13 are translation types
+for idx in range(10, 14):
+if len(self.items[idx]):
+t = {10:'text', 12:'quickhelptext', 13:'title'}[idx]
+self.keys.append((idx, self.sdf2po(%s#%s.%s%s % (path[-1], 
self.items[4], prefix, t
+
+def translate(self, translations):
+Translates text in the entry based on translations.
+
+self.items[9] = options.language
+for idx, key in self.keys:
+try:
+self.items[idx] = translations.data[(self.po, key)]
+
+self.items[14] = 2002-02-02 02:02:02
+except KeyError:
+pass
+self.items[14] = self.items[14].strip()
+
+def sdf2po(self, s):
+Escapes special chars in po key names.
+
+return s.translate(normalizetable)
+
+class Template:
+Represents a reference template in SDF format.
+
+def __init__(self, path):
+sock = open(path)
+self.lines = []
+for line in sock:
+self.lines.append(Entry(line.split('\t')))
+
+def translate(self, translations):
+Translates entires in the template based on translations.
+
+sock = open(options.output, w)
+for line in self.lines:
+line.translate(translations)
+sock.write(\t.join(line.items)+\r\n)
+sock.close()
+
+class Translations:
+Represents a set of .po files, containing translations.
+
+def __init__(self):
+key = None
+self.data = {}
+for root, dirs, files in os.walk(options.input):
+for file in files:
+path = %s/%s % (root, file)
+sock = open(path)
+buf = []
+multiline = False
+fuzzy = False
+for line in sock:
+if line.startswith(#: ):
+key = line.strip()[3:]
+elif line.startswith(#, fuzzy):
+fuzzy = True
+elif line.startswith(msgstr ):
+trans = line.strip()[8:-1]
+if len(trans):
+if fuzzy:
+fuzzy = False
+else:
+self.setdata(path, key, trans)
+else:
+buf = []
+

Re: [Libreoffice] A belated hello

2011-09-08 Thread Sophie Gautier
Hi Stephan,

On Mon, Sep 5, 2011 at 1:00 PM, Bjoern Michaelsen
bjoern.michael...@canonical.com wrote:
 Hi Stephan,

 On Fri, 2 Sep 2011 09:32:28 +0200
 Stephan Bergmann
 stephan.bergmann.second...@googlemail.com
 wrote:

 As you might already have noticed, I've started to become active
 around here recently.  That's because, since yesterday, I'm an
 employee of Red Hat (though not yet with a proper email address, but
 that will change soon), having the pleasure of reinforcing its great
 LibreOffice team.

 That is great news! A most sincere welcome to you on the LibreOffice
 project!

I second Bjoern :)

Kind regards
Sophie
-- 
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Buqfrekponqhxntj

2011-09-08 Thread joan
Message could not be delivered

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] License for my patches

2011-09-08 Thread Marc-André Laverdière
Thanks for pointing out to that wiki page. I had missed it too!!!

-- 
Marc-André Laverdière
Software Security Scientist
Innovation Labs, Tata Consultancy Services
Hyderabad, India

On Thu 08 Sep 2011 09:13:56 PM IST, Regina Henschel wrote:
 Hi,
 
 I want to add me to
 http://wiki.documentfoundation.org/Development/Developers and noticed
 that there is no public license statement yet. So for the records:
 All my patches are under LGPLv3+/MPL. This holds for new patches too
 until I explicitly revoke this statement.
 
 Kind regards
 Regina
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Commit 66f05b5d5acc43e4615bc19045d3600ed93e328b breaks the build

2011-09-08 Thread David Tardon
On Thu, Sep 08, 2011 at 09:22:52PM +0200, Francois Tigeot wrote:
 Hi,
 
 This commit has added a file named filter/source/svg/js2hxx.py
 which has the following shebang :
 
#!/usr/bin/env python
 
 Unfortunately, system python is not always named 'python'. On one of my
 systems, it is named 'python2.6' and the build breaks when it encounters
 this script...
 
 Configure correctly detects the right python interpreter and puts it in
 the PYTHON environment variable but I'm not sure how to exploit it to
 correct this issue

Hi, Francois,

the shebang is actually a red herring: the real problem is in
filter/source/svg/makefile.mk, that uses plain python in case of
$(SYSTEM_PYTHON) != . Commit 82f6c0502e51afbc25e5bf0fcee7914a1a5b3f28
should fix the problem.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Herbert Duerr

Hi,


(a.nChar1  b.nChar1) || ((a.nChar1 == a.nChar2)  (a.nChar2 
b.nChar2))


? Somehow, that expression still looks suspicious. (At least, it does
not implement a lexicographical less-than relation. Not sure whether it
should or not, however.)


It should not indeed. On the other hand OutputDevice::GetKerningPairs() 
as the only user of that buggy compare got that comment by me:

// TODO: best is to get rid of this method completely
as the method is a just a remnant of an obsolete WriterEngine/EditEngine 
idea on how to layout text runs.


The method is nowadays only used by the UNO API and even if there was a 
user of that API (which I don't think there is) that alone should be a 
reason to look into what the heck it is trying to accomplish, because 
most probably it is doing it wrongly. So replacing the method with a 
dummy that always returned zero would not make a difference... Or 
getting rid of the related UNO API would also be a good idea if there 
wasn't the UNO API semper fi mantra.


Pair kerning is requested via the font's kerning flag and done just 
above the system's text run layouting. With better support for the 
optional OpenType features it should be moved into the layouting engines 
itself. There is still reason for many conflicts whether a font has a 
classic kern table or GPOS kern subtable or both at the same time 
and which layout engine handle should handle these.


Herbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice