[Libreoffice-commits] core.git: 2 commits - connectivity/source include/comphelper mysqlc/source odk/examples vcl/source

2016-09-19 Thread Stephan Bergmann 
 connectivity/source/drivers/firebird/SubComponent.hxx  |   25 
+-
 include/comphelper/proparrhlp.hxx  |   25 
+-
 mysqlc/source/mysqlc_subcomponent.hxx  |   24 
+
 odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx |   24 
+
 vcl/source/window/taskpanelist.cxx |5 
+-
 5 files changed, 57 insertions(+), 46 deletions(-)

New commits:
commit d5f1e7c5adac5f38379c56b536640f3aaf9ec7d5
Author: Stephan Bergmann 
Date:   Mon Sep 19 21:30:51 2016 +0200

Obsolete workaround for SUNPRO 5 compiler

Change-Id: Ib51f08e1d0e0dff066b06ecd85976b777d722a33

diff --git a/vcl/source/window/taskpanelist.cxx 
b/vcl/source/window/taskpanelist.cxx
index 21b94d2..b5d1738 100644
--- a/vcl/source/window/taskpanelist.cxx
+++ b/vcl/source/window/taskpanelist.cxx
@@ -28,7 +28,8 @@
 #include 
 #include 
 
-// can't have static linkage because SUNPRO 5.2 complains
+namespace {
+
 Point ImplTaskPaneListGetPos( const vcl::Window *w )
 {
 Point pos;
@@ -47,6 +48,8 @@ Point ImplTaskPaneListGetPos( const vcl::Window *w )
 return pos;
 }
 
+}
+
 // compares window pos left-to-right
 struct LTRSort : public ::std::binary_function< const vcl::Window*, const 
vcl::Window*, bool >
 {
commit 07339d03afe742c53c22cb4ff5f73fe3132cff54
Author: Stephan Bergmann 
Date:   Mon Sep 19 21:18:23 2016 +0200

Remove obsolete workaround for SUNPRO 5 compiler

...copy/pasted into three more places

Change-Id: I6661244d0248af509cd867fc3e8c451551068a78

diff --git a/connectivity/source/drivers/firebird/SubComponent.hxx 
b/connectivity/source/drivers/firebird/SubComponent.hxx
index 7a86cf1..5c87097 100644
--- a/connectivity/source/drivers/firebird/SubComponent.hxx
+++ b/connectivity/source/drivers/firebird/SubComponent.hxx
@@ -68,17 +68,7 @@ namespace connectivity
 
 public:
 OPropertyArrayUsageHelper();
-virtual ~OPropertyArrayUsageHelper()
-{   // ARGHHH . would like to implement this in 
proparrhlp_impl.hxx (as we do with all other methods)
-// but SUNPRO 5 compiler (linker) doesn't like this
-::osl::MutexGuard aGuard(s_aMutex);
-OSL_ENSURE(s_nRefCount > 0, 
"OPropertyArrayUsageHelper::~OPropertyArrayUsageHelper : suspicious call : have 
a refcount of 0 !");
-if (!--s_nRefCount)
-{
-delete s_pProps;
-s_pProps = nullptr;
-}
-}
+virtual ~OPropertyArrayUsageHelper();
 
 /** call this in the getInfoHelper method of your derived class. 
The method returns the array helper of the
 class, which is created if necessary.
@@ -117,6 +107,19 @@ namespace connectivity
 
 
 template 
+OPropertyArrayUsageHelper::~OPropertyArrayUsageHelper()
+{
+::osl::MutexGuard aGuard(s_aMutex);
+OSL_ENSURE(s_nRefCount > 0, 
"OPropertyArrayUsageHelper::~OPropertyArrayUsageHelper : suspicious call : have 
a refcount of 0 !");
+if (!--s_nRefCount)
+{
+delete s_pProps;
+s_pProps = nullptr;
+}
+}
+
+
+template 
 ::cppu::IPropertyArrayHelper* 
OPropertyArrayUsageHelper::getArrayHelper()
 {
 OSL_ENSURE(s_nRefCount, "OPropertyArrayUsageHelper::getArrayHelper 
: suspicious call : have a refcount of 0 !");
diff --git a/include/comphelper/proparrhlp.hxx 
b/include/comphelper/proparrhlp.hxx
index 0f8fe7e..507c51b 100644
--- a/include/comphelper/proparrhlp.hxx
+++ b/include/comphelper/proparrhlp.hxx
@@ -45,18 +45,7 @@ protected:
 
 public:
 OPropertyArrayUsageHelper();
-virtual ~OPropertyArrayUsageHelper()
-{   // ARGHHH . would like to implement this after the class
-// definition (as we do with all other methods) but SUNPRO 5 compiler
-// (linker) doesn't like this
-::osl::MutexGuard aGuard(OPropertyArrayUsageHelperMutex::get());
-OSL_ENSURE(s_nRefCount > 0, 
"OPropertyArrayUsageHelper::~OPropertyArrayUsageHelper : suspicious call : have 
a refcount of 0 !");
-if (!--s_nRefCount)
-{
-delete s_pProps;
-s_pProps = nullptr;
-}
-}
+virtual ~OPropertyArrayUsageHelper();
 
 /** call this in the getInfoHelper method of your derived class. The 
method returns the array helper of the
 class, which is created if necessary.
@@ -125,6 +114,18 @@ 
OPropertyArrayUsageHelper::OPropertyArrayUsageHelper()
 }
 
 template 
+OPropertyArrayUsageHelper::~OPropertyArrayUsageHelper()
+{
+::osl::MutexGuard aGuard(OPropertyArrayUsageHelperMutex::get());
+OSL_ENSURE(s_nRefCount > 0, 
"OPropertyArrayUsageHelper::~OPropertyArrayUsageHelper : suspicious call :

[Libreoffice-commits] online.git: loleaflet/dist loleaflet/main.js loleaflet/src

2016-09-19 Thread Pranav Kant 
 loleaflet/dist/toolbar/toolbar.js |   60 ++
 loleaflet/main.js |2 -
 loleaflet/src/layer/tile/TileLayer.js |   16 -
 3 files changed, 6 insertions(+), 72 deletions(-)

New commits:
commit 77e219ceff24dd4a566dfdf4f82a6929fe9a563e
Author: Pranav Kant 
Date:   Tue Sep 20 10:57:39 2016 +0530

loleaflet: Kill editlock code, completely

Editlock buttons have already been removed; most of this code is
unreachable/useless anyways.

Don't listen to editlock messages anymore, and always set the map
permission to edit unless specified.

Change-Id: I2ee672e72beaa48a7c6cd0bbd1c548ff10a251d1

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index f6597f2..8e4e6aa 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -123,13 +123,6 @@ function onClick(id, item, subItem) {
map.setPart(id);
}
}
-   else if (id === 'takeedit') {
-   if (!item.checked) {
-   map._socket.sendMessage('takeedit');
-   // And advertise which page we're on.
-   map._socket.sendMessage('setclientpart part=' + 
map._docLayer._selectedPart);
-   }
-   }
else if (id === 'searchprev') {
map.search(L.DomUtil.get('search-input').value, true);
}
@@ -496,8 +489,6 @@ var formatButtons = {
'incrementindent': true, 'decrementindent': true, 'insertgraphic': true
 };
 
-var takeEditPopupMessage = '' + _('You are viewing now.') + '' + 
_('Click here to take edit.') + '';
-var takeEditPopupTimeout = null;
 var userJoinedPopupMessage = '' + _('%user has joined') + '';
 var userLeftPopupMessage = '' + _('%user has left') + '';
 var userPopupTimeout = null;
@@ -1004,7 +995,9 @@ map.on('commandstatechanged', function (e) {
}
// only store the state for now;
// buttons with stored state === enabled will
-   // be enabled when we get the editlock
+   // be enabled later (if we are in editmode)
+   // If we are in viewmode, these store states will be used
+   // when we get the edit access
else if (state === 'enabled') {
formatButtons[id] = true;
}
@@ -1012,8 +1005,7 @@ map.on('commandstatechanged', function (e) {
formatButtons[id] = false;
}
 
-   // Change the toolbar button state immediately
-   // if we already have the editlock
+   // Change the toolbar button states immediately if we are in 
editmode
if (map._permission === 'edit' && (state === 'enabled' || state 
=== 'disabled')) {
// in case some buttons are in toolbar-up-more, find
// them and en/dis-able them.
@@ -1211,33 +1203,7 @@ map.on('hyperlinkclicked', function (e) {
 });
 
 map.on('updatepermission', function (e) {
-   var toolbar = w2ui['toolbar-down'];
-   if (e.perm === 'edit') {
-   toolbar.disable('takeedit');
-   toolbar.set('takeedit', {hint: _('You are editing (others can 
only view)'), caption: _('EDITING')});
-   }
-   else if (e.perm === 'view') {
-   toolbar.enable('takeedit');
-   toolbar.set('takeedit', {hint: _('Take edit lock (others can 
only view)'), caption: _('VIEWING')});
-   $('#tb_toolbar-down_item_takeedit')
-   .w2overlay({
-   class: 'loleaflet-font',
-   html: takeEditPopupMessage,
-   style: 'padding: 5px'
-   });
-   clearTimeout(takeEditPopupTimeout);
-   takeEditPopupTimeout = setTimeout(function() {
-   $('#tb_toolbar-down_item_takeedit').w2overlay('');
-   clearTimeout(takeEditPopupTimeout);
-   takeEditPopupTimeout = null;
-   }, 3000);
-   }
-   else if (e.perm === 'readonly') {
-   toolbar.disable('takeedit');
-   toolbar.set('takeedit', {hint: _('You are locked in readonly 
mode'), caption: _('READONLY')});
-   }
-
-   toolbar = w2ui['toolbar-up'];
+   var toolbar = w2ui['toolbar-up'];
var toolbarUpMore = w2ui['toolbar-up-more'];
// {En,Dis}able toolbar buttons
for (var id in formatButtons) {
@@ -1317,22 +1283,6 @@ map.on('updatepermission', function (e) {
}
 });
 
-map.on('mouseup keypress', function() {
-   if (map._permission === 'view') {
-   $('#tb_toolbar-down_item_takeedit')
-   .w2overlay({
-   html: takeEditPopupMessage,
-   style:

[Libreoffice-bugs] [Bug 102305] New: Rotation of AutoLayout textboxes not applied

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102305

Bug ID: 102305
   Summary: Rotation of AutoLayout textboxes not applied
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

Steps:
1) Open https://wiki.documentfoundation.org/images/9/98/Progress.otp
2) On slide 1 delete title and content textboxes
3) Reselect the 'Title, Content' layout
4) Notice the textboxes are horizontal rather than being slanted like the
master slide

Version: 5.3.0.0.alpha0+
Build ID: 3287bc2f91438085b7604773d5e0346fc3c3f452
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-09-18_06:17:20
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

2016-09-19 Thread Adolfo Jayme Barrientos 
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ece7079f77efea3fcbd205209fb16f6c9a12bf3f
Author: Adolfo Jayme Barrientos 
Date:   Mon Sep 19 23:21:09 2016 -0500

Updated core
Project: help  229282b80660a023077e5330afbbae51398b9690

It’s called an asterisk

Change-Id: If15846de1cd0df1023198bff74711419ec3137f5

diff --git a/helpcontent2 b/helpcontent2
index e8cbb3d..229282b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e8cbb3daf90aa2a6f2e68c01841535b49d53d066
+Subproject commit 229282b80660a023077e5330afbbae51398b9690
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2016-09-19 Thread Adolfo Jayme Barrientos 
 source/text/shared/01/05020301.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 229282b80660a023077e5330afbbae51398b9690
Author: Adolfo Jayme Barrientos 
Date:   Mon Sep 19 23:21:09 2016 -0500

It’s called an asterisk

Change-Id: If15846de1cd0df1023198bff74711419ec3137f5

diff --git a/source/text/shared/01/05020301.xhp 
b/source/text/shared/01/05020301.xhp
index ad4310d..df8c1f5 100644
--- a/source/text/shared/01/05020301.xhp
+++ b/source/text/shared/01/05020301.xhp
@@ -206,7 +206,7 @@
 
 Spaces
 To use a 
character to define the width of a space in a number format, type an underscore 
( _ ) followed by the character. The width of the space varies according to the 
width of the character that you choose. For example, _M creates a 
wider space than _i.
-To fill free 
space with a given character, use star character (*) followed by this 
character. For instance:
+To fill free 
space with a given character, use an asterisk (*) followed by this character. 
For instance:
 *\0
 will display 
integer value (0) preceded by as many as needed backslash characters (\) to 
fill column width. For accounting representation, you may left align currency 
symbol with a format similar to:
 $_-* 0.--;$-* 
0.--;$_-* -
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102304] AutoLayout textbox background fill should appear even without text

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102304

--- Comment #1 from Yousuf Philips (jay)  ---
3) Notice that these dont appear in the slide preview pane or in slideshow

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102304] New: AutoLayout textbox background fill should appear even without text

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102304

Bug ID: 102304
   Summary: AutoLayout textbox background fill should appear even
without text
   Product: LibreOffice
   Version: 3.4.6 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: notBibisectable, regression
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com

Steps:
1) Open https://wiki.documentfoundation.org/images/5/52/FireRed.otp
2) Notice the red gradient title textboxes on slides 1 and 2
3) Notice that these dont appear in the slide preview pane or when 

Regression as it works correctly in 3.3.0, but is also broken in AOO.

Version: 5.3.0.0.alpha0+
Build ID: 3287bc2f91438085b7604773d5e0346fc3c3f452
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-09-18_06:17:20
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97105] Freeze rows and columns part should be updated.

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97105

--- Comment #3 from Commit Notification 
 ---
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=e8cbb3daf90aa2a6f2e68c01841535b49d53d066

tdf#97105 Fix location of the Freze Rows and Columns menu item

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97105] Freeze rows and columns part should be updated.

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97105

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100819] Can't save my file

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100819

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||273

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2016-09-19 Thread Gabor Kelemen 
 source/text/scalc/00/0407.xhp|2 +-
 source/text/scalc/guide/line_fix.xhp |6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit e8cbb3daf90aa2a6f2e68c01841535b49d53d066
Author: Gabor Kelemen 
Date:   Mon Sep 19 15:10:00 2016 +0200

tdf#97105 Fix location of the Freze Rows and Columns menu item

This is now under View -> Freeze Cells

Change-Id: I6968ee93a1d2f12451791b297b9497eae6e93cd6
Reviewed-on: https://gerrit.libreoffice.org/29024
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/source/text/scalc/00/0407.xhp 
b/source/text/scalc/00/0407.xhp
index 6574661..2021aeb 100644
--- a/source/text/scalc/00/0407.xhp
+++ b/source/text/scalc/00/0407.xhp
@@ -30,7 +30,7 @@
 
 Window 
Menu
 Choose View - Split 
Window
-Choose View - Freeze Rows and 
Columns
+Choose View - Freeze Cells - Freeze Rows and 
Columns
 
 
 
diff --git a/source/text/scalc/guide/line_fix.xhp 
b/source/text/scalc/guide/line_fix.xhp
index 400debb..2dc7810 100644
--- a/source/text/scalc/guide/line_fix.xhp
+++ b/source/text/scalc/guide/line_fix.xhp
@@ -49,15 +49,15 @@
 To freeze 
both horizontally and vertically, select the cell that is below 
the row and to the right of the column that you want to freeze.
   
   
-Choose 
View - Freeze Rows and Columns.
-To 
deactivate, choose View - Freeze Rows and Columns 
again.
+Choose 
View - Freeze Cells - Freeze Rows and 
Columns.
+To 
deactivate, choose View - Freeze Cells - Freeze Rows and 
Columns again.
   
 
 If the area defined 
is to be scrollable, apply the View - Split Window 
command.
 If you want to 
print a certain row on all pages of a document, choose Format - Print ranges - Edit.
 
 
-View - 
Freeze Rows and Columns
+View - Freeze Cells - Freeze Rows and Columns
 View - Split 
Window
 
 Format - 
Print ranges - Edit
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101858] Problems when saving .odt and .ods documents

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101858

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||273

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

2016-09-19 Thread Gabor Kelemen 
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e57baf08d6b1911ac151e5485b2ea8331725324f
Author: Gabor Kelemen 
Date:   Mon Sep 19 15:10:00 2016 +0200

Updated core
Project: help  e8cbb3daf90aa2a6f2e68c01841535b49d53d066

tdf#97105 Fix location of the Freze Rows and Columns menu item

This is now under View -> Freeze Cells

Change-Id: I6968ee93a1d2f12451791b297b9497eae6e93cd6
Reviewed-on: https://gerrit.libreoffice.org/29024
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index f3339c9..e8cbb3d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit f3339c932c24d48eb854399d92cd7ca64fe3ea1c
+Subproject commit e8cbb3daf90aa2a6f2e68c01841535b49d53d066
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/TileCache.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/TileCache.cpp |   21 -
 1 file changed, 12 insertions(+), 9 deletions(-)

New commits:
commit faf6cf7ce414fd61c948058e085c9856d87edd6e
Author: Ashod Nakashian 
Date:   Mon Sep 19 20:51:10 2016 -0400

loolwsd: better logging in subscribeToTileRendering

Change-Id: I5b94cda02e4f0e1154de81fc7bb4380332f2eeeb
Reviewed-on: https://gerrit.libreoffice.org/29070
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp
index c7dfd6e..ba20c8d 100644
--- a/loolwsd/TileCache.cpp
+++ b/loolwsd/TileCache.cpp
@@ -423,26 +423,30 @@ void TileCache::saveLastModified(const Timestamp& 
timestamp)
 // FIXME: to be further simplified when we centralize tile messages.
 int TileCache::subscribeToTileRendering(const TileDesc& tile, const 
std::shared_ptr )
 {
+assert(subscriber->getKind() == LOOLSession::Kind::ToClient);
+
 std::unique_lock lock(_tilesBeingRenderedMutex);
 
 std::shared_ptr tileBeingRendered = 
findTileBeingRendered(tile);
 
+std::ostringstream oss;
+oss << '(' << tile.getPart() << ',' << tile.getTilePosX() << ',' << 
tile.getTilePosY() << ')';
+const auto name = oss.str();
+
 if (tileBeingRendered)
 {
-Log::debug() << "Subscribing to tile (" << tile.getPart() << ',' << 
tile.getTilePosX() << ','
- << tile.getTilePosY() << ") which has "
- << tileBeingRendered->_subscribers.size()
- << " subscribers already. Adding one more." << Log::end;
-assert(subscriber->getKind() == LOOLSession::Kind::ToClient);
-
 for (const auto  : tileBeingRendered->_subscribers)
 {
 if (s.lock().get() == subscriber.get())
 {
-Log::debug("Redundant request to re-subscribe on a tile");
+Log::debug("Redundant request to subscribe on tile " + name);
 return 0;
 }
 }
+
+Log::debug() << "Subscribing to tile " << name << " which has "
+ << tileBeingRendered->_subscribers.size()
+ << " subscribers already. Adding one more." << Log::end;
 tileBeingRendered->_subscribers.push_back(subscriber);
 
 const auto duration = (std::chrono::steady_clock::now() - 
tileBeingRendered->getStartTime());
@@ -456,8 +460,7 @@ int TileCache::subscribeToTileRendering(const TileDesc& 
tile, const std::shared_
 }
 else
 {
-Log::debug() << "Subscribing to tile (" << tile.getPart() << ',' << 
tile.getTilePosX() << ','
- << tile.getTilePosY() << ") which has no subscribers. 
Subscribing for ver: "
+Log::debug() << "Subscribing to tile " << name << " which has no 
subscribers. Subscribing for ver: "
  << tile.getVersion() << "." << Log::end;
 
 const std::string cachedName = cacheFileName(tile);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/TileDesc.hpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/TileDesc.hpp |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 454b2b71c18ace94f16dcf1f203c4d20cf9f1dce
Author: Ashod Nakashian 
Date:   Mon Sep 19 20:30:35 2016 -0400

loolwsd: don't generate imgsize in tile when 0

Change-Id: I469bdbfbb5efd8230808e6c68f58f505acef3993
Reviewed-on: https://gerrit.libreoffice.org/29069
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TileDesc.hpp b/loolwsd/TileDesc.hpp
index e4d2c36..0258645 100644
--- a/loolwsd/TileDesc.hpp
+++ b/loolwsd/TileDesc.hpp
@@ -81,8 +81,13 @@ public:
 << " tileposy=" << _tilePosY
 << " tilewidth=" << _tileWidth
 << " tileheight=" << _tileHeight
-<< " ver=" << _ver
-<< " imgsize=" << _imgSize;
+<< " ver=" << _ver;
+
+if (_imgSize > 0)
+{
+oss << " imgsize=" << _imgSize;
+}
+
 if (_id >= 0)
 {
 oss << " id=" << _id;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/test loolwsd/TileCache.cpp loolwsd/TileCache.hpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/DocumentBroker.cpp  |8 ++--
 loolwsd/TileCache.cpp   |   14 +-
 loolwsd/TileCache.hpp   |2 +-
 loolwsd/test/TileCacheTests.cpp |2 +-
 4 files changed, 9 insertions(+), 17 deletions(-)

New commits:
commit ec4b4898859f2849ba7888b04dc688f804cb6975
Author: Ashod Nakashian 
Date:   Mon Sep 19 20:21:18 2016 -0400

loolwsd: remove unused priority flag from saveTileAndNotify

Change-Id: I49309bb80a6b9e9e8265da8f8db966b98e362f0a
Reviewed-on: https://gerrit.libreoffice.org/29068
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 78cc9e7..5ef3f60 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -609,13 +609,9 @@ void DocumentBroker::handleTileResponse(const 
std::vector& payload)
 
 if (firstLine.size() < static_cast(length) - 1)
 {
-// If the tile right under the cursor, give it priority.
-const bool priority = tile.intersectsWithRect(
-_cursorPosX, _cursorPosY,
-_cursorWidth, _cursorHeight);
 tileCache().saveTileAndNotify(
 tile, buffer + firstLine.size() + 1,
-length - firstLine.size() - 1, priority);
+length - firstLine.size() - 1);
 }
 else
 {
@@ -648,7 +644,7 @@ void DocumentBroker::handleTileCombinedResponse(const 
std::vector& payload
 {
 for (const auto& tile : tileCombined.getTiles())
 {
-tileCache().saveTileAndNotify(tile, buffer + offset, 
tile.getImgSize(), false);
+tileCache().saveTileAndNotify(tile, buffer + offset, 
tile.getImgSize());
 offset += tile.getImgSize();
 }
 }
diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp
index 9e3bca7..c7dfd6e 100644
--- a/loolwsd/TileCache.cpp
+++ b/loolwsd/TileCache.cpp
@@ -140,19 +140,11 @@ std::unique_ptr TileCache::lookupTile(const 
TileDesc& tile)
 return nullptr;
 }
 
-void TileCache::saveTileAndNotify(const TileDesc& tile, const char *data, 
const size_t size, const bool /* priority */)
+void TileCache::saveTileAndNotify(const TileDesc& tile, const char *data, 
const size_t size)
 {
 std::unique_lock lock(_tilesBeingRenderedMutex);
 
 std::shared_ptr tileBeingRendered = 
findTileBeingRendered(tile);
-#if 0
-if (!priority && tileBeingRendered && tileBeingRendered->getVersion() != 
tile.getVersion())
-{
-Log::trace() << "Skipping unexpected tile ver: " << tile.getVersion()
- << ", waiting for ver " << 
tileBeingRendered->getVersion() << Log::end;
-return;
-}
-#endif
 
 // Save to disk.
 const auto cachedName = (tileBeingRendered ? 
tileBeingRendered->getCacheName()
@@ -197,6 +189,10 @@ void TileCache::saveTileAndNotify(const TileDesc& tile, 
const char *data, const
 }
 }
 }
+else
+{
+Log::debug("No subscribers for: " + cachedName);
+}
 
 // Remove subscriptions.
 if (tileBeingRendered->getVersion() == tile.getVersion())
diff --git a/loolwsd/TileCache.hpp b/loolwsd/TileCache.hpp
index bbe5aa0..08b14e0 100644
--- a/loolwsd/TileCache.hpp
+++ b/loolwsd/TileCache.hpp
@@ -44,7 +44,7 @@ public:
 
 std::unique_ptr lookupTile(const TileDesc& tile);
 
-void saveTileAndNotify(const TileDesc& tile, const char *data, const 
size_t size, const bool priority);
+void saveTileAndNotify(const TileDesc& tile, const char *data, const 
size_t size);
 
 std::string getTextFile(const std::string& fileName);
 
diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index a4d3527..b9f8900 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -159,7 +159,7 @@ void TileCacheTests::testSimple()
 // Cache Tile
 const auto size = 1024;
 const auto data = genRandomData(size);
-tc.saveTileAndNotify(tile, data.data(), size, true);
+tc.saveTileAndNotify(tile, data.data(), size);
 
 // Find Tile
 file = tc.lookupTile(tile);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   28 +++-
 1 file changed, 11 insertions(+), 17 deletions(-)

New commits:
commit a9fbfe8d8ac802086844e307dff979a8e1436ba2
Author: Ashod Nakashian 
Date:   Sat Sep 17 10:09:47 2016 -0400

loolwsd: remove queue thread from child socket handler

Change-Id: Ib6b4890db1f331b2e2cdcfafb57366ff62e3a13d
Reviewed-on: https://gerrit.libreoffice.org/29067
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 51c33f3..02919e6 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -57,7 +57,6 @@
 #include "LibreOfficeKit.hpp"
 #include "Log.hpp"
 #include "Png.hpp"
-#include "QueueHandler.hpp"
 #include "Rectangle.hpp"
 #include "TileDesc.hpp"
 #include "Unit.hpp"
@@ -320,27 +319,21 @@ public:
 Log::debug("Thread started.");
 try
 {
-auto queue = std::make_shared();
-QueueHandler handler(queue, _session, "kit_queue_" + 
_session->getId());
-
-Thread queueHandlerThread;
-queueHandlerThread.start(handler);
-std::shared_ptr session = _session;
-
 IoUtil::SocketProcessor(_ws,
-[](const std::vector& payload)
+[this](const std::vector& payload)
 {
-queue->put(payload);
+if (!_session->handleInput(payload.data(), payload.size()))
+{
+Log::info("Socket handler flagged for finishing.");
+return false;
+}
+
 return true;
 },
-[]() { session->closeFrame(); },
-[]() { return TerminationFlag || 
!queueHandlerThread.isRunning(); });
-
-queue->clear();
-queue->put("eof");
-queueHandlerThread.join();
+[this]() { _session->closeFrame(); },
+[]() { return !!TerminationFlag; });
 
-if (session->isCloseFrame())
+if (_session->isCloseFrame())
 {
 Log::trace("Normal close handshake.");
 _ws->shutdown();
@@ -1503,6 +1496,7 @@ void lokit_main(const std::string& childRoot,
 requestUrl += "=" + encodedVersionStr;
 free(versionInfo);
 }
+
 HTTPRequest request(HTTPRequest::HTTP_GET, requestUrl);
 HTTPResponse response;
 auto ws = std::make_shared(cs, request, response);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ClientSession.cpp loolwsd/ClientSession.hpp loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/test loolwsd/TileCache.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/ClientSession.cpp  |2 --
 loolwsd/ClientSession.hpp  |9 -
 loolwsd/DocumentBroker.cpp |6 --
 loolwsd/LOOLWSD.cpp|   28 ++--
 loolwsd/TileCache.cpp  |   27 ---
 loolwsd/test/Makefile.am   |1 +
 6 files changed, 31 insertions(+), 42 deletions(-)

New commits:
commit e7272019dc28da7b66a7db145bda9a9c3db1380c
Author: Ashod Nakashian 
Date:   Wed Aug 31 23:34:41 2016 -0400

loolwsd: remove tile queue and simplify tile response

Tile queue was used to process canceltiles commands.
Since those are handled by TileCache, there is no need
for queues and the threads that pump them.

But because these queues were also used to buffer between
WSD internals and clients, such that a slow client wouldn't
block WSD while sending back tiles, it is necessary
to reword that logic.
In subsequent commits that will change as well.

With this change not only do we save a thread per client,
but we also reduce latency of tile, and improve typing
responsiveness, by almost 3x or more! Latencies are
down to ~15ms from almost 50ms.

Reviewed-on: https://gerrit.libreoffice.org/28575
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 59eaacd2f87f46c4c4d2963ef54f4d20d346b2d0)

Change-Id: I77813267a95a724491165792ec020ae00953c05e
Reviewed-on: https://gerrit.libreoffice.org/29066
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ClientSession.cpp b/loolwsd/ClientSession.cpp
index 533844f..b493c58 100644
--- a/loolwsd/ClientSession.cpp
+++ b/loolwsd/ClientSession.cpp
@@ -37,11 +37,9 @@ using Poco::StringTokenizer;
 ClientSession::ClientSession(const std::string& id,
  std::shared_ptr ws,
  std::shared_ptr docBroker,
- std::shared_ptr queue,
  bool readOnly) :
 LOOLSession(id, Kind::ToClient, ws),
 _docBroker(std::move(docBroker)),
-_queue(std::move(queue)),
 _isReadOnly(readOnly),
 _loadFailed(false),
 _loadPart(-1)
diff --git a/loolwsd/ClientSession.hpp b/loolwsd/ClientSession.hpp
index e6f3098..a285efe 100644
--- a/loolwsd/ClientSession.hpp
+++ b/loolwsd/ClientSession.hpp
@@ -23,7 +23,6 @@ public:
 ClientSession(const std::string& id,
   std::shared_ptr ws,
   std::shared_ptr docBroker,
-  std::shared_ptr queue,
   bool isReadOnly = false);
 
 virtual ~ClientSession();
@@ -58,11 +57,6 @@ public:
 _loadFailed = true;
 }
 
-void sendToInputQueue(const std::string& message)
-{
-_queue->put(message);
-}
-
 std::shared_ptr getDocumentBroker() const { return 
_docBroker; }
 
 private:
@@ -83,9 +77,6 @@ private:
 
 std::shared_ptr _docBroker;
 
-/// The incoming message queue.
-std::shared_ptr _queue;
-
 // Whether the session is opened as readonly
 bool _isReadOnly;
 
diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 1e58e76..78cc9e7 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -364,8 +364,10 @@ bool DocumentBroker::sendUnoSave(const bool 
dontSaveIfUnmodified)
 // arguments end
 oss << "}";
 
-Log::debug(".uno:Save arguments: " + oss.str());
-sessionIt.second->sendToInputQueue("uno .uno:Save " + oss.str());
+const auto saveArgs = oss.str();
+Log::trace(".uno:Save arguments: " + saveArgs);
+const auto command = "uno .uno:Save " + saveArgs;
+sessionIt.second->handleInput(command.data(), command.size());
 return true;
 }
 
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 9f1d6d7..266ac7c 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -399,7 +399,7 @@ private:
 
 // Load the document.
 std::shared_ptr ws;
-auto session = std::make_shared(id, ws, 
docBroker, nullptr);
+auto session = std::make_shared(id, ws, 
docBroker);
 
 // Request the child to connect to us and add this session.
 auto sessionsCount = docBroker->addSession(session);
@@ -686,10 +686,7 @@ private:
 std::shared_ptr session;
 try
 {
-// For ToClient sessions, we store incoming messages in a queue 
and have a separate
-// thread to pump them. This is to empty the queue when we get a 
"canceltiles" message.
-auto queue = std::make_shared();
-session = std::make_shared(id, ws, docBroker, 
queue, isReadOnly);
+session = std::make_shared(id, ws, docBroker, 
isReadOnly);
 if

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/DocumentBroker.cpp |   24 ++--
 1 file changed, 2 insertions(+), 22 deletions(-)

New commits:
commit 1255cc11d894685362249d48063f000e75adc0d3
Author: Ashod Nakashian 
Date:   Mon Sep 19 20:29:40 2016 -0400

loolwsd: version each tile and simplify tilecombine request handling

Change-Id: I369b05a747182cb387141d09ecb5098e1dd16901
Reviewed-on: https://gerrit.libreoffice.org/29065
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 709c2a0..1e58e76 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -545,11 +545,9 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 {
 std::unique_lock lock(_mutex);
 
-tileCombined.setVersion(++_tileVersion);
 Log::trace() << "TileCombined request for " << tileCombined.serialize() << 
Log::end;
 
 // Satisfy as many tiles from the cache.
-std::vector tiles;
 for (auto& tile : tileCombined.getTiles())
 {
 std::unique_ptr cachedTile = 
_tileCache->lookupTile(tile);
@@ -577,12 +575,11 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 cachedTile->close();
 
 session->sendBinaryFrame(output.data(), output.size());
-continue;
 }
 else
 {
 // Not cached, needs rendering.
-tile.setVersion(_tileVersion);
+tile.setVersion(++_tileVersion);
 const auto ver = tileCache().subscribeToTileRendering(tile, 
session);
 if (ver <= 0)
 {
@@ -590,29 +587,12 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 continue;
 }
 else
-if (tile.intersectsWithRect(_cursorPosX, _cursorPosY,
-_cursorWidth, _cursorHeight))
 {
-// If this tile is right under the cursor, give it priority.
 const auto req = tile.serialize("tile");
-Log::debug() << "Priority tile request: " << req << Log::end;
+Log::debug() << "Tile request: " << req << Log::end;
 _childProcess->getWebSocket()->sendFrame(req.data(), 
req.size());
-
-// No need to process with the group anymore.
-continue;
 }
 }
-
-tiles.push_back(tile);
-}
-
-for (auto& tile : tiles)
-{
-const auto tileMsg = tile.serialize("tile ");
-Log::debug() << "TileCombined residual request for " << tileMsg << 
Log::end;
-
-// Forward to child to render.
-_childProcess->getWebSocket()->sendFrame(tileMsg.data(), 
tileMsg.size());
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/DocumentBroker.cpp |   29 +
 1 file changed, 5 insertions(+), 24 deletions(-)

New commits:
commit 7a8248875dcf6627e302b918c105438673ed0112
Author: Ashod Nakashian 
Date:   Fri Sep 2 07:29:59 2016 -0400

loolwsd: don't combine tiles by row to allow for better culling

Reviewed-on: https://gerrit.libreoffice.org/28615
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 99d0ee2ac111e7199626f6c17fb7ce723dac9126)

Change-Id: Ibfe6b7430cbdf78bc13b42d19789ce23226a5a5a
Reviewed-on: https://gerrit.libreoffice.org/29064
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index cd4639f..709c2a0 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -549,8 +549,7 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 Log::trace() << "TileCombined request for " << tileCombined.serialize() << 
Log::end;
 
 // Satisfy as many tiles from the cache.
-// The rest, group by rows.
-std::map rows;
+std::vector tiles;
 for (auto& tile : tileCombined.getTiles())
 {
 std::unique_ptr cachedTile = 
_tileCache->lookupTile(tile);
@@ -604,34 +603,16 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 }
 }
 
-const auto tilePosY = tile.getTilePosY();
-auto it = rows.lower_bound(tilePosY);
-if (it != rows.end())
-{
-it->second.emplace_back(tile);
-}
-else
-{
-rows.emplace_hint(it, tilePosY, std::vector({ tile }));
-}
+tiles.push_back(tile);
 }
 
-if (rows.empty())
+for (auto& tile : tiles)
 {
-// Done.
-return;
-}
-
-auto& tiles = tileCombined.getTiles();
-for (auto& row : rows)
-{
-tiles = row.second;
-const auto tileMsg = tileCombined.serialize();
+const auto tileMsg = tile.serialize("tile ");
 Log::debug() << "TileCombined residual request for " << tileMsg << 
Log::end;
 
 // Forward to child to render.
-const std::string request = "tilecombine " + tileMsg;
-_childProcess->getWebSocket()->sendFrame(request.data(), 
request.size());
+_childProcess->getWebSocket()->sendFrame(tileMsg.data(), 
tileMsg.size());
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   25 ++---
 1 file changed, 22 insertions(+), 3 deletions(-)

New commits:
commit 23ef612970ff5e90ffc8da63f503170aef9a56be
Author: Ashod Nakashian 
Date:   Sat Sep 17 10:04:28 2016 -0400

loolwsd: ensure that the connection thread is running

If the connection thread is not running when loading a
document, the callback will drop events. This can happen
when the thread is too slow to spawn, but we return from
the createSession function and process client messages.

This should solve the race where we lose notifications of
other views when a new view is created.

Change-Id: Ia79739889b2f01fbb374d48eb33620084f4ed1c1
Reviewed-on: https://gerrit.libreoffice.org/29063
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 252cfb3..51c33f3 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define LOK_USE_UNSTABLE_API
 #include 
@@ -279,6 +280,16 @@ public:
 void start()
 {
 _thread.start(*this);
+
+// Busy-wait until we run.
+// This is important to make sure we can process
+// callbacks, which if we're late to start will
+// be dropped. No need for async notification here.
+constexpr auto delay = COMMAND_TIMEOUT_MS / 20;
+for (auto i = 0; i < 20 && !isRunning(); ++i)
+{
+std::this_thread::sleep_for(std::chrono::milliseconds(delay));
+}
 }
 
 bool isRunning()
@@ -871,15 +882,23 @@ private:
 bool isFound = false;
 for (auto& it : pDescr->Doc->_connections)
 {
-if (it.second->isRunning())
+auto session = it.second->getSession();
+if (session && session->getViewId() == pDescr->ViewId)
 {
-auto session = it.second->getSession();
-if (session && session->getViewId() == pDescr->ViewId)
+if (it.second->isRunning())
 {
 isFound = true;
 auto pNotif = new CallbackNotification(session, nType, 
payload);
 pDescr->Doc->_callbackQueue.enqueueNotification(pNotif);
 }
+else
+{
+Log::error() << "Connection thread for session " << 
it.second->getSessionId() << " for view "
+ << pDescr->ViewId << " is not running. 
Dropping [" << LOKitHelper::kitCallbackTypeToString(nType)
+ << "] payload [" << payload << "]." << 
Log::end;
+}
+
+break;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/Connect.cpp loolwsd/LOOLWSD.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/Connect.cpp |4 +++-
 loolwsd/LOOLWSD.cpp |2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 53ba8a130785778603db65d454e4f7ea158588f5
Author: Ashod Nakashian 
Date:   Sat Sep 17 09:48:39 2016 -0400

loolwsd: use std sleep_for rather than POSIX or Poco

Change-Id: Icce28f2ee61035534431bb8b5d7df93b00ad2fc3
Reviewed-on: https://gerrit.libreoffice.org/29062
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Connect.cpp b/loolwsd/Connect.cpp
index 5b10efa..eb91903 100644
--- a/loolwsd/Connect.cpp
+++ b/loolwsd/Connect.cpp
@@ -14,6 +14,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -200,7 +201,8 @@ protected:
 std::unique_lock lock(coutMutex);
 std::cout << "Sleeping " << sleepTime << " seconds" << 
std::endl;
 }
-Thread::sleep(sleepTime * 1000);
+
+std::this_thread::sleep_for(std::chrono::seconds(sleepTime));
 }
 else if (line == "exit")
 {
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index b496a1b..9f1d6d7 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1923,7 +1923,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 }
 }
 
-sleep(WSD_SLEEP_SECS);
+std::this_thread::sleep_for(std::chrono::seconds(WSD_SLEEP_SECS));
 
 // Make sure we have sufficient reserves.
 prespawnChildren();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   39 ++-
 1 file changed, 18 insertions(+), 21 deletions(-)

New commits:
commit bad8ae9ed99879dbdac6cb37d425c922ba047d5b
Author: Ashod Nakashian 
Date:   Sat Sep 17 09:18:33 2016 -0400

loolwsd: one anonymous namespace per file is enough

Change-Id: I12b4967a321de45fc50ad314775d01499b5edd80
Reviewed-on: https://gerrit.libreoffice.org/29061
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index d5d3fc9..252cfb3 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -231,6 +231,24 @@ namespace
 cap_free(caps);
 }
 
+void symlinkPathToJail(const Path& jailPath, const std::string ,
+   const std::string )
+{
+Path symlinkSource(jailPath, Path(loTemplate.substr(1)));
+File(symlinkSource.parent()).createDirectories();
+
+std::string symlinkTarget;
+for (auto i = 0; i < Path(loTemplate).depth(); i++)
+symlinkTarget += "../";
+symlinkTarget += loSubPath;
+
+Log::debug("symlink(\"" + symlinkTarget + "\",\"" + 
symlinkSource.toString() + "\")");
+if (symlink(symlinkTarget.c_str(), symlinkSource.toString().c_str()) 
== -1)
+{
+Log::syserror("symlink(\"" + symlinkTarget + "\",\"" + 
symlinkSource.toString() + "\") failed");
+throw Exception("symlink() failed");
+}
+}
 }
 
 /// Connection thread with a client (via WSD).
@@ -1292,27 +1310,6 @@ private:
 std::atomic_size_t _clientViews;
 };
 
-namespace {
-void symlinkPathToJail(const Path& jailPath, const std::string ,
-   const std::string )
-{
-Path symlinkSource(jailPath, Path(loTemplate.substr(1)));
-File(symlinkSource.parent()).createDirectories();
-
-std::string symlinkTarget;
-for (auto i = 0; i < Path(loTemplate).depth(); i++)
-symlinkTarget += "../";
-symlinkTarget += loSubPath;
-
-Log::debug("symlink(\"" + symlinkTarget + "\",\"" + 
symlinkSource.toString() + "\")");
-if (symlink(symlinkTarget.c_str(), symlinkSource.toString().c_str()) 
== -1)
-{
-Log::syserror("symlink(\"" + symlinkTarget + "\",\"" + 
symlinkSource.toString() + "\") failed");
-throw Exception("symlink() failed");
-}
-}
-}
-
 void lokit_main(const std::string& childRoot,
 const std::string& sysTemplate,
 const std::string& loTemplate,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/loolwsd.xml.in loolwsd/TraceFile.hpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/TraceFile.hpp  |7 +++
 loolwsd/loolwsd.xml.in |2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 74f796d91ab2871ad8da9025a59a8449dc4375fb
Author: Ashod Nakashian 
Date:   Mon Sep 19 18:48:30 2016 -0400

loolwsd: flush trace file on events

This reduces chances of data loss and gives
more up-to-date data to the user.

Also include tile messages in the trace recording,
since they are useful for debugging. Should be
disabled to reduce excessive trace generation.

Change-Id: I223144660698843f4e94564e049883db898c0064
Reviewed-on: https://gerrit.libreoffice.org/29060
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/TraceFile.hpp b/loolwsd/TraceFile.hpp
index 576121f..8c32d47 100644
--- a/loolwsd/TraceFile.hpp
+++ b/loolwsd/TraceFile.hpp
@@ -71,6 +71,7 @@ public:
 void writeEvent(const std::string& pId, const std::string& sessionId, 
const std::string& data)
 {
 write(pId, sessionId, data, 
static_cast(TraceFileRecord::Direction::Event));
+flush();
 }
 
 void writeIncoming(const std::string& pId, const std::string& sessionId, 
const std::string& data)
@@ -89,6 +90,12 @@ public:
 }
 }
 
+void flush()
+{
+_deflater.flush();
+_stream.flush();
+}
+
 private:
 void write(const std::string& pId, const std::string& sessionId, const 
std::string& data, const char delim)
 {
diff --git a/loolwsd/loolwsd.xml.in b/loolwsd/loolwsd.xml.in
index 56de388..20b1dd7 100644
--- a/loolwsd/loolwsd.xml.in
+++ b/loolwsd/loolwsd.xml.in
@@ -36,7 +36,7 @@
 
 /tmp/looltrace.gz
 
-tile.*
+
 
 
 false
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

2016-09-19 Thread Ashod Nakashian 
 loolwsd/DocumentBroker.cpp |   15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

New commits:
commit b0f20ea35f604494df28ad6b2e2b377b60185f52
Author: Ashod Nakashian 
Date:   Mon Sep 19 19:18:07 2016 -0400

loolwsd: proper tracing of outgoing tile messages

Change-Id: I875743cac144bd4bc357038aa58c9cfe7a3988aa
Reviewed-on: https://gerrit.libreoffice.org/29059
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 182a72c..cd4639f 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -472,19 +472,24 @@ size_t DocumentBroker::removeSession(const std::string& 
id)
 
 bool DocumentBroker::handleInput(const std::vector& payload)
 {
-Log::trace("DocumentBroker got child message: [" + 
LOOLProtocol::getAbbreviatedMessage(payload) + "].");
+const auto msg = LOOLProtocol::getAbbreviatedMessage(payload);
+Log::trace("DocumentBroker got child message: [" + msg + "].");
 
-const auto command = LOOLProtocol::getFirstToken(payload);
-LOOLWSD::dumpOutgoingTrace(getJailId(), "0", command);
+LOOLWSD::dumpOutgoingTrace(getJailId(), "0", msg);
 
-if (command == "tile:")
+if (msg.find("tile:") == 0)
 {
 handleTileResponse(payload);
 }
-else if (command == "tilecombine:")
+else if (msg.find("tilecombine:") == 0)
 {
handleTileCombinedResponse(payload);
 }
+else
+{
+Log::error("Unexpected message: [" + msg + "].");
+return false;
+}
 
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/loolwsd.xml.in

2016-09-19 Thread Ashod Nakashian 
 loolwsd/loolwsd.xml.in |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 6f7115ebc6302abed9c50d89679d786f50ad3575
Author: Ashod Nakashian 
Date:   Mon Sep 19 20:52:05 2016 -0400

loolwsd: added config for logging to file

Change-Id: Ib4942af2e9875018fbb27e1666912ca8f8b4e901
Reviewed-on: https://gerrit.libreoffice.org/29058
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/loolwsd.xml.in b/loolwsd/loolwsd.xml.in
index 6ddba26..56de388 100644
--- a/loolwsd/loolwsd.xml.in
+++ b/loolwsd/loolwsd.xml.in
@@ -21,6 +21,16 @@
 
 true
 trace
+
+loolwsd.log
+never
+timestamp
+true
+10 days
+10
+true
+false
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102303] New: Drawing a line over an image is sent to back after document is closed.

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102303

Bug ID: 102303
   Summary: Drawing a line over an image is sent to back after
document is closed.
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ramiroar...@pochta.ru

User-Agent:   Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:48.0)
Gecko/20100101 Firefox/48.0
Build Identifier: Build ID: 1:5.2.1~rc2-0ubuntu1~trusty0

Let us say you are creating a document in Writer with screenshots. Then you
draw a line over the screenshot to explain something. Part of the line is over
the image and part of the line is on the outside coming from a text. While the
document is opened the line remains over the image, as you draw it. But once
you saved and then closed the document and then opened the document the line is
no longer over the image. And this bug occurs in LibreOffice for Ubuntu and for
Windows. And this bug is coming from several previous versions of Writer. 

Reproducible: Always

Steps to Reproduce:
1. Opened Writer. Put an image in your document. 
2. From the Draw tool bar select Line. The draw the line so part of it is over
the image and part of it is outside the image. 
3. Save the document, close the document. Opened the document, now the line is
no longer over the image.
Actual Results:  
The result is always the same, as I described in the steps to reproduce.

Expected Results:  
If I draw the line over an image I expect the line remains over the image.

The bug appears on several machines with different operating systems, Windows
7, Windows 8, Ubuntu 14.04, Xubuntu.


Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94903] Digital Signatures are not working with 64-Bit LibreOffice 5.0.2.2 and 32-Bit LibreOffice 5.2.x in Windows

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94903

yanjing...@gmail.com changed:

   What|Removed |Added

Summary|Digital Signatures are not  |Digital Signatures are not
   |working with 64-Bit |working with 64-Bit
   |LibreOffice 5.0.2.2 |LibreOffice 5.0.2.2 and
   ||32-Bit LibreOffice 5.2.x in
   ||Windows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94903] Digital Signatures are not working with 64-Bit LibreOffice 5.0.2.2

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94903

yanjing...@gmail.com changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All

--- Comment #7 from yanjing...@gmail.com ---
Version: 5.2.2.1
Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
Locale: zh-CN (zh_CN); Calc: single

Now, LibreOffice 5.2.0 and 5.2.2 32bit cannot sign documnet either.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102302] New: 'Title Slide' and 'Centered Text' slide layouts ignores content colors

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102302

Bug ID: 102302
   Summary: 'Title Slide' and 'Centered Text' slide layouts
ignores content colors
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: philip...@hotmail.com
CC: libreoffice-ux-advise@lists.freedesktop.org,
rb.hensc...@t-online.de

Steps:
1) Start impress
2) Switch to master slide mode
3) Set text color and bullet color of title and content textboxes to red
4) Close master slide mode
5) Notice that non-title textbox isnt red
6) Change slide layout to 'Title, Content' and notice it is now red
7) Switch to 'Centered Text' slide layout and notice that it isnt red

Not sure if this how it was meant to be, but this seems strange to me.

Version: 5.3.0.0.alpha0+
Build ID: 3287bc2f91438085b7604773d5e0346fc3c3f452
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-09-18_06:17:20
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102302] New: 'Title Slide' and 'Centered Text' slide layouts ignores content colors

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102302

Bug ID: 102302
   Summary: 'Title Slide' and 'Centered Text' slide layouts
ignores content colors
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
CC: libreoffice-ux-adv...@lists.freedesktop.org,
rb.hensc...@t-online.de

Steps:
1) Start impress
2) Switch to master slide mode
3) Set text color and bullet color of title and content textboxes to red
4) Close master slide mode
5) Notice that non-title textbox isnt red
6) Change slide layout to 'Title, Content' and notice it is now red
7) Switch to 'Centered Text' slide layout and notice that it isnt red

Not sure if this how it was meant to be, but this seems strange to me.

Version: 5.3.0.0.alpha0+
Build ID: 3287bc2f91438085b7604773d5e0346fc3c3f452
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-09-18_06:17:20
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102301] After export to HTML, bullet lists lose indentation and alignment

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102301

--- Comment #2 from Leif Arne Storset  ---
Created attachment 127446
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127446=edit
Demonstration of nicer-looking bullets in HTML

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102301] After export to HTML, bullet lists lose indentation and alignment

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102301

--- Comment #1 from Leif Arne Storset  ---
Created attachment 127445
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127445=edit
HTML file with ugly bullets

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102301] New: After export to HTML, bullet lists lose indentation and alignment

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102301

Bug ID: 102301
   Summary: After export to HTML, bullet lists lose indentation
and alignment
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leifa...@storset.net

Created attachment 127444
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127444=edit
ODT file with bullet points

To reproduce:

1. Create a Writer document.
2. Press Shift+F12 to start a bullet list.
3. Type some list items, one of them long enough to cause the line to wrap.
4. Export to HTML.

Or load the attached ODT and export it.

Expected:

The bullets look pretty. :) Specifically:

- There is some space between the left margin, the bullet and the text.
- When the text in a list item wraps, the second line should line up with the
  first line. Something like this ASCII text does.

One way of achieving this would be to use the default stylesheet for HTML used
automatically by all browsers. Or, use one of the default list marker types, or
a custom 'list-style-image'.

See also the attached "bullet-better.html".

Actual:

- The bullet is exactly aligned with the left margin. It is nearly touching the
  text of the list item.
- Wrapped lines line up with the left margin and the bullet.

This happens because the stylesheet sets margin and padding to zero, which
removes the browser's default indentation:

ol, ul { margin:0; padding:0;}

and also removes the default list-item marker:

li { list-style: none; margin:0; padding:0;}

See the attached "bullets.html".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102300] Heading becomes numbered when exported to HTML

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102300

--- Comment #1 from Leif Arne Storset  ---
Created attachment 127443
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127443=edit
HTML file with numbered heading

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102300] New: Heading becomes numbered when exported to HTML

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102300

Bug ID: 102300
   Summary: Heading becomes numbered when exported to HTML
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leifa...@storset.net

Created attachment 127442
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127442=edit
ODT file without numbering

I was editing a document and customized one of the heading styles. I'm not sure
exactly what I did wrong, but no error was apparent while editing. Only when I
exported the document did the heading show up numbered. The number is written
out in the mark-up, not in the stylesheet.

To reproduce, load the attached ODT and export it to HTML. I expect no
numbering in the document, but see "1.1Second heading" instead, as in the
attached HTML.

I expect I must have accidentally enabled some numbering that just didn't
display in the Web or Normal views, but still was stored in the stylesheet. It
could be that the exporter must take some edge case into account.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98001] File/New, Recent documents, Wizards cannot be disabled

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98001

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #6 from Aron Budea  ---
Not sure what's going on inside, but undo still doesn't enable File -> New and
File -> Wizards. That doesn't seem to be okay... or is it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97455] Copied text appears with big delay in the clipboard

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97455

--- Comment #6 from Dmitry  ---
I still have problems with LibreOffice 5.1.2.2. Actually, "About" dialog has
the same problem: go to "Help → About LibreOffice", select some text, press
Ctrl-C and try to paste into notebook. Few seconds delay is guaranteed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98365] Crash on first run of 64-bit build with no user profile

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98365

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2295

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101907] Crash on startup with new profile

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101907

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2295

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100300] Crash upon start (LibreOffice recovers, but there's an (empty ) Document Recovery dialog ..)

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100300

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2295

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102295] Some OpenGL drivers need more time to start up

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102295

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||365,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0300,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1907

--- Comment #5 from Aron Budea  ---
I added a bunch of likely duplicates to see also field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80768] Cell ranges with the same Conditional Formatting should be consolidated to 1 range.

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80768

--- Comment #31 from Lenge  ---
(In reply to Markus Mohrhard from comment #30)
> This is not a bug. There is somewhere an enhancement request to allow
> combining equal conditional formats but doing it automatically is surely
> completely wrong and will cause bugs.
While one can argue about this being a bug or rather an enhancement, one thing
is clear: NOT automatically combining DOES cause bugs (as seen in the issues
marked as duplicates of this bug). So lowering the priority is no good signal
IMHO.

There are two fundamental approaches to tackle these bugs:
(1) Automatically combining equally formatted cells (like this bug proposes),
or
(2) eliminate the concept of conditionally formatted cell ranges and make all
conditional formatting a normal per-cell property.
The first approach is probably somewhat harder to implement, yet the second one
might add more bloat if many cells use the same conditional formatting.

However, a separate function for the combining is still a good idea. It'd be
guaranteed to not break things unless explicitly called. And combined with an
option to call it automatically after any changes to conditional formatting, it
would probably satisfy everyone.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60573] Conditional formatting does not allow scrolling

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=60573

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||453

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102266] Refresh tables command not available in the Unity HUD in Base

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102266

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com,
   ||momonas...@gmail.com
 Ever confirmed|0   |1

--- Comment #4 from Maxim Monastirsky  ---
I can reproduce it. The "Refresh Tables" menu item is disabled when Base is
started, because it defaults to the "Forms" mode. One has to switch to "Tables"
to enable it, but the native menu state won't update until the next time the
menu is activated.

This used to work, but was unintentionally broken with:

commit 15436c009e756dd4c94046f9849ad5a186454af8
Date:   Tue Jun 7 13:31:12 2016 +0100

gtk3: move the updating of native menu to right after its activated

try fix that view->toolbars isn't in sync

Change-Id: I095be3003f076193878f2c3ce2a2be5acbe0e33f

The problem is that the HUD implementation found in recent Ubuntu versions
doesn't support activation callback, so if we want to support it, we have to
keep updating the native menu structure in the background, not only when a menu
is activated. Actually that's the only reason we need to keep listening to
status updates in MenuBarManager all the time (as noted in commit
2abdcfd641883f246fe78f2fbe38499c9382c059).

But the previous solution (of commit 2abdcfd641883f246fe78f2fbe38499c9382c059)
to update the whole submenu at any status update, is far from ideal, and seems
to create a performance hit when starting Writer. So probably it would be
better to update only the changed menu item immediately at the status update -
for at least the title and enabled state. I tried to do this but got lots of
warnings like "GLib-GIO-CRITICAL **: g_action_group_get_action_enabled:
assertion 'G_IS_ACTION_GROUP (action_group)' failed" printed to the console.
I'm not entirely sure what to do with this.

@Caolán: Any thoughts on this? How (if at all) should we handle this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 100487, which changed state.

Bug 100487 Summary: "abort() has been called" upon start in debug build
https://bugs.documentfoundation.org/show_bug.cgi?id=100487

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102295] Some OpenGL drivers need more time to start up

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102295

Jan Holesovsky  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #4 from Jan Holesovsky  ---
*** Bug 100487 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100487] "abort() has been called" upon start in debug build

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100487

Jan Holesovsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Jan Holesovsky  ---
Resolving as a duplicate, seems to be the same thing :-)

*** This bug has been marked as a duplicate of bug 102295 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102295] Some OpenGL drivers need more time to start up

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102295

--- Comment #3 from Jan Holesovsky  ---
Nope, it's the same thing:

https://msdn.microsoft.com/en-us/library/windows/desktop/ms724832(v=vs.85).aspx

6.1 == Windows 7 :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102295] Some OpenGL drivers need more time to start up

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102295

--- Comment #2 from Jan Holesovsky  ---
Bug 100487 is I believe a duplicate of this; though the Windows version there
looks like Vista I think (?)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes36' - vcl/inc vcl/source

2016-09-19 Thread Jan Holesovsky 
 vcl/inc/opengl/watchdog.hxx|1 +
 vcl/source/opengl/OpenGLHelper.cxx |   10 +++---
 2 files changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 86adf461d56dc46056c4fdf31d77d4b509076ca4
Author: Jan Holesovsky 
Date:   Tue Sep 20 00:16:10 2016 +0200

tdf#102295: relax timeout timings for the GL watchdog

Some OS/GPU combinations need more relaxed watchdog timeout timings
as the shader compilation takes too long to complete.

Change-Id: Ifd9ff7ecfa4b004d5411d6d364dd01a389a3fcec
(cherry picked from commit e5c3c69423c0f32bf4bee147936e58ba4d3be181)

diff --git a/vcl/inc/opengl/watchdog.hxx b/vcl/inc/opengl/watchdog.hxx
index ce97064..ced3cf2 100644
--- a/vcl/inc/opengl/watchdog.hxx
+++ b/vcl/inc/opengl/watchdog.hxx
@@ -22,6 +22,7 @@ struct WatchdogTimings
 
 int mnMode;
 
+/// delays to take various actions in 1/4 of a second increments.
 std::vector maDisableEntries;
 std::vector maAbortAfter;
 
diff --git a/vcl/source/opengl/OpenGLHelper.cxx 
b/vcl/source/opengl/OpenGLHelper.cxx
index 38317e5..f36b4da 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -827,10 +827,10 @@ void WatchdogTimings::relax()
 {
 osl::MutexGuard g(maMutex);
 
-maDisableEntries[0] = 20; /*  5s */
-maDisableEntries[1] = 60; /* 15s */
+maDisableEntries[0] = 180; /* 45s */
+maDisableEntries[1] = 180; /* 45s */
 
-maAbortAfter[0] = 40;  /* 10s */
+maAbortAfter[0] = 240; /* 60s */
 maAbortAfter[1] = 240; /* 60s */
 }
 
@@ -841,10 +841,6 @@ OpenGLWatchdogThread::OpenGLWatchdogThread()
 
 void OpenGLWatchdogThread::execute()
 {
-// delays to take various actions in 1/4 of a second increments.
-static const int nDisableEntries[2] = { 6 /* 1.5s */, 20 /* 5s */ };
-static const int nAbortAfter[2] = { 20 /* 10s */, 120 /* 30s */ };
-
 int nUnchanged = 0; // how many unchanged nEnters
 TimeValue aQuarterSecond(0, 1000*1000*1000*0.25);
 bool bAbortFired = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101738] Number mask in .xlsx format

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101738

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #5 from Xisco Faulí  ---
I can't reproduce the mentioned behavior in

Version: 5.3.0.0.alpha0+
Build ID: 416eb656da5ecf82e4386bbffc7c843f6d065b3f
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Could you please try it with a recent daily build to see whether this issue is
already fixed in master? http://dev-builds.libreoffice.org/daily/master/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100487] "abort() has been called" upon start in debug build

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100487

--- Comment #6 from Aron Budea  ---
Created attachment 127441
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127441=edit
OpenGL device log

Attaching device log. CPU/GPU is an AMD 10-7800 APU.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95309] Insert > File in Draw & Impress don' t display all available files

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95309

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest, regression |needsUXEval

--- Comment #9 from Xisco Faulí  ---
Probably UX team has something to say here...
Removing keyword 'regression' and 'bibisectRequest' as per comment 6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88790] Conditional Formatting is lost when the document is saved then reopened

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=88790

--- Comment #22 from Markus Mohrhard  ---
Should be fixed as part of Bug 100393

Please retest with a daily build or hopefully 5.2.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84678] FILEOPEN: .DOCX textbox margins incorrectly set in 4.4.x

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=84678

Xisco Faulí  changed:

   What|Removed |Added

 CC||alank...@mangoapps.com

--- Comment #16 from Xisco Faulí  ---
*** Bug 100921 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100921] FILEOPEN DOCX Difference in padding with text box borders

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100921

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 Status|NEW |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #5 from Xisco Faulí  ---
Regression introduced by d379d18666aa42031359ca8eb34b0021960347ae, which is the
same as in bug 84678, thus closing this bug a RESOLVED DUPLICATE of 84678

*** This bug has been marked as a duplicate of bug 84678 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98830] FILEOPEN DOCX Drawing object (with table) is drawn on the top of the paragraph

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98830

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Xisco Faulí  ---
The commit that introduced this regression is the same as in bug 84678, thus
closing this bug a RESOLVED DUPLICATE of 84678.

*** This bug has been marked as a duplicate of bug 84678 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84678] FILEOPEN: .DOCX textbox margins incorrectly set in 4.4.x

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=84678

Xisco Faulí  changed:

   What|Removed |Added

 CC||s...@mt2015.com

--- Comment #15 from Xisco Faulí  ---
*** Bug 98830 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102291] FILTER: AutoFilter, dropdown, "All" leads to crash

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102291

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Win10x64
Reproducible with:
Version: 5.1.5.2 (x64)
Build ID: 7a864d8825610a8c07cfc3bc01dd4fce6a9447e5
CPU Threads: 1; OS Version: Windows 6.19; UI Render: default; 
Locale: es-ES (es_ES); Calc: CL

but Not with;
Version: 5.2.2.1 (x64)
Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

Let's as new for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59346] FILESAVE: FILEOPEN: Certain conditional formatting is broken

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=59346

--- Comment #12 from Markus Mohrhard  ---
(In reply to mike.hall from comment #7)
> (In reply to comment #6)
> > Created attachment 74983 [details]
> > Conditional Formatting - Colour Styles
> > 
> > @Marcus

> After some more delving re these comments:
> Issue 2) results from the STYLE() function being silently deleted from the
> formula in column C. The reason for the deletion is evidently that STYLE()
> has no equivalent function in Excel. Suggest that when this occurs, as a
> minimum the user should be informed with a warning message about what has
> been dropped and why.

As I mentioned before we are currently not planning to implement something like
that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80768] Cell ranges with the same Conditional Formatting should be consolidated to 1 range.

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80768

Markus Mohrhard  changed:

   What|Removed |Added

   Priority|high|low
   Severity|normal  |enhancement

--- Comment #30 from Markus Mohrhard  ---
This is not a bug. There is somewhere an enhancement request to allow combining
equal conditional formats but doing it automatically is surely completely wrong
and will cause bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102292] sorting problem with calc

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102292

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
I can't reproduce.
Win10x64
Version: 5.2.2.1 (x64)
Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

Please attach a minimal sample file for test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102268] "intd" (=dynamic integral) does not accept sub/superscripts

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102268

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=53
   ||472

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53472] FORMATTING: Integral Symbols too small for some integrands

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=53472

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2268

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2016-09-19 Thread Markus Mohrhard 
 sc/source/filter/excel/xecontent.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit 11370a0ce5a8ca503927cff38d79b38e513123fe
Author: Markus Mohrhard 
Date:   Mon Sep 19 23:20:22 2016 +0200

try to generate more excel compliant files, tdf#41722

§18.3.1.10 says for the operator attribute: "The operator in a "cell
value is" conditional formatting rule. This attribute is ignored if
type is not equal to cellIs"

but checking §18.18.15 there are at least 4 attribute values that are
not related to cellIs. I have added them now but need to test that this
really helps.

Change-Id: Id15efc7e0148b4e3b54404d1ffd911adc56b11ec

diff --git a/sc/source/filter/excel/xecontent.cxx 
b/sc/source/filter/excel/xecontent.cxx
index 86a19f7..cfa6c5a 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -836,6 +836,18 @@ const char* GetOperatorString(ScConditionMode eMode, bool& 
bFrmla2)
 case SC_COND_NOTDUPLICATE:
 pRet = nullptr;
 break;
+case SC_COND_BEGINS_WITH:
+pRet = "beginsWith";
+break;
+case SC_COND_ENDS_WITH:
+pRet = "endsWith";
+break;
+case SC_COND_CONTAINS_TEXT:
+pRet = "containsText";
+break;
+case SC_COND_NOT_CONTAINS_TEXT:
+pRet = "notContains";
+break;
 case SC_COND_DIRECT:
 break;
 case SC_COND_NONE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102295] Some OpenGL drivers need more time to start up

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102295

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-09-19 Thread Tomaž Vajngerl 
 vcl/inc/opengl/watchdog.hxx|   36 
 vcl/inc/opengl/zone.hxx|1 
 vcl/source/opengl/OpenGLHelper.cxx |   55 -
 3 files changed, 79 insertions(+), 13 deletions(-)

New commits:
commit e5c3c69423c0f32bf4bee147936e58ba4d3be181
Author: Tomaž Vajngerl 
Date:   Mon Sep 19 18:03:47 2016 +0200

tdf#102295: relax timeout timings for the GL watchdog

Some OS/GPU combinations need more relaxed watchdog timeout timings
as the shader compilation takes too long to complete.

Change-Id: Ifd9ff7ecfa4b004d5411d6d364dd01a389a3fcec

diff --git a/vcl/inc/opengl/watchdog.hxx b/vcl/inc/opengl/watchdog.hxx
index 0213efb..ced3cf2 100644
--- a/vcl/inc/opengl/watchdog.hxx
+++ b/vcl/inc/opengl/watchdog.hxx
@@ -14,6 +14,42 @@
 #include 
 #include 
 #include 
+#include 
+
+struct WatchdogTimings
+{
+osl::Mutex maMutex;
+
+int mnMode;
+
+/// delays to take various actions in 1/4 of a second increments.
+std::vector maDisableEntries;
+std::vector maAbortAfter;
+
+WatchdogTimings();
+
+void relax();
+
+int getMode()
+{
+return mnMode;
+}
+
+void setMode(int nMode)
+{
+mnMode = nMode;
+}
+
+int getDisableEntries()
+{
+   return maDisableEntries[mnMode];
+}
+
+int getAbortAfter()
+{
+return maAbortAfter[mnMode];
+}
+};
 
 class OpenGLWatchdogThread : private salhelper::Thread
 {
diff --git a/vcl/inc/opengl/zone.hxx b/vcl/inc/opengl/zone.hxx
index 11f6ed0..65a7249 100644
--- a/vcl/inc/opengl/zone.hxx
+++ b/vcl/inc/opengl/zone.hxx
@@ -38,6 +38,7 @@ public:
 ~OpenGLZone() { gnLeaveCount++; }
 static bool isInZone() { return gnEnterCount != gnLeaveCount; }
 static void hardDisable();
+static void relaxWatchdogTimings();
 };
 
 /// Create this to not only enter the zone, but set VCL context.
diff --git a/vcl/source/opengl/OpenGLHelper.cxx 
b/vcl/source/opengl/OpenGLHelper.cxx
index f713cf8..fa1c532 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -780,6 +780,13 @@ bool OpenGLHelper::isDeviceBlacklisted()
 #elif defined( _WIN32 )
 WinOpenGLDeviceInfo aInfo;
 bBlacklisted = aInfo.isDeviceBlocked();
+
+if (aInfo.GetWindowsVersion() == 0x00060001 && /* Windows 7 */
+aInfo.GetAdapterVendorID() == "0x1022")/* AMD */
+{
+SAL_INFO("vcl.opengl", "Relaxing watchdog timings.");
+OpenGLZone::relaxWatchdogTimings();
+}
 #else
 bBlacklisted = false;
 #endif
@@ -806,9 +813,27 @@ void OpenGLZone::leave() { gnLeaveCount++; }
 namespace {
 static volatile bool gbWatchdogFiring = false;
 static oslCondition gpWatchdogExit = nullptr;
+static WatchdogTimings gWatchdogTimings;
 static rtl::Reference gxWatchdog;
 }
 
+WatchdogTimings::WatchdogTimings()
+: mnMode(0)
+, maDisableEntries({ 6 /* 1.5s */,  20 /* 5s */ })
+, maAbortAfter({ 20 /* 5s */, 120 /* 30s */ })
+{}
+
+void WatchdogTimings::relax()
+{
+osl::MutexGuard g(maMutex);
+
+maDisableEntries[0] = 180; /* 45s */
+maDisableEntries[1] = 180; /* 45s */
+
+maAbortAfter[0] = 240; /* 60s */
+maAbortAfter[1] = 240; /* 60s */
+}
+
 OpenGLWatchdogThread::OpenGLWatchdogThread()
 : salhelper::Thread("OpenGL Watchdog")
 {
@@ -816,25 +841,24 @@ OpenGLWatchdogThread::OpenGLWatchdogThread()
 
 void OpenGLWatchdogThread::execute()
 {
-// delays to take various actions in 1/4 of a second increments.
-static const int nDisableEntries[2] = { 6 /* 1.5s */, 20 /* 5s */ };
-static const int nAbortAfter[2] = { 20 /* 10s */, 120 /* 30s */ };
-
 int nUnchanged = 0; // how many unchanged nEnters
-TimeValue aHalfSecond(0, 1000*1000*1000*0.25);
+TimeValue aQuarterSecond(0, 1000*1000*1000*0.25);
 bool bAbortFired = false;
 
 do {
 sal_uInt64 nLastEnters = OpenGLZone::gnEnterCount;
 
-osl_waitCondition(gpWatchdogExit, );
+osl_waitCondition(gpWatchdogExit, );
 
 if (OpenGLZone::isInZone())
 {
-int nType = 0;
+osl::MutexGuard g(gWatchdogTimings.maMutex);
+
 // The shader compiler can take a long time, first time.
 if (gbInShaderCompile)
-nType = 1;
+gWatchdogTimings.setMode(1);
+else
+gWatchdogTimings.setMode(0);
 
 if (nLastEnters == OpenGLZone::gnEnterCount)
 nUnchanged++;
@@ -843,12 +867,12 @@ void OpenGLWatchdogThread::execute()
 SAL_INFO("vcl.opengl", "GL watchdog - unchanged " <<
  nUnchanged << " enter count " <<
  OpenGLZone::gnEnterCount << " type " <<
- (nType ? "in shader" : "normal gl") <<
- "breakpoints mid: " << nDisableEntries[nType] <<
- " max " << nAbortAfter[nType]);
+

[Libreoffice-bugs] [Bug 102295] Some OpenGL drivers need more time to start up

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102295

--- Comment #1 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e5c3c69423c0f32bf4bee147936e58ba4d3be181

tdf#102295: relax timeout timings for the GL watchdog

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102298] [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102298

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #3 from m.a.riosv  ---
Confirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102299] FILESAVE: Saving a file with double line borders ( top & bottom) with dotted lines on verticals over several cells will not save

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102299

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Created attachment 127440
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127440=edit
Sample file

I think works fine for me with:
Win10x64
Version: 5.2.2.1 (x64)
Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102268] "intd" (=dynamic integral) does not accept sub/superscripts

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102268

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||matteo.campane...@gmail.com
   ||,
   ||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
Regression introduced by 

commit 93e6291c29d547c0c29c6e43b2ca4b36a3e8506f
Author: matteocam 
AuthorDate: Tue Feb 25 14:37:55 2014 -0500
Commit: Norbert Thiebaud 
CommitDate: Sat Mar 15 22:45:51 2014 +

fdo#53472 Created Dynamic Integral Node classes. Integrals size made dependent
on body.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41722] conditional formatting does not export to excel

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=41722

Markus Mohrhard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102299] FILESAVE: Saving a file with double line borders ( top & bottom) with dotted lines on verticals over several cells will not save

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102299

--- Comment #1 from lyns...@lynstef.com ---
Saving a file (I am working in Libra calc) which has cells that I want to have
double lined borders (top & bottom) with dotted lines on verticals over several
cells. On re-open they have not saved. I have tried on 3 diff machines and the
only way i can get them to stay on is to export it as a PDF.
Steps I Took
1) Highlighted 5 cells
2) Right click, format cells, cell protection, untick 'protect cells' click ok
3) Right click, format cells. borders,set all outer and inner borders, set 
 vertical borders as dotted lines and top and bottom as double lines. press ok
4) Right click, format cells, protection tick protect cells click ok
5) Tools, protect document, sheet, untick select protected cells, click ok
6) Save document as ods and close
7) Re-open border has not saved
I am on version 5.0.2.2 also noticed it saves as a ODS not ODC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102210] Cannot use '°' character in subroutine name

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102210

--- Comment #7 from rapper.sk...@hotmail.it ---
Sorry for that. I'll try to make a test file with Excel.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102297] FILECLOSE: crash when closing presentation (or other action)

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102297

--- Comment #1 from Cor Nouws  ---
hmm, seems this happens when I have a (specific) extension installed..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/jmux/new-vcl-scheduler+kde4' - 35 commits - android/source avmedia/source basctl/source chart2/source cui/source dbaccess/source desktop/qa desktop/sour

2016-09-19 Thread Jan-Marek Glogowski 
Rebased ref, commits from common ancestor:
commit be5282827e39dc65b33c785dbd760b0a59df8513
Author: Jan-Marek Glogowski 
Date:   Mon Sep 19 22:47:37 2016 +0200

KDE4 no more progress bar flickering

This will always redraw the progress bar over the last one.
It stops the flickering at least in KDE4 from re-painting the
background, but obvously will break any transparent or alaiasing
effect, if it was used.

There is actually a mbProgressNeedsErase in the global settings,
so actually use it when setting a new progress value.

Change-Id: Ic62784da4f6d08bf0e03a9e04848a5cc687ee236

diff --git a/vcl/source/window/status.cxx b/vcl/source/window/status.cxx
index 0035714..70778b0 100644
--- a/vcl/source/window/status.cxx
+++ b/vcl/source/window/status.cxx
@@ -1352,7 +1352,8 @@ void StatusBar::SetProgressValue( sal_uInt16 nNewPercent )
 &&   IsReallyVisible()
 &&   (!mnPercent || (mnPercent != nNewPercent)) )
 {
-Invalidate(maPrgsFrameRect);
+bool bNeedErase = ImplGetSVData()->maNWFData.mbProgressNeedsErase;
+Invalidate(maPrgsFrameRect, bNeedErase ? InvalidateFlags::NONE : 
InvalidateFlags::NoErase);
 Flush();
 }
 mnPercent = nNewPercent;
commit 5f190ff5b8ab049a35e21d8513c868ebd6bf10f8
Author: Jan-Marek Glogowski 
Date:   Mon Sep 19 22:31:17 2016 +0200

tdf#94172 KDE4 fix gradient toolbars

Bug introduced by commit 4f5fe008a3d5f0b5ddfa656299306cff9d57d802.
The code was moved from ImplInitSettings to ApplySettings and somehow
a not (!) got lost.

Change-Id: Ie3fa4fb99d030d106aab712cd6bdafada8c6d423

diff --git a/vcl/source/window/dockingarea.cxx 
b/vcl/source/window/dockingarea.cxx
index 1806519..a1de6bc 100644
--- a/vcl/source/window/dockingarea.cxx
+++ b/vcl/source/window/dockingarea.cxx
@@ -149,7 +149,7 @@ void DockingAreaWindow::ApplySettings(vcl::RenderContext& 
rRenderContext)
 
 rRenderContext.SetBackground(aWallpaper);
 }
-else if (rRenderContext.IsNativeControlSupported(ControlType::Toolbar, 
ControlPart::Entire))
+else if (!rRenderContext.IsNativeControlSupported(ControlType::Toolbar, 
ControlPart::Entire))
 {
 Wallpaper aWallpaper;
 aWallpaper.SetStyle(WallpaperStyle::ApplicationGradient);
commit e21bbabd7e5cc4422b87847ee89b06f1977c016f
Author: Jan-Marek Glogowski 
Date:   Mon Sep 19 22:24:12 2016 +0200

tdf#94112 KDE4 use disabled WindowText color

Libre office just has a general disabled color. Instead of the
general QPalette::Mid, use the color QPalette::WindowText of
the palette QPalette::Disabled.

Change-Id: Ie6943b455d3e6545289b241ee4ab85128f4fd7ab

diff --git a/vcl/unx/kde4/KDESalFrame.cxx b/vcl/unx/kde4/KDESalFrame.cxx
index 9edeb11..a1086ba 100644
--- a/vcl/unx/kde4/KDESalFrame.cxx
+++ b/vcl/unx/kde4/KDESalFrame.cxx
@@ -243,7 +243,7 @@ void KDESalFrame::UpdateSettings( AllSettings& rSettings )
 style.SetTabHighlightTextColor( aButn );
 
 // Disable color
-style.SetDisableColor( aMid );
+style.SetDisableColor( toColor( pal.color( QPalette::Disabled, 
QPalette::WindowText ) ) );
 
 // Workspace
 style.SetWorkspaceColor( aMid );
commit 3a6d4d136246352239f26696852560b42160fb68
Author: Jan-Marek Glogowski 
Date:   Wed Oct 29 15:54:29 2014 +0100

KDE4: Switch default image color to transparent...

and just fill the painted image once at the beginning.

Also adapt background based on the control information from Qt4.

Change-Id: I39c03b2ca779381920e2597b4bea7973fea6ae2a

diff --git a/vcl/unx/kde4/KDESalGraphics.cxx b/vcl/unx/kde4/KDESalGraphics.cxx
index 76f8a58..9cdd627 100644
--- a/vcl/unx/kde4/KDESalGraphics.cxx
+++ b/vcl/unx/kde4/KDESalGraphics.cxx
@@ -220,13 +220,46 @@ bool KDESalGraphics::drawNativeControl( ControlType type, 
ControlPart part,
 {
 m_image.reset(new QImage( widgetRect.width(), widgetRect.height(), 
QImage::Format_ARGB32 ) );
 }
-m_image->fill(KApplication::palette().color(QPalette::Window).rgb());
+
+// Default image color - just once
+switch (type)
+{
+case ControlType::MenuPopup:
+if( part == ControlPart::MenuItemCheckMark || part == 
ControlPart::MenuItemRadioMark )
+{
+// it is necessary to fill the background transparently first, 
as this
+// is painted after menuitem highlight, otherwise there would 
be a grey area
+m_image->fill( Qt::transparent );
+break;
+}
+SAL_FALLTHROUGH; // QPalette::Window
+case ControlType::Menubar:
+case ControlType::WindowBackground:
+m_image->fill( 
KApplication::palette().color(QPalette::Window).rgb() );
+break;
+case ControlType::Tooltip:
+
m_image->fill(KApplication::palette().color(QPalette::ToolTipBase).rgb());
+

Re: ulsdegyzwkzdepkhzrlh

2016-09-19 Thread zwonibgf 
-->> $16283...
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

dbg build error on start for missing shared libraries

2016-09-19 Thread Cor Nouws 
Hi,

Downloaded and unpacked
http://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86@71-TDF-dbg/current/master_dbg~2016-09-18_23.51.47_LibreOfficeDev_5.3.0.0.alpha0_Linux_x86_archive.tar.gz


& /program/soffice
/home/cono/lotest/TM/LibreOfficeDev_5.3.0.0.alpha0_Linux_x86_archive/program/oosplash:
error while loading shared libraries: libXinerama.so.1: cannot open
shared object file: No such file or directory

Despite the return message, I doubt this is something that I need to fix
with gathering all kind of libraries.. Can someone pls confirm?


-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94112] Unreadable non accesible entries in menu with kde dark theme

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94112

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||172

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94172] Docked toolbars use “gen” VCL plugin’s gradient instead of KDE theme color

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94172

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||112

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102299] New: FILESAVE: Saving a file with double line borders ( top & bottom) with dotted lines on verticals over several cells will not save

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102299

Bug ID: 102299
   Summary: FILESAVE: Saving a file with double line borders (top
& bottom) with dotted lines on verticals over several
cells will not save
   Product: LibreOffice
   Version: 5.0.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lyns...@lynstef.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94172] Docked toolbars use “gen” VCL plugin’s gradient instead of KDE theme color

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94172

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=369037

--- Comment #9 from Yousuf Philips (jay)  ---
The issue was also reported by Andreas here.

https://bugs.kde.org/show_bug.cgi?id=369037

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101164] Drag and drop from bibliography database does not insert any data

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101164

Michael Stahl  changed:

   What|Removed |Added

Version|3.6.4.3 release |3.3.0 release

--- Comment #5 from Michael Stahl  ---
oops, i should be more careful when bisecting because i'm doing it wrong:

commit c9af2604214a1bff261ced86343eb32de5f18443
Author: Italo Vignoli 
AuthorDate: Fri Mar 9 15:07:02 2012 +

Resolves: fdo#45033 use LibreOffice references in bibliography


that commit changed the bibliography database itself in LO 3.6,
which previously contained 59 entries but now contains only 20.

the bug is that the index of the row that is being inserted is
~33 larger than the row that was dragged, which means that
with a 59 entry database i see data being inserted, it's just
the wrong data!

so LO 3.5 *also* has the same bug...

was broken in OOo 3.3 already, it worked in OOo 3.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101164] Drag and drop from bibliography database does not insert any data

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101164

Michael Stahl  changed:

   What|Removed |Added

   Keywords|bibisected  |preBibisect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102293] triple click on word in impress results in visually unselected word

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102293

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #5 from Caolán McNamara  ---
This'll do for now I guess unless a better idea shows up

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102298] New: [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102298

Bug ID: 102298
   Summary: [UI] In Autofilter the 5 elements on top do not get
focus by Tab, nor have a shortcut
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: c...@nouenoff.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102293] triple click on word in impress results in visually unselected word

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102293

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=38a61ddaf63768ebe19c92d561eac6f50d67ded7

Resolves: tdf#102293 triple click results in visually unselected word

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102293] triple click on word in impress results in visually unselected word

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102293

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102298] [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102298

--- Comment #2 from Cor Nouws  ---
Created attachment 127439
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127439=edit
screen short

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102298] [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102298

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #1 from Cor Nouws  ---
Items Sort Ascending, Sort Descending, Top 10, Empty and Non Empty
get no focus with Tab nor have a short cut

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

2016-09-19 Thread Caolán McNamara 
 sd/source/ui/func/futext.cxx |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit 38a61ddaf63768ebe19c92d561eac6f50d67ded7
Author: Caolán McNamara 
Date:   Mon Sep 19 21:21:58 2016 +0100

Resolves: tdf#102293 triple click results in visually unselected word

in previously unselected textboxes in impress

started happening after...

commit 16c7f8916661df24f4681ec82f6bd4d7ad85d141
Date:   Tue Jan 12 16:36:49 2016 +

tdf#97075 - don't render sdr overlays before we paint

in impress instead flush the overlay after activating the edit object
if we go on to put the cursor in there. Seems to work.

Change-Id: Ib746c36d1074aee09771a3dc1d69834ce80a9c08

diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 72f6ae2..9b0979b 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -21,6 +21,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -1064,6 +1066,19 @@ void FuText::SetInEditMode(const MouseEvent& rMEvt, bool 
bQuickDrag)
 
 if (mpView->SdrBeginTextEdit(pTextObj, pPV, mpWindow, 
true, pOutl) && mxTextObj->GetObjInventor() == SdrInventor)
 {
+//tdf#102293 flush overlay before going on to pass 
clicks down to
+//the outline view which will want to paint selections
+for (sal_uInt32 b = 0; b < pPV->PageWindowCount(); ++b)
+{
+const SdrPageWindow& rPageWindow = 
*pPV->GetPageWindow(b);
+if (!rPageWindow.GetPaintWindow().OutputToWindow())
+continue;
+rtl::Reference< sdr::overlay::OverlayManager > 
xManager = rPageWindow.GetOverlayManager();
+if (!xManager.is())
+continue;
+xManager->flush();
+}
+
 bFirstObjCreated = true;
 DeleteDefaultText();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102298] [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102298

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||278

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93278] [UI] In Autofilter taborder does not work, neither alt shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93278

Cor Nouws  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2298
 Resolution|--- |FIXED

--- Comment #9 from Cor Nouws  ---
close as resolved, fixed, open bug
https://bugs.documentfoundation.org/show_bug.cgi?id=102298 for the remaining
issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93278] [UI] In Autofilter taborder does not work, neither alt shortcut

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93278

--- Comment #8 from Cor Nouws  ---
already much better than it ever was!
Search box gets the focus (even twice on tabbing) 
Other elements get focus too
Search by typing works in the list
Accelerators on OK, All, Cancel

Only the Sort items and Top 10 (non) Empty only work with a mouse

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 94427] UI: Show indicator of currently applied style when a different style is selected in styles sidebar

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94427

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

--- Comment #21 from Heiko Tietze  ---
Enough input from the UX team, removing the keyword now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 94427] UI: Show indicator of currently applied style when a different style is selected in styles sidebar

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94427

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

--- Comment #21 from Heiko Tietze  ---
Enough input from the UX team, removing the keyword now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98904] [Formatting] Custom image for bullets won't work

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98904

Jon Harris  changed:

   What|Removed |Added

 CC||lardconce...@gmail.com

--- Comment #2 from Jon Harris  ---
I can confirm with Version: 5.2.1.2
Build ID: 31dd62db80d4e60af04904455ec9c9219178d620
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
Locale: en-GB (en_GB); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67574] EDITING: Shortcut to paste a link

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=67574

--- Comment #11 from Heiko Tietze  ---
(In reply to Cor Nouws from comment #10)
> [Does my scheme say it's time to agree to Jay or to Heiko .. ;) ]

Should be the easiest answer ever :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 67574] EDITING: Shortcut to paste a link

2016-09-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=67574

--- Comment #11 from Heiko Tietze  ---
(In reply to Cor Nouws from comment #10)
> [Does my scheme say it's time to agree to Jay or to Heiko .. ;) ]

Should be the easiest answer ever :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

  1   2   3   4   >