Re: Visual Studio Integration with LO

[Tor Lillqvist]

Do I need to do a complete build in order to get integration working.
>

Yes. And even then I wouldn't count on it working. Personally I think it is
a horrible idea and counter-productive to keep advocating this ridiculous
"integration". But then I am a grumpy senior citizen.

Let's hope I am wrong and once you have built a complete build by typing
"make" (I know, an awfully hard thing to do), the integration actually
works as documented and you expect.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: comphelper/source embeddedobj/source package/source svl/source svtools/source svx/source

[Jochen Nitschke]

 comphelper/source/property/genericpropertyset.cxx|2 +-
 embeddedobj/source/commonembedding/miscobj.cxx   |2 +-
 embeddedobj/source/commonembedding/specialobject.cxx |2 +-
 package/source/xstor/ocompinstream.cxx   |4 ++--
 package/source/xstor/owriteablestream.cxx|8 
 package/source/xstor/xstorage.cxx|   10 +-
 svl/source/fsstor/fsstorage.cxx  |2 +-
 svl/source/fsstor/ostreamcontainer.cxx   |   12 ++--
 svtools/source/graphic/descriptor.cxx|2 +-
 svtools/source/graphic/graphic.cxx   |2 +-
 svtools/source/graphic/renderer.cxx  |2 +-
 svtools/source/uno/unoimap.cxx   |2 +-
 svx/source/unodraw/unopool.cxx   |2 +-
 svx/source/unogallery/unogalitem.cxx |2 +-
 14 files changed, 27 insertions(+), 27 deletions(-)

New commits:
commit 930f0242a11538ddda0e80712be98ff6b9431fd2
Author: Jochen Nitschke 
Date:   Sun Oct 16 07:52:45 2016 +0200

replace <<= with assign for <<= with rhs Any

queryAggregation and queryInterface return Any

Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a
Reviewed-on: https://gerrit.libreoffice.org/29912
Tested-by: Jenkins 
Reviewed-by: Jochen Nitschke 

diff --git a/comphelper/source/property/genericpropertyset.cxx 
b/comphelper/source/property/genericpropertyset.cxx
index e8b08ec..f30a7b2 100644
--- a/comphelper/source/property/genericpropertyset.cxx
+++ b/comphelper/source/property/genericpropertyset.cxx
@@ -205,7 +205,7 @@ Any SAL_CALL GenericPropertySet::queryAggregation( const 
Type & rType )
 else if( rType == cppu::UnoType::get())
 aAny <<= Reference< XMultiPropertySet >(this);
 else
-aAny <<= OWeakAggObject::queryAggregation( rType );
+aAny = OWeakAggObject::queryAggregation( rType );
 
 return aAny;
 }
diff --git a/embeddedobj/source/commonembedding/miscobj.cxx 
b/embeddedobj/source/commonembedding/miscobj.cxx
index 00464a7..fa020e9 100644
--- a/embeddedobj/source/commonembedding/miscobj.cxx
+++ b/embeddedobj/source/commonembedding/miscobj.cxx
@@ -369,7 +369,7 @@ uno::Any SAL_CALL OCommonEmbeddedObject::queryInterface( 
const uno::Type& rType
 return uno::Any(, rType);
 }
 else
-aReturn <<= ::cppu::queryInterface(
+aReturn = ::cppu::queryInterface(
 rType,
 static_cast< embed::XInplaceObject* >( this ),
 static_cast< embed::XVisualObject* >( this ),
diff --git a/embeddedobj/source/commonembedding/specialobject.cxx 
b/embeddedobj/source/commonembedding/specialobject.cxx
index b9ec0ab..e1c73f8 100644
--- a/embeddedobj/source/commonembedding/specialobject.cxx
+++ b/embeddedobj/source/commonembedding/specialobject.cxx
@@ -57,7 +57,7 @@ uno::Any SAL_CALL OSpecialEmbeddedObject::queryInterface( 
const uno::Type& rType
 {
 uno::Any aReturn;
 
-aReturn <<= ::cppu::queryInterface( rType,
+aReturn = ::cppu::queryInterface( rType,
 static_cast< embed::XEmbeddedObject* 
>( this ),
 static_cast< embed::XInplaceObject* >( 
this ),
 static_cast< embed::XVisualObject* >( 
this ),
diff --git a/package/source/xstor/ocompinstream.cxx 
b/package/source/xstor/ocompinstream.cxx
index 24318b1..c94d16c 100644
--- a/package/source/xstor/ocompinstream.cxx
+++ b/package/source/xstor/ocompinstream.cxx
@@ -80,7 +80,7 @@ uno::Any SAL_CALL OInputCompStream::queryInterface( const 
uno::Type& rType )
 uno::Any aReturn;
 
 // common interfaces
-aReturn <<= ::cppu::queryInterface
+aReturn = ::cppu::queryInterface
 (   rType
 ,   static_cast ( this )
 ,   static_cast ( this )
@@ -93,7 +93,7 @@ uno::Any SAL_CALL OInputCompStream::queryInterface( const 
uno::Type& rType )
 
 if ( m_nStorageType == embed::StorageFormats::OFOPXML )
 {
-aReturn <<= ::cppu::queryInterface
+aReturn = ::cppu::queryInterface
 (   rType
 ,   static_cast ( this ) 
);
 
diff --git a/package/source/xstor/owriteablestream.cxx 
b/package/source/xstor/owriteablestream.cxx
index 7e60023..8506f7e 100644
--- a/package/source/xstor/owriteablestream.cxx
+++ b/package/source/xstor/owriteablestream.cxx
@@ -1866,7 +1866,7 @@ uno::Any SAL_CALL OWriteStream::queryInterface( const 
uno::Type& rType )
 uno::Any aReturn;
 
 // common interfaces
-aReturn <<= ::cppu::queryInterface
+aReturn = ::cppu::queryInterface
 (   rType
 ,   static_cast ( this )
 

[Libreoffice-bugs] [Bug 101327] Impress crashes saving a pptx doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101327

--- Comment #14 from Mike Kaganski  ---
The stack trace of a point at which the static member seems to be ruined is
this:

sdlo.dll!std::_Tree >,0> >::clear() Line
1543 C++
sdlo.dll!std::_Tree >,0>
>::erase(std::_Tree_const_iterator > > > _First,
std::_Tree_const_iterator > > > _Last) Line
1515  C++
sdlo.dll!std::_Tree >,0> >::_Tidy() Line
2230 C++
sdlo.dll!std::_Tree >,0>
>::~_Tree >,0> >() Line 1193 
 C++
sdlo.dll!std::map,std::less,std::allocator >
>::~map,std::less,std::allocator > >()   C++
sdlo.dll!`dynamic atexit destructor for
'sd::framework::FrameworkHelper::maInstanceMap''()  C++
sdlo.dll!_CRT_INIT(void * hDllHandle, unsigned long dwReason, void *
lpreserved) Line 416   C
sdlo.dll!__DllMainCRTStartup(void * hDllHandle, unsigned long dwReason,
void * lpreserved) Line 522 C
sdlo.dll!_DllMainCRTStartup(void * hDllHandle, unsigned long dwReason,
void * lpreserved) Line 472  C
ntdll.dll!77a7dbbe()Unknown

Seems like the DLL is loaded second time (presumably to save Impress file as
ODG - i.e. loading Draw module for that) and re-writes the variable?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Visual Studio Integration with LO

[Abhilash Singh]

I built a single module SC using the windows build guide with debugging
enabled. Although things are fine, I'm unable to integrate Visual Studio
2013 with LO code. Do I need to do a complete build in order to get
integration working.

This is the output I get on doing make vs2013-ide-integration
http://pastebin.com/kZitD5G3. The generated visual studio project file
contains nothing, and no other module gets a project file. Any guesses what
is wrong here?

Thanks a lot.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 103326] New: Viewing: Enhancement: Unable to set web view as default for opening all documents.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103326

Bug ID: 103326
   Summary: Viewing: Enhancement: Unable to set web view as
default for opening all documents.
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eltimbalino.s...@gmail.com

Description:
Currently when opening a document it defaults to page view. I would like to be
able to set the default view for opening all Writer documents to web view.

I would like this default to be overridden if the file being opened contains
view information.

The currently recommended work around is to write a macro that sets current
view to web view and is run by the events 'open document' and 'new document'.
This solution is not optimal, and for those who don't want JRE, not available. 

Steps to Reproduce:
N/A: Feature request.
1. Open document or create new document
2. Document is in Print view when Web view is preferred.
3. Go to 'View' and click radio button 'Web'


Actual Results:  
N/A: Feature request.


Expected Results:
1. Open Writer
2. Go Tools --> Options --> LibreOffice Writer --> View
3. In this window under the View title a new options exists as Default Layout
4. New option Default Layout has two radio buttons, (1) Page View, (2) Web View
5. The chosen option causes writer to behave in the same manner as if, after
opening or creating a document, the user had selected that view.


Reproducible: Always

User Profile Reset: No

Additional Info:
Caution: writing code that emulates a radio button click of Web View will cause
a problem because the current implementation toggles instead of selects the
radio buttons as per bug:
https://bugs.documentfoundation.org/show_bug.cgi?id=62182


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/54.0.2840.59 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101327] Impress crashes saving a pptx doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101327

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||notBibisectable,
   ||preBibisect, regression
Version|5.1.5.2 release |4.1.0.4 release

--- Comment #13 from Mike Kaganski  ---
This started somewhere before Version: 4.1.0.0.beta2
Build ID: 33224f4f11a05cfad2249e812fcc2975fbb61f6

The stated version already crashes saving attachment 126630 as ODG, while
4.0.6.2 does not -> regression, preBibisect.

No crash with Version: 5.2.2.2
Build ID: 1:5.2.2-0ubuntu1~xenial0
CPU Threads: 1; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

No bibisect repository for that commit range for Windows -> notBibisectable.

The initial crash (on current master) happens in void vcl::Window::dispose() at
line 547 of vcl/source/window/window.cxx:
> pSysWin = pSysWin->mpWindowImpl->mpFrameData->mpNextFrame;

because pSysWin happens to be nullptr.
Actually, all the block starting from line 539:
> if ( mpWindowImpl->mbFrame )
fails because it tries to use mpWindowImpl->mpFrame and
mpWindowImpl->mpFrameData, that are both nullptr for some reason.

If line 539 is fixed this way:
> if ( mpWindowImpl->mbFrame && mpWindowImpl->mpFrame && 
> mpWindowImpl->mpFrameData )
then next crash happens in ::std::shared_ptr
FrameworkHelper::Instance (ViewShellBase& rBase) at line 333 of
sd/source/ui/framework/tools/FrameworkHelper.cxx:
> InstanceMap::const_iterator iHelper (maInstanceMap.find());
This time, it turns out that static maInstanceMap gets cleared somewhere
previously, but somehow incorrectly, so that its size is 0, but _Myhead's
_Mytop, _Myleft and _Myright members do not point to _Myhead but to 0x,
and _Myproxy is 0x (in essence, maInstanceMap is ruined), so find()
segfaults.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103087] Border widget must not focus an option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103087

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
note: unable to bibisect with win-5.2, dozens of skipped commits.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62182] print/web layout are toggles instead of set commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62182

--- Comment #8 from eltimbalino  ---
Still reproducible in LO 5.1.4.2 Ubuntu 16.04 x86-64.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103325] New: Libreoffice windows does not tolerate resize from left side

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103325

Bug ID: 103325
   Summary: Libreoffice windows does not tolerate resize from left
side
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sas...@gmail.com

Created attachment 128064
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128064=edit
Screenshot calc itch

Hi,

I open a new openoffice application (writer, or calc).
I restore the window size (un-maximize), and I try to resize it from the left
side.
It gets confused:
the top menu is scrolled out to the left, and the rendering get's itchy :(
(I grab the left window corner, and I start reducing the window size)
Other side effect in writer: normal view (with paper page with side gray area):
the scrolling is in the wrong direction :(
(I resize the page from left -> reducing resolution -> the page moes to the
left (into the disappearing gray area...))


If I restore maximize, and get back, it will work fine.
It however can tolerate the resizing from right.

Technical details:
I'm using Gentoo, AMD64, 8G memory. I'm using 5.1.4.2 pre-built version (I
don't have the time, or memory to compile it on tmpfs...)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - formula/source include/formula sc/source

[Kohei Yoshida]

 formula/source/core/api/token.cxx   |5 -
 include/formula/tokenarray.hxx  |   11 +++
 sc/source/core/data/formulacell.cxx |5 -
 sc/source/core/tool/compiler.cxx|   26 --
 sc/source/core/tool/token.cxx   |1 +
 5 files changed, 40 insertions(+), 8 deletions(-)

New commits:
commit aed5e42680caf49068a3f463b571621ef0d87f86
Author: Kohei Yoshida 
Date:   Mon Oct 17 23:19:23 2016 -0400

tdf#93894: Prohibit grouping when certain token types are present.

For instance, column / row label tokens don't work correctly in
grouped cells with the current implementation.

Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683

diff --git a/formula/source/core/api/token.cxx 
b/formula/source/core/api/token.cxx
index 034b0d6..9808d40 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -712,7 +712,8 @@ FormulaTokenArray::FormulaTokenArray() :
 nError(0),
 nMode(ScRecalcMode::NORMAL),
 bHyperLink(false),
-mbFromRangeName(false)
+mbFromRangeName(false),
+mbShareable(true)
 {
 }
 
@@ -735,6 +736,7 @@ void FormulaTokenArray::Assign( const FormulaTokenArray& r )
 nMode  = r.nMode;
 bHyperLink = r.bHyperLink;
 mbFromRangeName = r.mbFromRangeName;
+mbShareable = r.mbShareable;
 pCode  = nullptr;
 pRPN   = nullptr;
 FormulaToken** pp;
@@ -846,6 +848,7 @@ void FormulaTokenArray::Clear()
 nError = nLen = nIndex = nRPN = 0;
 bHyperLink = false;
 mbFromRangeName = false;
+mbShareable = true;
 ClearRecalcMode();
 }
 
diff --git a/include/formula/tokenarray.hxx b/include/formula/tokenarray.hxx
index 1735d00..71bacbb 100644
--- a/include/formula/tokenarray.hxx
+++ b/include/formula/tokenarray.hxx
@@ -116,6 +116,7 @@ protected:
 ScRecalcModenMode;  // Flags to indicate when to 
recalc this code
 boolbHyperLink; // If HYPERLINK() occurs in the 
formula.
 boolmbFromRangeName;// If this array originates from a 
named expression
+boolmbShareable;// Whether or not it can be shared 
with adjacent cells.
 
 protected:
 voidAssign( const FormulaTokenArray& );
@@ -180,6 +181,16 @@ public:
 void SetFromRangeName( bool b ) { mbFromRangeName = b; }
 bool IsFromRangeName() const { return mbFromRangeName; }
 
+void SetShareable( bool b ) { mbShareable = b; }
+
+/**
+ * Check if this token array is shareable between multiple adjacent
+ * formula cells. Certain tokens may not function correctly when shared.
+ *
+ * @return true if the token array is shareable, false otherwise.
+ */
+bool IsShareable() const { return mbShareable; }
+
 void Clear();
 void DelRPN();
 FormulaToken* First() { nIndex = 0; return Next(); }
diff --git a/sc/source/core/data/formulacell.cxx 
b/sc/source/core/data/formulacell.cxx
index 2e6f549..e262e8f 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -1342,7 +1342,7 @@ void ScFormulaCell::CompileXML( 
sc::CompileFormulaContext& rCxt, ScProgress& rPr
 ScAddress aPreviousCell( aPos );
 aPreviousCell.IncRow( -1 );
 ScFormulaCell *pPreviousCell = pDocument->GetFormulaCell( 
aPreviousCell );
-if( pPreviousCell )
+if (pPreviousCell && pPreviousCell->GetCode()->IsShareable())
 {
 // Now try to convert to a string quickly ...
 ScCompiler aBackComp( rCxt, aPos, *(pPreviousCell->pCode) );
@@ -3804,6 +3804,9 @@ ScFormulaCell::CompareState 
ScFormulaCell::CompareByTokenArray( ScFormulaCell& r
 if ( GetHash() != rOther.GetHash() )
 return NotEqual;
 
+if (!pCode->IsShareable() || !rOther.pCode->IsShareable())
+return NotEqual;
+
 FormulaToken **pThis = pCode->GetCode();
 sal_uInt16 nThisLen = pCode->GetCodeLen();
 FormulaToken **pOther = rOther.pCode->GetCode();
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 595059d..9132bbd 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -4288,6 +4288,12 @@ ScTokenArray* ScCompiler::CompileString( const OUString& 
rFormula )
 --nFunction;
 }
 break;
+case ocColRowName:
+case ocColRowNameAuto:
+// The current implementation of column / row labels doesn't
+// function correctly in grouped cells.
+aArr.SetShareable(false);
+break;
 default:
 break;
 }
@@ -5137,8 +5143,10 @@ bool ScCompiler::HandleColRowName()
 {
 ScSingleRefData aRefData;
 aRefData.InitAddress( aRange.aStart );
-aRefData.SetColRel( true );
-aRefData.SetRowRel( true );
+

[Libreoffice-bugs] [Bug 46733] Deleting columns in a table can delete several columns if any cells in that column are merged with other cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46733

Steve Edmonds  changed:

   What|Removed |Added

 CC||st...@edmondsfamily.co.nz

--- Comment #13 from Steve Edmonds  ---
Also present in 5.2.2.2.0.
Test case added where deleting middle column deletes table.

Work around, split spanning row to match columns, delete column, merge cells in
row to span.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46733] Deleting columns in a table can delete several columns if any cells in that column are merged with other cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46733

--- Comment #14 from Steve Edmonds  ---
Created attachment 128063
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128063=edit
Test file

Deleting middle column deletes table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103324] New: user interface freezes on opening dialogs and context menus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103324

Bug ID: 103324
   Summary: user interface freezes on opening dialogs and context
menus
   Product: LibreOffice
   Version: 5.1.5.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ajanov...@gmail.com

How to reproduce:

1. Open Libreoffice Calc (it opens relatively fast)
2. Enter few numbers in several cells (all is OK, formatting is OK)
3. Press CTRL+1 to open cell options (or right click).
4. The dialog shows after 5-10 seconds, but it is all BLACK, after 30-40
seconds it is finally drawn in an instant.
5. After the dialog is drawn completely, it is not a problem to change options
and switch between tabs.
6. After closing the dialog, to open the same dialog once again it will be a
couple of seconds faster, but still too slow.

The problem is not just with this dialog, but many dialogs (e.g. image
properties, character formatting, paragraph formatting, ...). Some open faster,
some slower.

This problem started to occur for the first time in the last month or so, but I
have not been paying too much attention because I didn't have much work to do
with office documents, just reading. 

So I am not able to remember and pinpoint what changed so that the situation
got worse.

I am using Archlinux on a Intel i5 with 4GB RAM, so it's not due to not having
enough resources. This happens even on empty documents with just 2 lines of
text.

The problem affects all Libreoffice apps.

Writing pure text and reformatting text just by using the toolbar is OK.

I have tried several options to attempt and fix the problem, without success:
- deleted the .config profile
- reinstalled libreoffice (both -still and -fresh versions)
- reinstalled all libraries that libreoffice package depends on
- increased/decreased memory settings of libreoffice
- changed hardware acceleration and opengl options
- changed system themes and fonts
- have tried the most recent Zen and Mainline kernels available as arch
packages in order to try with different graphics driver versions

I don't have any other ideas what to try to solve this issue, but it is quite a
problem if you have to wait a minute on every picture you paste, just to be
able to rescale it or reposition it in the document.

I don't know how to debug it, but since I am an advanced linux user, any idea
what to do and try in order to be able to pinpoint why this happens is welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90195] Hiding the menu bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90195

--- Comment #18 from Yousuf Philips (jay)  ---
(In reply to V Stuart Foote from comment #15)
> Semantically the mini menu (black/white ODF icon) of the "Tabbed" layout of
> the Notbookbar names it a "Menubar"--but that is probably not ideal--it
> should just be "Menus". 

Both sound fine to me, though i would stick with Menubar as that is what it
would be named as in the view menu, and not to be confused with context menu
and various other popout menus.

> Pedro suggested in bug 69959 having a View -> Toolbars toggle for the Menu.
> 
> But it feels like the "Menus" control should be a direct toggle at top level
> of the View menu--not pushed down into the Toolbars split button list. 

Yes i agree as well.

You can find my reorganization of things in this patch.

https://gerrit.libreoffice.org/30028

(In reply to V Stuart Foote from comment #16)
> For a shortcut assignment, I'd suggest we simply continue to use the F10 key.
> 
> F10 now directs focus (cursor and program) to the Main menu, extending its
> behavior to now unhide the menu should be trivial. And would keep the UI
> consistent.

Sounds like a great idea to unhide the menu with f10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 90195] Hiding the menu bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90195

--- Comment #18 from Yousuf Philips (jay)  ---
(In reply to V Stuart Foote from comment #15)
> Semantically the mini menu (black/white ODF icon) of the "Tabbed" layout of
> the Notbookbar names it a "Menubar"--but that is probably not ideal--it
> should just be "Menus". 

Both sound fine to me, though i would stick with Menubar as that is what it
would be named as in the view menu, and not to be confused with context menu
and various other popout menus.

> Pedro suggested in bug 69959 having a View -> Toolbars toggle for the Menu.
> 
> But it feels like the "Menus" control should be a direct toggle at top level
> of the View menu--not pushed down into the Toolbars split button list. 

Yes i agree as well.

You can find my reorganization of things in this patch.

https://gerrit.libreoffice.org/30028

(In reply to V Stuart Foote from comment #16)
> For a shortcut assignment, I'd suggest we simply continue to use the F10 key.
> 
> F10 now directs focus (cursor and program) to the Main menu, extending its
> behavior to now unhide the menu should be trivial. And would keep the UI
> consistent.

Sounds like a great idea to unhide the menu with f10.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: 3 commits - formula/source include/formula sc/qa sc/source

[Kohei Yoshida]

 formula/source/core/api/token.cxx|5 +
 include/formula/tokenarray.hxx   |   11 +++
 sc/qa/unit/data/ods/shared-formula/column-row-labels.ods |binary
 sc/qa/unit/subsequent_filters-test.cxx   |   50 ---
 sc/source/core/data/formulacell.cxx  |5 +
 sc/source/core/tool/compiler.cxx |   26 ++-
 sc/source/core/tool/token.cxx|1 
 7 files changed, 81 insertions(+), 17 deletions(-)

New commits:
commit 42062d99f171196778685e655e4edafd33ac159f
Author: Kohei Yoshida 
Date:   Tue Oct 18 18:16:42 2016 -0400

tdf#93894: Write a new test case for column and row labels combined.

Change-Id: I76e1f6f3c3aed9d940e4433026f752f3630f2373

diff --git a/sc/qa/unit/data/ods/shared-formula/column-row-labels.ods 
b/sc/qa/unit/data/ods/shared-formula/column-row-labels.ods
new file mode 100644
index 000..02f711b
Binary files /dev/null and 
b/sc/qa/unit/data/ods/shared-formula/column-row-labels.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index bc82fb9..78724f8 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -221,6 +221,7 @@ public:
 void testSharedFormulaXLSB();
 void testSharedFormulaXLS();
 void testSharedFormulaColumnLabelsODS();
+void testSharedFormulaColumnRowLabelsODS();
 void testExternalRefCacheXLSX();
 void testExternalRefCacheODS();
 void testHybridSharedStringODS();
@@ -333,6 +334,7 @@ public:
 CPPUNIT_TEST(testSharedFormulaXLSB);
 CPPUNIT_TEST(testSharedFormulaXLS);
 CPPUNIT_TEST(testSharedFormulaColumnLabelsODS);
+CPPUNIT_TEST(testSharedFormulaColumnRowLabelsODS);
 CPPUNIT_TEST(testExternalRefCacheXLSX);
 CPPUNIT_TEST(testExternalRefCacheODS);
 CPPUNIT_TEST(testHybridSharedStringODS);
@@ -3470,6 +3472,45 @@ void ScFiltersTest::testSharedFormulaColumnLabelsODS()
 xDocSh->DoClose();
 }
 
+void ScFiltersTest::testSharedFormulaColumnRowLabelsODS()
+{
+ScDocShellRef xDocSh = loadDoc("shared-formula/column-row-labels.", 
FORMAT_ODS);
+
+CPPUNIT_ASSERT(xDocSh.Is());
+ScDocument& rDoc = xDocSh->GetDocument();
+rDoc.CalcAll();
+
+// Expected output in each of the three ranges.
+//
+// +---+---+---+
+// | 1 | 4 | 7 |
+// +---+---+---+
+// | 2 | 5 | 8 |
+// +---+---+---+
+// | 3 | 6 | 9 |
+// +---+---+---+
+
+auto aCheckFunc = [&](SCCOL nStartCol, SCROW nStartRow)
+{
+double fExpected = 1.0;
+for (SCCOL nCol = 0; nCol <= 2; ++nCol)
+{
+for (SCROW nRow = 0; nRow <= 2; ++nRow)
+{
+ScAddress aPos(nStartCol+nCol, nStartRow+nRow, 0);
+CPPUNIT_ASSERT_EQUAL(fExpected, rDoc.GetValue(aPos));
+fExpected += 1.0;
+}
+}
+};
+
+aCheckFunc(5, 1); // F2:H4
+aCheckFunc(9, 1); // J2:L4
+aCheckFunc(1, 6); // B7:D9
+
+xDocSh->DoClose();
+}
+
 void ScFiltersTest::testExternalRefCacheXLSX()
 {
 ScDocShellRef xDocSh = loadDoc("external-refs.", FORMAT_XLSX);
commit 2b32042294a497f9e387348faf20fcdcb0c0fd7a
Author: Kohei Yoshida 
Date:   Tue Oct 18 17:51:02 2016 -0400

tdf#93894: These assumptions no longer hold.

Since we've switched to not grouping formulas with column / row
labels.

Change-Id: I0097a5103b5dfaa5b021ee76545beb9f24ac7bd3

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 8088e71..bc82fb9 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -3449,15 +3449,6 @@ void ScFiltersTest::testSharedFormulaColumnLabelsODS()
 ScDocument& rDoc = xDocSh->GetDocument();
 rDoc.CalcAll();
 
-// Cells C2, D2 and E2 all should contain formula groups of length 5.
-for (SCCOL i = 2; i <= 4; ++i)
-{
-const ScFormulaCell* pCell = rDoc.GetFormulaCell(ScAddress(i,1,0));
-CPPUNIT_ASSERT(pCell);
-CPPUNIT_ASSERT(pCell->IsSharedTop());
-CPPUNIT_ASSERT_EQUAL(static_cast(5), pCell->GetSharedLength());
-}
-
 CPPUNIT_ASSERT_EQUAL( 5.0, rDoc.GetValue(ScAddress(2,1,0)));
 CPPUNIT_ASSERT_EQUAL(15.0, rDoc.GetValue(ScAddress(2,2,0)));
 CPPUNIT_ASSERT_EQUAL(30.0, rDoc.GetValue(ScAddress(2,3,0)));
commit e944d9510404d8c67b3867d7cd9f313fd5091004
Author: Kohei Yoshida 
Date:   Mon Oct 17 23:19:23 2016 -0400

tdf#93894: Prohibit grouping when certain token types are present.

For instance, column / row label tokens don't work correctly in
grouped cells with the current implementation.

Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683

diff --git a/formula/source/core/api/token.cxx 
b/formula/source/core/api/token.cxx
index a9abdd0..7c85b15 

[Libreoffice-bugs] [Bug 103323] Make notebookbar experimental but not toolbar layout entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103323

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102070] Menubar button to change the toolbar layout/mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102070

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3323

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102062] [META] Extended Toolbar (Notebookbar) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102062

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||103323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103323
[Bug 103323] Make notebookbar experimental but not toolbar layout entry
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101249] Easily activate single toolbar, sidebar mode, and extended toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101249

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3323

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102070] Menubar button to change the toolbar layout/mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102070

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3323

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103323] New: Make notebookbar experimental but not toolbar layout entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103323

Bug ID: 103323
   Summary: Make notebookbar experimental but not toolbar layout
entry
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 102062

Samuel set the notebookbar as experimental in this commit.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=08d7ffcd442c5f02b4ceb068d308a26b04e41d29

But this also makes the 'Toolbar Layout' menu entry experimental as well which
isnt ideal. So here is a solution that we can temporarily have to deal with the
current experimental nature of the notebookbar.

1) Hide the notebookbar entry under 'toolbar layout', which can easily be done
in officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu

2) Create a toggle button entry to enable notebookbar mode, which was
previously how we toggled notebookbar on and off in the past and likely a
useful uno command to have around anyway (toggle on enables toolbar mode,
toggle off enables the previously selected toolbar layout), and set its
experimental attribute and add it into the view menu

3) remove experimental attribute for 'toolbar layout', which is simple to
revert half of samuel's patch


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
[Bug 102062] [META] Extended Toolbar (Notebookbar) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103231] LibreOffice Won't Run in Wineskin. (May Not Run in Wine.)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103231

--- Comment #3 from MarjaE  ---
I mean OpenOffice 4.1.3 runs in Wineskin, though presumably also in basic Wine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103231] LibreOffice Won't Run in Wineskin. (May Not Run in Wine.)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103231

--- Comment #2 from MarjaE  ---
More testing. LibreOffice 5.2.1 Portable does not run. OpenOffice 4.1.3 does
run in Wine, but the corresponding version doesn't run in MacOS. However, that
doesn't establish that this wasn't inherited from OO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
Bug 103239 depends on bug 101249, which changed state.

Bug 101249 Summary: Easily activate single toolbar, sidebar mode, and extended 
toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101249

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102062] [META] Extended Toolbar (Notebookbar) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
Bug 102062 depends on bug 101249, which changed state.

Bug 101249 Summary: Easily activate single toolbar, sidebar mode, and extended 
toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101249

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101249] Easily activate single toolbar, sidebar mode, and extended toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101249

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #24 from Yousuf Philips (jay)  ---
OLE Object crashers are fixed, so returning it back to fixed. Please file
further issues a new bug reports and set them as blocks bug 102062 if it is
notebookbar related.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||103322


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103322
[Bug 103322] Use floating point for glyph positioning in VCL
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Khaled Hosny  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||71732


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] New: Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Bug ID: 103322
   Summary: Use floating point for glyph positioning in VCL
   Product: LibreOffice
   Version: 5.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: khaledho...@eglug.org

Currently we use integers and do lots of calculations and recalculations
resulting in rounding errors which mess up with text spacing specially at low
resolution screens.

We should switch to using floats to store glyph positions instead, which would
make the rounding errors less visible. It would also allow us to benefit from
sub-pixel positioning support in the graphics libraries we use.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99132] GTK3 font size in UI too small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99132

--- Comment #6 from ale.carrazz...@gmail.com ---
I'm using debian sid and the theme I'm using is Zukitre, but the font is
Roboto. It's not the default theme.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74402] Unstable glyph justification

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74402

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #7 from Khaled Hosny  ---
We need a test file here, the font and the text can make a big difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72546] Kerning Terrible for MS Times New Roman

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72546

Khaled Hosny  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #13 from Khaled Hosny  ---
Can someone attach a test file showing the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72861] SVG font embedding is not supported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72861

Khaled Hosny  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #8 from Khaled Hosny  ---
SVG fonts (like the one embedded in the SVG file) are obsolete and were dropped
from SVG 2.0 draft. Firefox and Internet Explorer never supported them and
Chrome dropped support for them few years ago. I’d close this WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66819] Setting additional spacing between characters does not prevent automatic ligature substitution.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66819

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||89870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89870
[Bug 89870] Unify text layout to use HarfBuzz on all platforms
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66818] Font kerning cannot be disabled (for OpenType fonts)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66818

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||89870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89870
[Bug 89870] Unify text layout to use HarfBuzz on all platforms
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48732] Hebrew Nikud still not represented properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48732

Khaled Hosny  changed:

   What|Removed |Added

 Depends on|39805   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39805
[Bug 39805] Hebrew nikud not represented properly (Windows specific)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39805] Hebrew nikud not represented properly (Windows specific)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39805

Khaled Hosny  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org
 Depends on||89870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89870
[Bug 89870] Unify text layout to use HarfBuzz on all platforms
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39805] Hebrew nikud not represented properly (Windows specific)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39805

Khaled Hosny  changed:

   What|Removed |Added

 Blocks|48732   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=48732
[Bug 48732] Hebrew Nikud still not represented properly
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: opencl/source

[Tomaž Vajngerl]

 opencl/source/openclwrapper.cxx |   12 +---
 1 file changed, 5 insertions(+), 7 deletions(-)

New commits:
commit baeb3b43fb67192e8e8639e2d5dd21ccbf5178a4
Author: Tomaž Vajngerl 
Date:   Tue Oct 11 13:01:01 2016 +0200

opencl: convert to C++11 for loop

Change-Id: Id96a3816eb7ef2241f5a6a57b164e1e366eb357a
Reviewed-on: https://gerrit.libreoffice.org/29693
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/opencl/source/openclwrapper.cxx b/opencl/source/openclwrapper.cxx
index 3daa019..c876133 100644
--- a/opencl/source/openclwrapper.cxx
+++ b/opencl/source/openclwrapper.cxx
@@ -739,16 +739,14 @@ namespace {
 
 cl_device_id findDeviceIdByDeviceString(const OUString& rString, const 
std::vector& rPlatforms)
 {
-std::vector::const_iterator it = rPlatforms.begin(), 
itEnd = rPlatforms.end();
-for(; it != itEnd; ++it)
+for (const OpenCLPlatformInfo& rPlatform : rPlatforms)
 {
-std::vector::const_iterator itr = 
it->maDevices.begin(), itrEnd = it->maDevices.end();
-for(; itr != itrEnd; ++itr)
+for (const OpenCLDeviceInfo& rDeviceInfo : rPlatform.maDevices)
 {
-OUString aDeviceId = it->maVendor + " " + itr->maName;
-if(rString == aDeviceId)
+OUString aDeviceId = rDeviceInfo.maVendor + " " + 
rDeviceInfo.maName;
+if (rString == aDeviceId)
 {
-return static_cast(itr->device);
+return rDeviceInfo.device;
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/fixes36' - opencl/source

[Tomaž Vajngerl]

 opencl/source/openclwrapper.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit c10d35e7b9135b98479b6188c2765dc661ba1e65
Author: Tomaž Vajngerl 
Date:   Tue Oct 18 23:53:44 2016 +0200

opencl: make sure we don't initialize OpenCL when disabled

If SAL_DISABLE_OPENCL is set we don't want to do any kind of
OpenCL initialization. Put an extra guard in fillOpenCLInfo to
prevent that.

Change-Id: Icc216d4299d3a7942843117ab9b9411de8075b11
(cherry picked from commit a009a8383111593c26646951d4f290dbbe89af29)

diff --git a/opencl/source/openclwrapper.cxx b/opencl/source/openclwrapper.cxx
index d8d16c3..abd5407 100644
--- a/opencl/source/openclwrapper.cxx
+++ b/opencl/source/openclwrapper.cxx
@@ -648,7 +648,9 @@ bool createPlatformInfo(cl_platform_id nPlatformId, 
OpenCLPlatformInfo& rPlatfor
 const std::vector& fillOpenCLInfo()
 {
 static std::vector aPlatforms;
-if(!aPlatforms.empty())
+
+// return early if we already initialized or SAL_DISABLE_OPENCL is set
+if (!aPlatforms.empty() || getenv("SAL_DISABLE_OPENCL"))
 return aPlatforms;
 
 int status = clewInit(OPENCL_DLL_NAME);
@@ -733,7 +735,7 @@ void findDeviceInfoFromDeviceId(cl_device_id aDeviceId, 
size_t& rDeviceId, size_
 
 bool switchOpenCLDevice(const OUString* pDevice, bool bAutoSelect, bool 
bForceEvaluation, OUString& rOutSelectedDeviceVersionIDString)
 {
-if(fillOpenCLInfo().empty() || getenv("SAL_DISABLE_OPENCL"))
+if (getenv("SAL_DISABLE_OPENCL") || fillOpenCLInfo().empty())
 return false;
 
 cl_device_id pDeviceId = nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1374076:  Error handling issues  (UNCAUGHT_EXCEPT)
/xmlsecurity/source/pdfio/pdfverify.cxx: 25 in main()



*** CID 1374076:  Error handling issues  (UNCAUGHT_EXCEPT)
/xmlsecurity/source/pdfio/pdfverify.cxx: 25 in main()
19 #include 
20 
21 #include 
22 
23 using namespace com::sun::star;
24 
>>> CID 1374076:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type 
>>> "std::length_error" is thrown and never caught.
25 SAL_IMPLEMENT_MAIN_WITH_ARGS(nArgc, pArgv)
26 {
27 if (nArgc < 2)
28 {
29 SAL_WARN("xmlsecurity.pdfio", "not enough parameters");
30 return 1;

** CID 1374075:  Error handling issues  (UNCAUGHT_EXCEPT)
/xmlsecurity/source/pdfio/pdfverify.cxx: 25 in main()



*** CID 1374075:  Error handling issues  (UNCAUGHT_EXCEPT)
/xmlsecurity/source/pdfio/pdfverify.cxx: 25 in main()
19 #include 
20 
21 #include 
22 
23 using namespace com::sun::star;
24 
>>> CID 1374075:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type 
>>> "com::sun::star::uno::DeploymentException" is thrown and never caught.
25 SAL_IMPLEMENT_MAIN_WITH_ARGS(nArgc, pArgv)
26 {
27 if (nArgc < 2)
28 {
29 SAL_WARN("xmlsecurity.pdfio", "not enough parameters");
30 return 1;

** CID 1374074:  Error handling issues  (UNCAUGHT_EXCEPT)
/xmlsecurity/source/pdfio/pdfverify.cxx: 25 in main()



*** CID 1374074:  Error handling issues  (UNCAUGHT_EXCEPT)
/xmlsecurity/source/pdfio/pdfverify.cxx: 25 in main()
19 #include 
20 
21 #include 
22 
23 using namespace com::sun::star;
24 
>>> CID 1374074:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type 
>>> "com::sun::star::uno::RuntimeException" is thrown and never caught.
25 SAL_IMPLEMENT_MAIN_WITH_ARGS(nArgc, pArgv)
26 {
27 if (nArgc < 2)
28 {
29 SAL_WARN("xmlsecurity.pdfio", "not enough parameters");
30 return 1;



To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpypJRiS-2Ffco4aZgEEt3h7hV1FEUazA-2FE1qUDJjgBNuY-2BFKnTKWslxsN87NACkg6USGeTcbinhhv6dMZFQfxV1PRdJ2o-2F-2Fb9D-2FF3O1h7bD-2BYTuT3WeZfTwQbmB63OBjVJZdNO2l6Z95gvB26Y1QQqHKHzTNwIO8YJ-2B7wxGC9QfFSYM-3D

To manage Coverity Scan email notifications for 
"libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpypJRiS-2Ffco4aZgEEt3h7hV2v3IiBFEXKGMVtn-2FalCs79BmZe5005xvk6wNlDkBK1lqBRCKFbemwaH-2Fu8tZ7H-2FyA3cvyYdzNbked7msuzCUW6m0TzUnH5i0eLkwBhl8fSiJdYF-2BezMUWsf1QIHWO2Ut4eSiumF4rYWI3bOeiWwhRM-3D

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: extras/source

[Krunoslav Šebetić]

 extras/source/autocorr/lang/hr/DocumentList.xml  |  687 
+-
 extras/source/autocorr/lang/hr/README.md |   84 +
 extras/source/autocorr/lang/hr/SentenceExceptList.xml|  433 +++---
 extras/source/autocorr/lang/hr/dodano-na-documentlist.txt|   14 
 extras/source/autocorr/lang/hr/licence_and_version.md|   17 
 extras/source/autocorr/lang/hr/umetanje-automatskih-ispravaka.md |   23 
 6 files changed, 744 insertions(+), 514 deletions(-)

New commits:
commit c01b15514e376c4981dd98c58fa69c848c47ce9a
Author: Krunoslav Šebetić 
Date:   Mon Oct 17 21:32:44 2016 +0200

Update autocorrect for Croatian

Change-Id: I23254c546ddffc080a4239be103618c4b4514095
Reviewed-on: https://gerrit.libreoffice.org/29985
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/extras/source/autocorr/lang/hr/DocumentList.xml 
b/extras/source/autocorr/lang/hr/DocumentList.xml
index 1924ed5..67c8244 100644
--- a/extras/source/autocorr/lang/hr/DocumentList.xml
+++ b/extras/source/autocorr/lang/hr/DocumentList.xml
@@ -1,107 +1,208 @@
-
+
 http://openoffice.org/2001/block-list;>
+  
+  
+  
+  
+  
   
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
   
-  
-  
-  
-  
-  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
   
+  
   
   
   
-  
-  
+  
+  
+  
+  
   
   
-  
-  
-  
-  
   
   
   
-  
-  
   
-  
-  
   
   
-  
-  
   
-  
-  
   
   
-  
-  
   
-  
-  
   
-  
-  
   
-  
-  
-  
   
   
   
-  
   
   
   
   
   
-  
   
+  
   
   
   
+  
   
   
-  
-  
   
+  
   
   
   
   
-  
   
   
+  
   
   
   
   
   
   
-  
-  
-  
   
+  
   
   
   
   
-  
-  
   
   
   
-  
   
   
   
   
   
+  
   
-  
   
+  
   
   
   
@@ -114,38 +215,14 @@
   
   
   
-  
   
+  
   
   
   
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
   
-  
   
+  
   
   
   
@@ -163,27 +240,17 @@
   
   
   
-  
-  
   
-  
   
-  
-  
-  
   
   
-  
-  
   
   
   
+  
   
   
-  
   
-  
-  
   
   
   
@@ -194,25 +261,31 @@
   
   
   
-  
   
   
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
   
   
   
-  
-  
   
   
-  
   
   
   
+  
   
   
-  
-  
   
+  
   
   
   
@@ -222,8 +295,8 @@
   
   
   
-  
   
+  
   
   
   
@@ -231,34 +304,26 @@
   
   
   
-  
   
+  
   
   
   
-  
-  
-  
+  
   
   
-  
-  
   
   
   
   
-  
   
+  
   
   
-  
   
   
   
   
-  
-  
-  
   
   
   
@@ -269,174 +334,153 @@
   
   
   
-  
   
-  
-  
+  
   
   
-  
-  
   
   
   
-  
   
+  
   
   
-  
+  
   
   
   
-  
+  
   
   
-  
   
+  
   
   
+  
   
   
-  
+  
   
   
-  
-  
   
+  
   
   
   
-  
-  
   
   
   
-  
-  
-  
-  
   
+  
   
-  
-  
-  
   
   
+  
   
   
   
-  
   
+  
   
-  
-  
-  
-  
-  
   
+  
+  
   
   
   
   
   
   
+  
   
   
   
   
-  
   
   
   
   
   
   
-  
   
+  
   
   
   
+  
   
   
-  
   
+  
   
   
-  
   
+  
   
   
   
   
-  
-  
-  
-  
   
   
   
   
+  
   
   
   
-  
-  
   
-  
+  
   
   
   
-  
   
+  
   
   
   
-  
   
+  
   
-  
   
+  
   
   
   
   
-  
   
+  
   
   
   
   
-  
-  
-  
   
   
   
   
   
-  
   
+  
+  
   
   
-  
-  
   
+  
   
   
   
   
   
-  
   
+  
   
   
+  
   
   
   
   
   
   
-  
   
   
   
@@ -445,9 +489,9 @@
   
   
   
-  
-  
   
+  
+  
   
   
   
@@ -455,16 +499,16 @@
   
   
   
-  
   
+  
   
   
   
   
   
   
-  
   
+  
   
   
   
@@ -472,22 +516,22 @@
   
   
   
-  
   
+  
+  
   
   
-  
   
   
   
   
-  
   
+  
+  
   
   
-  
-  
   
+  
   
   
   
@@ -495,77 +539,69 @@
   
   
   
-  
-  
-  
   
   
+  
   
   
-  
   
   
+  
   
   
-  
   
-  
-  
-  
-  
-  
+  
   
   
-  
   
   
   
-  
-  
   
   
   
   
+  
+  
+  
+  
+  
   
-  
-  
   
   
   
   
-  
   
-  
+  
+  
+  
   
+  
   
   
-  
   
-  
+  
   
-  
+  
   
+  
   
-  
   
+  
   
   
   
-  
   
-  
+  
   
+  
   
   
   
-  
-  
-  
   
   
   
-  
   
+  
   
   
   
@@ -577,14 +613,14 @@
   
   
   
-  
   
+  
   
   
-  
-  
-  
   
+  
+  
+  
   
   
   
@@ -604,24 +640,20 @@
   
   
   
-  
-  
-  
   
-  
   
   
   
   
-  
   
-  
   
+  
+  
+  
   
   
   
   
-  
   
   
   
@@ -630,60 +662,58 @@
   
   
   
-  
-  
+  
   
+  
   
   
   
-  
   
-  
+  
   
+  
   
-  
   
+  
   
   
+  
   
+  
   
   
-  
   
-  
-  
-  
   
   
   
   
   
   
-  
   
+  
   
   
   
+  
   
   
-  
   
   
   
   
   
+  
   
   
-  
   
   
-  
-  
   
   
   
   
   
+  
+  

[Libreoffice-bugs] [Bug 103244] local help (IT) for CALC (document protection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103244

Valter Mura  changed:

   What|Removed |Added

 CC||valterm...@gmail.com

--- Comment #2 from Valter Mura  ---
Hi,

discrepancy confirmed, there is a difference between the documentation, that
follows the old menu structure, and the new interface.

The new menu is here:
https://translations.documentfoundation.org/it/libo_ui/translate/officecfg/registry/data/org/openoffice/Office/UI.po#unit=100534789

but the interface points to:
https://translations.documentfoundation.org/it/libo_help/translate/scalc/guide.po#unit=30707091

which is correctly translated, but doesn't follow the new menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103321] New: After freeze, an old version of my file is recovered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103321

Bug ID: 103321
   Summary: After freeze, an old version of my file is recovered
   Product: LibreOffice
   Version: 5.2.1.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: joseph.h...@aya.yale.edu

Description:
While working on Writer document, I attempted to add a Zotero reference and got
the error message that Zotero wasn't open. The error dialogue wouldn't go away
and there was no way to interact with LibreOffice, so after several minutes I
force quit it. When I reopened LibreOffice, it offered to recover the document,
yet it recovered the same version I had saved 3 hours before. I have the
preferences set to save every 2 minutes, so I should have lost no more than 2
minutes of work.

I should mention that this has been happening to me for several years—whenever
there's a Zotero-related crash, LibreOffice often seems to revert to the saved
version instead of using an autosaved version. 

Steps to Reproduce:
1. Attempt to interact with Zotero when Zotero is not open
2. When LibreOffice freezes, force quit and restart
3. Click "ok" when asked whether you want to recover the document

Actual Results:  
LibreOffice restores my last saved version.

Expected Results:
LibreOffice should restore a version autosaved less than 2 minutes ago


Reproducible: Sometimes

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||103318


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103318
[Bug 103318] libreoffice Math: underbrace and overbrace are totally displaced
on screen and printout
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103038] Math Formula are rendered in system font (Segoe UI) on win8 or 10 when OpenGL is disabled, not the module default OpenSymbol

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103038

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3318

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32362] Bad behavior of scalable brackets with large objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32362

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3318

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39750] [Task] General formula editor improvements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39750

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||103318


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103318
[Bug 103318] libreoffice Math: underbrace and overbrace are totally displaced
on screen and printout
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103318] libreoffice Math: underbrace and overbrace are totally displaced on screen and printout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103318

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=32
   ||362,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3038
 Blocks||39750, 71732
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Isolating the two nodes requires an extra space after the integral, so formula
needed is

int from {4} to {5} `{2 x + 4} underbrace {u(X)}

However, confirmed on Windows 8.1 Ent 64-bit with *default* graphics rendering
Version: 5.3.0.0.alpha0+
Build ID: d83748d6bfaf97c686ced436506102148e796f34
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-10-14_08:02:08
Locale: en-US (en_US); Calc: CL

With default rendering, system font Segoe UI is used by SimpleWinLayout and the
nodes are misplaced and badly scaled.

However, if you can enable OpenGL with the extra grave space, the nodes are
rendered in OpenSymbol, and positioning is close to correct (but the underbrace
is still oddly scaled). Multiple glyph brackets need to be implemented at some
point to render cleaner formula nodes--ref bug 32362


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
[Bug 39750] [Task] General formula editor improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101714] Comments as pop-ups

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101714

--- Comment #3 from Patrick  ---
I am suggesting this as an option. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103315] Editing conditional formats restores removed conditional formats

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103315

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE

--- Comment #2 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 96453 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89676] 4.4.x: Bundled templates are not localizable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89676

--- Comment #4 from Yousuf Philips (jay)  ---
(In reply to miles from comment #3)
> Hi,

Hey,

> using English, non-localized text is the worst thing.
> 
> I would suggest to use dummy text, if possible word "LibreOffice".

So "LibreOffice" for the title and dummy latin text for the subtitle/context
text?

> I am not sure about the script/font used to represent it (i.e. if in Chinese
> or Japanese latin letters are supposed to be represented).

It would use the font assigned in the template.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103311] Tools -> Mail Merge Wizard can't insert anything

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103311

Cor Nouws  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 CC||c...@nouenoff.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/Util.hpp

[Michael Meeks]

 loolwsd/DocumentBroker.cpp |   39 ---
 loolwsd/Util.hpp   |7 +++
 2 files changed, 27 insertions(+), 19 deletions(-)

New commits:
commit 8d4c5d4e68eaf196a9e6c7478fbee15285beac04
Author: Michael Meeks 
Date:   Tue Oct 18 21:51:11 2016 +0100

Avoid deadlock when notifying users of document load failure.

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 624b2be..3adc1ad 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -410,30 +410,30 @@ size_t 
DocumentBroker::addSession(std::shared_ptr& session)
 const auto id = session->getId();
 const std::string aMessage = "session " + id + " " + _docKey + "\n";
 
-std::lock_guard lock(_mutex);
+try
+{
+std::lock_guard lock(_mutex);
 
-// Request a new session from the child kit.
-Log::debug("DocBroker to Child: " + aMessage.substr(0, aMessage.length() - 
1));
-_childProcess->sendTextFrame(aMessage);
+// Request a new session from the child kit.
+Log::debug("DocBroker to Child: " + aMessage.substr(0, 
aMessage.length() - 1));
+_childProcess->sendTextFrame(aMessage);
 
-auto ret = _sessions.emplace(id, session);
-if (!ret.second)
-{
-Log::warn("DocumentBroker: Trying to add already existing session.");
-}
+auto ret = _sessions.emplace(id, session);
+if (!ret.second)
+{
+Log::warn("DocumentBroker: Trying to add already existing 
session.");
+}
 
-if (session->isReadOnly())
-{
-Log::debug("Adding a readonly session [" + id + "]");
-}
+if (session->isReadOnly())
+{
+Log::debug("Adding a readonly session [" + id + "]");
+}
 
-// Below values are recalculated when startDestroy() is called (before 
destroying the
-// document). It is safe to reset their values to their defaults whenever 
a new session is added.
-_lastEditableSession = false;
-_markToDestroy = false;
+// Below values are recalculated when startDestroy() is called (before 
destroying the
+// document). It is safe to reset their values to their defaults 
whenever a new session is added.
+_lastEditableSession = false;
+_markToDestroy = false;
 
-try
-{
 load(id, std::to_string(_childProcess->getPid()));
 }
 catch (const StorageSpaceLowException&)
@@ -491,6 +491,7 @@ size_t DocumentBroker::removeSession(const std::string& id)
 
 void DocumentBroker::alertAllUsersOfDocument(const std::string& cmd, const 
std::string& kind)
 {
+Util::assertIsNotLocked(_mutex);
 std::lock_guard lock(_mutex);
 
 std::stringstream ss;
diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp
index a55c70e..d99fd36 100644
--- a/loolwsd/Util.hpp
+++ b/loolwsd/Util.hpp
@@ -106,6 +106,13 @@ namespace Util
 assert(!mtx.try_lock());
 }
 
+inline
+void assertIsNotLocked(std::mutex& mtx)
+{
+assert(mtx.try_lock());
+mtx.unlock();
+}
+
 /// Safely remove a file or directory.
 /// Supresses exception when the file is already removed.
 /// This can happen when there is a race (unavoidable) or when
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 85940] Accessing paragraph and character styles from context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85940

--- Comment #10 from Yousuf Philips (jay)  ---
(In reply to Cor Nouws from comment #9)
> So the context menu would be
> 
> 
> Styles > Clear direct Formatting

I'd put this at the bottom, but its up to you.

>  ---
>  Edit Style
>  ---
>  Character Styles  >
>  ---
>  Paragraph Styles  >

As 'Edit Style' is editing paragraph style, i'd put those together

---
Edit Paragraph Style
Paragraph Styles  >
---
Character Styles  >

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 85940] Accessing paragraph and character styles from context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85940

--- Comment #10 from Yousuf Philips (jay)  ---
(In reply to Cor Nouws from comment #9)
> So the context menu would be
> 
> 
> Styles > Clear direct Formatting

I'd put this at the bottom, but its up to you.

>  ---
>  Edit Style
>  ---
>  Character Styles  >
>  ---
>  Paragraph Styles  >

As 'Edit Style' is editing paragraph style, i'd put those together

---
Edit Paragraph Style
Paragraph Styles  >
---
Character Styles  >

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103279] Left brace in formula drawn distorted and displaced with OpenGL render

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103279

V Stuart Foote  changed:

   What|Removed |Added

 CC||joern.k...@gmail.com

--- Comment #6 from V Stuart Foote  ---
*** Bug 102165 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102165] scaled parenthesis overlap other elements in formular

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102165

--- Comment #8 from V Stuart Foote  ---
of course that dupe should be to bug 103279 not 297, and ref to bug 99231 not
92231--sorry for the noise and my dyslexia.

*** This bug has been marked as a duplicate of bug 103279 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - ucbhelper/source

[Damjan Jovanovic]

 ucbhelper/source/provider/resultsethelper.cxx |   45 --
 1 file changed, 28 insertions(+), 17 deletions(-)

New commits:
commit cea03b42ca0e2cd4d93c01879dec388295b8f771
Author: Damjan Jovanovic 
Date:   Tue Oct 18 17:52:44 2016 +

#i125868# AOO crashes if JRE (Java) is not installed (using help search or 
picture/makros)

ucbhelper::ResultSetHelper methods calling init() can only throw
RuntimeException, yet Exception or its other subclasses are
thrown in some cases (eg. with Java disabled, try searching
the Help index), resulting in unexpected() on at least FreeBSD
and MacOS that crashes AOO.

Fix this by catching Exception and instead throwing a
RuntimeException with its message.

Patch by: me

diff --git a/ucbhelper/source/provider/resultsethelper.cxx 
b/ucbhelper/source/provider/resultsethelper.cxx
index 4cde2c4..08cc0b3 100644
--- a/ucbhelper/source/provider/resultsethelper.cxx
+++ b/ucbhelper/source/provider/resultsethelper.cxx
@@ -298,27 +298,38 @@ void ResultSetImplHelper::init( sal_Bool bStatic )
 
 if ( !m_bInitDone )
 {
-if ( bStatic )
+try
 {
-// virtual... derived class fills m_xResultSet1
-initStatic();
-
-OSL_ENSURE( m_xResultSet1.is(),
-"ResultSetImplHelper::init - No 1st result set!" );
-m_bStatic = sal_True;
+if ( bStatic )
+{
+// virtual... derived class fills m_xResultSet1
+initStatic();
+
+OSL_ENSURE( m_xResultSet1.is(),
+"ResultSetImplHelper::init - No 1st result set!" );
+m_bStatic = sal_True;
+}
+else
+{
+// virtual... derived class fills m_xResultSet1 and 
m_xResultSet2
+initDynamic();
+
+OSL_ENSURE( m_xResultSet1.is(),
+"ResultSetImplHelper::init - No 1st result set!" );
+OSL_ENSURE( m_xResultSet2.is(),
+"ResultSetImplHelper::init - No 2nd result set!" );
+m_bStatic = sal_False;
+}
+m_bInitDone = sal_True;
+}
+catch ( uno::RuntimeException const  )
+{
+throw runtimeException;
 }
-else
+catch ( uno::Exception const  )
 {
-// virtual... derived class fills m_xResultSet1 and m_xResultSet2
-initDynamic();
-
-OSL_ENSURE( m_xResultSet1.is(),
-"ResultSetImplHelper::init - No 1st result set!" );
-OSL_ENSURE( m_xResultSet2.is(),
-"ResultSetImplHelper::init - No 2nd result set!" );
-m_bStatic = sal_False;
+throw uno::RuntimeException( exception.Message, uno::Reference< 
XInterface >() );
 }
-m_bInitDone = sal_True;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 83853] Other: Printing from File>Labels fails without error message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83853

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #12 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, data appear when
printing on file.
Data don't appear when exporting in pdf, just fields appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

[Giuseppe Castagno]

 sfx2/source/doc/sfxbasemodel.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 71dfc1113e45caff3d2ff43261a81c8cadae340a
Author: Giuseppe Castagno 
Date:   Sun Oct 16 10:11:13 2016 +0200

tdf#103274 (8): Add default XCommandEnvironment reference

Change-Id: I583ed0714c0bf543c44c098613e1aab9d3b31452
Reviewed-on: https://gerrit.libreoffice.org/30007
Tested-by: Jenkins 
Reviewed-by: Giuseppe Castagno 

diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 55bbf0a..27e79f8 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3942,7 +3942,7 @@ OUString SAL_CALL SfxBaseModel::getTitle()
 {
 try {
 ::ucbhelper::Content aContent( pMedium->GetName(),
-Reference(),
+utl::UCBContentHelper::getDefaultCommandEnvironment(),
 comphelper::getProcessComponentContext() );
 const Reference < beans::XPropertySetInfo > xProps
  = aContent.getProperties();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 89676] 4.4.x: Bundled templates are not localizable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89676

--- Comment #3 from mi...@filmsi.net ---
Hi,

using English, non-localized text is the worst thing.

I would suggest to use dummy text, if possible word "LibreOffice".

I am not sure about the script/font used to represent it (i.e. if in Chinese or
Japanese latin letters are supposed to be represented).

Lp, m.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source chart2/source cppuhelper/source dbaccess/source extensions/source filter/source forms/source fpicker/source framework/source pyuno/source reportdesign/sour

[Jochen Nitschke]

 basic/source/classes/sbunoobj.cxx   |  
  2 
 basic/source/runtime/methods1.cxx   |  
  6 -
 basic/source/uno/namecont.cxx   |  
  4 -
 chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx |  
  2 
 cppuhelper/source/propshlp.cxx  |  
  2 
 dbaccess/source/ui/dlg/paramdialog.cxx  |  
  2 
 extensions/source/propctrlr/stringrepresentation.cxx|  
  2 
 filter/source/pdf/impdialog.cxx |  
  2 
 forms/source/component/Grid.cxx |  
  2 
 forms/source/component/ListBox.cxx  |  
  2 
 fpicker/source/office/OfficeFilePicker.cxx  |  
  2 
 framework/source/fwe/classes/addonsoptions.cxx  |  
 24 +++
 pyuno/source/module/pyuno.cxx   |  
  8 +-
 pyuno/source/module/pyuno_callable.cxx  |  
  2 
 reportdesign/source/core/api/ReportDefinition.cxx   |  
  4 -
 reportdesign/source/ui/dlg/AddField.cxx |  
  2 
 reportdesign/source/ui/inspection/DataProviderHandler.cxx   |  
  4 -
 reportdesign/source/ui/inspection/GeometryHandler.cxx   |  
  2 
 sc/source/filter/oox/defnamesbuffer.cxx |  
  2 
 sc/source/ui/unoobj/viewuno.cxx |  
  4 -
 sc/source/ui/view/viewfunc.cxx  |  
  2 
 sd/source/filter/eppt/pptx-text.cxx |  
  2 
 sd/source/ui/table/TableDesignPane.cxx  |  
  2 
 sdext/source/minimizer/optimizationstats.cxx|  
  2 
 svtools/source/graphic/renderer.cxx |  
  2 
 svtools/source/uno/unoiface.cxx |  
 14 ++--
 svx/source/unodraw/unoshap4.cxx |  
  4 -
 toolkit/source/awt/vclxwindows.cxx  |  
 32 +-
 toolkit/source/controls/controlmodelcontainerbase.cxx   |  
  2 
 toolkit/source/controls/eventcontainer.cxx  |  
  4 -
 toolkit/source/controls/tabpagecontainer.cxx|  
  2 
 toolkit/source/controls/unocontrolcontainermodel.cxx|  
  2 
 ucb/source/core/ucb.cxx |  
  2 
 ucb/source/ucp/file/shell.cxx   |  
  2 
 ucb/source/ucp/gio/gio_content.cxx  |  
  2 
 ucb/source/ucp/webdav-neon/webdavcontent.cxx|  
  2 
 writerfilter/source/dmapper/SdtHelper.cxx   |  
  2 
 xmloff/source/draw/animationimport.cxx  |  
  2 
 xmloff/source/draw/ximpcustomshape.cxx  |  
  2 
 xmloff/source/style/xmlimppr.cxx|  
  2 
 40 files changed, 83 insertions(+), 83 deletions(-)

New commits:
commit d1ea6ecda68bf65b8d90e9ea17fa0a218a92b016
Author: Jochen Nitschke 
Date:   Sun Oct 16 20:08:47 2016 +0200

replace <<= with assign for <<= with rhs Any

found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke 
Tested-by: Jochen Nitschke 

diff --git a/basic/source/classes/sbunoobj.cxx 
b/basic/source/classes/sbunoobj.cxx
index 1933e69..2a73adf 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -4475,7 +4475,7 @@ Reference< XInterface > createComListener( const Any& 
aControlAny, const OUStrin
 Reference< XInvocation > xProxy = new ModuleInvocationProxy( aPrefix, 
xScopeObj );
 
 Sequence args( 3 );
-args[0] <<= aControlAny;
+args[0] = aControlAny;
 args[1] <<= aVBAType;
 args[2] <<= xProxy;
 
diff --git a/basic/source/runtime/methods1.cxx 
b/basic/source/runtime/methods1.cxx
index 1166cb7..a93e988 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -2885,7 +2885,7 @@ RTLFUNC(NPV)
 aValues >>= sValues[ 0 ];
 aValues <<= sValues;
 
-aParams[ 1 ] <<= aValues;
+aParams[ 1 ] = aValues;
 
 CallFunctionAccessFunction( aParams, "NPV", rPar.Get( 0 ) );
 }
@@ -2959,7 +2959,7 @@ 

[Libreoffice-bugs] [Bug 103311] Tools -> Mail Merge Wizard can't insert anything

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103311

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||glo...@fbihome.de,
   ||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #2 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

At step 3, I noticed on console these logs:
warn:sc:3501:1:sc/source/filter/orcus/orcusfiltersimpl.cxx:163: Unable to load
styles from xml file! failed to load 
warn:dbaccess.core:3501:1:dbaccess/source/core/api/RowSetCache.cxx:134:
ORowSetCache: exception: The result set is read-only.
warn:dbaccess.core:3501:1:dbaccess/source/core/api/RowSetCache.cxx:134:
ORowSetCache: exception: The result set is read-only.

At step 4, I noticed on console these logs:
warn:vcl:3501:1:vcl/source/window/builder.cxx:220: missing either source
femalecolft or target fieldname member of Mnemonic Widget Mapping
warn:vcl:3501:1:vcl/source/window/builder.cxx:220: missing either source
femalefieldft or target fieldvalue member of Mnemonic Widget Mapping

Jan-Marek: knowing your work on MM, thought you might be interested in this
one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucb/source

[Jochen Nitschke]

 ucb/source/cacher/cachedcontentresultset.cxx |5 ++---
 ucb/source/ucp/file/filrow.cxx   |4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 55bcb865ee09673af06652e507d08d13069eae86
Author: Jochen Nitschke 
Date:   Mon Oct 17 17:00:10 2016 +0200

ucb: fix handling of >>= with rhs Any

>>= for rhs Any is always true, check result with hasValue() instead.

bool convert(...) always returns false and assigns
the 3rd parameter to the 4th.
do the assign directly and check result with hasValue().

Change-Id: I0ae985cc0837abf1108930d593edae69de2ae549
Reviewed-on: https://gerrit.libreoffice.org/29977
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/ucb/source/cacher/cachedcontentresultset.cxx 
b/ucb/source/cacher/cachedcontentresultset.cxx
index c45410b..abf29aa 100644
--- a/ucb/source/cacher/cachedcontentresultset.cxx
+++ b/ucb/source/cacher/cachedcontentresultset.cxx
@@ -2118,10 +2118,9 @@ Any SAL_CALL CachedContentResultSet
 }
 //@todo: pay attention to typeMap
 const Any& rValue = m_aCache.getAny( nRow, columnIndex );
-Any aRet;
 m_bLastReadWasFromCache = true;
-m_bLastCachedReadWasNull = !( rValue >>= aRet );
-return aRet;
+m_bLastCachedReadWasNull = !rValue.hasValue();
+return rValue;
 }
 
 //virtual
diff --git a/ucb/source/ucp/file/filrow.cxx b/ucb/source/ucp/file/filrow.cxx
index aafeca5..3709062 100644
--- a/ucb/source/ucp/file/filrow.cxx
+++ b/ucb/source/ucp/file/filrow.cxx
@@ -307,9 +307,9 @@ XRow_impl::getObject(
 {
 if( columnIndex < 1 || columnIndex > m_aValueMap.getLength() )
 throw sdbc::SQLException( THROW_WHERE, uno::Reference< uno::XInterface 
>(), OUString(), 0, uno::Any() );
-uno::Any  Value;
 osl::MutexGuard aGuard( m_aMutex );
-m_nWasNull = ::convert( m_pMyShell,m_xTypeConverter,m_aValueMap[ 
--columnIndex ],Value );
+uno::Any Value = m_aValueMap[columnIndex - 1];
+m_nWasNull = !Value.hasValue();
 return Value;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #42 from Cor Nouws  ---
perfectly fine for me to adapt the patch (comment #33) to make a submenu Styles
with at least some character styles.
  Bug 85940 - Accessing paragraph and character styles from context menu

If this needs more time (> few weeks?), I suggest to push the patch as is for
the moment. OK?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Eike Rathke]

 sc/qa/unit/ucalc_formula.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit 5cfbab03f914946bf9e5813eae707328fda438f9
Author: Eike Rathke 
Date:   Tue Oct 18 20:50:40 2016 +0200

unit test for tdf#101583, named expression reference expansion

Change-Id: I40dc157ebb33da59e436214b703800dfabc11a23

diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index c343686..37d4981 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -2764,6 +2764,20 @@ void Test::testFormulaRefUpdateNameExpandRef()
 m_pDoc->SetValue(ScAddress(0,3,0), 4.0);
 CPPUNIT_ASSERT_EQUAL(10.0, m_pDoc->GetValue(ScAddress(0,6,0)));
 
+// Insert a new column at column 2, which should not expand the named
+// range as it is only one column wide.
+rFunc.InsertCells(ScRange(1,0,0,1,MAXROW,0), , INS_INSCOLS_BEFORE, 
false, true);
+pName = m_pDoc->GetRangeName()->findByUpperName("MYRANGE");
+CPPUNIT_ASSERT(pName);
+pName->GetSymbol(aSymbol, m_pDoc->GetGrammar());
+CPPUNIT_ASSERT_EQUAL(OUString("$A$1:$A$4"), aSymbol);
+
+// Make sure the referenced area has not changed.
+m_pDoc->SetValue(ScAddress(0,3,0), 2.0);
+CPPUNIT_ASSERT_EQUAL(8.0, m_pDoc->GetValue(ScAddress(0,6,0)));
+m_pDoc->SetValue(ScAddress(1,3,0), 2.0);
+CPPUNIT_ASSERT_EQUAL(8.0, m_pDoc->GetValue(ScAddress(0,6,0)));
+
 // Clear the document and start over.
 m_pDoc->GetRangeName()->clear();
 clearSheet(m_pDoc, 0);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 85940] Accessing paragraph and character styles from context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85940

--- Comment #9 from Cor Nouws  ---
So the context menu would be


Styles > Clear direct Formatting
 ---
 Edit Style
 ---
 Character Styles  >
 ---
 Paragraph Styles  >

?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 85940] Accessing paragraph and character styles from context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85940

--- Comment #9 from Cor Nouws  ---
So the context menu would be


Styles > Clear direct Formatting
 ---
 Edit Style
 ---
 Character Styles  >
 ---
 Paragraph Styles  >

?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

Re: Merging feature/commonsallayout branch

[Milos Sramek]

Dear Khaled,

do you think that extensive comparison of rendering of numerous
documents with and without the new layout engine makes sense?
If yes, I can run my tests in such a way to see if there are any
differences.

My test documents use latin script except for a few ones in Chinese. So,
if you happen to have sume documents in Arabic I can add them to my test
set.

best
Milos



On 2016-10-17 21:30, Khaled Hosny wrote:
> I believe that feature/commonsallayout (AKA unified text layout) is now
> feature complete with no known major bugs, and should be ready to be
> merged on master. I’ll try merge it tomorrow night and hope for the
> best, unless someone objects loudly.
>
> Currently the new layout is off by default and can be enabled at runtime
> by setting SAL_USE_COMMON_LAYOUT env variable. After merging with
> master, I’m going to wait a week or so for any potential build issues
> then swap the default.
>
> There are too main issues with the new code:
> - Type 1 fonts are not supported. They can be supported with some
>   effort, but Type 1 fonts have been obsolete for more than 15 years and
>   I’d like to use this opportunity to drop support for them and cleanup
>   some of the ugly code we have.
> - We use a bit of DirectWrite to load fonts on Windows, so Windows XP is
>   not supported as well. Again it can be fixed with some effort, but I
>   don’t think anyone will miss XP. Ideally we should do a full switch to
>   DirectWrite and modernise our Windows font rendering, but that is
>   another story.
>
> Regards,
> Khaled
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Milos Sramek, msrame...@gmail.com




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Merging feature/commonsallayout branch

[Stephan van den Akker]

Congratulations when this gets merged! It's a big chunk of work.

One question is on my mind that I was meaning to ask before: Is issue
tdf#66819 "Setting additional spacing between characters does not
prevent automatic ligature substitution." solved in this branch?

Greetings,

Stephan

2016-10-17 21:30 GMT+02:00 Khaled Hosny :
> I believe that feature/commonsallayout (AKA unified text layout) is now
> feature complete with no known major bugs, and should be ready to be
> merged on master. I’ll try merge it tomorrow night and hope for the
> best, unless someone objects loudly.
>
> Currently the new layout is off by default and can be enabled at runtime
> by setting SAL_USE_COMMON_LAYOUT env variable. After merging with
> master, I’m going to wait a week or so for any potential build issues
> then swap the default.
>
> There are too main issues with the new code:
> - Type 1 fonts are not supported. They can be supported with some
>   effort, but Type 1 fonts have been obsolete for more than 15 years and
>   I’d like to use this opportunity to drop support for them and cleanup
>   some of the ugly code we have.
> - We use a bit of DirectWrite to load fonts on Windows, so Windows XP is
>   not supported as well. Again it can be fixed with some effort, but I
>   don’t think anyone will miss XP. Ideally we should do a full switch to
>   DirectWrite and modernise our Windows font rendering, but that is
>   another story.
>
> Regards,
> Khaled
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #42 from Cor Nouws  ---
perfectly fine for me to adapt the patch (comment #33) to make a submenu Styles
with at least some character styles.
  Bug 85940 - Accessing paragraph and character styles from context menu

If this needs more time (> few weeks?), I suggest to push the patch as is for
the moment. OK?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

Re: Merging feature/commonsallayout branch

[Khaled Hosny]

On Mon, Oct 17, 2016 at 09:30:14PM +0200, Khaled Hosny wrote:
> I believe that feature/commonsallayout (AKA unified text layout) is now
> feature complete with no known major bugs, and should be ready to be
> merged on master. I’ll try merge it tomorrow night and hope for the
> best, unless someone objects loudly.

I just pushed the code into master, here is the summary of changes:

 RepositoryExternal.mk   |  20 +--
 config_host.mk.in   |   1 -
 configure.ac|  47 +++---
 external/harfbuzz/ExternalProject_harfbuzz.mk   |   5 +
 vcl/CppunitTest_vcl_wmf_test.mk |   5 +-
 vcl/Library_vcl.mk  |   6 +-
 vcl/README.vars |   1 +
 vcl/headless/svptext.cxx|  10 +-
 vcl/inc/CommonSalLayout.hxx |  82 +++
 vcl/inc/headless/svpgdi.hxx |   3 +-
 vcl/{ => inc}/quartz/ctfonts.hxx|   6 +-
 vcl/inc/quartz/salgdi.h |  18 ++-
 vcl/inc/salgdi.hxx  |   6 +-
 vcl/inc/sallayout.hxx   |   6 +-
 vcl/{unx/generic/glyphs => inc}/scrptrun.h  |   4 +-
 vcl/inc/textrender.hxx  |   3 +-
 vcl/inc/unx/cairotextrender.hxx |   2 +-
 vcl/inc/unx/genpspgraphics.h|   4 +-
 vcl/inc/unx/glyphcache.hxx  |   4 +
 vcl/inc/unx/salgdi.h|   3 +-
 vcl/inc/win/salgdi.h|  11 +-
 vcl/{win/gdi => inc/win}/winlayout.hxx  | 283 
+++-
 vcl/quartz/ctfonts.cxx  |   6 +-
 vcl/quartz/ctlayout.cxx |   2 +-
 vcl/quartz/salgdi.cxx   | 212 
+++
 vcl/source/gdi/CommonSalLayout.cxx  | 784 
++
 vcl/source/gdi/sallayout.cxx|   6 +
 vcl/{unx/generic/glyphs => source/gdi}/scrptrun.cxx |   0
 vcl/unx/generic/gdi/cairotextrender.cxx |  28 +++-
 vcl/unx/generic/gdi/font.cxx|  10 +-
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx  |   6 +-
 vcl/unx/generic/glyphs/gcach_layout.cxx |   3 +-
 vcl/unx/generic/print/genpspgraphics.cxx|   2 +-
 vcl/win/gdi/salfont.cxx |  29 +++-
 vcl/win/gdi/winlayout.cxx   | 429 
+-
 35 files changed, 1606 insertions(+), 441 deletions(-)

Regards,
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 101193] Return object Name and Description dialog buttons to object context menus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101193

--- Comment #13 from Cor Nouws  ---
(In reply to Cor Nouws from comment #12)

> Maybe someone can give some insight on the reasons for this detailed demand
> in the specs? From contact with someone in accessibility, looking for those
> attributes, I wouldn't be surprised if it comes from that expertise.

Looks so. Accidentally coming across
https://bugs.documentfoundation.org/show_bug.cgi?id=81132#c5

(Michael Meeks in comment #5)
> So - a point of fact here; the context menu is often exposed for a11y
> reasons to the Accessibility Technology, and removing things can have an
> impact. Having said that having smaller context menus is also a worthy goal.
> Ultimately this is one for the UX team I think - personally I love Jay's
> data-driven approach.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101193] Return object Name and Description dialog buttons to object context menus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101193

--- Comment #13 from Cor Nouws  ---
(In reply to Cor Nouws from comment #12)

> Maybe someone can give some insight on the reasons for this detailed demand
> in the specs? From contact with someone in accessibility, looking for those
> attributes, I wouldn't be surprised if it comes from that expertise.

Looks so. Accidentally coming across
https://bugs.documentfoundation.org/show_bug.cgi?id=81132#c5

(Michael Meeks in comment #5)
> So - a point of fact here; the context menu is often exposed for a11y
> reasons to the Accessibility Technology, and removing things can have an
> impact. Having said that having smaller context menus is also a worthy goal.
> Ultimately this is one for the UX team I think - personally I love Jay's
> data-driven approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 33 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/CppunitTest_vcl_wmf_test.mk vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quartz v

[Khaled Hosny]

 RepositoryExternal.mk  |   20 
 config_host.mk.in  |1 
 configure.ac   |   47 -
 external/harfbuzz/ExternalProject_harfbuzz.mk  |5 
 vcl/CppunitTest_vcl_wmf_test.mk|5 
 vcl/Library_vcl.mk |6 
 vcl/README.vars|1 
 vcl/headless/svptext.cxx   |   10 
 vcl/inc/CommonSalLayout.hxx|   82 ++
 vcl/inc/headless/svpgdi.hxx|3 
 vcl/inc/quartz/ctfonts.hxx |   34 +
 vcl/inc/quartz/salgdi.h|   18 
 vcl/inc/salgdi.hxx |6 
 vcl/inc/sallayout.hxx  |6 
 vcl/inc/scrptrun.h |  160 +
 vcl/inc/textrender.hxx |3 
 vcl/inc/unx/cairotextrender.hxx|2 
 vcl/inc/unx/genpspgraphics.h   |4 
 vcl/inc/unx/glyphcache.hxx |4 
 vcl/inc/unx/salgdi.h   |3 
 vcl/inc/win/salgdi.h   |   11 
 vcl/inc/win/winlayout.hxx  |  519 
 vcl/quartz/ctfonts.cxx |6 
 vcl/quartz/ctfonts.hxx |   34 -
 vcl/quartz/ctlayout.cxx|2 
 vcl/quartz/salgdi.cxx  |  212 +-
 vcl/source/gdi/CommonSalLayout.cxx |  784 +
 vcl/source/gdi/sallayout.cxx   |6 
 vcl/source/gdi/scrptrun.cxx|  234 +++
 vcl/unx/generic/gdi/cairotextrender.cxx|   28 
 vcl/unx/generic/gdi/font.cxx   |   10 
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |6 
 vcl/unx/generic/glyphs/gcach_layout.cxx|3 
 vcl/unx/generic/glyphs/scrptrun.cxx|  234 ---
 vcl/unx/generic/glyphs/scrptrun.h  |  160 -
 vcl/unx/generic/print/genpspgraphics.cxx   |2 
 vcl/win/gdi/salfont.cxx|   29 
 vcl/win/gdi/winlayout.cxx  |  429 +++--
 vcl/win/gdi/winlayout.hxx  |  240 ---
 39 files changed, 2267 insertions(+), 1102 deletions(-)

New commits:
commit 8b9ec421accf344e0e6921c35ba53d8ff0b2de40
Author: Khaled Hosny 
Date:   Mon Oct 17 19:59:23 2016 +0200

Fix debug build and few cleanups

Change-Id: I805962667c3ef2dcaf07a0acebeacca74c74892a

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index abc5ea7..cd43bec 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -50,9 +50,10 @@ class CommonSalLayout : public GenericSalLayout
 #else
 ServerFont& mrServerFont;
 #endif
-OString mLang;
-hb_feature_t * mpFeatures;
-unsigned int mnFeats;
+
+voidParseFeatures(const OUString& name);
+OString msLanguage;
+std::vector maFeatures;
 
 public:
 #if defined(_WIN32)
@@ -66,7 +67,6 @@ public:
 const ServerFont&   getFontData() const { return mrServerFont; };
 #endif
 
-voidParseFeatures(OUString name);
 voidSetNeedFallback(ImplLayoutArgs&, sal_Int32, bool);
 voidAdjustLayout(ImplLayoutArgs&) override;
 boolLayoutText(ImplLayoutArgs&) override;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 0966b29..f6088b8 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -126,18 +126,16 @@ static hb_unicode_funcs_t* getUnicodeFuncs()
 }
 #endif
 
-void CommonSalLayout::ParseFeatures(OUString name)
+void CommonSalLayout::ParseFeatures(const OUString& name)
 {
-mnFeats = 0;
-mpFeatures = 0;
-mLang = OString("");
+int nFeatures = 0;
 int nStart = name.indexOf(':');
 if (nStart < 0)
 return;
 OString oName = OUStringToOString(name, RTL_TEXTENCODING_ASCII_US);
 for (int nNext = nStart; nNext > 0; nNext = name.indexOf('&', nNext + 1))
 {
-if (name.match("lang=", nNext+1))
+if (name.match("lang=", nNext + 1))
 {
 int endamp = name.indexOf('&', nNext+1);
 int enddelim = name.indexOf(' ', nNext+1);
@@ -151,23 +149,23 @@ void CommonSalLayout::ParseFeatures(OUString name)
 end = endamp;
 else
 end = enddelim;
-mLang = oName.copy(nNext+6, end-nNext-6);
+msLanguage = oName.copy(nNext + 6, end - nNext - 6);
 }
 else
-++mnFeats;
+++nFeatures;
 }
-if (mnFeats == 0)
+if (nFeatures == 0)
 return;
 
-mpFeatures = new hb_feature_t[mnFeats];
-mnFeats = 0;
-for (int nThis = nStart, nNext = name.indexOf('&', nStart+1); nThis 

[Libreoffice-bugs] [Bug 100841] Dragging a cell's frame to Fill Series, etc - no longer shows a tooltip indicating currently reached value

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100841

Rene Engelhard  changed:

   What|Removed |Added

 Blocks||103182


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Rene Engelhard  changed:

   What|Removed |Added

 Depends on||100841


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100841
[Bug 100841] Dragging a cell's frame to Fill Series, etc - no longer shows a
tooltip indicating currently reached value
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97968] EDITING: Cut/paste doesn't change formula references

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97968

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #5 from Eike Rathke  ---
Taking.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmlsecurity/Library_xmlsecurity.mk xmlsecurity/source

[Miklos Vajna]

 xmlsecurity/Library_xmlsecurity.mk   |1 
 xmlsecurity/source/pdfio/pdfdocument.cxx |  206 ++-
 2 files changed, 204 insertions(+), 3 deletions(-)

New commits:
commit c70eeb2be7ac0a2c0c81a7cbc9642b0ae824b110
Author: Miklos Vajna 
Date:   Tue Oct 18 15:31:28 2016 +0200

xmlsecurity: use NSS on Linux/macOS to generate pdf signature

This is just the minimum so that our own PDF signature validation is
happy.

Change-Id: I1148817c11174fd4f9184d0ce2c0511e9d6bd11c
Reviewed-on: https://gerrit.libreoffice.org/30018
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/xmlsecurity/Library_xmlsecurity.mk 
b/xmlsecurity/Library_xmlsecurity.mk
index c5e8d68..e211c61 100644
--- a/xmlsecurity/Library_xmlsecurity.mk
+++ b/xmlsecurity/Library_xmlsecurity.mk
@@ -78,6 +78,7 @@ $(eval $(call gb_Library_add_defs,xmlsecurity,\
 ))
 $(eval $(call gb_Library_use_externals,xmlsecurity,\
 nss3 \
+plc4 \
 ))
 endif # BUILD_TYPE=DESKTOP
 endif
diff --git a/xmlsecurity/source/pdfio/pdfdocument.cxx 
b/xmlsecurity/source/pdfio/pdfdocument.cxx
index 9566083..3b01578 100644
--- a/xmlsecurity/source/pdfio/pdfdocument.cxx
+++ b/xmlsecurity/source/pdfio/pdfdocument.cxx
@@ -232,7 +232,102 @@ PDFDocument::PDFDocument()
 {
 }
 
-bool PDFDocument::Sign(const uno::Reference& 
/*xCertificate*/)
+#ifdef XMLSEC_CRYPTO_NSS
+static NSSCMSMessage* CreateCMSMessage(PRTime nTime,
+   NSSCMSSignedData** ppCMSSignedData,
+   NSSCMSSignerInfo** ppCMSSigner,
+   CERTCertificate* pCertificate,
+   SECItem* pDigest)
+{
+NSSCMSMessage* pResult = NSS_CMSMessage_Create(nullptr);
+if (!pResult)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSMessage_Create() failed");
+return nullptr;
+}
+
+*ppCMSSignedData = NSS_CMSSignedData_Create(pResult);
+if (!*ppCMSSignedData)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignedData_Create() failed");
+return nullptr;
+}
+
+NSSCMSContentInfo* pCMSContentInfo = 
NSS_CMSMessage_GetContentInfo(pResult);
+if (NSS_CMSContentInfo_SetContent_SignedData(pResult, pCMSContentInfo, 
*ppCMSSignedData) != SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSContentInfo_SetContent_SignedData() failed");
+return nullptr;
+}
+
+pCMSContentInfo = NSS_CMSSignedData_GetContentInfo(*ppCMSSignedData);
+
+// No detached data.
+if (NSS_CMSContentInfo_SetContent_Data(pResult, pCMSContentInfo, nullptr, 
PR_TRUE) != SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSContentInfo_SetContent_Data() failed");
+return nullptr;
+}
+
+*ppCMSSigner = NSS_CMSSignerInfo_Create(pResult, pCertificate, 
SEC_OID_SHA1);
+if (!*ppCMSSigner)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignerInfo_Create() failed");
+return nullptr;
+}
+
+if (NSS_CMSSignerInfo_AddSigningTime(*ppCMSSigner, nTime) != SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignerInfo_AddSigningTime() failed");
+return nullptr;
+}
+
+if (NSS_CMSSignerInfo_IncludeCerts(*ppCMSSigner, NSSCMSCM_CertChain, 
certUsageEmailSigner) != SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignerInfo_IncludeCerts() failed");
+return nullptr;
+}
+
+if (NSS_CMSSignedData_AddCertificate(*ppCMSSignedData, pCertificate) != 
SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignedData_AddCertificate() failed");
+return nullptr;
+}
+
+if (NSS_CMSSignedData_AddSignerInfo(*ppCMSSignedData, *ppCMSSigner) != 
SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignedData_AddSignerInfo() failed");
+return nullptr;
+}
+
+if (NSS_CMSSignedData_SetDigestValue(*ppCMSSignedData, SEC_OID_SHA1, 
pDigest) != SECSuccess)
+{
+SAL_WARN("xmlsecurity.pdfio", "CreateCMSMessage: 
NSS_CMSSignedData_SetDigestValue() failed");
+return nullptr;
+}
+
+return pResult;
+}
+
+static char* PasswordCallback(PK11SlotInfo* /*pSlot*/, PRBool /*bRetry*/, 
void* pArg)
+{
+return PL_strdup(static_cast(pArg));
+}
+
+static void AppendHex(sal_Int8 nInt, OStringBuffer& rBuffer)
+{
+static const sal_Char pHexDigits[] =
+{
+'0', '1', '2', '3', '4', '5', '6', '7',
+'8', '9', 'A', 'B', 'C', 'D', 'E', 'F'
+};
+rBuffer.append(pHexDigits[(nInt >> 4) & 15]);
+rBuffer.append(pHexDigits[nInt & 15]);
+}
+
+#endif
+
+bool PDFDocument::Sign(const uno::Reference& 
xCertificate)
 {
 m_aEditBuffer.WriteCharPtr("\n");
 
@@ -357,7 +452,7 @@ bool 

[Libreoffice-bugs] [Bug 102868] No "jump back" option, after jump to another cell ( with Cell Name box, TLHC of the sheet), to return to the previous cell address

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102868

--- Comment #10 from Dean  ---
I'm quite comfortable with your suggestion.

If there is some way that I can help, please let me know, and thanks for your
continuing interest and assistance.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102868] No "jump back" option, after jump to another cell ( with Cell Name box, TLHC of the sheet), to return to the previous cell address

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102868

--- Comment #10 from Dean  ---
I'm quite comfortable with your suggestion.

If there is some way that I can help, please let me know, and thanks for your
continuing interest and assistance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100468] Options font size too small, doesn' t change after installing -gnome, -gtk

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100468

--- Comment #7 from DorothyD  ---
Created attachment 128062
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128062=edit
Version 5.2.2.2 Ubuntu Mate

The problem appears on Version 5.2.2.2 just the same. Notice the options dialog
still has smaller font than the menus

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 130 commits - accessibility/source basctl/source basegfx/source basic/source compilerplugins/clang config_host.mk.in configure.ac con

[Khaled Hosny]

Rebased ref, commits from common ancestor:
commit d0b5e1536983dbc1d4eb1b34d9864a0cd6dc1406
Author: Khaled Hosny 
Date:   Mon Oct 17 19:59:23 2016 +0200

Fix debug build and few cleanups

Change-Id: I805962667c3ef2dcaf07a0acebeacca74c74892a

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index abc5ea7..cd43bec 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -50,9 +50,10 @@ class CommonSalLayout : public GenericSalLayout
 #else
 ServerFont& mrServerFont;
 #endif
-OString mLang;
-hb_feature_t * mpFeatures;
-unsigned int mnFeats;
+
+voidParseFeatures(const OUString& name);
+OString msLanguage;
+std::vector maFeatures;
 
 public:
 #if defined(_WIN32)
@@ -66,7 +67,6 @@ public:
 const ServerFont&   getFontData() const { return mrServerFont; };
 #endif
 
-voidParseFeatures(OUString name);
 voidSetNeedFallback(ImplLayoutArgs&, sal_Int32, bool);
 voidAdjustLayout(ImplLayoutArgs&) override;
 boolLayoutText(ImplLayoutArgs&) override;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 0966b29..f6088b8 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -126,18 +126,16 @@ static hb_unicode_funcs_t* getUnicodeFuncs()
 }
 #endif
 
-void CommonSalLayout::ParseFeatures(OUString name)
+void CommonSalLayout::ParseFeatures(const OUString& name)
 {
-mnFeats = 0;
-mpFeatures = 0;
-mLang = OString("");
+int nFeatures = 0;
 int nStart = name.indexOf(':');
 if (nStart < 0)
 return;
 OString oName = OUStringToOString(name, RTL_TEXTENCODING_ASCII_US);
 for (int nNext = nStart; nNext > 0; nNext = name.indexOf('&', nNext + 1))
 {
-if (name.match("lang=", nNext+1))
+if (name.match("lang=", nNext + 1))
 {
 int endamp = name.indexOf('&', nNext+1);
 int enddelim = name.indexOf(' ', nNext+1);
@@ -151,23 +149,23 @@ void CommonSalLayout::ParseFeatures(OUString name)
 end = endamp;
 else
 end = enddelim;
-mLang = oName.copy(nNext+6, end-nNext-6);
+msLanguage = oName.copy(nNext + 6, end - nNext - 6);
 }
 else
-++mnFeats;
+++nFeatures;
 }
-if (mnFeats == 0)
+if (nFeatures == 0)
 return;
 
-mpFeatures = new hb_feature_t[mnFeats];
-mnFeats = 0;
-for (int nThis = nStart, nNext = name.indexOf('&', nStart+1); nThis > 0; 
nThis = nNext, nNext = name.indexOf('&', nNext + 1))
+maFeatures.reserve(nFeatures);
+for (int nThis = nStart, nNext = name.indexOf('&', nStart + 1); nThis > 0; 
nThis = nNext, nNext = name.indexOf('&', nNext + 1))
 {
-if (!name.match("lang=", nThis+1))
+if (!name.match("lang=", nThis + 1))
 {
 int end = nNext > 0 ? nNext : name.getLength();
-if (hb_feature_from_string(oName.getStr() + nThis + 1, end - nThis 
- 1, [mnFeats]))
-++mnFeats;
+hb_feature_t aFeature;
+if (hb_feature_from_string(oName.getStr() + nThis + 1, end - nThis 
- 1, ))
+maFeatures.push_back(aFeature);
 }
 }
 }
@@ -463,9 +461,9 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 int nRunLen = nEndRunPos - nMinRunPos;
 aHbScript = hb_icu_script_to_script(aScriptRun.maScript);
 
-// hb_language_from_string() accept ISO639-3 language tag except 
for Chinese.
-LanguageTag  = rArgs.maLanguageTag;
-OString sLanguage = mLang.getLength() ? mLang : 
OUStringToOString(rTag.getBcp47(), RTL_TEXTENCODING_ASCII_US);
+OString sLanguage = msLanguage;
+if (sLanguage.isEmpty())
+sLanguage = OUStringToOString(rArgs.maLanguageTag.getBcp47(), 
RTL_TEXTENCODING_ASCII_US);
 
 bool bVertical = false;
 if ((rArgs.mnFlags & SalLayoutFlags::Vertical) &&
@@ -498,7 +496,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 #if HB_VERSION_ATLEAST(0, 9, 42)
 hb_buffer_set_cluster_level(pHbBuffer, 
HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS);
 #endif
-hb_shape(mpHbFont, pHbBuffer, mpFeatures, mnFeats);
+hb_shape(mpHbFont, pHbBuffer, maFeatures.data(), 
maFeatures.size());
 
 int nRunGlyphCount = hb_buffer_get_length(pHbBuffer);
 hb_glyph_info_t *pHbGlyphInfos = 
hb_buffer_get_glyph_infos(pHbBuffer, nullptr);
commit 8b45bb381520bc6990c87966b09dcad90d4f5212
Author: Martin Hosken 
Date:   Mon Oct 17 15:22:32 2016 +0100

Add feature support to CommonLayout

Change-Id: I19a0e26cefa5e4185df961ae0f6f2f37811ae5bb
Reviewed-on: https://gerrit.libreoffice.org/29978

[ANNOUNCE] Tag libreoffice-5.1.6.2 (on branch libreoffice-5-1-6) created

[Jan Iversen]

The tag libreoffice-5.1.6.2 (AKA 5.1.6 RC2) has been created on the
libreoffice-5-1-6 branch.
The branch will be used for fine tuning of the 5.1.6 release. (It is
the last scheduled RC)

The following rules apply to the branch:

+ preferably just translation or blocker fixes
+ only cherry-picking from libreoffice-4-2 branch
+ 2 additional reviews needed; 2nd reviewer pushes
+ no regular merges back to anything

The ‘libreoffice-5-1' branch is still active but there are no more planned 5.1.x releases. Please read more at   http://wiki.documentfoundation.org/ReleasePlan/5.1#5.1.6_release
   http://wiki.documentfoundation.org/Development/Branches
   http://wiki.documentfoundation.org/Release_Criteria

To checkout the tag, use

./g fetch --tags
./g checkout -b tag-libreoffice-5.1.6.2 libreoffice-5.1.6.2

Linux distro packages might find source tarballs at
http://dev-builds.libreoffice.org/pre-releases/src/
They will soon be available from the official page together with the builds.

Attached is the list of changes against 5.1.6 RC1

Happy hacking,
Jan I

commits-libreoffice-5-1-6-release-libreoffice-5.1.6.2.log
Description: Binary data


bugs-libreoffice-5-1-6-release-libreoffice-5.1.6.2.log
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] [ANNOUNCE] Tag libreoffice-5.1.6.2 (on branch libreoffice-5-1-6) created

[Jan Iversen]

The tag libreoffice-5.1.6.2 (AKA 5.1.6 RC2) has been created on the
libreoffice-5-1-6 branch.
The branch will be used for fine tuning of the 5.1.6 release. (It is
the last scheduled RC)

The following rules apply to the branch:

+ preferably just translation or blocker fixes
+ only cherry-picking from libreoffice-4-2 branch
+ 2 additional reviews needed; 2nd reviewer pushes
+ no regular merges back to anything

The ‘libreoffice-5-1' branch is still active but there are no more planned 5.1.x releases. Please read more at   http://wiki.documentfoundation.org/ReleasePlan/5.1#5.1.6_release
   http://wiki.documentfoundation.org/Development/Branches
   http://wiki.documentfoundation.org/Release_Criteria

To checkout the tag, use

./g fetch --tags
./g checkout -b tag-libreoffice-5.1.6.2 libreoffice-5.1.6.2

Linux distro packages might find source tarballs at
http://dev-builds.libreoffice.org/pre-releases/src/
They will soon be available from the official page together with the builds.

Attached is the list of changes against 5.1.6 RC1

Happy hacking,
Jan I

commits-libreoffice-5-1-6-release-libreoffice-5.1.6.2.log
Description: Binary data


bugs-libreoffice-5-1-6-release-libreoffice-5.1.6.2.log
Description: Binary data
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 103320] New: [gtk3] pressed buttons on the toolbar have wrong coloring.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103320

Bug ID: 103320
   Summary: [gtk3] pressed buttons on the toolbar have wrong
coloring.
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@hussam.eu.org

Created attachment 128061
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128061=edit
gtk-demo toolbar vs LO toolbar.

Notice the pressed button in LO toolbar and the one in gtk3-demo.
The one in gtk3-demo has darker coloring for the pressed button area.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103318] libreoffice Math: underbrace and overbrace are totally displaced on screen and printout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103318

Julien Nabet  changed:

   What|Removed |Added

Summary|libreoffice Mathe:  |libreoffice Math:
   |underbrace and overbrace|underbrace and overbrace
   |are totally displaced on|are totally displaced on
   |screen and printout |screen and printout

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103256] cannot deactivate autocorrect of uppercase letters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103256

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #5 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, if I open your file,
without changing any option, then type "this is a sentence.", the first "t"
isn't put in uppercase.
I must have missed something.
I don't think I can't help here sorry.
Certainly may help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/core/draw/dcontact.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 03b8778130509d886a58255a6aa6aa94c5171ea4
Author: Caolán McNamara 
Date:   Tue Oct 18 19:02:02 2016 +0100

dynamic_cast followed by static_cast

Change-Id: I079b483f2fce1a55f5690fa5a990cbe40ead6a7a

diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index 0200bfa..c282108 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -99,9 +99,9 @@ SwFrameFormat *FindFrameFormat( SdrObject *pObj )
 {
 SwFrameFormat* pRetval = nullptr;
 
-if ( dynamic_cast( pObj) !=  nullptr )
+if (SwVirtFlyDrawObj* pFlyDrawObj = dynamic_cast(pObj))
 {
-   pRetval = static_cast(pObj)->GetFormat();
+   pRetval = pFlyDrawObj->GetFormat();
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source

[Caolán McNamara]

 cui/source/tabpages/tpgradnt.cxx  |6 --
 cui/source/tabpages/tphatch.cxx   |6 --
 cui/source/tabpages/tppattern.cxx |6 --
 3 files changed, 12 insertions(+), 6 deletions(-)

New commits:
commit 0a7d06cfc37f94f8a7571f023e1b78b6451a5367
Author: Caolán McNamara 
Date:   Tue Oct 18 18:56:29 2016 +0100

make area tab page of paragraph properties not crash

cause the parent dialog isn't a SvxAreaTabDialog

Change-Id: I1a1311ca4b414c797d4b3e72208e64bffea863ca

diff --git a/cui/source/tabpages/tpgradnt.cxx b/cui/source/tabpages/tpgradnt.cxx
index 68d2871..503e94a 100644
--- a/cui/source/tabpages/tpgradnt.cxx
+++ b/cui/source/tabpages/tpgradnt.cxx
@@ -184,8 +184,10 @@ void SvxGradientTabPage::ActivatePage( const SfxItemSet& 
rSet )
 if( *m_pnColorListState & ChangeType::CHANGED ||
 *m_pnColorListState & ChangeType::MODIFIED )
 {
-if( *m_pnColorListState & ChangeType::CHANGED )
-m_pColorList = static_cast( 
GetParentDialog() )->GetNewColorList();
+SvxAreaTabDialog* pArea = (*m_pnColorListState & 
ChangeType::CHANGED) ?
+dynamic_cast(GetParentDialog()) : nullptr;
+if (pArea)
+m_pColorList = pArea->GetNewColorList();
 
 // LbColorFrom
 nPos = m_pLbColorFrom->GetSelectEntryPos();
diff --git a/cui/source/tabpages/tphatch.cxx b/cui/source/tabpages/tphatch.cxx
index 9b6c5ad..7469d15 100644
--- a/cui/source/tabpages/tphatch.cxx
+++ b/cui/source/tabpages/tphatch.cxx
@@ -170,8 +170,10 @@ void SvxHatchTabPage::ActivatePage( const SfxItemSet& rSet 
)
 if( *m_pnColorListState & ChangeType::CHANGED ||
 *m_pnColorListState & ChangeType::MODIFIED )
 {
-if( *m_pnColorListState & ChangeType::CHANGED )
-m_pColorList = static_cast( 
GetParentDialog() )->GetNewColorList();
+SvxAreaTabDialog* pArea = (*m_pnColorListState & 
ChangeType::CHANGED) ?
+dynamic_cast(GetParentDialog()) : nullptr;
+if (pArea)
+m_pColorList = pArea->GetNewColorList();
 
 // LbLineColor
 nPos = m_pLbLineColor->GetSelectEntryPos();
diff --git a/cui/source/tabpages/tppattern.cxx 
b/cui/source/tabpages/tppattern.cxx
index c156d24..2ae6dfd79 100644
--- a/cui/source/tabpages/tppattern.cxx
+++ b/cui/source/tabpages/tppattern.cxx
@@ -175,8 +175,10 @@ void SvxPatternTabPage::ActivatePage( const SfxItemSet& 
rSet )
 if( *m_pnColorListState & ChangeType::CHANGED ||
 *m_pnColorListState & ChangeType::MODIFIED )
 {
-if( *m_pnColorListState & ChangeType::CHANGED )
-m_pColorList = static_cast( 
GetParentDialog() )->GetNewColorList();
+SvxAreaTabDialog* pArea = (*m_pnColorListState & 
ChangeType::CHANGED) ?
+dynamic_cast(GetParentDialog()) : nullptr;
+if (pArea)
+m_pColorList = pArea->GetNewColorList();
 
 // LbColor
 nPos = m_pLbColor->GetSelectEntryPos();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92091] Renders some Persian texts wrongly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92091

--- Comment #4 from Arham Amouei  ---
Also it appears in LibreOffice 5.2.2.2 on Ubuntu 16.04 64bit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/tool/token.cxx |   50 ++
 1 file changed, 32 insertions(+), 18 deletions(-)

New commits:
commit 6b9804b8f2ca85e9eb42d344d17cfee7a7a9414c
Author: Eike Rathke 
Date:   Tue Oct 18 19:30:24 2016 +0200

Resolves: tdf#101583 references to be expanded must be at least 2 cols/rows

... wide/tall also in named expressions.

Change-Id: If0c192def74812cc9405ae633b6f83f7021344d0

diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 407a100..44dbe38 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -3491,28 +3491,36 @@ bool adjustDoubleRefInName(
 {
 if (rCxt.mnRowDelta > 0 && !rRef.Ref1.IsRowRel() && 
!rRef.Ref2.IsRowRel())
 {
-// Check and see if we should expand the range at the top.
-ScRange aSelectedRange = getSelectedRange(rCxt);
 ScRange aAbs = rRef.toAbs(rPos);
-if (aSelectedRange.Intersects(aAbs))
+// Expand only if at least two rows tall.
+if (aAbs.aStart.Row() < aAbs.aEnd.Row())
 {
-// Selection intersects the referenced range. Only expand the
-// bottom position.
-rRef.IncEndRowSticky(rCxt.mnRowDelta, rPos);
-return true;
+// Check and see if we should expand the range at the top.
+ScRange aSelectedRange = getSelectedRange(rCxt);
+if (aSelectedRange.Intersects(aAbs))
+{
+// Selection intersects the referenced range. Only expand 
the
+// bottom position.
+rRef.IncEndRowSticky(rCxt.mnRowDelta, rPos);
+return true;
+}
 }
 }
 if (rCxt.mnColDelta > 0 && !rRef.Ref1.IsColRel() && 
!rRef.Ref2.IsColRel())
 {
-// Check and see if we should expand the range at the left.
-ScRange aSelectedRange = getSelectedRange(rCxt);
 ScRange aAbs = rRef.toAbs(rPos);
-if (aSelectedRange.Intersects(aAbs))
+// Expand only if at least two columns wide.
+if (aAbs.aStart.Col() < aAbs.aEnd.Col())
 {
-// Selection intersects the referenced range. Only expand the
-// right position.
-rRef.IncEndColSticky(rCxt.mnColDelta, rPos);
-return true;
+// Check and see if we should expand the range at the left.
+ScRange aSelectedRange = getSelectedRange(rCxt);
+if (aSelectedRange.Intersects(aAbs))
+{
+// Selection intersects the referenced range. Only expand 
the
+// right position.
+rRef.IncEndColSticky(rCxt.mnColDelta, rPos);
+return true;
+}
 }
 }
 }
@@ -3736,8 +3744,11 @@ sc::RefUpdateResult ScTokenArray::AdjustReferenceInName(
 {
 // Check if we could expand range reference by the 
bottom
 // edge. For named expressions, we only expand 
absolute
-// references.
-if (!rRef.Ref1.IsRowRel() && !rRef.Ref2.IsRowRel() 
&& aAbs.aEnd.Row()+1 == rCxt.maRange.aStart.Row())
+// references. Reference must be at least two rows
+// tall.
+if (!rRef.Ref1.IsRowRel() && !rRef.Ref2.IsRowRel() 
&&
+aAbs.aStart.Row() < aAbs.aEnd.Row() &&
+aAbs.aEnd.Row()+1 == 
rCxt.maRange.aStart.Row())
 {
 // Expand by the bottom edge.
 rRef.Ref2.IncRow(rCxt.mnRowDelta);
@@ -3748,8 +3759,11 @@ sc::RefUpdateResult ScTokenArray::AdjustReferenceInName(
 {
 // Check if we could expand range reference by the 
right
 // edge. For named expressions, we only expand 
absolute
-// references.
-if (!rRef.Ref1.IsColRel() && !rRef.Ref2.IsColRel() 
&& aAbs.aEnd.Col()+1 == rCxt.maRange.aStart.Col())
+// references. Reference must be at least two
+// columns wide.
+if (!rRef.Ref1.IsColRel() && !rRef.Ref2.IsColRel() 
&&
+aAbs.aStart.Col() < aAbs.aEnd.Col() &&
+aAbs.aEnd.Col()+1 == 
rCxt.maRange.aStart.Col())
 {
 // Expand by the right edge.
 rRef.Ref2.IncCol(rCxt.mnColDelta);

[Libreoffice-bugs] [Bug 89676] 4.4.x: Bundled templates are not localizable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89676

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl,
   ||philip...@hotmail.com,
   ||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3317
 Blocks||103314

--- Comment #2 from Yousuf Philips (jay)  ---
Hi Martin & Sophie,

Now that i'm currently working on updating the default templates for impress in
bug 103317, i'd like to see what can be done about the localization issues at
the same time.

>From what i can see, impress templates are localized, as the temporary textbox
texts like 'Click to add Title' and 'Click to add Text' are changed to the
localized equivalents when the template is opened. The only thing that isnt
localized seems to be the previews, as it shows up with localized text based on
the locale of the user who last saved the template file. So i see a few options
to deal with the preview.

1) Have the preview blank without text
2) Have a defined dummy text used for the title and context text (used in
iWork)
3) Use the template's english name as the title text (used in MSO)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103314
[Bug 103314] [META] Templates bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 103317] New default set of templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103317

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||676

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103314

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||89676


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89676
[Bug 89676] 4.4.x: Bundled templates are not localizable
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103317] New default set of templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103317

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||676

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90600] Working StarBasic macro fails after reloading the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90600

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, Data/Refresh is
disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs