[Libreoffice-bugs] [Bug 125440] textimport: copy & paste one row is different from multiple rows
https://bugs.documentfoundation.org/show_bug.cgi?id=125440 --- Comment #2 from Oliver Brinzing --- Created attachment 151585 --> https://bugs.documentfoundation.org/attachment.cgi?id=151585=edit one_row_paste -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125440] textimport: copy & paste one row is different from multiple rows
https://bugs.documentfoundation.org/show_bug.cgi?id=125440 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #1 from Oliver Brinzing --- Created attachment 151584 --> https://bugs.documentfoundation.org/attachment.cgi?id=151584=edit multiple_rows_textimport -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125440] New: textimport: copy & paste one row is different from multiple rows
https://bugs.documentfoundation.org/show_bug.cgi?id=125440 Bug ID: 125440 Summary: textimport: copy & paste one row is different from multiple rows Product: LibreOffice Version: 5.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: oliver.brinz...@gmx.de steps to reproduce: - open new spreadsheet - copy rows to clipboard: "Row1""" "" "50.000" "Row2""" "" "-50.000" - paste data into spreadsheet -> text Import dialog will open, make selection as shwon in attached screenshots -> data is pasted as values. do same with one row: -> no text Import Dialog appear, datais pasted as text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121784] FILEOPEN DOCX Footnote and endnote changes are not opened as change in change control
https://bugs.documentfoundation.org/show_bug.cgi?id=121784 László Németh changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from László Németh --- @all I plan to backport the fix in 6.2, too. Thanks for the report and the feedbacks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 Bug 109195 depends on bug 121784, which changed state. Bug 121784 Summary: FILEOPEN DOCX Footnote and endnote changes are not opened as change in change control https://bugs.documentfoundation.org/show_bug.cgi?id=121784 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=115709 Bug 115709 depends on bug 121784, which changed state. Bug 121784 Summary: FILEOPEN DOCX Footnote and endnote changes are not opened as change in change control https://bugs.documentfoundation.org/show_bug.cgi?id=121784 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121784] FILEOPEN DOCX Footnote and endnote changes are not opened as change in change control
https://bugs.documentfoundation.org/show_bug.cgi?id=121784 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121784] FILEOPEN DOCX Footnote and endnote changes are not opened as change in change control
https://bugs.documentfoundation.org/show_bug.cgi?id=121784 --- Comment #11 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/2d3a907973d04f0b8368a132d262e0318c4445dc%5E%21 tdf#121784 DOCX import: fix change tracking of footnotes It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf121784.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx| 17 +
writerfilter/source/dmapper/DomainMapper_Impl.cxx |5 -
3 files changed, 21 insertions(+), 1 deletion(-)
New commits:
commit 2d3a907973d04f0b8368a132d262e0318c4445dc
Author: László Németh
AuthorDate: Tue May 21 13:36:22 2019 +0200
Commit: László Németh
CommitDate: Wed May 22 07:39:40 2019 +0200
tdf#121784 DOCX import: fix change tracking of footnotes
and endnotes by creating redline data for their anchors, too.
Now footnote/endnote insertions are visible, and it's possible
to reject them.
Change-Id: I5cd3300c0d423b8c6803b7aeb848dcc103c3b565
Reviewed-on: https://gerrit.libreoffice.org/72680
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/qa/extras/ooxmlexport/data/tdf121784.docx
b/sw/qa/extras/ooxmlexport/data/tdf121784.docx
new file mode 100644
index ..30faeb2841b9
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf121784.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index b056ad16071d..b7d5132c47c2 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -306,6 +306,23 @@ DECLARE_OOXMLEXPORT_TEST(testTdf125298,
"tdf125298_crossreflink_nonascii_charlim
CPPUNIT_ASSERT_EQUAL(expectedFieldName2, fieldName2);
}
+DECLARE_OOXMLIMPORT_TEST(testTdf121784, "tdf121784.docx")
+{
+// check tracked insertion of footnotes
+CPPUNIT_ASSERT_EQUAL( OUString( "Text1" ), getParagraph( 1 )->getString());
+CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 1 ), 2
)->getString());
+CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(1), 2), "RedlineType"));
+
CPPUNIT_ASSERT_EQUAL(OUString("Insert"),getProperty(getRun(getParagraph(1),
2), "RedlineType"));
+CPPUNIT_ASSERT_EQUAL( OUString( "1" ), getRun( getParagraph( 1 ), 3
)->getString());
+
+// check tracked insertion of endnotes
+CPPUNIT_ASSERT_EQUAL( OUString( "texti" ), getParagraph( 2 )->getString());
+CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 2
)->getString());
+CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(2), 2), "RedlineType"));
+
CPPUNIT_ASSERT_EQUAL(OUString("Insert"),getProperty(getRun(getParagraph(2),
2), "RedlineType"));
+CPPUNIT_ASSERT_EQUAL( OUString( "i" ), getRun( getParagraph( 2 ), 3
)->getString());
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 772ff5bdf3c6..eb852bf943d4 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -2039,8 +2039,11 @@ void DomainMapper_Impl::PushFootOrEndnote( bool
bIsFootnote )
m_aTextAppendStack.push(TextAppendContext(uno::Reference<
text::XTextAppend >( xFootnoteText, uno::UNO_QUERY_THROW ),
xFootnoteText->createTextCursorByRange(xFootnoteText->getStart(;
-// Redlines for the footnote anchor
+// Redlines for the footnote anchor in the main text content
+std::vector< RedlineParamsPtr > aFootnoteRedline = m_aRedlines.top();
+m_aRedlines.pop();
CheckRedline( xFootnote->getAnchor( ) );
+m_aRedlines.push( aFootnoteRedline );
}
catch( const uno::Exception& )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1d6cc7d95261fc910dc99959c5a99119c5363b16 Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:27 2019 + Commit: Julien Nabet CommitDate: Wed May 22 07:30:27 2019 +0200 Fix typo Change-Id: I3bb52201d523fd1c97315c99ce58e4473f971a12 Reviewed-on: https://gerrit.libreoffice.org/72699 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx index 6b4b8da61b2e..dd151dd09383 100644 --- a/editeng/source/editeng/impedit2.cxx +++ b/editeng/source/editeng/impedit2.cxx @@ -895,7 +895,7 @@ EditSelection const & ImpEditEngine::MoveCursor( const KeyEvent& rKeyEvent, Edit CursorMoved( aOldPaM.GetNode() ); } -// May cause, an CreateAnchor or deselection all +// May cause, a CreateAnchor or deselection all aSelEngine.SetCurView( pEditView ); aSelEngine.CursorPosChanging( bKeyModifySelection, aTranslatedKeyEvent.GetKeyCode().IsMod1() ); EditPaM aOldEnd( pEditView->pImpEditView->GetEditSelection().Max() ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/items/bulitem.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 06c1ad874fc64947fb4d857ac33b589c663a7264
Author: Andrea Gelmini
AuthorDate: Tue May 14 21:25:25 2019 +
Commit: Julien Nabet
CommitDate: Wed May 22 07:29:45 2019 +0200
Fix typo
Change-Id: I8d0eb79c1848714c637d05064b6aae5140843c20
Reviewed-on: https://gerrit.libreoffice.org/72707
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/editeng/source/items/bulitem.cxx b/editeng/source/items/bulitem.cxx
index 97c6f76457db..9518cf4abbe9 100644
--- a/editeng/source/items/bulitem.cxx
+++ b/editeng/source/items/bulitem.cxx
@@ -89,7 +89,7 @@ bool SvxBulletItem::operator==( const SfxPoolItem& rItem )
const
{
DBG_ASSERT(dynamic_cast< const SvxBulletItem* >() !=
nullptr,"operator==Types not matching");
const SvxBulletItem& rBullet = static_cast(rItem);
-// Compare with ValidMask, otherwise no put possible in a AttrSet if the
+// Compare with ValidMask, otherwise no put possible in an AttrSet if the
// item differs only in terms of the ValidMask from an existing one.
if( nStyle != rBullet.nStyle||
nScale != rBullet.nScale||
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/misc/svxacorr.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 0f05795a3f0c211dc0be512f1f1b66e6019bd262
Author: Andrea Gelmini
AuthorDate: Tue May 14 21:25:24 2019 +
Commit: Julien Nabet
CommitDate: Wed May 22 07:27:21 2019 +0200
Fix typo
Change-Id: I88e2a10836ae961764d899b8d74fd707a3e15b2c
Reviewed-on: https://gerrit.libreoffice.org/72708
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 32c2dce2f9c6..01a4f27234fb 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -1444,8 +1444,8 @@ void SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc& rDoc,
const OUString& rTxt,
FnCorrectCapsLock( rDoc, rTxt, nCapLttrPos, nInsPos, eLang ) )
{
// Correct accidental use of cAPS LOCK key (do this only when
-// the caps or shift lock key is pressed). Turn off the caps
-// lock afterwords.
+// the caps or shift lock key is pressed). Turn off the caps
+// lock afterwards.
pFrameWin->SimulateKeyPress( KEY_CAPSLOCK );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/outliner/outliner.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b10af777ee7a1a879e6cab8314a1bc555c6ddba3 Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:23 2019 + Commit: Julien Nabet CommitDate: Wed May 22 07:25:33 2019 +0200 Fix typo Change-Id: I97909d9d6ece176f519318ebb53b4cdfeeba9146 Reviewed-on: https://gerrit.libreoffice.org/72709 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/editeng/source/outliner/outliner.cxx b/editeng/source/outliner/outliner.cxx index 13d371eba8b7..d015b9c97c03 100644 --- a/editeng/source/outliner/outliner.cxx +++ b/editeng/source/outliner/outliner.cxx @@ -1478,7 +1478,7 @@ void Outliner::StyleSheetChanged( SfxStyleSheet const * pStyle ) // The EditEngine calls StyleSheetChanged also for derived styles. // Here all the paragraphs, which had the said template, used to be -// hunted by a ImpRecalcParaAttribs, why? +// hunted by an ImpRecalcParaAttribs, why? // => only the Bullet-representation can really change... sal_Int32 nParas = pParaList->GetParagraphCount(); for( sal_Int32 nPara = 0; nPara < nParas; nPara++ ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: embeddedobj/source
embeddedobj/source/general/docholder.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 40556d4309195ed20ed9c0afa86a89723ba2b93b
Author: Andrea Gelmini
AuthorDate: Tue May 14 21:25:18 2019 +
Commit: Julien Nabet
CommitDate: Wed May 22 07:22:56 2019 +0200
Fix typo
Change-Id: I257313aa1744f8c70ea9888cd19adde149c1ce64
Reviewed-on: https://gerrit.libreoffice.org/72716
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/embeddedobj/source/general/docholder.cxx
b/embeddedobj/source/general/docholder.cxx
index 0c426d71e5e8..f7b1044fff12 100644
--- a/embeddedobj/source/general/docholder.cxx
+++ b/embeddedobj/source/general/docholder.cxx
@@ -960,7 +960,7 @@ bool DocumentHolder::LoadDocToFrame( bool bInPlace )
uno::Reference < frame::XModel > xDoc( m_xComponent, uno::UNO_QUERY );
if ( xDoc.is() )
{
-// load new document in to the frame
+// load new document into the frame
uno::Reference< frame::XComponentLoader > xComponentLoader(
m_xFrame, uno::UNO_QUERY_THROW );
::comphelper::NamedValueCollection aArgs;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit5.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0cdde7f044802c028a512960aa2fc8ccc3cb33ce Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:26 2019 + Commit: Julien Nabet CommitDate: Wed May 22 07:22:01 2019 +0200 Fix typo Change-Id: I09c624e4def7a0a3f0a753f9f325b4863dceac0e Reviewed-on: https://gerrit.libreoffice.org/72706 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/editeng/source/editeng/impedit5.cxx b/editeng/source/editeng/impedit5.cxx index d158d0f48a40..2a94e2c6dcf3 100644 --- a/editeng/source/editeng/impedit5.cxx +++ b/editeng/source/editeng/impedit5.cxx @@ -371,7 +371,7 @@ SfxItemSet ImpEditEngine::GetAttribs( EditSelection aSel, EditEngineAttribs nOnl // wrong in selection if invalidated // => better not invalidate, instead CHANGE! // It would be better to fill each paragraph with -// a itemset and compare this in large. +// an itemset and compare this in large. if ( nWhich <= EE_PARA_END ) aCurSet.InvalidateItem( nWhich ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123915] Font on Calc tabs not following Plasma Font DPI settings
https://bugs.documentfoundation.org/show_bug.cgi?id=123915 --- Comment #13 from Michael Weghorn --- Good to hear, thanks for the update! :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123549] the "close document" button is missing to return to welcome start window
https://bugs.documentfoundation.org/show_bug.cgi?id=123549 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0|target:6.3.0 target:6.2.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123549] the "close document" button is missing to return to welcome start window
https://bugs.documentfoundation.org/show_bug.cgi?id=123549 --- Comment #12 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/f10c1c648e698b48dfaa679a4909b3d9de6ed868%5E%21 tdf#123549 Qt5 implement Qt5Menu::ShowCloseButton It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Menu.hxx |2 +
vcl/inc/qt5/Qt5Tools.hxx |5 +++
vcl/qt5/Qt5Menu.cxx | 75 +--
vcl/qt5/Qt5Tools.cxx | 20
4 files changed, 81 insertions(+), 21 deletions(-)
New commits:
commit f10c1c648e698b48dfaa679a4909b3d9de6ed868
Author: Jan-Marek Glogowski
AuthorDate: Sat May 4 00:03:15 2019 +
Commit: Michael Weghorn
CommitDate: Wed May 22 07:15:00 2019 +0200
tdf#123549 Qt5 implement Qt5Menu::ShowCloseButton
This includes some not-so-nice lifetime handling of the button
"clicked" connection handling. I decided to keep the code in
one place, simply always forcing a disconnect on show, instead
of a more "optimized" code version in SetFrame.
First we try to get the icon from the system theme, but use LO's
own icon theme as a fallback.
Change-Id: Ic0459623ec907b9a54bef4670bf65cf587cd47ea
Reviewed-on: https://gerrit.libreoffice.org/71784
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 8ea988f585db72da88994d29d006f1976007789d)
Reviewed-on: https://gerrit.libreoffice.org/71931
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index 76563008a893..dfd6192e2c73 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -64,6 +64,7 @@ public:
virtual void SetAccelerator(unsigned nPos, SalMenuItem* pSalMenuItem,
const vcl::KeyCode& rKeyCode, const OUString&
rKeyName) override;
virtual void GetSystemMenuData(SystemMenuData* pData) override;
+virtual void ShowCloseButton(bool bShow) override;
void SetMenu(Menu* pMenu) { mpVCLMenu = pMenu; }
Menu* GetMenu() { return mpVCLMenu; }
@@ -77,6 +78,7 @@ private slots:
static void slotMenuTriggered(Qt5MenuItem* pQItem);
static void slotMenuAboutToShow(Qt5MenuItem* pQItem);
static void slotMenuAboutToHide(Qt5MenuItem* pQItem);
+void slotCloseDocument();
};
class Qt5MenuItem : public SalMenuItem
diff --git a/vcl/inc/qt5/Qt5Tools.hxx b/vcl/inc/qt5/Qt5Tools.hxx
index 8863e2496687..6b1fb1adcc7e 100644
--- a/vcl/inc/qt5/Qt5Tools.hxx
+++ b/vcl/inc/qt5/Qt5Tools.hxx
@@ -34,6 +34,9 @@
#include
+class Image;
+class QImage;
+
inline OUString toOUString(const QString& s)
{
// QString stores UTF16, just like OUString
@@ -136,4 +139,6 @@ typedef std::unique_ptr
UniqueCairoSurface;
sal_uInt16 GetKeyModCode(Qt::KeyboardModifiers eKeyModifiers);
sal_uInt16 GetMouseModCode(Qt::MouseButtons eButtons);
+QImage toQImage(const Image& rImage);
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 87b4ba4e457e..b27cdb825661 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -7,18 +7,21 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
-#include
-#include
#include
#include
-#include
+#include
+#include
+#include
+
+#include
+#include
#include
#include
-#include
-#include
+
+#include
+#include
Qt5Menu::Qt5Menu(bool bMenuBar)
: mpVCLMenu(nullptr)
@@ -419,6 +422,7 @@ void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar)
{
// clear action groups since menu is rebuilt
ResetAllActionGroups();
+ShowCloseButton(false);
for (sal_Int32 nItem = 0; nItem < static_cast(GetItemCount());
nItem++)
{
@@ -505,21 +509,7 @@ void Qt5Menu::SetItemImage(unsigned, SalMenuItem* pItem,
const Image& rImage)
if (!pAction)
return;
-QImage aImage;
-
-if (!!rImage)
-{
-SvMemoryStream aMemStm;
-vcl::PNGWriter aWriter(rImage.GetBitmapEx());
-aWriter.Write(aMemStm);
-
-if (!aImage.loadFromData(static_cast(aMemStm.GetData()),
aMemStm.TellEnd()))
-{
-return;
-}
-}
-
-pAction->setIcon(QPixmap::fromImage(aImage));
+pAction->setIcon(QPixmap::fromImage(toQImage(rImage)));
}
void Qt5Menu::SetAccelerator(unsigned, SalMenuItem* pItem, const vcl::KeyCode&,
@@ -605,6 +595,49 @@ void Qt5Menu::NativeItemText(OUString& rItemText)
rItemText = rItemText.replace('~', '&');
}
+void Qt5Menu::slotCloseDocument()
+{
+MenuBar* pVclMenuBar = static_cast(mpVCLMenu.get());
+if (pVclMenuBar)
+Application::PostUserEvent(pVclMenuBar->GetCloseButtonClickHdl());
+}
+
+void Qt5Menu::ShowCloseButton(bool bShow)
+{
+if (!mpQMenuBar)
+return;
+
+QPushButton* pButton =
static_cast(mpQMenuBar->cornerWidget(Qt::TopRightCorner));
+if (!pButton)
+{
+QIcon aIcon;
+if (QIcon::hasThemeIcon("window-close-symbolic"))
+aIcon = QIcon::fromTheme("window-close-symbolic");
+else
+aIcon = QIcon(
+QPixmap::fromImage((toQImage(Image(StockImage::Yes,
SV_RESID_BITMAP_CLOSEDOC);
+pButton = new QPushButton(mpQMenuBar);
+
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 123915, which changed state. Bug 123915 Summary: Font on Calc tabs not following Plasma Font DPI settings https://bugs.documentfoundation.org/show_bug.cgi?id=123915 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123915] Font on Calc tabs not following Plasma Font DPI settings
https://bugs.documentfoundation.org/show_bug.cgi?id=123915 Evert changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #12 from Evert --- Well it seems to work for me now, too. I did update my system in the meantime, so this may have been a bug in one of the sub systems. Thank you again for your patience. -Evert- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: embeddedobj/source
embeddedobj/source/commonembedding/embedobj.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 13e6b438869546db563df713108fc6e67a119417
Author: Andrea Gelmini
AuthorDate: Tue May 14 21:25:20 2019 +
Commit: Julien Nabet
CommitDate: Wed May 22 07:08:53 2019 +0200
Fix typo
Change-Id: Ibaafe29797523290f0fe17be7304c99a70752eda
Reviewed-on: https://gerrit.libreoffice.org/72712
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/embeddedobj/source/commonembedding/embedobj.cxx
b/embeddedobj/source/commonembedding/embedobj.cxx
index 98f6a3d11d2b..8c888df48a9e 100644
--- a/embeddedobj/source/commonembedding/embedobj.cxx
+++ b/embeddedobj/source/commonembedding/embedobj.cxx
@@ -653,7 +653,7 @@ void SAL_CALL OCommonEmbeddedObject::setParent( const
css::uno::Reference< css::
// XDefaultSizeTransmitter
void SAL_CALL OCommonEmbeddedObject::setDefaultSize( const css::awt::Size&
rSize_100TH_MM )
{
-//#i103460# charts do not necessaryly have an own size within ODF files,
in this case they need to use the size settings from the surrounding frame,
which is made available with this method
+//#i103460# charts do not necessarily have an own size within ODF files,
in this case they need to use the size settings from the surrounding frame,
which is made available with this method
m_aDefaultSizeForChart_In_100TH_MM = rSize_100TH_MM;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/uno/unofored.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 351cffbbea58868982032ed0cab970838f6d5802 Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:21 2019 + Commit: Julien Nabet CommitDate: Wed May 22 07:09:23 2019 +0200 Fix typo Change-Id: Ib28c9a3df6b6d6b6f65e2c9b0810655b963eb1ff Reviewed-on: https://gerrit.libreoffice.org/72711 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/editeng/source/uno/unofored.cxx b/editeng/source/uno/unofored.cxx index 889b7b7b4420..47a8accb4cca 100644 --- a/editeng/source/uno/unofored.cxx +++ b/editeng/source/uno/unofored.cxx @@ -190,7 +190,7 @@ SfxItemState GetSvxEditEngineItemState( EditEngine const & rEditEngine, const ES rEditEngine.GetCharAttribs( nPara, aAttribs ); bool bEmpty = true; // we found no item inside the selection of this paragraph -bool bGaps = false;// we found items but theire gaps between them +bool bGaps = false;// we found items but there are gaps between them sal_Int32 nLastEnd = nPos; const SfxPoolItem* pParaItem = nullptr; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: embeddedobj/source
embeddedobj/source/inc/commonembobj.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit f545ee280053f8b7804e748bd41fe0cbb1cc07d9 Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:17 2019 + Commit: Julien Nabet CommitDate: Wed May 22 07:08:25 2019 +0200 Fix typo Change-Id: I627d0d9899226eb39a19bde1ecf79f04ca26e633 Reviewed-on: https://gerrit.libreoffice.org/72717 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/embeddedobj/source/inc/commonembobj.hxx b/embeddedobj/source/inc/commonembobj.hxx index 868bcc296631..c00fbdc096be 100644 --- a/embeddedobj/source/inc/commonembobj.hxx +++ b/embeddedobj/source/inc/commonembobj.hxx @@ -156,7 +156,7 @@ protected: bool m_bHasClonedSize; // the object has cached size css::awt::Size m_aClonedSize; sal_Int32 m_nClonedMapUnit; -css::awt::Size m_aDefaultSizeForChart_In_100TH_MM;//#i103460# charts do not necessaryly have an own size within ODF files, in this case they need to use the size settings from the surrounding frame, which is made available with this member +css::awt::Size m_aDefaultSizeForChart_In_100TH_MM;//#i103460# charts do not necessarily have an own size within ODF files, in this case they need to use the size settings from the surrounding frame, which is made available with this member private: void CommonInit_Impl( const css::uno::Sequence< css::beans::NamedValue >& aObjectProps ); @@ -396,7 +396,7 @@ public: virtual void SAL_CALL setParent( const css::uno::Reference< css::uno::XInterface >& Parent ) override; // XDefaultSizeTransmitter -//#i103460# charts do not necessaryly have an own size within ODF files, in this case they need to use the size settings from the surrounding frame, which is made available with this method +//#i103460# charts do not necessarily have an own size within ODF files, in this case they need to use the size settings from the surrounding frame, which is made available with this method virtual void SAL_CALL setDefaultSize( const css::awt::Size& rSize_100TH_MM ) override; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: embeddedobj/source
embeddedobj/source/commonembedding/persistence.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 73e58a91bcae4238cf44b1c927fec2f993022a6d Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:19 2019 + Commit: Julien Nabet CommitDate: Wed May 22 07:07:46 2019 +0200 Fix typo Change-Id: I69c3a6b6ca8d5a568ec7f052c742335dd50bda5b Reviewed-on: https://gerrit.libreoffice.org/72714 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/embeddedobj/source/commonembedding/persistence.cxx b/embeddedobj/source/commonembedding/persistence.cxx index aae1180f8d8b..b0decc28bd6a 100644 --- a/embeddedobj/source/commonembedding/persistence.cxx +++ b/embeddedobj/source/commonembedding/persistence.cxx @@ -1399,7 +1399,7 @@ void SAL_CALL OCommonEmbeddedObject::storeAsEntry( const uno::Reference< embed:: m_aNewEntryName = sEntName; m_aNewDocMediaDescriptor = GetValuableArgs_Impl( lArguments, true ); -// TODO: register listeners for storages above, in case thay are disposed +// TODO: register listeners for storages above, in case they are disposed // an exception will be thrown on saveCompleted( true ) // TODO: should the listener notification be done here or in saveCompleted? ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120556] Password protected sheets in Calc cause crashes annd the same when uses autocorrection (eg. :?:)
https://bugs.documentfoundation.org/show_bug.cgi?id=120556 raal changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103303] [META] Desktop integration bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103303 Mike Kaganski changed: What|Removed |Added Depends on||52078 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=52078 [Bug 52078] shlxthdl_x64.dll/shlxthdl.dll causes Windows Explorer to CRASH repeatedly when Flat ODF file is in view -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124572] tabs in calc (for sheets) and draw (for layer) style
https://bugs.documentfoundation.org/show_bug.cgi?id=124572 --- Comment #27 from Tomaz Vajngerl --- Hi, this is not the final version yet, so the size of the tabs will be minimized, when the protected icon is taken into account at calculation of tab size. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125404] Request for new sinitic languages
https://bugs.documentfoundation.org/show_bug.cgi?id=125404 趙惟倫 changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from 趙惟倫 --- https://en.wikipedia.org/wiki/ISO_639_macrolanguage IMHO, "zh" is not a proper language name, which should be broken into various sinitic languages, though it's almost impossible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125398] Shadow shows on inserted images in doc/pdf files
https://bugs.documentfoundation.org/show_bug.cgi?id=125398 griffi...@gmail.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from griffi...@gmail.com --- I am using Windows 10 - I don't know how to provide foo/bar - I have a .docx document which shows the problem but it keeps asking for foo/bar instead. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89709] TOOLTIP: Page number tooltip doesnt appear in document with a single page
https://bugs.documentfoundation.org/show_bug.cgi?id=89709 Jim Raykowski changed: What|Removed |Added CC||rayk...@gmail.com Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #6 from Jim Raykowski --- Here is a patch for this - https://gerrit.libreoffice.org/#/c/72715/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125348] autocorrect replacement table default width is increased by long autocorrect entries and you can't resize it
https://bugs.documentfoundation.org/show_bug.cgi?id=125348 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124236] EDITING: Cannot correct an incorrect hyphenation point
https://bugs.documentfoundation.org/show_bug.cgi?id=124236 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124905] iPad Hardware-Keyboard in iOS App
https://bugs.documentfoundation.org/show_bug.cgi?id=124905 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118856] Text blinking when highlighting text in about us windows
https://bugs.documentfoundation.org/show_bug.cgi?id=118856 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125404] Request for new sinitic languages
https://bugs.documentfoundation.org/show_bug.cgi?id=125404 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123568] Right click menu changes to word correction menu nearby word marked by spell checker
https://bugs.documentfoundation.org/show_bug.cgi?id=123568 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124364] Inserting a diagram leads to an error
https://bugs.documentfoundation.org/show_bug.cgi?id=124364 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123862] File locking has no benefits at all
https://bugs.documentfoundation.org/show_bug.cgi?id=123862 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122916] [EDITING] the cursor is not on the line but jump forward + [maiusc+F3] doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=122916 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125147] Digital Signatures for DOCX files
https://bugs.documentfoundation.org/show_bug.cgi?id=125147 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120940] typing a hyphen creates strike-through of previous sentence
https://bugs.documentfoundation.org/show_bug.cgi?id=120940 --- Comment #4 from QA Administrators --- Dear Shawn, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125345] LibreOffice Impress Slideshow failure
https://bugs.documentfoundation.org/show_bug.cgi?id=125345 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120519] Printing bug with imported data from other datasheet
https://bugs.documentfoundation.org/show_bug.cgi?id=120519 --- Comment #4 from QA Administrators --- Dear assamite4ever, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125345] LibreOffice Impress Slideshow failure
https://bugs.documentfoundation.org/show_bug.cgi?id=125345 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121622] LibreOffice V5.4.6.2 crashes when requesting "Check for Updates"
https://bugs.documentfoundation.org/show_bug.cgi?id=121622 --- Comment #2 from QA Administrators --- Dear Budd, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124364] Inserting a diagram leads to an error
https://bugs.documentfoundation.org/show_bug.cgi?id=124364 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120419] Printing Envelope Canon MX 922
https://bugs.documentfoundation.org/show_bug.cgi?id=120419 --- Comment #3 from QA Administrators --- Dear Joe F, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36799] If you insert an envelope into a document only the envelope is printed (Mac OS X)
https://bugs.documentfoundation.org/show_bug.cgi?id=36799 --- Comment #36 from QA Administrators --- Dear Fred, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121602] Writer acts like it is auto-saving my work, and then crashes.
https://bugs.documentfoundation.org/show_bug.cgi?id=121602 --- Comment #2 from QA Administrators --- Dear loveneedstruth, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96506] The "Use Styles From Another Document" feature doesn't work if the other document is a .fodt one
https://bugs.documentfoundation.org/show_bug.cgi?id=96506 --- Comment #6 from QA Administrators --- Dear Ganton, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121603] I cannot save the settings of my "view" in writer from one session to another.
https://bugs.documentfoundation.org/show_bug.cgi?id=121603 --- Comment #2 from QA Administrators --- Dear loveneedstruth, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106468] editing viewing fileopen unable to open edit or view older wordperfect documents
https://bugs.documentfoundation.org/show_bug.cgi?id=106468 --- Comment #6 from QA Administrators --- Dear sandhillsinvestment, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103388] UI: "View > Show Formula" shows the shortcut as "Ctrl+grave"
https://bugs.documentfoundation.org/show_bug.cgi?id=103388 --- Comment #14 from QA Administrators --- Dear brucehohl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63642] Math formula looses custom font settings on save as Flat XML
https://bugs.documentfoundation.org/show_bug.cgi?id=63642 --- Comment #20 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83581] caret does not enter ligature; easy to insert at wrong place
https://bugs.documentfoundation.org/show_bug.cgi?id=83581 --- Comment #14 from QA Administrators --- Dear dE, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113811] FILESAVE: dialogs are not preserved in flat ODS file
https://bugs.documentfoundation.org/show_bug.cgi?id=113811 --- Comment #9 from QA Administrators --- Dear Mátyás Jani, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117365] Decimal separator is not updated on language change
https://bugs.documentfoundation.org/show_bug.cgi?id=117365 --- Comment #9 from QA Administrators --- Dear Heiko Tietze, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92210] Flat XML files without XML declaration cannot be opened
https://bugs.documentfoundation.org/show_bug.cgi?id=92210 --- Comment #5 from QA Administrators --- Dear Urmas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77007] FILEOPEN: User asked to save changes upon exit from unmodified XLS file (possibly because of particular chart)
https://bugs.documentfoundation.org/show_bug.cgi?id=77007 --- Comment #14 from QA Administrators --- Dear larin, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106552] Commandline convert DOCX to fodt or odt, wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=106552 --- Comment #5 from QA Administrators --- Dear Jan Idzikowski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112075] Problems with element in flat ODF
https://bugs.documentfoundation.org/show_bug.cgi?id=112075 --- Comment #3 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55969] BASIC: API methods for select-protected-cells
https://bugs.documentfoundation.org/show_bug.cgi?id=55969 --- Comment #9 from QA Administrators --- Dear pierre-yves samyn, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76900] FILESAVE: Flat XML format broken. Formula size not preserved in roundtrip.
https://bugs.documentfoundation.org/show_bug.cgi?id=76900 --- Comment #15 from QA Administrators --- Dear sergio.callegari, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120809] Undo/Redo buffer should record input until next punctuation mark
https://bugs.documentfoundation.org/show_bug.cgi?id=120809 --- Comment #11 from Leandro Martín Drudi --- Sorry for bothering. I would like to know if there is anything new about this. The possibility of using "cut" is not useful because if you add text in between something already written, undoing is the best option to restore the original version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120556] Password protected sheets in Calc cause crashes annd the same when uses autocorrection (eg. :?:)
https://bugs.documentfoundation.org/show_bug.cgi?id=120556 Leandro Martín Drudi changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #18 from Leandro Martín Drudi --- It seems that the problem was solved throughout the new versions. So it could be said that it is solved. I downloaded the shared file that caused problems and opened it without any problems. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125439] New: Ask if you want to install a recently installed extension
https://bugs.documentfoundation.org/show_bug.cgi?id=125439 Bug ID: 125439 Summary: Ask if you want to install a recently installed extension Product: LibreOffice Version: 6.2.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sanipache...@outlook.com.ar Description: After installing any extension, it offers to restart LibreOffice, after which it asks again if you want to install the same extension. Steps to Reproduce: 1. Install any extension. 2. Close Extension Manager. 3. Ask if you want to restart LibreOffice now or later. 4. Click in NOW button. 5. LibreOffice restarts. 6. LibreOffice is automatically opened. 7. Extension Manager is automatically opened. 8. EM asks for install the extension installed in step 1. Actual Results: Ask for reinstall extension installed. Expected Results: Open LibreOffice and start to work. Reproducible: Always User Profile Reset: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125438] Extension updates to another instead of installing
https://bugs.documentfoundation.org/show_bug.cgi?id=125438 --- Comment #1 from Leandro Martín Drudi --- Created attachment 151583 --> https://bugs.documentfoundation.org/attachment.cgi?id=151583=edit Update previous version (when in fact they are two different extensions) The installed extension (LMD Color Palettes version 2019.05.21 R1 Anniversary) is an extension for personal use, stored locally on my computer. The extension to install (LMD Color of the year (2019) version 2018.12.06) is one downloaded from the web extensions and both are of my creation. Anyway, the same happens with both extensions uploaded to the web. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116460] The current page number isn't updated when scrolling with page up/down or arrow until after release
https://bugs.documentfoundation.org/show_bug.cgi?id=116460 Jim Raykowski changed: What|Removed |Added CC||rayk...@gmail.com Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125438] New: Extension updates to another instead of installing
https://bugs.documentfoundation.org/show_bug.cgi?id=125438 Bug ID: 125438 Summary: Extension updates to another instead of installing Product: LibreOffice Version: 6.2.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sanipache...@outlook.com.ar Description: [ES] Dos extensiones diferentes creadas por mí para la instalación de paletas de colores se actualizan aún cuando son dos paletas totalmente diferentes e independientes. [EN] Two different extensions created by me for the installation of color palettes are updated even though they are two totally different and independent palettes. Steps to Reproduce: 1. Download LMD Malva de Perkin (Color palette) (https://extensions.libreoffice.org/extensions/malva-de-pekin-color-palette) 2. Install with double click. 3. Download LMD Color of the Year (Color Pallette) (https://extensions.libreoffice.org/extensions/lmd-color-of-the-year-color-pallette) 4. Double click to install Actual Results: The new extension tries to update to the one that is already installed. Expected Results: Both extensions are installed independently of the one that is already installed. Reproducible: Sometimes User Profile Reset: Yes Additional Info: Both extensions are from my creation and this happens with the extensions created by me to install different color palettes (extensions published or not in https://extensions.libreoffice.org/). It does not happen if the palette belongs to another author. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116460] The current page number isn't updated when scrolling with page up/down or arrow until after release
https://bugs.documentfoundation.org/show_bug.cgi?id=116460 --- Comment #6 from Jim Raykowski --- Hi all, a patch for this is here: https://gerrit.libreoffice.org/#/c/72713/ For me, testing with SAL_USE_VCLPLUGIN gtk2 and gtk3, page up/down continue action and do not update the page number in the statusbar after released when held down for longer than a single action key press. SAL_USE_VCLPLUGIN=gen behavior does not continue page up/down action after released. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - net/Socket.cpp net/Socket.hpp test/Makefile.am test/UnitHTTP.cpp wsd/DocumentBroker.cpp
net/Socket.cpp |9
net/Socket.hpp |4 ++
test/Makefile.am |6 ++-
test/UnitHTTP.cpp | 97 +
wsd/DocumentBroker.cpp | 13 --
5 files changed, 122 insertions(+), 7 deletions(-)
New commits:
commit 83d687825dbe9212397a09547838eaf89058caad
Author: Michael Meeks
AuthorDate: Wed May 22 02:38:39 2019 +0100
Commit: Michael Meeks
CommitDate: Wed May 22 02:56:11 2019 +0100
Avoid exceptions in some shutdown corner cases.
Change-Id: I1c301dc96d925fd5d74c00bf4b9417782822a997
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 698f3dd98..eb8fb1eee 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1915,11 +1915,14 @@ void ConvertToBroker::removeFile(const std::string
)
{
if (!uriOrig.empty())
{
-// Remove source file and directory
-Poco::Path path = uriOrig;
-Poco::File(path).remove();
-Poco::File(path.makeParent()).remove();
-FileUtil::removeFile(uriOrig);
+try {
+// Remove source file and directory
+Poco::Path path = uriOrig;
+Poco::File(path).remove();
+Poco::File(path.makeParent()).remove();
+} catch (const std::exception ) {
+LOG_ERR("Error while removing conversion temporary: '" << uriOrig
<< "' - " << ex.what());
+}
}
}
commit 4f804a48fe743ac37ee45b8a4c323cad072cdb5e
Author: Michael Meeks
AuthorDate: Wed May 22 02:54:12 2019 +0100
Commit: Michael Meeks
CommitDate: Wed May 22 02:56:11 2019 +0100
Initial HTTP Expect: 100-continue implementation.
Change-Id: Ic9aa59cac5103151d91f6eb59d12313e545c7916
diff --git a/net/Socket.cpp b/net/Socket.cpp
index c1225877a..ba72e16c1 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -681,6 +681,15 @@ bool StreamSocket::parseHeader(const char *clientName,
LOG_DBG("Not enough content yet: ContentLength: " << contentLength
<< ", available: " << available);
return false;
}
+
+if (request.getExpectContinue() && !_sentHTTPContinue)
+{
+LOG_TRC("#" << getFD() << " got Expect: 100-continue, sending
Continue");
+// FIXME: should validate authentication headers early too.
+send("HTTP/1.1 100 Continue\r\n\r\n",
+ sizeof("HTTP/1.1 100 Continue\r\n\r\n") - 1);
+_sentHTTPContinue = true;
+}
}
catch (const Poco::Exception& exc)
{
diff --git a/net/Socket.hpp b/net/Socket.hpp
index 0764df159..5995570dc 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -801,6 +801,7 @@ public:
_bytesRecvd(0),
_wsState(WSState::HTTP),
_closed(false),
+_sentHTTPContinue(false),
_shutdownSignalled(false)
{
LOG_DBG("StreamSocket ctor #" << fd);
@@ -1154,6 +1155,9 @@ protected:
/// True if we are already closed.
bool _closed;
+/// True if we've received a Continue in response to an Expect:
100-continue
+bool _sentHTTPContinue;
+
/// True when shutdown was requested via shutdown().
bool _shutdownSignalled;
};
diff --git a/test/Makefile.am b/test/Makefile.am
index 0432955ae..eed2abd5d 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -17,7 +17,7 @@ noinst_LTLIBRARIES = \
unit-timeout.la unit-prefork.la \
unit-storage.la unit-client.la \
unit-admin.la unit-tilecache.la \
- unit-fuzz.la unit-oob.la unit-oauth.la \
+ unit-fuzz.la unit-oob.la unit-http.la unit-oauth.la \
unit-wopi.la unit-wopi-saveas.la \
unit-wopi-ownertermination.la unit-wopi-versionrestore.la \
unit-wopi-documentconflict.la unit_wopi_renamefile.la
@@ -86,6 +86,7 @@ fakesockettest_LDADD = $(CPPUNIT_LIBS)
# unit test modules:
unit_oob_la_SOURCES = UnitOOB.cpp
+unit_http_la_SOURCES = UnitHTTP.cpp
unit_fuzz_la_SOURCES = UnitFuzz.cpp
unit_admin_la_SOURCES = UnitAdmin.cpp
unit_admin_la_LIBADD = $(CPPUNIT_LIBS)
@@ -130,7 +131,8 @@ check-local:
TESTS = unit-typing.la unit-convert.la unit-prefork.la unit-tilecache.la \
unit-timeout.la unit-oauth.la unit-wopi.la unit-wopi-saveas.la \
unit-wopi-ownertermination.la unit-wopi-versionrestore.la \
-unit-wopi-documentconflict.la unit_wopi_renamefile.la
+unit-wopi-documentconflict.la unit_wopi_renamefile.la \
+ unit-http.la
# TESTS = unit-client.la
# TESTS += unit-admin.la
# TESTS += unit-storage.la
diff --git a/test/UnitHTTP.cpp b/test/UnitHTTP.cpp
new file mode 100644
index 0..d0530fe10
--- /dev/null
+++ b/test/UnitHTTP.cpp
@@ -0,0 +1,97 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ *
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57b' - instsetoo_native/inc_openoffice scp2/source
instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt |1 +
instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt |2 +-
instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt |1 +
scp2/source/ooo/ucrt.scp |4 ++--
4 files changed, 5 insertions(+), 3 deletions(-)
New commits:
commit c8e3da67f457a268a888a4764d0bd3606347ab2f
Author: Mike Kaganski
AuthorDate: Mon Dec 17 00:23:24 2018 +0300
Commit: Thorsten Behrens
CommitDate: Wed May 22 03:08:55 2019 +0200
tdf#122134: use CurrentMajorVersionNumber to filter out Windows 10
On Windows 8.1, the one that is problematic to tell from Windows 10
(because the latter also exposes its version as 603 to the msiexec),
the registry value doesn't exist at
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion
but let's play safe and also check for "#6" value just in case.
Reference:
https://stackoverflow.com/questions/31072543/reliable-way-to-get-windows-version-from-registry
Thanks to Mitchell for the idea!
Reviewed-on: https://gerrit.libreoffice.org/65231
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
(cherry picked from commit d87fa557ff58c3b9f5c9079a1d7595e095694111)
Reviewed-on: https://gerrit.libreoffice.org/65242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit 72f2fbc75dc254ea8e13527b592bd0b4fb946bab)
Conflicts:
instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
Change-Id: Ic907c4d992a7cb1d12e392686c19cd6fd6da3c7c
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
b/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
index 3968375a8815..4bc5b05f6d9a 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/AppSearc.idt
@@ -5,3 +5,4 @@ INSTALLLOCATION installuser
INSTALLLOCATIONinstalluser_
INSTALLLOCATIONinstallmachine
INSTALLLOCATIONinstallmachine_
+WINMAJORVERWinMajorVer
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
index 44fb9f500387..b3eaa2342d9f 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
@@ -42,7 +42,7 @@ ProgressType3 installs
Quickstarterlinkname QUICKSTARTERLINKNAMETEMPLATE
RebootYesNoYes
ReinstallModeText omus
-SecureCustomProperties NEWPRODUCTS;OLDPRODUCTS;WIN81S14
+SecureCustomProperties NEWPRODUCTS;OLDPRODUCTS;WIN81S14;WINMAJORVER
SetupType Typical
SELECT_WORD0
SELECT_EXCEL 0
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
b/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
index c082322086ad..7788815d3a6e 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/RegLocat.idt
@@ -5,3 +5,4 @@ installuser 1
Software\LibreOffice\Layers\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION]
installuser_ 1
Software\LibreOffice\Layers_\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION]
INSTALLLOCATION 2
installmachine 2
Software\LibreOffice\Layers\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION]
INSTALLLOCATION 2
installmachine_2
Software\LibreOffice\Layers_\[DEFINEDPRODUCT]\[BRANDPACKAGEVERSION]
INSTALLLOCATION 2
+WinMajorVer2 Software\Microsoft\Windows NT\CurrentVersion
CurrentMajorVersionNumber 2
diff --git a/scp2/source/ooo/ucrt.scp b/scp2/source/ooo/ucrt.scp
index ae2eb27a4dbe..a2d6965e2ecb 100644
--- a/scp2/source/ooo/ucrt.scp
+++ b/scp2/source/ooo/ucrt.scp
@@ -111,7 +111,7 @@ WindowsCustomAction gid_Customaction_check_win81x64_ucrt
Source = "InstMSUBinary";
Target = "Windows81-KB2999226-x64msu";
Inbinarytable = 0;
- Assignment1 = ("InstallExecuteSequence", "Not Installed And VersionNT =
603 And VersionNT64", "check_win8x64_ucrt");
+ Assignment1 = ("InstallExecuteSequence", "Not Installed And VersionNT =
603 And (Not WINMAJORVER Or WINMAJORVER = \"#6\") And VersionNT64",
"check_win8x64_ucrt");
Styles = "NO_FILE";
End
@@ -147,7 +147,7 @@ WindowsCustomAction gid_Customaction_check_win81x32_ucrt
Source = "InstMSUBinary";
Target = "Windows81-KB2999226-x86msu";
Inbinarytable = 0;
- Assignment1 = ("InstallExecuteSequence", "Not Installed And VersionNT =
603 And Not VersionNT64", "check_win8x32_ucrt");
+ Assignment1 = ("InstallExecuteSequence", "Not Installed And VersionNT =
603 And (Not WINMAJORVER Or WINMAJORVER = \"#6\") And Not VersionNT64",
"check_win8x32_ucrt");
Styles = "NO_FILE";
End
Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0
We are still using libgpg-error v1.27 but the latest version on their download page is 1.36. Can we update this tarball so that new LODE installs can work again? https://gnupg.org/download/index.html#libgpg-error -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/LOOLWSD.cpp
wsd/DocumentBroker.cpp | 11 ---
wsd/DocumentBroker.hpp |3 +++
wsd/LOOLWSD.cpp|9 +
3 files changed, 20 insertions(+), 3 deletions(-)
New commits:
commit 1845ed42af661dbb7b10a2fb4686ce2c8ef7e521
Author: Michael Meeks
AuthorDate: Tue May 21 19:50:17 2019 +0100
Commit: Michael Meeks
CommitDate: Wed May 22 01:57:48 2019 +0200
tdf#123482 - cleanup convert-to folder even more reliably.
Problems could occur if exceptiosn thrown when parsing the input stream.
Change-Id: Id82b3816450194164fc2093554c730b4a94acef1
Reviewed-on: https://gerrit.libreoffice.org/72695
Reviewed-by: Michael Meeks
Tested-by: Michael Meeks
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 6779473a4..698f3dd98 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1908,13 +1908,18 @@ ConvertToBroker::ConvertToBroker(const std::string& uri,
ConvertToBroker::~ConvertToBroker()
{
NumConverters--;
-if (!_uriOrig.empty())
+removeFile(_uriOrig);
+}
+
+void ConvertToBroker::removeFile(const std::string )
+{
+if (!uriOrig.empty())
{
// Remove source file and directory
-Poco::Path path = _uriOrig;
+Poco::Path path = uriOrig;
Poco::File(path).remove();
Poco::File(path.makeParent()).remove();
-FileUtil::removeFile(_uriOrig);
+FileUtil::removeFile(uriOrig);
}
}
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 0642599c2..c56ced733 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -481,6 +481,9 @@ public:
/// How many live conversions are running.
static size_t getInstanceCount();
+
+/// Cleanup path and its parent
+static void removeFile(const std::string );
};
#endif
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 69e74114a..25877811a 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -572,6 +572,9 @@ class ConvertToPartHandler : public PartHandler
public:
std::string getFilename() const { return _filename; }
+/// Afterwards someone else is responsible for cleaning that up.
+void takeFile() { _filename.clear(); }
+
ConvertToPartHandler(bool convertTo = false)
: _convertTo(convertTo)
{
@@ -579,6 +582,11 @@ public:
virtual ~ConvertToPartHandler()
{
+if (!_filename.empty())
+{
+LOG_TRC("Remove un-handled temporary file '" << _filename << "'");
+ConvertToBroker::removeFile(_filename);
+}
}
virtual void handlePart(const MessageHeader& header, std::istream& stream)
override
@@ -2377,6 +2385,7 @@ private:
LOG_DBG("New DocumentBroker for docKey [" << docKey <<
"].");
auto docBroker =
std::make_shared(fromPath, uriPublic, docKey);
+handler.takeFile();
cleanupDocBrokers();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/quartz
vcl/inc/quartz/CGHelpers.hxx | 36 +
vcl/quartz/salgdicommon.cxx | 37 ++
vcl/quartz/salgdiutils.cxx | 112 +++
3 files changed, 124 insertions(+), 61 deletions(-)
New commits:
commit 959e8ae7ea33ce94dd80ee8ea172b6db64593873
Author: Tomaž Vajngerl
AuthorDate: Tue May 21 14:46:56 2019 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed May 22 01:33:59 2019 +0200
tdf#124271 use the bitmap context, handle scaling
The problem with latest macOS versions is that creating a graphic
context with window (NSGraphicsContext graphicsContextWithWindow:)
only works when actually drawing and otherwise it returns null.
This caused problems before in AquaVrtualDevice, but we also use
this when creating a device backing storage. This interestingly
caused slowdowns and eventual crash, but the backtrace looked
very misterious as it didn't crash because of a nullptr, but
it halted all drawing commands and it crashed because of that.
This changes the graphic context with a bitmap context, as it
was already done in VirtualDevice and use that instead. The
problem with a bitmap context is that we need to handle HiDPI
scaling by ourselves now.
LayerHolder was extended to store the scaling information of the
layer (and its underlaying bitmap context) and provides methods
that get the size of the layer in pixels or in scaling independent
points (which is just size in pixels multiplied by the scaling
factor).
An known issue is that VirtualDevice also needs to take scaling
into account, which it currently doesn't, so the text is still
blurry on a HiDPI screen, but that was already true previously
and is something that will be done in a different change.
Change-Id: I8e10c518ecba285125746bd20525c4cb5ca67279
Reviewed-on: https://gerrit.libreoffice.org/72663
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/inc/quartz/CGHelpers.hxx b/vcl/inc/quartz/CGHelpers.hxx
index f2d024dc9299..5d44e835d99b 100644
--- a/vcl/inc/quartz/CGHelpers.hxx
+++ b/vcl/inc/quartz/CGHelpers.hxx
@@ -22,22 +22,56 @@ class CGLayerHolder
private:
CGLayerRef mpLayer;
+// Layer's scaling factor
+float mfScale;
+
public:
CGLayerHolder()
: mpLayer(nullptr)
+, mfScale(1.0)
{
}
-CGLayerHolder(CGLayerRef pLayer)
+CGLayerHolder(CGLayerRef pLayer, float fScale = 1.0)
: mpLayer(pLayer)
+, mfScale(fScale)
{
}
+// Just the size of the layer in pixels
+CGSize getSizePixels() const
+{
+CGSize aSize;
+if (mpLayer)
+{
+aSize = CGLayerGetSize(mpLayer);
+SAL_INFO("vcl.cg", "CGLayerGetSize(" << mpLayer << ") = " <<
aSize);
+}
+return aSize;
+}
+
+// Size in points is size in pixels multiplied by the scaling factor
+CGSize getSizePoints() const
+{
+CGSize aSize;
+if (mpLayer)
+{
+const CGSize aLayerSize = getSizePixels();
+aSize.width = aLayerSize.width / mfScale;
+aSize.height = aLayerSize.height / mfScale;
+}
+return aSize;
+}
+
CGLayerRef get() const { return mpLayer; }
bool isSet() const { return mpLayer != nullptr; }
void set(CGLayerRef const& pLayer) { mpLayer = pLayer; }
+
+float getScale() { return mfScale; }
+
+void setScale(float fScale) { mfScale = fScale; }
};
class CGContextHolder
diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index dd35917cd949..05e84b98b810 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -483,48 +483,67 @@ void AquaSalGraphics::copyArea( long nDstX, long
nDstY,long nSrcX, long nSrcY,
if (!maLayer.isSet())
return;
#endif
+float fScale = maLayer.getScale();
+
+long nScaledSourceX = nSrcX * fScale;
+long nScaledSourceY = nSrcY * fScale;
+
+long nScaledTargetX = nDstX * fScale;
+long nScaledTargetY = nDstY * fScale;
+
+long nScaledSourceWidth = nSrcWidth * fScale;
+long nScaledSourceHeight = nSrcHeight * fScale;
ApplyXorContext();
+maContextHolder.saveState();
+
// in XOR mode the drawing context is redirected to the XOR mask
// copyArea() always works on the target context though
CGContextRef xCopyContext = maContextHolder.get();
+
if( mpXorEmulation && mpXorEmulation->IsEnabled() )
{
xCopyContext = mpXorEmulation->GetTargetContext();
}
+
+// If we have a scaled layer, we need to revert the scaling or else
+// it will interfere with the coordinate calculation
+CGContextScaleCTM(xCopyContext, 1.0 / fScale, 1.0 / fScale);
+
// drawing a layer onto its own context causes trouble on OSX => copy it
first
// TODO: is it possible to get rid of this unneeded copy more often?
//
[Libreoffice-bugs] [Bug 124271] Provide releases built with XCode 10
https://bugs.documentfoundation.org/show_bug.cgi?id=124271 --- Comment #4 from Commit Notification --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/959e8ae7ea33ce94dd80ee8ea172b6db64593873%5E%21 tdf#124271 use the bitmap context, handle scaling It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124271] Provide releases built with XCode 10
https://bugs.documentfoundation.org/show_bug.cgi?id=124271 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/FileDefinitionWidgetDraw.cxx |8 +---
vcl/source/gdi/WidgetDefinitionReader.cxx |6 ++
2 files changed, 11 insertions(+), 3 deletions(-)
New commits:
commit 3b67ad5f11714d6bea83ec8511f7723dbd999c56
Author: Tomaž Vajngerl
AuthorDate: Mon May 20 21:41:03 2019 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed May 22 01:33:19 2019 +0200
widgettheme: support multiple spinbox orientations
This adds the ability to define the spinbox orientation that has
decrease and increase buttons on the right side and can be changed
by adding "orientation="edit-decrease-increase" to the Spinbox
"Entire" part in the widget definition.
Change-Id: I3601a987a4abb8d998e9cd2d8973d794d3d66f9b
Reviewed-on: https://gerrit.libreoffice.org/72662
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index e5dc455fd9cc..393fab87c7b0 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
@@ -690,9 +690,11 @@ bool FileDefinitionWidgetDraw::getNativeControlRegion(
return false;
Size aButtonSizeDown(pButtonDownPart->mnWidth,
pButtonDownPart->mnHeight);
-OString sOrientation = "decrease-edit-increase";
+auto const& pEntirePart
+= m_pWidgetDefinition->getDefinition(eType,
ControlPart::Entire);
+OString sOrientation = pEntirePart->msOrientation;
-if (sOrientation == "decrease-edit-increase")
+if (sOrientation.isEmpty() || sOrientation ==
"decrease-edit-increase")
{
if (ePart == ControlPart::ButtonUp)
{
@@ -728,7 +730,7 @@ bool FileDefinitionWidgetDraw::getNativeControlRegion(
return true;
}
}
-else
+else if (sOrientation == "edit-decrease-increase")
{
if (ePart == ControlPart::ButtonUp)
{
diff --git a/vcl/source/gdi/WidgetDefinitionReader.cxx
b/vcl/source/gdi/WidgetDefinitionReader.cxx
index f825addd0042..dd6bf75abe32 100644
--- a/vcl/source/gdi/WidgetDefinitionReader.cxx
+++ b/vcl/source/gdi/WidgetDefinitionReader.cxx
@@ -308,6 +308,12 @@ void
WidgetDefinitionReader::readDefinition(tools::XmlWalker& rWalker,
pPart->mnMarginWidth = nMarginWidth;
}
+OString sOrientation = rWalker.attribute("orientation");
+if (!sOrientation.isEmpty())
+{
+pPart->msOrientation = sOrientation;
+}
+
rWidgetDefinition.maDefinitions.emplace(ControlTypeAndPart(eType,
ePart), pPart);
readPart(rWalker, pPart);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125437] Libreoffice crashes when restarting after setting opencl & restart
https://bugs.documentfoundation.org/show_bug.cgi?id=125437 MM changed: What|Removed |Added Crash report or||https://crashreport.libreof crash signature||fice.org/stats/crash_detail ||s/78ba7238-c62b-422b-9039-5 ||47517c6e707 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125437] New: Libreoffice crashes when restarting after setting opencl & restart
https://bugs.documentfoundation.org/show_bug.cgi?id=125437 Bug ID: 125437 Summary: Libreoffice crashes when restarting after setting opencl & restart Product: LibreOffice Version: 6.2.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: plokk...@vivaldi.net Description: LO crashes when restarting after setting opencl on (or off) & press restart after apply. Steps to Reproduce: - Start LO - Goto options > opencl - Turn opencl on or off, depends whether it's off / on. - Press 'Apply' - Press 'Restart now' Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: Yes Additional Info: It only happens when pressing 'apply / restart now' and -not- when pressing 'ok / restart now Version: 6.2.3.2 (x64) Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac CPU threads: 3; OS: Windows 6.1; UI render: GL; VCL: win -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125426] Very slow loading of 12kB ODT, loads fast when contents is pasted into new ODT
https://bugs.documentfoundation.org/show_bug.cgi?id=125426 --- Comment #3 from MM --- Unconfirmed on windows 7 x64 with Version: 6.2.3.2 (x64) Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac CPU threads: 3; OS: Windows 6.1; UI render: default; VCL: win -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 Wolfgang Jäger changed: What|Removed |Added CC||j...@psilosoph.de --- Comment #3 from Wolfgang Jäger --- I should subjoin that even the expression EqualUnoObjects(ThisComponent.Sheets.GetByIndex(0), ThisComponent.Sheets.GetByIndex(0)) will return False. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125436] Dialog box disabled to choose between Firebird or hsqldb embedded when creating DB
https://bugs.documentfoundation.org/show_bug.cgi?id=125436 Drew Jensen changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Drew Jensen --- Confirmed w/ Ubuntu 18.04.1, LO Version: 6.3.0.0.alpha1+ Build ID: b26b6cab5d8147d35f76a21c333719c80840d08d CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: kde5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-20_23:15:15 The dialog starts out that way, always. If you select one of the other option buttons on the dialog page then go back and select the Which engine option button the drop down does become active. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124305] Multi-selection lost after promote/demote chapter/level in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=124305 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/menufloatingwindow.cxx | 36 +++
1 file changed, 23 insertions(+), 13 deletions(-)
New commits:
commit c04169c586ef1d55b1d0ac469bb4fbd4f50bd08a
Author: Miklos Vajna
AuthorDate: Tue May 21 17:45:05 2019 +0200
Commit: Miklos Vajna
CommitDate: Tue May 21 23:59:28 2019 +0200
tdf#125415 vcl menu floating window: avoid flicker
This is similar to e8d5b8beb5958147235ff955ed38c47b51d860ff (tdf#113714
vcl menu bar window: avoid flicker, 2019-05-20), except that was for the
menu bar window, and this is for the floating window opening from that
one.
Change-Id: Ib24f4999ad3e8cbbecc058368e9d112e106e9178
Reviewed-on: https://gerrit.libreoffice.org/72688
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/vcl/source/window/menufloatingwindow.cxx
b/vcl/source/window/menufloatingwindow.cxx
index 7986679f8af1..631d275e8656 100644
--- a/vcl/source/window/menufloatingwindow.cxx
+++ b/vcl/source/window/menufloatingwindow.cxx
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include
MenuFloatingWindow::MenuFloatingWindow( Menu* pMen, vcl::Window* pParent,
WinBits nStyle ) :
@@ -1206,32 +1207,41 @@ void MenuFloatingWindow::Paint(vcl::RenderContext&
rRenderContext, const tools::
if (!pMenu)
return;
-rRenderContext.Push( PushFlags::CLIPREGION );
-rRenderContext.SetClipRegion(vcl::Region(rPaintRect));
+// Make sure that all actual rendering happens in one go to avoid flicker.
+ScopedVclPtrInstance pBuffer;
+pBuffer->SetOutputSizePixel(GetOutputSizePixel(), false);
+pBuffer->DrawOutDev(Point(0, 0), GetOutputSizePixel(), Point(0, 0),
GetOutputSizePixel(),
+rRenderContext);
+
+pBuffer->Push(PushFlags::CLIPREGION);
+pBuffer->SetClipRegion(vcl::Region(rPaintRect));
if (rRenderContext.IsNativeControlSupported(ControlType::MenuPopup,
ControlPart::Entire))
{
-rRenderContext.SetClipRegion();
+pBuffer->SetClipRegion();
long nX = 0;
Size aPxSize(GetOutputSizePixel());
aPxSize.AdjustWidth( -nX );
ImplControlValue aVal(pMenu->nTextPos - GUTTERBORDER);
-rRenderContext.DrawNativeControl(ControlType::MenuPopup,
ControlPart::Entire,
- tools::Rectangle(Point(nX, 0),
aPxSize),
- ControlState::ENABLED, aVal,
OUString());
-InitMenuClipRegion(rRenderContext);
+pBuffer->DrawNativeControl(ControlType::MenuPopup, ControlPart::Entire,
+ tools::Rectangle(Point(nX, 0), aPxSize),
ControlState::ENABLED,
+ aVal, OUString());
+InitMenuClipRegion(*pBuffer);
}
if (IsScrollMenu())
{
-ImplDrawScroller(rRenderContext, true);
-ImplDrawScroller(rRenderContext, false);
+ImplDrawScroller(*pBuffer, true);
+ImplDrawScroller(*pBuffer, false);
}
-
rRenderContext.SetFillColor(rRenderContext.GetSettings().GetStyleSettings().GetMenuColor());
-pMenu->ImplPaint(rRenderContext, GetOutputSizePixel(), nScrollerHeight,
ImplGetStartY());
+
pBuffer->SetFillColor(rRenderContext.GetSettings().GetStyleSettings().GetMenuColor());
+pMenu->ImplPaint(*pBuffer, GetOutputSizePixel(), nScrollerHeight,
ImplGetStartY());
if (nHighlightedItem != ITEMPOS_INVALID)
-RenderHighlightItem(rRenderContext, nHighlightedItem);
+RenderHighlightItem(*pBuffer, nHighlightedItem);
+
+pBuffer->Pop();
-rRenderContext.Pop();
+rRenderContext.DrawOutDev(Point(0, 0), GetOutputSizePixel(), Point(0, 0),
GetOutputSizePixel(),
+ *pBuffer);
}
void MenuFloatingWindow::ImplDrawScroller(vcl::RenderContext& rRenderContext,
bool bUp)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105314] EDITING Filter finds not all cells
https://bugs.documentfoundation.org/show_bug.cgi?id=105314 --- Comment #7 from stefan_lange...@t-online.de --- As I have seen only now I haven't described the bug completely correct: The filter in "Testtabelle_Filter_V1.ods" is set via Standard Filter and 40 rows are selected by the filter and in "Testtabelle_Filter_V2.ods" is set by "Search items" and 39 rows are selected. But as was written by m.a.riosv in Comment 3 it is a corner case. I have already written in Comment 5 when the problem did occur first (LO 5.0.0, when in the filter entry list the the entry "empty" was introduced). The bug is still present in Version: 6.2.3.2 (x64) Build-ID: aecc05fe267cc68dde00352a451aa867b3b546ac CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: CL and in Version: 6.2.4.2 (x64) Build-ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: CL and also in Version: 6.3.0.0.alpha1+ (x64) Build ID: 9e0e97b716ab074d4558c76a62a66bf597f332a5 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-05-21_17:40:06 Locale: de-DE (de_DE); UI-Language: en-US In Version: 6.3.0.0.alpha1+ (x64) there is an new bug I will report soon: In the case of "Testtabelle_Filter_V1.ods" where the filter is set via Standard Filter a click on the blue filter arrow in column D opens the entry list with all entries selected and also "All" selected, but the click on "OK" doesn't change the selection: Only the entries selected by Standard filter remain selected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120278] With version 6.1.2.1 cannot save doc to NAS drive due to insufficient permission
https://bugs.documentfoundation.org/show_bug.cgi?id=120278 r.mario...@fdcx.net changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #5 from r.mario...@fdcx.net --- As requested I downloaded and performed a parallel install on my LinuxMint 19.2 system. The problem of saving to a remote share (CISF or NSF) seems to work just fine now. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=104742 Bug 104742 depends on bug 120278, which changed state. Bug 120278 Summary: With version 6.1.2.1 cannot save doc to NAS drive due to insufficient permission https://bugs.documentfoundation.org/show_bug.cgi?id=120278 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125436] New: Dialog box disabled to choose between Firebird or hsqldb embedded when creating DB
https://bugs.documentfoundation.org/show_bug.cgi?id=125436 Bug ID: 125436 Summary: Dialog box disabled to choose between Firebird or hsqldb embedded when creating DB Product: LibreOffice Version: 6.3.0.0.alpha1+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: serval2...@yahoo.fr Description: On pc Debian x86-64 with master sources updated today, the dialog box disabled to choose between Firebird or hsqldb embedded when creating DB Steps to Reproduce: 1. Launch Base Actual Results: Create a new database is selected by default but embedded database listbox is disabled. Expected Results: Create a new database is selected by default but embedded database listbox is enabled, so you can choose the type of DB. Reproducible: Always User Profile Reset: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125434] Windows Installer
https://bugs.documentfoundation.org/show_bug.cgi?id=125434 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please from where is the download and what is the web browser? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122538] EDITING Table - Index Design: Index isn't sortable any more
https://bugs.documentfoundation.org/show_bug.cgi?id=122538 --- Comment #3 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. I submitted a patch to gerrit here: https://gerrit.libreoffice.org/#/c/72701/ It concerns only hsqldb. About Firebird, I don't reproduce this. I noticed there's no AddIndexAppendix quotation in Drivers.xcu from Firebird part, see https://opengrok.libreoffice.org/xref/core/connectivity/registry/firebird/org/openoffice/Office/DataAccess/Drivers.xcu?r=9b6906bb -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 845ebb4dd45ad4f93a6344d010f383be339ad488 Author: Andrea Gelmini AuthorDate: Tue May 14 21:25:29 2019 + Commit: Julien Nabet CommitDate: Tue May 21 22:15:51 2019 +0200 Fix typo Change-Id: I2c4fcfee1ee9901297acebc11a7698633c3c21ef Reviewed-on: https://gerrit.libreoffice.org/72696 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx index 9f0e27909515..8f09ca8f13d0 100644 --- a/editeng/source/editeng/impedit.hxx +++ b/editeng/source/editeng/impedit.hxx @@ -264,7 +264,7 @@ private: /// mechanism to change from the classic refresh mode that simply // invalidates the area where text was changed. When set, the invalidate // and the direct repaint of the Window-plugged EditView will be suppressed. -// Instead, a consumer that has registered using a EditViewCallbacks +// Instead, a consumer that has registered using an EditViewCallbacks // incarnation has to handle that. Used e.g. to represent the edited text // in Draw/Impress in an OverlayObject which avoids evtl. expensive full // repaints of the EditView(s) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125435] New: LibreOffice PDF export regression -- edit file properties before saving/exporting doesn't work correctly and the PDF isn't opened automatically after export
https://bugs.documentfoundation.org/show_bug.cgi?id=125435 Bug ID: 125435 Summary: LibreOffice PDF export regression -- edit file properties before saving/exporting doesn't work correctly and the PDF isn't opened automatically after export Product: LibreOffice Version: 6.2.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: joaopauloag-freedesk...@yahoo.com.br Description: On Windows 10, version 1809, 64 bits, running LibreOffice 6.2.3.2 (x64), build ID aecc05fe267cc68dde00352a451aa867b3b546ac, do the following: * Configure LibreOffice to edit file properties before saving (Menu Tools, Options, Load/Save, General, enable "Edit document properties before saving"). * Export any saved or unsaved document as a PDF file named as a new file (i.e., create a new PDF file instead of overwriting an old one). * LibreOffice opens an error message box saying (translated from PT-BR): "Error saving document : General error. General input/output error." * The PDF file isn't automatically opened (Menu File, Export As, Export As PDF, enable the "View PDF after export"). * Besides the error, the user still can edit the file properties and they will be saved on the exported PDF (tested with Title, Subject and Keywords fields, not tested with Custom Properties as they don't appear on SumatraPDF or Evince Document Viewer). * If the exported PDF file already exists (i.e., the user chooses to overwrite an old PDF file), there is no error shown and the PDF files is automatically opened if the setting to "View PDF after export" is enabled. I think this is due to the file properties being opened for the PDF file **before** the file is created. There is no __confirmed__ data loss (I didn't test with Adobe Reader or other PDF viewers which could show custom properties), but this is is annoying. Steps to Reproduce: 1. Configure LibreOffice to edit file properties before saving (Menu Tools, Options, Load/Save, General, enable "Edit document properties before saving"). 2. (Optional) Configure LibreOffice to open the PDF file after export (Menu File, Export As, Export As PDF, enable the "View PDF after export"). 3. Export any saved or unsaved document as a PDF file named as a new file (i.e., create a new PDF file instead of overwriting an old one). 4. LibreOffice opens an error message box saying (translated from PT-BR): "Error saving document : General error. General input/output error." 5.a) If Step 2. was completed: The PDF file isn't automatically opened. 5.b) With or without Step 2. completed: If the exported PDF file already exists (i.e., the user chooses to overwrite an old PDF file), there is no error shown and the PDF files is automatically opened if the setting to "View PDF after export" is enabled. 6. Besides the error, the user still can edit the file properties and they will be saved on the exported PDF (tested with Title, Subject and Keywords fields, not tested with Custom Properties as they don't appear on SumatraPDF or Evince Document Viewer). Actual Results: Actual results: There is no __confirmed__ data loss (I didn't test with Adobe Reader or other PDF viewers which could show custom properties), but this is is annoying. Expected Results: Expected results: 1. No error shown when exporting PDF if editing properties before saving file was enabled. 2. Automatically open the PDF file if view PDF after export was enabled. Reproducible: Always User Profile Reset: No Additional Info: I marked version 6.2.3.2 release as the earliest version affected because I didn't test on earlier versions. I think it's a regression from version 6.1.5.2, as it was the latest I had before upgrading to 6.2.x line. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/pdfium
external/pdfium/Library_pdfium.mk |3 +-- external/pdfium/inc/pch/precompiled_pdfium.hxx |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) New commits: commit 08ec2c1dc59255cd35ee29774874398c44b5b2be Author: Miklos Vajna AuthorDate: Tue May 21 17:16:25 2019 +0200 Commit: Miklos Vajna CommitDate: Tue May 21 21:58:16 2019 +0200 pdfium: re-enable PCH Change-Id: I5987fcc04396e4e22640d6b09b52fa7b08460369 Reviewed-on: https://gerrit.libreoffice.org/72687 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/external/pdfium/Library_pdfium.mk b/external/pdfium/Library_pdfium.mk index b70adf146c6c..acc2f7d38d84 100644 --- a/external/pdfium/Library_pdfium.mk +++ b/external/pdfium/Library_pdfium.mk @@ -13,8 +13,7 @@ $(eval $(call gb_Library_use_unpacked,pdfium,pdfium)) $(eval $(call gb_Library_set_warnings_not_errors,pdfium)) -# FIXME this needs updating -#$(eval $(call gb_Library_set_precompiled_header,pdfium,$(SRCDIR)/external/pdfium/inc/pch/precompiled_pdfium)) +$(eval $(call gb_Library_set_precompiled_header,pdfium,$(SRCDIR)/external/pdfium/inc/pch/precompiled_pdfium)) $(eval $(call gb_Library_set_include,pdfium,\ -I$(call gb_UnpackedTarball_get_dir,pdfium) \ diff --git a/external/pdfium/inc/pch/precompiled_pdfium.hxx b/external/pdfium/inc/pch/precompiled_pdfium.hxx index 282c2a508060..c70c4d16a101 100644 --- a/external/pdfium/inc/pch/precompiled_pdfium.hxx +++ b/external/pdfium/inc/pch/precompiled_pdfium.hxx @@ -13,7 +13,7 @@ manual changes will be rewritten by the next run of update_pch.sh (which presumably also fixes all possible problems, so it's usually better to use it). - Generated on 2019-05-18 14:23:38 using: + Generated on 2019-05-21 17:15:06 using: ./bin/update_pch external/pdfium pdfium --cutoff=1 --exclude:system --include:module --include:local If after updating build fails, use the following command to locate conflicting headers: @@ -124,7 +124,6 @@ #include #include #include -#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421
Julien Nabet changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #2 from Julien Nabet ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Since in this part:
3171 if( x1 == x2 )
3172 {
3173 refVar->PutBool( true );
3174 }
x1 isn't considered as == to x2, refVar stays at false.
Now I don't know how to fix this or if we should fix this.
Indeed, I suppose it may have impacts on existing macros.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/hierarchy/hierarchycontent.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 165327d4ae442fb33b634577c32fe692a9293457
Author: Mike Kaganski
AuthorDate: Tue May 21 18:52:54 2019 +0200
Commit: Mike Kaganski
CommitDate: Tue May 21 21:54:04 2019 +0200
tdf#125424: properly reset temporarily cleared guard
Since the guard is only cleared optionally, most probably the code after
the conditional block is expected to be guarded until the second clear.
Change-Id: I913cb4bff42140da605a6f45414bece419f4a4c8
Reviewed-on: https://gerrit.libreoffice.org/72689
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/ucb/source/ucp/hierarchy/hierarchycontent.cxx
b/ucb/source/ucp/hierarchy/hierarchycontent.cxx
index e0ac3c81fda7..923225a1df90 100644
--- a/ucb/source/ucp/hierarchy/hierarchycontent.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchycontent.cxx
@@ -1002,7 +1002,7 @@ uno::Sequence< uno::Any >
HierarchyContent::setPropertyValues(
const uno::Sequence< beans::PropertyValue >& rValues,
const uno::Reference< ucb::XCommandEnvironment > & xEnv )
{
-osl::ClearableGuard< osl::Mutex > aGuard( m_aMutex );
+osl::ResettableGuard< osl::Mutex > aGuard( m_aMutex );
uno::Sequence< uno::Any > aRet( rValues.getLength() );
uno::Sequence< beans::PropertyChangeEvent > aChanges( rValues.getLength()
);
@@ -1253,6 +1253,7 @@ uno::Sequence< uno::Any >
HierarchyContent::setPropertyValues(
"Exchange failed!",
static_cast< cppu::OWeakObject * >( this ) );
}
+aGuard.reset();
}
if ( !aOldTitle.isEmpty() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125434] New: Windows Installer
https://bugs.documentfoundation.org/show_bug.cgi?id=125434 Bug ID: 125434 Summary: Windows Installer Product: LibreOffice Version: 6.2.3.1 rc Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: commuz...@gmail.com Description: I cannot install Libre Office on my PC. I downloaded twice the Windows version 6.2.3_Win_x86 and it tells me that something with the packet is not working with Windows Installer... Actual Results: Installation of the software impossible Expected Results: Possibility to install Libre office on my computer and use it. Thanks Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/qt5
vcl/qt5/Qt5FilePicker.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit e9280e673da66cc37a8908dd82698ff91f2fe4ec Author: Michael Weghorn AuthorDate: Wed Feb 6 17:45:56 2019 +0100 Commit: Katarina Behrens CommitDate: Tue May 21 21:44:05 2019 +0200 Qt5FilePicker::addCustomControl: Add missing from kde5 Take over functionality from 'KDE5FilePicker::addCustomControl' that has not been implemented in qt5 one yet. Change-Id: I9690e163b3b739bfec6813d9a4e1e0170b730187 Reviewed-on: https://gerrit.libreoffice.org/68056 Tested-by: Jenkins Reviewed-by: Katarina Behrens (cherry picked from commit c5947393cdd433a4a9d3e19ded1e9ca6ef384d74) Reviewed-on: https://gerrit.libreoffice.org/72653 diff --git a/vcl/qt5/Qt5FilePicker.cxx b/vcl/qt5/Qt5FilePicker.cxx index 9a0d6e820783..0d2025cec55b 100644 --- a/vcl/qt5/Qt5FilePicker.cxx +++ b/vcl/qt5/Qt5FilePicker.cxx @@ -624,9 +624,13 @@ void Qt5FilePicker::addCustomControl(sal_Int16 controlId) case LISTBOX_IMAGE_TEMPLATE: resId = STR_FPICKER_IMAGE_TEMPLATE; break; +case LISTBOX_IMAGE_ANCHOR: +resId = STR_FPICKER_IMAGE_ANCHOR; +break; case LISTBOX_VERSION_LABEL: case LISTBOX_TEMPLATE_LABEL: case LISTBOX_IMAGE_TEMPLATE_LABEL: +case LISTBOX_IMAGE_ANCHOR_LABEL: case LISTBOX_FILTER_SELECTOR: break; } @@ -653,6 +657,7 @@ void Qt5FilePicker::addCustomControl(sal_Int16 controlId) break; case LISTBOX_VERSION: case LISTBOX_TEMPLATE: +case LISTBOX_IMAGE_ANCHOR: case LISTBOX_IMAGE_TEMPLATE: case LISTBOX_FILTER_SELECTOR: label = new QLabel(getResString(resId), m_pExtraControls); @@ -662,6 +667,7 @@ void Qt5FilePicker::addCustomControl(sal_Int16 controlId) case LISTBOX_VERSION_LABEL: case LISTBOX_TEMPLATE_LABEL: case LISTBOX_IMAGE_TEMPLATE_LABEL: +case LISTBOX_IMAGE_ANCHOR_LABEL: break; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx
vcl/unx/kde5/KDE5FilePicker.hxx |4
vcl/unx/kde5/KDE5FilePicker2.cxx | 11 ---
2 files changed, 4 insertions(+), 11 deletions(-)
New commits:
commit 5fe230552f276b429178f1d183abc134452b0150
Author: Michael Weghorn
AuthorDate: Wed Feb 6 17:12:32 2019 +0100
Commit: Katarina Behrens
CommitDate: Tue May 21 21:42:53 2019 +0200
kde5 fpicker: Reuse parent class member to store custom widgets
Directly access member 'm_pExtraControls' from parent class
Qt5FilePicker for managing custom widgets, rather than maintaining
an own one.
This is meant as an intermediate step, further refactoring will
follow.
Change-Id: I0568d3db68dc24042e198d36f4b5e49608f93a0e
Reviewed-on: https://gerrit.libreoffice.org/68055
Tested-by: Jenkins
Reviewed-by: Katarina Behrens
(cherry picked from commit 2bd0400a49ad2dfeb1c3848a84f8e512433b5411)
Reviewed-on: https://gerrit.libreoffice.org/72652
diff --git a/vcl/unx/kde5/KDE5FilePicker.hxx b/vcl/unx/kde5/KDE5FilePicker.hxx
index 3d3a428cd5a0..044a921eeb72 100644
--- a/vcl/unx/kde5/KDE5FilePicker.hxx
+++ b/vcl/unx/kde5/KDE5FilePicker.hxx
@@ -54,9 +54,6 @@ protected:
QHash _customWidgets;
QHash _customListboxes;
-//widget to contain extra custom controls
-QWidget* _extraControls;
-
//layout for extra custom controls
QGridLayout* _layout;
@@ -64,7 +61,6 @@ protected:
public:
explicit KDE5FilePicker(QFileDialog::FileMode);
-virtual ~KDE5FilePicker() override;
// XExecutableDialog functions
virtual sal_Int16 SAL_CALL execute() override;
diff --git a/vcl/unx/kde5/KDE5FilePicker2.cxx b/vcl/unx/kde5/KDE5FilePicker2.cxx
index 7e683a59884f..aabd344b1547 100644
--- a/vcl/unx/kde5/KDE5FilePicker2.cxx
+++ b/vcl/unx/kde5/KDE5FilePicker2.cxx
@@ -82,8 +82,7 @@ uno::Sequence FilePicker_getSupportedServiceNames()
KDE5FilePicker::KDE5FilePicker(QFileDialog::FileMode eMode)
// Native kde5 filepicker does not add file extension automatically
: Qt5FilePicker(eMode, true)
-, _extraControls(new QWidget)
-, _layout(new QGridLayout(_extraControls))
+, _layout(new QGridLayout(m_pExtraControls))
, allowRemoteUrls(false)
{
// use native dialog
@@ -118,8 +117,6 @@ KDE5FilePicker::KDE5FilePicker(QFileDialog::FileMode eMode)
qApp->installEventFilter(this);
}
-KDE5FilePicker::~KDE5FilePicker() { delete _extraControls; }
-
sal_Int16 SAL_CALL KDE5FilePicker::execute()
{
if (qApp->thread() != QThread::currentThread())
@@ -326,7 +323,7 @@ void KDE5FilePicker::addCustomControl(sal_Int16 controlId)
// code, but the checkbox is hidden and ignored
bool hidden = controlId == CHECKBOX_AUTOEXTENSION;
-auto widget = new QCheckBox(resString, _extraControls);
+auto widget = new QCheckBox(resString, m_pExtraControls);
widget->setHidden(hidden);
if (!hidden)
{
@@ -349,7 +346,7 @@ void KDE5FilePicker::addCustomControl(sal_Int16 controlId)
case LISTBOX_TEMPLATE:
case LISTBOX_VERSION:
{
-auto widget = new QComboBox(_extraControls);
+auto widget = new QComboBox(m_pExtraControls);
QLabel* label = new QLabel(resString);
label->setBuddy(widget);
@@ -508,7 +505,7 @@ bool KDE5FilePicker::eventFilter(QObject* o, QEvent* e)
{
if (auto* fileWidget = w->findChild({},
Qt::FindDirectChildrenOnly))
{
-fileWidget->setCustomWidget(_extraControls);
+fileWidget->setCustomWidget(m_pExtraControls);
// remove event filter again; the only purpose was to set the
custom widget here
qApp->removeEventFilter(this);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
