Re: On extending SdrTextPrimitive2D

2014-07-24 Thread Thorsten Behrens
Matteo Campanelli wrote: > I created a class that extends SdrTextPrimitive2D. The derived > class - SdrChainedTextPrimitive2D - should be used for dealing with > text in chained text boxes. > Cool! > 1) SdrChainedTextPrimitive2D::create2DDecomposition should return a > Primitive2DSequence. What

Re: Tinderbox 'Win-x86@42' seems stuck

2014-07-27 Thread Thorsten Behrens
Robinson Tryon wrote: > On Sun, Jul 27, 2014 at 7:08 AM, Adam Fyne wrote: > > Looks like latest daily build from that machine was on July 22nd. > > Who is responsible for this machine and can maybe quickly check it out? > > > Restarted, hung at some unit test. -- Thorsten signature.asc Des

Shared compilation cache & windows ...

2014-05-09 Thread Thorsten Behrens
Hi, seems the mozilla guys are pushing some boundaries again - is this sccache thing something we could try on windows? For me, the modified ccache has never really worked... http://glandium.org/blog/?p=3275 Cheers, -- Thorsten signature.asc Description: Digital signature ___

[Libreoffice-commits] buildbot.git: 2 commits - bin/tinbuild bin/tinbuild2

2014-05-14 Thread Thorsten Behrens
bin/tinbuild | 367 -- bin/tinbuild2 |1 2 files changed, 1 insertion(+), 367 deletions(-) New commits: commit d9fbd644cf17ca43f06f0ae33b4312d47a86354d Author: Thorsten Behrens Date: Wed May 14 09:27:40 2014 +0200 tinbuild is

Re: dev-www down (was: do NOT immediately remove files from dev-downloads.libreoffice.org on update of externals!)

2014-05-19 Thread Thorsten Behrens
Bjoern Michaelsen wrote: > Anyone taking care of this? > Back now, will look into the details. -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [GSoC] Text Background Color in Draw - Report 24/05/2013

2014-05-27 Thread Thorsten Behrens
Noel Grandin wrote: > [background color & anti-aliasing] > > Hopefully LO doesn't have this problem, but just in case, I thought > you should know. > Don't think so. Glyphs are cached with alpha info in all font subsystems that I know of. Cheers, -- Thorsten signature.asc Description: Digital

Re: Using OutputDevice::DrawTransparent fails

2014-05-27 Thread Thorsten Behrens
Matteo Campanelli wrote: > Some further experiments: > Let me get a build of your exact version, will get back to you on that. Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.

[Libreoffice-commits] core.git: vcl/generic

2014-05-27 Thread Thorsten Behrens
vcl/generic/glyphs/gcach_layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b3911e8adb34c6ee72577e58658b2cb72c6e79a3 Author: Thorsten Behrens Date: Wed May 28 00:48:49 2014 +0200 Fix build to work with older harfbuzz versions. Whee, seems hb

Re: EE_EDIT_CHAR_BKGCOLOR breaks unit test?

2014-05-27 Thread Thorsten Behrens
Matteo Campanelli wrote: > I put it at the end of the char attributes updating all subsequent values > consistently (all incremented by one). > Still, it broke unit test for editeng_core. > Is there some check I'm missing? > warn:legacy.tools:12168:1:editeng/source/editeng/eerdll.cxx:165: ITEMCOUN

Re: [GSoC] Text Background Color in Draw - Report 02/06/2014

2014-06-03 Thread Thorsten Behrens
Matteo Campanelli wrote: > I am still trying to debug some misbehavior in (2) and i had no successful > experiment in with transparency so far. > Fixing these two issues and writing more layout attribute-related code are > my core goals of the current week. > Hi Matteo, sounds excellent - and do

[Libreoffice-commits] buildbot.git: tb/tb_internals.sh

2014-06-03 Thread Thorsten Behrens
tb/tb_internals.sh |3 +++ 1 file changed, 3 insertions(+) New commits: commit c900dd47e4eabc6a8b977ff012379a52f6a7c43c Author: Thorsten Behrens Date: Tue Jun 3 20:50:52 2014 +0200 Add libreoffice-4-3 branch to tb. diff --git a/tb/tb_internals.sh b/tb/tb_internals.sh index 5114824

Re: Sort and copy results

2014-06-05 Thread Thorsten Behrens
Kohei Yoshida wrote: > I'm just wondering if anyone would miss this feature if it got > removed. > Especially with Calc & Writer, it is a relatively safe bet that every obscure feature is absolutely necessary for someone's workflow. Just sayin, -- Thorsten signature.asc Description: Digital si

Re: EditEng - Switch from edit to non-edit mode - Code references?

2014-06-14 Thread Thorsten Behrens
Matteo Campanelli wrote: > Rendering of text in this module seems to work (_roughly_) in this way: > (1) information on font (text color, underlining, italic...) are passed > from an external module [this is still subject of exploration], That should be svx/source/sdr/primitive2d/sdrattributecreato

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - vcl/generic

2014-06-20 Thread Thorsten Behrens
vcl/generic/glyphs/gcach_layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a4090d9f9bfa7fbe9b25147f3c661c99714e83a6 Author: Thorsten Behrens Date: Wed May 28 00:48:49 2014 +0200 Fix build to work with older harfbuzz versions. Whee, seems hb

Re: [GSoC] Chained Text Boxes in Draw - Report 29/06/2014

2014-07-01 Thread Thorsten Behrens
Matteo Campanelli wrote: > Current goals include understanding FormatDoc's code further trying to > answer questions (a) and (b) above. > Hi Matteo, as discussed during the hangout today, let's focus on EditEng & drawinglayer for the moment. Live editing also has lower prio than having static tex

Re: Discussion of Bug 37759 - Pixel around Objects like ellipse

2014-08-22 Thread Thorsten Behrens
Regina Henschel wrote: > What is wrong with gradient fill and mso? Do you know an issue or do > you have test documents? I see no difference between AOO (without > the points) and LibreOffice (with this points). > This blog should give some more background info; no bugdocs at hand currently, but s

Re: [Libreoffice-commits] core.git: canvas/source dbaccess/source oox/source reportdesign/source slideshow/source

2014-08-29 Thread Thorsten Behrens
Jörg Sonnenberger wrote: > +SurfaceSharedPtr surface(mpOwningSpriteCanvas->getBufferSurface()); > ::std::for_each( aUncoveredAreas.begin(), > aUncoveredAreas.end(), > ::boost::bind( &repaintBackground, >

Re: [Libreoffice-commits] core.git: canvas/source dbaccess/source oox/source reportdesign/source slideshow/source

2014-08-30 Thread Thorsten Behrens
Joerg Sonnenberger wrote: > Haven't tried, was looking for the minimal change to the existing > structure. > The proposed change would be even more minimal. ;) > One thing to keep in mind is that getBufferSurface() creates a > temporary variable. It doesn't return a reference itself. > Sure, it's

[Libreoffice-commits] voting.git: configure.in vote/2014-mc vote/Makefile.am

2014-09-03 Thread Thorsten Behrens
79b19823a36a7c1dcd96dd89cf354342d731a8a7 Author: Thorsten Behrens Date: Wed Sep 3 23:21:21 2014 +0200 Create 2014 membership committee election pages. diff --git a/configure.in b/configure.in index 5567fea..decfd68 100644 --- a/configure.in +++ b/configure.in @@ -20,4 +20,5 @@ vote/2012

[Libreoffice-commits] voting.git: vote/index.wml

2014-09-03 Thread Thorsten Behrens
vote/index.wml |1 + 1 file changed, 1 insertion(+) New commits: commit 3c14098e5ec53f41fe389b3b356f845b115a482b Author: Thorsten Behrens Date: Wed Sep 3 23:26:43 2014 +0200 Add reference to MC election to main page diff --git a/vote/index.wml b/vote/index.wml index 59e15bd..7e32257

[Libreoffice-commits] voting.git: vote/2014-mc

2014-09-04 Thread Thorsten Behrens
vote/2014-mc/candidates.wml | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) New commits: commit 8a1cfe9a7a6c9b06a54bedb58f0e94db6d47f1db Author: Thorsten Behrens Date: Thu Sep 4 18:02:00 2014 +0200 Fix glitches on candidates page. diff --git a/vote/2014-mc

Re: LibreOffice / Future / design notes foo ...

2014-09-09 Thread Thorsten Behrens
Michael Meeks wrote: > * VCL lifecycle > + switching to reference counted / smart-pointer > for all VCL Window sub-classes > As a random word of warning - windows point back & forth all over the place, to both parent _and_ children; unless one uses weak pointers

[Libreoffice-commits] core.git: vcl/unx

2014-04-10 Thread Thorsten Behrens
vcl/unx/generic/printer/ppdparser.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 23648e824fe41addb75a024374085bbc831b5d1b Author: Thorsten Behrens Date: Thu Apr 10 19:35:15 2014 +0200 Fix crash in ppd parser. Only access pKey after we'v

[Libreoffice-commits] core.git: sfx2/source

2014-04-10 Thread Thorsten Behrens
sfx2/source/dialog/templdlg.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 058cfa72dcdd91df302be45f7fc59b0d961a420b Author: Thorsten Behrens Date: Thu Apr 10 19:40:54 2014 +0200 Fix fdo#71423 - crash while editing Impress tables. Band-aid fix

[Libreoffice-commits] core.git: 2 commits - canvas/source include/o3tl

2014-04-15 Thread Thorsten Behrens
canvas/source/vcl/impltools.cxx|7 -- include/o3tl/compat_functional.hxx | 43 - 2 files changed, 5 insertions(+), 45 deletions(-) New commits: commit 7e6628f374cdb87631b54ccdafd69554eda9536e Author: Thorsten Behrens Date: Tue Apr 15 21:36:02

Re: [Libreoffice-commits] core.git: 3 commits - sd/source slideshow/source

2014-04-15 Thread Thorsten Behrens
Zolnai Tamás wrote: > --- a/slideshow/source/engine/shapes/appletshape.cxx > +++ b/slideshow/source/engine/shapes/appletshape.cxx > @@ -96,11 +96,11 @@ namespace slideshow > virtual bool implRender( const ::basegfx::B2DRange& rCurrBounds > ) const SAL_OVERRIDE; > virtual

Re: OutputDevice code reorganization

2014-04-15 Thread Thorsten Behrens
Kohei Yoshida wrote: > My only request is that the move be done in such a way that git knows > the files have been moved (in a single commit), rather than the old > files removed and new one added. > That is, for all intents and purposes, not going to work here, when methods are mixed and matched

[Libreoffice-commits] core.git: slideshow/source

2014-04-16 Thread Thorsten Behrens
slideshow/source/inc/iexternalmediashapebase.hxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4be3e38439672e6b3f42617a050494b16535afea Author: Thorsten Behrens Date: Wed Apr 16 10:35:58 2014 +0200 Adjust header guard to modified filename

Re: [Libreoffice-commits] core.git: 3 commits - sd/source slideshow/source

2014-04-16 Thread Thorsten Behrens
Tamas Zolnai wrote: > I reverted these changes and just rename ExternalMediaShape which > was confusing for me. > Cool then - thx! :) -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.o

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sfx2/source

2014-04-16 Thread Thorsten Behrens
sfx2/source/dialog/templdlg.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 4128c63d655869e0ab7befde2c46761d8e1b273f Author: Thorsten Behrens Date: Thu Apr 10 19:40:54 2014 +0200 Fix fdo#71423 - crash while editing Impress tables. Band-aid fix

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2-4' - sfx2/source

2014-04-24 Thread Thorsten Behrens
sfx2/source/dialog/templdlg.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit c9c50b74fe1ca51e975deda780228386cefa8301 Author: Thorsten Behrens Date: Thu Apr 10 19:40:54 2014 +0200 Fix fdo#71423 - crash while editing Impress tables. Band-aid fix

Re: About ANIMATIONMODE_VIEW in slideshow module

2014-04-26 Thread Thorsten Behrens
Julien Nabet wrote: > Ok to remove ANIMATIONMODE_VIEW or did I miss something? > Yep, looks fine to me. Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freed

[Libreoffice-commits] core.git: bin/find-german-comments starmath/source

2014-04-28 Thread Thorsten Behrens
bin/find-german-comments |2 +- starmath/source/parse.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 4cd629645cdebf30f2e941df6e17f51b50d934f1 Author: Thorsten Behrens Date: Mon Apr 28 11:52:50 2014 +0200 Make starmath german-comment-free

Re: About Svgreader

2014-05-07 Thread Thorsten Behrens
Miklos Vajna wrote: > AFAIK the filter one is used when you open a .svg file (which opens in > Draw), and the svgio one is used to handle embedded SVG files. > Yep. > svgio is the newer code, it came in via > 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70, the filter one much older, > dates back to 200

Re: fdo#63315: sign windows binaries during build

2014-05-07 Thread Thorsten Behrens
David Tardon wrote: > If we really want to continue to use this script for signing, IMHO > it should be done as a separate step after build. > Might be a good idea anyway. Defined point in time when keys are used, less code involved, etc etc. -- Thorsten signature.asc Description: Digital signa

Re: [Libreoffice] presenterconsole in writer ? ...

2010-11-17 Thread Thorsten Behrens
Michael Meeks wrote: > Any volunteer interesting in debugging that ? one good way would be to > put a breakpoint in osl_psz_loadModule - and just stepping through until > we hit the one that pulls it in, grabbing a backtrace and posting it for > this module ;-) > There's an initial patch for

[Libreoffice] [UX] Progress bars - convey "this make take some time, dunno how long"

2010-11-17 Thread Thorsten Behrens
Hi, chatting with some folks yesterday at the OOo congress for business and administration, and two users approached me with a problem most prevalent when saving to network volumes: LibO save progress bars are basically driven by the xml export code (when saving to odf, of course), but there's so

Re: [Libreoffice] [UX] Progress bars - convey "this make take some time, dunno how long"

2010-11-17 Thread Thorsten Behrens
Christoph Noack wrote: > Okay, so we just "move" the problem. To better understand the issue... > > * The patch just changes the progress bar behavior, but the time > to be waited is the same? > > * The progress bar is the only information - as far as I know, > there i

Re: [Libreoffice] crash report and Oracle url

2010-11-19 Thread Thorsten Behrens
Jean-Baptiste Faure wrote: > Yesterday I got the crash report in LibO after a test of docking the > navigator on the right edge of the LibO window. It contained a link to > the privacy policy of Oracle. > > I did not sent the crash report because it was no clear for me who is > the recipient of th

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-22 Thread Thorsten Behrens
Gioele Barabucci wrote: > PS: Isn't there a libreoffice-legal mailing list? > There's a le...@documentfoundation.org alias - but I think code licensing questions are very much on topic on *this here* list. Cheers, -- Thorsten pgpmEFPNNaOfI.pgp Description: PGP signature ___

Re: [Libreoffice] Windows installer: what languages in multi/all_lang? - SDK: Why different version number?

2010-11-23 Thread Thorsten Behrens
Christian Lohmaier wrote: > * What languages does the windows installer contain? > * Which ones are included in multi and which ones in all_lang? > Hi Christian, all_lang is built --with-lang=ALL, multi includes the same set as you see for Mac. > * Is it correct that help in both packages is o

Re: [Libreoffice] Windows installer: what languages in multi/all_lang? - SDK: Why different version number?

2010-11-23 Thread Thorsten Behrens
Christian Lohmaier wrote: > >> * Version of the SDK: Why is the version "3.3.0" for Windows, but > >> "315" for all others? > >> > > Gah. My bad. Last minute renaming script gone wrong. > > So 315 is correct or 3.3.0? > 3.3.0 > Ah, So I can take (for beta3 at least) the difference between Mac >

Re: [Libreoffice] More links inherited from OOo

2010-11-23 Thread Thorsten Behrens
Sophie Gautier wrote: > - the paragraph about changes on BerkeleyDB engine and extensions > database incompatiliby seems strange when speaking about [for > ${PRODUCTNAME} versions prior to 3.2]. May be we should namely > speaks about OpenOffice.org. > Removed completely, LibO uses its own config di

Re: [Libreoffice] Building problem, DEBUG_ELEMENT when DEBUG is off

2010-11-23 Thread Thorsten Behrens
Joost Eekhoorn wrote: > I had a problem in writerfilter, building without DEBUG. > Should be fixed on master, please pull latest changes. Cheers, -- Thorsten pgplJkZmzhzbu.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.

Re: [Libreoffice] More links inherited from OOo

2010-11-24 Thread Thorsten Behrens
Christian Lohmaier wrote: > And "Your question may have already been answered - check the > Community Forum at http://www.documentfoundation.org/nabble/ " is > misleading, as that nabble is not a forum, but a mailing-list > interface in forum-style look and feel. > Bah, details. ;) (I think we re

[Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-24 Thread Thorsten Behrens
Hi, prompted by some complaints on too large icons on Mac, switched the icon size from 'large' to 'auto' for 3.3. Added code to all vcl native widget implementations to pick a preferred icon size (or auto-size them - this was already in place for windows, added similar code for Mac). Gnome/KDE pic

Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-25 Thread Thorsten Behrens
Michael Meeks wrote: > > prompted by some complaints on too large icons on Mac, switched the > > icon size from 'large' to 'auto' for 3.3. > > Did we ever get some screenshots of the perceived problem ? I asked in > some bug, but never got that back AFAIR. > Hi Michael, take my word for it

Re: [Libreoffice] compilation of LO on mac

2010-11-25 Thread Thorsten Behrens
Jonathan Aquilina wrote: > hey guys is it possible to compile LO on mac osx? if so what > dependencies does one need to satisfy before compiling it. > Hi Jonathan, sure - please read up here for details: http://wiki.documentfoundation.org/Development/How_to_build#Mac_OS_X Don't hesitate to ask,

Re: [Libreoffice] installation on mac doesnt require read me or licenses

2010-11-25 Thread Thorsten Behrens
Jonathan Aquilina wrote: > hey guys i'm noticing something interesting. wouldn't it be better > to use an installer to make sure the read me's as well as the > licenses get installed in the LO directory. currently the way it is > i don't have to drag either of them into the application directory. >

Re: [Libreoffice] Crash after Preference selection on Mac

2010-11-25 Thread Thorsten Behrens
Chris Makepeace wrote: > Libre Office (current) and OOo (3.2.1) is repeatedly crashing as I go into > Preferences (Mac language for 'Options'). > > The system console reports that the crash is related to JavaNativeFoundation > and the crash log makes no mention of Java but does spend 771 lines > r

Re: [Libreoffice] main.xdg 2 largest sections not needed on startup?

2010-11-26 Thread Thorsten Behrens
Sebastian Spaeth wrote: > The 2 biggest sections are: > "Labels" 14345 + 11 lines (defining label sizes for printing envelope labels) > "TableWizard" 8666 + 26 lines > > These make 1/3 of main.xdg, are both needed on startup or can those be > put into a different file that is only read when it is

Re: [Libreoffice] Image Compression Patch

2010-11-26 Thread Thorsten Behrens
Hi Andrew, sorry, a few of those nasty odf-branded icons slipped past me, had to revert a bunch of your optimized icons in default_images - do we have a script / documentation somewhere, so this can be re-optimized? Cheers, -- Thorsten pgpX8CKqmowyF.pgp Description: PGP signature _

Re: [Libreoffice] [Crazy Ideas] Discuss "Replace regexp parser with std library"

2010-11-29 Thread Thorsten Behrens
Joe Smith wrote: > I've looked at the code a bit, and it seems like there is indeed only one > point > of contact with the rest of the suite, textsearch.cxx, which handles all types > of text searches (normal, regexp & fuzzy), and calls Regexpr::re_search(), > which > calls re_match2() to run the

Re: [Libreoffice] Release criteria

2010-11-29 Thread Thorsten Behrens
Petr Mladek wrote: > I like the idea about adding libreoffice@lists.freedesktop.org into CC > of the meta bug. IMHO, it is worth to have the discussion about blocker > bugs on the dev mailing list. Others might help to provide more details > if we are in doubts... > > Thorsten, Kendy, others, wha

[Libreoffice] MacOSX release build configure line

2010-11-29 Thread Thorsten Behrens
Hi Norbert, got the mac booted & configure line (for the "build" repo) extracted: ./configure --with-distro=LibreOfficeMacOSX --with-lang="en-US af ar be-BY bg br ca cs cy da de el en-GB en-ZA es et fi fr ga gl gu he hi-IN hu hr it ja ka km ko lt mk nb nl nn nr pa-IN pl pt pt-BR ru rw sh sk sl

[Libreoffice] Updated artwork for RC

2010-11-29 Thread Thorsten Behrens
Hi, since we decided to label the next release RC1 (http://lists.freedesktop.org/archives/libreoffice/2010-November/003452.html), just updated our artwork from http://wiki.documentfoundation.org/File:LibreOffice-Initial-Artwork-Package.zip (differences: removed "beta" text, text / paper is visual

Re: [Libreoffice] Updated artwork for RC

2010-11-29 Thread Thorsten Behrens
Hi Chris, you wrote: > Just to be sure - did you also update the position of the progress bars? > Yep. > And, looking at the files list below, it seems that the original > filenames (picked from the OOo UI project) changed a bit. Would it be > helpful to rename the icons within the artwork packa

Re: [Libreoffice] [UX] LO status bar annoyances

2010-11-30 Thread Thorsten Behrens
Sebastian Spaeth wrote: > Am I the only one finding the current status bar pretty much useless? > Nope. I hear you, pretty much unconditionally. Adding UX tag & Cc-ing my favourite UX homie. :) Cheers, -- Thorsten pgphW56AvlvY5.pgp Description: PGP signature ___

Re: [Libreoffice] [UX] LO status bar annoyances

2010-11-30 Thread Thorsten Behrens
Kohei Yoshida wrote: > > b) We warn when closing a modified doc anyway, so there is no need to > > always warn me and use up precious space. I propose to just do away > > with it. > > Sorry I have to disagree there. I'm the one who put that icon there, > and the reason for that was to

Re: [Libreoffice] Script to find undocumented classes

2010-11-30 Thread Thorsten Behrens
Miklos Vajna wrote: > Does the idea sounds sane, OK to push? > Totally! Would you maybe also be interested to work on an improved start page / index, e.g. like this here: http://www.informatik.uni-hamburg.de/~meine/hg/vigra/file/bf402d01f821/docsrc/index.dxx (see http://www.informatik.uni-hambur

Re: [Libreoffice] Script to find undocumented classes

2010-11-30 Thread Thorsten Behrens
Lubos Lunak wrote: > On Tuesday 30 of November 2010, Thorsten Behrens wrote: > > Additionally, I think most classes don't necessarily need detailed > > docs for all methods in the first place (which may also hurt later > > merging from OOo), but would already benefit fr

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Thorsten Behrens
Sebastian Spaeth wrote: > What does bFull mean? Not so quick? What portions will be formatted if > this is FALSE? Looking at the function it either calls > pImpEditEngine->FormatFullDoc(); > or > pImpEditEngine->FormatDoc(); > > What the heck is the difference between those functions? Now I h

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Thorsten Behrens
Lubos Lunak wrote: > See? So nobody actually knows what the code really does, and everytime > somebody changes something there, they possibly have a slightly different > understanding of the purpose, resulting in even bigger mess. That's yet > another advantage of documentation - even you yours

Re: [Libreoffice] Attention: The changes to the build system are about to be pushed....

2010-12-01 Thread Thorsten Behrens
Caolan McNamara wrote: > What's the situation with the l10n module ? i.e. If someeone does a > ./autogen --with-lang="something that isn't en_US" > something somewhere should clone l10n as well. > Fix for that on my disk, preempted by other things, and was pointed to bin/repo-list, which I need t

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-01 Thread Thorsten Behrens
surensp...@gmail.com wrote: > After few sleepless nights spent grokking and with quite a big deal > help from IRC and the list, have come up with the first cuts working > version of the External Edit functionality[1]. Have attached the > patches rebased against the latest master. > Hi Suren, I had

Re: [Libreoffice] Script to find undocumented classes

2010-12-02 Thread Thorsten Behrens
Hi Lubos, you wrote: > I'm not asking for anything ridiculous like having a paragraph > explaining every line, I'm saying that everything non-trivial > should have at least some documentation > Good, then we're mostly on the same page. Then we're both talking about mission statements, higher-level

Re: [Libreoffice] [PUSHED] patch review for commit 67be5829944758dec070710521cd86ae49e00aa9

2010-12-02 Thread Thorsten Behrens
Radek Doulík wrote: > would you please review my patch in vcl/source/canvastools? I would like > to push it to 3-3 branch. > Done, thanks for that fix - nasty temporary of a temporary bug. Signed-off & pushed. Cheers, -- Thorsten pgpq0Y33Rt6xE.pgp Description: PGP signature ___

Re: [Libreoffice] [PUSHED] patch review for commit 67be5829944758dec070710521cd86ae49e00aa9

2010-12-02 Thread Thorsten Behrens
Radek Doulík wrote: > would you please review my patch in vcl/source/canvastools? I would like > to push it to 3-3 branch. > Done, thanks for that fix - nasty temporary of a temporary bug. Signed-off & pushed. Cheers, -- Thorsten pgpV2bJa5WSSs.pgp Description: PGP signature ___

Re: [Libreoffice] [PUSHED] Clean code at impress

2010-12-02 Thread Thorsten Behrens
Kayo Hamid wrote: > Covering impress/animations/source/animcore/ and > impress/sd/source/core/*, sending for review. > Hi Kayo, many thanks, looks good, committed - two minor tweaks: turned the first XCommend... hunk into a better comment, and did not remove the inbetween parts of sd/source/core/

Re: [Libreoffice] [For Review] --enable-opengl impact on MacOS build (and other platform)

2010-12-03 Thread Thorsten Behrens
Norbert Thiebaud wrote: > --with-openl is now on be default for MacOS in the bootstrap > configure.in. This actually break on MacOS. > There is a patch in dev300/. that seems to address this problem. The > attach patches integrate this patch. > > Since I have no expertise in this part of the code

Re: [Libreoffice] defaulting to --without-java ... (?)

2010-12-03 Thread Thorsten Behrens
Kálmán „KAMI” Szalai wrote: > I agree. However can we see what we lose with java enabled builds > (diskspace, performance, startup time)? > Random facts - here, java-1_6_0-sun-1.6.0.u22 is a major offender in powertop, with apparently some GC timer running very frequently. Cheers, -- Thorsten

Re: [Libreoffice] Script to find undocumented classes

2010-12-03 Thread Thorsten Behrens
Jan Holesovsky wrote: > As a conclusion, what about to combine Miklos' check for the missing > documentation with a commit hook, so that it does not allow you to > commit _new_ files without (at least the high level) documentation? ;-) > Hi Kendy, I find it surprising me actually saying this, but

[Libreoffice] Fix for fdo#31243 needs review

2010-12-03 Thread Thorsten Behrens
Hi Caolan, took your patch, handled one more case - could you please review & commit to libreoffice-3-3 if ok? Cheers, -- Thorsten From 25ae4e3bf1632150aa54769ed5b3235cbfa2af2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Fri, 3 Dec 2010 11:15:24 +0100 Subject: [PATCH

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-03 Thread Thorsten Behrens
surensp...@gmail.com wrote: > I shall touch base with you on the IRC and will implement all the > tweaks as you suggest. If there are any best practices wiki link, > please guide me to that :) > > > There are one or two other things that could benefit from looking > > into, e.g. the usage of the w

Re: [Libreoffice] Script to find undocumented classes

2010-12-03 Thread Thorsten Behrens
Jan Holesovsky wrote: > As to the crossing the line - the first time it won't let you commit, > and you'll be angry, the second time it won't let you commit, and you'll > just fix that, and the third time you'll comment just naturally, and > won't even hit the check :-) This worked with the warnin

Re: [Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing

2010-12-03 Thread Thorsten Behrens
Petr Mladek wrote: > libreoffice-3-3 git branch is still opened for fixes. Just please, send > your patches for review to this mailing list before you commit. You > might ask a particular person for review via CC or on the irc channel > #libreoffice. > Hi Petr, all, it would then be nice if the r

Re: [Libreoffice] de-emphasisig java ... - summary so far ...

2010-12-05 Thread Thorsten Behrens
Christian Lohmaier wrote: > But it is more than clear that those users will then get the "This > function requires a JRE" notification. This hasn't been a problem in > OOo-land, so why should it be a problem for LO? > Because the default OOo install does include a JRE. Otherwise, I'm rather indiff

Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?

2010-12-05 Thread Thorsten Behrens
Caolan McNamara wrote: > IIRC I tried this before, and there was some cockup under MacOSX, so if > someone on MacOSX could see what findhome says and if its correct/wrong > vs what works correctly there, that'd be helpful. > About 4k miles away from my MacBook currently - Norbert, Cloph, any chanc

Re: [Libreoffice] README translation for 3.3

2010-12-10 Thread Thorsten Behrens
Andras Timar wrote: > By the way, README was updated several times lately but it was not > offered for localization. The extra lo-build.sdf/.pot does not contain > these new/changed strings. I think if we had everything updated, these > issues would be resolved automatically. > Hi Andras, so that

Re: [Libreoffice] Build environment MacOSX - autoconf / automake version problems

2010-12-10 Thread Thorsten Behrens
Alexander Thurgood wrote: > to getting the build environment up and running on my Mac OSX Snow > Leopard, but I've hit a snag with automake. When I go to configure > automake 1.11.1, I get this error message and obviously configure bombs > out : > > configure: error: Autoconf 2.61a-341 or better i

Re: [Libreoffice] pdf import extention

2010-12-13 Thread Thorsten Behrens
Lior Kaplan wrote: > Could we import changes made in the PDF import extension ? > > See http://hg.services.openoffice.org/cws/pdfextfix04 > Yep, makes sense - if someone could second this, I'll commit it to -3-3. Cheers, -- Thorsten pgpe1Z2XnBMLJ.pgp Description: PGP signature

Re: [Libreoffice] [PUSHED] Grey as default color for native tables in Impress

2010-12-13 Thread Thorsten Behrens
camille wrote: > Please find attached a tentative patch for my own Easy Hack described > below. > Thanks camille, looks good & is a sensible approach. Committed to -3-3. Keep the patches coming! :) Cheers, -- Thorsten pgpd77dGGctLp.pgp Description: PGP signature __

Re: [Libreoffice] Feature list for upcoming version

2010-12-13 Thread Thorsten Behrens
Marc Paré wrote: > I'm helping out with the "Features list" for the upcoming > LibreOffice v. 3.3 as found on this page: > http://wiki.documentfoundation.org/Marketing/LibOReleaseEvents/LOPressKit/FeatureList3.3 > . Sophie was kind enough to help with the initial list. Is there a > place where a l

Re: [Libreoffice] Feature list for upcoming version

2010-12-13 Thread Thorsten Behrens
Marc Paré wrote: > I'm helping out with the "Features list" for the upcoming > LibreOffice v. 3.3 as found on this page: > http://wiki.documentfoundation.org/Marketing/LibOReleaseEvents/LOPressKit/FeatureList3.3 > . Sophie was kind enough to help with the initial list. Is there a > place where a l

Re: [Libreoffice] De-Java-ise flat XML export

2010-12-14 Thread Thorsten Behrens
Michael Meeks wrote: > Riight; interesting. Ultimately XSLT requires a DOM to operate on, so I > suppose if we get SAX events from OO.o, we will need to map these to > libxml's nodes. > > I believe we already have code to do this in > xmlsecurity/source/xmlsec/saxhelper.cxx / .hxx - wh

[Libreoffice] Fix for pdfimport (fdo#32330) needs review

2010-12-14 Thread Thorsten Behrens
Hi, could someone quickly review attached patch - a fairly safe fix I'd like to include in -3-3, since it quite spectacularly break graphics on PDF import. Thanks, -- Thorsten From e455af833b31e3d5e8f7fa32a24ea44e53126baa Mon Sep 17 00:00:00 2001 From: Thorsten Behrens Date: Wed, 15 Dec

Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes

2010-12-15 Thread Thorsten Behrens
Jan Holesovsky wrote: > impress > Reviewed & cherry-picked the i#107568 fixes Cheers, -- Thorsten pgpLzIalt3kyB.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] hsqldb update

2010-12-15 Thread Thorsten Behrens
Rene Engelhard wrote: > On Tue, Dec 14, 2010 at 11:13:28PM +, Wols Lists wrote: > > > Version 2.0 has been out there for quite some time, 2.0.1 is well on the > > > way and as the website > > > states, the new version is much improved on various ends. > > The problem is that the file format

Re: [Libreoffice] Build on MacOSX fails in soltools/mkdepend

2010-12-15 Thread Thorsten Behrens
Alexander Thurgood wrote: > Hopefully someone can help out here. I've been attempting my first build > on MacOSX and the build fails in soltools trying to make mdepend : > > ../unxmacxi.pro/misc/make_makedepend.makedepend_1.cmd: line 1: -n: > command not found > dmake: Error code 127, while makin

Re: [Libreoffice] Mac OSX build fails in jurt, jvmaccess, jvmfwk

2010-12-15 Thread Thorsten Behrens
Alexander Thurgood wrote: > > From the errors produced in jvmaccess, it looks like something has > > happened to classpath.cxx and classpath.hxx. Virtually every line gives > > an error. > > > Same with jurt and jvmfwk. > Hi Alex, best join #libreoffice irc on freenode.net - either there are kink

Re: [Libreoffice] minutes of tech steering call ...

2010-12-15 Thread Thorsten Behrens
Jan Holesovsky wrote: > Actually, I still might have the cvs -> git import I did 2-3 years back > that tracked all the branches, and also marked the integration commits > as merges; if there'd be more demand for that, I could try to resurrect > that for the history digging purposes ;-) > If you ha

Re: [Libreoffice] Python API and Danny.O00

2010-12-16 Thread Thorsten Behrens
Peter Morgan wrote: > import LibreOffice as LO > > spread_full_path = "/jobs/%s/my_calc_spread_sheet.odf" % JOB.job_id # > whatever extension > > spreadMe = LO.open(spread_full_path) > > mySheet = spreadMe.sheet("foo", create=True) # create's if not exist, > otherwise error > > mySheet.append(

Re: [Libreoffice] segfault in libqa_unit.so test

2010-12-16 Thread Thorsten Behrens
Michael Meeks wrote: > > -- > > - start unit test #1 on library ../../unxbsdx3.pro/lib/libqa_unit.so > > -- > > So - I would cut/paste the command-line; export the LD_LIBRARY_PATH

Re: [Libreoffice] The download link still shows Beta?

2010-12-16 Thread Thorsten Behrens
Yi Fan Jiang wrote: > The links here looks a bit strange with 'Beta' while we have been in RC phase > for some while: > > http://www.documentfoundation.org/download/ > > The word seems embedded in the picture...(from css) > Hi Yifan, yep, good catch, this was reported as https://bugs.freedeskt

[Libreoffice] [PATCH] Correct credits url to website conventions

2010-12-16 Thread Thorsten Behrens
Hi, Florian mentions website conventions are that non-localized content lives under www.libreoffice - attached trivial patch changes that for the credits link, and would need -3-3 review. Thanks, -- Thorsten From 7a85ae06141ab1ec70a63928d593ac51314de33b Mon Sep 17 00:00:00 2001 From: Thorsten

Re: [Libreoffice] backport bad copy ctor fix, missing slide color transitions to 3.3

2010-12-18 Thread Thorsten Behrens
into 3.3, what do you think ? > Hi Caolan, good catch - indeed. But I'd suggest attached patch, both methods are just fine when auto-generated by the compiler. Cheers, -- Thorsten From 35a6e32b9edfea1a9bb390d8e3046a9267acd05f Mon Sep 17 00:00:00 2001 From: Thorsten Behrens Date: Sat,

[Libreoffice] [PATCH] Quick-fixing dbgutil sc build breakage

2010-12-21 Thread Thorsten Behrens
Hey there, just removed some assertions I believe are relicts - but didn't look _too_ closely. Kohei, could you have a quick look please? Thanks, -- Thorsten From aaf478ce3619db18ff0f6e8dee44e5a200b0a0d5 Mon Sep 17 00:00:00 2001 From: Thorsten Behrens Date: Tue, 21 Dec 2010 21:49:00

Re: [Libreoffice] [PUSHED] Change of the color of the watermark at the pdfexport

2010-12-21 Thread Thorsten Behrens
Andreas Mantke wrote: > there is a new option inside the code of the pdfexport of LO/OOo, which sets > a > watermark on the exported document. This watermark is currently red. This is > a bit > uggly and I think a light green matches better to LO. > Beautiful, pushed - congrats, your first code

Re: [Libreoffice] pdf import extention

2010-12-23 Thread Thorsten Behrens
Lior Kaplan wrote: > Sorry for nagging, but I'm interested in seeing these fixes in LibO 3.3. > > Could you integrate http://hg.services.openoffice.org/cws/pdfextfix04 ? > Hi Lior, yes, I know - but this fix needs somewhat deeper changes in vcl (a text mirroring service), which I sadly did not

Re: [Libreoffice] rc2 only partially uploaded - many languagepacks missing

2010-12-23 Thread Thorsten Behrens
Christian Lohmaier wrote: > it seems the upload process was interrupted and thus lots of files > didn't make it to the mirror network. > > http://download.documentfoundation.org/libreoffice/testing/3.3.0-rc2/deb/x86_64/ > - languagepacks only up to "lo" > > Please restart the upload (and if possi

  1   2   3   4   5   6   7   8   9   10   >