On Thu, 2010-10-07 at 17:18 +0300, Harri Pitkänen wrote:
This patch closes a file that would be left open if memory allocation fails.
The cppcheck error was [profile.c:248]: (error) Memory leak: pFile
Harri
Thanks for the nice patch, looked good to me, pushed
regards,
Noel
On Thu, 2010-10-07 at 10:28 -0400, Kohei Yoshida wrote:
Having said that, once we remove this, it won't be easy to add it
back.
So I'd personally like to be a bit careful on making decision here.
For
example, can anybody provide any arguments for keeping the current
behavior?
No, +1 for
Hi Ruben,
Thanks for hacking LibreOffice and thanks for the patch, it's mostly
committed,
On Sun, 2010-10-10 at 13:10 +0200, Rubén Jáñez wrote:
This patch removes bogus comments found in Base.
just be careful of removing any comment that reference openoffice
issuezilla bugs ( there is useful
Hi Alan
On Sun, 2010-10-10 at 15:29 -0700, Alan Du wrote:
I've deleted some pointless comments in two files here. The git diff
is attached
Contributed under LGPLv3+
Thanks for the patch but what is the full path to the files the patch is
addressing?, for the life of me I can't find any module
On Mon, 2010-10-11 at 14:58 +0200, Sebastian Spaeth wrote:
I guess a comment with. fixed in LibreOffice commit:
CGIT URI
should not be perceived as a dirty trick. Rather it points OOo
developers to a possible solution that they can use for inspiration of
how to fix a bug.
I am just
Hi Thorsten
On Tue, 2010-10-12 at 03:40 +0200, Thorsten Behrens wrote:
Hi,
Mechtilde thankfully reported a problem with old OOo 2.x user
installations, which get migrated over to LibreOffice automatically
- problem is, the OOo code we inherit here has several bugs.
Aha, coincidentally I was
On Tue, 2010-10-12 at 15:07 +0100, Michael Meeks wrote:
Would it be possible to add a non-modal / floating / dialog to
prompt
users to migrate / import their macros from an old version if it
hasn't
been previously imported, and we know that they have really been
editing / changing
On 18/10/10 14:06, Povilas Kanapickas wrote:
Hello,
I've done some work on entry level tasks. Specifically, I've removed
all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus
comments like /*N*/, /*?*/ and so on were removed. As more than
thousand of files have been changed
sending again :/
On 18/10/10 14:06, Povilas Kanapickas wrote:
Hello,
I've done some work on entry level tasks. Specifically, I've removed
all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus
comments like /*N*/, /*?*/ and so on were removed. As more than
thousand of files
On 20/10/10 14:39, Jean-Etienne SIX wrote:
Hello
I'm testing libo beta2 + langpack fr under linux(slax) without jre
get Erreur d'exécution BASIC
message : the external file picker does not run
works fine under windows
happy if you can help
what exact steps do you do? can you give some more
On 25/10/10 16:49, René Kjellerup wrote:
finally had time (although not to complete another build) to run the
test again,
the procedure I did was:
Tools-Macros-Organize macros-basic
select Main and click on the Edit button
I've attached the back-trace of the crash
René
That stack looks
Just a quick question as whether anyone tried this with beta2 ( on linux
) on opensuse11.2
I tried and failed to insert a movie ( ogg format ) in a presentation.
It failed reporting errors ala format of selected file is unsupported
etc. Since I have a somewhat dirty installation ( in terms of
On 27/10/10 15:15, Noel Power wrote:
Just a quick question as whether anyone tried this with beta2 ( on
linux ) on opensuse11.2
opensuse11.3 ( I meant )
I
Hi Peter,
On Tue, 2010-11-02 at 21:19 -0300, Peter Burtt wrote:
The cygwin SETUP.EXE accepts a comma-delimited list of packages to
install. To install cygwin and the packages listed as prerequisites on
On Tue, 2010-11-02 at 10:34 -0400, Kohei Yoshida wrote:
On Tue, 2010-11-02 at 09:45 +, Caolán McNamara wrote:
On Mon, 2010-11-01 at 22:27 -0400, Kohei Yoshida wrote:
Hello Joost,
Thanks for the patch. Just pushed to the master branch. :-)
Nothing to do with the patch, but I
On Wed, 2010-11-03 at 21:47 -0700, John LeMoyne Castle wrote:
Adds '=' to edge test in sbxscan.cxx ImpCvtNum so exponent prints and 1
million is 1e+6 instead of just 1 for singles.
Same one char change does similar fix for OO Basic doubles and 1e+14.
When I saw #i76852# --
On Wed, 2010-11-03 at 21:47 -0700, John LeMoyne Castle wrote:
thanks for the cool patch!!
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Fri, 2010-11-05 at 18:13 -0700, John LeMoyne Castle wrote:
Hi all,
[...]
Still new to git but I am sure I saw and built and ran the old txtedt.cxx
and still no LSQEW. Feelin' a bit lost ... I can think of some other
options for trying to find what fixed the LSQEW but I feel like I'm
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote:
Noel Power wrote:
I wonder if the recent rebase to OOO330m13 is the culprit, would be
interesting if you could test against the corresponding oracle dev build
Yes, I see that test would be useful.
Not about to setup
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote:
Noel Power wrote:
I wonder if the recent rebase to OOO330m13 is the culprit, would be
interesting if you could test against the corresponding oracle dev build
Yes, I see that test would be useful.
Not about to setup
On Thu, 2010-11-11 at 11:23 +0100, Rene Engelhard wrote:
On Thu, Nov 11, 2010 at 05:55:44PM +0800, David Nelson wrote:
I'm just giving you a heads-up because I was contacted by�Jason Warner of
Canonical ([1]jason.war...@canonical.com�and�jasoncwarner on Freenode)
And because of this
On Thu, 2010-11-18 at 09:30 +, Caolán McNamara wrote:
On Thu, 2010-11-18 at 00:17 +0100, Miklos Vajna wrote:
On Wed, Nov 17, 2010 at 04:44:19PM +, Caolán McNamara
caol...@redhat.com wrote:
print dbg_dump(string)
[...]
Without checking myself, are those pu macros horrifically slow
On Thu, 2010-11-18 at 13:01 +0100, David Tardon wrote:
Hi all,
currently, configuring with --enable-debug means that dbglevel is set to
2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables
all the OSL_ debugging stuff there is (well, maybe there is some really
rare stuff
On Tue, 2010-11-23 at 23:51 +0100, Joost Eekhoorn wrote:
Hi,
I had a problem in writerfilter, building without DEBUG.
I did some local hack with #undef, to get it building again.
[...]
I fixed a bug in this area, should be good now
thanks,
Noel
sending again ( whilst attempting to preserve the threading this time )
On Tue, 2010-11-30 at 01:35 -0800, John LeMoyne Castle wrote:
OOo Basic has had issues with its fixed point Currency type for a long
time.
I think the Basic Currency type deficiencies create a bar to adoption
in the
minds
Hi Kenneth,
thanks for the patch, perfect as far as I could see so it is pushed
thanks,
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Sun, 2010-12-05 at 23:28 +0200, Lior Kaplan wrote:
Hi,
Can any one look at the small patch attached to
http://www.openoffice.org/issues/show_bug.cgi?id=115495
It would be nice to have this fixed in LibO 3.3, as this annoys a lot
of users of the the RTL languages.
Thanks
Kaplan
Hi John,
On Tue, 2010-11-30 at 04:22 -0700, Noel Power wrote:
Main patch makes 1/2 kLOC reduction in sbx.
yeah, so you will have to give me some time to look at this ( not really
familar with the Currently type ) and I need to somehow filter out the
whitespace changes too ( probably I can
Hi Kayo
On Sun, 2010-12-05 at 14:37 -0800, Kayo Hamid wrote:
Sending for review, cover sd/slideshow/*
revol_
Pushed, I didn't commit the changes to
slideshow/source/engine/sp_debug.cxx as I find those comment telling
what #ifdef the #endif closes very useful. Thanks muchly for the nice
Hi Julien
On 06/12/10 21:40, Julien Nabet wrote:
Hello,
Here's a small patch for dbaccess/source/ui/dlg
This is a strange one, it seems SERVICE_UI_FOLDERPICKER is not a simple
const char but an instance of ConstAsciiString ( defined in
dbaccess/source/inc/constasciistring.hxx ) so I changed
Hi Mattias/Michael
On 08/12/10 11:20, Michael Meeks wrote:
Having said that, this really doesn't seem ideal. I wonder what the
compatibility impact of changing it would be [ a chestnut for Noel to
consider I suspect ].
From the basic point of view as Mattias says ( and afaics ) this
On 08/12/10 16:22, Noel Power wrote:
For this patch I am not familiar with the writer bits involved, so I
am not sure if there would be some side-affects. Personally I'd like
to understand why the explict check in the output doesn't get
applied in this case, I'll at least try and see where
Hi John,
On 06/12/10 17:58, Noel Power wrote:
Hi John,
[...]
in sbxToUnoValueImpl ( convert to uno without known target class ) in
basic/source/classes/sbunoobj.cxx previously an Double or Float basic
value ( within the range of an int ) was transfered as a the smallest
type e.g. sal_Int8
On 14/12/10 20:19, Jan Holesovsky wrote:
Hi,
I wanted to merge the m18 changes today, but looking at the diff, it is
not that trivial, and I don't feel like the right person reviewing it
according to our post-RC criteria; so I'd like to ask you to review it.
Best if you can merge/cherry-pick
On 22/12/10 10:13, Tor Lillqvist wrote:
It seems that this patch is now in master, and it causes compilation errors on
Windows (slightly edited compiler messages for brevity):
sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier
sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member
On 22/12/10 02:23, Balachandran Sivakumar wrote:
call of overloaded 'append(char)' is ambiguous
Hmm I never got that error but happily it seems Joseph Powers commited a
fix for that, try pull and rebuild.
thanks,
Noel
___
LibreOffice mailing list
On 21/10/11 04:19, August Sodora wrote:
I came across this feature request today and decided to try my hand at
it. Is the attached patch an appropriate solution?
seems like a nice patch :-). From the basic side of things , all seems
fine, if Kohei is happy with the calc parts then I see no
On 21/10/11 16:04, Michael Meeks wrote:
Hi August,
Well - of course, it'd be nice to have some more complex tests of
StarBasic (and VBA) macros, potentially loaded from .bas files inside a
unit test.
Noel - do you have any really nasty syntax / built-in basic
functionality
there were at least a few people trying to make this a blocker for 3.4 ( makes
ole automation quite broken ), the fix on master I would like to backport is
here
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fcb94311fd7dd40c05ca132e3a30a888316cbbe
Noel
On 26/10/11 20:26, Michael Meeks wrote:
The code is similarly opaque to me :-) if you're happy it is tested and
works I don't know that we'll find any more competent reviewers. It is
slightly concerning to me that this method has seemingly been using a
SAFEARRAY since 2000:
SAFEARRAY is
On 26/10/11 20:43, Noel Power wrote:
type of a variant containing a SAFEARRAY is set to VT_VARIANT
regardless of the type of the SAFEARRAY
meant to say SAFEARRAY is set to array of VT_VARIANT e.g. ( VT_ARRAY |
VT_VARIANT )
___
LibreOffice mailing
I've commited this to 3.4
http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4id=ab802aee181ca6df397ca53e461d5f53808cef9d
and like the subject says. one more needed for 3.4.4
Noel
___
LibreOffice mailing list
On 27/10/11 17:40, Harri Pitkänen wrote:
the patch looks fine, builds etc., not entirely sure about some of the
mode removal stuff. But, since you have previously contributed html
filter related stuff I assume you have a better idea than me. Hopefully
if there are any additional concerns
On 27/10/11 22:04, Terrence Enger wrote:
I offer the attached patch under LGPLv3+/MPL1.1 dual license
or future versions of the licenses,
It fixes a leak of connection handle in an ODBC database.
Without the call to SQLDisconnect90, SQLFreeHandle() fails
with code 'HY010'.
This is my first
On 28/10/11 10:18, Noel Power wrote:
On 27/10/11 22:04, Terrence Enger wrote:
This is my first attempt a patch. Comments and guidance
welcome.
just fyi, I did an additional commit to do a minor tweak changing the
OSL_TRACE messages into OSL_ENSURE messages. Nothing wrong
On 27/10/11 20:31, August Sodora wrote:
Hello all,
I have been trying to add support for assigning to named ranges in
VBA. There are a couple of ways VBA does this but for now I'm focusing
on something like:
Range(A1:H8).Name = TestRange
Currently the Name property on [X/ScVba]Range is
On 28/10/11 14:21, Terrence Enger wrote:
Noel,
I am sorry for a long response to an innocent-looking
message, but a man's gotta do what a man's gotta do.
[...]
As it happens, the leak was indeed the result of a program
error: the program was not calling SQLDisconnect. But the
ODBC functions
fix is here
http://cgit.freedesktop.org/libreoffice/core/commit/?id=991aa4fff785612bad7281f4948f5771bf8d215a
and is pretty trivial
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 10/11/11 11:10, Michael Meeks wrote:
Hi Noel,
On Wed, 2011-11-09 at 18:28 +, Noel Power wrote:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=991aa4fff785612bad7281f4948f5771bf8d215a
It'd be great to reference the public bug in the commit msg ;-) Anyhow
- I've pushed
Hi
We have an internal bug that happens when closing the application where
there is a legacy format document ( e.g. something.sdd ) already open
I get the following trace
==23824== Invalid read of size 8
==23824==at 0x10C543A0: GtkSalDisplay::EventGuardAcquire()
(gtkdata.hxx:83)
On 10/11/11 16:14, Julien Chaffraix wrote:
Very straightforward change attached.
The change is contributed under the LGPLv3+ / MPL.
very nice, pushed, thanks alot
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 10/11/11 16:15, Julien Chaffraix wrote:
Another simple change attached.
The change is contributed under the LGPLv3+ / MPL.
and builds fine for me, pushed, thanks again
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 11/11/11 08:06, Winfried Donkers wrote:
First tiny contribution.
Translated comments, also renamed define MAX_COL_HEIGHT to MAX_ROW_HEIGHT.
This patch is and future patches will be contributed under the LGPLv3+
/ MPL.
Erm, I think the attached patch is not the intended one right ( patch
On 11/11/11 05:44, Karl Koehler wrote:
Hi,
investigating further I have come to the conclusion that the attached
( and previously inlined ) patch is correct, in the sense that regular
expressions of the failing type are now handled correctly.
e.g.
A[\[:\]]
should find an 'A' followed by one
On 11/11/11 13:32, Eike Rathke wrote:
now I see why my push failed appears you beat me to it
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 11/11/11 12:56, Winfried Donkers wrote:
(reply to list as well-together with attachment- is better, of course)
First tiny contribution.
Translated comments, also renamed define MAX_COL_HEIGHT to
MAX_ROW_HEIGHT.
Erm, I think the attached patch is not the intended one right ( patch
forgot to change the subject line to PUSHED, also the commit is here
http://cgit.freedesktop.org/libreoffice/core/commit/?id=98a10b638a645776d14049b8fb12a87b80b6eb3b
thanks,
Noel
On 11/11/11 15:02, Noel Power wrote:
On 11/11/11 12:56, Winfried Donkers wrote:
(reply to list as well-together
On 10/11/11 03:02, August Sodora wrote:
Hello,
I've attached a patch that attempts to add line numbers to the basic
ide. I believe it is mostly correct, although I am seeing a couple of
rendering issues that I haven't been able to track down yet. First,
the scrollbar seems to jump around and
On 11/11/11 16:09, Noel Power wrote:
On 10/11/11 03:02, August Sodora wrote:
Hello,
I've attached a patch that attempts to add line numbers to the basic
ide. I believe it is mostly correct, although I am seeing a couple of
rendering issues that I haven't been able to track down yet. First
On 11/11/11 16:30, August Sodora wrote:
There are a couple problems as you mention with this patch, however I do think that
this is *really* useful land certainly something that I would have liked to see at
times. However sometimes I think the line numbers can just be annoying ;-) so I
On 11/11/11 16:50, Noel Power wrote:
On 11/11/11 16:30, August Sodora wrote:
I'd love to but I'm not exactly sure how. Currently I have it as a
local branch.
haha, yes, well not being much of a git guru myself I can't recall
offhand what the command are for that, let me try and find out what
16:50, Noel Power wrote:
Of course I was looking at the stuff in cui for adding an option
somewhere, is that the correct place to be looking? Also I'm not sure
if the basic ide deserves its own entire category for options yet as I
think this is the first configurable thing about the basic ide.
I
(putting patch in subject )
Hi
We have an internal bug that happens when closing the application where
there is a legacy format document ( e.g. something.sdd ) already open
I get the following trace
==23824== Invalid read of size 8
==23824==at 0x10C543A0:
On 11/11/11 20:42, Michael Meeks wrote:
SvtMiscOptions aMiscOptions;
const bool bExperimentalMode = aMiscOptions.IsExperimentalMode();
Should get that for you to switch on; Noel - do you think that's
enough ?:-) or do you really want the setting for this so it can be
turned
On 12/11/11 12:45, Michael Meeks wrote:
Looks fine for the branch for me - any chance you could cherry-pick
it ?
committed with your sign-off ( and the additional piece you requested )
On 11/11/11 22:16, Chr. Rossmanith wrote:
Hi,
currently I'm removing the Fill() method for strings. Comments are
very welcome.
Christina
Thanks!! btw. I didn't get any errors in sc tests
Noel
___
LibreOffice mailing list
On 13/11/11 18:54, Matteo Casalin wrote:
Hi everybody,
my name's Matteo and this is my first contribution [attempt] to
this wonderful piece of work, besides spreading the word.
welcome !!
The attached patch does a little code cleanup in Docuview::DrawSymbol
function and its helper,
On 11/11/11 19:56, Noel Power wrote:
On 11/11/11 19:25, August Sodora wrote:
[...]
Also, is there a consensus on how
the option to hide/display line numbers should be added? Currently I'm
trying to add a page to the options dialog in cui but I suppose it
will really only have one option
On 14/11/11 17:17, Noel Power wrote:
ok, since let me try and help with this, I am trying to add the menu
and some supporting code to tie that in, when I have it done I hope
you can take the patch and look at dynamically displaying/undisplaying
the linenumbers. Perhaps as a start you could
On 14/11/11 15:49, Julien Chaffraix wrote:
Hi,
please find attached a patch to remove most of the unused functions in basic/.
The patch is contributed under the LGPLv3+ / MPL.
Surprised at some of the methods there :-) but I trust callcatcher..
builds for me, cursory testing of basic by
On 14/11/11 15:53, Julien Chaffraix wrote:
Hi everyone,
please find attached the removal of some of the unused icons. Make
sure you double-check that I did not miss some usage when grepping and
testing!
The PNG and code removals are squashed in this change, let me know if
you would like them
reverted the patch above ( and my subsequent patch ) as it appears a
build from clean fails ( or so the tinderbox(s) say )
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 15/11/11 15:16, Julien Chaffraix wrote:
some physical images removed here are
lx03139.png
sx03139.png
oth_16_8.png
oth_32_8.png
oth_48_8.png
these images are associated with SV_ICON_ID_HTML_DOCUMENT which according to
opengrok ( assuming it is correct ) isn't used in code.
however there are
On 15/11/11 16:55, Julien Chaffraix wrote:
[...]
I tried removing SV_ICON_ID_HTML_DOCUMENT because I also did not see
it during my grepping. However I would get some errors during make
dev-install about the missing icons (I don't have the error with me
sorry).
I think this was some side-affect
Hi Daisuke
On 15/11/11 11:26, Daisuke Nishino wrote:
Hi all,
In Math's inline editing, closing braces ( ')', ]', '}' ) are
literally inserted independent of the context.
This is not necessarily intuitive.
[...]
I fixed so that when you are at the tail of the brace and typed the
closing
On 16/11/11 13:35, Ivan Timofeev wrote:
Hi there,
I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) ,
but I think an additional review will not be superfluous, since I am
still a newbie.
The fact is SwDocShell::GetWrtShell() always returns 0 in page
preview. And Writer dies
On 16/11/11 19:59, Petr Mladek wrote:
I am surprised that anyone still uses it. The following two bugs makes
me feel that it does not work for LO-3.4 and master:
testtool should work ( afaik ) on 3.4 ( I thought I fixed it there ), of
course there may be some tests that somehow now don't work
On 17/11/11 06:45, Winfried Donkers wrote:
Some more translated files.
This and subsequent contributions submitted under LGPL3+ / MPL.
PUSHED with some minor changes, I just tweaked some spelling and
rephrased something here and there as I scanned the translations, since
I don't speak
On 16/11/11 19:12, Tim Hardeck wrote:
Hi,
[...]
This change should also have no influence on the user configuration
since these files are only relevant for the default settings.
true, so pushed, hopefully the new defaults will help
Noel
___
On 17/11/11 12:09, Niklas Johansson wrote:
Hi,
I did a small patch to fix
https://bugs.freedesktop.org/show_bug.cgi?id=40505
The patch fixes the issue with the reversed Right/Left arrow keys
without affecting
the Right/Left buttons in the dialog. It's a small fix were only to
lines of code
Hi August,
On 17/11/11 16:52, August Sodora wrote:
a minor fix ) So, what I suggest is to mail the patch to me/list and I will
test/integrate it ( already I fear some manual merging will be necessary as
Everything is pushed to the branch feature/line-numbers-in-basicIDE.
I have added a
Hi
On 19/11/11 00:39, Jan Holesovsky wrote:
Hi Niklas,
[...]
Thank you very much for the patch, great! :-) Please can you confirm
that it is under our preferred license combo, LGPLv3+ / MPL?
it is :-), see https://bugs.freedesktop.org/show_bug.cgi?id=40505#c5
Ideally in
the form This and
On 23/11/11 04:41, Kohei Yoshida wrote:
Hi there,
So, not having been able to build master on Windows for almost 2
months, I've decided to give it another go. But it fails in scripting
this time, and I have no clue.
The build log is attached. Hopefully this will ring a bell for someone...
On 23/11/11 09:27, Noel Power wrote:
in my case a (full) clean build solved it
has to be said this was on linux though
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Am I missing some magic incantation ? haven't built on windows forever,
the build fails with nss, it just refuses to build for me ( attached is
build log and autogen.lastrun ) There are some errors in the config from
nss to do with phtreads but not sure if this is normal or not, or if
this is
On 28/11/11 11:46, Andras Timar wrote:
[...]
--with-mozilla-build=/cygdrive/c/mozilla-build/
For me it is
--with-mozilla-build=c:/mozilla-build
Give it a try, because your build system does not find nsinstall.exe
and it is possible, that this is the root cause.
unfortunately that wasn't it,
Hi Maxime,
On 09/12/11 15:24, Kohei Yoshida wrote:
Hello Maxime,
On Fri, 2011-12-09 at 16:12 +0100, Maxime de Roucy wrote:
Hello
I have been ask to add the possibility to add a carriage return in a
cell via Ctrl+Enter in the formula bar (like when I directly edit the
cell).
I think Noel
On 12/12/11 14:39, Maxime de Roucy wrote:
Hi
I checked with a recent master build on Archlinux and it works
perfectly :-).
I also checked with the 3.5 beta on Windows XP but the behaviour of Ctrl
+Enter changed. Now it switch the auto-wrap mode.
I don't know if it's normal or not ...
It is
Andrew,
Apologies for the late reply, just back from vacation and now trying to
chip away at the mountain of mail backlog
On 01/01/12 16:01, Andrew Douglas Pitonyak wrote:
Thanks for checking Will wait and see what Noel has to say...
I say I don't know :-)
hmm I think I dropped the ball
On 06/01/12 21:39, Andrew Douglas Pitonyak wrote:
Off hand, I might be inclined to simply move the code back to its
original location, which would set the behavior back to letting math
with dates return dates, rather than just specific operations (which
is not even supported now).
yeah I
Be good to get this in, afaict this shouldn't cause any problems
see attached patch
Noel
From 778c2ad1225ee3d1e9ac40ab584d8f5f428845fe Mon Sep 17 00:00:00 2001
From: Noel Power noel.po...@novell.com
Date: Thu, 12 Jan 2012 15:46:52 +
Subject: [PATCH] restore special DATE handling code
On 12/01/12 22:27, Michael Stahl wrote:
looking at the change, i notice that now it is independent of the
operation being performed, while the code that was originally removed
in adcba12537d047f5ad65334b65512615311cf872 checked for addition only
(as the comment says):
-//
Hi Guys,
We have a bug here in the suse system that highlights a regression
attempting to resolve a range by name. Note: this is not a problem on
master.
the failing macro code is something like so;
Sub test
ProjectPlanSheet = ThisComponent.Sheets.getByName( ProjectPlan )
On 16/01/12 10:17, Michael Meeks wrote:
On Sun, 2012-01-15 at 13:04 +0100, Stefan Knorr (Astron) wrote:
Finally done that, it was easier than I thought, too. Just had to
change another help makefile ... actually reading make's error
messages does help.
Lovely :-) - strangely I still
On 16/01/12 13:48, Stefan Knorr (Astron) wrote:
Anyway, I just moved these icons over:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=75e3bffa1006eeb91324eaeabd52182d25b28711
I would have gladly moved them myself ( with the info ) but grateful
that you did it for me :-)
thanks again,
Hi Eike,
On 16/01/12 13:01, Eike Rathke wrote:
Hi Noel, On Friday, 2012-01-13 09:51:33 +, Noel Power wrote:
this change ( the variant ) is what is on master, here the intention
is as Andrew pointed out ( in a previous mail discussing the
regression ) to allow operations on date types
On 16/01/12 16:59, Eike Rathke wrote:
b) not so risky ( I think ), and... would change the present
behaviour in consistent way for treatment of minus operator
-if( GetType() == SbxDATE || rOp.GetType() == SbxDATE )
+if( ( eOp == SbxPLUS || eOp ==
Hi Markus
On 13/01/12 18:27, Markus Mohrhard wrote:
I think it makes sense to remove the findByName and replace them with
findByUpperName. The findByName is error-prone and therefore I removed
it for 3-5, internally we only use upper name (and in 3.5 we use it
even to store the range name). I
Hi Andrew,
My primary concerns
1. Change in behavior that may break existing code.
the intent of the patch is to restore the previous behaviour ( by
previous behaviour I mean before integration of the feature that
erroneously removed the 'special' processing for '+' for dates ).
On 20/01/12 13:40, Andrew Douglas Pitonyak wrote:
On 01/20/2012 06:32 AM, Noel Power wrote:
note there is a mistake in the table below
[*] table of behaviour in vba, pre the bug being introduced and post
patch
msoold behaviour present
1 - 100 of 1331 matches
Mail list logo
