Re: [libvirt] [PATCH v2 06/25] API: Add domain job operation for backups

On 12/3/19 11:17 AM, Peter Krempa wrote: Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation. Signed-off-by: Peter Krempa --- include/libvirt/libvirt-domain.h | 1 + tools/virsh-domain.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by:

Re: [libvirt] [PATCH v2 01/25] qemu: domain: Export qemuDomainGetImageIds

On 12/3/19 11:17 AM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [libvirt] [PATCH 2/2] Add -mem-shared option

On Tue, Dec 03, 2019 at 09:56:15AM +0100, Thomas Huth wrote: > On 02/12/2019 22.00, Eduardo Habkost wrote: > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: > >> On Fri, 29 Nov 2019 18:46:12 +0100 > >> Paolo Bonzini wrote: > >> > >>> On 29/11/19 13:16, Igor Mammedov wrote: >

Re: [libvirt] [PATCH] tests: stop linking virt tests to secondary drivers

On 12/3/19 12:30 PM, Daniel P. Berrangé wrote: The hard dependancy between the virt drivers and the network or storage drivers was removed quite a while back now, so the tests no longer need to link to these drivers. Signed-off-by: Daniel P. Berrangé --- Reviewed-by: Laine Stump --

Re: [libvirt] [PATCH] maint: Post-release version bump to 5.11.0

On 12/3/19 1:35 AM, Peter Krempa wrote: > On Tue, Dec 03, 2019 at 04:24:59 +, Jim Fehlig wrote: >> Signed-off-by: Jim Fehlig >> --- >> >> Pushing under the trivial rule. >> >> configure.ac | 2 +- >> docs/news.xml | 8 >> 2 files changed, 9 insertions(+), 1 deletion(-) >> >>

Re: [libvirt] [PATCH] tools: skip libvirt-guests fast if libvirtd is not active

On 2019.12.03 00:56 Christian Ehrhardt wrote: > The most common operation of libvirt-guests is to manage the local > libvirtd. But users might have disabled that and while we are > After=libvirtd for ordering we are not Requiring it.. > OTOH adding that or any harder dependency might affect our

[libvirt] [PATCH] tests: stop linking virt tests to secondary drivers

The hard dependancy between the virt drivers and the network or storage drivers was removed quite a while back now, so the tests no longer need to link to these drivers. Signed-off-by: Daniel P. Berrangé --- tests/Makefile.am | 33 - 1 file changed, 12

[libvirt] [PATCH v2 03/25] virsh: Implement VIR_DOMAIN_JOB_DISK_TEMP_(USED|TOTAL) in cmdDomjobinfo

Signed-off-by: Peter Krempa Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé --- tools/virsh-domain.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 21ea1a69ea..bb942267f0 100644 --- a/tools/virsh-domain.c +++

[libvirt] [PATCH v2 15/25] qemu: domain: Track backup job data in the status XML

Store the data of a backup job along with the index counter for new backup jobs in the status XML. Currently we will support only one backup job and thus there's no necessity to add arrays of jobs. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 58

[libvirt] [PATCH v2 18/25] conf: backup: Add fields for tracking stats of completed sub-jobs

We need a place to store stats of completed sub-jobs so that we can later report accurate stats. Signed-off-by: Peter Krempa --- src/conf/backup_conf.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/conf/backup_conf.h b/src/conf/backup_conf.h index c970e01920..5dfc42e297 100644

[libvirt] [PATCH v2 08/25] backup: Parse and output backup XML

From: Eric Blake Accept XML describing a generic block job, and output it again as needed. This may still need a few tweaks to match the documented XML and RNG schema. Signed-off-by: Eric Blake --- po/POTFILES.in | 1 + src/conf/Makefile.inc.am | 2 + src/conf/backup_conf.c |

[libvirt] [PATCH v2 25/25] qemu: Add support for VIR_DOMAIN_CAPS_FEATURE_BACKUP

Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 1 + tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 1 + tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml| 1 + tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 1 +

[libvirt] [PATCH v2 21/25] qemu: backup: Implement stats gathering while the job is running

We can use the output of 'query-jobs' to figure out some useful information about a backup job. That is progress in case of a push job and scratch file use in case of a pull job. Add a worker which will total up the data and call it from qemuDomainGetJobStatsInternal. Signed-off-by: Peter Krempa

Re: [libvirt] [PATCH] spec: mingw: add deps for genprotocol.pl usage

On Tue, Dec 03, 2019 at 12:11:50PM -0500, Cole Robinson wrote: > As of 0985a9597bb03 we no longer distribute generated files. mingw > needs to call genprotocol.pl itself, which means it needs rpcgen > and cpp installed. > > Signed-off-by: Cole Robinson > --- > mingw-libvirt.spec.in | 4 >

[libvirt] [PATCH v2 23/25] qemu: blockjob: Implement concluded blockjob handler for backup blockjobs

After the individual sub-blockjobs of a backup libvirt job finish we must detect it and notify the parent job, so that it can be properly terminated. Since we update job information to determine success of an blockjob we can directly report back also statistics of the blockjob. Signed-off-by:

[libvirt] [PATCH v2 11/25] qemu: Add infrastructure for statistics of a backup job

Introduce QEMU_DOMAIN_JOB_STATS_TYPE_BACKUP and the convertors and other plumbing to be able to report statistics for the backup job. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 62 ++ src/qemu/qemu_domain.h | 10 +++

[libvirt] [PATCH v2 09/25] tests: genericxml2xml: Add testing of backup XML files

Now that the parser and formatter are in place we can excercise it on the test files. Signed-off-by: Peter Krempa --- tests/Makefile.am | 1 + .../backup-pull-seclabel.xml | 18 tests/domainbackupxml2xmlout/backup-pull.xml | 10

[libvirt] [PATCH v2 20/25] qemu: Implement backup job APIs and qemu handling

This allows to start and manage the backup job. Signed-off-by: Peter Krempa --- po/POTFILES.in | 1 + src/qemu/Makefile.inc.am | 2 + src/qemu/qemu_backup.c | 941 +++ src/qemu/qemu_backup.h | 41 ++ src/qemu/qemu_driver.c | 47 ++ 5

[libvirt] [PATCH v2 16/25] qemu: blockjob: Track internal data for 'backup' blockjob

A backup blockjob needs to be able to notify the parent backup job as well as track all data to be able to clean up the bitmap and blockdev used for the backup. Add the data structure, job allocation function and status XML formatter and parser. Signed-off-by: Peter Krempa ---

[libvirt] [PATCH v2 14/25] qemu: monitor: Add support for blockdev-backup via 'transaction'

Implement the transaction actions generator for blockdev-backup. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 15 +++ src/qemu/qemu_monitor_json.c | 29 + src/qemu/qemu_monitor_json.h | 8

[libvirt] [PATCH v2 24/25] conf: domaincaps: Add 'backup' feature flag

This flag will allow figuring out whether the hypervisor supports the incremental backup and checkpoint features. Signed-off-by: Peter Krempa --- docs/formatdomaincaps.html.in | 8 docs/schemas/domaincaps.rng| 9 + src/conf/domain_capabilities.c | 1 +

[libvirt] [PATCH v2 05/25] backup: Introduce virDomainBackup APIs

From: Eric Blake Introduce a few new public APIs related to incremental backups. This builds on the previous notion of a checkpoint (without an existing checkpoint, the new API is a full backup, differing from virDomainBlockCopy in the point of time chosen and in operation on multiple disks at

[libvirt] [PATCH v2 17/25] tests: qemustatusxml2xml: Add test for 'pull' type backup job

Signed-off-by: Peter Krempa --- .../qemustatusxml2xmldata/backup-pull-in.xml | 608 ++ .../qemustatusxml2xmldata/backup-pull-out.xml | 1 + tests/qemuxml2xmltest.c | 2 + 3 files changed, 611 insertions(+) create mode 100644

[libvirt] [PATCH v2 19/25] doc: Document quirk of getting block job info for a 'backup' blockjob

The stats reported for a blockjob which is member of a domain pull backup refer to the utilization of the scratch file rather than the progress of the backup as the progress of the backup depends on the client. Note this quirk in the docs. Signed-off-by: Peter Krempa --- src/libvirt-domain.c |

[libvirt] [PATCH v2 10/25] backup: Implement virsh support for backup

From: Eric Blake Introduce virsh commands for performing backup jobs. Signed-off-by: Eric Blake Signed-off-by: Peter Krempa --- po/POTFILES.in | 1 + tools/Makefile.am| 1 + tools/virsh-backup.c | 151 +++ tools/virsh-backup.h | 21

[libvirt] [PATCH v2 22/25] qemu: driver: Allow cancellation of the backup job

Use the helper which cancels all blockjobs to perform the backup job cancellation in qemuDomainAbortJob. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH v2 00/25] Incremental backup support for qemu

Next version which includes feedback from V1: https://www.redhat.com/archives/libvir-list/2019-November/msg01315.html and also few features and bugs fixed based on offline requests: - The flag VIR_DOMAIN_BACKUP_BEGIN_REUSE_EXTERNAL was added to facilitate users who wish to provide their own

[libvirt] [PATCH v2 07/25] backup: Implement backup APIs for remote driver

From: Eric Blake This one is fairly straightforward - the generator already does what we need. Signed-off-by: Eric Blake Signed-off-by: Peter Krempa --- src/remote/remote_driver.c | 2 ++ src/remote/remote_protocol.x | 33 - src/remote_protocol-structs |

[libvirt] [PATCH v2 13/25] Add 'backup' block job type

A backup job may consist of many backup sub-blockjobs. Add the new blockjob type and add all type converter strings. Signed-off-by: Peter Krempa --- examples/c/misc/event-test.c | 3 +++ include/libvirt/libvirt-domain.h | 3 +++ src/conf/domain_conf.c | 2 +-

[libvirt] [PATCH v2 04/25] backup: Document new XML for backups

From: Eric Blake Prepare for new backup APIs by describing the XML that will represent a backup. The XML resembles snapshots and checkpoints in being able to select actions for a set of disks, but has other differences. It can support both push model (the hypervisor does the backup directly

[libvirt] [PATCH v2 06/25] API: Add domain job operation for backups

Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation. Signed-off-by: Peter Krempa --- include/libvirt/libvirt-domain.h | 1 + tools/virsh-domain.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h

[libvirt] [PATCH v2 12/25] qemu: domain: Introduce QEMU_ASYNC_JOB_BACKUP async job type

We will want to use the async job infrastructure along with all the APIs and event for the backup job so add the backup job as a new async job type. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c| 3 +++ src/qemu/qemu_domain.h| 1 + src/qemu/qemu_migration.c | 2 ++

[libvirt] [PATCH v2 01/25] qemu: domain: Export qemuDomainGetImageIds

Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 470d342afc..8d2923300d 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH v2 02/25] API: Introduce field for reporting temporary disk space usage of a domain job

A pull mode backup job uses temporary disk images to hold the changed parts of the disk while the client is copying the changes. Since usage of the temporary space can be monitored but doesn't really fit any of the existing stats fields introduce new fields for reporting this data. Signed-off-by:

[libvirt] [PATCH] scripts: fix list indexing when printing mis-ordered symbols

The python array slice syntax expects the first and last indexes, not the first length and element count. Signed-off-by: Daniel P. Berrangé --- scripts/check-symsorting.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check-symsorting.py

[libvirt] [PATCH] spec: mingw: add deps for genprotocol.pl usage

As of 0985a9597bb03 we no longer distribute generated files. mingw needs to call genprotocol.pl itself, which means it needs rpcgen and cpp installed. Signed-off-by: Cole Robinson --- mingw-libvirt.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/mingw-libvirt.spec.in

Re: [libvirt] [PATCH v2] driver: Include source as a flag to virDomainGetHostname

On 12/2/19 4:24 AM, Julio Faracco wrote: There is a lots of possibilities to retrieve hostname information from domain. Libvirt could use lease information from dnsmasq to get current hostname too. QEMU supports QEMU-agent but it can use lease source. See 'domifaddr' as an example. This commit

[libvirt] [PATCH 0/4] Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param

Normally the TLS certificate from the destination host must match the host's name for TLS verification to succeed. When the certificate does not match the destination hostname and the expected cetificate's hostname is known, this parameter can be used to pass this expected hostname when starting

[libvirt] [PATCH 3/4] qemu: Implement VIR_MIGRATE_PARAM_TLS_DESTINATION

Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.h| 1 + src/qemu/qemu_migration_params.c | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h index d98fe9f80a..b6f88d3fd9 100644 ---

[libvirt] [PATCH 1/4] qemu: Add support for setting string migration params

The functions for converting migration typed parameters to QEMU migration parameters and back were only implemented for integer types. This patch adds support for string parameters. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 56 1 file

[libvirt] [PATCH 2/4] Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param

Normally the TLS certificate from the destination host must match the host's name for TLS verification to succeed. When the certificate does not match the destination hostname and the expected cetificate's hostname is known, this parameter can be used to pass this expected hostname when starting

[libvirt] [PATCH 4/4] virsh: Add --tls-destination option for migrate command

This option can be used to override the destination host name used for TLS verification. Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 11 +++ tools/virsh.pod | 8 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c

[libvirt] [PATCH] tests: stop static linking to libvirt code in tests

If we static link to libvirt_util.la then we can't override functions in this file by simply implementing them in the test code. Any tests should dynamic link to the main libvirt.la and ensure symbols are exported. Signed-off-by: Daniel P. Berrangé --- src/libvirt_private.syms | 2 ++

Re: [libvirt] [PATCH v2 04/12] esx: implement connectListAllStoragePools

On Fri, Nov 15, 2019 at 01:40:43PM +0100, Pino Toscano wrote: Implement the .connectListAllStoragePools storage API in the esx storage driver, and in all its subdrivers. Signed-off-by: Pino Toscano --- src/esx/esx_storage_backend_iscsi.c | 72 +

Re: [libvirt] [PATCH 2/2] Add -mem-shared option

On Tue, 3 Dec 2019 09:56:15 +0100 Thomas Huth wrote: > On 02/12/2019 22.00, Eduardo Habkost wrote: > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: > >> On Fri, 29 Nov 2019 18:46:12 +0100 > >> Paolo Bonzini wrote: > >> > >>> On 29/11/19 13:16, Igor Mammedov wrote: >

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

On Mon, 2019-12-02 at 20:33 +0100, Andrea Bolognani wrote: > > On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote: > > > +++ b/guests/host_vars/libvirt-opensuse-15/main.yml > > > @@ -0,0 +1,22 @@ > > > +--- > > > +projects: > > > + - libosinfo > > > + - libvirt > > > + - libvirt-cim > > > + -

Re: [libvirt] [PATCH v3 2/4] qemu: block: use the delete flag to delete snapshot images if requested

On Thu, Nov 21, 2019 at 11:00:45 +0100, Pavel Mores wrote: > When blockcommit finishes successfully, one of the > qemuBlockJobProcessEventCompletedCommit() and > qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called. > This is where the delete flag (stored in

Re: [libvirt] [PATCH v3 4/4] qemu: block: enable the snapshot image deletion feature

On Thu, Nov 21, 2019 at 11:00:47 +0100, Pavel Mores wrote: > With all plumbing in place, we can now enable the new functionality. > > Signed-off-by: Pavel Mores > --- > src/qemu/qemu_driver.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v3 3/4] qemu: block: store the delete flag in libvirtd's status XML

On Thu, Nov 21, 2019 at 11:00:46 +0100, Pavel Mores wrote: > Since blockcommit is asynchronous, libvirtd can be restarted while the > operation runs. To ensure the information necessary to finish up the job > is not lost, serialisation to and deserialisation from the status XML is > added. > >

Re: [libvirt] [PATCH v3 2/4] qemu: block: use the delete flag to delete snapshot images if requested

On Thu, Nov 21, 2019 at 11:00:45 +0100, Pavel Mores wrote: > When blockcommit finishes successfully, one of the > qemuBlockJobProcessEventCompletedCommit() and > qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called. > This is where the delete flag (stored in

Re: [libvirt] [PATCH v3 1/4] qemu: block: propagate the delete flag to where it can actually be used

On Thu, Nov 21, 2019 at 11:00:44 +0100, Pavel Mores wrote: > Propagate the delete flag from qemuDomainBlockCommit() (which was just > ignoring it until now) to qemuBlockJobDiskNewCommit() where it can be > stored in the qemuBlockJobCommitData structure which holds information > necessary to finish

Re: [libvirt] [glib PATCH] glib,docs: Remove "object-tree" chapter

On 12/3/19 2:04 PM, Fabiano Fidêncio wrote: gtk-doc-1.30+ does *not* create tree_index.sgml in case the library does not provide GObjects, which is the case of LibvirtGLib. In previous versions, though, an empty file would be generated. This seems to be a regression which hit *a* *lot* of

Re: [libvirt] Libvirt 5.9.0 Lags

Hello Daniel, Thanks for your reply. Yes, the issue is all inside the guest, not between the host and guest or between guests. Regards, Dincer Mit freundlichen Grüßen Dincer Beken E-Mail: dbe...@blackned.de Tel.: +49 8331 9959-852

Re: [libvirt] Libvirt 5.9.0 Lags

On Tue, Dec 03, 2019 at 11:28:37AM +, Dincer Beken wrote: > > Hello all, > > I am using Arch Linux 5.3.13-arch1-1 and libvirt 5.9.0. > > After I made a linux update (sudo pacman -Syu), I got the new, libvirt > version mentioned above. > > But soon after I realized, while programming in

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

On Tue, 2019-12-03 at 13:54 +0100, Fabiano Fidêncio wrote: > > > > > 'lci update ... libvirt' fails in task "Configure hostname": > > > > > > > > > > fatal: [libvirt-opensuse-tumbleweed]: FAILED! => {"changed": false, > > > > > "msg": "hostname module cannot be used on platform Linux > > > > >

Re: [libvirt] [PATCH 04/21] backup: Introduce virDomainBackup APIs

On Wed, Nov 27, 2019 at 11:30:30 -0600, Eric Blake wrote: > On 11/26/19 3:39 PM, Peter Krempa wrote: [...] > > + * For now, backup jobs are also mutually exclusive with any > > + * other block job on the same device, although this restriction may > > + * be lifted in a future release. Progress

Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

On Tue, Dec 03, 2019 at 02:00:50PM +0100, Andrea Bolognani wrote: > On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote: > > On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote: > > > extra_arg = "console=ttyS0 > > > ks=file:/{}".format(install_config) > > > > On a

[libvirt] [glib PATCH] glib,docs: Remove "object-tree" chapter

gtk-doc-1.30+ does *not* create tree_index.sgml in case the library does not provide GObjects, which is the case of LibvirtGLib. In previous versions, though, an empty file would be generated. This seems to be a regression which hit *a* *lot* of different projects, all of them having to take the

Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote: > On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote: > > extra_arg = "console=ttyS0 ks=file:/{}".format(install_config) > > On a side note - I'm pretty sure I've already mentioned it in the past, but we > should

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

> > > > 'lci update ... libvirt' fails in task "Configure hostname": > > > > > > > > fatal: [libvirt-opensuse-tumbleweed]: FAILED! => {"changed": false, > > > > "msg": "hostname module cannot be used on platform Linux > > > > (Opensuse-tumbleweed)"} > > > > > > It seems to be an Ansible bug: >

[libvirt] [PATCH] maint: post-post-version-bump version bump to 6.0.0

My commit 3bbe10205b79c8803e69c61897a0491d7a3f57c0 forgot to update the news. Signed-off-by: Ján Tomko --- Pushed under the trivial paper bag rule. docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index e4533cc46e..43aa96f497

Re: [libvirt] [PATCH] spec: Fix printing test-suite.log when make check fails

On Tue, Dec 03, 2019 at 11:53:41AM +0100, Jiri Denemark wrote: > Commit v5.7.0-248-g03449e2504 removed "cd tests" without updating the > patch to test-suite.log. > > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Pavel

[libvirt] [PATCH] maint: post-version bump version bump to 6.0.0

Signed-off-by: Ján Tomko --- Pushed as trivial. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d0ef7de750..76d28d2f67 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU

Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote: > It's not immediately obvious why we're using it even when installing > a distribution like Debian, so explain the motivation in a comment. > > Signed-off-by: Andrea Bolognani > --- > guests/lcitool | 4 +++- > 1 file changed, 3

[libvirt] Libvirt 5.9.0 Lags

Hello all, I am using Arch Linux 5.3.13-arch1-1 and libvirt 5.9.0. After I made a linux update (sudo pacman -Syu), I got the new, libvirt version mentioned above. But soon after I realized, while programming in eclipse, that copy paste does not work anymore. After couple of tries, when I try

Re: [libvirt] [PATCH] tests: fix name of 32-bit x86 QEMU binary

On Tue, Dec 03, 2019 at 11:09:56AM +, Daniel P. Berrangé wrote: > The 32-bit x86 binary is called qemu-system-i386, not > qemu-system-i686. This mistake across many test XML files was > not noticed because the mistake was also made in testutilsqemu.c > when mocking the capabilities. > >

[libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms (libvirt 4.5)

Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") adds support for CLZERO CPUID bit. This commit extends support for this bit in libvirt. This patch is based off of libvirt-4.5 tree. Signed-off-by: Ani Sinha --- src/cpu/cpu_map.xml | 5 + 1 file changed, 5

[libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

It's not immediately obvious why we're using it even when installing a distribution like Debian, so explain the motivation in a comment. Signed-off-by: Andrea Bolognani --- guests/lcitool | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool

Re: [libvirt] CLZERO support for AMD

Thanks. I have sent a patch based off the tip here: https://www.redhat.com/archives/libvir-list/2019-December/msg00086.html I also have a patch off libvirt-4.5 which I have tested on our HW. If needed, I can send that patch as well. Ani On Dec 2, 2019, 5:22 PM +0530, Daniel P. Berrangé ,

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

On Tue, 2019-12-03 at 11:50 +0100, Fabiano Fidêncio wrote: > > It sounds like we can just provide install= unconditionally, same as > > we currently do with ks=? We'd have to verify doing so doesn't cause > > any unintended side-effects for existing guest types. > > I'd rather have it done in a

[libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms

Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") adds support for CLZERO CPUID bit. This commit extends support for this CPUID bit into libvirt. Signed-off-by: Ani Sinha --- src/cpu_map/x86_EPYC-IBPB.xml | 1 + src/cpu_map/x86_EPYC.xml | 1 +

[libvirt] [PATCH] spec: Fix printing test-suite.log when make check fails

Commit v5.7.0-248-g03449e2504 removed "cd tests" without updating the patch to test-suite.log. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c7fac104d9..4c6161a26f 100644 ---

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

Andrea, > It sounds like we can just provide install= unconditionally, same as > we currently do with ks=? We'd have to verify doing so doesn't cause > any unintended side-effects for existing guest types. I'd rather have it done in a more explicit way, just for the sake of someone else trying

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

On Tue, 2019-12-03 at 11:05 +0100, Fabiano Fidêncio wrote: > > Speaking of which: I've run into a fairly major problem with > > the Leap 15.1 support enabled by this patch: while unattended > > installation works as expected on my laptop (Fedora 31), when I try > > the same steps on the CentOS CI

Re: [libvirt] [PATCH] news: Fix XML validation

On Tue, 2019-12-03 at 04:02 +, Jim Fehlig wrote: > The news schema requires two digits for both month and day in the date > attribute. s/2/02/ in the day value of date to fix the following > 'make check' failure > > 2165) Checking ../docs/news.xml against ../news.rng ... >

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

Andrea, > > Speaking of which: I've run into a fairly major problem with > the Leap 15.1 support enabled by this patch: while unattended > installation works as expected on my laptop (Fedora 31), when I try > the same steps on the CentOS CI production environment (CentOS 7.5) > it doesn't seem to

Re: [libvirt] [PATCH 2/2] Add -mem-shared option

On 02/12/2019 22.00, Eduardo Habkost wrote: > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: >> On Fri, 29 Nov 2019 18:46:12 +0100 >> Paolo Bonzini wrote: >> >>> On 29/11/19 13:16, Igor Mammedov wrote: As for "-m", I'd make it just an alias that translates

[libvirt] [PATCH] tools: skip libvirt-guests fast if libvirtd is not active

The most common operation of libvirt-guests is to manage the local libvirtd. But users might have disabled that and while we are After=libvirtd for ordering we are not Requiring it.. OTOH adding that or any harder dependency might affect our ordering. But if people have disabled libvirt they will

Re: [libvirt] [PATCH] maint: Post-release version bump to 5.11.0

On Tue, Dec 03, 2019 at 04:24:59 +, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > --- > > Pushing under the trivial rule. > > configure.ac | 2 +- > docs/news.xml | 8 > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index

Re: [libvirt] [PATCH] news: Fix XML validation

Dohhh, that's why :-) ! Thanks for chasing this Jim, Daniel On Tue, Dec 03, 2019 at 04:02:11AM +, Jim Fehlig wrote: > The news schema requires two digits for both month and day in the date > attribute. s/2/02/ in the day value of date to fix the following > 'make check' failure > > 2165)