[libvirt] [tck Patch] Require perl(IO::Pty)

The Net::OpenSSH module requires IO::Pty if password authentication will be used, but The Fedora Net::OpenSSH maintainers don't want to put anything stronger that "Suggests: perl(IO::Pty)" in their specfile, which unfortunately does absolutely nothing. (see

[libvirt] [PATCH] tests: fix bhyve build

This file was modified in an editor buffer but not saved prior to commit e62cb4a9b78 (which removed virMacAddr::generated), so the bhyve build would fail. Signed-off-by: Laine Stump --- Pushed under the build breaker rule. tests/bhyvexml2argvmock.c | 1 - 1 file changed, 1

Re: [libvirt] [PATCH v2 16/42] util: add default: case to all switch statements

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Even if the compiler has validated that all enum constants have case > statements in a switch, it is not safe to omit a default: case > statement. When assigning a value to a variable / struct field that is > defined with an enum type, nothing

Re: [libvirt] [PATCH v2 16/42] util: add default: case to all switch statements

On 02/19/2018 06:49 PM, John Ferlan wrote: > > > On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: >> Even if the compiler has validated that all enum constants have case >> statements in a switch, it is not safe to omit a default: case >> statement. When assigning a value to a variable /

Re: [libvirt] Regarding libvirt patchset "Keep original security label"

[Adding libvirt-list as others might chime in or when somebody is solving similar issue they can find answers in the archive.] On 02/19/2018 10:09 AM, Toni Peltonen wrote: > Hi, > > Sorry to bother you with ages old stuff like this >

Re: [libvirt] [PATCH v3 08/10] qemu: remove virConnectPtr in some migration methods

On Fri, Feb 16, 2018 at 05:02:34PM -0500, John Ferlan wrote: > > > On 02/16/2018 06:22 AM, Daniel P. Berrangé wrote: > > The qemuMigrationPrecreateStorage method needs a connection > > to access the storage driver. Instead of passing it around, > > open it at time of use. > > > > Signed-off-by:

[libvirt] [RFC] libvirt hexagon sticker design

Hi folks, those who attended at least one conference for the past year have probably noticed the rising trend (more like "sticker hype") of FOSS projects giving away these hexagon stickers, it's very inexpensive way of making some promo for their project and since we don't do many promos (AFAIK

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, 2018-02-19 at 07:24 +0100, Peter Krempa wrote: > On Fri, Feb 16, 2018 at 17:28:03 +0100, Andrea Bolognani wrote: > > Validate time is a bit too early to check whether the required > > capabilities are available, since the QEMU binary might have > > been updated or replaced by the time we

Re: [libvirt] [RFC] libvirt hexagon sticker design

W dniu 19.02.2018 o 09:44, Erik Skultety pisze: > So, I've taken our libvirt-publican repo and came up with a few > various color combinations for libvirt hexagon sticker design. > [1] https://drive.google.com/open?id=1xhn0GLvCKMcEOUnqn6boghaUOgjA8sOG > [2]

Re: [libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams

ping ^ 2 On 02/13/2018 11:20 AM, Edgar Kaziakhmedov wrote: ping On 02/07/2018 05:49 PM, Edgar Kaziakhmedov wrote: Predefine hints for all parameters possible to avoid wrong type convert. Signed-off-by: Edgar Kaziakhmedov ---   libvirt-override.c | 128

[libvirt] [PATCH 0/2] Two blockjob fixes

Peter Krempa (2): virsh: Fix internal naming of some blockjob commands qemu: blockcopy: Add check for bandwidth src/qemu/qemu_driver.c | 8 +++ tools/virsh-domain.c | 60 +- 2 files changed, 38 insertions(+), 30 deletions(-) -- 2.15.0

[libvirt] [PATCH 1/2] virsh: Fix internal naming of some blockjob commands

The variable names for the options and information about a command should have an underscore in places where the virsh command has a hyphen. The function callback name should capitalize the letter after the hyphen. This was not used in 'blockcommit', 'blockcopy', 'blockjob', 'blockpull', and

[libvirt] [PATCH 2/2] qemu: blockcopy: Add check for bandwidth

QEMU code does not work well with too big numbers on the JSON monitor so our monitor code supports sending only numbers up to LLONG_MAX. Avoid a weird error message by limiting the size of the 'bandwidth' parameter for block copy. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1532542

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, Feb 19, 2018 at 10:29:18 +0100, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 07:24 +0100, Peter Krempa wrote: > > On Fri, Feb 16, 2018 at 17:28:03 +0100, Andrea Bolognani wrote: > > > Validate time is a bit too early to check whether the required > > > capabilities are available, since

Re: [libvirt] [PATCH 0/2] Two blockjob fixes

On Mon, Feb 19, 2018 at 09:40:39AM +0100, Peter Krempa wrote: Peter Krempa (2): virsh: Fix internal naming of some blockjob commands qemu: blockcopy: Add check for bandwidth src/qemu/qemu_driver.c | 8 +++ tools/virsh-domain.c | 60 +- 2

Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

On Mon, 2018-02-19 at 07:28 +0100, Peter Krempa wrote: > On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote: > > We will rewrite pretty much every single line of this function > > over the course of the next several commits, and starting from > > a clean slate rather than replacing it

Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

On Mon, Feb 19, 2018 at 10:22:29 +0100, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 07:28 +0100, Peter Krempa wrote: > > On Fri, Feb 16, 2018 at 17:28:04 +0100, Andrea Bolognani wrote: > > > We will rewrite pretty much every single line of this function > > > over the course of the next

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 10:31:34AM +, Daniel P. Berrangé wrote: > On Mon, Feb 19, 2018 at 09:44:36AM +0100, Erik Skultety wrote: > > Hi folks, > > those who attended at least one conference for the past year have probably > > noticed the rising trend (more like "sticker hype") of FOSS projects

Re: [libvirt] [PATCH v2 08/15] qemu: Validate PCI controllers (index)

On Mon, 2018-02-19 at 11:52 +, Daniel P. Berrangé wrote: > > +qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef > > *controller, > > + const virDomainDef *def) > > { > > +const virDomainPCIControllerOpts *pciopts =

[libvirt] [PATCH] tests: drop linkage to libvirt_driver_network_impl.la

The qemuxml2argvtest does not need to link to the network driver after this commit: commit 0c63c117a2d17f66b05dd83e50aa36ac0b0c9843 Author: Daniel P. Berrangé Date: Fri Feb 9 15:08:53 2018 + conf: reimplement virDomainNetResolveActualType in terms of public

[libvirt] [PATCH] bhyve: Fix build

Commit 2d43f0a2dcfd dropped virDomainDiskTranslateSourcePool()'s first argument but failed to update callers in the bhyve driver. Signed-off-by: Andrea Bolognani --- Pushed under the build breaker rule. src/bhyve/bhyve_command.c | 21 ++--- 1 file changed,

Re: [libvirt] [RFC] libvirt hexagon sticker design

[...] > > In terms of background & border, IMHO, it really should be the white > > background - the logo doesn't stand out well when you have it on the > > green background. Green background is ok for the wbsite banner as we > > don't want the logo to be too distrating, but for a promotional

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, 2018-02-19 at 13:25 +0100, Martin Kletzander wrote: > > Agreed. The lighter green background also mostly works, but only > > with the grey text variation of the logo. > > I'd vote from second one from the top row. Did you try making a circular (or > hexagonal) gradien tthat would start

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 02:49:34PM +0100, Andrea Bolognani wrote: On Mon, 2018-02-19 at 13:25 +0100, Martin Kletzander wrote: > Agreed. The lighter green background also mostly works, but only > with the grey text variation of the logo. I'd vote from second one from the top row. Did you try

Re: [libvirt] [python PATCH 1/4] Use static variables to store virPyDictToTypedParams hints

On Mon, Feb 19, 2018 at 03:21:58PM +0100, Pavel Hrdina wrote: > There is no need to have dynamic allocation every time the API > is called. Rewrites commit <314b2346df>. > > Signed-off-by: Pavel Hrdina > --- > libvirt-override.c | 149 >

Re: [libvirt] [PATCH v2 05/15] qemu: Simplify modelName stringification

On Fri, Feb 16, 2018 at 17:28:02 +0100, Andrea Bolognani wrote: > There's no need to perform checks before conversion, we can > just go try and check the results later on. > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_command.c | 16 +--- > 1 file

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 02:49:34PM +0100, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 13:25 +0100, Martin Kletzander wrote: > > > Agreed. The lighter green background also mostly works, but only > > > with the grey text variation of the logo. > > > > I'd vote from second one from the top row.

[libvirt] [python PATCH 0/4] followup fixes for virPyDictToTypedParams

Pavel Hrdina (4): Use static variables to store virPyDictToTypedParams hints Fix order of virPyDictToTypedParams hints Add missing virPyDictToTypedParams hint for migration params Fix virPyDictToTypedParams type hint for block copy params libvirt-override.c | 150

[libvirt] [python PATCH 1/4] Use static variables to store virPyDictToTypedParams hints

There is no need to have dynamic allocation every time the API is called. Rewrites commit <314b2346df>. Signed-off-by: Pavel Hrdina --- libvirt-override.c | 149 - libvirt-utils.h| 2 + 2 files changed, 34

[libvirt] [python PATCH 4/4] Fix virPyDictToTypedParams type hint for block copy params

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index 59c1e0c..580c259 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -8668,7 +8668,7 @@

[libvirt] [python PATCH 3/4] Add missing virPyDictToTypedParams hint for migration params

Signed-off-by: Pavel Hrdina --- libvirt-override.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-override.c b/libvirt-override.c index 4f546b4..59c1e0c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7747,6 +7747,7 @@ static virPyTypedParamsHint

[libvirt] [python PATCH 2/4] Fix order of virPyDictToTypedParams hints

This corresponds to the order in libvirt-domain.h header file. Signed-off-by: Pavel Hrdina --- libvirt-override.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index ab4232f..4f546b4 100644 ---

Re: [libvirt] [python PATCH 2/4] Fix order of virPyDictToTypedParams hints

On Mon, Feb 19, 2018 at 03:21:59PM +0100, Pavel Hrdina wrote: > This corresponds to the order in libvirt-domain.h header file. > > Signed-off-by: Pavel Hrdina > --- > libvirt-override.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P.

Re: [libvirt] [python PATCH 3/4] Add missing virPyDictToTypedParams hint for migration params

On Mon, Feb 19, 2018 at 03:22:00PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > libvirt-override.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [python PATCH 4/4] Fix virPyDictToTypedParams type hint for block copy params

On Mon, Feb 19, 2018 at 03:22:01PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > libvirt-override.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, 2018-02-19 at 14:30 +0100, Peter Krempa wrote: > On Mon, Feb 19, 2018 at 13:21:35 +, Daniel Berrange wrote: > > On Mon, Feb 19, 2018 at 02:13:14PM +0100, Peter Krempa wrote: > > > The only situation when we should not fail if QEMU is not installed and > > > you restart libvirtd. Making

Re: [libvirt] [PATCH v2 02/15] qemu: Move 'done' label in qemuBuildControllerDevStr()

On Fri, Feb 16, 2018 at 17:27:59 +0100, Andrea Bolognani wrote: > Even when we skip part of the processing, we still want error > checking on the buffer. > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH v2 03/15] qemu: Move skip for implicit PHB of pSeries guests

On Fri, Feb 16, 2018 at 17:28:00 +0100, Andrea Bolognani wrote: > Performing the skip earlier will help us making the function > nicer later on. We also make the condition for the skip a bit > more precise, though that'a more for self-documenting purposes > and doesn't change anything in practice.

Re: [libvirt] [PATCH v2 04/15] qemu: Restrict scope in qemuBuildControllerDevStr()

On Fri, Feb 16, 2018 at 17:28:01 +0100, Andrea Bolognani wrote: > Some variables are only used for PCI controllers, and we're going > to add more soon. We can declare them in the 'case' scope rather > than in the function scope to make it a bit nicer. > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH v2 03/15] qemu: Move skip for implicit PHB of pSeries guests

On Mon, 2018-02-19 at 15:58 +0100, Peter Krempa wrote: > On Fri, Feb 16, 2018 at 17:28:00 +0100, Andrea Bolognani wrote: > > Performing the skip earlier will help us making the function > > nicer later on. We also make the condition for the skip a bit > > more precise, though that'a more for

Re: [libvirt] [PATCH v3] qemu: rename migration APIs to include Src or Dst in their name

On 02/19/2018 06:46 AM, Daniel P. Berrangé wrote: > It is very difficult while reading the migration code trying to > understand whether a particular function is being called on the src side > or the dst side, or either. Putting "Src" or "Dst" in the method names will > make this much more

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 11:36:03AM +0100, Kashyap Chamarthy wrote: > On Mon, Feb 19, 2018 at 09:44:36AM +0100, Erik Skultety wrote: > > Hi folks, > > those who attended at least one conference for the past year have probably > > noticed the rising trend (more like "sticker hype") of FOSS projects

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 11:09:40AM +, Daniel P. Berrangé wrote: > On Mon, Feb 19, 2018 at 12:02:01PM +0100, Erik Skultety wrote: > > [...] > > > > > > In terms of background & border, IMHO, it really should be the white > > > > background - the logo doesn't stand out well when you have it on

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On 02/19/2018 04:29 AM, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 07:24 +0100, Peter Krempa wrote: >> On Fri, Feb 16, 2018 at 17:28:03 +0100, Andrea Bolognani wrote: >>> Validate time is a bit too early to check whether the required >>> capabilities are available, since the QEMU binary

Re: [libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams

On Wed, Feb 07, 2018 at 05:49:30PM +0300, Edgar Kaziakhmedov wrote: > Predefine hints for all parameters possible to avoid wrong type > convert. > > Signed-off-by: Edgar Kaziakhmedov > --- > libvirt-override.c | 128 >

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, 2018-02-19 at 10:31 +, Daniel P. Berrangé wrote: > > [1] https://drive.google.com/open?id=1xhn0GLvCKMcEOUnqn6boghaUOgjA8sOG > > [2] https://drive.google.com/open?id=1b2MUyv0eo723F2rorWnmv1sTeCycUCN4 > > I think the second style works better, as having the 'VIRTUALIZATION API' > line

Re: [libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams

On Mon, Feb 19, 2018 at 01:09:27PM +, Daniel P. Berrangé wrote: > On Wed, Feb 07, 2018 at 05:49:30PM +0300, Edgar Kaziakhmedov wrote: > > Predefine hints for all parameters possible to avoid wrong type > > convert. > > > > Signed-off-by: Edgar Kaziakhmedov >

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, Feb 19, 2018 at 02:13:14PM +0100, Peter Krempa wrote: > On Mon, Feb 19, 2018 at 13:04:08 +, Daniel Berrange wrote: > > On Mon, Feb 19, 2018 at 10:29:18AM +0100, Andrea Bolognani wrote: > > > On Mon, 2018-02-19 at 07:24 +0100, Peter Krempa wrote: > > > > On Fri, Feb 16, 2018 at 17:28:03

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, Feb 19, 2018 at 13:21:35 +, Daniel Berrange wrote: > On Mon, Feb 19, 2018 at 02:13:14PM +0100, Peter Krempa wrote: > > On Mon, Feb 19, 2018 at 13:04:08 +, Daniel Berrange wrote: > > > On Mon, Feb 19, 2018 at 10:29:18AM +0100, Andrea Bolognani wrote: > > > > On Mon, 2018-02-19 at

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 09:44:36AM +0100, Erik Skultety wrote: > Hi folks, > those who attended at least one conference for the past year have probably > noticed the rising trend (more like "sticker hype") of FOSS projects giving > away > these hexagon stickers, it's very inexpensive way of

Re: [libvirt] [PATCH v2 08/15] qemu: Validate PCI controllers (index)

On Fri, Feb 16, 2018 at 05:28:05PM +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 56 > -- > 1 file changed, 54 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 12:54:24PM +0100, Erik Skultety wrote: > On Mon, Feb 19, 2018 at 11:09:40AM +, Daniel P. Berrangé wrote: > > On Mon, Feb 19, 2018 at 12:02:01PM +0100, Erik Skultety wrote: > > > [...] > > > > > > > > In terms of background & border, IMHO, it really should be the white >

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 12:02:01PM +0100, Erik Skultety wrote: > [...] > > > > In terms of background & border, IMHO, it really should be the white > > > background - the logo doesn't stand out well when you have it on the > > > green background. Green background is ok for the wbsite banner as we

Re: [libvirt] [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

On Mon, 2018-02-19 at 10:40 +0100, Peter Krempa wrote: > > Renaming the function won't work because then the compiler will > > complain about it being unused. Unless you meant something like > > > > /* Delete once done */ > > ValidateControllerPCIOld() { > > /* Existing checks here */ > >

Re: [libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams

On 02/19/2018 01:08 PM, Edgar Kaziakhmedov wrote: > ping ^ 2 > > > On 02/13/2018 11:20 AM, Edgar Kaziakhmedov wrote: >> ping >> >> >> On 02/07/2018 05:49 PM, Edgar Kaziakhmedov wrote: >>> Predefine hints for all parameters possible to avoid wrong type >>> convert. >>> >>> Signed-off-by: Edgar

Re: [libvirt] [PATCH python 1/1] Set hints for virPyDictToTypedParams

On Mon, Feb 19, 2018 at 02:20:30PM +0100, Pavel Hrdina wrote: > On Mon, Feb 19, 2018 at 01:09:27PM +, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 05:49:30PM +0300, Edgar Kaziakhmedov wrote: > > > Predefine hints for all parameters possible to avoid wrong type > > > convert. > > > >

Re: [libvirt] [PATCH] conf: move 'generated' member from virMacAddr to virDomainNetDef

On Mon, Feb 19, 2018 at 07:23:23AM +0100, Michal Privoznik wrote: > On 02/16/2018 09:04 PM, Laine Stump wrote: > > Commit 7e62c4cd26d (first appearing in libvirt-3.9.0 as a resolution > > to rhbz #1343919) added a "generated" attribute to virMacAddr that was > > set whenever a mac address was

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 09:44:36AM +0100, Erik Skultety wrote: > Hi folks, > those who attended at least one conference for the past year have probably > noticed the rising trend (more like "sticker hype") of FOSS projects giving > away > these hexagon stickers, it's very inexpensive way of

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 12:41:32PM +0100, Andrea Bolognani wrote: On Mon, 2018-02-19 at 10:31 +, Daniel P. Berrangé wrote: > [1] https://drive.google.com/open?id=1xhn0GLvCKMcEOUnqn6boghaUOgjA8sOG > [2] https://drive.google.com/open?id=1b2MUyv0eo723F2rorWnmv1sTeCycUCN4 I think the second

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, Feb 19, 2018 at 10:29:18AM +0100, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 07:24 +0100, Peter Krempa wrote: > > On Fri, Feb 16, 2018 at 17:28:03 +0100, Andrea Bolognani wrote: > > > Validate time is a bit too early to check whether the required > > > capabilities are available,

Re: [libvirt] [RFC] libvirt hexagon sticker design

On Mon, Feb 19, 2018 at 10:48:26AM +, Daniel P. Berrangé wrote: > On Mon, Feb 19, 2018 at 11:36:03AM +0100, Kashyap Chamarthy wrote: > > On Mon, Feb 19, 2018 at 09:44:36AM +0100, Erik Skultety wrote: [...] > > Speaking of logos...at the risk of opening a huge bucket of paint: > > > > The

Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time

On Mon, Feb 19, 2018 at 13:04:08 +, Daniel Berrange wrote: > On Mon, Feb 19, 2018 at 10:29:18AM +0100, Andrea Bolognani wrote: > > On Mon, 2018-02-19 at 07:24 +0100, Peter Krempa wrote: > > > On Fri, Feb 16, 2018 at 17:28:03 +0100, Andrea Bolognani wrote: > > > > Validate time is a bit too

[libvirt] [PATCH] docs: Fix indentation of inlined JavaScript snippet

Signed-off-by: Andrea Bolognani --- Pushed as trivial. docs/page.xsl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/page.xsl b/docs/page.xsl index 3a64a06c5..c1804eab3 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -103,7 +103,7 @@

Re: [libvirt] [PATCH v2 05/15] qemu: Simplify modelName stringification

On Mon, 2018-02-19 at 16:06 +0100, Peter Krempa wrote: > > case VIR_DOMAIN_CONTROLLER_TYPE_PCI: { > > -const virDomainPCIControllerOpts *pciopts; > > -const char *modelName = NULL; > > - > > -pciopts = >opts.pciopts; > > -if (def->model !=

Re: [libvirt] [PATCH] docs: Document pcie-root requirement for q35 guests

On Mon, Feb 19, 2018 at 05:38:35PM +0100, Andrea Bolognani wrote: > When you add a bunch of pcie-root-port controllers to a q35 guest > in order to have hotplug capabilities, you also need to make sure > you're adding the pcie-root controller at the same time or you > will get an error. Document

Re: [libvirt] [PATCH v2 04/15] qemu: Restrict scope in qemuBuildControllerDevStr()

On Mon, 2018-02-19 at 16:00 +0100, Peter Krempa wrote: > > @@ -2625,8 +2625,6 @@ qemuBuildControllerDevStr(const virDomainDef > > *domainDef, > > { > > virBuffer buf = VIR_BUFFER_INITIALIZER; > > int address_type = def->info.type; > > -const virDomainPCIControllerOpts *pciopts; > >

[libvirt] [PATCH] docs: Document pcie-root requirement for q35 guests

When you add a bunch of pcie-root-port controllers to a q35 guest in order to have hotplug capabilities, you also need to make sure you're adding the pcie-root controller at the same time or you will get an error. Document this fact. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH] daemon: trigger RPC re-generation when Makefile.am changes

The src/Makefile.am rules all re-generate the RPC dispatch code whenever the Makefile.am changes, so for consistency do that for daemon/Makefile.am too. Signed-off-by: Daniel P. Berrangé --- daemon/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH v2 03/42] conf: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/conf/domain_audit.c | 1 + > src/conf/domain_conf.c | 47 +-- >

Re: [libvirt] [PATCH v2 01/42] conf: add enum constants for default controller models

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > The controller model is slightly unusual in that the default value is > -1, not 0. As a result the default value is not covered by any of the > existing enum cases. This in turn means that any switch() statements > that think they have covered

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. and in some cases force an error if something unexpected is found. [not necessary to add, especially since it's repeatable throughout the series so far, but figured I'd note it at least

Re: [libvirt] [PATCH v2 04/42] esx: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or explicitly > cast away enum type where we don't want to list all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/esx/esx_driver.c | 1 + >

Re: [libvirt] [PATCH v2 09/42] qemu: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or cast away > enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/qemu/qemu_command.c | 28

Re: [libvirt] [PATCH v2 10/42] rpc: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/rpc/virnetclient.c| 2 ++ > src/rpc/virnetclientprogram.c | 1 + > src/rpc/virnetserverprogram.c | 4 >

Re: [libvirt] [PATCH v2 11/42] security: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/security/security_driver.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: John Ferlan

Re: [libvirt] [PATCH v2 12/42] xen: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/vmx/vmx.c | 27 +-- > src/xenconfig/xen_common.c | 17 +++-- >

Re: [libvirt] [PATCH v2 13/42] tools: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Cast away enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > tools/virt-host-validate-qemu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [libvirt] [PATCH v2 14/42] m4: enforce that all enum cases are listed in switch statements

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > As a general rule any time we switch() on something that is an enum, we > want to have a case for every enum constant. The -Wswitch warning will > report any switch where we've violated this rule, except if that switch > has a default case. >

Re: [libvirt] [PATCH v2 07/42] lxc: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or cast away > enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/lxc/lxc_container.c | 7 --- >

Re: [libvirt] [PATCH v2 08/42] nwfilter: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or cast away > enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/nwfilter/nwfilter_ebiptables_driver.c |

Re: [libvirt] [PATCH v2 05/42] hyperv: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. This improves > debug logging integration with openwsman. > > Signed-off-by: Daniel P. Berrangé > --- > src/hyperv/hyperv_driver.c | 18 -- > 1 file

Re: [libvirt] [PATCH v2 06/42] libxl: handle missing switch enum cases

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Cast away enum type for libxl schedular constants since we don't want to > cover all of them and don't want build to break when new ones are added. > > Signed-off-by: Daniel P. Berrangé > --- > src/libxl/libxl_driver.c |

[libvirt] [PATCH] nwfilter: assure that virNWFilterSnoop(Eth|Dhcp)Hdr objects don't change size

These two objects are used to access fields in actual ethernet packets captures with libpcap, so it's essential that they don't change size for any reason. This patch uses gnulib's verify() macro to make sure their sizes don't change. Signed-off-by: Laine Stump --- danpb