[libvirt] [PATCH v2 62/73] qemu: Set migration parameters automatically

Most QEMU migration parameters directly correspond to VIR_MIGRATE_PARAM_* typed parameters and qemuMigrationParamsFromFlags can automatically set them according to a static mapping between libvirt and QEMU parameters. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [PATCH 4/6] qemu: caps: Add capability for 'write-cache' parameter of disk frontends

On 04/04/2018 04:13 AM, Peter Krempa wrote: > QEMU translates the cache mode of a disk internally into 3 flags. > 'write-cache' is a flag of the frontend while others are flag of the > backing storage. Add capability which will allow expressing it via the > frontend attribute. > >

[libvirt] [PATCH v2 68/73] qemu: Properly avoid cancelling memory-only dump

migrate_cancel QMP command cannot be used for cancelling memory-only dumps and priv->job.dump_memory_only is used for reporting an error if someone calls virDomainAbortJob when memory-only dump job is running. Since commit 150930e3098 the dump_memory_only flag is set only dump-guest-memory

[libvirt] [PATCH v2 65/73] qemumigparamstest: Add basic test data

Signed-off-by: Jiri Denemark --- tests/qemumigparamsdata/basic.json | 9 + tests/qemumigparamsdata/basic.reply | 12 tests/qemumigparamsdata/basic.xml | 11 +++ tests/qemumigparamsdata/empty.json | 3 +++ tests/qemumigparamsdata/empty.reply

[libvirt] [PATCH 3/8] util: virhostdev: add virHostdevIsMdevDevice()

Add the function virHostdevIsMdevDevice() which detects whether a hostdev is a mediated device or not. Also, replace all existing conditionals. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski

[libvirt] [PATCH 8/8] news: documentation of new feature

Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Boris Fiuczynski --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 798ab6da40..41bd2ab372 100644 --- a/docs/news.xml

[libvirt] [PATCH v2 63/73] qemu: Properly reset migration params when libvirtd restarts

To be able to restore all migration parameters when libvirtd is restarting during an active migration job, we need to store the original values of all parameters (stored in priv->job.migParams) in the status XML. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c

Re: [libvirt] [PATCH 5/6] qemu: Format 'write-cache' parameter for disk frontends

On 04/04/2018 04:13 AM, Peter Krempa wrote: > The disk cache mode translates to various frontend and backend > attributes for the qemu block layer. For the frontend device the > 'writeback' parameter is used and provided as 'write-cache'. Implement > this so that we can later switch to using

[libvirt] [PATCH v1 6/7] tests: Update qemucapabilitiesdata

Signed-off-by: Michal Privoznik --- .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 +- .../caps_2.10.0.aarch64.replies| 30 +- tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 2

[libvirt] [PATCH v1 0/7] Enable memory-backend-file.discard-data

Qemu introduced this in 11ae6ed8affdd13. A small refactor is needed however. Michal Privoznik (7): qemu: Rename qemuMonitorGetObjectProps to qemuMonitorGetDeviceProps qemu_capabilities: s/ObjectProps/DeviceProps/g qemu_capabilities: Separate out device props fetching qemu_monitor:

[libvirt] [PATCH v1 3/7] qemu_capabilities: Separate out device props fetching

The code is written generic enough to be reused. Move it into a separate function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 62 ++-- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git

[libvirt] [PATCH v1 5/7] qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

This capability tracks if memory-backend-file has discard-data attribute or not. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 17 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 18 insertions(+) diff --git

[libvirt] [jenkins-ci PATCH] guests: Introduce libvirt+mingw project

Instead of cramming the dependencies that we need for a MinGW build of libvirt along with those we need for a native build, create a new project for the former. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-fedora-rawhide/main.yml | 1 +

[libvirt] [PATCH] bhyve: add support for passing stdin to loader

This commit adds the node to the domain definition, with the following semantics: To pass standard input verbatim to the bootloader, set some stdin Multiline standard input can be set using a CDATA tag: Standard input can be read from a file as follows: Signed-off-by: Fabian

Re: [libvirt] [RFC v2] external (pull) backup API

On 04/13/2018 05:47 AM, Nikolay Shirokovskiy wrote: >>> However as we use chain of disabled bitmaps with one active bitmap on tip >>> of the chain and qemu does not track their order we need to do it in >>> libvirt. >>> >> Well, you seem to be tracking it in *qemu*, by using the name field. >>

Re: [libvirt] [RFC v2] external (pull) backup API

On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote: > It's not easier, as we'll have to implement either separate of bitmaps > concept of checkpoints, which will be based on bitmaps, and we'll have > to negotiate and implement storing these objects to qcow2 and migrate > them. Or we'll

Re: [libvirt] [RFC v2] external (pull) backup API

13.04.2018 21:02, John Snow wrote: On 04/13/2018 08:01 AM, Vladimir Sementsov-Ogievskiy wrote: 1. It looks unsafe to use nbd server + backup(sync=none) on same node, synchronization is needed, like in block/replication, which uses backup_wait_for_overlapping_requests, backup_cow_request_begin,

Re: [libvirt] [PATCH] acl: remove various left over Xen ACL whitelist entries

On Thu, Apr 12, 2018 at 04:24:18PM +0100, Daniel P. Berrangé wrote: The legacy xen driver is removed, so these ACLL hacks can be removed s/LL/L/ too now. Signed-off-by: Daniel P. Berrangé --- src/check-aclrules.pl | 23 --- 1 file changed, 4

Re: [libvirt] [PATCH v4 01/14] virstoragefile: Introduce virStoragePRDef

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > This is a definition that holds information on SCSI persistent > reservation settings. The XML part looks like this: > > > > > > If @managed is set to 'yes' then the is not parsed. > This design was agreed on here: > >

[libvirt] [PATCH v2 2/2] vmware: Failures in cache info init are non-fatal

This is also not fatal on other drivers. Signed-off-by: Rainer Müller --- src/vmware/vmware_conf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 891d9a47f..b9f18e6ac 100644 ---

[libvirt] [jenkins-ci PATCH] guests: Only attempt to fix intltool-update if it exists

If we're running against a freshly-provisioned FreeBSD guest, intltool won't have been installed yet and attempts to fix it will fail. Make sure the file exists. Signed-off-by: Andrea Bolognani --- guests/tasks/kludges.yml | 8 1 file changed, 8 insertions(+) diff

Re: [libvirt] [PATCH v4 03/14] qemu: Introduce pr-manager-helper capability

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > The capability tracks if qemu has pr-manager-helper object. At > this time don't actually detect if qemu has the capability. Not > just yet. Only after the code is written the feature will be > enabled. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [dbus PATCH v3 00/20] More APIs for Domain Interface

On Fri, Apr 13, 2018 at 01:15:11PM +0200, Katerina Koukiou wrote: > Changes from v2: > Adjusted to reviews. > > Katerina Koukiou (20): > Implement Setter for Autostart property for Domain interface > Implement SchedulerType property for Domain Interface > Implement MemoryStats for Domain

Re: [libvirt] [PATCH jenkins-ci 1/2] Enable mingw build for libvirt-glib project

On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote: > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > > diff --git a/guests/vars/projects/libvirt-glib.yml > > b/guests/vars/projects/libvirt-glib.yml > > index 13a5128..bb21ae0 100644 > > ---

Re: [libvirt] [dbus PATCH v3 18/20] Implement MigrateSetMaxSpeed method for Domain Interface

On Fri, Apr 13, 2018 at 01:15:29PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 25 + > 2 files changed, 31 insertions(+) [...] > +static void >

Re: [libvirt] [RFC v2] external (pull) backup API

On 13.04.2018 12:07, Daniel P. Berrangé wrote: > On Tue, Apr 03, 2018 at 03:01:22PM +0300, Nikolay Shirokovskiy wrote: >> *Temporary snapshot API* >> >> In previous version it is called 'Fleece API' after qemu terms and I'll still >> use BlockSnapshot prefix for commands as in previous RFC

Re: [libvirt] [PATCH v2 40/73] qemu: Call qemuMigrationAnyCompressionParse only from driver

On Wed, Apr 11, 2018 at 04:41:30PM +0200, Jiri Denemark wrote: Propagate the calls up the stack to the point where qemuMigrationParamsFromFlags is called. The end goal achieved in the following few patches is to merge compression parameters into the general migration parameters code.

Re: [libvirt] [PATCH v2 33/73] qemu: Check supported caps in qemuMigrationParamsCheck

On Wed, Apr 11, 2018 at 04:41:23PM +0200, Jiri Denemark wrote: Instead of checking each capability at the time we want to set it in qemuMigrationParamsSetCapability we can check all of them at once in qemuMigrationParamsCheck. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [RFC v2] external (pull) backup API

13.04.2018 12:16, Nikolay Shirokovskiy wrote: On 13.04.2018 00:16, John Snow wrote: On 04/03/2018 08:01 AM, Nikolay Shirokovskiy wrote: Hi, all. This is another RFC on pull backup API. This API

Re: [libvirt] [PATCH v2 44/73] qemu: Move qemuMigrationAnyCompression*

On Wed, Apr 11, 2018 at 04:41:34PM +0200, Jiri Denemark wrote: The code really belongs to qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 140 - src/qemu/qemu_migration.h| 19

Re: [libvirt] [PATCHv2 1/4] Introduce QEMU_CAPS_SECCOMP_BLACKLIST

On 04/10/2018 10:49 AM, Ján Tomko wrote: > QEMU commit 1bd6152 changed the default behavior from whitelist > to blacklist and introduced a few sets of system calls. > > Use the 'elevateprivileges' parameter of -sandbox as a witness > of this change. > >

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, Apr 13, 2018 at 02:36:57PM +0200, Andrea Bolognani wrote: > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > [...] > > + mingw32-gtk-vnc: > > +FedoraRawhide: mingw32-gtk-vnc > > This (and the corresponding mingw64 entry) will drag in the version > of the library based

Re: [libvirt] [PATCH v2 39/73] qemu: Set migration capabilities automatically

On Wed, Apr 11, 2018 at 04:41:29PM +0200, Jiri Denemark wrote: Most migration capabilities are directly connected with virDomainMigrateFlags so qemuMigrationParamsFromFlags can automatically enable them. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c|

[libvirt] [dbus PATCH v3 19/20] Implement SetMemory method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 26 ++ 2 files changed, 32 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 838ebed..dc1df26 100644

Re: [libvirt] [PATCH] qemu: remove obsolete qemuMonitorMigrateToCommand

On Thu, Apr 12, 2018 at 11:10:34AM +0100, Daniel P. Berrangé wrote: The last use of qemuMonitorMigrateToCommand was removed years back in commit 2e90c9daf9eabe15d826a48c06607acb9d18fda6 Author: Daniel P. Berrange Date: Fri Nov 6 16:50:26 2015 + qemu: assume

[libvirt] [PATCH 05/10] conf: Add flag to regenerate genid for virDomainDefCopy

Add the VIR_DOMAIN_DEF_COPY_NEWGENID to indicate that the generated domain definition should adjust the genid value before returning the @def to the caller. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 12 src/conf/domain_conf.h | 5 +

Re: [libvirt] virNetSocketNewListenTCP tries just one address

On Wed, Mar 28, Olaf Hering wrote: > > How can libvirt tell whether this is a misconfiguration of DNS or host's > > interfaces? > By simply cycling through the 'runp' list to see if any bind() succeeds? This change fixes /etc/sysconfig/network/ifcfg-br0:BOOTPROTO='dhcp4' for me. Just keep going

[libvirt] [PATCH 00/10] Add support for VM Generation ID (vmgenid)

As a result of the RFC: https://www.redhat.com/archives/libvir-list/2018-March/msg01214.html Patches to support changes for https://bugzilla.redhat.com/show_bug.cgi?id=1149445 The first patch isn't necessarily related, but since it I was looking at the all the virUUIDGenerate calls, I figured

[libvirt] [PATCH 04/10] conf: Add VM Generation ID to virDomainDef

Add a genid[] field to be able to store a uuid-like GUID value. Also add associated bool's to support VM Generation ID operation. Signed-off-by: John Ferlan --- src/conf/domain_conf.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/conf/domain_conf.h

Re: [libvirt] [RFC v2] external (pull) backup API

On 11.04.2018 19:32, Eric Blake wrote: > On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote: >> Hi, all. >> >> >>

[libvirt] [dbus PATCH 0/6] More methods for Domain interface

Katerina Koukiou (6): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain

[libvirt] [dbus PATCH 1/6] Implement Setter for Autostart property for Domain interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 +++-- src/domain.c| 22 +- test/test_domain.py | 7 +++ 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/data/org.libvirt.Domain.xml

Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

On Thu, Apr 12, 2018 at 09:14 AM +0200, Michal Privoznik wrote: > In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into > virObject. Well, this requires 'virObject' member to be stored on > the first position of the struct. This adjustment is missing in > the

[libvirt] [PATCH libvirt v2 0/9] Fix virConnectRegisterCloseCallback and get rid of global variables

The first part of this patch series fixes the behavior of virConnectRegisterCloseCallback and converts the testDriver to virObjectLockable. The subsequent patches remove the need to have the global variables 'qemuProgram' and 'remoteProgram' in libvirtd.[ch]. They only work in combination with

Re: [libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > We require QEMU >= 0.15.0, assume every QEMU supports it. s/0.15.0/1.5.0/ Unless the usable monitor was introduced in 0.15.0, in which case your version is more precise. > Sadly that does not let us trivially drop qemuMonitor's >

[libvirt] [PATCH] syntax-check: check QEMU caps grouping

Introduce a perl script that is able to regroup both the QEMU_CAPS constants and the capability strings. Check correct grouping as a part of syntax check. For in-place regrouping after a rebase, just run: tests/group-qemu-caps.pl without any parameters. Signed-off-by: Ján Tomko

Re: [libvirt] [jenkins-ci PATCH 04/10] guests: Move ccache configuration to shell profile

On Thu, Apr 05, 2018 at 02:22:14PM +0200, Andrea Bolognani wrote: > Now that we have our custom shell profile, making sure ccache > is used is way simpler. > > Signed-off-by: Andrea Bolognani > --- > guests/tasks/users.yml | 18 -- > guests/templates/bashrc

Re: [libvirt] path for user provided all-guest-read-only content

On Wed, Apr 11, 2018 at 05:01:04PM +0200, Christian Ehrhardt wrote: > Feel free to read [1] for context, here the quote that made me poll for > opinions: > "it would be nice in the future to have some standardized path for user > provided guest-read-only stuff" > > The TL;DR of their case is: >

Re: [libvirt] [PATCH 2/8] qemu: introduce vfio-ccw capability

On Wed, 11 Apr 2018 17:49:53 +0200 Shalini Chellathurai Saroja wrote: > Let us introduce the capability vfio-ccw for supporting the basic > channel I/O passthrough, which have been introduced in QEMU 2.10. The > current focus is to support dasd-eckd (cu_type/dev_type

Re: [libvirt] [jenkins-ci PATCH] guests: Clean up packages after update

On Mon, Apr 09, 2018 at 03:56:05PM +0200, Andrea Bolognani wrote: > The package cache can grow to eat up a lot of disk space, and > not removing unused packages can lead to upgrade issues down > the line for fast moving distributions such as Fedora Rawhide. > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > Implied by QEMU >= 1.2.0. > > Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used > when QEMU_CAPS_NO_USER_CONFIG is unsupported. Is there a specific reason for the 6-patch gap between dropping NO_USER_CONFIG and dropping

[libvirt] [not libvirt PATCH] rcc - resolve capabilities conflicts

my tool for naively resolving qemu capabilities conflicts after a rebase, that used to contain my latest syntax-check addition --- rcc | 62 ++ 1 file changed, 62 insertions(+) create mode 100755 rcc diff --git a/rcc b/rcc new file

Re: [libvirt] [PATCH v2 48/73] qemu: Introduce qemuMigrationParamsFetch

On Wed, Apr 11, 2018 at 04:41:38PM +0200, Jiri Denemark wrote: Let's separate the code which queries QEMU for migration parameters from qemuMigrationParamsCheck into a dedicated function. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 56

Re: [libvirt] [PATCH v2 56/73] qemu: Refactor qemuMigrationParams

On Wed, Apr 11, 2018 at 04:41:46PM +0200, Jiri Denemark wrote: Adding support for new migration parameter requires a lot of places to be changed (most likely by copy engineering): new variables to store the parameter value and the associated *_set bool, JSON formatter and parser, XML formatter

[libvirt] [PATCH 4/9] src: Unify virObject member name

Whenever we declare a new object the first member of the struct has to be virObject (or any other member of that family). Now, up until now we did not care about the name of the struct member. But lets unify it so that we can do some checks at compile time later. The unified name is 'parent'.

Re: [libvirt] [PATCHv2 4/4] qemu: deny privilege elevation and spawn in seccomp

On Fri, Apr 13, 2018 at 10:08:34AM -0400, John Ferlan wrote: > > > On 04/10/2018 10:49 AM, Ján Tomko wrote: > > If QEMU uses a seccomp blacklist (since 2.11), -sandbox on > > no longer tries to whitelist all the calls, but uses sets > > of blacklists: > > default (always blacklisted with

Re: [libvirt] [PATCH v2 53/73] qemu: Move migration parameters JSON formatting

On Wed, Apr 11, 2018 at 04:41:43PM +0200, Jiri Denemark wrote: We want to have all migration parameters parsing and formatting at one place, i.e., in qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 68

Re: [libvirt] [PATCH v2 45/73] qemu: Hide qemuMigrationParamsSetCompression

On Wed, Apr 11, 2018 at 04:41:35PM +0200, Jiri Denemark wrote: There's no need to call this API explicitly in the migration code. We can pass the compression parameters to qemuMigrationParamsFromFlags and it can internally call qemuMigrationParamsSetCompression to apply them to the

Re: [libvirt] [PATCH v2 46/73] qemu: Replace qemuMigrationAnyCompressionDump

On Wed, Apr 11, 2018 at 04:41:36PM +0200, Jiri Denemark wrote: Since every parameter or capability set in qemuMigrationCompression structure is now reflected in qemuMigrationParams structure, we can replace qemuMigrationAnyCompressionDump with a new API which will work on qemuMigrationParams.

[libvirt] [PATCH 5/9] src: Unify dispose function names

If a function is disposing virSomething it should be called virSomethingDispose(). There are two offenders: virCapabilitiesDispose(virCapsPtr) and virDomainXMLOptionClassDispose(virDomainXMLOptionPtr). Signed-off-by: Michal Privoznik --- src/conf/capabilities.c | 6 +++---

Re: [libvirt] [PATCH v2 49/73] qemu: Limit usage of qemuMonitorMigrationParams

On Wed, Apr 11, 2018 at 04:41:39PM +0200, Jiri Denemark wrote: Use this internal structure only in qemu_migration_params.c and change other non-test users to use the high level qemuMigrationParams struct. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c |

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > diff --git a/guests/vars/projects/virt-viewer.yml > b/guests/vars/projects/virt-viewer.yml > index 6f3dbf9..85d1589 100644 > --- a/guests/vars/projects/virt-viewer.yml > +++ b/guests/vars/projects/virt-viewer.yml > @@ -6,5 +6,29 @@

Re: [libvirt] [PATCH 2/6] tests: qemuxm2argv: Add infrastructure for testing with real qemuCaps

On Wed, Apr 11, 2018 at 11:16:27AM -0400, John Ferlan wrote: On 04/04/2018 04:13 AM, Peter Krempa wrote: Allow testing of XML->argv conversion with using a real capability map as used in the qemucapabilitiestest. This allows specifying the required qemu version with the test rather than

Re: [libvirt] [PATCH v2 60/73] qemu: Check remote caps when enabling always-on capabilities

On Wed, Apr 11, 2018 at 04:41:50PM +0200, Jiri Denemark wrote: When an always-on migration capability is supposed to be enabled on both sides of migration, each side can only enable the feature if it is enabled by the other side. Thus the source host sends a list of supported migration

Re: [libvirt] [PATCH v2 61/73] qemu: Generalize qemuMigrationParamsGetDowntimeLimit

On Wed, Apr 11, 2018 at 04:41:51PM +0200, Jiri Denemark wrote: The API is renamed as qemuMigrationParamsGetULL and it can be used with any migration parameter stored as unsigned long long. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 9 -

[libvirt] [PATCH 1/2] lxc: s/subtreee/subtree/

Signed-off-by: Radostin Stoyanov --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 532fd0be0..665b93a0a 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c

[libvirt] [PATCH 0/2] Trivial fixes

Radostin Stoyanov (2): lxc: s/subtreee/subtree/ lxc: Clean up /.oldroot src/lxc/lxc_container.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] lxc: Clean up /.oldroot

Remove the /.oldroot directory after it has been unmounted (at the end of lxcContainerSetupPivotRoot). Ignore errors silently. Signed-off-by: Radostin Stoyanov --- src/lxc/lxc_container.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lxc/lxc_container.c

[libvirt] [RFC 0/3] LXC with block device and enabled userns

Problem background -- The LXC driver has support for the filesystem types "file" and "block" that allow a disk image to be mounted in the guest (container). [1] However, when user-namespace is enabled (uid/gid mapping is used) the mount of the root filesystem block device fails.

[libvirt] [RFC 1/3] lxc: Make lxcContainerMountFSBlock non static

--- src/lxc/lxc_container.c | 5 + src/lxc/lxc_container.h | 4 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 532fd0be0..3b8cb966e 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -113,9 +113,6

[libvirt] [RFC 2/3] lxc: Move up virLXCControllerAppendNBDPids

There is no functional change in this patch. It only moves virLXCControllerAppendNBDPids above virLXCControllerSetupNBDDeviceFS. --- src/lxc/lxc_controller.c | 96 1 file changed, 49 insertions(+), 47 deletions(-) diff --git

[libvirt] [RFC 3/3] lxc: Mount NBD devices before clone

When user-namespace is enabled we are not allowed to mount block/NBD devices. Instead, mount /dev/nbdX to /run/libvirt/lxc/.root and set: fs->src->path = /run/libvirt/lxc/.root fs->type = VIR_DOMAIN_FS_TYPE_MOUNT --- src/lxc/lxc_container.c | 53

<    1   2