btrfs encryption problems

Hi to all, I have a hard drive encrypted using the gnome disk utility and it is formated with with btrfs and GUID, the problem started when moving a 4gb file to other disk it stooped saying input output error I think, then when I tried to access it I entered the password to decrypt and it now says

Re: btrfs encryption problems

810d4rk wrote (ao): Hi to all, I have a hard drive encrypted using the gnome disk utility and it is formated with with btrfs and GUID, the problem started when moving a 4gb file to other disk it stooped saying input output error I think, then when I tried to access it I entered the password to

Re: Announcing btrfs-gui

On Sat, Nov 12, 2011 at 01:24:57AM +0100, Amedee Van Gasse wrote: On 02-06-11 01:20, Hugo Mills wrote: Unless the traffic gets too high-volume, or unless someone important objects, I'm going to suggest that bug reports should go to this list for now (cc'd me, if you like). Note that this

Re: [PATCH 0/3] Show Chunks by position

On Tue, Nov 22, 2011 at 08:12:43PM -0500, Phillip Susi wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2011 10:50 AM, Phillip Susi wrote: This is a nice little tool. The one suggestion that I have is that it display the actual chunks and where they are located. It seems

btrfs and load (sys)

I've been using btrfs for two months now. Every day between 02:00 and 08:00 I rsync some 300GB data (milions of files) to btrfs device and then make snapshot. Next day i rsync again 300GG little changed (rsync in place). First days it worked perfectly. Then loadavg (sys load) started to rise. Now,

Re: btrfs and load (sys)

Yes, yesterday I've umouted partition and re-mounted it. Nothing has changed this night. You can look at my load graphs here: http://img42.imageshack.us/img42/4661/33737291.png http://img210.imageshack.us/img210/2742/46527625.png On the second one blue is SYS load. I bet you can reasily spot

Re: [PATCH] Btrfs: rewrite btrfs_trim_block_group()

On Thu, Nov 17, 2011 at 03:26:17PM +0800, Li Zefan wrote: diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 8c32434..89cc54e 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c +static int trim_no_bitmap(struct btrfs_block_group_cache

mounting btrfs FS on zfs zvol hangs

Hiya, yes, you'll probably think that is crazy, but after observing better performance with btrfs in some work loads on md RAID5 than btrfs builtin RAID10, I thought I'd try btrfs on zfs (in-kernel, not fuse) zvol (on raidz) just for a laugh. While this procedure worked for ext4 and xfs, for

Re: fsck with err is 1

On Nov 22, 2011, at 10:02 PM, Fajar A. Nugraha wrote: On Wed, Nov 23, 2011 at 12:33 PM, Blair Zajac bl...@orcaware.com wrote: Hello, I'm trying btrfs in a VirtualBox VM running Ubuntu 11.10 with kernel 3.0.0. Running fsck I get a message with err is 1. Does this mean there's an error?

Re: btrfs and load (sys)

On 11/23/2011 9:43 AM, krz...@gmail.com wrote: What all those btrfs benchmark does not tell you that its performance decreases (sys load increases) with growing size of btree. Creating btrfs filesystem is instantaneous because initial tree is just nothing... While something is clearly wrong,

stripe alignment consideration for btrfs on RAID5

Hiya, is there any recommendation out there to setup a btrfs FS on top of hardware or software raid5 or raid6 wrt stripe/stride alignment? From mkfs.btrfs, it doesn't look like there's much that can be adjusted that would help, and what I'm asking might not even make sense for btrfs but I

Re: stripe alignment consideration for btrfs on RAID5

On Nov 23, 2011, at 9:04 AM, Stephane CHAZELAS wrote: Hiya, is there any recommendation out there to setup a btrfs FS on top of hardware or software raid5 or raid6 wrt stripe/stride alignment? Isn't the advantage of having btrfs do all the raiding itself so one gets the checksums? If one

Re: fsck with err is 1

Hallo, Blair, Du meintest am 23.11.11: I can't answer that, but I can tell you that fsck for btrfs right now is almost useless. It can't fix anyting. Thank you, I've read that fsck doesn't fix anything. I was curious if doing the scrub would resolve it. I had tried ... about 4 Tbyte data

Re: Announcing btrfs-gui

On Wed, Nov 23, 2011 at 6:33 AM, Hugo Mills h...@carfax.org.uk wrote: On Sat, Nov 12, 2011 at 01:24:57AM +0100, Amedee Van Gasse wrote: On 02-06-11 01:20, Hugo Mills wrote:    Unless the traffic gets too high-volume, or unless someone important objects, I'm going to suggest that bug reports

Re: fsck with err is 1

On 23.11.2011 18:32, Helmut Hullen wrote: One big problem of btrfs seems to be: you can't see on which partition/ disk the defect sector (or something else) may be A recent kernel (3.2, still rc) will tell you the byte number when an error occurs, and also give the the opportunity to resolve

Re: stripe alignment consideration for btrfs on RAID5

2011-11-23, 09:08(-08), Blair Zajac: On Nov 23, 2011, at 9:04 AM, Stephane CHAZELAS wrote: Hiya, is there any recommendation out there to setup a btrfs FS on top of hardware or software raid5 or raid6 wrt stripe/stride alignment? Isn't the advantage of having btrfs do all the raiding

Re: fsck with err is 1

Hallo, Jan, Du meintest am 23.11.11: One big problem of btrfs seems to be: you can't see on which partition/ disk the defect sector (or something else) may be A recent kernel (3.2, still rc) will tell you the byte number when an error occurs, and also give the the opportunity to resolve

Re: btrfs encryption problems

dd that backup disk to another disk, so you have a backup of your backup, and work with that. OK. You can also post the dmesg output you get when you mount the broken filesystem, and ask the experts if it might be worth to try experimental btrfs.fsck on it. dmesg does not output anything

[PATCH 1/2] Removed extraneous whitespace from mkfs man page

There were extra spaces around some of the arguments in the man page for mkfs. --- man/mkfs.btrfs.8.in | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in index 432db1b..542e6cf 100644 --- a/man/mkfs.btrfs.8.in +++

[PATCH 2/2] Document --rootdir mkfs switch

--- man/mkfs.btrfs.8.in |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in index 542e6cf..25e817b 100644 --- a/man/mkfs.btrfs.8.in +++ b/man/mkfs.btrfs.8.in @@ -12,6 +12,7 @@ mkfs.btrfs \- create an btrfs filesystem [

Re: [PATCH 1/2] Removed extraneous whitespace from mkfs man page

On Wed, Nov 23, 2011 at 04:25:30PM -0500, Phillip Susi wrote: There were extra spaces around some of the arguments in the man page for mkfs. Please resend with Signed-off-by: tag, and it would be helpful to prepend the subject with eg. btrfs-progs. thanks, david -- To unsubscribe from this

Re: btrfs and load (sys)

I've rebooted server and run backup to btrfs partition again. It seems that problem is gone, high sys load does not occur now. So it is some bug in btrfs... Before reboot server had 30 days uptime so its really not much. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in

[patch 04/99] btrfs: Simplify btrfs_insert_root

btrfs_insert_root is just a wrapper for btrfs_insert_item. Just return the error directly. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/root-tree.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c index

[patch 45/99] btrfs: run_scheduled_bios should return void

run_scheduled_bios has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/volumes.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c

[patch 98/99] btrfs: btrfs_destroy_pending_snapshots should return void

btrfs_destroy_pending_snapshots has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -53,7 +53,7 @@ static void

[patch 99/99] btrfs: add_excluded_extent should return void

add_excluded_extent has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent-tree.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -206,15 +206,14 @@

[patch 94/99] btrfs: btrfs_free_fs_root should return void

btrfs_free_fs_root has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |3 +-- fs/btrfs/disk-io.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2733,7 +2733,7

[patch 92/99] btrfs: btrfs_add_ordered_operation should return void

btrfs_add_ordered_operation has no error conditions and should return void Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c | 11 --- fs/btrfs/ordered-data.h |6 +++--- 2 files changed, 7 insertions(+), 10 deletions(-) --- a/fs/btrfs/ordered-data.c +++

[patch 97/99] btrfs: btrfs_destroy_ordered_extents should return void

btrfs_destroy_ordered_extents has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -50,7 +50,7 @@ static void

[patch 95/99] btrfs: del_fs_roots should return void

del_fs_roots has no error conditions and should return void Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2764,7 +2764,7 @@ static void free_fs_root(struct

[patch 93/99] btrfs: btrfs_add_ordered_sum should return void

btrfs_add_ordered_sum has no error conditions and should return void Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c |7 +++ fs/btrfs/ordered-data.h |6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-) --- a/fs/btrfs/ordered-data.c +++

[patch 96/99] btrfs: btrfs_destroy_ordered_operations should return void

btrfs_destroy_ordered_operations has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -49,7 +49,7 @@ static void

[patch 91/99] btrfs: btrfs_run_ordered_operations should return void

btrfs_run_ordered_operations has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c |4 +--- fs/btrfs/ordered-data.h |2 +- 2 files changed, 2 insertions(+), 4 deletions(-) --- a/fs/btrfs/ordered-data.c +++

[patch 88/99] btrfs: __btrfs_remove_ordered_extent should return void

__btrfs_remove_ordered_extent has no error conditions and should return void. Once that happens, btrfs_remove_ordered_extent has no error conditions can can also return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c | 15 +-- fs/btrfs/ordered-data.h

[patch 90/99] btrfs: btrfs_wait_ordered_range should return void

btrfs_wait_ordered_range has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c |3 +-- fs/btrfs/ordered-data.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/ordered-data.c +++

[patch 86/99] btrfs: update_inline_extent_backref should return void

Now that btrfs_truncate_item returns void, there are no more error conditions in update_inline_extent_backref and it should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent-tree.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) ---

[patch 83/99] btrfs: btrfs_extend_item should return void

btrfs_extend_item has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.c |7 +++ fs/btrfs/ctree.h |5 +++-- fs/btrfs/dir-item.c|5 ++--- fs/btrfs/extent-tree.c |5 ++--- fs/btrfs/file-item.c |2 +-

[patch 82/99] btrfs: btrfs_truncate_item should return void

btrfs_truncate_item has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.c | 11 +-- fs/btrfs/ctree.h |8 fs/btrfs/dir-item.c|4 ++-- fs/btrfs/extent-tree.c |3 +-- fs/btrfs/file-item.c |

[patch 84/99] btrfs: end_compressed_writeback should return void

end_compressed_writeback has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/compression.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/compression.c

[patch 87/99] btrfs: btrfs_put_ordered_extent should return void

btrfs_put_ordered_extent has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c |3 +-- fs/btrfs/ordered-data.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/ordered-data.c +++

[patch 85/99] btrfs: copy_for_split should return void

copy_for_split has no error conditions and should return void. We return 0 from split_leaf instead of ret since ret would have been set using the return value from copy_for_split which would have been 0. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.c | 19

[patch 89/99] btrfs: btrfs_wait_ordered_extents should return void

btrfs_wait_ordered_extents has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ordered-data.c |5 ++--- fs/btrfs/ordered-data.h |4 ++-- fs/btrfs/transaction.c |3 +-- 3 files changed, 5 insertions(+), 7 deletions(-) ---

[patch 43/99] btrfs: clear_extent_buffer_dirty should return void

clear_extent_buffer_dirty has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |3 +-- fs/btrfs/extent_io.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) ---

[patch 76/99] btrfs: Delayed ref mempool functions should return void

Now that the delayed ref code uses mempools, allocations can't fail, and there are no more error conditions to report. This patch makes the following functions return void: - btrfs_alloc_reserved_file_extent - btrfs_add_delayed_tree_ref - btrfs_add_delayed_data_ref -

[patch 80/99] btrfs: __btrfs_mod_ref should return void

Now that process_func can't return an error, __btrfs_mod_ref has no more error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.c | 30 ++ fs/btrfs/ctree.h |8 fs/btrfs/extent-tree.c | 34

[patch 39/99] btrfs: __unlock_for_delalloc should return void

__unlock_for_delalloc has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) --- a/fs/btrfs/extent_io.c +++

[patch 41/99] btrfs: check_page_locked should return void

check_page_locked has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/btrfs/extent_io.c +++

[patch 44/99] btrfs: btrfs_cleanup_fs_uuids should return void

btrfs_cleanup_fs_uuids has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/volumes.c |3 +-- fs/btrfs/volumes.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) ---

[patch 79/99] btrfs: __btrfs_mod_refs process_func should return void

__btrfs_mod_ref's process_func function pointer calls btrfs_free_extent and btrfs_inc_extent_ref, which now both return only 0. This patches makes them return void and eliminates the error condition in __btrfs_mod_ref. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |

[patch 81/99] btrfs: clean_tree_block should return void

clean_tree_block has no error conditions and should return void. Its callers already ignore the error codes. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |5 ++--- fs/btrfs/disk-io.h |4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[patch 78/99] btrfs: btrfs_free_extent void return prep

btrfs_free_extent has no error conditions, but is used via process_func in __btrfs_mod_ref which requires it to return an int. This patch cleans up the callers to eliminate error handling that will never be used. The next patch makes both btrfs_free_extent and the other function used via

[patch 75/99] btrfs: Use mempools for delayed refs

This patch converts the delayed ref code to use slab cache-backed mempools for allocating its nodes. The allocations happen deep in the call path where error recovery is impossible. By using mempools, we ensure that the allocations can't fail. Each mempool keeps a page of structures

[patch 77/99] btrfs: btrfs_inc_extent_ref void return prep

btrfs_inc_extent_ref has no error conditions, but is used via process_func in __btrfs_mod_ref which requires it to return an int. This patch cleans up the callers to eliminate error handling that will never be used. A later patch in this series makes both btrfs_inc_extent_ref and the other

[patch 73/99] btrfs: add_delayed_data_ref should return void

add_delayed_data_ref has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/delayed-ref.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c index

[patch 70/99] btrfs: insert_ptr should return void

insert_ptr has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.c | 46 +- 1 files changed, 13 insertions(+), 33 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index

[patch 74/99] btrfs: Fix kfree of member instead of structure

Correctness fix: The kfree calls in the add_delayed_* functions free the node that's passed into it, but the node is a member of another structure. It works because it's always the first member of the containing structure, but it should really be using the containing structure itself.

[patch 71/99] btrfs: add_delayed_ref_head should return void

add_delayed_ref_head has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/delayed-ref.c | 29 ++--- 1 files changed, 10 insertions(+), 19 deletions(-) diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c index

[patch 69/99] btrfs: del_ptr should return void

With fixup_low_keys now returning void, there are no error conditions for del_ptr to report so it should return void. We set ret = 0 explicitly in btrfs_del_items but I'm not convinced that the error handling code already there is correct. Signed-off-by: Jeff Mahoney je...@suse.com ---

[patch 67/99] btrfs: fixup_low_keys should return void

fixup_low_keys has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.c | 39 +++ 1 files changed, 11 insertions(+), 28 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index

[patch 64/99] btrfs: Factor out tree-ops-merge_bio_hook call

In submit_extent_page, there's a visually noisy if statement that, in the midst of other conditions, does the tree dependency for tree-ops and tree-ops-merge_bio_hook before calling it, and then another condition afterwards. If an error is returned from merge_bio_hook, there's no way to catch

[patch 72/99] btrfs: add_delayed_tree_ref should return void

add_delayed_tree_ref has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/delayed-ref.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c index

[patch 65/99] btrfs: -submit_bio_hook error push-up

This pushes failures from the submit_bio_hook callbacks, btrfs_submit_bio_hook and btree_submit_bio_hook into the callers, including callers of submit_one_bio where it catches the failures with BUG_ON. It also pushes up through the -readpage_io_failed_hook to end_bio_extent_writepage where

[patch 66/99] btrfs: __add_reloc_root error push-up

This patch pushes kmalloc errors up to the caller and BUGs in the caller. The BUG_ON for duplicate reloc tree root insertion is replaced with a panic explaining the issue. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/relocation.c | 22 -- 1 file changed, 16

[patch 63/99] btrfs: Simplify btrfs_submit_bio_hook

btrfs_submit_bio_hook currently calls btrfs_bio_wq_end_io in either case of an if statement that determines one of the arguments. This patch moves the function call outside of the if statement and uses it to only determine the different argument. This allows us to catch an error in one place

[patch 61/99] btrfs: setup_inline_extent_backref should return void

setup_inline_extent_backref has no error conditions and should return void. We set ret = 0 explicitly in insert_inline_extent_backref since it would have been set using the return value, which would have been 0. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent-tree.c | 23

[patch 60/99] btrfs: btrfs_set_block_group_rw should return void

btrfs_set_block_group_rw has no error conditions and should return void. Its callers already ignore the error codes anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |4 ++-- fs/btrfs/extent-tree.c |3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)

[patch 58/99] btrfs: btrfs_destroy_delalloc_inodes should return void

btrfs_destroy_delalloc_inodes has no error conditions and should return void. Its callers already ignore the error codes anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/btrfs/disk-io.c +++

[patch 59/99] btrfs: btrfs_prepare_extent_commit should return void

btrfs_prepare_extent_commit has no error conditions and should return void. Its callers already ignore the error codes anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |4 ++-- fs/btrfs/extent-tree.c |3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)

[patch 57/99] btrfs: __setup_root should return void

__setup_root has no error conditions and should return void. Its callers already ignore the error codes anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/disk-io.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c

[patch 55/99] btrfs: btrfs_init_compress should return void

btrfs_init_compress doesn't have any failure conditions, so return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/compression.c |3 +-- fs/btrfs/compression.h |2 +- fs/btrfs/super.c |5 + 3 files changed, 3 insertions(+), 7 deletions(-) diff --git

[patch 56/99] btrfs: btrfs_invalidate_inodes should return void

btrfs_invalidate_inodes has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |2 +- fs/btrfs/inode.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index

[patch 53/99] btrfs: btrfs_end_log_trans should return void

btrfs_end_log_trans has no error conditions and should return void. Its callers ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/tree-log.c |3 +-- fs/btrfs/tree-log.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[patch 52/99] btrfs: btrfs_requeue_work should return void

btrfs_requeue_work has no error conditions and should return void. Its callers ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/async-thread.c |7 ++- fs/btrfs/async-thread.h |2 +- 2 files changed, 3 insertions(+), 6 deletions(-) ---

[patch 50/99] btrfs: run_ordered_completions should return void

run_ordered_completions has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/async-thread.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/async-thread.c +++

[patch 54/99] btrfs: wait_for_writer should return void

wait_for_writer has no error conditions and should return void. Its callers already ignore the error codes anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/tree-log.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/tree-log.c

[patch 49/99] btrfs: btrfs_queue_worker should return void

btrfs_queue_worker has no error conditions and should return void. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/async-thread.c | 14 -- fs/btrfs/async-thread.h |2 +- 2 files changed, 5 insertions(+), 11 deletions(-) --- a/fs/btrfs/async-thread.c +++

[patch 47/99] btrfs: schedule_bio should return void

schedule_bio has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/volumes.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@

[patch 51/99] btrfs: btrfs_stop_workers should return void

btrfs_stop_workers has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/async-thread.c |3 +-- fs/btrfs/async-thread.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) ---

[patch 40/99] btrfs: check_page_uptodate should return void

check_page_uptodate has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/btrfs/extent_io.c +++

[patch 37/99] btrfs: wait_on_state should return void

wait_on_state has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/extent_io.c +++

[patch 38/99] btrfs: wait_extent_bit should return void

wait_extent_bit has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |3 +-- fs/btrfs/extent_io.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) ---

[patch 15/99] btrfs: try_lock_extent can drop gfp_t argumetn

All of the callers of try_lock_extent call it with gfp_t == GFP_NOFS. This patch simplifies the call sites by calling clear_extent_bit with GFP_NOFS from try_lock_extent itself. Since the extent io code will probably never be used outside of a file system, this is generally ok. If there are

[patch 48/99] btrfs: fill_device_from_item should return void

fill_device_from_item has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/volumes.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/btrfs/volumes.c +++

[patch 42/99] btrfs: check_page_writeback should return void

check_page_writeback has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/extent_io.c +++

[patch 46/99] btrfs: btrfs_close_extra_devices should return void

btrfs_close_extra_devices has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/volumes.c |3 +-- fs/btrfs/volumes.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) ---

[patch 02/99] btrfs: Catch locking failures in {set,clear,convert}_extent_bit

The *_state functions can only return 0 or -EEXIST. This patch addresses the cases where those functions returning -EEXIST represent a locking failure. It handles them by panicking with an appropriate error message. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c | 58

[patch 35/99] btrfs: btrfs_update_root error push-up

btrfs_update_root BUG's when it can't alloc a path, yet it can recover from a search error. This patch returns -ENOMEM instead. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |7 --- fs/btrfs/root-tree.c |4 +++- 2 files changed, 7 insertions(+), 4 deletions(-)

[patch 31/99] btrfs: btrfs_pin_extent error push-up

btrfs_pin_extent looks up a block group and then calls pin_down_extent with it. If the lookup fails, it should return -ENOENT to allow callers to handle the error condition. For the three existing callers, it is a logic error if the lookup fails and a panic will occur. Signed-off-by: Jeff

[patch 32/99] btrfs: btrfs_drop_snapshot should return int

Commit cb1b69f4 (Btrfs: forced readonly when btrfs_drop_snapshot() fails) made btrfs_drop_snapshot return void because there were no callers checking the return value. That is the wrong order to handle error propogation since the caller will have no idea that an error has occured and continue on

[patch 33/99] btrfs: btrfs_start_transaction non-looped error push-up

This patch handles btrfs_start_transaction failures that don't occur in a loop and are obvious to simply push up. In all cases except the mark_garbage_root case, the error is already handled by BUG_ON in the caller. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent-tree.c |6

[patch 36/99] btrfs: set_range_writeback should return void

set_range_writeback has no error conditions and should return void. Its callers already ignore the error code anyway. There are internal error conditions but they are fatal and will cause a panic. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c |8 +--- 1 file

[patch 28/99] btrfs: clear_extent_bit error push-up

clear_extent_bit can fail with -ENOMEM for a specific case but will BUG on other memory allocation failures. This patch returns -ENOMEM for memory allocation failures and handles them with BUG_ON in callers which don't handle it already. Signed-off-by: Jeff Mahoney je...@suse.com ---

[patch 30/99] btrfs: pin_down_extent should return void

pin_down_extent performs some operations which can't fail and then calls set_extent_dirty, which has two failure cases via set_extent_bit: 1) Return -EEXIST if exclusive bits are set - Since it doesn't use any exclusive bits, this failure case can't occur. 2) Return -ENOMEM if

[patch 29/99] btrfs: convert_extent_bit should return void with __GFP_WAIT set

Now that allocations that are allowed to sleep can't fail, convert_extent_bit has no more error conditions and we can assume the return value will be 0 and return void to callers. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c | 18 ++

[patch 25/99] btrfs: set_extent_bit can drop gfp_t argument

Now that all of the callers of set_extent_bit use GFP_NOFS and all callers of set_extent_bit_atomic use GFP_ATOMIC, we can drop the gfp_t argument to both. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c | 35 +++ fs/btrfs/extent_io.h |

[patch 21/99] btrfs: set_extent_bits can drop gfp_t argument

Now that all of the callers of set_extent_bits use GFP_NOFS, we can drop the gfp_t argument entirely and allow set_extent_bits to always pass GFP_NOFS. Since the extent io code will probably never be used outside of a file system, this is generally ok. If there are new callers, they can add

[patch 24/99] btrfs: set_extent_uptodate can drop gfp_t argument

Now that all of the callers of set_extent_uptodate use GFP_NOFS or GFP_ATOMIC, we can drop the gfp_t argument entirely and allow set_extent_uptodate to always pass GFP_NOFS to set_extent_bit or GFP_ATOMIC to set_extent_bit_atomic. Since the extent io code will probably never be used outside

[patch 27/99] btrfs: set_extent_bit should return -ENOMEM on GFP_ATOMIC failures

The only failure condition is for GFP_ATOMIC allocations. Push up to callers which are already handling it. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent_io.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) Index:

[patch 23/99] btrfs: set_extent_new can drop gfp_t argument

Now that all of the callers of set_extent_new use GFP_NOFS, we can drop the gfp_t argument entirely and allow set_extent_new to always pass GFP_NOFS. Since the extent io code will probably never be used outside of a file system, this is generally ok. If there are new callers, they can add

[patch 19/99] btrfs: lock_extent can drop gfp_t argument

All of the callers of lock_extent call it with gfp_t == GFP_NOFS. This patch simplifies the call sites by calling clear_extent_bit with GFP_NOFS from lock_extent itself. Since the extent io code will probably never be used outside of a file system, this is generally ok. If there are new

  1   2   >