Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-09 Thread Oliver Endriss
Michael Krufky wrote: Oliver Endriss wrote: Manu Abraham wrote: On 8/6/07, Michael Krufky [EMAIL PROTECTED] wrote: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-08 Thread Manu Abraham
On 8/8/07, Oliver Endriss [EMAIL PROTECTED] wrote: Manu Abraham wrote: On 8/6/07, Michael Krufky [EMAIL PROTECTED] wrote: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-08 Thread Michael Krufky
Oliver Endriss wrote: Manu Abraham wrote: On 8/6/07, Michael Krufky [EMAIL PROTECTED] wrote: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be checking

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-08 Thread Manu Abraham
On 8/9/07, Michael Krufky [EMAIL PROTECTED] wrote: I apologize for my delayed response -- I had to leave town unexpectedly. The above is OK with me. As I understand it, we cannot remove fe-ops.info.frequency_max|min because it is part of the userspace API. I wasn't thinking about that fact

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-08 Thread Michael Krufky
Manu Abraham wrote: On 8/9/07, Michael Krufky [EMAIL PROTECTED] wrote: I apologize for my delayed response -- I had to leave town unexpectedly. The above is OK with me. As I understand it, we cannot remove fe-ops.info.frequency_max|min because it is part of the userspace API. I wasn't

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-08 Thread Manu Abraham
On 8/9/07, Michael Krufky [EMAIL PROTECTED] wrote: Manu Abraham wrote: On 8/9/07, Michael Krufky [EMAIL PROTECTED] wrote: I apologize for my delayed response -- I had to leave town unexpectedly. The above is OK with me. As I understand it, we cannot remove

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-07 Thread MikeW
Michael Krufky mkrufky at linuxtv.org writes: ...snip... That's fine with me... except I just don't see why we shouldn't just have the demod drivers that have the integrated tuning functionality just fill tuner_ops.info.frequency_max|min anyway. The point is, the structures will be present

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-07 Thread e9hack
Oliver Endriss schrieb: e9hack wrote: Currently, I'm missing something in the tuner modules (and I didn't ask for it). It isn't possible to wait for getting the pll lock. The tuning function of the TT-C2300 does wait. It isn't possible to switch the time constant of the loop filter after

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-07 Thread Oliver Endriss
Manu Abraham wrote: On 8/6/07, Michael Krufky [EMAIL PROTECTED] wrote: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be checking

[linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread e9hack
Hi, the min frequencies of the DVB-C frontends are wrong. In Europe, the center frequency of the lowest channel is 50.5MHz and not 51MHz. All known cards with the stv0297/tda0002x/ves1820 frontend are able to tune to this frequency. I've changed the range to the lowest channel - 1/2 bandwidth

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Michael Krufky
e9hack wrote: Hi, the min frequencies of the DVB-C frontends are wrong. In Europe, the center frequency of the lowest channel is 50.5MHz and not 51MHz. All known cards with the stv0297/tda0002x/ves1820 frontend are able to tune to this frequency. I've changed the range to the lowest

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread e9hack
Michael Krufky schrieb: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be checking fe-ops.tuner_ops.info.frequency_min|max , instead of

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Michael Krufky
e9hack wrote: Michael Krufky schrieb: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be checking fe-ops.tuner_ops.info.frequency_min|max , instead of

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Michael Krufky
Oliver Endriss wrote: Michael Krufky wrote: e9hack wrote: Hi, the min frequencies of the DVB-C frontends are wrong. In Europe, the center frequency of the lowest channel is 50.5MHz and not 51MHz. All known cards with the stv0297/tda0002x/ves1820 frontend are able to tune to

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Oliver Endriss
Michael Krufky wrote: Oliver Endriss wrote: Michael Krufky wrote: e9hack wrote: Hi, the min frequencies of the DVB-C frontends are wrong. In Europe, the center frequency of the lowest channel is 50.5MHz and not 51MHz. All known cards with the stv0297/tda0002x/ves1820

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Michael Krufky
Oliver Endriss wrote: Michael Krufky wrote: Oliver Endriss wrote: Michael Krufky wrote: e9hack wrote: Hi, the min frequencies of the DVB-C frontends are wrong. In Europe, the center frequency of the lowest channel is 50.5MHz and not 51MHz. All known

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Michael Krufky
Trent Piepho wrote: On Mon, 6 Aug 2007, e9hack wrote: Michael Krufky schrieb: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be checking

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Oliver Endriss
Michael Krufky wrote: Trent Piepho wrote: On Mon, 6 Aug 2007, e9hack wrote: Michael Krufky schrieb: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Michael Krufky
Oliver Endriss wrote: Michael Krufky wrote: Trent Piepho wrote: On Mon, 6 Aug 2007, e9hack wrote: Michael Krufky schrieb: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Oliver Endriss
Michael Krufky wrote: Oliver Endriss wrote: Michael Krufky wrote: Trent Piepho wrote: On Mon, 6 Aug 2007, e9hack wrote: Michael Krufky schrieb: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Manu Abraham
On 8/7/07, Oliver Endriss [EMAIL PROTECTED] wrote: I didn't see the ranges from the tuner, because the dvb-c drivers don't use the pll framework. They have very simple tuning functions only. We should use both values. One part may be more restrictive than the other one.

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Oliver Endriss
e9hack wrote: Currently, I'm missing something in the tuner modules (and I didn't ask for it). It isn't possible to wait for getting the pll lock. The tuning function of the TT-C2300 does wait. It isn't possible to switch the time constant of the loop filter after getting the lock.

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Manu Abraham
On 8/7/07, Trent Piepho [EMAIL PROTECTED] wrote: Most demodulators don't have frequency ranges. They just take whatever the tuner gives them at a fixed intermediate frequency. It's really the tuner that has the frequency range. Not true: look at the MB86A16. It is a DC (Direct Conversion)

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Manu Abraham
On 8/6/07, Michael Krufky [EMAIL PROTECTED] wrote: Now I'm beginning to have doubts about Oliver's original patch: dvb_frontend: Range check of frequency and symbol rate http://linuxtv.org/hg/v4l-dvb/rev/8186a34dd0a6 Should we be checking fe-ops.tuner_ops.info.frequency_min|max , instead of

Re: [linux-dvb] [PATCH] Fix the min/max frequencies of some DVB-C frontends

2007-08-06 Thread Trent Piepho
On Tue, 7 Aug 2007, Manu Abraham wrote: On 8/7/07, Trent Piepho [EMAIL PROTECTED] wrote: Most demodulators don't have frequency ranges. They just take whatever the tuner gives them at a fixed intermediate frequency. It's really the tuner that has the frequency range. Not true: look