[PATCH] sata_nv: fix ATAPI issues with memory over 4GB (v7)

2008-02-04 Thread Robert Hancock
. Reported to fix https://bugzilla.redhat.com/show_bug.cgi?id=351451 Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.24/drivers/ata/sata_nv.c 2008-01-24 16:58:37.0 -0600 +++ linux-2.6.24edit/drivers/ata/sata_nv.c 2008-01-29 18:39:37.0 -0600 @@ -247,6 +247,7

Re: PROBLEM: SATA hotplugging not working with nForce MCP61

2008-02-02 Thread Robert Hancock
Tejun Heo wrote: Tuomas Jormola wrote: 00:08.0 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) 00:08.1 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) That's MCP61 which is GENERIC variant in sata_nv which does not

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-31 Thread Robert Hancock
Alexander wrote: Hello! The problem described at https://bugzilla.redhat.com/show_bug.cgi?id=351451 and at http://ubuntuforums.org/showthread.php?t=655772 and supposedly fixed by the patch http://kerneltrap.org/mailarchive/linux-kernel/2007/11/25/445094 is still there. I have compiled

Re: DMA mapping on SCSI device?

2008-01-30 Thread Robert Hancock
Mark Lord wrote: Robert Hancock wrote: Luben Tuikov wrote: --- On Mon, 1/28/08, Robert Hancock [EMAIL PROTECTED] wrote: The trick is that if an ATAPI device is connected, we (as far as I'm aware) can't use ADMA mode, so we have to switch that port into legacy mode. Can you double check

[PATCH] sata_nv: fix for completion handling

2008-01-29 Thread Robert Hancock
with corresponding tag number completed execution. So i added the check notifier code. Sometimes i saw that the notifier reg set some bits , but the adma status set NV_ADMA_STAT_CMD_COMPLETE ,not NV_ADMA_STAT_DONE. So i added the NV_ADMA_STAT_CMD_COMPLETE check code. Signed-off-by: Robert Hancock

Re: DMA mapping on SCSI device?

2008-01-29 Thread Robert Hancock
Luben Tuikov wrote: --- On Mon, 1/28/08, Robert Hancock [EMAIL PROTECTED] wrote: The trick is that if an ATAPI device is connected, we (as far as I'm aware) can't use ADMA mode, so we have to switch that port into legacy mode. Can you double check this with the HW architect of the HW DMA

Re: [PATCH] sata_nv: fix for completion handling

2008-01-29 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: This patch is based on an original patch from Kuan Luo of NVIDIA, posted under subject fixed a bug of adma in rhel4u5 with HDS7250SASUN500G. His description follows. I've reworked it a bit to avoid some unnecessary repeated checks but it should

Re: Hot (un)plugging of a SATA drive with sata_nv (CK8S)?

2008-01-28 Thread Robert Hancock
(linux-ide cc'ed) Ignacy Gawedzki wrote: On Fri, Jan 25, 2008 at 09:03:02PM -0600, thus spake Robert Hancock: Ignacy Gawedzki wrote: Hi everyone, I'm having trouble to determine the cause of the following behavior. I'm not even sure that I'm supposed to hot plug and unplug a SATA drive from

Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-28 Thread Robert Hancock
Kuan Luo wrote: Robert worte. Kuan, does this patch (using the notifiers to see if the command is really done) still work if one port on the controller has ADMA disabled because it's in ATAPI mode? I seem to recall Allen Martin mentioning that notifiers wouldn't work in this case. I just

DMA mapping on SCSI device?

2008-01-28 Thread Robert Hancock
We've got a bit of a problem with the sata_nv driver that I'm trying to figure out a decent solution to (hence all the lists CCed). This is the situation: The nForce4 ADMA hardware has 2 modes: legacy mode, where it acts like a normal ATA controller with 32-bit DMA limits, and ADMA mode where

Re: sata_nv and 2.6.24 (was Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.)

2008-01-23 Thread Robert Hancock
Jeff Garzik wrote: Ping... sata_nv status is still a bit open for 2.6.24, and I would like to move us forward a bit. * Kuan's patch... it has been confirmed (and is needed), correct? can someone work up a good patch for 2.6.24? The only one I ever received was badly word-wrapped, and at

Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-23 Thread Robert Hancock
Kuan Luo wrote: First thank davide to help to send the attachment. Robert, The patch is to solve the error message ata1: CPB flags CMD err, flags=0x11 when testing HDS7250SASUN500G in rhel4u5. I tested this hd in 2.6.24-rc7 which needed to remove the mask in blacklist to run the ncq and the

Re: sata_nv and 2.6.24 (was Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.)

2008-01-23 Thread Robert Hancock
Jeff Garzik wrote: Robert Hancock wrote: Jeff Garzik wrote: Ping... sata_nv status is still a bit open for 2.6.24, and I would like to move us forward a bit. * Kuan's patch... it has been confirmed (and is needed), correct? can someone work up a good patch for 2.6.24? The only one I

Re: dvdrw-cdrom

2008-01-21 Thread Robert Hancock
Tejun Heo wrote: Jake wrote: http://marc.info/?l=linux-idem=120069298104580w=4 It has been 2 weeks here hunting for some solutions, can you recommend anything that I should try? Thank you. Can you please post full boot log from the working kernel broken kernel? It seems you were using

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-14 Thread Robert Hancock
James Bottomley wrote: On Sun, 2008-01-13 at 16:29 +, Alan Cox wrote: Yes, I concur for the short term. The other two possible courses of action either involve long discussions (the different device one) or you'll never quite be sure you got all the paths (the GFP_DMA32 one). At least with

Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-13 Thread Robert Hancock
Kuan Luo wrote: Robert hancock wrote: What problem does this resolve? I tested it against the cache flush/NCQ write switching problem we've been trying to solve, and it doesn't look like it fixes that one - if I apply this patch and then remove the udelay(20) in sata_nv.c that I added which

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
Alexander wrote: Robert Hancock wrote: There's this patch which was intended to fix it: http://lkml.org/lkml/2007/11/22/148 I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is normaly detected as: sr0: scsi3-mmc drive: 48x/48x writer dvd-ram cd/rw xa/form2 cdda tray But I

Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-11 Thread Robert Hancock
Kuan Luo wrote: hi robert, I have fixed a bug in rhel4u5 2.6.9-55 when running adma mode with HDS7250SASUN500G. Could you check this code and if no problem, then help me to submit to the newest kernel. It seems like a reasonable change - I'm sure you guys would know better

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-10 Thread Robert Hancock
it is limited to 32-bit DMA.. Could that be breaking or insufficient somehow? -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: disabling sata_nv ADMA for 2.6.24

2008-01-09 Thread Robert Hancock
Tejun Heo wrote: How about putting a bunch of printks inside the interrupt handler? That would tell us if it's even reaching the interrupt handler.. If you give me a patch, I'll apply it and cause lock up and report the result. Just shoot the patches my way. But maybe reproducing the lock up

Re: [PATCH] libata and starting/stopping ATAPI floppy devices

2008-01-09 Thread Robert Hancock
); -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: disabling sata_nv ADMA for 2.6.24

2008-01-08 Thread Robert Hancock
Tejun Heo wrote: Tejun Heo wrote: [ 34.466899] testing NMI watchdog ... 4WARNING: CPU#0: NMI appears to be stuck (0-0)! [ 34.555056] WARNING: CPU#1: NMI appears to be stuck (0-0)! Oops, missed that. I'll see whether there's IRQ storm going on. I made the nv irq handler to print message

Re: disabling sata_nv ADMA for 2.6.24

2008-01-08 Thread Robert Hancock
Tejun Heo wrote: Tejun Heo wrote: Robert Hancock wrote: Tejun Heo wrote: Tejun Heo wrote: [ 34.466899] testing NMI watchdog ... 4WARNING: CPU#0: NMI appears to be stuck (0-0)! [ 34.555056] WARNING: CPU#1: NMI appears to be stuck (0-0)! Oops, missed that. I'll see whether there's IRQ

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Robert Hancock
Mark Lord wrote: Tejun Heo wrote: Hello, guys. We still have three problems with ADMA. * hard lockup during resume * occasional hard lockup after hotplug or other erros (probably related to the above?) This has only been reported on one person's MSI board. Apparently another revision of

Re: sata_nv + ADMA + Samsung disk problem

2008-01-07 Thread Robert Hancock
Allen Martin wrote: Dunno about the NVidia version. Theirs works rather differently - the GO bit is there, but there's another append register which is used to tell the controller that a new tag has been added to the CPB list. The only thing we currently use the GO bit for is to switch

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Mark Lord wrote: Tejun Heo wrote: Hello, guys. We still have three problems with ADMA. * hard lockup during resume * occasional hard lockup after hotplug or other erros (probably related to the above?) This has only been reported on one person's MSI

Re: PROBLEM: I/O scheduler problem with an 8 SATA disks raid 5 under heavy load ?

2008-01-07 Thread Robert Hancock
seconds, so that means the drive failed to service those queued commands for that length of time. It may be that your drive has a poor NCQ implementation that can starve some of the pending commands for a long time under heavy load? -- Robert Hancock Saskatoon, SK, Canada To email, remove

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Robert Hancock
Tejun Heo wrote: Tejun Heo wrote: Robert Hancock wrote: This has only been reported on one person's MSI board. Apparently another revision of the same board is reported to work, and I can't duplicate the problem on my Asus board, so it could just be some hardware problem on that motherboard

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Robert Hancock
Tejun Heo wrote: Tejun Heo wrote: Robert Hancock wrote: Okay, just succeeded on the current #upstream-fixes, attaching the log. The machine is a brick after the crash. I assume the cable got reconnected at 325 seconds? It looks like that was during error handling for the previous unplug? I

Re: Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-06 Thread Robert Hancock
using the term 'hub' as a [sic] replacement for a 'switch'? I believe that they're essentially the same in that regard, though someone can correct me if I'm wrong.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http

Re: sata_nv + ADMA + Samsung disk problem

2008-01-03 Thread Robert Hancock
Benjamin Herrenschmidt wrote: Another thing about the PacDigi core: one has to be very careful to avoid sequential accesses to sequential PCI locations when programming the chip -- it cannot handle merged register writes. So for any group of sequentially laid out registers, the code has to

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-03 Thread Robert Hancock
Linda Walsh wrote: Robert Hancock wrote: Linda Walsh wrote: Alan Cox wrote: rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). Try disabling NCQ - see if you've got a drive with the 'NCQ = no readahead' flaw. http://linux-ata.org

Re: Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-03 Thread Robert Hancock
Linda Walsh wrote: I seem to remember reading about some problems with Promise SATA ACPI. Does this address that or is that a separate issue? (Am using no-acpi for now, but would like to try acpi again if it may be fixed (last time I tried it with this card, sdb went offline (once it

Re: sata_nv + ADMA + Samsung disk problem

2008-01-03 Thread Robert Hancock
Allen Martin wrote: Dunno about the NVidia version. Theirs works rather differently - the GO bit is there, but there's another append register which is used to tell the controller that a new tag has been added to the CPB list. The only thing we currently use the GO bit for is to switch

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-03 Thread Robert Hancock
Linda Walsh wrote: Robert Hancock wrote: Looks like the drive reports ERR/ABRT (command aborted), meaning it likely doesn't support those commands. --- Except the PATA version of the drive does (same capacity, other specs). Seagate would disable advanced features for SATA but leave

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Robert Hancock
less than 20 microseconds, or potentially longer) after the previous command's completion, the ADMA status changes from 0x500 (STOPPED and IDLE) to 0x400 (just IDLE) as it typically does, but then it sticks there, no interrupt is ever raised, and CPB response flags remain at 0. -- Robert

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-02 Thread Robert Hancock
. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Jeff Garzik wrote: Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only

Re: [PATCH] ide: delete filenames/versions from comments

2008-01-02 Thread Robert Hancock
for god knows how long, so clearly this version number is not useful.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: sata_nv + ADMA + Samsung disk problem

2008-01-02 Thread Robert Hancock
Mark Lord wrote: Robert Hancock wrote: .. From some of the traces I took previously (posted on LKML as sata_nv ADMA controller lockup investigation way back in Feb 07), what seems to occur is that when the second command is issued very rapidly (within less than 20 microseconds

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Tejun Heo wrote: [cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation failure on flush

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Robert Hancock wrote: Tejun Heo wrote: [cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Jeff Garzik wrote: Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few chips, it's not appearing in any new

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2007-12-31 Thread Robert Hancock
Linda Walsh wrote: Robert Hancock wrote: Have you tried using a different block size to see how that effects the results? There might be some funny interaction there. There is some interaction with the large block size (but only on the SATA disk). Counts were adjusted to keep

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-12-28 Thread Robert Hancock
Robert Hancock wrote: Jeff Garzik wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so

Re: HSM violation errors

2007-12-25 Thread Robert Hancock
was removed since it was broken, so this error shouldn't happen anymore. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: Strange ATA problems

2007-12-14 Thread Robert Hancock
to occur repeatedly, you don't have to worry about it. Yes, if it didn't recur, was likely just a transient glitch. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line

Re: ATA ACPI needs Mr interpreter, would you please shut up? flag

2007-12-13 Thread Robert Hancock
decided that one board always choked on an empty channel. Maybe it's not that and it's just another case of the same issue where our resetting default timing values on the controller before calling _GTM would choke the _GTM method? -- Robert Hancock Saskatoon, SK, Canada To email, remove

Re: Bug: get EXT3-fs error Allocating block in system zone

2007-12-10 Thread Robert Hancock
).. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: Iomega ZIP-100 drive unsupported with jmicron JMB361 chip?

2007-12-10 Thread Robert Hancock
that this drive still works with older kernels using drivers/ide, and that the hardware didn't break at some point, I assume? -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line

Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

2007-12-09 Thread Robert Hancock
are often too quick to blacklist hardware instead of looking into why it really is failing. ACPI is one of those areas where we often just need to figure out how to be bug-to-bug compatibile with what Windows is doing.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from

Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

2007-12-09 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: And you're quite right in your comment that we are often too quick to blacklist hardware instead of looking into why it really is failing. ACPI is one of those areas where we often just need to figure out how to be bug-to-bug compatibile with what Windows

Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

2007-12-08 Thread Robert Hancock
on the original Hitachi disk, but I've upgraded it to a newer Samsung). I'd say if the drive returns command aborted on one of these, we should just ignore that command and continue to the next one without trying to retry or disabling the ACPI support entirely. -- Robert Hancock Saskatoon, SK, Canada

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-12-08 Thread Robert Hancock
Jeff Garzik wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-12-04 Thread Robert Hancock
Jeff Garzik wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get

Re: Kernel 2.6.23.9 / P35 Chipset + WD 750GB Drives (reset port)

2007-12-04 Thread Robert Hancock
think there theory is that it's some other timing problem or some such, given the number of drives across all makers which are reported to do this. I believe Tejun is investigating? -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http

Re: Kernel 2.6.23.9 / P35 Chipset + WD 750GB Drives (reset port)

2007-12-01 Thread Robert Hancock
and thus be worthless in a raid5 configuration. Can anyone offer any insight here? Thank you, Justin. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe

Re: Possibly SATA related freeze killed networking and RAID

2007-11-29 Thread Robert Hancock
-triggered interrupt, an unhandled interrupt will keep interrupting forever since nobody knows how to clear it (until we decide to disable the IRQ entirely). -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com

[PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3)

2007-11-25 Thread Robert Hancock
attempt to try and issue NCQ commands with result taskfile requested, since the hardware doesn't allow this. Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.24-rc3-git1edit/drivers/ata/sata_nv.c.before2 2007-11-25 16:28:58.0 -0600 +++ linux-2.6.24-rc3-git1edit/drivers

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Robert Hancock
limit depending on the connected device, unless there is really a way to issue ATAPI commands with this EDMA interface, as the TODO list in sata_mv.c suggests may be possible.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-23 Thread Robert Hancock
Jeff Garzik wrote: Robert Hancock wrote: Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask unconditionally, but for non-ATA_PROT_DMA commands (which includes all ATAPI), it just falls back to ata_qc_issue_prot which issues via the legacy SFF interface and can only handle

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2)

2007-11-22 Thread Robert Hancock
Tejun Heo wrote: Hello, Robert. Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't

[PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

2007-11-22 Thread Robert Hancock
is needed for ATAPI devices). Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.24-rc3-git1edit/drivers/ata/sata_nv.c.before2 2007-11-22 19:42:28.0 -0600 +++ linux-2.6.24-rc3-git1edit/drivers/ata/sata_nv.c 2007-11-22 19:48:25.0 -0600 @@ -247,6 +247,7 @@ void

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2)

2007-11-21 Thread Robert Hancock
Vincent Fortier wrote: Le mardi 20 novembre 2007 à 18:56 -0600, Robert Hancock a écrit : This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer

[PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2)

2007-11-20 Thread Robert Hancock
is needed for ATAPI devices). Also, explicitly set a 32-bit DMA mask before allocating the legacy buffers since setting the DMA mask affects both ports and we need to ensure the second port's buffers are allocated properly (fixes a problem with the previous version of this patch). Signed-off-by: Robert

Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode

2007-11-20 Thread Robert Hancock
and the normal case with a RESULT_TF command where we do).. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get allocated

Re: stable basic 4-port SATA card

2007-11-14 Thread Robert Hancock
Tejun Heo wrote: Jeff Breidenbach wrote: I read with interest I. Straford's current trials and tribulations with the Promise SATA300 TX4. Do people have a favorite alternative to this card that plays well with Linux? I've read the chipset compatibility list, but am not sure how to boil that

Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB

2007-11-13 Thread Robert Hancock
Tejun Heo wrote: Could be done.. but, I don't want to constrain the ADMA APRD/CPB area in that way (there are some dual-socket Opteron boxes with this controller, forcing an allocation below 4GB for this could force a non-optimal node allocation I think..) To do this I'd have to raise the mask

[PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode

2007-11-13 Thread Robert Hancock
-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.24-rc1-git10/drivers/ata/sata_nv.c2007-11-01 20:01:32.0 -0600 +++ linux-2.6.24-rc1-git10edit/drivers/ata/sata_nv.c2007-11-13 19:01:09.0 -0600 @@ -791,11 +797,13 @@ static void nv_adma_tf_read(struct ata_port *ap

[PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-13 Thread Robert Hancock
is needed for ATAPI devices). Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.24-rc1-git10edit/drivers/ata/sata_nv.c.before 2007-11-13 19:04:18.0 -0600 +++ linux-2.6.24-rc1-git10edit/drivers/ata/sata_nv.c2007-11-13 19:02:34.0 -0600 @@ -247,6 +247,7 @@ void

Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-11-10 Thread Robert Hancock
to reinforce... sata_nv support and bug fixes are primarily done right now through the valiant efforts of Robert Hancock (with assists from Alan, Tejun, and others). Robert's job is difficult, because he has no hardware documentation[1], and NVIDIA does not seem to be helping out much with driver

Re: sata NCQ blacklist entry

2007-11-08 Thread Robert Hancock
driver is installed for the SATA controller in Windows, the chipset-manufacturer-provided AHCI driver or the default Microsoft driver? You'd need the AHCI driver installed for NCQ to be used. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http

Re: SATA eating my disk, port reset, destroying unrelated data

2007-11-07 Thread Robert Hancock
drives goes into hard reset failures), .config, lspci -v output. Are there any chances that using 2.6.23 will improve/fix this? Any other suggestions? I would consider it an hardware problem, but since it started at one big io thingy and is persistent since then I am a bit sceptic. -- Robert

Re: sata NCQ blacklist entry

2007-11-07 Thread Robert Hancock
. I'll keep your email in my todo list and add the drive to the blacklist once the problem is verified. I agree that something seems fishy with this. It seems unlikely that this many drives from multiple vendors would have the exact same, relatively obscure problem.. -- Robert Hancock

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Robert Hancock
, and the card indicates DMA support, which libata tries to use but which doesn't work. It looks like it never tried falling back to PIO after DMA failed. Seems like a deficiency in the speed-down logic? -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page

Re: sata_nv and dynamically changing DMA mask?

2007-10-30 Thread Robert Hancock
Alan Cox wrote: On Mon, 29 Oct 2007 22:17:40 -0600 Robert Hancock [EMAIL PROTECTED] wrote: In the sata_nv driver, when running in ADMA mode, we can do 64-bit DMA. However, when an ATAPI device like a DVD drive is connected, we can't use ADMA mode, and so we have to abide by the restrictions

sata_nv and dynamically changing DMA mask?

2007-10-29 Thread Robert Hancock
be switched out on the port, so the mask might need to be updated at runtime.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: Inquiry data and emulated SG devices

2007-10-17 Thread Robert Hancock
is differentiating IDE and read-good-old-SCSI devices and handles them sometimes in a different way, so this differenciation is really important for us. - How can I detect the real physical device type now? I don't have a great answer off the top of my head.. -- Robert Hancock Saskatoon, SK

Re: Invalid PnP ACPI reserved MMIO areas on Supermicro boards

2007-10-11 Thread Robert Hancock
Len Brown wrote: On Tuesday 09 October 2007 20:01, Robert Hancock wrote: Some people with certain Supermicro boards (at least the H8DCE, it seems) have reported that the sata_nv driver fails to attach to some of the controllers due to resource conflicts: https://bugzilla.redhat.com

Invalid PnP ACPI reserved MMIO areas on Supermicro boards

2007-10-09 Thread Robert Hancock
if they conflict with the ACPI resource reservations? I wonder how Windows deals with this, if it even does on these boards? -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line

libata-add-human-readable-error-value-decoding-v3.patch (was: -mm merge plans for 2.6.24)

2007-10-01 Thread Robert Hancock
Andrew Morton wrote: libata-add-human-readable-error-value-decoding-v3.patch I think I own this now. Will send to jgarzik then drop it if it doesn't stick. Another plug for this one, as the author. I really don't think one can object to it, and it definitely seems useful. -- Robert

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Robert Hancock
Management feature set. Whereas TEST UNIT READY is required for SCSI. It seems the SAT authors didn't consider this case. I assume we can tell from the identify data that the device doesn't support power management and just fake success for TEST UNIT READY in this case? -- Robert Hancock

Re: 2.6.22.5 SATA Failure

2007-08-25 Thread Robert Hancock
in your kernel configuration that result in drivers/ide trying to drive part or all of that controller, preventing libata from doing so. Likely the easiest thing to do is just set CONFIG_IDE=n entirely.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED

Re: regression problem with Maxtor disk

2007-08-15 Thread Robert Hancock
Lieven Marchand wrote: Tejun Heo [EMAIL PROTECTED] writes: It seems klogd clipped some messages. Can you please turn on printk timestamp, enlarge printk log buffersize and post the result of 'dmesg' after errors? [ 34.576963] ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) [

Re: regression problem with Maxtor disk

2007-08-14 Thread Robert Hancock
Tejun Heo wrote: [cc'ing Robert Hancock and quoting the whole message for him] Lieven Marchand wrote: Hi, the following drive Aug 12 12:26:15 black kernel: Vendor: ATA Model: Maxtor 7H500F0Rev: HA43 Aug 12 12:26:15 black kernel: Type: Direct-Access ANSI

Re: Disk spin down issue on shut down/suspend to disk

2007-08-10 Thread Robert Hancock
access the disk and in which parts/functions, pls. Again, it's not believed that this is being done via AML, but via a BIOS SMM trap on the ACPI sleep state hardware IO port. We have no real ability to find out what the BIOS is doing or prevent it in this case. -- Robert Hancock Saskatoon

Re: Disk spin down issue on shut down/suspend to disk

2007-08-07 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Tejun Heo wrote: Michael Sedkowski wrote: Hmmm... If the problem only shows up on nx6325, it might be that ACPI is pulling unnecessary stunt. Please apply the attached patch and report when the disk spins down and up. Disk spins down on Pre-shutdown

Re: Disk spin down issue on shut down/suspend to disk

2007-08-07 Thread Robert Hancock
the landing zone. I don't think arbitrary power-offs make too much difference on those drives. (However, these generally aren't rated to handle as many start/stop cycles, which is why laptop drives generally use load/unload instead.) -- Robert Hancock Saskatoon, SK, Canada To email, remove

Re: Disk spin down issue on shut down/suspend to disk

2007-08-07 Thread Robert Hancock
* a taskset to send to the driver, and we send that taskset ourselves in libata and libpata(?). -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: Disk spin down issue on shut down/suspend to disk

2007-08-07 Thread Robert Hancock
Henrique de Moraes Holschuh wrote: On Tue, 07 Aug 2007, Robert Hancock wrote: You *do* have to worry about it in any box you turn off daily. Desktop HDs will croak fast in that scenario, laptop HDs less so, but still too fast. A very good laptop HD can last about 20k emergency unloads

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Robert Hancock
, and the kernel does its own standby, this could cause an extra spinup/down.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

[PATCH -mm] libata: add human-readable error value decoding v3

2007-08-03 Thread Robert Hancock
looking at error reports. Some bits that drivers/ide decoded are not decoded here, since the bits are either command-dependent or obsolete, and properly parsing them would add too much complexity. Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- Rebased to apply to 2.6.23-rc1-mm2. --- linux

Re: Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)

2007-07-07 Thread Robert Hancock
Jeff Garzik wrote: Kuan Luo wrote: @@ -1714,3 +2761,6 @@ module_init(nv_init); module_exit(nv_exit); module_param_named(adma, adma_enabled, bool, 0444); MODULE_PARM_DESC(adma, Enable use of ADMA (Default: true)); +module_param_named(ncq, ncq_enabled, bool, 0444);

[PATCH -mm] sata_nv: allow changing queue depth

2007-06-28 Thread Robert Hancock
The sata_nv driver was missing the change_queue_depth hook in the SCSI host template which the other NCQ-capable libata drivers had. This made it impossible to change the queue depth by user request. Add this in. Signed-off-by: Robert Hancock [EMAIL PROTECTED] --- linux-2.6.22-rc6-mm1/drivers

Re: hsm violation

2007-06-24 Thread Robert Hancock
that aren't actually completed yet..) -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Frequent SATA resets with sata_nv (fwd)

2007-06-24 Thread Robert Hancock
expect.. Does this drive actually support NCQ? I can't tell from this part of the log. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 2.6.22-rc5] libata: add HTS541616J9SA00 to NCQ blacklist

2007-06-24 Thread Robert Hancock
that that one has Hitachi at the front and the others don't.. -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED

Re: [PATCH 2.6.22-rc5] libata: add HTS541616J9SA00 to NCQ blacklist

2007-06-24 Thread Robert Hancock
that) practice to have it there, but maybe they see the advantage of being able to figure out who made the drive now :-) -- Robert Hancock Saskatoon, SK, Canada To email, remove nospam from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line

  1   2   >