On Wednesday 24 August 2005 23:04, Borislav Petkov wrote:
Hi there,
Jeff asked for a volunteer a couple days ago on lkml to implement libata
debugging similar to the netdev debugging (see thread Another libata TODO
item) and I decided to give it a try. Here's a forward message I sent to him
HI Jeff,
another question:
unsigned int ata_dev_classify(struct ata_taskfile *tf)
in drivers/scsi/libata-core.c doesn't have access to an ata_port struct and it
thus cannot be converted to the new ata_msg_xxx usage. However, this function
has only two users which both have ata_port defined
libata new debugging macro definitions
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--- include/linux/libata.h.orig 2005-08-27 08:45:32.0 +0200
+++ include/linux/libata.h 2005-08-30 10:55:22.0 +0200
@@ -31,7 +31,8 @@
#include linux/workqueue.h
/*
- * compile-time
-
From: [EMAIL PROTECTED]
A very small size (object file 432 bytes smaller) and readability optimization
of ide.c
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
Index: 22-rc1/drivers/ide/ide.c
===
--- 22-rc1/drivers/ide
--- Alan Cox [EMAIL PROTECTED] schrieb:
On Thu, 17 May 2007 13:25:54 +0200
Borislav Petkov [EMAIL PROTECTED] wrote:
-
From: [EMAIL PROTECTED]
A very small size (object file 432 bytes smaller)
and readability optimization of ide.c
Signed-off-by: Borislav Petkov [EMAIL
On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
Hi all,
PS ide-cd Maintainer position is still open...
i'd like to take that position if nobody objects. I've done some work around the
kernel here and there and i think its time for me to get serious.
Thanks.
On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Thursday 20 December 2007, Borislav Petkov wrote:
On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
Hi all,
PS ide-cd Maintainer position is still open...
i'd like to take
On Tue, Dec 25, 2007 at 02:05:14PM -0800, Andrew Morton wrote:
On Thu, 20 Dec 2007 01:48:49 +0100 Bartlomiej Zolnierkiewicz [EMAIL
PROTECTED] wrote:
This patch series is a major rework of the ide-cd driver.
woo-hoo.
PS ide-cd Maintainer position is still open...
boo-hoo.
I wish
Hi Bart,
the following moves the remaining cdrom.c ioctl-related pieces to their proper
location. It applies on top of your 63 redux patches and shouldn't be changing
anything in the current functionality of the driver.
--
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional
On Wed, Dec 26, 2007 at 09:50:14PM +0100, Borislav Petkov wrote:
Actually you should drop the previous one for it wasn't incomplete. Here's,
hopefully, a better one :).
--
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes from this.
Signed-off-by: Borislav Petkov
Hi Bart,
here's the unfinished redux of ide-floppy which i'm sending now so that we could
sinchronize trees. There are some things left to be done which are not so
trivial and i'd like to give them a bit more thought :).
drivers/ide/ide-floppy.c | 1248
On Wed, Jan 02, 2008 at 10:25:05AM +0100, Borislav Petkov wrote:
by the way, i messed up the numbering of the patches: their correct count is not
12 but 10 so you shouldn't be missing any even if it seems so at a first glance.
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send
Hi Bart,
here's the unfinished redux of ide-floppy which i'm REsending now so that we
could
sinchronize trees. The original send got busted in vger's filters due to syntax
error in the Message-ID tag.
Documentation/ide/ChangeLog.ide-floppy.1996-2002 | 64 ++
drivers/ide/ide-floppy.c
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 90 +-
1 files changed, 57 insertions(+), 33 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers
Replace the ide-floppy packet commands opcode defines with the generic ones.
Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
last one can be found in the current version of INF-8090, p.905.
CC: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
Documentation/ide/ChangeLog.ide-floppy.1996-2002 | 64
drivers/ide/ide-floppy.c | 69 +-
2 files changed, 67 insertions(+), 66 deletions(-)
diff --git a/Documentation/ide
- do a white-space cleanup
- remove old crufty code untouched since at least 2005
- shorten lines longer than 80ish columns
- shorten some LAAARGE typenames.
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide
This BUG_ON is unneeded since the -handler != NULL check is performed in
ide_set_handler().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide
also, fix header comments and remove superfluous ones. There should be no
functionality change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 45 -
drivers/ide/ide-floppy.h | 127
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 58 +
drivers/ide/ide-floppy.h |3 +-
2 files changed, 29 insertions(+), 32 deletions(-)
diff --git
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 2c139e7..fd5fe7b 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide
while at it:
-cleanup small issues raised by scripts/checkpatch.pl
-remove redundant and shorten some comments
There should be no functionality change resulting from this patch
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 195
On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi,
Hi Bart,
Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for
moving code out of ide-floppy.c (and this patch series doesn't change that).
?, you mean this patch series _does_ change that,
On Sat, Jan 05, 2008 at 04:46:05PM +0100, Bartlomiej Zolnierkiewicz wrote:
Hmm, no. The driver is called ide-floppy (ide_floppy) and it is more
readable this way.
{
idefloppy_t *floppy = drive-driver_data;
struct gendisk *g = floppy-disk;
@@ -1479,7 +1450,7 @@ static
guys have in mind or is it missing the
point.
Thanks.
From 41c791f40e3fcf2287aa245f25796fa58bb17afc Mon Sep 17 00:00:00 2001
From: Borislav Petkov [EMAIL PROTECTED]
Date: Sun, 6 Jan 2008 10:37:47 +0100
Subject: [PATCH] ide-floppy: remove struct idefloppy_capabilities_page
This change is rather
-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 147 +++--
1 files changed, 75 insertions(+), 72 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 0729df5..3d9b1e5 100644
--- a/drivers/ide/ide
which releases that last
reference.
Rename ide_floppy_release() to idefloppy_cleanup_obj() in order to make its
purpose
more clear. There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1
medium type, this
comparison is now done by simply checking whether the medium has changed.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 89 -
1 files changed, 32 insertions(+), 57 deletions(-)
diff --git a/drivers/ide
Replace the ide-floppy packet commands opcode defines with the generic ones.
Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
last one can be found in the current version of INF-8090, p.905.
CC: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 89b26ea..0729df5 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
typedefs and teach
idefloppy_create_mode_sense_cmd() to work directly on u8 buffers.
Also, since idefloppy_get_capability_page() was used to read only the sfrp bit,
rename the latter so that the name reflects what it does.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 25 -
1 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 7d4ac0b..11c2c9b 100644
--- a/drivers/ide/ide-floppy.c
+++ b
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 41 -
1 files changed, 0 insertions(+), 41 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 5c85833..d98264e 100644
--- a/drivers/ide/ide
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index e4ebb21..e63758a 100644
--- a/drivers/ide/ide-floppy.c
* some debug_log() calls were not using ide-floppy: prefix
* a few used printk levels different than KERN_INFO (KERN_NOTICE
and KERN_ERR, which is the default one if no level is given)
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL
Hi Bart,
here's the second version of the ide-floppy refactoring trail. All the
patches are based on the version of your quilt tree from the 05.01. Also, you've
already applied patch 5 in this series but i'm submitting it still for the sake
of completeness.
drivers/ide/ide-cd.c |2
Also, move xfer_func_t typedef to the ide.h since it is used by two drivers
now (more coming).
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-cd.c |2 --
drivers/ide/ide-floppy.c | 37 ++---
include/linux/ide.h |3 +++
3
In addition to shortening the function name, move the printk-call into the
function thereby saving some code lines. Also, make the function out_of_line
since it is not on a performance critical path.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 37
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index c889c16..89b26ea 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide
This change is temporary and after unification of the IDE subsystem proper
bit setting and testing macros will be introduced.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 82 +-
1 files changed, 45 insertions(+), 37
While at it, collapse idefloppy_analyze_error() into
idefloppy_request_sense_callback() since the latter was its only user.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 82 +
1 files changed, 24 insertions(+), 58
variable instead.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 67 +++--
1 files changed, 17 insertions(+), 50 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 3d9b1e5..4106eb4 100644
[...]
This is not an equivalent transformation:
header-wp is 0 or 1
pc.buffer[3] 0x80 is 0 or 0x80
It seems to work fine for -wp (because it is needlessly defined as 'int')
but may seriously confuse set_disk_ro() and thus bdev_read_only() users.
Should be fixed to '(pc.buffer[3]
On Sat, Jan 12, 2008 at 09:14:39PM +0100, Bartlomiej Zolnierkiewicz wrote:
[...]
PS1 Please rebase the patches still needing polishing on top of updated
IDE quilt tree, recast them and respin the patch series (no need to post
already merged patches).
sure, will do.
PS2 what happend to fix
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 26 +++---
1 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 2b9885f..7648684 100644
--- a/drivers/ide/ide-floppy.c
+++ b
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 90 ++---
1 files changed, 36 insertions(+), 54 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 7648684..06d83cb 100644
--- a/drivers/ide
-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 176 --
1 files changed, 76 insertions(+), 100 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 06d83cb..caeffb7 100644
--- a/drivers/ide/ide-floppy.c
+++ b
() to idefloppy_format_unit().
Finally, rename the reworked functions to ide_floppy..().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 153 +++--
1 files changed, 78 insertions(+), 75 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 00ea8d6..5004773 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide
() to
ide_floppy_io_buffers().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 67 +
1 files changed, 20 insertions(+), 47 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index e7cc9dd..6c917fc 100644
This info is already available through ioctl() and /proc
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 63 +
1 files changed, 13 insertions(+), 50 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide
In addition to shortening the function name, move the printk-call into the
function thereby saving some code lines. Also, make the function out_of_line
since it is not on a performance critical path. Finally, rename the reworked
function to ide_floppy..().
Signed-off-by: Borislav Petkov [EMAIL
This flag is not being set anywhere in the driver so it can go.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 17 ++---
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index
Hi Bart,
here are the remaining patches which had issues to be worked out. I decided
to keep the Flexible Disk Page and Capacity Descriptor in
idefloppy_floppy_t for the sake of the two printk calls for which they are
used. Otherwise, we'll be changing long-known driver behavior and this won't
be
..and replace them with flag enums.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 132 +
1 files changed, 73 insertions(+), 59 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index
on.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 357 +-
1 files changed, 161 insertions(+), 196 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index f9faf26..9361dfd 100644
On Mon, Jan 14, 2008 at 10:50:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Sunday 13 January 2008, Borislav Petkov wrote:
..and replace them with flag enums.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 132
On Mon, Jan 14, 2008 at 11:32:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote:
On Sunday 13 January 2008, Borislav Petkov wrote:
..and replace them with flag enums.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
small update
On Mon, Jan 14, 2008 at 10:50:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Sunday 13 January 2008, Borislav Petkov wrote:
..and replace them with flag enums.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 132
... and finally the last one. Whew! I think we're done here for now. :)
--
From: Borislav Petkov [EMAIL PROTECTED]
Date: Tue, 15 Jan 2008 21:01:04 +0100
Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2
such as
ERROR: switch and case should be at the same indent
ERROR: need
driver version?
---
From 6f948b93839cdf397cb38ca75c3c6cc9a21e6070 Mon Sep 17 00:00:00 2001
From: Borislav Petkov [EMAIL PROTECTED]
Date: Sun, 20 Jan 2008 13:32:24 +0100
Subject: [PATCH] ide-floppy: bump driver version number
Acknowledge major ide-floppy code refactoring and cleanup by bumping
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 34 --
1 files changed, 0 insertions(+), 34 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 552cfed..3bedeb8 100644
--- a/drivers/ide/ide-tape.c
+++ b
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 40 +++-
1 files changed, 15 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 173ac0d..0542b07 100644
--- a/drivers/ide/ide-tape.c
Hi Bart,
after a lot of hammering ide-tape got pimped pretty considerably (ca. 600 lines
shorter and slicker :)). I'm sure there's more to be done like, e.g. replacing
the BKL in idetape_write_release() with finer-grained locking etc, probably also
some pipeline improvements, removal of OnStream
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 83 +++
1 files changed, 27 insertions(+), 56 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 3bedeb8..173ac0d 100644
--- a/drivers/ide/ide
The device capabilities are probed for during device initialization so this
info is available through proc/ioctl() und it is redundant here.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 74
1 files changed, 0
Also, cleanup whitespace and update comments.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++
drivers/ide/ide-tape.c | 414 +---
2 files changed, 409 insertions
From: Borislav Petkov [EMAIL PROTECTED]
This function was being used only at one place so fold it in there.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 36
1 files changed, 16 insertions(+), 20 deletions(-)
diff --git
From: Borislav Petkov [EMAIL PROTECTED]
Those are already in mtio.h.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 96 +++
1 files changed, 15 insertions(+), 81 deletions(-)
diff --git a/drivers/ide/ide-tape.c b
From: Borislav Petkov [EMAIL PROTECTED]
Also, remove those which weren't used.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 80 ++--
1 files changed, 30 insertions(+), 50 deletions(-)
diff --git a/drivers/ide/ide
From: Borislav Petkov [EMAIL PROTECTED]
Also, shorten function name idetape_get_blocksize_from_block_descriptor() and
move its definition up thereby getting rid of its forward declaration.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 68
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 19 ---
1 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 51 ---
1 files changed, 13 insertions(+), 38 deletions(-)
diff
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 49 +--
1 files changed, 18 insertions(+), 31 deletions(-)
diff
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 42 ++
1 files changed, 2 insertions(+), 40 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index dbececc
From: Borislav Petkov [EMAIL PROTECTED]
All those 2-byte values denoting the different capabilities are being written to
the local copy of the caps buffer without being converted to big endian for
simplicity of usage and shorter code later. Also, we add some comments stating
which are the fields
From: Borislav Petkov [EMAIL PROTECTED]
Teach the debug logging macro to differentiate different log levels based on the
type of debug level enabled specifically instead of a threshold-based one.
Thus, convert tape-debug_level to a bitmask that is written to over /proc.
Also,
- Cleanup
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 19 ---
1 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 02f5d5e..0708049 100644
From: Borislav Petkov [EMAIL PROTECTED]
They seem just to sit there completely unused.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 37 -
1 files changed, 0 insertions(+), 37 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
ide-tape has depended on EXPERIMENTAL for ages. Change that since the driver is
being only maintained now.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/Kconfig |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
From: Borislav Petkov [EMAIL PROTECTED]
This is not a network driver.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 1435f4e
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 60 ---
1 files changed, 31 insertions(+), 29 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c |9 +
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 5a18158..fd7eeea 100644
--- a/drivers/ide/ide
From: Borislav Petkov [EMAIL PROTECTED]
idetape_active_next_stage() was rather ambiguous wrt its purpose. Make that
more explicit and remove superfluous comment.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c |9 +++--
1 files changed, 3 insertions(+), 6
From: Borislav Petkov [EMAIL PROTECTED]
Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make
the struct function-local.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 23 +++
1 files changed, 11 insertions(+), 12
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 29 +++--
1 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index f8a4b27..d4c4255 100644
From: Borislav Petkov [EMAIL PROTECTED]
Bart,
this one is rather intrusive so please doublecheck it wrt to kzalloc/kfree
balancing on all the codepaths so that we don't leak memory all over the place.
I free all the alloc'd pc's and rq's in idetape_end_request() which is called
from the callback
From: Borislav Petkov [EMAIL PROTECTED]
Some member names are self-explanatory, so remove their respective
comments. Also, explain the exact purpose of struct members in comments
in the struct definition instead of using excessively long member names
thus replacing then with a shorter, more handy
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 88 ---
1 files changed, 45 insertions(+), 43 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index
From: Borislav Petkov [EMAIL PROTECTED]
tape-speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
value is tested for being 0, 1, or 2. Remove the if-branches where
tape-speed_ctl != 1 since they are never executed.
Also, rename calculate_speeds() by adding driver's prefix
From: Borislav Petkov [EMAIL PROTECTED]
Also remove flag IDETAPE_READ_ERROR since it is unused.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 222 +---
1 files changed, 117 insertions(+), 105 deletions(-)
diff --git
Hi Bart,
sorry for that thread split but i had to resend those remaining patches with
gmail because yahoo have a restriction on the number of mails one can send per
day :(
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message
Hi Bart,
[...]
the BKL in idetape_write_release() with finer-grained locking etc, probably
also
some pipeline improvements, removal of OnStream support, etc. but that'll
come
later.
On-Stream support has been long gone but it seems that deprecation
warning etc. managed to
On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote:
On Thu, Jan 31 2008, Nai Xia wrote:
My dmesg relevant info is quite similar:
[6.875041] Freeing unused kernel memory: 320k freed
[8.143120] ide-cd: rq still having bio: dev hdc: type=2, flags=114c8
[8.144439]
[
On Thu, Jan 31, 2008 at 05:35:56PM -0500, Kiyoshi Ueda wrote:
Hi Boris,
Thank you for the confirmation of original behavior.
On Thu, 31 Jan 2008 22:37:40 +0100, Borislav Petkov wrote:
On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote:
On Thu, Jan 31 2008, Nai Xia wrote:
My
On Wed, Jan 30, 2008 at 01:29:55AM +0100, Bartlomiej Zolnierkiewicz wrote:
On Monday 28 January 2008, Borislav Petkov wrote:
Hi Bart,
[...]
the BKL in idetape_write_release() with finer-grained locking etc,
probably also
some pipeline improvements, removal of OnStream
On Fri, Feb 01, 2008 at 12:39:27PM -0500, Kiyoshi Ueda wrote:
snip
end_that_request_last() is not called when __blk_end_reuqest()
returns 1. Then, the issuer isn't waken up.
So I think the BUG() or error messages should be there.
you mean, end_that_request_last() isn't called when
On Sun, Feb 03, 2008 at 12:43:22AM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi,
[...]
Even if this patch contains only trivial changes, the amount of them
and the fact that it intermixes different logical changes (shortening
names, dead code removal and comments beautification) makes it
On Sun, Feb 03, 2008 at 08:16:42PM +0300, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Index: b/drivers/ide/ide-tape.c
1 - 100 of 165 matches
Mail list logo
