Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

On Tue, Feb 26, 2008 at 06:32:41PM +1000, Brad Rosser wrote: Hi Brad, Hello Boris, Bart, On Tue, Feb 26, 2008 at 12:45 AM, Borislav Petkov [EMAIL PROTECTED] wrote: On Mon, Feb 25, 2008 at 03:57:06PM +1000, Brad Rosser wrote: ... it would suggest the option 'hda=noprobe' was entered

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

On Mon, Feb 25, 2008 at 03:57:06PM +1000, Brad Rosser wrote: Hi Boris, Well, this sounds strange. Are you sure you're entering the boot options correctly on the kernel command line? Which is your boot loader? I just booted my machine with 'hdc=noprobe' (hdc is my cdrom drive) and

ide-cd: trivial fixes

Hi Bart, here some trivial fixes that i wanted to get out the door. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ide-cd: put proc-related functions together under single ifdef

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 29 + 1 files changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 546f436..3600648 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide

[PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 634 + 1 files changed, 323 insertions(+), 311 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 3600648..3853eb5 100644 --- a/drivers/ide/ide

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

On Sun, Feb 24, 2008 at 03:38:34PM +1000, Brad Rosser wrote: [ Added Bart to CC: ] Hi Brad, Borislav Petkov wrote: Feb 14 00:18:18 kernel: hde: cdrom_pc_intr: The drive appears confused (ireason = 0x01). Trying to recover by ending request. Feb 14 00:27:27 kernel: hdc

[PATCH] ide-cd: remove the internal 64k buffer

Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 19 14:25:09 2008 +0100 ide-cd: remove the internal 64k buffer This removes the internal ide-cd buffer and falls back to read-ahead block layer capabilities. Thorough testing (cd burning, dvd read, raw read) gives

Re: Optiarc DVD RW AD-5200A audio playing

On Tue, Feb 19, 2008 at 12:18:48AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 18 February 2008, Stefan Bader wrote: Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote

Re: IDE cdrom problem

On Sun, Feb 17, 2008 at 03:16:42PM +0100, WaVeR wrote: Hi all, Le samedi 16 février 2008 à 21:23 +0100, Borislav Petkov a écrit : Do you want me to try the 2.6.25-rc2 ? and give my feedback Yes, please. Until now, there's no prob with the kernel 2.6.25-rc2. Cool, let me know

[PATCH] MAINTAINERS: update ide-cd maintainer's email address

commit c65b97fdbb9f3075a37f711aa6b388a48a27d3f4 Author: Borislav Petkov [EMAIL PROTECTED] Date: Sat Feb 16 09:10:46 2008 +0100 MAINTAINERS: update ide-cd maintainer's email address Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index

Re: Optiarc DVD RW AD-5200A audio playing

bits setting? commit 435f0f4496a1b32af2d542f43b2370a890fe2f83 Author: Borislav Petkov [EMAIL PROTECTED] Date: Sat Feb 16 09:56:36 2008 +0100 ide-cd: Enable audio play quirk for Optiarc DVD RW AD-5200A drive Reported-by: Stefan Bader [EMAIL PROTECTED] Signed-off-by: Borislav

Re: Optiarc DVD RW AD-5200A audio playing

On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav, I worked on a problem with an DVD driver (model=Optiarc DVD RW AD

Re: Optiarc DVD RW AD-5200A audio playing

On Sat, Feb 16, 2008 at 06:48:24PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15

Re: IDE cdrom problem

On Sat, Feb 16, 2008 at 06:40:08PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:46PM +0100, Bartlomiej Zolnierkiewicz wrote: [ added Borislav (ide-cd maintainer) to cc: ] Hi, Unless there are some

Re: Optiarc DVD RW AD-5200A audio playing

On Sat, Feb 16, 2008 at 07:23:58PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 06:48:24PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24

Re: IDE cdrom problem

On Sat, Feb 16, 2008 at 08:27:21PM +0100, WaVeR wrote: Hi, Le samedi 16 février 2008 à 19:09 +0100, Borislav Petkov a écrit : On Sat, Feb 16, 2008 at 06:40:08PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

On Thu, Feb 14, 2008 at 02:42:58PM +0100, Boris Petkov wrote: On 2/14/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Thursday 14 February 2008, Borislav Petkov wrote: On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote: [Added Bart to CC] Am Dienstag, 12

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, I think that this _really_ should be done _after_ unifying ATAPI handling [*]. Otherwise you will be making some of the same changes to the _three_ copies of (more or less) identical code and more importantly

[PATCH 2/2] ide-scsi: do non-atomic pc-flags testing

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c | 27 ++- 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c index d46c81c..93c3fc2 100644 --- a/drivers/scsi/ide-scsi.c +++ b

[PATCH 1/2] ide: use generic ATAPI packet command flags in ide-{floppy,tape,scsi}

This is done in one single patch in order not to cause git breakage. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 14 -- drivers/ide/ide-tape.c | 16 drivers/scsi/ide-scsi.c | 36

[PATCH 1/2] ide: use generic ATAPI packet command flags in ide-{floppy,tape}

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 14 -- drivers/ide/ide-tape.c | 16 include/linux/ide.h | 15 +++ 3 files changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/ide/ide-floppy.c b

[PATCH 2/2] ide-scsi: do non-atomic pc-flags testing

...also, convert ide-scsi to using the generic pc-flags defines. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c | 37 - 1 files changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide

[PATCH] ide-floppy: merge callbacks

commit d1f1f84f413ab00cb2fec48170d022fcd900e214 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed Feb 13 20:26:56 2008 +0100 ide-floppy: merge callbacks The appropriate functionality of the callback is established through querying the ATAPI packet command in pc-c[0

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote: [Added Bart to CC] Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov: On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote: Hi, I suffer from unreliable cdrom operations (failing DAE and burn

Re: [PATCH] ide-floppy: merge callbacks

On Wed, Feb 13, 2008 at 11:04:23PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Borislav Petkov wrote: commit d1f1f84f413ab00cb2fec48170d022fcd900e214 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed Feb 13 20:26:56 2008 +0100 ide-floppy: merge

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote: Hi, I suffer from unreliable cdrom operations (failing DAE and burn sessions) with the openSUSE 2.6.18.8-0.7-bigsmp kernel. Hi, can please you test this with a more recent kernel. Yours is

[PATCH] ide-scsi: do non-atomic pc-flags testing

commit 272976f0f5754707f9e41da315717a6eb8d9d536 Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 12 16:22:44 2008 +0100 ide-scsi: do non-atomic pc-flags testing Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c index

[RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

. This change is less intrusive but begs for a lot of simplification afterwards similar to ide-cd, which will probably get rid of all those create_.*_cmd() helpers. 6. Only compile-tested. Proper testing follows... -- commit 8359f6f7122e87c30467ff73895399b82610b835 Author: Borislav Petkov [EMAIL PROTECTED

[PATCH] ide-floppy: rename end_request handler properly

commit 48f9b88d491aa478ffcf21e2f523e3665db0770b Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 12 09:42:19 2008 +0100 ide-floppy: rename end_request handler properly mv idefloppy_do_end_request - idefloppy_end_request as is the case with ide-cd Signed-off

[PATCH 0/4] ide: generic packet command representation

Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach seemed the fastest versus unnecessary callback function

Re: [PATCH 0/4] ide: generic packet command representation

On Tue, Feb 12, 2008 at 01:09:24AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 11 February 2008, Borislav Petkov wrote: Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search replace line. Using driver-specific members

[PATCH 3/4] ide-tape: convert driver to using generic ide_atapi_pc

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 251 ++-- 1 files changed, 114 insertions(+), 137 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 09ff9b0..aefbb47 100644 --- a/drivers/ide

[PATCH 1/4] ide: add generic packet command representation ide_atapi_pc

, or removed completely. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- include/linux/ide.h | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/include/linux/ide.h b/include/linux/ide.h index e4eddd4..aae98d7 100644

[PATCH 2/4] ide-floppy: convert driver to using generic ide_atapi_pc

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 205 +- 1 files changed, 93 insertions(+), 112 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 4ce67bd..7e62dfc 100644 --- a/drivers

[PATCH 4/4] ide-scsi: convert driver to using generic ide_atapi_pc

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c | 133 ++- 1 files changed, 62 insertions(+), 71 deletions(-) diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c index 7fea769..5ec421c 100644 --- a/drivers/scsi

[PATCH] ide-floppy: remove struct idefloppy_id_gcw

commit a6aaf3dd3e88d1bd1e85fb4329042ecb9247e0eb Author: Borislav Petkov [EMAIL PROTECTED] Date: Fri Feb 8 18:21:47 2008 +0100 ide-floppy: remove struct idefloppy_id_gcw Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide

[PATCH 1/2] ide-tape: move all struct and other defs at the top

Hi Bart, thanks for the update earlier. I'll look into blk_{get,put}_request later and try it on idefloppy. In the meantime, here are the patches as requested: --- From 0d91862fc802d6f5aa79947b2685de6c209236f2 Mon Sep 17 00:00:00 2001 From: Borislav Petkov [EMAIL PROTECTED] Date: Sat, 9 Feb 2008

[PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands

From 92dd5c1cfb27c0945894a3a055098290047d1ff0 Mon Sep 17 00:00:00 2001 From: Borislav Petkov [EMAIL PROTECTED] Date: Sat, 9 Feb 2008 20:33:48 +0100 Subject: [PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands Removing the atomic tests for pc's is unobjectionable. Since

[PATCH] ide-cd: replace ntohs with generic byteorder macro be16_to_cpu

commit d41c6bc739e7ea7880f7f5983a9694f2e0214d92 Author: Borislav Petkov [EMAIL PROTECTED] Date: Fri Feb 8 07:25:44 2008 +0100 ide-cd: replace ntohs with generic byteorder macro be16_to_cpu Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff --git a/drivers/ide/ide-cd.c b/drivers

Re: ide-tape redux (was: Re:)

is being retried and we should leave only those atomic tests intact, imho, but i'm definitely gonna need a second opinion here. --- commit 1ed8ae92249d5dff7af4ee88710ea08ff3f3356f Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 5 08:05:35 2008 +0100 ide-tape: remove atomic test/set

Re: ide-tape redux (was: Re:)

... and while we're at it ... commit c824f79fe4040f7541d7e35c546bb57a22d2fe11 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed Feb 6 06:23:10 2008 +0100 ide-tape: move all struct and other defs to the top Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff --git a/drivers

Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()

On Sun, Feb 03, 2008 at 08:16:42PM +0300, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-tape.c

[PATCH 10/22] ide-tape: shorten some function names

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index ae2c76d..4fee160 100644 --- a/drivers/ide/ide-tape.c +++ b

[PATCH 14/22] ide-tape: cleanup and fix comments

Also, remove redundant ones and cleanup whitespace. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 725 +++ 1 files changed, 293 insertions(+), 432 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide

[PATCH 16/22] ide-tape: include proper headers

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 342ec50..24f048f 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c

[PATCH 15/22] ide-tape: remove unused length arg from idetape_create_read_buffer_cmd()

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index a80f8d9..342ec50 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c

[PATCH 17/22] ide-tape: collect module-related macro calls at the end

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 24f048f..cfcf5b0 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c

[PATCH 09/22] ide-tape: remove idetape_increase_max_pipeline_stages()

This function was being used only at one place so fold it in there. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 36 1 files changed, 16 insertions(+), 20 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide

[PATCH 12/22] ide-tape: dump gcw fields on error in idetape_identify_device()

goes before ide-tape: remove IDETAPE_DEBUG_INFO patch in IDE quilt tree Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/ide/ide

[PATCH 04/22] ide-tape: simplify code branching in the interrupt handler

... by adding a new typedef function pointer idetape_io_buf in order to call the proper buffer i/o handler depending on the data direction. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 55 +-- 1 files changed, 29

[PATCH 06/22] ide-tape: struct idetape_tape_t: remove unused members

to; remove corresponding code chunk - uncontrolled_last_pipeline_head: only once written to - blocks_in_buffer: only written to Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 45 +++-- 1 files changed, 11 insertions(+), 34 deletions

[PATCH 01/22] ide-tape: refactor the debug logging facility

-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 344 +--- 1 files changed, 122 insertions(+), 222 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 4168a06..442d71c 100644 --- a/drivers/ide/ide-tape.c +++ b

[PATCH 07/22] ide-tape: struct idetape_tape_t: shorten member names v2

Shorten some member names not too aggressively since this driver might be gone anyway soon. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 210 ++-- 1 files changed, 113 insertions(+), 97 deletions(-) diff --git

[PATCH 11/22] ide-tape: remove atomic test/set macros

Also remove flag IDETAPE_READ_ERROR since it is unused. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 226 +-- 1 files changed, 120 insertions(+), 106 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide

[PATCH 03/22] ide-tape: remove unreachable code chunk

. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index c8c57ab..b15dd17 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide

[PATCH 02/22] ide-tape: remove struct idetape_read_position_result_t

There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 49 +-- 1 files changed, 18 insertions(+), 31 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers

[PATCH 13/22] ide-tape: remove struct idetape_id_gcw

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 58 --- 1 files changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 712c5df..175d507 100644 --- a/drivers/ide/ide

[no subject]

Hi Bart, here are the pending ide-tape patches reworked which incorporate all review points raised so far. Several new patches are appended to the original series which i thought would be reasonable to sumbit along with the others. Also, i've applied ide-tape: dump gcw fields on error in

[PATCH 08/22] ide-tape: remove packet command and struct request memory buffers

. Packet command and request memory is freed in idetape_end_request() which is at the end of the request path entered from all callbacks. While at it, integrate comments above member definitions in ide_tape_obj. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 146

[PATCH 21/22] ide-tape: bump minor driver version

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 5c5..2e6198f 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -15,7

[PATCH 22/22] ide-tape: schedule driver for removal after 6 months in case it turns out

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- Documentation/feature-removal-schedule.txt | 14 -- drivers/ide/ide-tape.c |5 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/Documentation/feature-removal-schedule.txt b

[PATCH 19/22] ide-tape: fix syntax error in idetape_identify_device()

Spotted by Sergei Shtylyov. CC: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 4a12c0b..7e998c4 100644

[PATCH 05/22] ide-tape: remove typedef idetape_chrdev_direction_t

.. and replace it with plain enums. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 62 --- 1 files changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 2857965

Re: (fwd) Bug#11922: I/O error on blank tapes

On Mon, Feb 04, 2008 at 03:22:06PM +0100, maximilian attems wrote: (Added Bart to CC) hello borislav, may i forward you that *old* Debian kernel bug, have seen you working on ide-tape: http://bugs.debian.org/11922 no we don't carry any ide patches anymore. maybe you've already fixed it

Re: [PATCH 07/22] ide-tape: struct idetape_tape_t: shorten member names v2

On Tue, Feb 05, 2008 at 02:23:21AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 04 February 2008, Borislav Petkov wrote: Shorten some member names not too aggressively since this driver might be gone anyway soon. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers

Re: [PATCH] ide: another possible ide panic fix for blk-end-request

of Linus' git. Please review and apply. Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/ide/ide-io.c |3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH 23/32] ide-tape: struct idetape_tape_t: shorten member names

On Sun, Feb 03, 2008 at 12:43:22AM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, [...] Even if this patch contains only trivial changes, the amount of them and the fact that it intermixes different logical changes (shortening names, dead code removal and comments beautification) makes it

Re: [PATCH 0/32] ide-tape redux v1

On Wed, Jan 30, 2008 at 01:29:55AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 28 January 2008, Borislav Petkov wrote: Hi Bart, [...] the BKL in idetape_write_release() with finer-grained locking etc, probably also some pipeline improvements, removal of OnStream

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

On Fri, Feb 01, 2008 at 12:39:27PM -0500, Kiyoshi Ueda wrote: snip end_that_request_last() is not called when __blk_end_reuqest() returns 1. Then, the issuer isn't waken up. So I think the BUG() or error messages should be there. you mean, end_that_request_last() isn't called when

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote: On Thu, Jan 31 2008, Nai Xia wrote: My dmesg relevant info is quite similar: [6.875041] Freeing unused kernel memory: 320k freed [8.143120] ide-cd: rq still having bio: dev hdc: type=2, flags=114c8 [8.144439] [

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

On Thu, Jan 31, 2008 at 05:35:56PM -0500, Kiyoshi Ueda wrote: Hi Boris, Thank you for the confirmation of original behavior. On Thu, 31 Jan 2008 22:37:40 +0100, Borislav Petkov wrote: On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote: On Thu, Jan 31 2008, Nai Xia wrote: My

Re: [PATCH 0/32] ide-tape redux v1

Hi Bart, [...] the BKL in idetape_write_release() with finer-grained locking etc, probably also some pipeline improvements, removal of OnStream support, etc. but that'll come later. On-Stream support has been long gone but it seems that deprecation warning etc. managed to

[PATCH 2/32] ide-tape: remove dead code

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 552cfed..3bedeb8 100644 --- a/drivers/ide/ide-tape.c +++ b

[PATCH 4/32] ide-tape: remove struct idetape_mode_parameter_header_t

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 40 +++- 1 files changed, 15 insertions(+), 25 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 173ac0d..0542b07 100644 --- a/drivers/ide/ide-tape.c

[PATCH 0/32] ide-tape redux v1

Hi Bart, after a lot of hammering ide-tape got pimped pretty considerably (ca. 600 lines shorter and slicker :)). I'm sure there's more to be done like, e.g. replacing the BKL in idetape_write_release() with finer-grained locking etc, probably also some pipeline improvements, removal of OnStream

[PATCH 3/32] ide-tape: remove struct idetape_request_sense_result_t

Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 83 +++ 1 files changed, 27 insertions(+), 56 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 3bedeb8..173ac0d 100644 --- a/drivers/ide/ide

[PATCH 5/32] ide-tape: remove IDETAPE_DEBUG_INFO

The device capabilities are probed for during device initialization so this info is available through proc/ioctl() und it is redundant here. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 74 1 files changed, 0

[PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002

Also, cleanup whitespace and update comments. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++ drivers/ide/ide-tape.c | 414 +--- 2 files changed, 409 insertions

[PATCH 27/32] ide-tape: remove idetape_increase_max_pipeline_stages()

From: Borislav Petkov [EMAIL PROTECTED] This function was being used only at one place so fold it in there. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 36 1 files changed, 16 insertions(+), 20 deletions(-) diff --git

[PATCH 29/32] ide-tape: remove mtio.h related comments

From: Borislav Petkov [EMAIL PROTECTED] Those are already in mtio.h. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 96 +++ 1 files changed, 15 insertions(+), 81 deletions(-) diff --git a/drivers/ide/ide-tape.c b

[PATCH 16/32] ide-tape: use generic scsi commands

From: Borislav Petkov [EMAIL PROTECTED] Also, remove those which weren't used. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 80 ++-- 1 files changed, 30 insertions(+), 50 deletions(-) diff --git a/drivers/ide/ide

[PATCH 13/32] ide-tape: remove struct idetape_parameter_block_descriptor_t

From: Borislav Petkov [EMAIL PROTECTED] Also, shorten function name idetape_get_blocksize_from_block_descriptor() and move its definition up thereby getting rid of its forward declaration. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 68

[PATCH 12/32] ide-tape: remove struct idetape_medium_partition_page_t

From: Borislav Petkov [EMAIL PROTECTED] There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 19 --- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/drivers/ide/ide-tape.c

[PATCH 09/32] ide-tape: remove struct idetape_inquiry_result_t

From: Borislav Petkov [EMAIL PROTECTED] There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 51 --- 1 files changed, 13 insertions(+), 38 deletions(-) diff

[PATCH 10/32] ide-tape: remove struct idetape_read_position_result_t

From: Borislav Petkov [EMAIL PROTECTED] There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 49 +-- 1 files changed, 18 insertions(+), 31 deletions(-) diff

[PATCH 06/32] ide-tape: remove IDETAPE_DEBUG_BUGS

From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 42 ++ 1 files changed, 2 insertions(+), 40 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index dbececc

[PATCH 08/32] ide-tape: remove struct idetape_capabilities_page_t

From: Borislav Petkov [EMAIL PROTECTED] All those 2-byte values denoting the different capabilities are being written to the local copy of the caps buffer without being converted to big endian for simplicity of usage and shorter code later. Also, we add some comments stating which are the fields

[PATCH 07/32] ide-tape: refactor the debug logging facility

From: Borislav Petkov [EMAIL PROTECTED] Teach the debug logging macro to differentiate different log levels based on the type of debug level enabled specifically instead of a threshold-based one. Thus, convert tape-debug_level to a bitmask that is written to over /proc. Also, - Cleanup

[PATCH 11/32] ide-tape: remove struct idetape_data_compression_page_t

From: Borislav Petkov [EMAIL PROTECTED] There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 19 --- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/drivers/ide/ide-tape.c

[PATCH 15/32] ide-tape: remove struct idetape_block_size_page_t

From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 02f5d5e..0708049 100644

[PATCH 14/32] ide-tape: remove structs os_partition_t, os_dat_entry_t, os_dat_t

From: Borislav Petkov [EMAIL PROTECTED] They seem just to sit there completely unused. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 37 - 1 files changed, 0 insertions(+), 37 deletions(-) diff --git a/drivers/ide/ide-tape.c

[PATCH 17/32] ide-tape: remove EXPERIMENTAL driver status

From: Borislav Petkov [EMAIL PROTECTED] ide-tape has depended on EXPERIMENTAL for ages. Change that since the driver is being only maintained now. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/Kconfig |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[PATCH 18/32] ide-tape: use generic byteorder macros

From: Borislav Petkov [EMAIL PROTECTED] This is not a network driver. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 1435f4e

[PATCH 21/32] ide-tape: idetape_chrdev_direction_t:shorten enum names

From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 60 --- 1 files changed, 31 insertions(+), 29 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index

[PATCH 19/32] ide-tape: remove unused sense packet commands.

From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 5a18158..fd7eeea 100644 --- a/drivers/ide/ide

[PATCH 20/32] ide-tape: make function name more accurate

From: Borislav Petkov [EMAIL PROTECTED] idetape_active_next_stage() was rather ambiguous wrt its purpose. Make that more explicit and remove superfluous comment. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |9 +++-- 1 files changed, 3 insertions(+), 6

[PATCH 31/32] ide-tape: remove idetape_config_t typedef

From: Borislav Petkov [EMAIL PROTECTED] Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make the struct function-local. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 23 +++ 1 files changed, 11 insertions(+), 12

[PATCH 28/32] ide-tape: shorten some function names

From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index f8a4b27..d4c4255 100644

[RFC PATCH 26/32] ide-tape: remove packet command and struct request memory buffers

From: Borislav Petkov [EMAIL PROTECTED] Bart, this one is rather intrusive so please doublecheck it wrt to kzalloc/kfree balancing on all the codepaths so that we don't leak memory all over the place. I free all the alloc'd pc's and rq's in idetape_end_request() which is called from the callback

[PATCH 23/32] ide-tape: struct idetape_tape_t: shorten member names

From: Borislav Petkov [EMAIL PROTECTED] Some member names are self-explanatory, so remove their respective comments. Also, explain the exact purpose of struct members in comments in the struct definition instead of using excessively long member names thus replacing then with a shorter, more handy

  1   2   >