[PATCH CPA] [5/28] Add pte_pgprot on i386

2008-01-03 Thread Andi Kleen
64bit already had it. Needed for later patches. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86/pgtable-2level.h |2 ++ include/asm-x86/pgtable-3level.h |2 ++ 2 files changed, 4 insertions(+) Index: linux/include/asm-x86/pgtable-2level.h

[PATCH CPA] [4/28] Add pte_clrhuge on i386

2008-01-03 Thread Andi Kleen
64bit had it already Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86/pgtable_32.h |1 + 1 file changed, 1 insertion(+) Index: linux/include/asm-x86/pgtable_32.h === ---

[PATCH CPA] [3/28] Add pte accessors for the global bit

2008-01-03 Thread Andi Kleen
Needed for some test code. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86/pgtable_32.h |3 +++ include/asm-x86/pgtable_64.h |3 +++ 2 files changed, 6 insertions(+) Index: linux/include/asm-x86/pgtable_64.h

[PATCH CPA] [1/28] Shrink __PAGE_KERNEL/__PAGE_KERNEL_EXEC on non PAE kernels

2008-01-03 Thread Andi Kleen
No need to make it 64bit there. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/mm/init_32.c|4 ++-- include/asm-x86/pgtable_32.h |3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) Index: linux/arch/x86/mm/init_32.c

Re: [PATCH 2/2] Kprobes: Move kprobes examples to samples/

2008-01-03 Thread Mathieu Desnoyers
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > > * Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> wrote: > > > > feature request: please make this work in the !modular case as well > > > - if built-in then it should just run sometime during bootup and run > > > the tests and report

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Benny Halevy
On Jan. 03, 2008, 14:30 +0200, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > Em Thu, Jan 03, 2008 at 12:26:10PM +, Christoph Hellwig escreveu: >> On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: >>> We have had some stabs at changing this, but no consensus was reached

Re: [RFC] sample kset/ktype/kobject implementation code

2008-01-03 Thread Cornelia Huck
On Wed, 19 Dec 2007 16:31:35 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > /* >* Initialize and add the kobject to the kernel. All the default files >* will be created here. As we have already specified a kset for this >* kobject, we don't have to set a parent for

regression w.r.t. problems #lilo when an usb-key is present: problem no longer

2008-01-03 Thread werner
I reported a regression, that when a usb-key is connected, #lilo produces a bootloader which don't work, on 2.6.24-rc6-git2, diferently to kernels before. Yesterday I compiled 2.6.24-rc6-git8 with exactly the same kernel parameters, with this, the problem didnt occure again, on the same 2

Re: serial console _after_ boot ? - was: Redirect kernel console

2008-01-03 Thread Jan Engelhardt
On Jan 3 2008 15:39, [EMAIL PROTECTED] wrote: >fantastic, thanks! > >unfortunately.. > >opensuse103:/home/roland/serialcons # ./mytioccons >ioctl: Device or resource busy > >but i`m not deep enough into programming to understand this. > >int main(void) >{ >int fd = open("/dev/ttyS0",

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 17:50 +0300, Cyrill Gorcunov wrote: > > > so what i would do now? i could post updated patch *without* that > splitted line, should I? And with the if (rc == 0) thing fixed too. Yes please. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[David Woodhouse - Thu, Jan 03, 2008 at 02:37:24PM +] | | On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote: | > * David Woodhouse <[EMAIL PROTECTED]> wrote: | > | > > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: | > > > not to make a big issue out of this, but when was the last

Re: [GIT] More NFS client fixes for 2.6.24-rc6

2008-01-03 Thread Trond Myklebust
On Thu, 2008-01-03 at 10:30 +0100, Ingo Molnar wrote: > * Trond Myklebust <[EMAIL PROTECTED]> wrote: > > > commit 53478daff2c8b494d2af1ede6611f166f81bc393 > > Author: Trond Myklebust <[EMAIL PROTECTED]> > > Date: Wed Jan 2 13:28:57 2008 -0500 > > > > NFS: Fix a possible Oops in

Re: serial console _after_ boot ? - was: Redirect kernel console

2008-01-03 Thread devzero
fantastic, thanks! unfortunately.. opensuse103:/home/roland/serialcons # ./mytioccons ioctl: Device or resource busy but, it`s not userspace: opensuse103:/home/roland # lsof |egrep "console|ttyS0" opensuse103:/home/roland # in tty_io.c -> ticoccons() there is if (redirect) {

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote: > * David Woodhouse <[EMAIL PROTECTED]> wrote: > > > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: > > > not to make a big issue out of this, but when was the last time you > > > tried to grep this way: > > > > > > grep -E

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Ingo Molnar
* David Woodhouse <[EMAIL PROTECTED]> wrote: > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: > > not to make a big issue out of this, but when was the last time you > > tried to grep this way: > > > > grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c > > Not precisely that, but

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread David Woodhouse
On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote: > not to make a big issue out of this, but when was the last time you > tried to grep this way: > > grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c Not precisely that, but I've certainly had greps fail because people have split up

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Jiri Slaby
On 01/03/2008 02:51 PM, Pekka J Enberg wrote: > Hi Jiri, > > On Thu, 3 Jan 2008, Jiri Slaby wrote: >> this happened, while playing with broken dvd. > > [snip] > >> Buffer I/O error on device sr0, logical block 5441 >> end_request: I/O error, dev sr0, sector 136 >> ISOFS: unable to read i-node

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Al Viro
On Thu, Jan 03, 2008 at 03:11:20PM +0100, Ingo Molnar wrote: > and there are about 5 other callsites as well that only check for a NULL > return. ... except that this is *not* getting NULL or make_bad_inode(); that's getting ERR_PTR(), which can't happen in mainline. So that looks like an -mm

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Ingo Molnar
* Pekka J Enberg <[EMAIL PROTECTED]> wrote: > return ERR_PTR(-EACCES); > } > + if (is_bad_inode(inode)) { > + unlock_kernel(); > + iput(inode); > + return ERR_PTR(-ENOENT); > +

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Al Viro
On Thu, Jan 03, 2008 at 03:51:28PM +0200, Pekka J Enberg wrote: > Does the following patch fix it? Highly doubtful, and doesn't deal with the real problem, AFAICS... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Al Viro
On Thu, Jan 03, 2008 at 02:23:44PM +0100, Jiri Slaby wrote: > ISOFS: unable to read i-node block isofs_read_inode() failing, about to do make_bad_inode() > Unable to handle kernel NULL pointer dereference at 00ad RIP: > [] d_splice_alias+0x1f/0x100 struct dentry

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
Hi Sam! On Thu, 3 Jan 2008, Sam Ravnborg wrote: > > --- > > > > Index: linux-compile.git/Documentation/stable_api_nonsense.txt > > === > > --- linux-compile.git.orig/Documentation/stable_api_nonsense.txt > > 2008-01-03

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Ingo Molnar
* Jörn Engel <[EMAIL PROTECTED]> wrote: > > - "audit: audit_lost=%d audit_rate_limit=%d > > audit_backlog_limit=%d\n", > > + "audit: audit_lost=%d audit_rate_limit=%d " > > + "audit_backlog_limit=%d\n", > >

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-01-03 Thread Boaz Harrosh
On Thu, Jan 03 2008 at 15:12 +0200, Andi Kleen <[EMAIL PROTECTED]> wrote: >> Can we please just nuke CONFIG_HIGHPTE? There's only been a small >> amount of 32bit machines > > It's unfortunately a larger amount :/ And for unknown reasons a lot of > people still install 32bit kernels on new

Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

2008-01-03 Thread Haavard Skinnemoen
On Thu, 3 Jan 2008 15:48:35 +0200 Ville Syrjälä <[EMAIL PROTECTED]> wrote: > On Wed, Dec 26, 2007 at 11:24:54PM +0100, Haavard Skinnemoen wrote: > > On Fri, 21 Dec 2007 09:34:01 +0200 > > Ville Syrjala <[EMAIL PROTECTED]> wrote: > > > > > +static struct platform_device foo_w1_device = { > > > +

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Steven Rostedt
[Added Chris Wright, Rusty and Virt list because they were involved with this issue before] On Thu, 3 Jan 2008, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > +# function tracing might turn this off: > > +config REGPARM > > + bool > > + depends on !MCOUNT > > +

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Pekka J Enberg
Hi Jiri, On Thu, 3 Jan 2008, Jiri Slaby wrote: > this happened, while playing with broken dvd. [snip] > Buffer I/O error on device sr0, logical block 5441 > end_request: I/O error, dev sr0, sector 136 > ISOFS: unable to read i-node block > Unable to handle kernel NULL pointer dereference at

Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

2008-01-03 Thread Ville Syrjälä
On Wed, Dec 26, 2007 at 11:24:54PM +0100, Haavard Skinnemoen wrote: > On Fri, 21 Dec 2007 09:34:01 +0200 > Ville Syrjala <[EMAIL PROTECTED]> wrote: > > > +static struct platform_device foo_w1_device = { > > + .name = "w1-gpio", > > + .id = -1, > >

Ban can ho cao cap V-Star (Korea) Quan 7, TP.HCM Gia Dac Biet Dau nam 2008

2008-01-03 Thread NHA DAT SAI GON
Chao cac ban, Ban nhan duoc email nay la do ban hoac mot ai do da dang ky dia chi email cua ban tai trang web: www.nhaban.net.tf, www.nhaban.vnn.bz, www.nhadep.us de nhan cac thong tin nha dat moi nhat cua chung toi. Nay chung toi han hanh thong bao voi cac ban cac can ho cao cap chung toi dang

isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-03 Thread Jiri Slaby
Hi, this happened, while playing with broken dvd. ISO 9660 Extensions: Microsoft Joliet Level 3 ISO 9660 Extensions: RRIP_1991A end_request: I/O error, dev sr0, sector 21760 Buffer I/O error on device sr0, logical block 5440 Buffer I/O error on device sr0, logical block 5441 Buffer I/O error on

Re: serial console _after_ boot ? - was: Redirect kernel console

2008-01-03 Thread Jan Engelhardt
On Jan 3 2008 13:43, [EMAIL PROTECTED] wrote: > >hi ! > >i was wondering how to make kernel messages appear on /dev/ttyS0 without a >reboot, i.e. kernelparam "console=ttyS0" The solution is simple... the following piece of code is inside

[RESEND PATCH 10/10] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder macros

2008-01-03 Thread Borislav Petkov
Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 6c29b5f..ddab66c 100644 --- a/drivers/ide/ide-floppy.c

[RESEND PATCH 06/10] ide-floppy: report DMA handling in idefloppy_pc_intr() properly

2008-01-03 Thread Borislav Petkov
while at it: -cleanup small issues raised by scripts/checkpatch.pl -remove redundant and shorten some comments There should be no functionality change resulting from this patch Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c | 195

[RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags

2008-01-03 Thread Borislav Petkov
also, fix header comments and remove superfluous ones. There should be no functionality change resulting from this patch. Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c | 45 - drivers/ide/ide-floppy.h | 127

[RESEND PATCH 04/10] ide-floppy: cleanup debugging macros

2008-01-03 Thread Borislav Petkov
There should be no functional change resulting from this patch. Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c | 58 + drivers/ide/ide-floppy.h |3 +- 2 files changed, 29 insertions(+), 32 deletions(-) diff --git

[RESEND PATCH 07/10] ide-floppy: remove unnecessary ->handler != NULL check

2008-01-03 Thread Borislav Petkov
This BUG_ON is unneeded since the ->handler != NULL check is performed in ide_set_handler(). Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/ide/ide-floppy.c

[RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

2008-01-03 Thread Borislav Petkov
- do a white-space cleanup - remove old crufty code untouched since at least 2005 - shorten lines longer than 80ish columns - shorten some LAAARGE typenames. There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> ---

[RESEND PATCH 08/10] ide-floppy: mv idefloppy_{should_,}report_error

2008-01-03 Thread Borislav Petkov
Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 2c139e7..fd5fe7b 100644 --- a/drivers/ide/ide-floppy.c +++

[RESEND PATCH 01/10] move ide-floppy historical changelog to Documentation/ide/ChangeLog.ide-floppy.1996-2002;

2008-01-03 Thread Borislav Petkov
Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- Documentation/ide/ChangeLog.ide-floppy.1996-2002 | 64 drivers/ide/ide-floppy.c | 69 +- 2 files changed, 67 insertions(+), 66 deletions(-) diff --git

[RESEND PATCH 05/10] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-03 Thread Borislav Petkov
There should be no functional change resulting from this patch. Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c | 90 +- 1 files changed, 57 insertions(+), 33 deletions(-) diff --git a/drivers/ide/ide-floppy.c

[RESEND PATCH 03/10] ide-floppy: convert to generic packet commands

2008-01-03 Thread Borislav Petkov
Replace the ide-floppy packet commands opcode defines with the generic ones. Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The last one can be found in the current version of INF-8090, p.905. CC: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by: Borislav Petkov <[EMAIL

[RESEND PATCH 0/10] ide-floppy redux p1

2008-01-03 Thread Borislav Petkov
Hi Bart, here's the unfinished redux of ide-floppy which i'm REsending now so that we could sinchronize trees. The original send got busted in vger's filters due to syntax error in the Message-ID tag. Documentation/ide/ChangeLog.ide-floppy.1996-2002 | 64 ++ drivers/ide/ide-floppy.c

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-03 Thread Gabor Gombas
On Wed, Jan 02, 2008 at 04:16:42PM +0100, Gabor Gombas wrote: > So the patch referenced above does not help. But I've found a very easy > way to trigger the bug: > > - do a "cat /dev/zero > /dev/rfcomm0" > - switch the phone off > - switch the phone on, and the kernel oopses FYI I also remember

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-01-03 Thread Andi Kleen
> Can we please just nuke CONFIG_HIGHPTE? There's only been a small > amount of 32bit machines It's unfortunately a larger amount :/ And for unknown reasons a lot of people still install 32bit kernels on new perfectly capable 64bit systems even if they have a lot of memory. I don't think

Re: Make checkpatch.pl's quiet option not print the summary on no errors

2008-01-03 Thread Andy Whitcroft
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote: > Subject: Make checkpatch.pl's quiet option not print the summary on no > errors > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED] > > Right now, in quiet mode, checkpatch.pl still prints a summary line even >

Re: git-x86 broken on 32bit

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 09:10:25 Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > Current git-x86 seems to be totally broken on i386 > > > > > > commit a6f08929f0566f9d309ef5f6651371d8e20fc833 > > > Author: Russell

Re: [PATCH] [1/20] x86: Make ptrace.h safe to include from assembler code

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 10:54:52 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Index: linux/include/asm-x86/ptrace-abi.h > > === > > --- linux.orig/include/asm-x86/ptrace-abi.h > > +++

Re: [PATCH] [19/20] x86: Use shorter addresses in i386 segfault printks

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 11:56:14 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > x86: Use shorter addresses in i386 segfault printks > > hm, why? It's pretty well-established that we print addresses 8 char > wide on 32-bit. It's useless. What purpose does it have?

Re: [PATCH] [20/20] x86: Print which shared library/executable faulted in segfault etc. messages

2008-01-03 Thread Andi Kleen
> > And printing the offset into a mapping also always allows to find the > > correct fault point in a library even with randomized mappings. Previously > > there was no way to actually find the correct code address inside > > the randomized mapping. > > > > Relies on earlier patch to shorten

Re: [PATCH] [12/20] x86: Use a per cpu timer for correctable machine check checking

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 11:49:56 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Previously the code used a single timer that then used > > smp_call_function to interrupt all CPUs while the original CPU was > > waiting for them. > > > > But it is better / more real

Re: [PATCH] [11/20] x86: Use the correct cpuid method to detect MWAIT support for C states

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 11:45:26 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > +static int mwait_usable(const struct cpuinfo_x86 *c) > > +{ > > + if (force_mwait) > > + return 1; > > + /* Any C1 states supported? */ > > + return c->cpuid_level >= 5 &&

Re: [PATCH] [5/20] x86: Introduce nsec_barrier()

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 11:47:54 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > nsec_barrier() is a new barrier primitive that stops RDTSC speculation > > to avoid races with timer interrupts on other CPUs. > > > > Add it to all architectures. Except for x86 it is a

Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 11:39:12 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > It is not really useful to lock machine checks against oopses. And > > machine checks normally don't nest, so they don't need their own > > locking. Just call bust_spinlock/console_verbose

Re: [uml-devel] UML woes in 2.6.24-rc6-mm1

2008-01-03 Thread Miklos Szeredi
> > 32bit UML, 64bit host, config attached. > > Hadn't tried that, but that works here too. > > I'll see if your config reproduces it. > > > Can't reproduce with plain -rc6. > > Feel like bisecting -mm1? This is the one: uml-runtime-detection-of-host-vmsplit-on-i386.patch The relevant log

Re: serial console _after_ boot ? - was: Redirect kernel console

2008-01-03 Thread devzero
hi ! i was wondering how to make kernel messages appear on /dev/ttyS0 without a reboot, i.e. kernelparam "console=ttyS0" after playing for a while with setconsole, setterm and klogconsole i didn`t find a way to make that happen. i can do "setconsole /dev/tty1 /dev/console" and see "test" on

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Tomas Carnecky
Christer Weinigel wrote: By the way, what is the consensus on lines over 80 characters? checkpatch complains about the following: WARNING: line over 80 characters #762: FILE: drivers/spi/spi_s3c24xx_dma.c:720: + printk(KERN_INFO "S3C24xx SPI DMA driver (c) 2007 Nordnav Technologies

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 03, 2008 at 12:26:10PM +, Christoph Hellwig escreveu: > On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: > > We have had some stabs at changing this, but no consensus was reached on > > whether it was a "for" or a "function". My memory is of there being > > slightly

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Christoph Hellwig
On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: > We have had some stabs at changing this, but no consensus was reached on > whether it was a "for" or a "function". My memory is of there being > slightly more "without a space" tenders than the other and so it has not > been

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[Tomas Carnecky - Thu, Jan 03, 2008 at 01:10:28PM +0100] > Cyrill Gorcunov wrote: >> [=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] >> | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: >> | > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) >> | >

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Tomas Carnecky
Cyrill Gorcunov wrote: [=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | > | > if (print) { | > printk(KERN_WARNING | > -

[Patch] xfrm_policy_destroy: rename and relative fixes

2008-01-03 Thread WANG Cong
Since __xfrm_policy_destroy is used to destory the resources allocated by xfrm_policy_alloc. So using the name __xfrm_policy_destroy is not correspond with xfrm_policy_alloc. Rename it to xfrm_policy_destroy. And along with some instances that call xfrm_policy_alloc but not using

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
[=?ISO-8859-1?Q?J=F6rn_Engel_ - Thu, Jan 03, 2008 at 12:29:57PM +0100] | On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: | > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) | > | > if (print) { | > printk(KERN_WARNING | > - "audit:

Re: [PATCHv3] powerpc: DBox2 Board Support

2008-01-03 Thread Jochen Friedrich
Hi David, +/ { + model = "unknown,dbox2"; // boot wrapper fills in correct manufacturer Probably better just to leave model out of the dts and let the bootwrapper add it. Unfortunately, dtc requires a model: $ dtc arch/powerpc/boot/dts/dbox2.dts DTC: dts->dts on file

Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Jörn Engel
On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote: > @@ -232,7 +232,8 @@ void audit_log_lost(const char *message) > > if (print) { > printk(KERN_WARNING > -"audit: audit_lost=%d audit_rate_limit=%d > audit_backlog_limit=%d\n", > +

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread pHilipp Zabel
On Dec 2, 2007 1:03 PM, Christer Weinigel <[EMAIL PROTECTED]> wrote: > Hi Andy, > > you seem to be the last person messing around with checkpatch.pl so I'm > addressing this to you. :-) > > checkpatch complains about the following: > > WARNING: no space between function name and open parenthesis

[x86] kernel/audit.c cleanup according to checkpatch.pl

2008-01-03 Thread Cyrill Gorcunov
This patch eliminates code-style errors according to checkpatch.pl Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- Ingo, David, md5sums will be different for old and patched asm listings due to: - zero initialized static vars take off - assignments moved out from 'if'

Re: [patch 1/3] move WARN_ON() out of line

2008-01-03 Thread Pekka Enberg
Hi Arjan, On Jan 3, 2008 2:56 AM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > +int do_warn_on(const unsigned long condition, const char *file, > + const int line, const char *function) > +{ > + if (unlikely(condition)) { > + printk(KERN_WARNING

Re: struct should not be named same way as function in sony-laptop

2008-01-03 Thread Al Viro
On Thu, Jan 03, 2008 at 12:01:54PM +0100, Pavel Machek wrote: > Naming struct and function by same name is evil. Rename the struct. Um... why? It's not even particulary bad style per se... Occurs less frequently than things like struct foo *foo; but nothing inherently terrible and not

Re: freeze vs freezer

2008-01-03 Thread Oliver Neukum
Am Donnerstag, 3. Januar 2008 10:52:53 schrieb Nigel Cunningham: > Hi. > > Oliver Neukum wrote: > > Am Donnerstag 03 Januar 2008 schrieb Nigel Cunningham: > >> On top of this, I made a (too simple at the moment) freeze_filesystems > >> function which iterates through _blocks in reverse order,

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Andy Whitcroft
On Sun, Dec 02, 2007 at 01:03:35PM +0100, Christer Weinigel wrote: > Hi Andy, > > you seem to be the last person messing around with checkpatch.pl so I'm > addressing this to you. :-) > > checkpatch complains about the following: > > WARNING: no space between function name and open parenthesis

don't #error on higher HZ values

2008-01-03 Thread Pavel Machek
For some crazy reason (trying to work around hw problem in i810) I wanted to use HZ around 4000. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> Pavel diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h index

Re: [PATCH 2/2] Kprobes: Move kprobes examples to samples/

2008-01-03 Thread Ingo Molnar
* Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> wrote: > > feature request: please make this work in the !modular case as well > > - if built-in then it should just run sometime during bootup and run > > the tests and report success/failure. This way automated testing can > > pick up any

struct should not be named same way as function in sony-laptop

2008-01-03 Thread Pavel Machek
Naming struct and function by same name is evil. Rename the struct. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c index b0f6803..31ce39d 100644 --- a/drivers/misc/sony-laptop.c +++ b/drivers/misc/sony-laptop.c @@ -1180,7

Re: [PATCH] [15/20] x86: Move X86_FEATURE_CONSTANT_TSC into early cpu feature detection

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Need this in the next patch in time_init and that happens early. > > This includes a minor fix on i386 where early_intel_workarounds() > [which is now called early_init_intel] really executes early as the > comments say. thanks, applied. I'll wait

Re: [PATCH] [20/20] x86: Print which shared library/executable faulted in segfault etc. messages

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > They now look like > > hal-resmgr[13791]: segfault at 3c rip 2b9c8caec182 rsp 7fff1e825d30 > error 4 in libacl.so.1.1.0[2b9c8caea000+6000] > > This makes it easier to pinpoint bugs to specific libraries. yep, that's really useful. I think the patch

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-03 Thread Pavel Machek
Hi! > > > > That way any suspend breakage would be detectable (and bisectable) > > > > in automated testing - if the resume does not come back after 10-20 > > > > seconds then the test failed. > > > > > > Yes, but please note that some systems require user space > > > manipulations of the

Re: [PATCH] [19/20] x86: Use shorter addresses in i386 segfault printks

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > x86: Use shorter addresses in i386 segfault printks hm, why? It's pretty well-established that we print addresses 8 char wide on 32-bit. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] [12/20] x86: Use a per cpu timer for correctable machine check checking

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Previously the code used a single timer that then used > smp_call_function to interrupt all CPUs while the original CPU was > waiting for them. > > But it is better / more real time and more power friendly to simply > run individual timers on each

Re: [PATCH] [5/20] x86: Introduce nsec_barrier()

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > nsec_barrier() is a new barrier primitive that stops RDTSC speculation > to avoid races with timer interrupts on other CPUs. > > Add it to all architectures. Except for x86 it is a nop right now. I > only tested x86, but it's a very simple change. >

Re: [RFC][PATCH 3/7] ACPI: Separate disabling of GPEs from _PTS

2008-01-03 Thread Pavel Machek
Hi! > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The preparation to enter an ACPI system sleep state is now tied to > the disabling of GPEs, but the GPEs should not be disabled before > suspending devices. Since on ACPI 1.0x systems the _PTS global > control method should be executed

Re: [PATCH] [11/20] x86: Use the correct cpuid method to detect MWAIT support for C states

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > +static int mwait_usable(const struct cpuinfo_x86 *c) > +{ > + if (force_mwait) > + return 1; > + /* Any C1 states supported? */ > + return c->cpuid_level >= 5 && ((cpuid_edx(5) >> 4) & 0xf) > 0; > +} > + > void __cpuinit

Re: [PATCH] [10/20] i386: Move MWAIT idle check to generic CPU initialization

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Previously it was only run for Intel CPUs, but AMD Fam10h implements > MWAIT too. > > This matches 64bit behaviour. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> thanks, applied. Ingo -- To unsubscribe from this list: send the line

Re: [RFC][PATCH 2/7] ACPI: Separate invocations of _GTS and _BFS from _PTS and _WAK

2008-01-03 Thread Pavel Machek
On Thu 2007-12-27 19:15:16, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The execution of ACPI global control methods _GTS and _BFS is > currently tied to the preparation to enter a sleep state and to the > leaving of the sleep state, respectively. However, these

Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > It is not really useful to lock machine checks against oopses. And > machine checks normally don't nest, so they don't need their own > locking. Just call bust_spinlock/console_verbose directly. is this in response to any particular incident you've

"mconf" and help texts

2008-01-03 Thread Ph. Marek
Hello everybody! [[ Please keep me CC'ed. Thank you. ]] I just tried looking at NF_CONNTRACK_MARK (menuconfig, in 2.6.23.12), and found it disallowed. So I took a look at "Help", and saw that blob: Selected by: NETFILTER_XT_TARGET_CONNMARK && NET && INET && NETFILTER &&

Re: [PATCH 2/2] Kprobes: Move kprobes examples to samples/

2008-01-03 Thread Ananth N Mavinakayanahalli
On Thu, Jan 03, 2008 at 10:33:03AM +0100, Ingo Molnar wrote: > > * Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> wrote: > > > From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > > > > Move kprobes examples from Documentation/kprobes.txt to under > > samples/. Patch originally by Randy

Re: Kernel BUG in 2.6.23.9

2008-01-03 Thread Tarkan Erimer
Arjan van de Ven wrote: On Sun, 09 Dec 2007 14:49:16 -0500 Jerry Geis <[EMAIL PROTECTED]> wrote: I am using centos 5.1, 2.6.23.9 kernel. Machine works great all day. Then sometime through the night the kernel dies, the trace is below. is this when a 3D screensaver is active? Probably

Re: [PATCH] [1/20] x86: Make ptrace.h safe to include from assembler code

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Index: linux/include/asm-x86/ptrace-abi.h > === > --- linux.orig/include/asm-x86/ptrace-abi.h > +++ linux/include/asm-x86/ptrace-abi.h > @@ -80,6 +80,7 @@ > > #define PTRACE_SINGLEBLOCK

Re: freeze vs freezer

2008-01-03 Thread Nigel Cunningham
Hi. Oliver Neukum wrote: > Am Donnerstag 03 Januar 2008 schrieb Nigel Cunningham: >> On top of this, I made a (too simple at the moment) freeze_filesystems >> function which iterates through _blocks in reverse order, freezing >> fuse filesystems or ordinary ones. I say 'too simple' because it

Re: freeze vs freezer

2008-01-03 Thread Oliver Neukum
Am Donnerstag 03 Januar 2008 schrieb Nigel Cunningham: > On top of this, I made a (too simple at the moment) freeze_filesystems > function which iterates through _blocks in reverse order, freezing > fuse filesystems or ordinary ones. I say 'too simple' because it doesn't > currently allow for the

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-03 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > Currently the notify_page_fault helper is used to test it the page > fault was caused by a kprobe causing an early return from > do_page_fault. > > Change the name of the helper to is_kprobe_fault to match the usage > and remove the

Re: [PATCH 2/2] Kprobes: Move kprobes examples to samples/

2008-01-03 Thread Ingo Molnar
* Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> wrote: > From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > > Move kprobes examples from Documentation/kprobes.txt to under > samples/. Patch originally by Randy Dunlap. nice! > +config SAMPLE_KPROBES > + tristate "Build kprobes

Re: [GIT] More NFS client fixes for 2.6.24-rc6

2008-01-03 Thread Ingo Molnar
* Trond Myklebust <[EMAIL PROTECTED]> wrote: > commit 53478daff2c8b494d2af1ede6611f166f81bc393 > Author: Trond Myklebust <[EMAIL PROTECTED]> > Date: Wed Jan 2 13:28:57 2008 -0500 > > NFS: Fix a possible Oops in fs/nfs/super.c > > Sigh... commit

Re: [patch 1/3] move WARN_ON() out of line

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven <[EMAIL PROTECTED]> wrote: > +#define WARN_ON(condition) do_warn_on((unsigned long)(condition), __FILE__, \ > + __LINE__, __FUNCTION__) hm. This passes in 4 arguments to do_warn_on(). i think we could get away with no arguments (!), by

Re: neigh: timer & !nud_in_timer

2008-01-03 Thread John Sigler
John Sigler wrote: I noticed the following message in my kernel log. kernel: neigh: timer & !nud_in_timer (Might be due to a race condition.) I'm running a UP Linux version 2.6.22.1-rt9 ( http://rt.wiki.kernel.org/index.php ) The following /proc entries might be relevant.

Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation

2008-01-03 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > +# function tracing might turn this off: > +config REGPARM > + bool > + depends on !MCOUNT > + default y are you sure -pg really needs this? I just carried this along the years and went the path of least resistence, but we should not be

Re: freeze vs freezer

2008-01-03 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: > On Wednesday, 2 of January 2008, Nigel Cunningham wrote: >> Pavel Machek wrote: So how do you handle threads that are blocked on I/O or a lock during the system freeze process, then? >>> We wait until they can continue. >> So if I have a

[PATCH] aio: negative offset should return -EINVAL

2008-01-03 Thread Rusty Russell
An AIO read or write should return -EINVAL if the offset is negative. This check matches the one in pread and pwrite. This was found by the libaio test suite. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 18802689361a fs/aio.c --- a/fs/aio.c Thu Jan 03 15:22:24 2008 +1100 +++

[PATCH] aio: partial write should not return error code.

2008-01-03 Thread Rusty Russell
When an AIO write gets an error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to. This was found by the libaio test suite. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 18802689361a fs/aio.c ---

Re: [patch 02/20] make the inode i_mmap_lock a reader/writer lock

2008-01-03 Thread Ingo Molnar
* Nick Piggin <[EMAIL PROTECTED]> wrote: > > Have you done anything more with allowing > 256 CPUS in this > > spinlock patch? We've been testing with 1k cpus and to verify with > > -mm kernel, we need to "unpatch" these spinlock changes. > > Hi Mike, > > Actually I had it in my mind that 64

<    1   2   3   4   5   6   7   8   >