Use regulator_set_voltage_time_sel() instead of open-coded.
Signed-off-by: Axel Lin axel@ingics.com
---
Hi Keerthy,
This patch was sent on:
https://lkml.org/lkml/2014/2/18/190
I'd appreciate if you can review and test it.
Thanks,
Axel
drivers/regulator/tps65218-regulator.c | 37
The devm_clk_unregister() in probe error paths are not necessary as it will be
automatically called when probe fails.
Signed-off-by: Axel Lin
---
drivers/clk/clk-s2mps11.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk
Use devm_clk_register() to simplify the code by removing twl6040_clk_remove().
Signed-off-by: Axel Lin
---
drivers/clk/clk-twl6040.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
index 1ada79a..9e996b4
Use devm_clk_register() to simplify the code by removing twl6040_clk_remove().
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/clk/clk-twl6040.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
index
The devm_clk_unregister() in probe error paths are not necessary as it will be
automatically called when probe fails.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/clk/clk-s2mps11.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/clk
2014-05-07 17:48 GMT+08:00 Krzysztof Kozlowski :
> I forgot to CC the stable.
>
> Mark, if the patches are OK and if you'll apply them, could you add a CC
> stable to the commit msg?
Hi Krzysztof,
Unless this serial misses 3.15, I think this serial does not need to CC stable.
Both
b96244fad953
2014-05-07 17:48 GMT+08:00 Krzysztof Kozlowski k.kozlow...@samsung.com:
I forgot to CC the stable.
Mark, if the patches are OK and if you'll apply them, could you add a CC
stable to the commit msg?
Hi Krzysztof,
Unless this serial misses 3.15, I think this serial does not need to CC stable.
t for the bucks unsupporting enable/disable
> (buck[15789] and buck10), the ramp delay for buck6 was also enabled.
>
> Signed-off-by: Krzysztof Kozlowski
> Fixes: b96244fad953 ("regulator: s2mps11: Don't check enable_shift before
> setting enable ramp rate")
For this serial,
Revie
-by: Axel Lin axel@ingics.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
2014-05-05 23:10 GMT+08:00 Krzysztof Kozlowski :
> S2MPA01 supports enabling/disabling ramp delay only for buck[1234].
> Other bucks have ramp delay enabled always.
>
> However the bit shift for enabling buck4 ramp delay in register is equal
> to 0. When ramp delay was set for these other bucks
2014-05-05 23:10 GMT+08:00 Krzysztof Kozlowski k.kozlow...@samsung.com:
S2MPA01 supports enabling/disabling ramp delay only for buck[1234].
Other bucks have ramp delay enabled always.
However the bit shift for enabling buck4 ramp delay in register is equal
to 0. When ramp delay was set for
interrupt enable bit for all interrupt trigger
mode.
According to the datasheet, the Interrupt Status Register is written one to
clear(Write 0 has no effect). So we don't need a read-modify-write operation
for clearing a bit in interrupt status register.
Signed-off-by: Axel Lin
---
Resend and also
interrupt enable bit for all interrupt trigger
mode.
According to the datasheet, the Interrupt Status Register is written one to
clear(Write 0 has no effect). So we don't need a read-modify-write operation
for clearing a bit in interrupt status register.
Signed-off-by: Axel Lin axel@ingics.com
interrupt enable bit for all interrupt trigger
mode.
According to the datasheet, the Interrupt Status Register is written one to
clear(Write 0 has no effect). So we don't need a read-modify-write operation
for clearing a bit in interrupt status register.
Signed-off-by: Axel Lin
---
drivers/irqchip
2014-04-28 18:08 GMT+08:00 Thomas Gleixner :
> On Mon, 28 Apr 2014, Axel Lin wrote:
>
>> According to the datasheet, the attribute of Interrupt Status Register is
>> RW0S,
>> which means:
>> Software can read the register.
>> Software can al
2014-04-28 18:08 GMT+08:00 Thomas Gleixner t...@linutronix.de:
On Mon, 28 Apr 2014, Axel Lin wrote:
According to the datasheet, the attribute of Interrupt Status Register is
RW0S,
which means:
Software can read the register.
Software can also write 1 to clear. write 0 has
interrupt enable bit for all interrupt trigger
mode.
According to the datasheet, the Interrupt Status Register is written one to
clear(Write 0 has no effect). So we don't need a read-modify-write operation
for clearing a bit in interrupt status register.
Signed-off-by: Axel Lin axel@ingics.com
write clear
instead.
Signed-off-by: Axel Lin
---
v2: Update commit log, this is a code simplification rather than bug fix.
drivers/irqchip/irq-vt8500.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-vt8500.c b/drivers/irqchip/irq-vt8500.c
index eb6
2014-04-28 2:34 GMT+08:00 Thomas Gleixner :
> On Sun, 27 Apr 2014, Axel Lin wrote:
>
>> According to the datasheet, the attribute of Interrupt Status Register is
>> RW0S,
>> which means:
>> Software can read the register.
>> Software can al
/write does not make sense for an irq status register like this,
since otherwise a read/modify/write can race with a device raising an interrupt
and then clear the pending bit unintentionally.
Signed-off-by: Axel Lin
---
Hi Tony,
I don't have this h/w to test, I'd appreciate if you can review
2014-04-28 2:34 GMT+08:00 Thomas Gleixner t...@linutronix.de:
On Sun, 27 Apr 2014, Axel Lin wrote:
According to the datasheet, the attribute of Interrupt Status Register is
RW0S,
which means:
Software can read the register.
Software can also write 1 to clear. write 0 has
-off-by: Axel Lin axel@ingics.com
---
v2: Update commit log, this is a code simplification rather than bug fix.
drivers/irqchip/irq-vt8500.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-vt8500.c b/drivers/irqchip/irq-vt8500.c
index eb6e91e..a0085bc
sense for an irq status register like this,
since otherwise a read/modify/write can race with a device raising an interrupt
and then clear the pending bit unintentionally.
Signed-off-by: Axel Lin axel@ingics.com
---
Hi Tony,
I don't have this h/w to test, I'd appreciate if you can review and test
The valid gpio is GPIO0 ~ GPIO58, so ngpio should be 59.
This patch also renames RDC321X_MAX_GPIO to RDC321X_NUM_GPIO because it
actually means the number of available GPIOs.
Signed-off-by: Axel Lin
Acked-by: Linus Walleij
---
drivers/mfd/rdc321x-southbridge.c | 2 +-
include/linux/mfd
The valid gpio is GPIO0 ~ GPIO58, so ngpio should be 59.
This patch also renames RDC321X_MAX_GPIO to RDC321X_NUM_GPIO because it
actually means the number of available GPIOs.
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Linus Walleij linus.wall...@linaro.org
---
drivers/mfd/rdc321x
2014-04-15 5:16 GMT+08:00 Mark Brown :
> On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only
Now this driver uses devm_regulator_register() so we don't need to save rdev
pointer to tps->rdev[i] for cleanup.
Signed-off-by: Axel Lin
---
drivers/regulator/tps65217-regulator.c | 3 ---
include/linux/mfd/tps65217.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/driv
The *rdev[] is not used since commit 413be59e2f333
"regulator: tps65218: Remove unnecessary regulator_unregister call".
Signed-off-by: Axel Lin
---
include/linux/mfd/tps65218.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps652
The *rdev[] is not used since commit 413be59e2f333
regulator: tps65218: Remove unnecessary regulator_unregister call.
Signed-off-by: Axel Lin axel@ingics.com
---
include/linux/mfd/tps65218.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd
Now this driver uses devm_regulator_register() so we don't need to save rdev
pointer to tps-rdev[i] for cleanup.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/tps65217-regulator.c | 3 ---
include/linux/mfd/tps65217.h | 1 -
2 files changed, 4 deletions(-)
diff
2014-04-15 5:16 GMT+08:00 Mark Brown broo...@kernel.org:
On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27
Since commit ca5d1b3524b4d
"regulator: helpers: Modify helpers enabling multi-bit control",
we can set enable_val setting for device that use multiple bits for control
when using regmap enable/disable/bypass ops.
Signed-off-by: Axel Lin
Tested-by: Balaji T K
---
drivers/regul
Since commit ca5d1b3524b4d
regulator: helpers: Modify helpers enabling multi-bit control,
we can set enable_val setting for device that use multiple bits for control
when using regmap enable/disable/bypass ops.
Signed-off-by: Axel Lin axel@ingics.com
Tested-by: Balaji T K balaj...@ti.com
2014-04-02 8:26 GMT+08:00 Axel Lin :
> 2014-03-08 11:55 GMT+08:00 Axel Lin :
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) b
2014-04-02 8:26 GMT+08:00 Axel Lin axel@ingics.com:
2014-03-08 11:55 GMT+08:00 Axel Lin axel@ingics.com:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27
2014-04-06 17:30 GMT+08:00 Steffen Trumtrar :
> Hi!
>
> On Sun, Apr 06, 2014 at 11:19:41AM +0800, Axel Lin wrote:
>> This driver is replaced by pwm-pca9685 driver and there is no user uses this
>> driver in current tree. So remove it.
>>
>> Signed-off-by: A
2014-04-06 17:30 GMT+08:00 Steffen Trumtrar s.trumt...@pengutronix.de:
Hi!
On Sun, Apr 06, 2014 at 11:19:41AM +0800, Axel Lin wrote:
This driver is replaced by pwm-pca9685 driver and there is no user uses this
driver in current tree. So remove it.
Signed-off-by: Axel Lin axel@ingics.com
This driver is replaced by pwm-pca9685 driver and there is no user uses this
driver in current tree. So remove it.
Signed-off-by: Axel Lin
---
Hi,
I found there is a modalias conflict between leds-pca9685.ko and pwm-pca9685.ko.
I think this conflict will cause problem.
After checking the code, I
This driver is replaced by pwm-pca9685 driver and there is no user uses this
driver in current tree. So remove it.
Signed-off-by: Axel Lin axel@ingics.com
---
Hi,
I found there is a modalias conflict between leds-pca9685.ko and pwm-pca9685.ko.
I think this conflict will cause problem.
After
Define __PINCTRL_LANTIQ_H to prevent multiple inclusion.
Signed-off-by: Axel Lin
---
drivers/pinctrl/pinctrl-lantiq.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-lantiq.h b/drivers/pinctrl/pinctrl-lantiq.h
index 6d07f02..c7cfad5 100644
--- a/drivers/pinctrl
It's only referenced in this file, make it static.
Signed-off-by: Axel Lin
---
drivers/pinctrl/pinctrl-adi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c
index 0cc0eec..5c44feb 100644
--- a/drivers/pinctrl
It's only referenced in this file, make it static.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/pinctrl/pinctrl-adi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c
index 0cc0eec..5c44feb 100644
Define __PINCTRL_LANTIQ_H to prevent multiple inclusion.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/pinctrl/pinctrl-lantiq.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-lantiq.h b/drivers/pinctrl/pinctrl-lantiq.h
index 6d07f02..c7cfad5 100644
2014-03-08 11:55 GMT+08:00 Axel Lin :
> The is_enabled implementation is wrong in some cases:
> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
> So is_enabled callback will always
2014-03-08 11:55 GMT+08:00 Axel Lin axel@ingics.com:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
So is_enabled callback will always return
2014-03-21 16:15 GMT+08:00 Axel Lin :
> Current code misses updating the register when enable_shift is 0.
> e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Hi Sachin and Krzysztof,
I think these 2 patches are bug fix.
Any comment on this patch serial?
Regards,
Axel
--
To unsubscribe from this list
This simplifies error and cleanup code paths.
Signed-off-by: Axel Lin
---
drivers/bus/omap_l3_smx.c | 53 +++
1 file changed, 12 insertions(+), 41 deletions(-)
diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c
index acc2164..90840cf
This simplifies error and cleanup code paths.
Also uses of_match_ptr() around of_match_table.
Signed-off-by: Axel Lin
---
drivers/bus/omap_l3_noc.c | 94 ++-
1 file changed, 19 insertions(+), 75 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b
Add missing mfd_remove_devices() call in remove function.
Signed-off-by: Axel Lin
---
drivers/mfd/bcm590xx.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 40c0dd3..c986149 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd
This is a i2c driver, so uses i2c prefix in modalias.
Signed-off-by: Axel Lin
---
drivers/mfd/bcm590xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index e9a33c7..40c0dd3 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers
This is a i2c driver, so uses i2c prefix in modalias.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/mfd/bcm590xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index e9a33c7..40c0dd3 100644
--- a/drivers/mfd
Add missing mfd_remove_devices() call in remove function.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/mfd/bcm590xx.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 40c0dd3..c986149 100644
--- a/drivers/mfd/bcm590xx.c
This simplifies error and cleanup code paths.
Also uses of_match_ptr() around of_match_table.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/bus/omap_l3_noc.c | 94 ++-
1 file changed, 19 insertions(+), 75 deletions(-)
diff --git a/drivers
This simplifies error and cleanup code paths.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/bus/omap_l3_smx.c | 53 +++
1 file changed, 12 insertions(+), 41 deletions(-)
diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c
2014-03-21 16:15 GMT+08:00 Axel Lin axel@ingics.com:
Current code misses updating the register when enable_shift is 0.
e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Hi Sachin and Krzysztof,
I think these 2 patches are bug fix.
Any comment on this patch serial?
Regards,
Axel
--
To unsubscribe
The voltages in aat2870_ldo_voltages table are in ascendant order, so use
regulator_map_voltage_ascend.
Signed-off-by: Axel Lin
---
drivers/regulator/aat2870-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/aat2870-regulator.c
b/drivers/regulator/aat2870
The voltages in aat2870_ldo_voltages table are in ascendant order, so use
regulator_map_voltage_ascend.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/aat2870-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/aat2870-regulator.c
b/drivers
Also remove test for selector in st_pwm_regulator_set_voltage_sel, the checking
is already done in .list_voltage.
Signed-off-by: Axel Lin
---
drivers/regulator/st-pwm.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/st-pwm.c b/drivers/regulator/st
Current code misses updating the register when enable_shift is 0.
e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Signed-off-by: Axel Lin
---
drivers/regulator/s2mpa01.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator
Current code misses updating the register when enable_shift is 0.
e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0.
Signed-off-by: Axel Lin
---
drivers/regulator/s2mps11.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator
Since commit ca5d1b3524b4d
"regulator: helpers: Modify helpers enabling multi-bit control",
we can set enable_val setting for device that use multiple bits for control.
Signed-off-by: Axel Lin
---
drivers/regulator/s5m8767.c | 78 +++--
1 file c
Since commit ca5d1b3524b4d
regulator: helpers: Modify helpers enabling multi-bit control,
we can set enable_val setting for device that use multiple bits for control.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/s5m8767.c | 78 +++--
1
Current code misses updating the register when enable_shift is 0.
e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/s2mps11.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git
Current code misses updating the register when enable_shift is 0.
e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/s2mpa01.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/s2mpa01.c b
Also remove test for selector in st_pwm_regulator_set_voltage_sel, the checking
is already done in .list_voltage.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/st-pwm.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/st-pwm.c b
2014-03-20 23:42 GMT+08:00 Matt Porter :
> On Fri, Mar 14, 2014 at 10:00:28AM +0800, Axel Lin wrote:
>> BCM590XX_NUM_REGS is known in compile time.
>> Use array to save desc and *info makes the code simpler.
>>
>> Signed-off-by: Axel Lin
>
> Well, ok. It was cod
2014-03-20 23:42 GMT+08:00 Matt Porter mpor...@linaro.org:
On Fri, Mar 14, 2014 at 10:00:28AM +0800, Axel Lin wrote:
BCM590XX_NUM_REGS is known in compile time.
Use array to save desc and *info makes the code simpler.
Signed-off-by: Axel Lin axel@ingics.com
Well, ok. It was coded
2014-03-17 9:47 GMT+08:00 Guenter Roeck :
> Commit 09e99bca8 (spi: sc18is602: Convert to let spi core validate
> transfer speed) made the maximum transfer speed much more restrictive
> than before. The transfer speed used to be adjusted to 1/4 of the chip
> clock rate if a higher transfer speed
2014-03-17 9:47 GMT+08:00 Guenter Roeck li...@roeck-us.net:
Commit 09e99bca8 (spi: sc18is602: Convert to let spi core validate
transfer speed) made the maximum transfer speed much more restrictive
than before. The transfer speed used to be adjusted to 1/4 of the chip
clock rate if a higher
-by: Axel Lin
---
drivers/mfd/bcm590xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 926a57e..e9a33c7 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -68,7 +68,7 @@ static const struct of_device_id
-by: Axel Lin axel@ingics.com
---
drivers/mfd/bcm590xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 926a57e..e9a33c7 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -68,7 +68,7 @@ static const struct
BCM590XX_NUM_REGS is known in compile time.
Use array to save desc and *info makes the code simpler.
Signed-off-by: Axel Lin
---
drivers/regulator/bcm590xx-regulator.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c
The **rdev of 'struct bcm590xx_reg' isn't used anywhere in the driver so
remove it.
Signed-off-by: Axel Lin
---
drivers/regulator/bcm590xx-regulator.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c
b/drivers/regulator/bcm590xx-regulator.c
Signed-off-by: Axel Lin
---
drivers/regulator/bcm590xx-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c
b/drivers/regulator/bcm590xx-regulator.c
index e6b2e8e..d12d6d6 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/bcm590xx-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c
b/drivers/regulator/bcm590xx-regulator.c
index e6b2e8e..d12d6d6 100644
--- a/drivers/regulator
The **rdev of 'struct bcm590xx_reg' isn't used anywhere in the driver so
remove it.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/bcm590xx-regulator.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c
b/drivers/regulator
BCM590XX_NUM_REGS is known in compile time.
Use array to save desc and *info makes the code simpler.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/bcm590xx-regulator.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/regulator
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[]
array to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin
---
drivers/regulator/max8998.c | 20 ++--
1 file changed
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[]
array to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin
---
drivers/regulator/max8997.c | 19 ++-
1 file changed, 6
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[]
array to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin
---
drivers/regulator/max77693.c | 16 +---
1 file changed, 5
Now we are using devm_regulator_register(), so we don't need the *rdev[] array
to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin
---
drivers/regulator/act8865-regulator.c | 13 +
1 file changed, 5
Now we are using devm_regulator_register(), so we don't need the rdev[] array
to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin
---
drivers/regulator/tps6586x-regulator.c | 14 --
1 file changed, 4
Now we are using devm_regulator_register(), so we don't need the rdev[] array
to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/tps6586x-regulator.c | 14 --
1
Now we are using devm_regulator_register(), so we don't need the *rdev[] array
to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/act8865-regulator.c | 13 +
1
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[]
array to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/max77693.c | 16
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[]
array to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/max8997.c | 19
Now we are using devm_regulator_register(), so we don't need to allocate *rdev[]
array to store return value of devm_regulator_register. Use a *rdev variable is
enough for checking return status.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/max8998.c | 20
This patch converts this driver to use the regmap helper functions provided by
regulator core.
Signed-off-by: Axel Lin
Acked-by: Balaji T K
---
v2: Add Balaji's Ack.
drivers/regulator/pbias-regulator.c | 74 ++---
1 file changed, 19 insertions(+), 55 deletions
with info->enable rather than
info->enable_mask.
Signed-off-by: Axel Lin
Acked-by: Balaji T K
---
v2: Update commit log and add Balaji's Ack.
drivers/regulator/pbias-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pbias-regulator.c
b/d
2014-03-07 23:25 GMT+08:00 Balaji T K :
> On Thursday 06 March 2014 06:40 PM, Axel Lin wrote:
>>
>> This patch converts this driver to use the regmap helper functions
>> provided by
>> regulator core.
>>
>> This fixes a few issues in current implementat
Since commit ca5d1b3524b4d
"regulator: helpers: Modify helpers enabling multi-bit control",
we can set enable_val setting for device that use multiple bits for control
when using regmap enable/disable/bypass ops.
Signed-off-by: Axel Lin
---
Note:
This patch depends on below commit whi
This patch converts this driver to use the regmap helper functions provided by
regulator core.
Signed-off-by: Axel Lin
---
drivers/regulator/pbias-regulator.c | 74 ++---
1 file changed, 19 insertions(+), 55 deletions(-)
diff --git a/drivers/regulator/pbias
with info->enable rather than
info->enable_mask.
Signed-off-by: Axel Lin
---
drivers/regulator/pbias-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pbias-regulator.c
b/drivers/regulator/pbias-regulator.c
index ded3b35..d89a1d8
2014-03-06 23:20 GMT+08:00 Balaji T K :
> On Thursday 06 March 2014 06:40 PM, Axel Lin wrote:
>>
>> This patch converts this driver to use the regmap helper functions
>> provided by
>> regulator core.
>>
>> This fixes a few issues in current implementat
2014-03-06 23:20 GMT+08:00 Balaji T K balaj...@ti.com:
On Thursday 06 March 2014 06:40 PM, Axel Lin wrote:
This patch converts this driver to use the regmap helper functions
provided by
regulator core.
This fixes a few issues in current implementation:
1) In original code, the set voltage
with info-enable rather than
info-enable_mask.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/pbias-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pbias-regulator.c
b/drivers/regulator/pbias-regulator.c
index ded3b35..d89a1d8
This patch converts this driver to use the regmap helper functions provided by
regulator core.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/pbias-regulator.c | 74 ++---
1 file changed, 19 insertions(+), 55 deletions(-)
diff --git a/drivers
Since commit ca5d1b3524b4d
regulator: helpers: Modify helpers enabling multi-bit control,
we can set enable_val setting for device that use multiple bits for control
when using regmap enable/disable/bypass ops.
Signed-off-by: Axel Lin axel@ingics.com
---
Note:
This patch depends on below
2014-03-07 23:25 GMT+08:00 Balaji T K balaj...@ti.com:
On Thursday 06 March 2014 06:40 PM, Axel Lin wrote:
This patch converts this driver to use the regmap helper functions
provided by
regulator core.
This fixes a few issues in current implementation:
1) In original code, the set voltage
with info-enable rather than
info-enable_mask.
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Balaji T K balaj...@ti.com
---
v2: Update commit log and add Balaji's Ack.
drivers/regulator/pbias-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
801 - 900 of 2364 matches
Mail list logo
