RE: Dell XPS13 does not suspend with Linux 4.10-rc3

2017-01-11 Thread Winkler, Tomas
> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3 > > On 01/11/17 10:36, Greg Kroah-Hartman wrote: > > On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote: > > >> On 01/10/17 23:24, Jan Niehusmann wrote: > >>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

2017-01-11 Thread Winkler, Tomas
> > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > On older platforms the command should be just ignored by the firmware > > but some older platforms misbehave so it's safer to send the command > > only if required. > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad x

RE: [char-misc for 4.10-rc4] mei: bus: enable OS version only for SPT and newer

2017-01-10 Thread Winkler, Tomas
> > On Mon, Jan 09, 2017 at 06:15:29PM +0200, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > Sending OS version for support of TPM2_ChangeEPS() is required only > > for SPT FW (HMB version 2.0) and newer. > > On older platforms the command should be just ignored by the firmware > > but

RE: ILK regression: hangs on reboot to Watchdog line, bisected

2017-01-09 Thread Winkler, Tomas
> -Original Message- > From: Sarvela, Tomi P > Sent: Monday, January 09, 2017 20:11 > To: Winkler, Tomas ; linux-kernel@vger.kernel.org > Cc: intel-gfx...@eclists.intel.com > Subject: ILK regression: hangs on reboot to Watchdog line, bisected > > Hello t

RE: [PATCH v4 1/8] PCI: Recognize Thunderbolt devices

2017-01-08 Thread Winkler, Tomas
> > We're about to allow runtime PM on Thunderbolt ports in > pci_bridge_d3_possible() and unblock runtime PM for Thunderbolt host > hotplug ports in pci_dev_check_d3cold(). In both cases we need to uniquely > identify if a PCI device belongs to a Thunderbolt controller. > > We also have the nee

RE: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers

2016-12-12 Thread Winkler, Tomas
> > On Mon, Dec 12, 2016 at 02:25:32PM +, Winkler, Tomas wrote: > > > > > > > > In order to provide access to locality registers, this commits > > > > adds mapping of the head of the CRB registers, which are located right > before the contro

RE: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers

2016-12-12 Thread Winkler, Tomas
> > I've tested is completley disjoint from the region pointed by the ACPI device > tree (SSDT in PTT's case). > > Here's example device from my x250: > > Device (TPM) > { > Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID: Hardware ID > Name (_STR, Unicode ("TPM 2.0 Device")) //

RE: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers

2016-12-12 Thread Winkler, Tomas
> > In order to provide access to locality registers, this commits adds mapping of > the head of the CRB registers, which are located right before the control > area. > > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm_crb.c | 89 + > - >

RE: [tpmdd-devel] [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

2016-12-06 Thread Winkler, Tomas
> -Original Message- > From: Nayna [mailto:na...@linux.vnet.ibm.com] > Sent: Tuesday, December 06, 2016 11:17 > To: Jarkko Sakkinen ; Winkler, Tomas > > Cc: tpmdd-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [tpmdd-devel] [PATCH v2 1

RE: [char-misc-next RESEND] mei: bus: enable non-blocking RX

2016-12-06 Thread Winkler, Tomas
> > On Sat, Dec 03, 2016 at 12:15:25AM +0200, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > Enable non-blocking receive for drivers on mei bus, this allows > > checking for data availability by mei client drivers. This is most > > effective for fixed address clients, that lacks flow co

RE: [tpmdd-devel] [PATCH v2 3/3] tpm_crb: request and relinquish locality 0

2016-12-05 Thread Winkler, Tomas
> > CC linux-security-module > > On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > > Request and relinquish locality for the driver use in order to be a > > better citizen in a multi locality environment like TXT. The locality > > is requested and relinquished as part of going in

RE: [tpmdd-devel] [PATCH v2 2/3] tpm_crb: encapsulate crb_wait_for_reg_32

2016-12-05 Thread Winkler, Tomas
> CC linux-security-module > > On Sat, Dec 03, 2016 at 07:52:12PM +0200, Jarkko Sakkinen wrote: > > Encapsulated crb_wait_for_reg32() so that state changes in other CRB > > registers than TPM_CRB_CTRL_REQ_x can be waited. > > > > Signed-off-by: Jarkko Sakkinen > > --- > > drivers/char/tpm/tpm_cr

RE: [tpmdd-devel] [PATCH v2 1/3] tpm_crb: map locality registers

2016-12-05 Thread Winkler, Tomas
> > On Mon, Dec 05, 2016 at 12:07:51PM +, Winkler, Tomas wrote: > > > > --- > > > > drivers/char/tpm/tpm_crb.c | 96 > > > > ++ > > > > 1 file changed, 64 insertions(+), 32 deletions(-) &

RE: [tpmdd-devel] [PATCH v2 1/3] tpm_crb: map locality registers

2016-12-05 Thread Winkler, Tomas
> > --- > > drivers/char/tpm/tpm_crb.c | 96 > > ++ > > 1 file changed, 64 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > > index 717b6b4..8d81b66 100644 > > --- a/drivers/char/tpm/tpm_crb.c

RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX

2016-11-30 Thread Winkler, Tomas
> On Tue, Nov 29, 2016 at 08:09:38PM +0000, Winkler, Tomas wrote: > > > > > On Mon, Nov 28, 2016 at 11:03:20PM +0000, Winkler, Tomas wrote: > > > > > > > > > > > > > > > > > > > > > > On Sat, Nov 19,

RE: [char-msic 1/3] mei: me: disable driver on SPT SPS firmware

2016-11-30 Thread Winkler, Tomas
> > On Tue, Nov 29, 2016 at 09:41:41PM +, Winkler, Tomas wrote: > > > > > > > > > > On Tue, Nov 29, 2016 at 07:21:43PM +, Winkler, Tomas wrote: > > > > > > > > > > On Tue, Nov 29, 2016 at 02:44:44PM +0200, Tomas Winkler

RE: [char-msic 2/3] mei: me: fix place for kaby point device ids.

2016-11-29 Thread Winkler, Tomas
> > On Tue, Nov 29, 2016 at 08:24:08PM +, Winkler, Tomas wrote: > > > > > > > > On Tue, Nov 29, 2016 at 02:44:45PM +0200, Tomas Winkler wrote: > > > > > This is fix of the backported patch only, it places KBL DIDs on > > > &g

RE: [char-msic 1/3] mei: me: disable driver on SPT SPS firmware

2016-11-29 Thread Winkler, Tomas
> > On Tue, Nov 29, 2016 at 07:21:43PM +, Winkler, Tomas wrote: > > > > > > On Tue, Nov 29, 2016 at 02:44:44PM +0200, Tomas Winkler wrote: > > > > commit 8c57cac1457f3125a5d13dc03635c0708c61bff0 upstream > > > > > > > > Su

RE: [char-msic 2/3] mei: me: fix place for kaby point device ids.

2016-11-29 Thread Winkler, Tomas
> > On Tue, Nov 29, 2016 at 02:44:45PM +0200, Tomas Winkler wrote: > > > This is fix of the backported patch only, it places KBL DIDs on > > > correct place to easy on backporting of further DIDs. > > > > > > Fixes: 5c99f32c461c ('mei: me: add kaby point device ids') > > > Cc: #4.4 > > > Signed-

RE: [char-msic 3/3] mei: fix return value on disconnection

2016-11-29 Thread Winkler, Tomas
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, November 29, 2016 21:15 > To: Winkler, Tomas > Cc: sta...@vger.kernel.org; linux-kernel@vger.kernel.org; Usyskin, Alexander > > Subject: Re: [char-msic 3/3] mei

RE: [char-msic 3/3] mei: fix return value on disconnection

2016-11-29 Thread Winkler, Tomas
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, November 29, 2016 21:15 > To: Winkler, Tomas > Cc: sta...@vger.kernel.org; linux-kernel@vger.kernel.org; Usyskin, Alexander > > Subject: Re: [char-msic 3/3] mei

RE: [char-msic 2/3] mei: me: fix place for kaby point device ids.

2016-11-29 Thread Winkler, Tomas
> > On Tue, Nov 29, 2016 at 02:44:45PM +0200, Tomas Winkler wrote: > > This is fix of the backported patch only, it places KBL DIDs on > > correct place to easy on backporting of further DIDs. > > > > Fixes: 5c99f32c461c ('mei: me: add kaby point device ids') > > Cc: #4.4 > > Signed-off-by: Toma

RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX

2016-11-29 Thread Winkler, Tomas
> On Mon, Nov 28, 2016 at 11:03:20PM +0000, Winkler, Tomas wrote: > > > > > > > > > > > > > > On Sat, Nov 19, 2016 at 02:16:11PM +0200, Tomas Winkler wrote: > > > > > From: Alexander Usyskin > > > > > > > > &g

RE: [char-msic 1/3] mei: me: disable driver on SPT SPS firmware

2016-11-29 Thread Winkler, Tomas
> > On Tue, Nov 29, 2016 at 02:44:44PM +0200, Tomas Winkler wrote: > > commit 8c57cac1457f3125a5d13dc03635c0708c61bff0 upstream > > > > Sunrise Point PCH with SPS Firmware doesn't expose working MEI > > interface, we need to quirk it out. > > The SPS Firmware is identifiable only on the first PCI

RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX

2016-11-28 Thread Winkler, Tomas
> > > > > > On Sat, Nov 19, 2016 at 02:16:11PM +0200, Tomas Winkler wrote: > > > From: Alexander Usyskin > > > > > > Enable non-blocking receive for drivers on mei bus, this allows > > > checking for data availability by mei client drivers. This is most > > > effective for fixed address clients,

RE: [char-misc-next] mei: request async autosuspend at the end of enumeration

2016-11-26 Thread Winkler, Tomas
> > W dniu 25.11.2016 o 04:14, Jeff King pisze: > > On Thu, Nov 24, 2016 at 10:37:14PM +0000, Winkler, Tomas wrote: > > > >>>>> Cc: # 4.4+ > >>>> > >>>> Looks like git send-email is not able to parse this address &

RE: [char-misc-next] mei: request async autosuspend at the end of enumeration

2016-11-24 Thread Winkler, Tomas
> > On Thu, Nov 24, 2016 at 04:10:49PM +, Winkler, Tomas wrote: > > > > Cc: # 4.4+ > > > > Looks like git send-email is not able to parse this address correctly > > though this is suggested format by Documentation/stable_kernel_rules.txt. > > C

RE: [char-misc-next] mei: request async autosuspend at the end of enumeration

2016-11-24 Thread Winkler, Tomas
> > From: Alexander Usyskin > > pm_runtime_autosuspend can take synchronous or asynchronous paths, > Because we are calling pm_runtime_mark_last_busy just before this most of > the cases it takes the asynchronous way. However, when the FW or driver > resets during already running runtime suspend

RE: [PATCH] tpm: use get_unaligned_be32 unaligned buffer access.

2016-11-23 Thread Winkler, Tomas
> On Wed, Nov 23, 2016 at 01:04:54PM +0200, Tomas Winkler wrote: > > Use get_unaligned_be32 as b32_to_cpu doesn't work correctly on all > > platforms for unaligned access. > > > > The fix doesn't cover all the cases as also some cast structures have > > members on unaligned addresses. > > I think

RE: [PATCH 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

2016-11-22 Thread Winkler, Tomas
> > On Wed, Nov 16, 2016 at 07:03:38PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced from other > > functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler > > Do you know how to make "make htmldocs" to generate documentation for

RE: [char-misc-next 4/4 V2] mei: bus: enable non-blocking RX

2016-11-19 Thread Winkler, Tomas
> > On Sat, Nov 19, 2016 at 02:16:11PM +0200, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > Enable non-blocking receive for drivers on mei bus, this allows > > checking for data availability by mei client drivers. This is most > > effective for fixed address clients, that lacks flow c

RE: [char-misc-next 4/4] mei: bus: enable non-blocking RX

2016-11-19 Thread Winkler, Tomas
> > On Fri, Nov 18, 2016 at 07:30:25PM +, Winkler, Tomas wrote: > > > > > > > > On Thu, Nov 17, 2016 at 04:22:24PM +, Winkler, Tomas wrote: > > > > > Just make a new function mei_cldev_recv_async() and then call a > > > > > loca

RE: [char-misc-next 4/4] mei: bus: enable non-blocking RX

2016-11-18 Thread Winkler, Tomas
> > On Thu, Nov 17, 2016 at 04:22:24PM +, Winkler, Tomas wrote: > > > Just make a new function mei_cldev_recv_async() and then call a > > > local, static function, that does the work with the correct flag > > > set. That way the developer always knows exa

RE: [char-misc-next 4/4] mei: bus: enable non-blocking RX

2016-11-17 Thread Winkler, Tomas
> > On Wed, Nov 16, 2016 at 10:51:30PM +0200, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > Enable non-blocking receive for drivers on mei bus, this allows > > checking for data availability by mei client drivers. This is most > > effective for fixed address clients, that lacks flow c

RE: [PATCH 2/2] tpm/tpm2-chip: fix kdoc errors

2016-11-14 Thread Winkler, Tomas
.org > Subject: Re: [PATCH 2/2] tpm/tpm2-chip: fix kdoc errors > > On Tue, Nov 01, 2016 at 03:05:14AM +0200, Tomas Winkler wrote: > > Use correct kdoc format, describe correct parameters and return values. > > > > Signed-off-by: Tomas Winkler > > --- > > drivers/char/tpm/tpm2-cmd.c | 107 > > +++

RE: [char-misc-next 2/2] mei: send OS type to the FW

2016-11-10 Thread Winkler, Tomas
> > On Thu, Nov 10, 2016 at 12:19:06PM +, Winkler, Tomas wrote: > > > > > > On Thu, Nov 10, 2016 at 12:00:29PM +, Winkler, Tomas wrote: > > > > > > > > > > > > > -Original Message- > > > > > From: G

RE: [char-misc-next 2/2] mei: send OS type to the FW

2016-11-10 Thread Winkler, Tomas
> > On Thu, Nov 10, 2016 at 12:00:29PM +, Winkler, Tomas wrote: > > > > > > > -Original Message- > > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > > Sent: Thursday, November 10, 2016 09:23 > > > To: Winkler,

RE: [char-misc-next 2/2] mei: send OS type to the FW

2016-11-10 Thread Winkler, Tomas
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 09:25 > To: Winkler, Tomas > Cc: Usyskin, Alexander ; linux- > ker...@vger.kernel.org; Jarkko Sakkinen > Subject: Re: [char-misc-next 2/2] mei: s

RE: [char-misc-next 2/2] mei: send OS type to the FW

2016-11-10 Thread Winkler, Tomas
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 09:23 > To: Winkler, Tomas > Cc: Usyskin, Alexander ; linux- > ker...@vger.kernel.org; Jarkko Sakkinen > Subject: Re: [char-misc-next 2/2] mei: s

RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem

2016-11-07 Thread Winkler, Tomas
> > On Mon, Nov 07, 2016 at 09:53:12PM +0200, Tomas Winkler wrote: > > Register UFS RPMB LUN with the RPMB subsystem and provide > > implementation for the RPMB access operations. RPMB partition is > > accessed via a sequence of security protocol in and security protocol > > out commands with UFS

RE: [tpmdd-devel] tpm_tis regression in 4.9?

2016-11-01 Thread Winkler, Tomas
> > On Mon, Oct 31, 2016 at 08:16:59PM +, Winkler, Tomas wrote: > > > > > > On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote: > > > > > > > > I think this patch from Jarkko's next is the fix: > > > > >

RE: [tpmdd-devel] tpm_tis regression in 4.9?

2016-10-31 Thread Winkler, Tomas
> > On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote: > > > > I think this patch from Jarkko's next is the fix: > > > > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7dd > > > cdd8990e4783d09c7e86d90ccb4121 > > > > > > Jarkko? Can you hurry that along to go i

RE: [tpmdd-devel] [PATCH] tpm, tpm_crb: remove redundant CRB_FL_CRB_START flag

2016-10-19 Thread Winkler, Tomas
> > On Mon, Oct 17, 2016 at 11:42:24PM +0300, Jarkko Sakkinen wrote: > > Because all the existing hardware have HID MSFT0101 we end up always > > setting CRB_FL_CRB_START flag as a workaround for 4th Gen Core CPUs. > > Even if ACPI start is used, the driver will always issue also CRB start. Do

RE: [tpmdd-devel] [PATCH 2/3] tpm_crb: encapsulate crb_wait_for_reg_32

2016-10-11 Thread Winkler, Tomas
> Encapsulated crb_wait_for_reg32() so that state changes in other CRB registers > than TPM_CRB_CTRL_REQ_x can be waited. > > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm_crb.c | 40 +++- > 1 file changed, 23 insertions(+), 17 deletions(-) > >

RE: [tpmdd-devel] [PATCH RFC 1/3] tpm_crb: expand struct crb_control_area to struct crb_regs

2016-10-09 Thread Winkler, Tomas
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Monday, October 10, 2016 02:08 > To: Jarkko Sakkinen > Cc: moderated list:TPM DEVICE DRIVER ; > open list > Subject: Re: [tpmdd-devel] [PATCH RFC 1/3] tpm_crb: expand struct > crb_control_area

RE: [tpmdd-devel] [PATCH RFC 3/3] tpm_crb: request and relinquish locality 0

2016-10-09 Thread Winkler, Tomas
> > > > > > > > Request and relinquish locality for the driver use in order to be a better > citizen > > > in a multi locality environment like with TXT as it uses locality 2. > > > > > > > > Signed-off-by: Jarkko Sakkinen > > > --- > > > drivers/char/tpm/tpm_crb.c | 36 > > > +++

RE: [tpmdd-devel] [PATCH RFC 3/3] tpm_crb: request and relinquish locality 0

2016-10-08 Thread Winkler, Tomas
> > Request and relinquish locality for the driver use in order to be a better > citizen > in a multi locality environment like with TXT as it uses locality 2. > > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm_crb.c | 36 > 1 file changed

RE: [tpmdd-devel] [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> > > Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle > > state > > > > On Sat, Oct 08, 2016 at 04:56:39PM +, Winkler, Tomas wrote: > > > > > > > > > > > On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tom

RE: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb

2016-10-08 Thread Winkler, Tomas
> -Original Message- > From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] > Sent: Saturday, October 08, 2016 19:01 > To: Winkler, Tomas > Cc: tpmdd-de...@lists.sourceforge.net; Jason Gunthorpe > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 4/4] t

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state > > On Sat, Oct 08, 2016 at 04:56:39PM +, Winkler, Tomas wrote: > > > > > > > > On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tomas wrote: > > > > > > >

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > > > Rather you it would be better not to use cmdReady/goIdle at all if > > kernel is not compiled with CONFIG_PM. > > It would be best practice to ensure the tpm is powered up no matter how the > kernel is compiled.. The firmwa

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> > On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tomas wrote: > > > > > > On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > > > > From: "Winkler, Tomas" > > > > > > > > There is a HW bug in Skylake,

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> > On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > > From: "Winkler, Tomas" > > > > There is a HW bug in Skylake, Kabylake, and Broxton PCH Intel PTT > > device, where most of the registers in the control area except START, > > REQ

RE: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb

2016-10-08 Thread Winkler, Tomas
> > On Sat, Oct 08, 2016 at 02:59:39PM +0300, Tomas Winkler wrote: > > From: "Winkler, Tomas" > > > > Utilize runtime_pm for driving tpm crb idle states. > > The framework calls cmd_ready from the pm_runtime_resume handler and > > go idle fr

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-07 Thread Winkler, Tomas
> Subject: Re: [PATCH] tpm: don't destroy chip device prematurely > > On Fri, Oct 07, 2016 at 02:24:59PM +0000, Winkler, Tomas wrote: > > > So here I'm to say I'm sorry for misleading this, after all the doubts > > I got back to debugging and tra

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-07 Thread Winkler, Tomas
> On Thu, Oct 06, 2016 at 12:43:13AM +0000, Winkler, Tomas wrote: > > > > You keep asserting that, but it just isn't true at all. > > > > Okay, let's rephrase, that calling device_del before tpm_transmit is not > > sane > when using runtime_pm.

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-05 Thread Winkler, Tomas
> On Wed, Oct 05, 2016 at 08:09:17PM +0000, Winkler, Tomas wrote: > > > It could, but that patch was not merged yet, and I believe even if the > > issue is exposed only with runtime_pm currently, we have a bug in > > design even w/o runtime pm. > > Please

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-05 Thread Winkler, Tomas
> > On Wed, Oct 05, 2016 at 07:48:59AM +, Winkler, Tomas wrote: > > > > down_write(&chip->ops_sem); > > > > chip->ops = NULL; > > > > up_write(&chip->ops_sem); > > > > > > No, that is wrong as well, another t

RE: [PATCH] tpm/tpm_crb: revamp starting method setting.

2016-10-05 Thread Winkler, Tomas
> On Wed, Oct 05, 2016 at 04:12:08PM +0300, Tomas Winkler wrote: > > Encapsulate the start method parsing in a single function and add > > needed debug printouts. > > It eliminates small issue with useless double checking for > > ACPI_TPM2_MEMORY_MAPPED. > > Start method is trival to check from TP

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-05 Thread Winkler, Tomas
> > > > > On Tue, Oct 04, 2016 at 08:19:46AM +0300, Jarkko Sakkinen wrote: > > > > > > > > Make the driver uncallable first. The worst race that can happen > > > > > is that open("/dev/tpm0", ...) returns -EPIPE. I do not consider > > > > > this fatal at all. > > > > > > > > No responses for this r

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-04 Thread Winkler, Tomas
> On Tue, Oct 04, 2016 at 08:19:46AM +0300, Jarkko Sakkinen wrote: > > > > Make the driver uncallable first. The worst race that can happen is > > > that open("/dev/tpm0", ...) returns -EPIPE. I do not consider this > > > fatal at all. > > > > No responses for this reasonable proposal so I'll sho

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-03 Thread Winkler, Tomas
> > On Mon, Oct 03, 2016 at 03:42:25PM +0300, Jarkko Sakkinen wrote: > > > > I've looked to the registration code and it indeed has few more > > > issues > > ? > > > > Maybe TPM_CHIP_FLAG_REGISTERED can be used for sealing the access to > > > the device during deregistration, current usage is v

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-03 Thread Winkler, Tomas
> On Mon, Oct 03, 2016 at 07:05:48AM +0000, Winkler, Tomas wrote: > > > > This patch is wrong, I though the comments were clear. All entry > > > points to find the device must be deleted before we commit to shutting > down the device. > > > > > > Y

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-03 Thread Winkler, Tomas
> > > On Sun, Oct 02, 2016 at 01:24:55PM +0300, Jarkko Sakkinen wrote: > > > On Sun, Oct 02, 2016 at 01:17:55PM +0300, Jarkko Sakkinen wrote: > > > > On Sun, Oct 02, 2016 at 10:39:31AM +0300, Tomas Winkler wrote: > > > > > In tpm_del_char_device device_del is called prior to > > > > > tpm2_shutdow

RE: [PATCH] tpm: don't destroy chip device prematurely

2016-10-03 Thread Winkler, Tomas
> On Sun, Oct 02, 2016 at 01:24:55PM +0300, Jarkko Sakkinen wrote: > > On Sun, Oct 02, 2016 at 01:17:55PM +0300, Jarkko Sakkinen wrote: > > > On Sun, Oct 02, 2016 at 10:39:31AM +0300, Tomas Winkler wrote: > > > > In tpm_del_char_device device_del is called prior to tpm2_shutdown > > > > where it i

RE: [PATCH v3 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-09-27 Thread Winkler, Tomas
> > On Thu, Sep 15, 2016 at 09:23:29AM +0300, Jarkko Sakkinen wrote: > > On Mon, Sep 12, 2016 at 04:04:19PM +0300, Tomas Winkler wrote: > > > There is a HW bug in Skylake, and Broxton PCH Intel PTT device, > > > where most of the registers in the control area except START, > > > REQUEST, CANCEL, a

RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-24 Thread Winkler, Tomas
> > > > > > Signed-off-by: Tomas Winkler > > Signed-off-by: Alexander Usyskin > Tested-by: Avri Altman > > - mmc - full functionality. One issue found that was fixed on V6: patch V6 > 2/9. > - ufs - read & read counter only. Testing is still wip. > > > > +static int rpmb_request_verify(s

RE: [PATCH v2 1/4] samples: move misc-devices/mei example code from Documentation

2016-09-21 Thread Winkler, Tomas
> > Move misc-devices/mei examples to samples/mei and remove it from > Documentation Makefile. Delete misc-devices/Makefile. > > Create a new Makefile to build samples/mei. It can be built from top level > directory or from mei directory: > > Run make -C samples/mei or cd samples/mei; make > >

RE: [PATCH v6 0/9] Replay Protected Memory Block (RPMB) subsystem

2016-09-20 Thread Winkler, Tomas
> > On Mon, Sep 19, 2016 at 12:17:48PM +, Winkler, Tomas wrote: > > \ > > > Subject: [PATCH v6 0/9] Replay Protected Memory Block (RPMB) > > > subsystem > > > > > > > > > Few storage technologies such is EMMC, UFS, and NVMe support RPM

RE: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

2016-09-20 Thread Winkler, Tomas
> On Tue, Sep 20, 2016 at 07:08:40AM +0000, Winkler, Tomas wrote: > > > > > -Original Message- > > > From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] > > > Sent: Monday, September 19, 2016 23:22 > > > To: Peter Huewe >

RE: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

2016-09-20 Thread Winkler, Tomas
> -Original Message- > From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] > Sent: Monday, September 19, 2016 23:22 > To: Peter Huewe > Cc: moderated list:TPM DEVICE DRIVER de...@lists.sourceforge.net>; open list > Subject: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expr

RE: [PATCH 5/8] samples: move misc-devices/mei example code from Documentation

2016-09-19 Thread Winkler, Tomas
> -Original Message- > From: Jonathan Corbet [mailto:cor...@lwn.net] > Sent: Monday, September 19, 2016 19:14 > To: Shuah Khan > Cc: Dutt, Sudeep ; Dixit, Ashutosh > ; Winkler, Tomas ; > t...@linutronix.de; w...@iguana.be; li...@roeck-us.net; > elfr.

RE: [PATCH v6 0/9] Replay Protected Memory Block (RPMB) subsystem

2016-09-19 Thread Winkler, Tomas
\ > Subject: [PATCH v6 0/9] Replay Protected Memory Block (RPMB) subsystem > > > Few storage technologies such is EMMC, UFS, and NVMe support RPMB > hardware partition with common protocol and frame layout. > The RPMB partition cannot be accessed via standard block layer, but by a set > of specif

RE: [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle state

2016-09-15 Thread Winkler, Tomas
> On Thu, Sep 15, 2016 at 08:23:03AM +0000, Winkler, Tomas wrote: > > > > > Subject: Re: [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle > > > > > state > > > > > > > > > > On Mon, Sep 12, 2016 at 04:04:18PM +0300, Tomas Winkler w

RE: [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle state

2016-09-15 Thread Winkler, Tomas
> > > Subject: Re: [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle > > > state > > > > > > On Mon, Sep 12, 2016 at 04:04:18PM +0300, Tomas Winkler wrote: > > > > The register TPM_CRB_CTRL_REQ_x contains bits goIdle and cmdReady > > > > for SW to indicate that the device can enter or should exit

RE: [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle state

2016-09-14 Thread Winkler, Tomas
> Subject: Re: [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle state > > On Mon, Sep 12, 2016 at 04:04:18PM +0300, Tomas Winkler wrote: > > The register TPM_CRB_CTRL_REQ_x contains bits goIdle and cmdReady for > > SW to indicate that the device can enter or should exit the idle state. > > > > T

Re: [PATCH v3 0/4] tpm/tpm_crb: implement power management.

2016-09-13 Thread Winkler, Tomas
On Mon, 2016-09-12 at 16:04 +0300, Tomas Winkler wrote: > Te overall platform ability to enter a low power state is also > conditioned on the ability of a tpm device to go to idle state. > This series should provide this feature. > > Unfortunately, there is a HW bug on Intel PTT devices on Skylake

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-09-04 Thread Winkler, Tomas
\ > Subject: Re: [PATCH v5 4/8] char: rpmb: provide a user space interface > > On Sun 2016-09-04 11:35:33, Winkler, Tomas wrote: > > > > > On Thu, Sep 01, 2016 at 08:05:26PM +, Winkler, Tomas wrote: > > > > > > > > > > > > > &

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-09-04 Thread Winkler, Tomas
> On Thu, Sep 01, 2016 at 08:05:26PM +0000, Winkler, Tomas wrote: > > > > > > > > On Sun, Aug 07, 2016 at 09:44:03AM +, Winkler, Tomas wrote: > > > > > > > > > > On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > > &

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-09-01 Thread Winkler, Tomas
> > On Sun, Aug 07, 2016 at 09:44:03AM +, Winkler, Tomas wrote: > > > > > > On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > > > > The user space API is achieved via two synchronous IOCTL. > > > > > > IOCTLs? > > > > Will

RE: [PATCH v5 3/8] char: rpmb: add device attributes

2016-09-01 Thread Winkler, Tomas
> > On Mon, Jul 18, 2016 at 11:27:48PM +0300, Tomas Winkler wrote: > > Add attribute type that displays underlay storage type technology > > EMMC, UFS, and attribute id, that displays underlay storage device id. > > For EMMC this would be content of CID and for UFS serial number from > > the devic

RE: [PATCH v5 5/8] char: rpmb: add RPMB simulation device

2016-09-01 Thread Winkler, Tomas
> > On Mon, Jul 18, 2016 at 11:27:50PM +0300, Tomas Winkler wrote: > > This is a simple platform device used for testing the RPMB subsystem. > > > > The module currently supports two configuration options: > > 1. max_wr_blks: for specifying max blocks that can be written in a > > single command 2.

RE: [char-misc-next 00/12] mei: rx enhancements

2016-08-29 Thread Winkler, Tomas
> > > > > On Sun, Jul 24, 2016 at 10:52:23PM +, Winkler, Tomas wrote: > > > > > > > > This patch series contains mostly fixes and enhancements of the rx > path: > > > > 1. Better handling of fixed address clients 2. Support for > >

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-08-07 Thread Winkler, Tomas
> > On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > > The user space API is achieved via two synchronous IOCTL. > > IOCTLs? Will fix > > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is > performed > > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD > where > >

RE: [char-misc-next 00/12] mei: rx enhancements

2016-07-25 Thread Winkler, Tomas
> > On Sun, Jul 24, 2016 at 10:52:23PM +, Winkler, Tomas wrote: > > > > > > This patch series contains mostly fixes and enhancements of the rx path: > > > 1. Better handling of fixed address clients 2. Support for consecutive > reads 3. > > >

RE: [char-misc-next 00/12] mei: rx enhancements

2016-07-24 Thread Winkler, Tomas
> > This patch series contains mostly fixes and enhancements of the rx path: > 1. Better handling of fixed address clients 2. Support for consecutive reads > 3. > Further amthif client diet > > Hi Greg, looks like the first 4 patches I've resent by mistake from the previous patchset , not sure

RE: [PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-07-23 Thread Winkler, Tomas
> > Few storage technologies such is EMMC, UFS, and NVMe support RPMB > hardware partition with common protocol and frame layout. > The RPMB partition cannot be accessed via standard block layer, but by a set > of specific commands: WRITE, READ, GET_WRITE_COUNTER, and > PROGRAM_KEY. > Such a part

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-07-20 Thread Winkler, Tomas
> > On Mon, Jul 18, 2016 at 4:27 PM, Tomas Winkler > wrote: > > The user space API is achieved via two synchronous IOCTL. > > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is > performed > > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD > where > > the whole RPMB se

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

2016-07-16 Thread Winkler, Tomas
> -Original Message- > From: Levy, Amir (Jer) > Sent: Thursday, July 14, 2016 17:50 > To: Winkler, Tomas ; > andreas.noe...@gmail.com; gre...@linuxfoundation.org; > bhelg...@google.com > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > net...@vger

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

2016-07-14 Thread Winkler, Tomas
> > Firmware-based (a.k.a ICM - Intel Connection Manager) controller is > used for establishing and maintaining the Thunderbolt Networking > connection. We need to be able to communicate with it. > > Signed-off-by: Amir Levy > --- > drivers/thunderbolt/Makefile |1 + > drivers/thunderb

RE: [PATCH v4 7/8] mmc: block: register RPMB partition with the RPMB subsystem

2016-06-27 Thread Winkler, Tomas
> 2; > > This looks like it does not support 8KB writes added in v5.1 spec. Can that > be > supported? You are right there is not support for 8K packet, but the change should be simple. I will update the patch. Thanks Tomas

RE: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-06-14 Thread Winkler, Tomas
>>> wrote: >>> > Few storage technology such is EMMC, UFS, and NVMe support RPMB >>> >hardware partition with common protocol and frame layout. >>> > The RPMB partition cannot be accessed via standard block layer, but >>> >by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and >>> >PROG

RE: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-06-02 Thread Winkler, Tomas
> > On Wed, Jun 1, 2016 at 2:41 PM, Tomas Winkler > wrote: > > Few storage technology such is EMMC, UFS, and NVMe support RPMB > >hardware partition with common protocol and frame layout. > > The RPMB partition cannot be accessed via standard block layer, but > >by a set of specific commands: WRI

RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl

2016-05-24 Thread Winkler, Tomas
> > On Mon, May 23, 2016 at 01:07:53PM +, Winkler, Tomas wrote: > > > > > > From: Alexander Usyskin > > > > > > wr_ctrl waiters are none interruptible, so should be waken up with > > > call to wake_up and not to wake_up_interruptible. >

RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl

2016-05-23 Thread Winkler, Tomas
> > From: Alexander Usyskin > > wr_ctrl waiters are none interruptible, so should be waken up with call to > wake_up and not to wake_up_interruptible. > > This fixes commit: > 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.") > > Signed-off-by: Alexander Usyskin > Signed-off-by: Toma

RE: [PATCH 2/8] char: rpmb: add sysfs-class ABI documentation

2016-04-24 Thread Winkler, Tomas
> > On Sun 2016-04-03 12:42:46, Tomas Winkler wrote: > > Signed-off-by: Tomas Winkler > > --- > > Documentation/ABI/testing/sysfs-class-rpmb | 15 +++ > > MAINTAINERS| 1 + > > 2 files changed, 16 insertions(+) > > create mode 100644 Documentation/AB

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

2016-04-11 Thread Winkler, Tomas
On Tue, 2016-04-05 at 20:16 +0800, kbuild test robot wrote: > Hi Tomas, > > [auto build test ERROR on char-misc/char-misc-testing] > [also build test ERROR on v4.6-rc2 next-20160405] > [if your patch is applied to the wrong git tree, please drop us a > note to help improving the system] > > url: 

RE: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem

2016-04-08 Thread Winkler, Tomas
> > On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: > >> Hi! > >> > >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: > >>> Register UFS RPMB LUN with the RPMB subsystem and provide > &

Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem

2016-04-07 Thread Winkler, Tomas
On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: > Hi! > > On 4/4/2016 12:11 PM, Tomas Winkler wrote: > > Register UFS RPMB LUN with the RPMB subsystem and provide > > implementation for the RPMB access operations. RPMB partition is > > accessed via a sequence of security protocol in and secur

RE: [PATCH v13 0/9] add support for DWC UFS Controller

2016-04-05 Thread Winkler, Tomas
Hi, On 4/5/2016 12:34 AM, Martin K. Petersen wrote: >> "Joao" == Joao Pinto writes: > > Joao, > > Joao> The work consisted of: - Fixed typo in ufshcd-pltfrm.c - Tweak > Joao> ufshcd.c for UFS 2.0 support - Implement ufshcd-dwc which > Joao> contains all DWC HW specific code - Unipro attr

<    1   2   3   4   5   >