Re: Ethernet driver on 2.6.22

2007-09-24 Thread Randy Dunlap
On Tue, 25 Sep 2007 12:37:32 +1000 hce wrote: > On 9/25/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > On Tue, 25 Sep 2007 08:39:07 +1000 hce wrote: > > > > > On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > On Mon, 24 Sep 2007 12:40:07 +1000 hce wrote: > > > > > > > > > Thanks Randy.

Re: What's in linux-2.6-block.git for 2.6.24

2007-09-24 Thread Torsten Kaiser
On 9/24/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > I will keep on using 2.6.23-rc7-mm1 and post again, if the error shows up > again. On the next boot it did show up again, so 2.6.23-rc7-mm1 still has the bug. [ 33.81] md1: bitmap initialized from disk: read 10/10 pages, set 0 bits [

[git pull] Input updates for 2.6.23-rc8

2007-09-24 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. There is only one patch that fixes regression in appletouch

Re: 2.6.23-rc6-mm1

2007-09-24 Thread Greg KH
On Sat, Sep 22, 2007 at 02:51:54PM +0530, Satyam Sharma wrote: > Hi Greg, > > > On Tue, 18 Sep 2007, Greg KH wrote: > > > > On Tue, Sep 18, 2007 at 03:04:48PM +0530, Satyam Sharma wrote: > > > > > > But wait ... isn't that a statically-allocated kobject, which were > > > supposed to be

Re: [patch 6/7] Linux Kernel Markers - Documentation

2007-09-24 Thread Randy Dunlap
Mathieu Desnoyers wrote: * Randy Dunlap ([EMAIL PROTECTED]) wrote: On Mon, 24 Sep 2007 17:08:30 -0400 Mathieu Desnoyers wrote: * Randy Dunlap ([EMAIL PROTECTED]) wrote: On Mon, 24 Sep 2007 11:56:35 -0700 Randy Dunlap wrote: Christoph Hellwig wrote: On Mon, Sep 24, 2007 at 11:49:15AM

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Vegard Nossum
On 9/23/07, Miguel Ojeda <[EMAIL PROTECTED]> wrote: > Nice. I would suggest having some kind of standard way to show the > information on the screen/dmesg. I mean, instead of having plain lines > being written to the log, having something very short like: Thanks for the idea. Is this something

[PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-09-24 Thread Peer Chen
Add the ahci controller legacy mode support to sata_nv. Move the DIDs of legacy mode from ahci.c to sata_nv.c The patch base on kernel 2.6.23-rc8 Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.23-rc8-vanilla/Documentation/dontdiff

Re: [PATCH] leds: add missing header

2007-09-24 Thread Pierre Ossman
On Tue, 25 Sep 2007 00:09:12 +0100 Richard Purdie <[EMAIL PROTECTED]> wrote: > On Sun, 2007-09-23 at 08:14 +0200, Pierre Ossman wrote: > > rwlocks are used in the structures so make sure the right header > > is included. > > > > Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> > > I think

[git patches] net driver fixes

2007-09-24 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/pcmcia/3c589_cs.c |2 +- drivers/net/r8169.c | 14 +- drivers/net/sky2.c| 37

lib-y vs EXPORT_SYMBOL: who wins?

2007-09-24 Thread Rusty Russell
Various files under lib/ are linked into a .a so they only get linked if needed. But many of these functions are also EXPORT_SYMBOL()ed. This doesn't really make sense: if it's exported it really needs to be present. Certain configurations can hit this (lguest uses kasprintf, and can be a

Re: [RFC] New kernel-message logging API

2007-09-24 Thread linux
> I don't know. Compare the following two lines: > > printk(KERN_INFO "Message.\n"); > kprint_info("Message."); > > By dropping the lengthy macro (it's not like it's going to change > while we're running anyway, so why not make it a part of the function > name?) and the final newline, we

Re: [PATCH 1/3] Virtualization config cleanup: Select CONFIG_PARAVIRT when required

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 06:26 +0200, Adrian Bunk wrote: > On Tue, Sep 25, 2007 at 02:20:03PM +1000, Rusty Russell wrote: > > On Tue, 2007-09-25 at 06:05 +0200, Adrian Bunk wrote: > > > depends on !(X86_VISWS || X86_VOYAGER) > > > > Hmm, if A selects B and B depends on C, does A not depend on C? >

Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7

2007-09-24 Thread Andrey Panin
On 267, 09 24, 2007 at 03:09:17PM -0400, Dave Jones wrote: > On Mon, Sep 24, 2007 at 01:51:17AM -0700, Jonathan Campbell wrote: > > > > +#if defined(__i386__) && defined(CONFIG_DMI) > >dmi_check_system(acpi_dmi_table); > > #endif > > > > +#ifdef CONFIG_DMI > >dmi_scan_machine();

Re: [PATCH] Delay creation of khcvd thread

2007-09-24 Thread Stephen Rothwell
Hi Rusty, On Tue, 25 Sep 2007 14:27:41 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > HVC console is also used by iSeries, so add that to HVC_DRIVER help. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> > > diff -r 85d39cbbd21c drivers/char/Kconfig > --- a/drivers/char/KconfigTue

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 12:36 +0900, Tejun Heo wrote: > Rusty Russell wrote: > > As stated you cannot protect arbitrary code this way, as you are trying > > to do. I do not think you've broken any of the current code, but I > > cannot tell. You're certainly going to surprise unsuspecting future >

Re: [PATCH] Delay creation of khcvd thread

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 14:04 +1000, Stephen Rothwell wrote: > On Tue, 25 Sep 2007 13:46:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > hvc_console used to only be for Power aka pSeries: now lguest and Xen > > Also legacy iSeries :-) OK, how's this: --- HVC console is also used by

Re: [PATCH 1/3] Virtualization config cleanup: Select CONFIG_PARAVIRT when required

2007-09-24 Thread Adrian Bunk
On Tue, Sep 25, 2007 at 02:20:03PM +1000, Rusty Russell wrote: > On Tue, 2007-09-25 at 06:05 +0200, Adrian Bunk wrote: > > depends on !(X86_VISWS || X86_VOYAGER) > > Hmm, if A selects B and B depends on C, does A not depend on C? No. > If not, I'll patch this... > > Thanks, > Rusty. cu Adrian

Re: [PATCH 1/3] Virtualization config cleanup: Select CONFIG_PARAVIRT when required

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 06:05 +0200, Adrian Bunk wrote: > depends on !(X86_VISWS || X86_VOYAGER) Hmm, if A selects B and B depends on C, does A not depend on C? If not, I'll patch this... Thanks, Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH 3/3] Virtualization config cleanup: The real patch 1/3

2007-09-24 Thread Rusty Russell
OK, I screwed up and sent the old 1/3. This was supposed to be 1/3, and there is no 3. I'm stupid. Be nice to get acks from Jeremy and Zach as it's their original penmanship. Cheers, Rusty. --- Normalize config options for guest support 1) Group all the "guest OS" support options together,

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-24 Thread Kyle Moffett
On Sep 24, 2007, at 13:32:23, Lennart Sorensen wrote: On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote: But I compile net/* into bzImage. I like netbooting :) Isn't it possible to netboot with an initramfs image? I am pretty sure I have seen some systems do exactly that.

Re: [PATCH] Remove broken netfilter binary sysctls from bridging code

2007-09-24 Thread Patrick McHardy
Stephen Hemminger wrote: > On Mon, 24 Sep 2007 18:55:38 +0200 > Patrick McHardy <[EMAIL PROTECTED]> wrote: > >>Eric W. Biederman wrote: >> >>>A really good fix would be to remove the binary side and then to >>>modify brnf_sysctl_call_tables to allocate a temporary ctl_table and >>>integer on the

Re: [37/50] Fix inet_diag OOPS.

2007-09-24 Thread Patrick McHardy
Dan Merillat wrote: > On 9/24/07, Greg KH <[EMAIL PROTECTED]> wrote: > >>netlink_run_queue() doesn't handle multiple processes processing the >>queue concurrently. Serialize queue processing in inet_diag to fix >>a oops in netlink_rcv_skb caused by netlink_run_queue passing a >>NULL for the skb.

Re: [patch 6/7] Linux Kernel Markers - Documentation

2007-09-24 Thread Mathieu Desnoyers
* Randy Dunlap ([EMAIL PROTECTED]) wrote: > On Mon, 24 Sep 2007 17:08:30 -0400 Mathieu Desnoyers wrote: > > > * Randy Dunlap ([EMAIL PROTECTED]) wrote: > > > On Mon, 24 Sep 2007 11:56:35 -0700 Randy Dunlap wrote: > > > > > > > Christoph Hellwig wrote: > > > > > On Mon, Sep 24, 2007 at 11:49:15AM

Re: [PATCH 1/3] Virtualization config cleanup: Select CONFIG_PARAVIRT when required

2007-09-24 Thread Adrian Bunk
On Tue, Sep 25, 2007 at 01:58:08PM +1000, Rusty Russell wrote: > (Unless there are complaints, I'll push this as part of the lguest > patches for 2.6.24, since there are lguest config changes there too). > > Andi points out that PARAVIRT is an option best selected when needed. > > We introduce

Re: [PATCH] Delay creation of khcvd thread

2007-09-24 Thread Stephen Rothwell
On Tue, 25 Sep 2007 13:46:24 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > hvc_console used to only be for Power aka pSeries: now lguest and Xen Also legacy iSeries :-) -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpA4NL0uuHIp.pgp

[PATCH 2/3] Virtualization config cleanup: move lgeust under virtualization menu

2007-09-24 Thread Rusty Russell
Move lguest under the virtualization menu. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/Kconfig |2 -- drivers/kvm/Kconfig |6 +- 2 files changed, 5 insertions(+), 3 deletions(-) === ---

Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS

2007-09-24 Thread Benjamin Herrenschmidt
On Mon, 2007-09-24 at 17:59 -0700, Roland McGrath wrote: > > Yup, I think I ditched most of them.. for some reason I decided it > > couldn't happen, but maybe I'm wrong ? > > Well, it's a BUG_ON. It's supposed to be for something that "can't happen". > That's why it's a sanity check, not a wild

[PATCH 1/3] Virtualization config cleanup: Select CONFIG_PARAVIRT when required

2007-09-24 Thread Rusty Russell
(Unless there are complaints, I'll push this as part of the lguest patches for 2.6.24, since there are lguest config changes there too). Andi points out that PARAVIRT is an option best selected when needed. We introduce PARAVIRT_GUEST for the menu itself, and select PARAVIRT if the user turns on

[PATCH] Delay creation of khcvd thread

2007-09-24 Thread Rusty Russell
This changes hvc_init() to be called only when someone actually uses the hvc_console driver. Dave Jones complained when profiling bootup. hvc_console used to only be for Power aka pSeries: now lguest and Xen both want it built-in in case the kernel is a guest under one of those, even though

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Tejun Heo
Rusty Russell wrote: > As stated you cannot protect arbitrary code this way, as you are trying > to do. I do not think you've broken any of the current code, but I > cannot tell. You're certainly going to surprise unsuspecting future > authors. Can you elaborate a bit? Why can't it protect the

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 11:39 +0900, Tejun Heo wrote: > Rusty Russell wrote: > >>> I really wonder if an explicit "kill_this_attribute()" is a better way > >>> to go than this... > >> I think this sort of temporary unload blocking would be useful for other > >> cases like this. > > > > I hope not:

Re: Re: [PATCH] ahci: Add MCP79 support to AHCI driver

2007-09-24 Thread Peer Chen
Yes,they all belong to AHCI controllers, 4 of them use ahci class code and others use RAID class code. -- Peer Chen 2007-09-25 - ·¢¼þÈË£ºSergei Shtylyov ·¢ËÍÈÕÆÚ£º2007-09-24 20:53:44

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Tejun Heo
Rusty Russell wrote: >>> I really wonder if an explicit "kill_this_attribute()" is a better way >>> to go than this... >> I think this sort of temporary unload blocking would be useful for other >> cases like this. > > I hope not: this doesn't work in general. Calling into a module after >

Re: Ethernet driver on 2.6.22

2007-09-24 Thread hce
On 9/25/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Tue, 25 Sep 2007 08:39:07 +1000 hce wrote: > > > On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > On Mon, 24 Sep 2007 12:40:07 +1000 hce wrote: > > > > > > > Thanks Randy. > > > > > > > > On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]>

Re: kswapd high CPU usage with no swap

2007-09-24 Thread Rik van Riel
On Tue, 25 Sep 2007 02:13:42 +0200 Jan Kundrát <[EMAIL PROTECTED]> wrote: > Hi folks, > I use a 2.6.22-gentoo-r2 SMP kernel with fglrx 8.40.4 [1], > tp_smapi-0.32 and ipw3945-1.2.0 on a Thinkpad T60 with dual core > Intel Core CPU. My root filesystem is XFS stored on an internal SATA > disk, and

Re: lockdep wierdness...

2007-09-24 Thread Steven Rostedt
On Mon, Sep 24, 2007 at 06:07:38PM -0400, Trond Myklebust wrote: > I'm seeing lockdep warning about a potential lock inversion between > >mmap_sem and >i_mutex in NFS (see attachment). > > Unfortunately the basis for the warning appears to be the behaviour in > ext3(???). AFAICS there is no way

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 10:40 +0900, Tejun Heo wrote: > Rusty Russell wrote: > > My concern is that you're dropping the module mutex around ->exit now. > > I don't *think* this should matter, but it's worth considering. > > We always did that. Before the patch the code segment looked like the >

Re: [PATCH 4/5] Add fair-user scheduler

2007-09-24 Thread Srivatsa Vaddagiri
On Tue, Sep 25, 2007 at 01:39:39AM +0200, roel wrote: > > +static int > > +root_user_share_read_proc(char *page, char **start, off_t off, int count, > > +int *eof, void *data) > > +{ > > + int len; > > + > > + len = sprintf(page, "%d\n", init_task_grp_load); > > + >

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Rob Landley
On Monday 24 September 2007 7:10:32 pm Joe Perches wrote: > On Mon, 2007-09-24 at 18:51 -0500, Rob Landley wrote: > > > An added pass between gcc preprocessor and compiler could compact > > > or compress the format string without modifying the conversion > > > specifications so __attribute__

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Tejun Heo
Rusty Russell wrote: > On Tue, 2007-09-25 at 08:18 +0900, Tejun Heo wrote: >>> Given your description of this tool as a "sledgehammer," might it not be >>> easier to just take and hold module_mutex for the duration of the unload >>> block? >> That would be easier but... >> >> * It would serialize

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-24 Thread Jeff Garzik
Berck E. Nash wrote: Greetings, I get a few million of these on boot-- the system never actually boots. Works fine in 2.6.23-rc7. [ 50.456012] ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0 [ 50.462484] ata2.00: irq_stat 0x4001 [ 50.466441] ata2.00: cmd

Re: [patch 6/7] Linux Kernel Markers - Documentation

2007-09-24 Thread Steven Rostedt
On Mon, Sep 24, 2007 at 06:50:44PM +0100, Christoph Hellwig wrote: > On Mon, Sep 24, 2007 at 12:49:56PM -0400, Mathieu Desnoyers wrote: > > Here is some documentation explaining what is/how to use the Linux > > Kernel Markers. > > As mentioned in the tracing infrastructure thread I don't think >

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Rob Landley
On Monday 24 September 2007 3:37:55 pm Vegard Nossum wrote: > On 9/24/07, Joe Perches <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-09-24 at 18:43 +0200, Vegard Nossum wrote: > > > Storing the format-string separately allows us to hash THAT instead of > > > the formatted (ie. console output)

Re: [PATCH] 2.6.22.6 user-mode linux: use address instead of value as argument in os_free_irq_by_cb

2007-09-24 Thread lepton
I added dump_stack and some printk in host kernel. The following is what I got when sys_reboot in host kernel is called, the first line is printing the process state and ptrace state and pid of the calling process. the following is the call path. Sep 22 14:25:49 pc kernel: linux

Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS

2007-09-24 Thread Roland McGrath
> Yup, I think I ditched most of them.. for some reason I decided it > couldn't happen, but maybe I'm wrong ? Well, it's a BUG_ON. It's supposed to be for something that "can't happen". That's why it's a sanity check, not a wild assertion. ;-) The 2/2 patch is an example of a bug that

Missing PCIe interface in lspci

2007-09-24 Thread Larry Finger
In the process of advising a user on getting a BCM4311 wireless device to work with bcm43xx rather than ndiswrapper, the device stopped appearing in an lspci output. The 'lspci -vn' output for this device before this failure was: 03:00.0 0280: 14e4:4311 (rev 01) Subsystem: 103c:1363

Linux 2.6.23-rc8

2007-09-24 Thread Linus Torvalds
Ok, I think I'm getting close to releasing a real 2.6.23. Things seem to have calmed down, and I think Thomas Gleixner may have found the suspend/resume regression that has dogged us for a while, so I'm feeling happy about things. Of course, me feeling happy is usually immediately followed by

Re: Xen kernel 2.6.23-rc7 bug at xen_mc_flush (arch/i386/xen/multicalls.c:68)

2007-09-24 Thread Jeremy Fitzhardinge
[EMAIL PROTECTED] wrote: > Using kernel 2.6.23-rc7 as xen domU client system I observe a kernel bug > which occurs reproducibly when calling a shell from midnight commander F2 > context menu or with testcase given below (However most other programs seem > to > be well behaved and do not trigger

Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS

2007-09-24 Thread Benjamin Herrenschmidt
On Mon, 2007-09-24 at 16:50 -0700, Roland McGrath wrote: > This restores the CHECK_FULL_REGS sanity check to every place that can > access the nonvolatile GPRs for ptrace. This is already done for > native-bitwidth PTRACE_PEEKUSR, but was omitted for many other cases > (32-bit ptrace,

Re: [PATCH 2/2] powerpc: FULL_REGS on exec

2007-09-24 Thread Benjamin Herrenschmidt
On Mon, 2007-09-24 at 16:52 -0700, Roland McGrath wrote: > When PTRACE_O_TRACEEXEC is used, a ptrace call to fetch the registers at > the PTRACE_EVENT_EXEC stop (PTRACE_PEEKUSR) will oops in CHECK_FULL_REGS. > With recent versions, "gdb --args /bin/sh -c 'exec /bin/true'" and "run" at > the (gdb)

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread Dave Jones
On Tue, Sep 25, 2007 at 02:20:01AM +0200, roel wrote: > > > > if ((c->x86_vendor != X86_VENDOR_AMD) || (c->x86 != 5) || > > > > ((c->x86_model != 12) && (c->x86_model != 13))) > > > > > > while we're at it, we could change this to > > > > > > if

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
On Mon, 2007-09-24 at 13:04 -0700, Linus Torvalds wrote: > > On Mon, 24 Sep 2007, Badari Pulavarty wrote: > > > > Whats happening on my machine is .. > > > > dbench forks of 4 children and sends them a signal to start the work. > > 3 out of 4 children gets the signal and does the work. One of

kswapd high CPU usage with no swap

2007-09-24 Thread Jan Kundrát
Hi folks, I use a 2.6.22-gentoo-r2 SMP kernel with fglrx 8.40.4 [1], tp_smapi-0.32 and ipw3945-1.2.0 on a Thinkpad T60 with dual core Intel Core CPU. My root filesystem is XFS stored on an internal SATA disk, and I have 1GB of RAM and no swap. After several suspend to RAM/resume cycles, the X

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread roel
Dave Jones wrote: > to add a single line reply> Ok, sorry, I don't know these rules > On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote: > > > > --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > > +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > > @@ -215,7 +215,7 @@ static

Re: [git] CFS-devel, latest code

2007-09-24 Thread Daniel Walker
On Mon, 2007-09-24 at 23:45 +0200, Ingo Molnar wrote: > Lots of scheduler updates in the past few days, done by many people. > Most importantly, the SMP latency problems reported and debugged by > Mike > Galbraith should be fixed for good now. Does this have anything to do with idle balancing

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Joe Perches
On Mon, 2007-09-24 at 18:51 -0500, Rob Landley wrote: > > An added pass between gcc preprocessor and compiler could compact > > or compress the format string without modifying the conversion > > specifications so __attribute__ ((format (printf)) would still work. > This does not address my

Re: x86_64: potential critical issue with quicklists and page table pages

2007-09-24 Thread Benjamin Herrenschmidt
On Mon, 2007-09-24 at 14:42 -0700, Christoph Lameter wrote: > On Tue, 25 Sep 2007, Benjamin Herrenschmidt wrote: > > > I'd suggest just reverting the patch for now (well, I see from the > > commit list that you did just that) and I'll try to come up with > > something better. > > That would be

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread roel
Davide Libenzi wrote: > On Tue, 25 Sep 2007, roel wrote: > >>> + if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) { >> if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) { > > int foo(int i, int j) { > > return !(i & 8) || !j; > } > > int moo(int i, int

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Jeff Garzik
Kristen Carlson Accardi wrote: On Tue, 25 Sep 2007 01:12:32 +0200 roel <[EMAIL PROTECTED]> wrote: #define ata_id_cdb_intr(id)(((id)[0] & 0x60) == 0x20) +#define ata_id_has_hipm(id)\ + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \ + ((id)[76] & (1 << 9)) )

[PATCH 2/2] powerpc: FULL_REGS on exec

2007-09-24 Thread Roland McGrath
When PTRACE_O_TRACEEXEC is used, a ptrace call to fetch the registers at the PTRACE_EVENT_EXEC stop (PTRACE_PEEKUSR) will oops in CHECK_FULL_REGS. With recent versions, "gdb --args /bin/sh -c 'exec /bin/true'" and "run" at the (gdb) prompt is sufficient to produce this. I also have written an

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Rob Landley
On Monday 24 September 2007 10:19:16 am Joe Perches wrote: > On Mon, 2007-09-24 at 11:22 +0200, Michael Holzheu wrote: > > Together with the idea of not allowing multiple lines in the kprint_xxx > > functions, that would go with our approach having message numbers to > > identify a message. > >

[PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS

2007-09-24 Thread Roland McGrath
This restores the CHECK_FULL_REGS sanity check to every place that can access the nonvolatile GPRs for ptrace. This is already done for native-bitwidth PTRACE_PEEKUSR, but was omitted for many other cases (32-bit ptrace, PTRACE_GETREGS, etc.); I think there may have been more uniform checks

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread Dave Jones
On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote: > > --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > @@ -215,7 +215,7 @@ static struct cpufreq_driver powernow_k6 > > */ > > static int __init powernow_k6_init(void) > > { >

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 01:12:32 +0200 roel <[EMAIL PROTECTED]> wrote: > > #define ata_id_cdb_intr(id)(((id)[0] & 0x60) == 0x20) > > +#define ata_id_has_hipm(id)\ > > + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \ > > + ((id)[76] & (1 << 9)) ) > ^ >

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Rusty Russell
On Tue, 2007-09-25 at 08:18 +0900, Tejun Heo wrote: > > Given your description of this tool as a "sledgehammer," might it not be > > easier to just take and hold module_mutex for the duration of the unload > > block? > > That would be easier but... > > * It would serialize users of the

Re: [PATCH 4/5] Add fair-user scheduler

2007-09-24 Thread roel
Srivatsa Vaddagiri wrote: > Enable user-id based fair group scheduling. This is usefull for anyone > who wants to test the group scheduler w/o having to enable > CONFIG_CGROUPS. > > A separate scheduling group (i.e struct task_grp) is automatically created > for > every new user added to the

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Davide Libenzi
On Tue, 25 Sep 2007, roel wrote: > > + if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) { > > if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) { int foo(int i, int j) { return !(i & 8) || !j; } int moo(int i, int j) { return !((i &

[patch] ata: libata: add per device private data

2007-09-24 Thread Kristen Carlson Accardi
Allow host controllers to store private data per device. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- include/linux/libata.h |3 +++ 1 file changed, 3 insertions(+) Index: libata-dev/include/linux/libata.h

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Tejun Heo
Jonathan Corbet wrote: > Hi, Tejun, > > I was just looking over these changes... > >> +/* Don't proceed till inhibition is lifted. */ >> +add_wait_queue(_unload_wait, ); >> +set_current_state(TASK_UNINTERRUPTIBLE); >> +if (atomic_read(_unload_inhibit_cnt)) >> +

Re: [PATCH 24/25] r/o bind mounts: track number of mount writers

2007-09-24 Thread Andrew Morton
On Mon, 24 Sep 2007 16:05:37 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > On Mon, 2007-09-24 at 15:25 -0700, Andrew Morton wrote: > > hm. I saw that warning on my 2-way. It has CONFIG_NR_CPUS=8 so perhaps > > the kernel has decided that this machine can possibly have eight CPUs. > > > > It's

Re: 2.6.23-rc7-mm1: build error with CONFIG_KEXEC=y and CONFIG_NOHIGHMEM=y

2007-09-24 Thread Randy Dunlap
[adding kexec m-l] On Mon, 24 Sep 2007 22:10:36 +0200 Laurent Riffard wrote: > Le 24.09.2007 11:17, Andrew Morton a écrit : > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/ > > > > I've got this compilation when CONFIG_KEXEC=y and

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread roel
Kristen Carlson Accardi wrote: > Device Initiated Power Management, which is defined > in SATA 2.5 can be enabled for disks which support it. > This patch enables DIPM when the user sets the link > power management policy to "min_power". > > Additionally, libata drivers can define a function >

Re: [PATCH] leds: add missing header

2007-09-24 Thread Richard Purdie
On Sun, 2007-09-23 at 08:14 +0200, Pierre Ossman wrote: > rwlocks are used in the structures so make sure the right header > is included. > > Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> I think something similar was already committed in revision df96efd73b81b8bc2d23b3d8b6025cce3d43db6c.

Re: [PATCH 24/25] r/o bind mounts: track number of mount writers

2007-09-24 Thread Dave Hansen
On Mon, 2007-09-24 at 15:25 -0700, Andrew Morton wrote: > hm. I saw that warning on my 2-way. It has CONFIG_NR_CPUS=8 so perhaps > the kernel has decided that this machine can possibly have eight CPUs. > > It's an old super-micro board, doesn't have ACPI. Well, it's looking like we only set

Re: Mask Issue?

2007-09-24 Thread Chris Holvenstot
On Mon, 2007-09-24 at 16:39 +0100, Mel Gorman wrote: > On (19/09/07 17:57), Chris Holvenstot didst pronounce: > > Still being a little new at this I am not sure if this is an issue at > > all or not but I noted that while building the 2.6.23-rc6-git8 kernel > > this afternoon I received the

Re: [Linux-fbdev-devel] [RFC] driving a LCD panel via I2C

2007-09-24 Thread Richard Purdie
On Mon, 2007-09-24 at 12:34 +0200, Haavard Skinnemoen wrote: > On Mon, 24 Sep 2007 10:58:08 +0200 (CEST) > "Rodolfo Giometti" <[EMAIL PROTECTED]> wrote: > > I have an LCD panel on a custom PXA27x based board and it must be > > turned on/off by some special commands via a GPIO throught a I2C chip.

Re: 2.6.23-rc7-mm1: build error with CONFIG_KEXEC=y and CONFIG_NOHIGHMEM=y

2007-09-24 Thread Laurent Riffard
Le 24.09.2007 11:17, Andrew Morton a écrit : > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/ > I've got this compilation when CONFIG_KEXEC=y and CCONFIG_NOHIGHMEM=y: linux-2.6-mm$ LANG=C make CHK include/linux/version.h CHK

Re: sys_chroot+sys_fchdir Fix

2007-09-24 Thread Serge E. Hallyn
Quoting David Newall ([EMAIL PROTECTED]): > Serge E. Hallyn wrote: >> No reason for any new parameters to pivot_root. Just clone your mounts >> namespace first. >> >> unshare(CLONE_NEWNS); >> chdir(new_dir); >> pivot_root(new_dir, oldroot); >> >> Since pivot_root actually fiddles

Re: sys_chroot+sys_fchdir Fix

2007-09-24 Thread Serge E. Hallyn
Quoting David Newall ([EMAIL PROTECTED]): > Serge E. Hallyn wrote: >> No reason for any new parameters to pivot_root. Just clone your mounts >> namespace first. >> >> unshare(CLONE_NEWNS); >> chdir(new_dir); >> pivot_root(new_dir, oldroot); >> >> Since pivot_root actually fiddles

Re: [patch 2/4] new timerfd API v2 - new timerfd API

2007-09-24 Thread roel
Davide Libenzi wrote: > This is the new timerfd API as it is implemented by the following patch: > > int timerfd_create(int clockid); > int timerfd_settime(int ufd, int flags, > const struct itimerspec *utmr, > struct itimerspec *otmr); > int

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Mathieu Desnoyers
* Randy Dunlap ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers wrote: > >* Randy Dunlap ([EMAIL PROTECTED]) wrote: > >>This is RFC patch 2/2. > >>Patch 1/2 introduces the samples/ infrastructure: > >> http://lkml.org/lkml/2007/9/24/397 > >> > > > >Hi Randy, > > > >I got this when building my

Re: Ethernet driver on 2.6.22

2007-09-24 Thread Randy Dunlap
On Tue, 25 Sep 2007 08:39:07 +1000 hce wrote: > On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > On Mon, 24 Sep 2007 12:40:07 +1000 hce wrote: > > > > > Thanks Randy. > > > > > > On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > On Mon, 24 Sep 2007 08:52:36 +1000 hce wrote: > > >

Re: [PATCH 6/11] eCryptfs: Update metadata read/write functions

2007-09-24 Thread Michael Halcrow
On Wed, Sep 19, 2007 at 10:48:17PM -0700, Andrew Morton wrote: > On Mon, 17 Sep 2007 16:48:44 -0500 Michael Halcrow <[EMAIL PROTECTED]> wrote: > > + if ((rc = ecryptfs_write_lower(ecryptfs_dentry->d_inode, > > checkpatch missed the assignment-in-an-if here. Fix an assignment-in-an-if.

Re: Ethernet driver on 2.6.22

2007-09-24 Thread hce
On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Mon, 24 Sep 2007 12:40:07 +1000 hce wrote: > > > Thanks Randy. > > > > On 9/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > On Mon, 24 Sep 2007 08:52:36 +1000 hce wrote: > > > > > > > Hi, > > > > > > > > I am upgrading from kernel

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Randy Dunlap
On Tue, 25 Sep 2007 00:24:00 +0200 roel wrote: > I could only point to three nitpicks Yes, hopefully the kprobes people will chime in here sometime and merge those as well, or just ack them and I can change the code. Thanks. --- ~Randy Phaedrus says that Quality is about caring. - To

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Randy Dunlap
Mathieu Desnoyers wrote: * Randy Dunlap ([EMAIL PROTECTED]) wrote: This is RFC patch 2/2. Patch 1/2 introduces the samples/ infrastructure: http://lkml.org/lkml/2007/9/24/397 Hi Randy, I got this when building my markers (which looks alike your kprobes): ld: samples/built-in.o: No such

Re: [PATCH 24/25] r/o bind mounts: track number of mount writers

2007-09-24 Thread Andrew Morton
On Mon, 24 Sep 2007 15:06:42 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > On Sun, 2007-09-23 at 23:17 -0700, Andrew Morton wrote: > > It look like a false positive to me, but really, for a patchset of this > > complexity and maturity I cannot fathom how it could have escaped any > > lockdep

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread roel
I could only point to three nitpicks Randy Dunlap wrote: > This is RFC patch 2/2. > Patch 1/2 introduces the samples/ infrastructure: > http://lkml.org/lkml/2007/9/24/397 > > > --- > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Move kprobes source files from Documentation/kprobes.txt to >

Re: 2.6.23-rc7-mm1: panic in scheduler

2007-09-24 Thread Ingo Molnar
* Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > Taking a quick look at [__]{en|de|queue_entity() and the functions > they call, I see something suspicious in set_leftmost() in > sched_fair.c: > > static inline void > set_leftmost(struct cfs_rq *cfs_rq, struct rb_node *leftmost) > { >

Linux 2.6.16.54-rc1

2007-09-24 Thread Adrian Bunk
Location: ftp://ftp.kernel.org/pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.53:

Re: 2.6.23-rc7-mm1

2007-09-24 Thread Kamalesh Babulal
Hi Andrew, The drivers/net/pasemi_mac seems to be broken and build fails with CC [M] drivers/net/pasemi_mac.o drivers/net/pasemi_mac.c: In function ‘pasemi_mac_probe’: drivers/net/pasemi_mac.c:1153: error: conflicting types for ‘mac’ drivers/net/pasemi_mac.c:1151: error: previous declaration of

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Mathieu Desnoyers
* Randy Dunlap ([EMAIL PROTECTED]) wrote: > > This is RFC patch 2/2. > Patch 1/2 introduces the samples/ infrastructure: > http://lkml.org/lkml/2007/9/24/397 > Hi Randy, I got this when building my markers (which looks alike your kprobes): ld: samples/built-in.o: No such file: No such file

[patch 2/2] Enable Aggressive Link Power management for AHCI controllers.

2007-09-24 Thread Kristen Carlson Accardi
This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci driver. This will cause the controller and disk to negotiate a lower power state for the link when there is no activity (see the AHCI 1.x spec for details). This feature is mutually exclusive

Re: [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-24 Thread Marcel Holtmann
Hi Wang, > This patch: > - makes hidp_setup_input() return int to indicate errors; > - checks its return value to handle errors. > > And this time it is against -rc7-mm1 tree. > > Thanks to roel and Marcel Holtmann for comments. > > Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Signed-off-by:

[patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Kristen Carlson Accardi
Device Initiated Power Management, which is defined in SATA 2.5 can be enabled for disks which support it. This patch enables DIPM when the user sets the link power management policy to "min_power". Additionally, libata drivers can define a function (enable_pm) that will perform hardware

[patch 0/2] SATA Link Power Management patches

2007-09-24 Thread Kristen Carlson Accardi
Here's a set of patches which implement link power management for SATA. We had talked at kernel summit of moving sysfs interface for setting the link power management policy to the block layer, but after a lot of consideration, I think this doesn't make sense. Mainly because I feel for SATA the

Re: [PATCH 3/11] eCryptfs: read_write.c routines

2007-09-24 Thread Michael Halcrow
On Wed, Sep 19, 2007 at 10:38:50PM -0700, Andrew Morton wrote: > > + offset = (page_for_lower->index << PAGE_CACHE_SHIFT) + offset_in_page; > > bug. You need to cast page.index to loff_t before shifting. > > I'd fix it on the spot, but this would be a good time to review the > whole patchset

i386: Fix null interrupt handler (ignore_int) message ?

2007-09-24 Thread Ahmed S. Darwish
Hi all, I'm getting little confused by some ignore_int (null interrupt handler) code in head.S. Code notifies the user about the unknown raised interrupt by below string: int_msg: .asciz "Unknown interrupt or fault at EIP %p %p %p\n" and prints it using below code path: ignore_int:

Re: [PATCH 24/25] r/o bind mounts: track number of mount writers

2007-09-24 Thread Dave Hansen
On Sun, 2007-09-23 at 23:17 -0700, Andrew Morton wrote: > It look like a false positive to me, but really, for a patchset of this > complexity and maturity I cannot fathom how it could have escaped any > lockdep testing. I test with lockdep all the time. The problem was that lockdep doesn't

lockdep wierdness...

2007-09-24 Thread Trond Myklebust
I'm seeing lockdep warning about a potential lock inversion between >mmap_sem and >i_mutex in NFS (see attachment). Unfortunately the basis for the warning appears to be the behaviour in ext3(???). AFAICS there is no way for NFS to share an inode->i_mutex with ext3. What to do? Trond

  1   2   3   4   5   6   7   8   9   10   >