Re: [GIT PULL] blob-stacking updates for security-next

2019-01-10 Thread James Morris
On Tue, 8 Jan 2019, Kees Cook wrote: > Hi James, > > Please pull these blob-stacking changes for security-next. > > Thanks! Merged to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general and next-testing. This passes the SELinux testsuite on my system, and

Re: [PATCH 14/15] arch: add split IPC system calls where needed

2019-01-10 Thread Heiko Carstens
On Thu, Jan 10, 2019 at 05:24:34PM +0100, Arnd Bergmann wrote: > The IPC system call handling is highly inconsistent across architectures, > some use sys_ipc, some use separate calls, and some use both. We also > have some architectures that require passing IPC_64 in the flags, and > others that

Re: [PATCH v3 0/6] Static calls

2019-01-10 Thread Josh Poimboeuf
On Thu, Jan 10, 2019 at 07:45:26PM +, Nadav Amit wrote: > >> I’m not GCC expert either and writing this code was not making me full of > >> joy, etc.. I’ll be happy that my code would be reviewed, but it does work. > >> I > >> don’t think an early pass is needed, as long as hardware registers

Re: [RFC PATCH glibc 1/4] glibc: Perform rseq(2) registration at nptl init and thread creation (v4)

2019-01-10 Thread Mathieu Desnoyers
- On Dec 11, 2018, at 2:40 AM, Florian Weimer fwei...@redhat.com wrote: > * Mathieu Desnoyers: > >> I want to keep the __rseq_refcount symbol so out-of-libc users can >> register rseq if they are linked against a pre-2.29 libc. > > Sorry, I was confused. Hi Florian, Thanks for your

Re: [PATCH v3 0/6] Static calls

2019-01-10 Thread Peter Zijlstra
On Wed, Jan 09, 2019 at 04:59:35PM -0600, Josh Poimboeuf wrote: > With this version, I stopped trying to use text_poke_bp(), and instead > went with a different approach: if the call site destination doesn't > cross a cacheline boundary, just do an atomic write. Otherwise, keep > using the

RE: [PATCH 1/2] ahci: qoriq: add lx2160 platforms support

2019-01-10 Thread Leo Li
> -Original Message- > From: Peng Ma > Sent: Thursday, January 10, 2019 4:32 AM > To: Peng Ma ; shawn...@kernel.org; > ax...@kernel.dk > Cc: Leo Li ; robh...@kernel.org; > mark.rutl...@arm.com; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.org;

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2019-01-10 Thread Eric Biggers
On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > > called from construct_alloc_key() during sys_request_key(),

Re: seqcount usage in xt_replace_table()

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 03:48:12PM +0100, Florian Westphal wrote: > Peter Zijlstra wrote: > > Is performance a concern in this path? There is no comment justifying > > this 'creative' stuff. > > We have to wait until all cpus are done with current iptables ruleset. > > Before this 'creative'

Re: [PATCH] checkpatch: allow reporting C99 style comments

2019-01-10 Thread Joe Perches
On Wed, 2019-01-09 at 21:01 -0800, Vadim Bendebury wrote: > Presently C99 style comments are removed unconditionally before actual > patch validity check happens. This is a problem for some third party > projects which use checkpatch.pl but do not allow C99 style comments. > > This patch adds yet

Re: [PATCH 27/41] scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I

Re: seqcount usage in xt_replace_table()

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 03:48:12PM +0100, Florian Westphal wrote: > Peter Zijlstra wrote: > > /* > > * Ensure contents of newinfo are visible before assigning to > > * private. > > */ > > smp_wmb(); > > table->private = newinfo; > > > > we have: > > > >

Re: seqcount usage in xt_replace_table()

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 01:53:28PM +0100, Dmitry Vyukov wrote: > On Thu, Jan 10, 2019 at 1:41 PM Peter Zijlstra wrote: > > > > On Tue, Jan 08, 2019 at 11:37:46PM +0100, Florian Westphal wrote: > > > Anatol Pomozov wrote: > > > > Or maybe xt_replace_table() can be enhanced? When I hear that > > >

Re: [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues

2019-01-10 Thread Sam Ravnborg
Hi Peter. (Hijacking this thread as I lost the orginal mails) > > > > I found an unfortunate issue while recoding plane handling to use > > drm_atomic_helper_check_plane_state(). The driver rotates clockwise, > > which is not correct. I simply fixed it (patch 1/4), but maybe that > > will cause

Re: [PATCH 05/41] scsi: aic7xxx: aic79xx: mark expected switch fall-through

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:36 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:26 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 06/41] scsi: aic7xxx: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:37 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:26 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 09/41] scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:38 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 08/41] scsi: be2iscsi: be_main: Mark expected switch fall-through

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:38 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 10/41] scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 11/41] scsi: bfa: bfa_fcs_rport: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 4/4] dt-bindings: mfd: max8998: Add charger subnode binding

2019-01-10 Thread Paweł Chmiel
Hi On Thursday, 10 January 2019 18:47:11 CET Sylwester Nawrocki wrote: > Hi, > > On 5/1/18 16:43, Paweł Chmiel wrote: > > On Tuesday, May 1, 2018 2:45:40 PM CEST Sebastian Reichel wrote: > >> On Fri, Apr 27, 2018 at 06:03:02PM +0200, Paweł Chmiel wrote: > >>> This patch adds devicetree bindings

Re: Question about qspinlock nest

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 06:25:57PM +, James Morse wrote: > On arm64 if all the RAS and psuedo-NMI patches land, our worst-case > interleaving > jumps to at least 7. The culprit is APEI using spinlocks to protect fixmap > slots. > > I have an RFC to bump the number of node bits from 2 to 3,

Re: [PATCH 13/41] scsi: csiostor: csio_wr: mark expected switch fall-through

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Martin: apparently, the only maintainers for this driver are you and James. Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks --

Re: There is no 'no space' message when using xfs with nfs.

2019-01-10 Thread J. Bruce Fields
On Sun, Dec 09, 2018 at 10:07:26PM +0900, Guk-Bong Kwon wrote: > i use xfs filesystem over nfs > > > I am using the xfs file system via NFS on two Linux servers. > > Even though xfs is full, you will not get a 'no space' message through nfs. > > The server's load average goes up and the

Re: [PATCH 14/41] scsi: esas2r: esas2r_init: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 16/41] scsi: imm: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Martin: apparently, the only maintainers for this driver are you and James. Thanks -- Gustavo On 11/27/18 10:29 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases

Re: [PATCH v1 6/7] arm64: dts: sdm845: Increase alert trip point to 95 degrees

2019-01-10 Thread Amit Kucheria
On Thu, Jan 10, 2019 at 5:59 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-01-09 16:00:55) > > 75 degrees is too aggressive for throttling the CPU. After speaking to > > Qualcomm engineers, increase it to 95 degrees. > > > > Signed-off-by: Amit Kucheria > > --- > >

Re: [PATCH v4 1/3] drm: msm: Cleanup drm_display_mode print str

2019-01-10 Thread Daniel Vetter
On Thu, Jan 10, 2019 at 04:13:01PM -0200, Shayenne Moura wrote: > This patch adjust the print string of drm_display_mode object > to remove drm_mode_object dependency in msm files. > > Reported-by: kbuild test robot For next time around, this is a bit much credit for kbuild test robot. I'd just

Re: [PATCH 22/41] scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH 23/41] scsi: lpfc: lpfc_els: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114978 ("Missing

Re: [PATCH 24/41] scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I

Re: Question about qspinlock nest

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 04:02:53PM +0800, Zhenzhong Duan wrote: > Hi Maintainer, > > > There is a question confused me for days. Appreciate an answer. > > In below code, the comment says we never have more than 4 nested contexts. > > What happen if debug and mce exceptions nest with the four,

Re: Re: [PATCH] drm/mediatek: Add MTK Framebuffer-Device (mt7623)

2019-01-10 Thread Daniel Vetter
On Thu, Jan 10, 2019 at 08:01:37PM +0100, Frank Wunderlich wrote: > Hi Daniel, > > > > Would be good to use the new generic fbdev emulation code here, for even > > > less code. Or at least know why this isn't possible to use for mtk (and > > > maybe address that in the core code). Hand-rolling

Re: [PATCH 26/41] scsi: lpfc: lpfc_nvme: Mark expected switch fall-through

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH v2] arm64: invalidate TLB just before turning MMU on

2019-01-10 Thread Bhupesh Sharma
Hi Qian, On Sat, Dec 15, 2018 at 7:24 AM Qian Cai wrote: > > On 12/14/18 2:23 AM, Ard Biesheuvel wrote: > > On Fri, 14 Dec 2018 at 05:08, Qian Cai wrote: > >> Also tried to move the local TLB flush part around a bit inside > >> __cpu_setup(), although it did complete kdump some times, it did

Re: [PATCH v1 6/7] arm64: dts: sdm845: Increase alert trip point to 95 degrees

2019-01-10 Thread Matthias Kaehlcke
On Fri, Jan 11, 2019 at 01:15:09AM +0530, Amit Kucheria wrote: > On Thu, Jan 10, 2019 at 7:45 AM Matthias Kaehlcke wrote: > > > > On Wed, Jan 09, 2019 at 05:15:33PM -0800, Matthias Kaehlcke wrote: > > > Hi Amit, > > > > > > On Thu, Jan 10, 2019 at 05:30:55AM +0530, Amit Kucheria wrote: > > > > 75

Re: perf: rdpmc bug when viewing all procs on remote cpu

2019-01-10 Thread Vince Weaver
On Thu, 10 Jan 2019, Vince Weaver wrote: > On Thu, 10 Jan 2019, Vince Weaver wrote: > > > However if you create an all-process attached to CPU event: > > perf_event_open(attr, -1, X, -1, 0); > > the mmap event index is set as if this were a valid event and so the rdpmc > > succeeds even

Re: PROBLEM: syzkaller found / pool corruption-overwrite / page in user-area or NULL

2019-01-10 Thread James Bottomley
On Thu, 2019-01-10 at 19:12 +, Esme wrote: > Sorry for the resend some mail servers rejected the mime type. > > Hi, I've been getting more into Kernel stuff lately and forged ahead > with some syzkaller bug finding. I played with reducing it further > as you can see from the attached c code

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Dan Murphy
On 1/10/19 1:23 PM, Jacek Anaszewski wrote: > Dan, > > On 1/10/19 1:46 PM, Dan Murphy wrote: >> Jacek >> >> On 1/8/19 3:25 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 1/8/19 3:18 PM, Jacek Anaszewski wrote: Hi Dan, On 1/7/19 10:14 PM, Dan Murphy wrote: > Jacek > > On

Re: [PATCH 33/41] scsi: osd: osd_initiator: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:07 PM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 34/41] scsi: osst: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:07 PM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 1/2] dt: bindings: lp5024: Introduce the lp5024 and lp5018 RGB driver

2019-01-10 Thread Jacek Anaszewski
Dan, On 1/10/19 8:22 PM, Dan Murphy wrote: Jacek On 1/10/19 12:44 PM, Jacek Anaszewski wrote: Hi Dan, On 1/9/19 10:31 PM, Dan Murphy wrote: Jacek On 1/9/19 3:28 PM, Jacek Anaszewski wrote: On 1/9/19 10:12 PM, Dan Murphy wrote: On 1/9/19 2:12 PM, Jacek Anaszewski wrote: Hi Dan, On

Re: [PATCH 35/41] scsi: ppa: mark expected switch fall-through

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:07 PM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH v4] irqchip/mmp: only touch the PJ4 & FIQ bits on enable/disable

2019-01-10 Thread Lubomir Rintel
On Thu, 2018-12-20 at 22:55 +0100, Lubomir Rintel wrote: > On an OLPC XO 1.75 machine, the "security processor" handles the GPIO 71 > and 72 interrupts. Don't reset the "route to SP" bit (4). > > I'm just assuming the bit 4 is the "route to SP" bit -- it fixes the > SP-based keyboard for me and

Re: [PATCH 37/41] scsi: st: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:08 PM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:08 PM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH 39/41] scsi: sym53c8xx_2: sym_nvram: Mark expected switch fall-through

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 6:08 PM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote: In preparation to

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 10, 2019 at 07:30:22PM +, Song Liu escreveu: > > > > On Jan 10, 2019, at 10:55 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: > >> > >> > >>> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo > >>> wrote: >

Re: [PATCH v5 07/15] locking/lockdep: Free lock classes that are no longer in use

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 11:31:11AM -0800, Bart Van Assche wrote: > On Thu, 2019-01-10 at 16:28 +0100, Peter Zijlstra wrote: > > On Mon, Dec 17, 2018 at 01:29:54PM -0800, Bart Van Assche wrote: > > > +static bool inside_selftest(void) > > > +{ > > > + return current == lockdep_selftest_task_struct;

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
> On Jan 10, 2019, at 11:30 AM, Song Liu wrote: > > > >> On Jan 10, 2019, at 10:55 AM, Arnaldo Carvalho de Melo >> wrote: >> >> Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: >>> >>> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo wrote: Em

Re: [PATCH v5 07/15] locking/lockdep: Free lock classes that are no longer in use

2019-01-10 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 10:51:27AM -0800, Bart Van Assche wrote: > On Thu, 2019-01-10 at 16:24 +0100, Peter Zijlstra wrote: > > /* > > * A data structure for delayed freeing of data structures that may be > > - * accessed by RCU readers at the time these were freed. The size of the > > array >

Re: [PATCH v3 0/6] Static calls

2019-01-10 Thread Nadav Amit
> On Jan 10, 2019, at 10:18 AM, Josh Poimboeuf wrote: > > On Thu, Jan 10, 2019 at 05:32:08PM +, Nadav Amit wrote: >>> On Jan 10, 2019, at 8:44 AM, Josh Poimboeuf wrote: >>> >>> On Thu, Jan 10, 2019 at 01:21:00AM +, Nadav Amit wrote: > On Jan 9, 2019, at 2:59 PM, Josh Poimboeuf

Re: [PATCH v1 6/7] arm64: dts: sdm845: Increase alert trip point to 95 degrees

2019-01-10 Thread Amit Kucheria
On Thu, Jan 10, 2019 at 7:45 AM Matthias Kaehlcke wrote: > > On Wed, Jan 09, 2019 at 05:15:33PM -0800, Matthias Kaehlcke wrote: > > Hi Amit, > > > > On Thu, Jan 10, 2019 at 05:30:55AM +0530, Amit Kucheria wrote: > > > 75 degrees is too aggressive for throttling the CPU. After speaking to > > >

Re: [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable

2019-01-10 Thread Dan Carpenter
On Thu, Jan 10, 2019 at 05:00:24PM +, Sidong Yang wrote: > I think you just point out that my code isn't obvious because the > function returns negative error codes. I agree with you. But what if > change my code like if(hgsmi_query_conf() != 0). > That's even worse! :P You should do

Re: [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

2019-01-10 Thread Li Yang
On Sat, Dec 22, 2018 at 2:02 AM Nicholas Mc Guire wrote: > > On Fri, Dec 21, 2018 at 08:29:56PM -0600, Scott Wood wrote: > > On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote: > > > devm_kstrdup() may return NULL if internal allocation failed, but > > > as machine is from the device

[PATCH v2] RISC-V: defconfig: Enable Generic PCIE by default

2019-01-10 Thread Alistair Francis
Enable generic PCIe by default in the RISC-V defconfig, this allows us to use QEMU's PCIe support out of the box. Signed-off-by: Alistair Francis --- arch/riscv/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig

Re: PROBLEM: syzkaller found / pool corruption-overwrite / page in user-area or NULL

2019-01-10 Thread Greg KH
On Thu, Jan 10, 2019 at 07:05:26PM +, esploit wrote: > Hi, I've been getting more into Kernel stuff lately and forged ahead > with some syzkaller bug finding. for syzkaller stuff, no need to cc: the security mailing list. Just work with the respective subsystem maintainers and developers

Re: [PATCH] drm/nouveau/nvkm: mark expected switch fall-throughs

2019-01-10 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can take this? Thanks -- Gustavo On 10/17/18 9:28 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch aims to suppress 29 missing-break-in-switch false positives.

Re: [PATCH v5 07/15] locking/lockdep: Free lock classes that are no longer in use

2019-01-10 Thread Bart Van Assche
On Thu, 2019-01-10 at 16:28 +0100, Peter Zijlstra wrote: > On Mon, Dec 17, 2018 at 01:29:54PM -0800, Bart Van Assche wrote: > > +static bool inside_selftest(void) > > +{ > > + return current == lockdep_selftest_task_struct; > > +} > > +void lockdep_free_key_range(void *start, unsigned long size)

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
> On Jan 10, 2019, at 10:55 AM, Arnaldo Carvalho de Melo > wrote: > > Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: >> >> >>> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo >>> wrote: >>> >>> Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: For

Re: [PATCH 4/4] drm/atmel-hlcdc: do not immediately disable planes, wait for next frame

2019-01-10 Thread Boris Brezillon
On Thu, 10 Jan 2019 18:51:21 + Peter Rosin wrote: > On 2019-01-10 18:29, Boris Brezillon wrote: > > On Thu, 10 Jan 2019 15:10:48 + > > Peter Rosin wrote: > > > >> The A2Q and UPDATE bits have no effect in the channel disable registers. > >> However, since they are present, assume

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Jacek Anaszewski
Dan, On 1/10/19 1:46 PM, Dan Murphy wrote: Jacek On 1/8/19 3:25 PM, Dan Murphy wrote: Jacek On 1/8/19 3:18 PM, Jacek Anaszewski wrote: Hi Dan, On 1/7/19 10:14 PM, Dan Murphy wrote: Jacek On 1/7/19 2:59 PM, Jacek Anaszewski wrote: Dan, On 1/7/19 8:36 PM, Dan Murphy wrote: Jacek On

Re: Question about qspinlock nest

2019-01-10 Thread Waiman Long
On 01/10/2019 01:25 PM, James Morse wrote: > Hi Longman, Zhenzhong, > > On 10/01/2019 14:43, Waiman Long wrote: >> On 01/10/2019 03:02 AM, Zhenzhong Duan wrote: >>> There is a question confused me for days. Appreciate an answer. >>> >>> In below code, the comment says we never have more than 4

Re: [PATCH 1/2] dt: bindings: lp5024: Introduce the lp5024 and lp5018 RGB driver

2019-01-10 Thread Dan Murphy
Jacek On 1/10/19 12:44 PM, Jacek Anaszewski wrote: > Hi Dan, > > On 1/9/19 10:31 PM, Dan Murphy wrote: >> Jacek >> >> On 1/9/19 3:28 PM, Jacek Anaszewski wrote: >>> On 1/9/19 10:12 PM, Dan Murphy wrote: On 1/9/19 2:12 PM, Jacek Anaszewski wrote: > Hi Dan, > > On 1/8/19 10:22 PM,

Re: [PATCH] include/linux: Remove duplicate header

2019-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2019 at 09:31:14PM +0530, Brajeswar Ghosh wrote: > Remove duplicate headers which are included more than once > > Signed-off-by: Brajeswar Ghosh > --- > include/linux/perf_event.h | 1 - > include/linux/ptr_ring.h | 1 - > include/linux/qed/qed_if.h | 1 - >

Re: [PATCH RFC 0/3] mm: Reduce IO by improving algorithm of memcg pagecache pages eviction

2019-01-10 Thread Shakeel Butt
On Thu, Jan 10, 2019 at 1:46 AM Kirill Tkhai wrote: > > Hi, Shakeel, > > On 09.01.2019 20:37, Shakeel Butt wrote: > > Hi Kirill, > > > > On Wed, Jan 9, 2019 at 4:20 AM Kirill Tkhai wrote: > >> > >> On nodes without memory overcommit, it's common a situation, > >> when memcg exceeds its limit and

RE: [PATCH V3 3/3] mmc: tegra: SDMMC pads auto-calibration

2019-01-10 Thread Sowjanya Komatineni
>> @@ -805,6 +854,12 @@ static int tegra_sdhci_init_pinctrl_info(struct device >> *dev, >> return -1; >> } >> >> +tegra_host->pinctrl_state_1v8_drv = pinctrl_lookup_state( >> +tegra_host->pinctrl_sdmmc, "sdmmc-1v8-drv"); >> + >> +

Re: [PATCH 2/2] x86/selftests/pkeys: fork() to check for state being preserved

2019-01-10 Thread Greg KH
On Thu, Jan 03, 2019 at 10:57:24AM -0800, Dave Hansen wrote: > On 1/3/19 5:52 AM, Sasha Levin wrote: > > This commit has been processed because it contains a -stable tag. > > The stable tag indicates that it's relevant for the following trees: all > > > > The bot has tested the following trees:

PROBLEM: syzkaller found / pool corruption-overwrite / page in user-area or NULL

2019-01-10 Thread Esme
Sorry for the resend some mail servers rejected the mime type. Hi, I've been getting more into Kernel stuff lately and forged ahead with some syzkaller bug finding. I played with reducing it further as you can see from the attached c code but am moving on and hope to get better about this

Re: [4.9 PATCH] MIPS: math-emu: Write-protect delay slot emulation pages

2019-01-10 Thread gre...@linuxfoundation.org
On Thu, Jan 10, 2019 at 05:47:42PM +, Paul Burton wrote: > commit adcc81f148d733b7e8e641300c5590a2cdc13bf3 upstream. > > Mapping the delay slot emulation page as both writeable & executable > presents a security risk, in that if an exploit can write to & jump into > the page then it can be

Re: [PATCH] ARM: mm: initialize pfn limits with find_limits()

2019-01-10 Thread Doug Berger
On 12/27/18 3:47 PM, Doug Berger wrote: > The max_low_pfn value must be set before sparse_init() is called to > keep the early memblock allocations and frees balanced for kmemleak > initialization when sparsemem is enabled. > > This commit accomplishes that by replacing the local variables min, >

Re: [PATCH] iavf: Use printf instead of gnu_printf for iavf_debug_d

2019-01-10 Thread Nathan Chancellor
On Thu, Jan 10, 2019 at 10:54:46AM -0800, Nick Desaulniers wrote: > On Wed, Jan 9, 2019 at 8:22 PM Nathan Chancellor > wrote: > > > > Clang warns: > > > > In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4: > > In file included from drivers/net/ethernet/intel/iavf/iavf.h:37: > >

Re: [PATCH RFC memory-model 0/6] LKMM updates

2019-01-10 Thread Paul E. McKenney
On Thu, Jan 10, 2019 at 10:47:26AM -0500, Alan Stern wrote: > On Wed, 9 Jan 2019, Paul E. McKenney wrote: > > > Hello! > > > > This series contains updates for the Linux-kernel memory model: > > > > 1-3.Add SRCU support, courtesy of Alan Stern. > > > > 4. Update README for adding of

Aw: Re: [PATCH] drm/mediatek: Add MTK Framebuffer-Device (mt7623)

2019-01-10 Thread Frank Wunderlich
Hi Daniel, > > Would be good to use the new generic fbdev emulation code here, for even > > less code. Or at least know why this isn't possible to use for mtk (and > > maybe address that in the core code). Hand-rolling fbdev code shouldn't be > > needed anymore. > > Back on the mailing list, no

Re: [PATCH v2] isdn: avm: Fix string plus integer warning from Clang

2019-01-10 Thread Nick Desaulniers
On Wed, Jan 9, 2019 at 9:42 PM Nathan Chancellor wrote: > > A recent commit in Clang expanded the -Wstring-plus-int warning, showing > some odd behavior in this file. > > drivers/isdn/hardware/avm/b1.c:426:30: warning: adding 'int' to a string does > not append to the string [-Wstring-plus-int]

Re: [PATCH v2] PM/runtime: Fix 'jiffies' in comments after move to hrtimers

2019-01-10 Thread Vincent Guittot
On Thu, 10 Jan 2019 at 00:19, Ladislav Michl wrote: > > PM-runtime now uses the hrtimers infrastructure for autosuspend, however > comments still reference 'jiffies'. > > Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtimers") > Signed-off-by: Ladislav Michl Acked-by:

Re: [PATCH] PM/runtime: Do not needlessly call ktime_get

2019-01-10 Thread Vincent Guittot
On Thu, 10 Jan 2019 at 10:51, Ladislav Michl wrote: > > pm_runtime_autosuspend_expiration calls ktime_get even when > its returned value may be unused. Therefore get current time > later and remove gotos while there. > > Signed-off-by: Ladislav Michl Acked-by: Vincent Guittot > --- > NOTE:

Re: [PATCH] iavf: Use printf instead of gnu_printf for iavf_debug_d

2019-01-10 Thread Nick Desaulniers
On Wed, Jan 9, 2019 at 8:22 PM Nathan Chancellor wrote: > > Clang warns: > > In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4: > In file included from drivers/net/ethernet/intel/iavf/iavf.h:37: > In file included from drivers/net/ethernet/intel/iavf/iavf_type.h:8: >

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: > > > > On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: > >> For better performance analysis of dynamically JITed and loaded kernel > >>

Re: [PATCH tip/core/rcu 2/2] virt/kvm: Replace spin_is_locked() with lockdep

2019-01-10 Thread Paul E. McKenney
On Wed, Jan 09, 2019 at 11:36:23PM +0100, Paolo Bonzini wrote: > On 09/01/19 23:21, Paul E. McKenney wrote: > > lockdep_assert_held() is better suited to checking locking requirements, > > since it only checks if the current thread holds the lock regardless of > > whether someone else does. This

Re: [PATCH v5 07/15] locking/lockdep: Free lock classes that are no longer in use

2019-01-10 Thread Bart Van Assche
On Thu, 2019-01-10 at 16:24 +0100, Peter Zijlstra wrote: > /* > * A data structure for delayed freeing of data structures that may be > - * accessed by RCU readers at the time these were freed. The size of the > array > - * is a compromise between minimizing the amount of memory used by this

Re: [PATCH 4/4] drm/atmel-hlcdc: do not immediately disable planes, wait for next frame

2019-01-10 Thread Peter Rosin
On 2019-01-10 18:29, Boris Brezillon wrote: > On Thu, 10 Jan 2019 15:10:48 + > Peter Rosin wrote: > >> The A2Q and UPDATE bits have no effect in the channel disable registers. >> However, since they are present, assume that the intention is to disable >> planes, not immediately as indicated

Re: yama: unsafe usage of ptrace_relation->tracer

2019-01-10 Thread Kees Cook
On Thu, Jan 10, 2019 at 3:06 AM Tetsuo Handa wrote: > syzbot is hitting this problem as of linux-next-20190110. > When a patch will be proposed? Hi! Sorry, this got delayed over the holidays. Let me finish the patch I was working on and get it published. Thanks! -- Kees Cook

Re: [PATCH v3 2/4] dt-bindings: hwmon: add dps650ab documentation

2019-01-10 Thread Guenter Roeck
On Thu, Jan 10, 2019 at 10:24:33AM +0800, Xiaoting Liu wrote: > Bindings for Delta Electronics DPS-650-AB power supply. > > Signed-off-by: Xiaoting Liu Waiting for DT maintainer Ack to apply. Note that you did not copy linux-hw...@vger.kernel.org. As a result, it _may_ get lost since

Re: [PATCH 1/2] dt: bindings: lp5024: Introduce the lp5024 and lp5018 RGB driver

2019-01-10 Thread Jacek Anaszewski
Hi Dan, On 1/9/19 10:31 PM, Dan Murphy wrote: Jacek On 1/9/19 3:28 PM, Jacek Anaszewski wrote: On 1/9/19 10:12 PM, Dan Murphy wrote: On 1/9/19 2:12 PM, Jacek Anaszewski wrote: Hi Dan, On 1/8/19 10:22 PM, Dan Murphy wrote: On 1/8/19 3:16 PM, Jacek Anaszewski wrote: On 1/8/19 9:53 PM, Dan

Re: [PATCH v3 4/4] hwmon: (pmbus) add support for DPS-650AB

2019-01-10 Thread Guenter Roeck
On Thu, Jan 10, 2019 at 10:31:44AM +0800, Xiaoting Liu wrote: > Provide support for PSU DPS-650AB from Delta Electronics, INC. > > Signed-off-by: Xiaoting Liu Applied to hwmon-next. Thanks, Guenter > --- > v3: > No change. > --- > v2: > Change the patch subject and commit message. >

Re: [PATCH v1 7/7] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-01-10 Thread Matthias Kaehlcke
On Thu, Jan 10, 2019 at 11:53:59AM +0530, Viresh Kumar wrote: > On 09-01-19, 18:22, Matthias Kaehlcke wrote: > > Hi Amit, > > > > On Thu, Jan 10, 2019 at 05:30:56AM +0530, Amit Kucheria wrote: > > > Since the big and little cpus are in the same frequency domain, use all > > > of them for

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo > wrote: > > Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: >> For better performance analysis of dynamically JITed and loaded kernel >> functions, such as BPF programs, this patch introduces >> PERF_RECORD_KSYMBOL, a new

[PATCH] mmc: meson-gx: Free irq in release() callback

2019-01-10 Thread Remi Pommarel
Because the irq was requested through device managed resources API (devm_request_threaded_irq()) it was freed after meson_mmc_remove() completion, thus after mmc_free_host() has reclaimed meson_host memory. As this irq is IRQF_SHARED, while using CONFIG_DEBUG_SHIRQ, its handler get called by

Re: [PATCH v3 2/6] static_call: Add basic static call infrastructure

2019-01-10 Thread Josh Poimboeuf
On Thu, Jan 10, 2019 at 02:03:20PM +, Edward Cree wrote: > > +#endif /* CONFIG_HAVE_STATIC_CALL_INLINE */ > CONFIG_HAVE_STATIC_CALL? Right, thanks. -- Josh

Re: General protection fault in `switch_mm_irqs_off()`

2019-01-10 Thread Lendacky, Thomas
On 1/10/19 10:49 AM, Paul Menzel wrote: > Dear Boris, dear Thomas, > > > On 01/10/19 17:00, Borislav Petkov wrote: >> On Thu, Jan 10, 2019 at 02:57:40PM +0100, Paul Menzel wrote: >>> Thank you very much. Indeed, the machine does not crash. I used Linus’ >>> master branch for testing, and applied

Re: [PATCH] hwmon: (adt7462) Mark expected switch fall-throughs

2019-01-10 Thread Guenter Roeck
On Thu, Jan 10, 2019 at 10:24:29AM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Signed-off-by: Gustavo A. R. Silva Applied to

Re: [PATCH 4.19 000/170] 4.19.14-stable review

2019-01-10 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 07:40:39AM -0800, Guenter Roeck wrote: > On Thu, Jan 10, 2019 at 04:15:40PM +0100, Christoph Biedl wrote: > > Christoph Biedl wrote... > > > > > Sorry for not getting back to you earlier. Building yesterday's > > > release (v4.19.14) *failed*, bisect led to > > > > > > |

Re: [RFC][PATCH v2 00/21] PMEM NUMA node and hotness accounting/migration

2019-01-10 Thread Jonathan Cameron
On Tue, 8 Jan 2019 15:52:56 +0100 Michal Hocko wrote: > On Wed 02-01-19 12:21:10, Jonathan Cameron wrote: > [...] > > So ideally I'd love this set to head in a direction that helps me tick off > > at least some of the above usecases and hopefully have some visibility on > > how to address the

Re: Question about qspinlock nest

2019-01-10 Thread James Morse
Hi Longman, Zhenzhong, On 10/01/2019 14:43, Waiman Long wrote: > On 01/10/2019 03:02 AM, Zhenzhong Duan wrote: >> There is a question confused me for days. Appreciate an answer. >> >> In below code, the comment says we never have more than 4 nested >> contexts. >> >> What happen if debug and mce

Re: [PATCH v3 5/6] x86/alternative: Use a single access in text_poke() where possible

2019-01-10 Thread Steven Rostedt
On Thu, 10 Jan 2019 10:04:28 -0800 Sean Christopherson wrote: > > What atomicity guarantee does the above require? > > I was asking in the context of static calls. My understanding is that > the write to change the imm32 of the CALL needs to be atomic from a > code fetch perspective so that

Re: x86/fpu: Don't export __kernel_fpu_{begin,end}()

2019-01-10 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 07:07:52PM +0100, Sebastian Andrzej Siewior wrote: > On 2019-01-10 17:32:58 [+], Hutter, Tony wrote: > > > But since when did out-of-tree modules use __kernel_fpu_begin? It's an > > > x86-only thing, and shouldn't really be used by anyone, right? > > > > ZFS on Linux

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: > For better performance analysis of dynamically JITed and loaded kernel > functions, such as BPF programs, this patch introduces > PERF_RECORD_KSYMBOL, a new perf_event_type that exposes kernel symbol > register/unregister information

RE: [PATCH 1/2] mmc: sdhci: Properly set DMA mask

2019-01-10 Thread Hunter, Adrian
> -Original Message- > From: Thierry Reding [mailto:thierry.red...@gmail.com] > Sent: Thursday, January 10, 2019 6:02 PM > To: Hunter, Adrian > Cc: Ulf Hansson ; Jonathan Hunter > ; Sowjanya Komatineni > ; Krishna Reddy ; linux- > m...@vger.kernel.org; linux-te...@vger.kernel.org;

Re: [PATCH v3 5/6] x86/alternative: Use a single access in text_poke() where possible

2019-01-10 Thread Josh Poimboeuf
On Thu, Jan 10, 2019 at 10:04:28AM -0800, Sean Christopherson wrote: > On Thu, Jan 10, 2019 at 12:57:57PM -0500, Steven Rostedt wrote: > > On Thu, 10 Jan 2019 09:42:57 -0800 > > Sean Christopherson wrote: > > > > > On Thu, Jan 10, 2019 at 12:32:43PM -0500, Steven Rostedt wrote: > > > > On Thu,

[PATCH] binder: create node flag to request sender's security context

2019-01-10 Thread Todd Kjos
To allow servers to verify client identity, allow a node flag to be set that causes the sender's security context to be delivered with the transaction. The BR_TRANSACTION command is extended in BR_TRANSACTION_SEC_CTX to contain a pointer to the security context string. Signed-off-by: Todd Kjos

<    1   2   3   4   5   6   7   8   9   10   >