Re: [PATCH v2 2/3] mm/memcg: remove rcu locking for lock_page_lruvec function series

2020-12-22 Thread Alex Shi
Cc: Hui Su and Alexander Duyck as Hugh suggested. 在 2020/12/22 下午1:20, Alex Shi 写道: > lock_page_lruvec() and its variants used rcu_read_lock() with the > intention of safeguarding against the mem_cgroup being destroyed > concurrently; but so long as they are called under the specified >

[PATCH] md/raid10: fix: incompatible types in comparison expression (different address spaces).

2020-12-22 Thread YANG LI
Fixes the following sparse errors in drivers/md/raid10.c error: incompatible types in comparison expression (different address spaces). The error was because of the following line in function read_balance(): rdev = rcu_dereference(conf->mirrors[disk].replacement); if (rdev == NULL ||

Re: [PATCH 01/18] arm64: dts: renesas: beacon kit: Configure programmable clocks

2020-12-22 Thread Geert Uytterhoeven
Hi Adam, On Tue, Dec 22, 2020 at 2:39 AM Adam Ford wrote: > On Fri, Dec 18, 2020 at 7:16 AM Geert Uytterhoeven > wrote: > > On Thu, Dec 17, 2020 at 12:52 PM Adam Ford wrote: > > > On Thu, Dec 17, 2020 at 2:16 AM Geert Uytterhoeven > > > wrote: > > > > On Wed, Dec 16, 2020 at 6:03 PM Adam

Re: [PATCH v5 01/12] media: uvcvideo: Fix race condition handling events

2020-12-22 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Mon, Dec 21, 2020 at 05:48:08PM +0100, Ricardo Ribalda wrote: > The control and its data needs to be copied to the workqueue at the same > time to avoid half-updates of the events. > This is, events reported to userspace were the control id does not match

[RFC PATCH 0/3 updated] add support for free hugepage reporting

2020-12-22 Thread Liang Li
A typical usage of hugetlbfs it's to reserve amount of memory during kernel booting, and the reserved pages are unlikely to return to the buddy system. When application need hugepages, kernel will allocate them from the reserved pool. when application terminates, huge pages will return to the

Re: [PATCH v5 02/12] media: uvcvideo: Allow more that one asyc_ctrl

2020-12-22 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Mon, Dec 21, 2020 at 05:48:09PM +0100, Ricardo Ribalda wrote: > The current implementation allocates memory for only one async_control. > If we get a second event before we have processed the previous one, the > old one gets lost. > > Introduce a dynamic

[RFC PATCH 0/3 updated] add support for free hugepage reporting

2020-12-22 Thread Liang Li
A typical usage of hugetlbfs it's to reserve amount of memory during kernel booting, and the reserved pages are unlikely to return to the buddy system. When application need hugepages, kernel will allocate them from the reserved pool. when application terminates, huge pages will return to the

[PATCH v9 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-22 Thread Alice Guo (OSS)
From: Alice Guo Add DT Binding doc for the Unique ID of i.MX 8M series. Signed-off-by: Alice Guo --- Changes for v9: - add additionalProperties for "^soc@[0-9a-f]+$" - add examples Changes for v8: - match soc node with regular expression Changes for v7: - change to a separate schema file

[PATCH v9 4/4] soc: imx8m: change to use platform driver

2020-12-22 Thread Alice Guo (OSS)
From: Alice Guo Directly reading ocotp register depends on that bootloader enables ocotp clk, which is not always effective, so change to use nvmem API. Using nvmem API requires to support driver defer probe and thus change soc-imx8m.c to use platform driver. The other reason is that directly

[PATCH v9 2/4] arm64: dts: imx8m: add SoC ID compatible

2020-12-22 Thread Alice Guo (OSS)
From: Alice Guo Add compatible string to .dtsi files for binding of imx8_soc_info and device. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alice Guo --- Changes for v9: - none Changes for v8: - none Changes for v7: - none Changes for v6: - leave only the changelog under '---' Changes

[PATCH v9 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID

2020-12-22 Thread Alice Guo (OSS)
From: Alice Guo In order to be able to use NVMEM APIs to read soc unique ID, add the nvmem data cell and name for nvmem-cells to the "soc" node, and add a nvmem node which provides soc unique ID to efuse@3035. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alice Guo --- Changes for v9:

[irqchip: irq/irqchip-next] driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()

2020-12-22 Thread irqchip-bot for John Garry
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: e1dc20995cb9fa04b46e8f37113a7203c906d2bf Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/e1dc20995cb9fa04b46e8f37113a7203c906d2bf Author:John Garry

Re: linux-next: build failure after merge of the akpm-current tree

2020-12-22 Thread Kuan-Ying Lee
On Mon, 2020-12-21 at 13:55 +1100, Stephen Rothwell wrote: > Hi Kuan-Ying, > > On Mon, 21 Dec 2020 10:31:38 +0800 Kuan-Ying Lee > wrote: > > > > On Mon, 2020-12-21 at 13:10 +1100, Stephen Rothwell wrote: > > > > > > After merging the akpm-current tree, today's linux-next build (x86_64 > > >

Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition

2020-12-22 Thread Jernej Škrabec
Hi! Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a): > This adds a device-tree definition for the CSI0 MCLK pin, > which can be used for feeding MIPI CSI-2 sensors. > > Signed-off-by: Paul Kocialkowski Is this used anywhere? Current policy is to add pin definitions

Re: [PATCH v2 1/2] dt-bindings: pwm: allwinner: Add V3s compatible description

2020-12-22 Thread Jernej Škrabec
Hi! Dne petek, 18. december 2020 ob 21:54:35 CET je Paul Kocialkowski napisal(a): > Introduce bindings description for the V3s PWM, which is > register-compatible with the A20 PWM. > > Signed-off-by: Paul Kocialkowski This is meant to be used together with V3s PWM patch you recently send? Can

Re: [PATCH v4] iio: Handle enumerated properties with gaps

2020-12-22 Thread Alexandru Ardelean
On Tue, Dec 22, 2020 at 9:21 AM Alexandru Ardelean wrote: > > On Mon, Dec 21, 2020 at 8:02 PM Andy Shevchenko > wrote: > > > > On Mon, Dec 21, 2020 at 5:11 PM Alexandru Ardelean > > wrote: > > > > > > From: Lars-Peter Clausen > > > > > > Some enums might have gaps or reserved values in the

Re: [PATCH 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2020-12-22 Thread Liu Ying
Hi Laurent, On Tue, 2020-12-22 at 09:49 +0200, Laurent Pinchart wrote: > Hi Liu, > > On Tue, Dec 22, 2020 at 09:36:37AM +0200, Laurent Pinchart wrote: > > On Thu, Dec 17, 2020 at 05:59:30PM +0800, Liu Ying wrote: > > > This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). > > > > >

Re: [RFC PATCH 2/3] virtio-balloon: add support for providing free huge page reports to host

2020-12-22 Thread David Hildenbrand
On 22.12.20 08:48, Liang Li wrote: > Free page reporting only supports buddy pages, it can't report the > free pages reserved for hugetlbfs case. On the other hand, hugetlbfs The virtio-balloon free page reporting interface accepts a generic sg, so it isn't glue to buddy pages. There is no need

Re: [RFC PATCH 3/3] mm: support free hugepage pre zero out

2020-12-22 Thread David Hildenbrand
On 22.12.20 08:49, Liang Li wrote: > This patch add support of pre zero out free hugepage, we can use > this feature to speed up page population and page fault handing. > > Cc: Alexander Duyck > Cc: Mel Gorman > Cc: Andrea Arcangeli > Cc: Dan Williams > Cc: Dave Hansen > Cc: David

Re: [PATCH v5 07/12] media: uvcvideo: Implement UVC_EXT_GPIO_UNIT

2020-12-22 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Mon, Dec 21, 2020 at 05:48:14PM +0100, Ricardo Ribalda wrote: > Some devices can implement a physical switch to disable the input of the > camera on demand. Think of it like an elegant privacy sticker. > > The system can read the status of the privacy

general protection fault in find_match (2)

2020-12-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3db1a3fa Merge tag 'staging-5.11-rc1' of git://git.kernel... git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=1103eadf50 kernel config: https://syzkaller.appspot.com/x/.config?x=2764fc28a92339f9

Re: [PATCH v3 2/7] regulator: dt-bindings: Document max8997-pmic nodes

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 07:31:21AM +, Timon Baetz wrote: > Add maxim,max8997-battery and maxim,max8997-muic optional nodes. > > Signed-off-by: Timon Baetz > --- > .../bindings/regulator/max8997-regulator.txt | 11 +++ > 1 file changed, 11 insertions(+) > Acked-by:

Re: [PATCH v5 07/12] media: uvcvideo: Implement UVC_EXT_GPIO_UNIT

2020-12-22 Thread Laurent Pinchart
On Tue, Dec 22, 2020 at 10:33:52AM +0200, Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Mon, Dec 21, 2020 at 05:48:14PM +0100, Ricardo Ribalda wrote: > > Some devices can implement a physical switch to disable the input of the > > camera on demand. Think of it like an

[PATCH] MIPS: loongson64: smp.c: Fix block comment coding style

2020-12-22 Thread siyanteng
From: siyanteng This patch fixes: "WARNING: Block comments use a trailing */ on a separate line" by checkpatch.pl Signed-off-by: siyanteng --- arch/mips/loongson64/smp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/mips/loongson64/smp.c

UBSAN: shift-out-of-bounds in kvm_vcpu_after_set_cpuid

2020-12-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5e60366d Merge tag 'fallthrough-fixes-clang-5.11-rc1' of g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11c7046b50 kernel config: https://syzkaller.appspot.com/x/.config?x=db720fe37a6a41d8

Re: [PATCH v9 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 04:10:54PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v9: > - add additionalProperties for "^soc@[0-9a-f]+$" > - add examples > Changes for v8: > -

Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 07:31:32AM +, Timon Baetz wrote: > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a > of_node set in the extcon driver. > > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure > the charger driver. > > Signed-off-by: Timon Baetz

Re: [v5,2/3] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2020-12-22 Thread Jianjun Wang
On Tue, 2020-12-22 at 11:55 +0800, Nicolas Boichat wrote: > On Tue, Dec 22, 2020 at 11:38 AM Jianjun Wang > wrote: > > > > On Mon, 2020-12-21 at 10:18 +0800, Nicolas Boichat wrote: > > > On Wed, Dec 2, 2020 at 9:39 PM Jianjun Wang > > > wrote: > > > > [snip] > > > > +static irq_hw_number_t

Re: [PATCH v3 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 07:31:40AM +, Timon Baetz wrote: > Register for extcon notification and set charging current depending on > the detected cable type. Current values are taken from vendor kernel, > where most charger types end up setting 650mA [0]. > > Also enable and disable the

Re: [PATCH v4 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

2020-12-22 Thread Geert Uytterhoeven
On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda wrote: > To remove mfd devices when unload this driver, should use > devm_mfd_add_devices() instead. > > Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") > Signed-off-by: Yoshihiro Shimoda > Acked-for-MFD-by: Lee Jones

Re: [RFC v2 PATCH 0/4] speed up page allocation for __GFP_ZERO

2020-12-22 Thread David Hildenbrand
On 21.12.20 17:25, Liang Li wrote: > The first version can be found at: https://lkml.org/lkml/2020/4/12/42 > > Zero out the page content usually happens when allocating pages with > the flag of __GFP_ZERO, this is a time consuming operation, it makes > the population of a large vma area very

Re: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

2020-12-22 Thread Geert Uytterhoeven
On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda wrote: > Use dev_regmap_add_irq_chip() to simplify the code. > > Signed-off-by: Yoshihiro Shimoda > Acked-for-MFD-by: Lee Jones Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

[PATCH] mmc: sdhci-msm: Fix possible NULL pointer exception

2020-12-22 Thread Md Sadre Alam
of_device_get_match_data returns NULL when no match. So add the NULL pointer check to avoid dereference. Signed-off-by: Md Sadre Alam --- drivers/mmc/host/sdhci-msm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index

Re: [RFC PATCH 3/3] mm: support free hugepage pre zero out

2020-12-22 Thread David Hildenbrand
On 22.12.20 09:31, David Hildenbrand wrote: > On 22.12.20 08:49, Liang Li wrote: >> This patch add support of pre zero out free hugepage, we can use >> this feature to speed up page population and page fault handing. >> >> Cc: Alexander Duyck >> Cc: Mel Gorman >> Cc: Andrea Arcangeli >> Cc: Dan

Re: [PATCH] usb: musb: add printf attribute to log function

2020-12-22 Thread Greg KH
On Mon, Dec 21, 2020 at 08:25:47AM -0800, t...@redhat.com wrote: > From: Tom Rix > > Attributing the function allows the compiler to more thoroughly > check the use of the function with -Wformat and similar flags. > > Signed-off-by: Tom Rix > --- > drivers/usb/musb/musb_debug.h | 1 + > 1

Re: [PATCH v5 12/12] media: uvcvideo: use dev_dbg() for uvc_trace()

2020-12-22 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Mon, Dec 21, 2020 at 05:48:19PM +0100, Ricardo Ribalda wrote: > Instead of calling prink() inside uvc_trace, use dev_dbg(), which add You're using dev_printk(KERN_DEBUG), which is right, but doesn't match the commit message. > context to the output. > >

Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2020-12-22 Thread Jagan Teki
On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > Engicam EDIMM2.2 Starter Kit

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Geert Uytterhoeven
Hi Shimoda-san, On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > The new PMIC BD9574MWF inherits features from BD9571MWV. > Add the support of new PMIC to existing bd9571mwv driver. > > Signed-off-by: Khiem Nguyen > Co-developed-by: Yoshihiro Shimoda >

Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote: > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski > > > wrote: > > > > > > > > On Mon, Dec 21,

Re: [PATCH v6 2/5] dt-bindings: media: max9286: Document 'maxim,reverse-channel-microvolt'

2020-12-22 Thread Jacopo Mondi
Hi Rob, Laurent, On Mon, Dec 21, 2020 at 11:58:27AM -0700, Rob Herring wrote: > On Wed, Dec 16, 2020 at 07:17:05PM +0200, Laurent Pinchart wrote: > > > > @@ -221,6 +241,7 @@ required: > > > >- ports > > > >- i2c-mux > > > >- gpio-controller > > > > + - maxim,reverse-channel-microvolt

general protection fault in ext4_commit_super

2020-12-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0d52778b Add linux-next specific files for 20201218 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15b4aecb50 kernel config: https://syzkaller.appspot.com/x/.config?x=5c81cc44aa25b5b3 dashboard

Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

2020-12-22 Thread Viresh Kumar
On Mon, 9 Nov 2020 at 16:51, Frank Lee wrote: > On Mon, Nov 9, 2020 at 1:53 PM Viresh Kumar wrote: > > > devm_pm_opp_set_supported_hw() > > > devm_pm_opp_set_regulators() [if we won't use GENPD] > > > devm_pm_opp_set_clkname() > > > devm_pm_opp_of_add_table() > > > > I tried to look earlier for

Re: [PATCH v2 13/48] opp: Add resource-managed versions of OPP API functions

2020-12-22 Thread Viresh Kumar
On 17-12-20, 21:06, Dmitry Osipenko wrote: > Add resource-managed versions of OPP API functions. This removes a need > from drivers to store and manage OPP table pointers. > > Signed-off-by: Dmitry Osipenko > --- > drivers/opp/core.c | 173 + >

Re: [PATCH 2/2] arm64: proper comment formatting in reboot handler

2020-12-22 Thread Geert Uytterhoeven
On Sat, Dec 19, 2020 at 3:38 PM Wolfram Sang wrote: > This comment was probably copied from arm32 and then shortened. It fits > to single line now. > > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH v2 14/48] opp: Filter out OPPs based on availability of a required-OPP

2020-12-22 Thread Viresh Kumar
On 17-12-20, 21:06, Dmitry Osipenko wrote: > A required OPP may not be available, and thus, all OPPs which are using > this required OPP should be unavailable too. > > Signed-off-by: Dmitry Osipenko > --- > drivers/opp/core.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-)

Re: [PATCH 1/5] dt-bindings: watchdog: renesas,wdt: add r8a779a0 (V3U) support

2020-12-22 Thread Geert Uytterhoeven
On Fri, Dec 18, 2020 at 6:37 PM Wolfram Sang wrote: > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical

Re: [PATCH v2 15/48] opp: Support set_opp() customization without requiring to use regulators

2020-12-22 Thread Viresh Kumar
On 17-12-20, 21:06, Dmitry Osipenko wrote: > Support set_opp() customization without requiring to use regulators. This > is needed by drivers which want to use dev_pm_opp_set_rate() for changing > rates of a multiple clocks and don't need to touch regulator. > > One example is NVIDIA Tegra30/114

Re: [PATCH 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2020-12-22 Thread Liu Ying
Hi Laurent, On Tue, 2020-12-22 at 09:36 +0200, Laurent Pinchart wrote: > Hi Liu, > > Thank you for the patch. > > On Thu, Dec 17, 2020 at 05:59:30PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). > > > > Signed-off-by: Liu Ying > > --- > >

Re: [PATCH 2/5] clk: renesas: r8a779a0: Add RWDT clocks

2020-12-22 Thread Geert Uytterhoeven
On Fri, Dec 18, 2020 at 6:37 PM Wolfram Sang wrote: > And introduce critical clocks, too, because RWDT is one. > > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-clk-for-v5.12. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

[RFC PATCH 1/1] net: arcnet: Fix RESET flag handling

2020-12-22 Thread Ahmed S. Darwish
The main arcnet interrupt handler calls arcnet_close() then arcnet_open(), if the RESET status flag is encountered. This is invalid: 1) In general, interrupt handlers should never call ->ndo_stop() and ->ndo_open() functions. They are usually full of blocking calls and other methods

[RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2020-12-22 Thread Ahmed S. Darwish
Folks, At drivers/net/arcnet/arcnet.c, there is: irqreturn_t arcnet_interrupt(int irq, void *dev_id) { ... if (status & RESETflag) { arcnet_close(dev); arcnet_open(dev); } ... } struct net_device_ops arcnet_netdev_ops = {

Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2020-12-22 Thread Jagan Teki
On Tue, Dec 22, 2020 at 2:23 PM Krzysztof Kozlowski wrote: > > On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote: > > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > > > > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > > > On Mon, Dec 21, 2020 at 7:36

Re: Correct ordering of phy_init and phy_power_on

2020-12-22 Thread Ahmad Fatoum
Hello Kishon, On 21.12.20 04:15, Kishon Vijay Abraham I wrote: >> So how was it meant to be? > > It is intended to be ->init() and then ->power_on(). So ideally it > should be the way dwc3 is. Thanks. Should we do something about the inconsistency? Amend documentation and maybe print a warning

Re: [PATCH v4 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

2020-12-22 Thread Vaittinen, Matti
On Tue, 2020-12-22 at 09:41 +0100, Geert Uytterhoeven wrote: > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda > wrote: > > To remove mfd devices when unload this driver, should use > > devm_mfd_add_devices() instead. > > > > Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") >

[PATCH] kernel/cpu: fix: use scnprintf or sprintf.

2020-12-22 Thread YANG LI
The snprintf() function returns the number of characters which would have been printed if there were enough space, but the scnprintf() returns the number of characters which were actually printed. If the buffer is not large enough, then using snprintf() would result in a read overflow and an

Re: [RFC 1/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory

2020-12-22 Thread David Hildenbrand
On 22.12.20 08:12, Anshuman Khandual wrote: > pfn_valid() validates a pfn but basically it checks for a valid struct page > backing for that pfn. It should always return positive for memory ranges > backed with struct page mapping. But currently pfn_valid() fails for all > ZONE_DEVICE based memory

v5.10: sched_cpu_dying() hits BUG_ON during hibernation: kernel BUG at kernel/sched/core.c:7596!

2020-12-22 Thread Dexuan Cui
Hi, I'm running a Linux VM with the recent mainline (48342fc07272, 12/20/2020) on Hyper-V. When I test hibernation, the VM can easily hit the below BUG_ON during the resume procedure (I estimate this can repro about 1/5 of the time). BTW, my VM has 40 vCPUs. I can't repro the BUG_ON with

Re: [PATCH v2 44/48] ARM: tegra: Add OPP tables and power domains to Tegra30 device-tree

2020-12-22 Thread Viresh Kumar
On 17-12-20, 21:06, Dmitry Osipenko wrote: > diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > index cbe84d25e726..983db1a06682 100644 > --- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi > +++

Re: [PATCH 3/5] arm64: dts: renesas: r8a779a0: Add RWDT node

2020-12-22 Thread Geert Uytterhoeven
On Fri, Dec 18, 2020 at 6:37 PM Wolfram Sang wrote: > From: Hoang Vo > > Add a device node for the Watchdog Timer (WDT) controller on the > R8A779A0 SoC. > > Signed-off-by: Hoang Vo > [wsa: rebased to mainline] > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven i.e. will queue in

Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable

2020-12-22 Thread Viresh Kumar
On 17-12-20, 21:06, Dmitry Osipenko wrote: > Fix adding OPP entries in a wrong (opposite) order if OPP rate is > unavailable. The OPP comparison is erroneously skipped if OPP rate is > missing, thus OPPs are left unsorted. > > Signed-off-by: Dmitry Osipenko > --- > drivers/opp/core.c | 23

Re: [PATCH 4/5] arm64: dts: renesas: falcon: Enable watchdog timer

2020-12-22 Thread Geert Uytterhoeven
On Fri, Dec 18, 2020 at 6:37 PM Wolfram Sang wrote: > From: Hoang Vo > > Enable the watchdog on the Falcon board. > > Signed-off-by: Hoang Vo > [wsa: rebased to mainline] > Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.12.

Re: [PATCH 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2020-12-22 Thread Liu Ying
Hi, On Tue, 2020-12-22 at 09:09 +0200, Laurent Pinchart wrote: > Hi Liu, > > Thank you for the patch. > > On Thu, Dec 17, 2020 at 05:59:25PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp display pixel link. > > > > Signed-off-by: Liu Ying > > --- > >

Re: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

2020-12-22 Thread Vaittinen, Matti
On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote: > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda > wrote: > > Use dev_regmap_add_irq_chip() to simplify the code. > > > > Signed-off-by: Yoshihiro Shimoda > > Acked-for-MFD-by: Lee Jones > > Reviewed-by: Geert Uytterhoeven

Re: [PATCH v2 00/48] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-22 Thread Viresh Kumar
On 18-12-20, 16:51, Dmitry Osipenko wrote: > Alright, although I haven't pretended that v2 patches should be merged > right away since they are fundamentally different from v1, and thus, all > patches need to be reviewed first. I agree. I have done some basic review for the stuff. > If the

Re: [PATCH 3/5] arm64: dts: renesas: r8a779a0: Add RWDT node

2020-12-22 Thread Wolfram Sang
> No interrupts property? ;-) > As we don't have it described yet for the other R-Car Gen3 SoCs, I > suggest we do that in one batch... Yes, I'll try to find some time for this as a seperate series. signature.asc Description: PGP signature

Re: [PATCH 5/5] WIP soc: v3u: allow WDT reset

2020-12-22 Thread Geert Uytterhoeven
On Fri, Dec 18, 2020 at 6:37 PM Wolfram Sang wrote: > Other Gen3 SoCs do this in the bootloader. Maybe V3U will also later? > For now, add it so we can properly reboot via remote. > > Not to be applied yet, just for demonstration. Agreed. > Signed-off-by: Wolfram Sang Reviewed-by: Geert

RE: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-22 Thread David Laight
From: Song Bao Hua > Sent: 21 December 2020 23:02 ... > > For decompression, I would like as low latency as possible which I > > think is only possible by doing decompression on a cpu synchronously. > > One possibility is that we change HW accelerator driver to be sync > polling for

Re: [PATCH] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-22 Thread Pali Rohár
On Tuesday 22 December 2020 02:14:45 Peter Chen wrote: > On 20-12-21 16:09:03, Pali Rohár wrote: > > Currently init_quirk callbacks for xhci platform drivers are called > > xhci_plat_setup() function which is called after chip reset completes. > > It happens in the middle of the usb_add_hcd()

RE: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > wrote: > > --- a/drivers/mfd/bd9571mwv.c > > +++ b/drivers/mfd/bd9571mwv.c > > > @@ -200,12 +277,14 @@ static int

Re: [PATCH] dt-bindings: Drop unnecessary *-supply schemas properties

2020-12-22 Thread Sakari Ailus
Hi Rob, On Mon, Dec 21, 2020 at 04:46:59PM -0700, Rob Herring wrote: > *-supply properties are always a single phandle, so binding schemas > don't need a type $ref nor 'maxItems'. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Jonathan Cameron > Cc:

Re: [PATCH] power: supply: bq27xxx: Supporrt CHARGE_NOW for bq27z561/bq28z610/bq34z100

2020-12-22 Thread Pali Rohár
On Tuesday 22 December 2020 03:44:09 Hermes Zhang wrote: > On 12/18/20 5:42 PM, Pali Rohár wrote: > > On Thursday 17 December 2020 12:03:24 Hermes Zhang wrote: > >> Hi Pali, > >> > >> From the TI spec (e.g. > >>

RE: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

2020-12-22 Thread Yoshihiro Shimoda
Hi Matti-san, > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM > > On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote: > > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda > > wrote: > > > Use dev_regmap_add_irq_chip() to simplify the code. > > > > > > Signed-off-by:

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Dec 22, 2020 at 10:23 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > > wrote: > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b/drivers/mfd/bd9571mwv.c > > > > >

[RFC PATCH v3 5/5] arm64: dts: mt8192: add SSUSB related nodes

2020-12-22 Thread Chunfeng Yun
From: Zhanyong Wang Add SSUSB related nodes for mt8192 Signed-off-by: Zhanyong Wang Signed-off-by: Chunfeng Yun --- v3: rename node as 'usb' instead of xhci v2: include phy.h file Depends on: https://patchwork.kernel.org/patch/11713559/ [v4,1/3] arm64: dts: Add Mediatek SoC MT8192 and

[RFC PATCH v3 4/5] usb: xhci-mtk: add support runtime pm

2020-12-22 Thread Chunfeng Yun
From: CK Hu add support runtime pm feature Signed-off-by: Zhanyong Wang Signed-off-by: Chunfeng Yun --- v3: 1. fix some issues 2. remove attribute files v2: fix error caused by request irq suggested by CK --- drivers/usb/host/xhci-mtk.c | 285 +++-

[RFC PATCH v3 2/5] usb: xhci-mtk: add mt8192 wakeup

2020-12-22 Thread Chunfeng Yun
From: Zhanyong Wang need to add wakeup solution as V3 since not support presently. Signed-off-by: Zhanyong Wang Signed-off-by: Chunfeng Yun --- v2~v3: no changes --- drivers/usb/host/xhci-mtk.c | 9 + 1 file changed, 9 insertions(+) mode change 100644 => 100755

[RFC PATCH v3 3/5] usb: xhci-mtk: fix random remote wakeup

2020-12-22 Thread Chunfeng Yun
Wakeup_signal will toggle status according to ssusb_ip_sleep signal after debounc time, add a delay time to avoid spurious wakeup event. Signed-off-by: Chunfeng Yun --- v3: new patch --- drivers/usb/host/xhci-mtk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[RFC PATCH v3 1/5] usb: xhci-mtk: improve bandwidth scheduling with multi-TT

2020-12-22 Thread Chunfeng Yun
From: Zhanyong Wang After inserted the usb type-c 3.5mm dongle with headset, dmesg showed: usb 1-1.1: new full-speed USB device number 5 using xhci-mtk usb 1-1.1: New USB device found, idVendor=05ac, idProduct=110a, bcdDevice=26.11 usb 1-1.1: New USB device strings: Mfr=1, Product=2,

RE: [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi()

2020-12-22 Thread David Laight
From: Palmer Dabbelt > Sent: 22 December 2020 05:33 > > From: Palmer Dabbelt > > This cast loses the __iomem qualifier from clint_timer_val, which > triggers an sparse warning. > > Reported-by: kernel test robot > Signed-off-by: Palmer Dabbelt > --- > drivers/clocksource/timer-clint.c | 2

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-22 Thread Nadav Amit
> On Dec 21, 2020, at 7:19 PM, Andy Lutomirski wrote: > > On Mon, Dec 21, 2020 at 3:22 PM Linus Torvalds > wrote: >> On Mon, Dec 21, 2020 at 2:30 PM Peter Xu wrote: >>> AFAIU mprotect() is the only one who modifies the pte using the mmap write >>> lock. NUMA balancing is also using read mmap

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Vaittinen, Matti
On Tue, 2020-12-22 at 09:23 +, Yoshihiro Shimoda wrote: > Hi Geert-san, > > Thank you for your review! > > > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > > wrote: > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++

Re: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

2020-12-22 Thread Vaittinen, Matti
On Tue, 2020-12-22 at 09:25 +, Yoshihiro Shimoda wrote: > Hi Matti-san, > > > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM > > > > On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda > > > wrote: > > > >

Re: [KVM] fdd90b978b: WARNING:suspicious_RCU_usage

2020-12-22 Thread David Woodhouse
On Tue, 2020-12-22 at 13:06 +0800, kernel test robot wrote: > > kern :warn : [ 86.138096] WARNING: suspicious RCU usage > kern :warn : [ 86.142286] 5.10.0-rc5-gfdd90b978b4e #1 Tainted: G > I > kern :warn : [ 86.148879] - > kern :warn : [

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-22 Thread Vitaly Wool
On Tue, 22 Dec 2020, 03:11 Song Bao Hua (Barry Song), wrote: > > > > > -Original Message- > > From: Song Bao Hua (Barry Song) > > Sent: Tuesday, December 22, 2020 3:03 PM > > To: 'Vitaly Wool' > > Cc: Shakeel Butt ; Minchan Kim ; > > Mike > > Galbraith ; LKML ; linux-mm > > ; Sebastian

Re: [RFC PATCH v2 3/8] net: sparx5: add hostmode with phylink support

2020-12-22 Thread Steen Hegelund
Hi Andrew, On Sat, 2020-12-19 at 20:51 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > > + /* Create a phylink for PHY management.  Also handles SFPs */ > > + spx5_port->phylink_config.dev = _port->ndev->dev; >

[PATCH v5 1/2] lib/string.c: add __sysfs_match_string_with_gaps() helper

2020-12-22 Thread Alexandru Ardelean
The original docstring of the __sysfs_match_string() and match_string() helper, implied that -1 could be used to search through NULL terminated arrays, and positive 'n' can be used to go through arrays that may have NULL elements in the middle of the array. This isn't true. Regardless of the

[PATCH v5 2/2] iio: Handle enumerated properties with gaps

2020-12-22 Thread Alexandru Ardelean
From: Lars-Peter Clausen Some enums might have gaps or reserved values in the middle of their value range. E.g. consider a 2-bit enum where the values 0, 1 and 3 have a meaning, but 2 is a reserved value and can not be used. Add support for such enums to the IIO enum helper functions. A

Re: [PATCH 07/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2020-12-22 Thread Liu Ying
On Mon, 2020-12-21 at 15:29 -0700, Rob Herring wrote: > On Thu, Dec 17, 2020 at 05:59:26PM +0800, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm/qxp display pixel link. > > The pixel link forms a standard asynchronous linkage between > > pixel sources(display controller or

Re: [PATCH] arm64: defconfig: Make INTERCONNECT_QCOM_SDM845 builtin

2020-12-22 Thread Georgi Djakov
On 12/22/20 06:37, Bjorn Andersson wrote: As of v5.11-rc1 the QUP nodes of SDM845 has got their interconnect properties specified, this means that the relevant interconnect provider needs to be builtin for the UART device to probe and the console to be registered before userspace needs to access

Re: [PATCH] usb: musb: add printf attribute to log function

2020-12-22 Thread Joe Perches
On Tue, 2020-12-22 at 09:52 +0100, Greg KH wrote: > On Mon, Dec 21, 2020 at 08:25:47AM -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > Attributing the function allows the compiler to more thoroughly > > check the use of the function with -Wformat and similar flags. > > > >

Re: [PATCH 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2020-12-22 Thread Liu Ying
On Thu, 2020-12-17 at 17:59 +0800, Liu Ying wrote: > This patch adds a drm bridge driver for i.MX8qxp LVDS display bridge(LDB). > The LDB has two channels. Each of them supports up to 24bpp parallel > input color format and can map the input to VESA or JEIDA standards. > The two channels cannot

Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell

2020-12-22 Thread Lee Jones
On Tue, 22 Dec 2020, Timon Baetz wrote: > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a > of_node set in the extcon driver. > > Add of_compatible ("maxim,max8997-battery") to the mfd_cell to configure > the charger driver. > > Signed-off-by: Timon Baetz > --- >

[PATCH v4 0/5] MSFT offloading support for advertisement monitor

2020-12-22 Thread Archie Pusaka
From: Archie Pusaka Hi linux-bluetooth, This series of patches manages the hardware offloading part of MSFT extension API. The full documentation can be accessed by this link:

[PATCH v4 1/5] Bluetooth: advmon offload MSFT add rssi support

2020-12-22 Thread Archie Pusaka
From: Archie Pusaka MSFT needs rssi parameter for monitoring advertisement packet, therefore we should supply them from mgmt. This adds a new opcode to add advertisement monitor with rssi parameters. Signed-off-by: Archie Pusaka Reviewed-by: Manish Mandlik Reviewed-by: Miao-chen Chou

[PATCH v4 2/5] Bluetooth: advmon offload MSFT add monitor

2020-12-22 Thread Archie Pusaka
From: Archie Pusaka Enables advertising monitor offloading to the controller, if MSFT extension is supported. The kernel won't adjust the monitor parameters to match what the controller supports - that is the user space's responsibility. This patch only manages the addition of monitors. Monitor

[PATCH v4 3/5] Bluetooth: advmon offload MSFT remove monitor

2020-12-22 Thread Archie Pusaka
From: Archie Pusaka Implements the monitor removal functionality for advertising monitor offloading to MSFT controllers. Supply handle = 0 to remove all monitors. Signed-off-by: Archie Pusaka Reviewed-by: Miao-chen Chou Reviewed-by: Yun-Hao Chung Reported-by: kernel test robot Reported-by:

[PATCH v4 4/5] Bluetooth: advmon offload MSFT handle controller reset

2020-12-22 Thread Archie Pusaka
From: Archie Pusaka When the controller is powered off, the registered advertising monitor is removed from the controller. This patch handles the re-registration of those monitors when the power is on. Signed-off-by: Archie Pusaka Reviewed-by: Miao-chen Chou Reviewed-by: Yun-Hao Chung ---

[PATCH v4 5/5] Bluetooth: advmon offload MSFT handle filter enablement

2020-12-22 Thread Archie Pusaka
From: Archie Pusaka Implements the feature to disable/enable the filter used for advertising monitor on MSFT controller, effectively have the same effect as "remove all monitors" and "add all previously removed monitors". This feature would be needed when suspending, where we would not want to

Re: [PATCH] dt-bindings: Drop unnecessary *-supply schemas properties

2020-12-22 Thread Lee Jones
On Mon, 21 Dec 2020, Rob Herring wrote: > *-supply properties are always a single phandle, so binding schemas > don't need a type $ref nor 'maxItems'. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Jonathan Cameron > Cc: Dmitry Torokhov > Cc:

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-22 Thread Kirill A. Shutemov
On Sat, Dec 19, 2020 at 12:34:17PM -0800, Linus Torvalds wrote: > On Sat, Dec 19, 2020 at 4:41 AM Kirill A. Shutemov > wrote: > > > > @@ -2884,19 +2966,18 @@ void filemap_map_pages(struct vm_fault *vmf, > > if (vmf->pte) > > vmf->pte += xas.xa_index -

  1   2   3   4   5   6   7   8   9   10   >