(err) {
> + ret = dma_set_max_seg_size(base->dev, STEDMA40_MAX_SEG_SIZE);
> + if (ret) {
> d40_err(&pdev->dev, "Failed to set dma max seg size\n");
> goto failure;
> }
>
> --
> To unsubscribe from this list: send the line
from drivers/mfd/tps65912-core.c:21:
> include/linux/device.h:574:14: note: expected ‘struct device *’ but argument
> is of type ‘struct device **’
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
esses; i++)
> if (at24->client[i])
> i2c_unregister_device(at24->client[i]);
> -
No need to remove this empty line.
> @@ -666,9 +653,6 @@ static int at24_remove(struct i2c_client *client)
>
> for (i = 1; i < at24->num_address
On Tue, May 28, 2013 at 11:00 PM, Nikolay Balandin
wrote:
> From: Nikolay Balandin
>
> Use devm_kzalloc to make cleanup paths simpler
>
> Signed-off-by: Nikolay Balandin
Reviewed-by: Andy Shevchenko
> ---
> drivers/misc
On Tue, May 28, 2013 at 11:01 PM, Nikolay Balandin
wrote:
> From: Nikolay Balandin
>
> Use devm_kzalloc to make cleanup paths simpler
>
> Signed-off-by: Nikolay Balandin
Reviewed-by: Andy Shevchenko
> ---
> drivers/misc/eeprom/at25.c | 25 -
a_controller_free().
Usually, the driver uses only devm_acpi_dma_controller_register().
Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
Acked-by: Rafael J. Wysocki
---
Documentation/acpi/enumeration.txt | 77 ++
drivers/dma/Kconfig| 4 +
drivers/dma/Make
Since we have proper ACPI DMA helpers implemented, the driver may use it. This
patch introduces custom filter function together with acpi_device_id table.
Signed-off-by: Mika Westerberg
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 68
The slave device could be enumerated by ACPI. In that case the
dma_request_slave_channel should use the acpi_dma_request_slave_channel()
helper.
Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
Acked-by: Rafael J. Wysocki
---
drivers/dma/dmaengine.c | 6 ++
1 file changed, 6
In Lynxpoint we have to enable clock per each LPSS device. That's why we have
to enumerate them from drivers/acpi/acpi_lpss.c. The DMA controller is one of
such devices.
Signed-off-by: Andy Shevchenko
---
drivers/acpi/acpi_lpss.c | 7 +++
drivers/clk/x86/clk-lpt.c | 2 +-
2 files ch
There is a patch series which introduces ACPI DMA helpers in similar way like
we have for DeviceTree.
In addition it applies this to the first user, namely dw_dmac driver.
Andy Shevchenko (6):
dma: acpi-dma: introduce ACPI DMA helpers
dmaengine: call acpi_dma_request_slave_channel as well
When device uses the fixed clock and has no private space of LTR, we have to
create main LPSS clock and register platform device. This is normally a case
for LPSS DMA controller.
Signed-off-by: Andy Shevchenko
---
drivers/acpi/acpi_lpss.c | 4
1 file changed, 4 insertions(+)
diff --git a
Since we have CSRT only to get additional DMA controller resources, let's get
rid of drivers/acpi/csrt.c and move its logic inside ACPI DMA helpers code.
Signed-off-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
Acked-by: Rafael J. Wysocki
---
drivers/acpi/Makefile| 1 -
dr
offset = xbar_chans[i][1] >> 2;
> + offset <<= 2;
Is it offset = xbar_chans[i][1] & 0xfffc; ?
> + mux = readl((void *)((u32)xbar + offset));
> + mux &= ~(0xff << shift);
> + mux |= xbar_chans[i][0] &
Oh, missed Cc list in the middle. Return it back and thus leave a full
message below.
On Thu, Mar 7, 2013 at 8:11 AM, Vinod Koul wrote:
> On Wed, Mar 06, 2013 at 05:53:20PM +0200, Andy Shevchenko wrote:
>> >> > How do you terminate a test? Esp if you have started
On Tue, 2013-03-05 at 17:16 +0800, Viresh Kumar wrote:
> On 4 March 2013 17:09, Andy Shevchenko
> wrote:
> > Better to keep test parameters separate from internal variables.
> >
> > Signed-off-by: Andy Shevchenko
> > ---
&g
On Thu, 2013-03-07 at 11:50 +0530, Vinod Koul wrote:
> On Mon, Mar 04, 2013 at 11:09:24AM +0200, Andy Shevchenko wrote:
> > The first approach to get dmatest module more flexible and easier to play
> > with.
> > The amount of patches could be reduced, but I would like to get
On Sun, Mar 10, 2013 at 3:44 PM, Viresh Kumar wrote:
> On 8 March 2013 21:11, Andy Shevchenko
> wrote:
>> On Thu, 2013-03-07 at 11:50 +0530, Vinod Koul wrote:
>>> On Mon, Mar 04, 2013 at 11:09:24AM +0200, Andy Shevchenko wrote:
>>> > The first approach to get
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 832538c..75ab5af 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -208,7 +208,7 @@ static inline
Not all of the controllers support the 64 bit data width. Make it configurable
via platform data. The driver will try to get a value from the component
parameters, otherwise it will use the platform data..
Signed-off-by: Andy Shevchenko
---
arch/arm/mach-spear13xx/spear13xx.c |2 ++
arch
In case the controller has the encoded parameters feature enabled the driver
will use it to get the number of channels. In the future it will be used for
the other important parameters as well.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 33
The maximum block size is a configurable parameter for the chip. So, driver
will try to get it from the encoded component parameters. Otherwise it will
come from the platform data.
Signed-off-by: Andy Shevchenko
---
arch/arm/mach-spear13xx/spear13xx.c |1 +
arch/avr32/mach-at32ap
Some controllers have the reduced functionality where the LLP multi block
transfers are not supported. This patch introduces a support of such
controllers. In case of memory copy or scatter-gather lists it emulates LLP
transfers via bunch of the regular single block ones.
Signed-off-by: Andy
Some controllers have the reduced functionality where the LLP multi block
transfers are not supported. This patch introduces a check and refuses to deal
with such devices.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 35 ++-
drivers/dma
transfers. It means that
normal linked list transfer is substituted by set of single block transfers
transparently to the user.
Comments are welcome.
Andy Shevchenko (7):
dw_dmac: mark dwc_dump_chan_regs as inline
dw_dmac: fill optional encoded parameters in register structure
dw_dmac: get number of
There is a block of the registers that are optional. However, if enabled they
contain useful information about the controller hardware configuration. We will
use this piece of data to autoconfigure the driver.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac_regs.h | 19
setof(struct dw_dma_regs, name))
> > +
>
> But why don't you use earlier defined readl/writel macros:
> dma_readl and dma_writel?
If you look at further patches, namely 3rd, the access to the register
is needed before we allocate memory for the dw_dma structure.
--
Andy Shevchenko
On Tue, 2012-09-18 at 13:29 +0530, viresh kumar wrote:
> On Tue, Sep 18, 2012 at 12:25 PM, Andy Shevchenko
> wrote:
> >> > +#define dma_raw_readl(addr, name) \
> >> > + readl((addr) + offsetof(struct dw_dma_regs, name))
> >> > +
>
On Tue, 2012-09-18 at 12:20 +0530, viresh kumar wrote:
> On Mon, Sep 17, 2012 at 1:09 PM, Andy Shevchenko
> wrote:
> > In case the controller has the encoded parameters feature enabled the driver
> > will use it to get the number of channels. In the future it will be used
> > + unsigned short block_size;
> > +
>
> You actually don't save any memory here with short and actually makes access
> to block_size more complex. keeping it int would be better i believe.
I rather agree with you. I'll change it.
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, 2012-09-18 at 12:41 +0530, viresh kumar wrote:
> On Mon, Sep 17, 2012 at 1:09 PM, Andy Shevchenko
> wrote:
> > @@ -647,7 +657,11 @@ dwc_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t
> > dest, dma_addr_t src,
> > return NULL;
> >
On Tue, 2012-09-18 at 12:47 +0530, viresh kumar wrote:
> On Mon, Sep 17, 2012 at 1:09 PM, Andy Shevchenko
> wrote:
> > @@ -555,8 +594,36 @@ static void dw_dma_tasklet(unsigned long data)
> > dwc_handle_cyclic(dw, dwc, status_err, status_xfer);
> >
On Tue, 2012-09-18 at 12:43 +0530, viresh kumar wrote:
> On Mon, Sep 17, 2012 at 1:09 PM, Andy Shevchenko
> wrote:
> > Some controllers have the reduced functionality where the LLP multi block
> > transfers are not supported. This patch introduces a check and refuses to
>
On Tue, 2012-09-18 at 14:11 +0800, Hein Tibosch wrote:
> On 9/17/2012 3:39 PM, Andy Shevchenko wrote:
> > Here is a patchset that allows to adapt the driver to the hardware
> > configuration during probe time. The hardware should have the specific
> > optional
> > pa
On Thu, Sep 20, 2012 at 12:32 PM, viresh kumar wrote:
> On Thu, Sep 20, 2012 at 3:00 PM, Andy Shevchenko
> wrote:
>>> Ok. If i am not wrong, such calls are only required once for below line:
>> Actually twice...
>>> dw_params = dma_raw_readl(regs, DW_PARAMS
>>
On Thu, Sep 20, 2012 at 12:46 PM, viresh kumar wrote:
> On Thu, Sep 20, 2012 at 3:12 PM, Andy Shevchenko
> wrote:
>>> Do these changes in a single patch 2/7
>> From this comment I guess you would like to have dw_dmac_regs.h changes
>> at one place. Am I right?
>
&
Hi!
The Sequans company who produce WiMAX chips provides the USB driver and kthp
addon driver. However the USB device doesn't work correctly.
Here is more true hack for Sequans SQN11x0 based modem.
P.S. For more details, please, ask Sequans staff (see Signed-off-by lines).
Signed-off-by:
Use devm_kzalloc, devm_clk_get, devm_request_irq, and devm_request_and_ioremap
to reduce the code and to simplify the error path.
Signed-off-by: Andy Shevchenko
Cc: Viresh Kumar
---
drivers/dma/dw_dmac.c | 53 +---
drivers/dma/dw_dmac_regs.h
Signed-off-by: Andy Shevchenko
Cc: Arnaldo Carvalho de Melo
---
tools/perf/util/symbol.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 50958bb..b0c8c8a 100644
--- a/tools/perf/util/symbol.c
Use 'u32' for the LLI structure members, which are defined by hardware to be
32-bit. dma_addr_t is much more vague about its actual size.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |7 ++-
drivers/dma/dw_dmac_regs.h |6 +++---
2 files changed, 5 insert
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 9151511..db56ef4 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -413,7 +413,7 @@ static void
The default values are filled to support at least mem-to-mem tests provided by
dmatest module. It makes sense to choose the 4 bytes (2 least significant bits)
alignment by the default.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |6 ++
1 file changed, 6 insertions(+)
diff
t does this mean? We will not support
> transfers with unaligned
> addresses/length to word size?
The dmatest module uses those constants to get source, destination
addresses and length of the test data aligned. On the other hand we
can't use unaligned address in LLI because of t
ill in my pool.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Jul 13, 2012 at 1:30 PM, viresh kumar wrote:
> Sorry, got confused now. What works without this patch? And what doesn't work
> without it?
It seems this patch is redundant.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscr
It will be useful to have the length of the transfer in the descriptor. The
cyclic transfer functions remained untouched.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index
field in the descriptor
structure is left untouched by the original code.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 93 -
1 file changed, 92 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
On Mon, 2013-01-21 at 00:49 -0800, Vinod Koul wrote:
> On Mon, Jan 21, 2013 at 11:00:44AM +0200, Andy Shevchenko wrote:
> > Currently the driver returns full length of the active descriptor which is
> > wrong. We have to go throught the active descriptor and sum up the lengt
_base + SSDR;
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the F
On Mon, 2013-01-21 at 06:22 -0800, Vinod Koul wrote:
> On Mon, Jan 21, 2013 at 11:45:51AM +0200, Andy Shevchenko wrote:
> > > > + return 0;
> > > hmmm, why not use BLOCK_TS value. That way you dont need to look at
> > > direction
> > > and alo
+ return number(buf, end,
> + (unsigned long long) *((phys_addr_t *)ptr), spec);
> }
> spec.flags |= SMALL;
> if (spec.field_width == -1) {
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
>
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, 2013-01-22 at 13:41 +0530, Viresh Kumar wrote:
> On Mon, Jan 21, 2013 at 2:30 PM, Andy Shevchenko
> wrote:
> > Currently the driver returns full length of the active descriptor which is
> > wrong. We have to go throught the active descriptor and sum up the length of
&
On Tue, 2013-01-22 at 15:10 +0530, Viresh Kumar wrote:
> On 22 January 2013 14:52, Andy Shevchenko
> wrote:
> > On Tue, 2013-01-22 at 13:41 +0530, Viresh Kumar wrote:
> >> > + spin_lock_irqsave(&dwc->lock, flags);
> >> > + if (list_empty(&am
On Wed, Jan 23, 2013 at 11:22 AM, Viresh Kumar wrote:
> On 23 January 2013 14:42, Andy Shevchenko
> wrote:
>> Yesterday I spent in testing of different approaches. First of all, the
>> calculation of the sent amount is nicer when ctlhi/ctllo is used and it
>> works fine
On Wed, Jan 23, 2013 at 11:51 AM, Viresh Kumar wrote:
> On 23 January 2013 15:06, Andy Shevchenko wrote:
>> On Wed, Jan 23, 2013 at 11:22 AM, Viresh Kumar
>> wrote:
>>> Second to solve your problem, you can add another field here: total_len.
>>> I know it wi
On Wed, 2013-01-23 at 15:54 +0530, Viresh Kumar wrote:
> On 23 January 2013 15:50, Andy Shevchenko wrote:
> > What about to calc len every time from lli.* instead of keeping it in
> > the len field of the descriptor?
>
> That's even bad.. we spend time on something
by this patch due to len field in the descriptor
structure is left untouched by the original code.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 53 ++--
drivers/dma/dw_dmac_regs.h |1 +
2 files changed, 52 insertions(+), 2 deletions
It will be useful to have the length of the transfer in the descriptor. The
cyclic transfer functions remained untouched.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma
The patch series is targeted for getting proper residue value.
Since v1:
- everything is rewritten to address Viresh's and Vinod's comments.
Andy Shevchenko (4):
dw_dmac: remove unnecessary tx_list field in dw_dma_chan
dw_dmac: introduce total_len field in struct dw_desc
dw_
By this new field we distinguish a total length of the chain and the individual
length of each descriptor in the chain.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 12 ++--
drivers/dma/dw_dmac_regs.h |1 +
2 files changed, 7 insertions(+), 6 deletions(-)
diff
The soft LLP mode is working for active descriptor only. So, we do not need to
have a copy of its pointer.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c | 17 -
drivers/dma/dw_dmac_regs.h |1 -
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a
In some cases we got the device without dma_mask configured. We have to apply
the default value to avoid crashes during memory mapping.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
---
Since v1:
- rebased on top of recent next branch from Vinod
drivers/dma/dw_dmac.c |6 ++
1
When status is DMA_SUCCESS the residue should be zero. Otherwise it's a bug.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
Cc: Linus Walleij
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/dma/coh901318.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --
There is no need to assign 0 to residue, because dma_cookie_status() does this
for us.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
Acked-by: Laxman Dewangan
---
drivers/dma/tegra20-apb-dma.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b
This is a patcset of independent fixes of the DMAC drivers. They are simple and
being understandable in their context.
Since v1:
- address all comments
- add ACKs
- rebase on top of recent Vinod's next branch
Andy Shevchenko (6):
dma: of-dma: protect list write operation by spin
dmaengine_device_control returns -ENOSYS in case the dma driver doesn't have
such functionality.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
---
include/linux/dmaengine.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/dmaengine.h b/in
Accordingly to commentary in the platform_device_register_full the memory
allocated for dma_mask will not going to be freed. That's why is better to
assign dma_mask afterwards.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
---
drivers/dma/edma.c |6 --
1 file chang
In case the len is 0 we must return without trying to unlock the lock that was
not locked.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
Cc: Linus Walleij
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/dma/coh901318_lli.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
It's possible to have an inconsistency in the list due to unprotected operation
on it. The patch adds a proper locking on the list operation.
Signed-off-by: Andy Shevchenko
Acked-by: Rob Herring
Acked-by: Viresh Kumar
---
drivers/dma/of-dma.c |2 ++
1 file changed, 2 insertions(+)
On Fri, Feb 15, 2013 at 4:52 PM, Linus Walleij wrote:
> On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko
> wrote:
>
>> I have not checked the code but there is a possibility that custom pool->lock
>> is not needed at all due to dma_pool contains it's own lock.
switch to new one.
That's what I afraid of. Better to try to avoid any excessive
requirement to the existing userspace.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vge
ntreq;
Could you use here full name like "request_line"? And I think the
better place for it in subsection "hardware configuration" (consider
non-DT cases of use).
> /* backlink to dw_dma */
> struct dw_dma *dw;
> };
We should not have this in linux-next. Are you sure you rebased it on
top of recent one?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sat, Feb 16, 2013 at 4:00 PM, Arnd Bergmann wrote:
> On Saturday 16 February 2013, Andy Shevchenko wrote:
>> On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann wrote:
>> > + if (WARN_ON(fargs.req >= 16 || fargs.src >= 2 || fargs.dst >= 2))
>> > +
e generic DMA binding, as well as the earlier attempt from
> Viresh. Both of these are currently not merged upstream however.
>
> This version incorporates feedback from Viresh Kumar, Andy Shevchenko
> and Russell King.
Sorry, few comments below.
After addressing them take my Acked
@sd_count: count of slave data structures passed.
> */
> struct dw_dma_platform_data {
> unsigned intnr_channels;
> @@ -38,6 +60,9 @@ struct dw_dma_platform_data {
> unsigned short block_size;
> unsigned char nr_masters;
> unsigned char data_widt
On Fri, Oct 12, 2012 at 11:34 AM, Viresh Kumar wrote:
> On 12 October 2012 13:53, Andy Shevchenko
> wrote:
>> On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
>>> diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt
>>> b/Documentation/device
On Fri, Oct 12, 2012 at 1:36 PM, viresh kumar wrote:
> On Fri, Oct 12, 2012 at 1:53 PM, Andy Shevchenko
> wrote:
>> On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
>
>>> + while (++i < dw->sd_count) {
>>> +
On Fri, Oct 12, 2012 at 2:01 PM, Viresh Kumar wrote:
> On 12 October 2012 16:10, Andy Shevchenko wrote:
>>>>> + if (!found) {
>>>>> + last_dw = dw;
>>>>> + last_bus_id = param;
>>>>> + retur
property_read_u32(cn, "dst_master", &val))
> + sd[count].dst_master = (u8)val;
ditto
> +
> + sd[count].dma_dev = &pdev->dev;
> + count++;
> + }
what about to define sd as sd[0]; in the platform_data structure
> dw->chan[i].initialized = false;
> }
>
> +#ifdef CONFIG_OF
> +static struct dw_dma_platform_data *
> +__devinit dw_dma_parse_dt(struct platform_device *pdev)
> +{
> + struct device_node *sn, *cn, *np = pdev->dev.of_node;
> + struct dw_dma_platform_da
On Fri, Oct 12, 2012 at 6:18 PM, Viresh Kumar wrote:
> On 12 October 2012 20:28, Andy Shevchenko
> wrote:
>> On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
>
>>> + if (last_dw) {
>>> + if ((last_bus_id == param) && (last_dw == dw
t dw_dma_chan *to_dw_dma_chan(struct dma_chan *chan)
> {
> @@ -246,9 +254,9 @@ static inline struct dw_dma_regs __iomem
> *__dw_regs(struct dw_dma *dw)
> }
>
> #define dma_readl(dw, name) \
> - readl(&(__dw_regs(dw)->name))
> + dma_readl_native(&(__d
On Mon, 2012-10-15 at 08:39 +0800, Hein Tibosch wrote:
> Hi Andy,
> On 10/15/2012 4:08 AM, Andy Shevchenko wrote:
> > On Sun, Oct 14, 2012 at 10:54 AM, Hein Tibosch
> > wrote:
> >> From: Hein Tibosch
> >>
> >> The dw_dmac was originally dev
On Mon, 2012-10-15 at 08:59 +0530, Viresh Kumar wrote:
> On 12 October 2012 20:28, Andy Shevchenko
> wrote:
> >> + if (last_dw) {
> >> + if ((last_bus_id == param) && (last_dw == dw))
> >> + return false;
> >>
ests, 0 failures (status
0)
[ 89.955059] dma0chan5-copy0: terminating after 50 tests, 0 failures (status
0)
[ 90.697073] dma0chan6-copy0: terminating after 50 tests, 1 failures (status
0)
[ 90.893422] dma0chan7-copy0: terminating after 50 tests, 1 failures (status
0)
Signed-off-by: And
On Tue, Oct 16, 2012 at 11:56 AM, viresh kumar wrote:
> On Tue, Oct 16, 2012 at 2:15 PM, Andy Shevchenko
> wrote:
>> The following error messages come if we have software LLP emulation enabled
>> and
>> enough threads running.
>>
>> modprobe dmatest ite
higher timeout. And
> terminating
> transfers for error case would be better, to make them timeout safe.
Yeah, seems the patch is not necessary.
In case of software emulation we just have a test passed much slow...
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this
There are several places in the kernel that use functionality like basename(3)
with an exception: in case of '/foo/bar/' we expect to get an empty string.
Let's do it common helper for them.
Signed-off-by: Andy Shevchenko
Cc: Jason Baron
Cc: YAMANE Toshiaki
Cc: Greg Kroah-Har
Signed-off-by: Andy Shevchenko
---
fs/proc/proc_devtree.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
index df7dd08..3d9fd66 100644
--- a/fs/proc/proc_devtree.c
+++ b/fs/proc/proc_devtree.c
@@ -13,6 +13,7
There are several places in the kernel that use functionality like basename(3)
with the exception: in case of '/foo/bar/' we expect to get an empty string.
Let's do it common helper for them.
Signed-off-by: Andy Shevchenko
---
include/linux/string.h | 11 +++
1 f
Signed-off-by: Andy Shevchenko
Cc: Steven Rostedt
Cc: Frederic Weisbecker
---
kernel/trace/trace_uprobe.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 03003cd..c7ba4f6 100644
--- a/kernel/trace
needed there as well.
Signed-off-by: Andy Shevchenko
Cc: YAMANE Toshiaki
Cc: Greg Kroah-Hartman
---
drivers/staging/rts_pstor/trace.h | 24
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rts_pstor/trace.h
b/drivers/staging/rts_psto
Remove the custom implementation of the functionality similar to kbasename().
Signed-off-by: Andy Shevchenko
Cc: Jason Baron
---
lib/dynamic_debug.c |9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index e7f7d99..1db1fc6
ch 1/1 to all people involved to the series
- rebase against recent linux-next
Since v1:
- fix changelog of the patch 1 - we are doing basename(3) alike helper
- usb related patch temporary excluded from series (under discussion with Greg)
Andy Shevchenko (6):
lib/string: introduce helper to get base
Signed-off-by: Andy Shevchenko
Cc: linux...@kvack.org
---
mm/memory.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 5823f29..06158b7 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -58,6 +58,7 @@
#include
#include
#include
dma_slave_config
structure. That's why the custom slave configuration could be optional for such
cases.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
---
drivers/dma/dw_dmac.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/driver
best
candidate to provide the storage is a custom channel structure. Until now we
still keep and check the direction field of the slave config structure as well.
Signed-off-by: Andy Shevchenko
Acked-by: Viresh Kumar
---
drivers/dma/dw_dmac.c | 12 ++--
drivers/dma/dw_dmac_regs.h
When build a kernel with "make W=1" we will get a warning about missing
initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't
initialize the buf[] field of the fifo structure. So, using C99 style helps in
such case.
Signed-off-by: Andy Shevchenko
Cc: Stef
When build a kernel with "make W=1" we will get a warning about missing
initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't
initialize the buf[] field of the fifo structure. So, using C99 style helps in
such case.
Signed-off-by: Andy Shevchenko
Cc: Stef
On Tue, 2013-01-08 at 07:54 -0800, Vinod Koul wrote:
> On Mon, Jan 07, 2013 at 02:54:54PM +0200, Andy Shevchenko wrote:
> > Hi, Vinod.
> >
> > I noticed you missed the 3.8 merge window and I can't see any of my
> > recent patches [1] in your next branch. So, wh
also changes the logic a bit when the master parameter of the
dwc_get_data_width() is out of range. Now the function will return a value
related to the first AHB master.
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw_dmac.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --
501 - 600 of 10895 matches
Mail list logo
