Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-25 Thread Jarkko Nikula
t this_irq, void *dev_id) static const struct i2c_algorithm i2c_dw_algo = { .functionality = i2c_dw_func, - .reg_slave = i2c_dw_reg_slave, - .unreg_slave = i2c_dw_unreg_slave, + .reg_target = i2c_dw_reg_target, + .unreg_target = i2c_dw_unreg_target, }; Acked-by: Jarkko Nikula

Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

2021-04-07 Thread Jarkko Nikula
Hi On 3/31/21 4:36 PM, Yicong Yang wrote: + ret = device_property_read_u64(dev, "clk_rate", >clk_rate_khz); + if (ret) { + dev_err(dev, "failed to get clock frequency, ret = %d\n", ret); + return ret; + } + + ctlr->clk_rate_khz =

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-04-06 Thread Jarkko Nikula
Shevchenko Acked-by: Wolfram Sang Acked-by: Jarkko Nikula

Re: [PATCH v1 1/1] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-31 Thread Jarkko Nikula
com Yicong, feel free to attach to your new version of it. drivers/i2c/busses/i2c-designware-master.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) Please note kernel test robot reported some issues with this patch before included in this series. Acked-by: Jarkko Nikula

Re: [PATCH v5 2/5] i2c: core: add api to provide frequency mode strings

2021-03-31 Thread Jarkko Nikula
is: "Mode(" -> "Mode (" - Space between number and unit: (1.0MHz) -> (1.0 MHz) With those changes you may add my Reviewed-by: Jarkko Nikula Tested-by: Jarkko Nikula

Re: [PATCH v2] i2c: designware: Add driver support for AMD NAVI GPU

2021-03-23 Thread Jarkko Nikula
Hi On 3/22/21 6:59 PM, Sanket Goswami wrote: The Latest AMD NAVI GPU card has an integrated Type-C controller and Designware I2C with PCI Interface. The Type-C controller can be accessed over I2C. The client driver is part of the USB Type-C UCSI driver. Also, there exists a couple of notable

Re: [PATCH v5 3/4] i2c: designware: Use pcim_alloc_irq_vectors() to allocate IRQ vectors

2021-03-03 Thread Jarkko Nikula
function, So replace it with pcim_alloc_irq_vectors(). At the same time, Remove the pci_free_irq_vectors() function to simplify the error handling path. the freeing resources will take automatically when device is gone. Acked-by: Andy Shevchenko Signed-off-by: Dejin Zheng --- Acked-by: Jarkko

Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()'

2021-02-15 Thread Jarkko Nikula
ectors(dev); platform_device_unregister(pdev); clk_unregister(spi_pdata->ssp.clk); } Reviewed-by: Jan Kiszka Please fix pca2xx-pci -> pxa2xx-pci in the subject line. With that change you may add: Reviewed-by: Jarkko Nikula

Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place

2021-02-15 Thread Jarkko Nikula
deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH 1/2] MAINTAINERS: Update email address for TI ASoC and twl4030 codec drivers

2020-12-15 Thread Jarkko Nikula
AUDIO SUPPORT > -M: Peter Ujfalusi > +M: Peter Ujfalusi > M: Jarkko Nikula > L: alsa-de...@alsa-project.org (moderated for non-subscribers) > L: linux-o...@vger.kernel.org > @@ -17537,7 +17537,7 @@ F:arch/xtensa/ > F: drivers/irqchip/irq-xtensa-* > Acked-by: Jarkko Nikula

Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-11 Thread Jarkko Nikula
On 11/11/20 12:54 PM, Vaibhav Gupta wrote: On Tue, Nov 10, 2020 at 02:33:43PM +0200, Jarkko Nikula wrote: +#define gpu_i2c_suspend NULL Perhaps we can put NULL directly into UNIVERSAL_DEV_PM_OPS() for the suspend callback? Yes. I have noticed that the approach for this is random. Many

Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm

2020-11-10 Thread Jarkko Nikula
the suspend callback is not set and device was on prior it. Reviewed-by: Jarkko Nikula

Re: [PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED

2020-11-05 Thread Jarkko Nikula
On 11/4/20 12:17 PM, michael...@vatics.com wrote: Hi Wolfram, dev->status can be used to record the current state, especially Designware I2C controller has no interrupts to identify a write-request. This patch Just double-checking: the designware HW does not raise an interrupt when its own

Re: [PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED

2020-10-30 Thread Jarkko Nikula
etions(-) Acked-by: Jarkko Nikula

Re: [PATCH v3] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-23 Thread Jarkko Nikula
/busses/i2c-designware-slave.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH v2] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-22 Thread Jarkko Nikula
Hi On 10/22/20 8:46 AM, Michael Wu wrote: @@ -217,10 +214,8 @@ static int i2c_dw_irq_handler_slave(struct dw_i2c_dev *dev) if (!i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_RECEIVED, )) dev_vdbg(dev->dev, "Byte %X

Re: [PATCH] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-21 Thread Jarkko Nikula
Hi On 10/20/20 11:33 AM, Michael Wu wrote: i2c_dw_read_clear_intrbits_slave() was called per each interrupt handle. It caused some interrupt bits which haven't been handled yet were cleared, the corresponding handlers would do nothing due to interrupt bits been discarded. For example, $ i2cset

Re: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

2020-10-14 Thread Jarkko Nikula
Hi On 10/14/20 8:25 AM, Michael Wu wrote: When an I2C slave works, sometimes both IC_INTR_RX_FULL and IC_INTR_STOP_DET are rising during an IRQ handle, especially when system is busy or too late to handle interrupts. If IC_INTR_RX_FULL is rising and the system doesn't handle immediately,

Re: [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads

2020-09-23 Thread Jarkko Nikula
ort block reads, the i2c controller drivers should cope with this and proceed with the i2c transfer using the original requested length." Reviewed-by: Andy Shevchenko for I²C DesignWare patches. Also for i2c-designware Acked-by: Jarkko Nikula

Re: [PATCH v2 2/4] i2c: designware: Ensure tx_buf_len is nonzero for SMBus block reads

2020-09-17 Thread Jarkko Nikula
On 9/17/20 8:22 AM, Sultan Alsawaf wrote: From: Sultan Alsawaf The point of adding a byte to len in i2c_dw_recv_len() is to make sure that tx_buf_len is nonzero, so that i2c_dw_xfer_msg() can let the i2c controller know that the i2c transaction can end. Otherwise, the i2c controller will think

Re: [PATCH v3] i2c: Squash of SMBus block read patchset to save power

2020-09-16 Thread Jarkko Nikula
On 9/15/20 8:48 PM, Sultan Alsawaf wrote: On Tue, Sep 15, 2020 at 02:55:48PM +0300, Jarkko Nikula wrote: I tested this on top of fc4f28bb3daf ("Merge tag 'for-5.9-rc5-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux") and seems to be working fine. What was the

Re: [PATCH v1] x86/defconfigs: Unbreak 32-bit defconfig builds

2020-09-08 Thread Jarkko Nikula
Hi On 9/8/20 3:13 PM, Ingo Molnar wrote: * Andy Shevchenko wrote: After the commit 1d0e12fd3a84 ("x86/defconfigs: Refresh defconfig files") 32-bit builds using defconfig become broken because on x86_64 build host with no ARCH provided the default behaviour is to assume 64-bit independently

Re: [PATCH 1/2] i2c: i801: Fix runtime PM

2020-09-01 Thread Jarkko Nikula
, On Tue, 26 Jun 2018 17:39:12 +0300, Jarkko Nikula wrote: Commit 9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM") nullified the runtime PM suspend/resume callback pointers while keeping the runtime PM enabled. This causes that device stays in D0 power state and sysf

Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power

2020-07-03 Thread Jarkko Nikula
Hi On 7/1/20 6:00 PM, Sultan Alsawaf wrote: On Wed, Jul 01, 2020 at 11:04:01AM +0300, Jarkko Nikula wrote: On 6/29/20 8:43 PM, Sultan Alsawaf wrote: Hmm, for some reason in 5.8 I get the same problem, but 5.7 is fine. Could you try this on 5.7 and see if it works? In the meantime I'll bisect

Re: [PATCH v6] i2c: designware: platdrv: Set class based on DMI

2020-07-02 Thread Jarkko Nikula
gned-off-by: Ricardo Ribalda Reviewed-by: Andy Shevchenko --- v6: Removed extra line, sorry for the invalid v5 drivers/i2c/busses/i2c-designware-platdrv.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Acked-by: Jarkko Nikula

Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power

2020-07-01 Thread Jarkko Nikula
On 6/29/20 8:43 PM, Sultan Alsawaf wrote: Hmm, for some reason in 5.8 I get the same problem, but 5.7 is fine. Could you try this on 5.7 and see if it works? In the meantime I'll bisect 5.8 to see why it's causing problems for me... I see the same issue on top of v5.7: [9.330514] i2c_hid

Re: [PATCH v2] i2c: designware: platdrv: Set class based on dmi

2020-06-25 Thread Jarkko Nikula
On 6/24/20 2:25 PM, Ricardo Ribalda wrote: Current AMD's zen-based APUs use this core for some of its i2c-buses. With this patch we re-enable autodetection of hwmon-alike devices, so lm-sensors will be able to work automatically. It does not affect the boot-time of embedded devices, as the

Re: [PATCH v2] i2c: designware: platdrv: Set class based on dmi

2020-06-24 Thread Jarkko Nikula
On 6/24/20 4:22 PM, Andy Shevchenko wrote: On Wed, Jun 24, 2020 at 01:25:30PM +0200, Ricardo Ribalda wrote: Current AMD's zen-based APUs use this core for some of its i2c-buses. With this patch we re-enable autodetection of hwmon-alike devices, so lm-sensors will be able to work automatically.

Re: [PATCH] i2c: designware: Fix functionality in !CONFIG_ACPI case

2020-06-23 Thread Jarkko Nikula
On 6/23/20 10:59 AM, Jarkko Nikula wrote: Hi On 6/23/20 5:51 AM, John Stultz wrote: On the HiKey board, where CONFIG_ACPI is not set, we started to see a graphics regression where the adv7511 HDMI bridge driver wasn't probing. This was due to the i2c bus failing to start up. I bisected

Re: [PATCH] i2c: designware: Fix functionality in !CONFIG_ACPI case

2020-06-23 Thread Jarkko Nikula
peed() out of the ifdef CONFIG_ACPI conditional, and gets the board working again. Cc: Andy Shevchenko Cc: Jarkko Nikula Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Fixes: f9288fcc5c615 ("i2c: designware: Move ACPI parts into common module") Signed-off-by: John Stultz --- dr

Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power

2020-06-17 Thread Jarkko Nikula
On 6/16/20 6:49 PM, Sultan Alsawaf wrote: From: Sultan Alsawaf We have no way of knowing how large an incoming payload is going to be, so the only strategy available up until now has been to always retrieve the maximum possible report length over i2c, which can be quite inefficient. For

Re: [PATCH v2] i2c: designware: Only check the first byte for SMBus block read length

2020-06-17 Thread Jarkko Nikula
nware: Implement support for SMBus block read and write") Signed-off-by: Sultan Alsawaf --- drivers/i2c/busses/i2c-designware-master.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH 2/2] HID: i2c-hid: Use block reads when possible to save power

2020-06-16 Thread Jarkko Nikula
On 6/15/20 12:02 AM, Sultan Alsawaf wrote: From: Sultan Alsawaf We have no way of knowing how large an incoming payload is going to be, so the only strategy available up until now has been to always retrieve the maximum possible report length over i2c, which can be quite inefficient. For

Re: [PATCH 1/2] i2c: designware: Only check the first byte for SMBus block read length

2020-06-16 Thread Jarkko Nikula
On 6/15/20 12:02 AM, Sultan Alsawaf wrote: From: Sultan Alsawaf SMBus block reads can be broken because the read function will just skip over bytes it doesn't like until reaching a byte that conforms to the length restrictions for block reads. This is problematic when it isn't known if the

Re: [PATCH v6 07/11] i2c: designware: Discard Cherry Trail model flag

2020-06-01 Thread Jarkko Nikula
o are fine with shuffling model defines, which I consider an unneeded churn. Signed-off-by: Serge Semin Acked-by: Jarkko Nikula I completely agree with Andy and more over, I didn't ack this version. This was the version I acked: https://www.spinics.net/lists/linux-i2c/msg45492.html So in gene

Re: [PATCH v2 08/12] i2c: designware: Introduce platform drivers glue layer interface

2020-05-25 Thread Jarkko Nikula
Hi On 5/21/20 5:37 AM, Serge Semin wrote: On Wed, May 20, 2020 at 03:46:11PM +0300, Jarkko Nikula wrote: Hi On 5/10/20 12:50 PM, Serge Semin wrote: Seeing the DW I2C platform driver is getting overcomplicated with a lot of vendor-specific configs let's introduce a glue-layer interface so new

Re: [PATCH v2 07/12] i2c: designware: Move Baytrail sem config to the platform if-clause

2020-05-25 Thread Jarkko Nikula
On 5/21/20 5:22 AM, Serge Semin wrote: On Wed, May 20, 2020 at 03:16:14PM +0300, Jarkko Nikula wrote: On 5/10/20 12:50 PM, Serge Semin wrote: Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some

Re: [PATCH v2 08/12] i2c: designware: Introduce platform drivers glue layer interface

2020-05-20 Thread Jarkko Nikula
Hi On 5/10/20 12:50 PM, Serge Semin wrote: Seeing the DW I2C platform driver is getting overcomplicated with a lot of vendor-specific configs let's introduce a glue-layer interface so new platforms which equipped with Synopsys Designware APB I2C IP-core would be able to handle their

Re: [PATCH v2 10/12] i2c: designware: Discard Cherry Trail model flag

2020-05-20 Thread Jarkko Nikula
nel.org Cc: devicet...@vger.kernel.org --- drivers/i2c/busses/i2c-designware-core.h| 3 --- drivers/i2c/busses/i2c-designware-pcidrv.c | 1 - drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH v2 04/12] i2c: designware: Convert driver to using regmap API

2020-05-20 Thread Jarkko Nikula
-by: Jarkko Nikula Acked-by: Jarkko Nikula

Re: [PATCH v2 05/12] i2c: designware: Use `-y` to build multi-object modules

2020-05-20 Thread Jarkko Nikula
lfram Sang Cc: Rob Herring Cc: Frank Rowand Cc: linux-m...@vger.kernel.org Cc: devicet...@vger.kernel.org --- drivers/i2c/busses/Makefile | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH v2 07/12] i2c: designware: Move Baytrail sem config to the platform if-clause

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some separated place with no reference to the platform code. Lets move the config definition under the

Re: [PATCH v2 06/12] i2c: designware: slave: Set DW I2C core module dependency

2020-05-20 Thread Jarkko Nikula
...@vger.kernel.org Cc: devicet...@vger.kernel.org --- drivers/i2c/busses/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jarkko Nikula

Re: [PATCH] i2c: fix missing pm_runtime_put_sync in i2c_device_probe

2020-05-03 Thread Jarkko Nikula
called within the function in case of an error. This commit add this error handling. Fixes: 72bfcee11cf8 ("i2c: Prevent runtime suspend of adapter when Host Notify is required") Right, I was blind to see this. Reviewed-by: Jarkko Nikula

[PATCH] mfd: intel-lpss: Add default I2C device properties for Gemini Lake

2019-09-03 Thread Jarkko Nikula
Intel Gemini Lake PCI IDs") Tested-by: Chris Chiu Signed-off-by: Jarkko Nikula --- This is not immediate stable material since there is no regression related to this. Those machines that need updated parameters have obviously never worked and I don't want this to cause regression either so bet

Re: Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Jarkko Nikula
On 9/4/19 7:38 AM, Chris Chiu wrote: On Tue, Sep 3, 2019 at 8:03 PM Jarkko Nikula wrote: Hi Chris On 9/3/19 11:18 AM, Mika Westerberg wrote: +Jarkko On Tue, Sep 03, 2019 at 04:10:27PM +0800, Chris Chiu wrote: Hi, We're working on the acer Gemnilake laptop TravelMate B118-M for touchpad

Re: Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Jarkko Nikula
ws team that Gemini Lake systems should use updated timing parameters that differ from those used in Broxton based systems. Fixes: f80e78aa11ad ("mfd: intel-lpss: Add Intel Gemini Lake PCI IDs") Signed-off-by: Jarkko Nikula --- This is not immediate stable material since there is no regress

Re: [PATCH] i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info

2019-08-06 Thread Jarkko Nikula
Hi On 8/6/19 10:50 AM, Gustavo A. R. Silva wrote: Fix the following warning: drivers/i2c/busses/i2c-designware-master.c: In function ‘i2c_dw_init_recovery_info’: drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable ‘r’ [-Wunused-variable] int r; ^ Fixes:

Re: [PATCH] ASoC: ti: Mark expected switch fall-throughs

2019-07-30 Thread Jarkko Nikula
his statement may fall through > [-Wimplicit-fallthrough=] >hs = 1; >~~~^~~ > sound/soc/ti/rx51.c:58:2: note: here > case RX51_JACK_HP: > ^~~~ > > Signed-off-by: Gustavo A. R. Silva > --- > sound/soc/ti/n810.c | 1 + > sound/soc/ti/rx51.c | 1 + > 2 files changed, 2 insertions(+) > Acked-by: Jarkko Nikula

Re: [PATCH] i2c: busses: Use dev_get_drvdata where possible

2019-07-29 Thread Jarkko Nikula
/i2c-i801.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) (...) Looks good to me, thanks. Reviewed-by: Jean Delvare For the i2c-designware-pcidrv.c Acked-by: Jarkko Nikula

Re: [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent

2019-06-28 Thread Jarkko Nikula
Hi On 6/28/19 5:47 AM, Fuqian Huang wrote: In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dmam_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/i2c/busses/i2c-ismt.c | 2

Re: [PATCH] i2c: designware: Add disable runtime pm quirk

2019-06-26 Thread Jarkko Nikula
On 6/26/19 5:32 AM, AceLan Kao wrote: Adding I2C_HID_QUIRK_NO_RUNTIME_PM quirk doesn't help on this issue. Actually, Goodix touchpad already has that PM quirk in the list for other issue. { I2C_VENDOR_ID_GOODIX, I2C_DEVICE_ID_GOODIX_01F0, I2C_HID_QUIRK_NO_RUNTIME_PM }, I

Re: [PATCH] i2c: designware: Add disable runtime pm quirk

2019-06-25 Thread Jarkko Nikula
On 6/25/19 11:30 AM, AceLan Kao wrote: Dell machines come with goodix touchpad IC suffer from the double click issue if the Designware I2C adapter enters runtime suspend. It's because the goodix re-assert the interrupt if host doesn't read the data within 100ms and designware takes a longer

Re: [PATCH 2/2] eeprom: ee1004: Deal with nack on page selection

2019-05-06 Thread Jarkko Nikula
right then we can continue. Signed-off-by: Jean Delvare Tested-by: Jarkko Nikula Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/misc/eeprom/ee1004.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Does Dreamcat4 deserve reported and tested by tags here? I guess

Re: [PATCH v2] mfd: intel-lpss: Add Intel Comet Lake PCI IDs

2019-05-02 Thread Jarkko Nikula
(+) Reviewed-by: Jarkko Nikula

Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs

2019-04-30 Thread Jarkko Nikula
On 4/16/19 10:55 AM, Andy Shevchenko wrote: On Tue, Apr 16, 2019 at 6:10 AM Evan Green wrote: On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko wrote: Intel Comet Lake has the same LPSS than Intel Cannon Lake. Add the new IDs to the list of supported devices. static const struct

Re: [Bug 203297] Synaptics touchpad TM-3127 functionality broken by PCI runtime power management patch on 4.20.2

2019-04-29 Thread Jarkko Nikula
On 4/29/19 10:45 AM, Benjamin Tissoires wrote: I would like to ask help from input subsystem experts what kind of SMBus power state dependency Synaptics RMI4 SMBus devices have since it cease to work if SMBus controllers idles between transfers and how this is best to fix? Hmm, I am not sure

Re: [Bug 203297] Synaptics touchpad TM-3127 functionality broken by PCI runtime power management patch on 4.20.2

2019-04-26 Thread Jarkko Nikula
On 4/22/19 4:08 PM, Bjorn Helgaas wrote: https://bugzilla.kernel.org/show_bug.cgi?id=203297 Regression, suspected but as yet unconfirmed cause: c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions") backported to 4.20 stable as 39e1be324c2f. With help of Keijo it was

Re: [PATCH] spi: pxa2xx: Add support for Intel Comet Lake

2019-04-16 Thread Jarkko Nikula
match with my understanding. Reviewed-by: Jarkko Nikula

Re: [PATCH v2] spi: pxa2xx: fix SCR (divisor) calculation

2019-04-12 Thread Jarkko Nikula
Instead, with this patch, we have in both case an SSP clock of 12.5MHz, so the max rate of the SPI device clock is respected. Signed-off-by: Flavio Suligoi Reviewed-by: Jarkko Nikula --- v2: - simplify the code using "DIV_ROUND_UP" v1: - first version drivers/spi/spi-pxa2xx.c | 8 ++

Re: [PATCH 1/2] spi: pxa2xx: fix SCR (divisor) calculation

2019-04-11 Thread Jarkko Nikula
On 4/10/19 3:51 PM, Flavio Suligoi wrote: Calculate the divisor for the SCR (Serial Clock Rate), avoiding that the SSP transmission rate can be greater than the device rate. When the division between the SSP clock and the device rate generates a reminder, we have to increment by one the

Re: [PATCH v2 1/1] spi: pxa2xx: add driver enabling message

2019-04-10 Thread Jarkko Nikula
a ? "DMA" : "PIO"); + "slave device" is ambiguous. Please use "controller" with both, i.e. "PXA2xx SPI %s controller (%s mode)\n", ... ? "slave" : "master", ... With that changed you may add: Reviewed-by: Jarkko Nikula

Re: [PATCH 1/1] spi: pxa2xx: add driver enabling message

2019-04-10 Thread Jarkko Nikula
On 4/10/19 11:13 AM, Flavio Suligoi wrote: [9.506895] pxa2xx-spi pxa2xx-spi.13: no DMA channels available, using PIO [9.516770] pxa2xx-spi pxa2xx-spi.13: registered master spi2 [9.518527] pxa2xx-spi pxa2xx-spi.13: PXA2xx SPI master controller (PIO mode) I have added this message

Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs

2019-04-10 Thread Jarkko Nikula
On 4/9/19 6:11 PM, Andy Shevchenko wrote: Intel Comet Lake has the same LPSS than Intel Cannon Lake. Add the new IDs to the list of supported devices. Signed-off-by: Andy Shevchenko --- drivers/mfd/intel-lpss-pci.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH 1/1] spi: pxa2xx: add driver enabling message

2019-04-10 Thread Jarkko Nikula
On 4/9/19 5:11 PM, Flavio Suligoi wrote: Hi Jarkko, Hi On 4/8/19 6:22 PM, Flavio Suligoi wrote: Add an info message for the PXA2xx device driver start-up, with the indication of the transfer mode used (DMA or GPIO). This info is useful to individuate the timing when the module starts.

Re: [PATCH 1/1] spi: pxa2xx: add driver enabling message

2019-04-09 Thread Jarkko Nikula
Hi On 4/8/19 6:22 PM, Flavio Suligoi wrote: Add an info message for the PXA2xx device driver start-up, with the indication of the transfer mode used (DMA or GPIO). This info is useful to individuate the timing when the module starts. Signed-off-by: Flavio Suligoi ---

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-03 Thread Jarkko Nikula
12 insertions(+), 2 deletions(-) On a BSW/CHT machine I have I see the warnings below at commit 48402cee6889 after resuming from hibernation but I2C bus itself is working so obviously I tested only S3 when I gave the tested by. This patch is fixing that so here's my tested by to this patch: Test

Re: [PATCH] [RFC] spi: pxa2xx: Do cs if restart the SSP during pxa2xx_spi_transfer_one()

2019-03-19 Thread Jarkko Nikula
Hi Jin On 3/8/19 9:28 AM, Xiao, Jin wrote: Yes, the spi core has de-asserted the CS before the pxa2xx_spi_unprepare_transfer(). The problem on my side is that the new transfer will restart the SSP in pxa2xx_spi_transfer_one(). The spi core has asserted the CS again before restart the SSP. 

Re: [PATCH 1/2] i2c: i2c-designware-platdrv: Allow a dynamic adap. nr without an ACPI fwnode

2019-03-12 Thread Jarkko Nikula
Hi On 3/11/19 1:22 PM, Hans de Goede wrote: Before this commit the i2c-designware-platdrv assumes that if the pdev has an apci-companion it should use a dynamic adapter-nr and otherwise it will use pdev->id as adapter-nr. On some devices e.g. the Apollo Lake using Acer TravelMate Spin B118,

Re: [PATCH] [RFC] spi: pxa2xx: Do cs if restart the SSP during pxa2xx_spi_transfer_one()

2019-03-07 Thread Jarkko Nikula
Hi Is this also related to the regression with d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop") you have found or another issue? Comments below. On 3/7/19 9:24 AM, xiao jin wrote: The spi-pxa2xx can't read and write data correctly on our board. The pxa_ssp_type is LPSS_BXT_SSP

Re: [PATCH] spi-pxa2xx.c: modify the chip selection timing when spi transfer

2019-03-05 Thread Jarkko Nikula
Hi On 3/6/19 5:05 AM, xiao jin wrote: From: "he, bo" We find spi can't work on board. More debug shows it's related to the following patch that changed the chip selection assert and deassert timing. ^^ timing caught my attention. More below. @@ -610,6 +596,7 @@ static void

Re: [PATCH v5 2/2] i2c: designware: Add support for an interface clock

2019-03-01 Thread Jarkko Nikula
gnware-platdrv.c | 5 + 3 files changed, 23 insertions(+), 2 deletions(-) Build & boot tested on linux-next that has the required commit 60b8f0ddf1a9 ("clk: Add (devm_)clk_get_optional() functions"). Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula

Re: linux-next: manual merge of the mfd tree with Linus' tree

2019-02-08 Thread Jarkko Nikula
On 2/8/19 4:37 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the mfd tree got a conflict in: drivers/mfd/Kconfig between commit: 9baddb61dfec ("mfd: Fix unmet dependency warning for MFD_TPS68470") from Linus' tree and commit: 09fdc9857712 ("mfd: Kconfig: Fix

[PATCH] mfd: Fix I2C_DESIGNWARE_PLATFORM dependencies

2019-01-21 Thread Jarkko Nikula
Reported-by: Randy Dunlap Fixes: acebcff9eda8 ("mfd: intel_soc_pmic: Select designware i2c-bus driver") Fixes: de85d79f4aab ("mfd: Add Cherry Trail Whiskey Cove PMIC driver") Fixes: 9bbf6a15ce19 ("mfd: Add support for TPS68470 device") Cc: Stable # v4.14+ Signed

Re: linux-next: Tree for Jan 18 (i2c-designware-platdrv.c)

2019-01-21 Thread Jarkko Nikula
Hi On 1/18/19 6:27 PM, Randy Dunlap wrote: On 1/17/19 8:24 PM, Stephen Rothwell wrote: Hi all, Changes since 20190117: on i386 or x86_64: ld: drivers/i2c/busses/i2c-designware-platdrv.o: in function `dw_i2c_plat_resume': i2c-designware-platdrv.c:(.text+0x4b): undefined reference to

Re: [PATCH] PCI: fix using __initdata memory after free in disable_acs_redir parameter

2019-01-16 Thread Jarkko Nikula
followed by a few lines of junk during boot when I defined pci=disable_acs_redir=:00:xy.z which disappear after your patch. Tested-by: Jarkko Nikula Reviewed-by: Jarkko Nikula

Re: [RFC 0/9] ASoC/ARM: Merge the davinci and omap audio directories

2018-11-11 Thread Jarkko Nikula
sound/soc/{omap => ti} conversion you may add: Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula

Re: [RFC 0/9] ASoC/ARM: Merge the davinci and omap audio directories

2018-11-11 Thread Jarkko Nikula
sound/soc/{omap => ti} conversion you may add: Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-18 Thread Jarkko Nikula
On 10/18/2018 10:36 AM, Andy Shevchenko wrote: On Thu, Oct 18, 2018 at 10:33 AM Rafael J. Wysocki wrote: On Sun, Sep 23, 2018 at 4:45 PM Hans de Goede wrote: On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the kernel. The P-Unit has a semaphore for the PMIC bus which we

Re: [PATCH 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-18 Thread Jarkko Nikula
On 10/18/2018 10:36 AM, Andy Shevchenko wrote: On Thu, Oct 18, 2018 at 10:33 AM Rafael J. Wysocki wrote: On Sun, Sep 23, 2018 at 4:45 PM Hans de Goede wrote: On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the kernel. The P-Unit has a semaphore for the PMIC bus which we

Re: [PATCH v3 3/3] i2c: designware: Cleanup bus lock handling

2018-10-15 Thread Jarkko Nikula
++ drivers/i2c/busses/i2c-designware-common.c | 4 ++-- drivers/i2c/busses/i2c-designware-core.h | 9 ++--- drivers/i2c/busses/i2c-designware-platdrv.c | 2 -- 4 files changed, 6 insertions(+), 27 deletions(-) Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula

Re: [PATCH v3 3/3] i2c: designware: Cleanup bus lock handling

2018-10-15 Thread Jarkko Nikula
++ drivers/i2c/busses/i2c-designware-common.c | 4 ++-- drivers/i2c/busses/i2c-designware-core.h | 9 ++--- drivers/i2c/busses/i2c-designware-platdrv.c | 2 -- 4 files changed, 6 insertions(+), 27 deletions(-) Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula

Re: [PATCH v3 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-15 Thread Jarkko Nikula
driver has indicated the P-Unit needs the bus through a iosf_mbi_punit_acquire() call. Signed-off-by: Hans de Goede For the record: once the designware maintainers are okay with this change, I am also okay with it going via the x86 platform tree. Acked-by: Jarkko Nikula Tested-by: Jarkko

Re: [PATCH v3 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-15 Thread Jarkko Nikula
driver has indicated the P-Unit needs the bus through a iosf_mbi_punit_acquire() call. Signed-off-by: Hans de Goede For the record: once the designware maintainers are okay with this change, I am also okay with it going via the x86 platform tree. Acked-by: Jarkko Nikula Tested-by: Jarkko

Re: [PATCH 3/3] ARM: OMAP2PLUS: Remove references to AM3517-EVM since it's in DT

2018-09-23 Thread Jarkko Nikula
-off-by: Adam Ford > For sound/soc/omap/ changes: Acked-by: Jarkko Nikula

Re: [PATCH 3/3] ARM: OMAP2PLUS: Remove references to AM3517-EVM since it's in DT

2018-09-23 Thread Jarkko Nikula
-off-by: Adam Ford > For sound/soc/omap/ changes: Acked-by: Jarkko Nikula

Re: [PATCH v3 3/3] i2c: designware: select gpio/default pin when prepare/unprepare recovery

2018-09-18 Thread Jarkko Nikula
. Signed-off-by: Jisheng Zhang --- drivers/i2c/busses/i2c-designware-core.h | 3 +++ drivers/i2c/busses/i2c-designware-master.c | 22 ++ 2 files changed, 25 insertions(+) Acked-by: Jarkko Nikula

Re: [PATCH v3 3/3] i2c: designware: select gpio/default pin when prepare/unprepare recovery

2018-09-18 Thread Jarkko Nikula
. Signed-off-by: Jisheng Zhang --- drivers/i2c/busses/i2c-designware-core.h | 3 +++ drivers/i2c/busses/i2c-designware-master.c | 22 ++ 2 files changed, 25 insertions(+) Acked-by: Jarkko Nikula

Re: [PATCH v2] i2c: designware: select gpio/default pin when prepare/unprepare recovery

2018-09-13 Thread Jarkko Nikula
On 09/13/2018 11:21 AM, Jisheng Zhang wrote: On some platforms, the sda/scl pins are muxed with gpio functions, so they could be used for recovery. Select the gpio/default pin function when prepare/unprepare recovery. Signed-off-by: Jisheng Zhang --- since v1: - use IS_ERR_OR_NULL

Re: [PATCH v2] i2c: designware: select gpio/default pin when prepare/unprepare recovery

2018-09-13 Thread Jarkko Nikula
On 09/13/2018 11:21 AM, Jisheng Zhang wrote: On some platforms, the sda/scl pins are muxed with gpio functions, so they could be used for recovery. Select the gpio/default pin function when prepare/unprepare recovery. Signed-off-by: Jisheng Zhang --- since v1: - use IS_ERR_OR_NULL

Re: [PATCH v4 0/7] Add support for MSCC Ocelot i2c

2018-08-16 Thread Jarkko Nikula
-7 through the mips tree once patch 4 has been reviewed by the DT maintainers. For the patches 1-3 and 5/7 that touch i2c-designware: Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula

Re: [PATCH v4 0/7] Add support for MSCC Ocelot i2c

2018-08-16 Thread Jarkko Nikula
-7 through the mips tree once patch 4 has been reviewed by the DT maintainers. For the patches 1-3 and 5/7 that touch i2c-designware: Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula

Re: [PATCH v3 0/6] Add support for MSCC Ocelot i2c

2018-08-07 Thread Jarkko Nikula
-6 through the mips tree once patch 4 has been reviewed by the DT maintainers. For the patches 1-4/6 that touch i2c-designware: Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula I tested acpi_match_device() conversion to device_get_match_data() didn't affect MODEL_CHERRYTRAIL case and quick

Re: [PATCH v3 0/6] Add support for MSCC Ocelot i2c

2018-08-07 Thread Jarkko Nikula
-6 through the mips tree once patch 4 has been reviewed by the DT maintainers. For the patches 1-4/6 that touch i2c-designware: Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula I tested acpi_match_device() conversion to device_get_match_data() didn't affect MODEL_CHERRYTRAIL case and quick

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jarkko Nikula
Hi On 06/26/2018 07:58 PM, Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit unstable for the multi-master use case. So this patch improves ASPEED I2C driver to support the

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-06-27 Thread Jarkko Nikula
Hi On 06/26/2018 07:58 PM, Jae Hyun Yoo wrote: BMC firmware should support some multi-master use cases such as multi-node, IPMB, BMC-ME link and so on but the current ASPEED I2C driver is a bit unstable for the multi-master use case. So this patch improves ASPEED I2C driver to support the

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Jarkko Nikula
On 05/18/2018 10:48 AM, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel-lpss-pci.c is also wrong for Apollo Lake (N3450) ?  There are lots of people having various issues with i2c attached touchpads on Apollo Lake devices, this bug:

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Jarkko Nikula
On 05/18/2018 10:48 AM, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel-lpss-pci.c is also wrong for Apollo Lake (N3450) ?  There are lots of people having various issues with i2c attached touchpads on Apollo Lake devices, this bug:

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Jarkko Nikula
On 05/18/2018 01:20 PM, Andy Shevchenko wrote: On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel- lpss- pci.c is also wrong for Apollo Lake (N3450) ? There are

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-18 Thread Jarkko Nikula
On 05/18/2018 01:20 PM, Andy Shevchenko wrote: On Fri, 2018-05-18 at 11:37 +0300, Andy Shevchenko wrote: On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote: Could it be the i2c input clock definition in drivers/mfd/intel- lpss- pci.c is also wrong for Apollo Lake (N3450) ? There are

  1   2   3   4   5   >