Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-28 Thread Robert Jarzmik
free. There is >> no need to allocate memory for 'functions' with devm function >> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. >> >> Signed-off-by: Arvind Yadav > > I want the maintainer Robert Jarzmik to review this before I do anything Hi

[PATCH v2] tags: honor COMPILED_SOURCE with apart output directory

2016-12-15 Thread Robert Jarzmik
ence the simple expression to compute "k" as the built object. Signed-off-by: Robert Jarzmik --- Since v1: amended k expression, Marek's comments --- scripts/tags.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index a2ff3388e

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-12 Thread Robert Jarzmik
Michal Marek writes: > Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): >> Robert Jarzmik writes: >> >>> When the kernel is compiled with an "O=" argument, the object files are >>> not necessarily in the source tree, and more probably in another tree.

Re: [V2] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-12 Thread Robert Jarzmik
arvind Yadav writes: > There is problem, if you will use devm_ioremap_resource instead of > devm_ioremap, > than devm_ioremap_resource will call request_mem_region(). > request_mem_region() allows to tell the kernel that this driver is going to > use > this range of I/O addresses, which will pr

Re: [RFC PATCH 15/23] arm: use kconfig fragments for ARCH_PXA defconfigs (part 1)

2016-12-10 Thread Robert Jarzmik
ing defconfig files (before/after the patch). > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Cyril Bur > Signed-off-by: Bartlomiej Zolnierkiewicz Hi Bartolomiej, It's a bit hard to judge without any context for me, especially I'm receiving patch

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-10 Thread Robert Jarzmik
Arvind Yadav writes: Hi Arvind, > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm function > so replace de

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-06 Thread Robert Jarzmik
Robert Jarzmik writes: > When the kernel is compiled with an "O=" argument, the object files are > not necessarily in the source tree, and more probably in another tree. > > In this situation, the current used check doesn't work, and > COMPILED_SOURCE tags is b

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-26 Thread Robert Jarzmik
+ + ac97_set_drvdata(adev, wm97xx); + dev_info(wm97xx->dev, "wm97xx core found, id=0x%x\n", +adev->vendor_id); [2] Lee's previous mail > On Sat, 19 Nov 2016, Robert Jarzmik wrote: >> Lee Jones writes: >>

Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus

2016-11-25 Thread Robert Jarzmik
Lars-Peter Clausen writes: ... Ok Lars, let's do this : I integrate as many of your remarks as I can, and I respin this serie, limited to patches 1, 2, 3, 4 and 5. Then we'll iterate, that will enable me to settle the serie, as I was on holidays and lost a bit my track. I'll send it hopefully ne

Re: [PATCH 6/9] power_supply: wm97xx_battery: use power_supply_get_drvdata

2016-11-25 Thread Robert Jarzmik
Sebastian Reichel writes: > Hi Robert, > > On Wed, Oct 26, 2016 at 09:41:44PM +0200, Robert Jarzmik wrote: >> As the power supply framework provides a way to store and retrieve >> private supply data, use it. >> >> In the process, change the platform data for w

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

2016-11-25 Thread Robert Jarzmik
Stefan Schmidt writes: > Hello. > > On 24.11.2016 17:29, Arnd Bergmann wrote: >> The camera_supply_dummy_device definition is shared between a780 and a910, >> but only provided when the first is enabled and fails to build for a >> configuration with only a910: >> >> arch/arm/mach-pxa/ezx.c:1097:

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

2016-11-25 Thread Robert Jarzmik
Arnd Bergmann writes: > The camera_supply_dummy_device definition is shared between a780 and a910, > but only provided when the first is enabled and fails to build for a > configuration with only a910: > > arch/arm/mach-pxa/ezx.c:1097:3: error: 'camera_supply_dummy_device' > undeclared here (not

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-19 Thread Robert Jarzmik
Lee Jones writes: > On Wed, 26 Oct 2016, Robert Jarzmik wrote: >> +config MFD_WM97xx >> +tristate "Wolfson Microelectronics WM97xx" >> +select MFD_CORE >> +select REGMAP_AC97 >> +select AC97_BUS_COMPAT if AC97_BUS_NEW >> +

Re: [PATCH] ASoC: mioa701_wm9713: add missing white space in dev_err message

2016-11-19 Thread Robert Jarzmik
Colin King writes: > From: Colin Ian King > > There is a missing whitespace in the dev_err message between > "will" and "lead". Add the whitespace. > > Signed-off-by: Colin Ian King Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus

2016-11-09 Thread Robert Jarzmik
Lars-Peter Clausen writes: > On 11/08/2016 10:18 PM, Robert Jarzmik wrote: >>> I'd make the controller itself a struct dev, rather than just having the >>> pointer to the parent. This is more idiomatic and matches what other >>> subsystems do. It has

Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable

2016-11-09 Thread Robert Jarzmik
arked > static. Cleanup all this. > > Cc: Robert Jarzmik > Signed-off-by: Stephen Boyd Most certainly. Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] serial: 8250_pxa: hide early console setup when disabled

2016-11-09 Thread Robert Jarzmik
defined reference to `early_serial8250_setup' > > This adds an #ifdef like the other glue drivers have it. > > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Robert Jarzmik
Arnd Bergmann writes: > On Tuesday, November 8, 2016 7:01:57 PM CET Robert Jarzmik wrote: >> Arnd Bergmann writes: >> If a non-exact match is found, either by closest_below or closest_above, >> rate is >> set (rate = freqs[closest_xxx].cpll). And a couple of lines

Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus

2016-11-08 Thread Robert Jarzmik
Lars-Peter Clausen writes: > On 10/26/2016 09:41 PM, Robert Jarzmik wrote: >> +#define to_ac97_device(d) container_of(d, struct ac97_codec_device, dev) >> +#define to_ac97_driver(d) container_of(d, struct ac97_codec_driver, driver) > > In my opinion these should be inline

Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return

2016-11-08 Thread Robert Jarzmik
Arnd Bergmann writes: > The new pxa2xx_determine_rate() function seems lacking in a few > regards: > > - For an exact match or no match at all, the rate is uninitialized > as reported by gcc -Wmaybe-unintialized: >drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate': >drivers/

Re: [PATCH 1/2] clk: pxa mark dummy helper as 'inline'

2016-11-08 Thread Robert Jarzmik
> Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from > pxa2xx-cpufreq") > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused

2016-11-08 Thread Robert Jarzmik
rewrite pxa2xx-uart to use 8250_core") > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH v3 2/4] ARM: dts: pxa: add pxa25x cpu operating points

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > Add the relevant data taken from the PXA 25x Electrical, Mechanical, and > Thermal Specfication. This will be input data for cpufreq-dt driver. > > Signed-off-by: Robert Jarzmik > --- > Since v2: opp definition amended as per Viresh's c

Re: [PATCH v3 3/4] ARM: dts: pxa: add pxa27x cpu operating points

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > Add the relevant data taken from the PXA27x Electrical, Mechanical, and > Thermal Specfication. This will be input data for cpufreq-dt driver. > > Signed-off-by: Robert Jarzmik > --- > Since v2: opp definition amended as per Viresh's comment Queued to pxa/dt. -- Robert

Re: [PATCH v3 0/4] PXA cpufreq conversion to clock API

2016-11-02 Thread Robert Jarzmik
Viresh Kumar writes: > On 31-10-16, 20:54, Robert Jarzmik wrote: >> Hi, >> >> This serie is a preparation to shift the cpufreq of pxa2xx platforms to >> clocks >> API, next iteration. >> >> The first 3 patches are review and merge material : >&g

Re: [PATCH v2] ARM: pxa: remove duplicated include from spitz.c

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > From: Wei Yongjun > > This partially reverts commit 12beb346710b ("Merge tag 'pxa-fixes-v4.8' > of https://github.com/rjarzmik/linux into randconfig-4.8"). > > This former patch introduced accidentally a double include of mo

Re: [PATCH 2/3] ARM: pxa: ezx: use the new pxa_camera platform_data

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > pxa_camera has transitioned from a soc_camera driver to a standalone > v4l2 driver. Amend the device declaration accordingly. > > Signed-off-by: Robert Jarzmik Queued to pxa/for-next. -- Robert

Re: [PATCH 1/3] ARM: pxa: mioa701: use the new pxa_camera platform_data

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > pxa_camera has transitioned from a soc_camera driver to a standalone > v4l2 driver. Amend the device declaration accordingly. Queued to pxa/for-next. -- Robert

Re: [PATCH 3/3] ARM: pxa: em-x270: use the new pxa_camera platform_data

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > pxa_camera has transitioned from a soc_camera driver to a standalone > v4l2 driver. Amend the device declaration accordingly. > > Signed-off-by: Robert Jarzmik Queued to pxa/for-next. -- Robert

[PATCH v3] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

2016-11-02 Thread Robert Jarzmik
CPU core turbo frequency or the CPU core run frequency This transfer is a prequel to shrink the code in pxa2xx-cpufreq.c, so that it can become, at least in devicetree builds, the casual cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- Since v1: fixed pxa25x CCCR settings added

Re: [PATCH v2 5/5] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

2016-11-02 Thread Robert Jarzmik
Stephen Boyd writes: > On 10/23, Robert Jarzmik wrote: >> diff --git a/drivers/clk/pxa/clk-pxa.c b/drivers/clk/pxa/clk-pxa.c >> index 29cee9e8d4d9..7184819b7415 100644 >> --- a/drivers/clk/pxa/clk-pxa.c >> +++ b/drivers/clk/pxa/clk-pxa.c >> @@ -15,9 +15

Re: [PATCH 5/9] ASoC: pxa: switch to new ac97 bus support

2016-11-01 Thread Robert Jarzmik
Robert Jarzmik writes: > Robert Jarzmik writes: > >> Switch to the new ac97 bus support in sound/ac97 instead of the legacy >> snd_ac97 one. >> >> Signed-off-by: Robert Jarzmik > I realized this one impacts sound/arm/pxa2xx-ac97.c. > This deserves a v2

[PATCH v3 4/4] cpufreq: pxa: convert to clock API

2016-10-31 Thread Robert Jarzmik
As the clock settings have been introduced into the clock pxa drivers, which are now available to change the CPU clock by themselves, remove the clock handling from this driver, and rely on pxa clock drivers. Signed-off-by: Robert Jarzmik --- Since v1: added !OF Kconfig dependency Since v2

[PATCH v3 1/4] cpufreq: pxa: use generic platdev driver for device-tree

2016-10-31 Thread Robert Jarzmik
For device-tree based pxa25x and pxa27x platforms, cpufreq-dt driver is doing the job as well as pxa2xx-cpufreq, so add these platforms to the compatibility list. This won't work for legacy non device-tree platforms where pxa2xx-cpufreq is still required. Signed-off-by: Robert Ja

[PATCH v3 3/4] ARM: dts: pxa: add pxa27x cpu operating points

2016-10-31 Thread Robert Jarzmik
Add the relevant data taken from the PXA27x Electrical, Mechanical, and Thermal Specfication. This will be input data for cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- Since v2: opp definition amended as per Viresh's comment --- arch/arm/boot/dts/pxa27x.dtsi

[PATCH v3 2/4] ARM: dts: pxa: add pxa25x cpu operating points

2016-10-31 Thread Robert Jarzmik
Add the relevant data taken from the PXA 25x Electrical, Mechanical, and Thermal Specfication. This will be input data for cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- Since v2: opp definition amended as per Viresh's comment --- arch/arm/boot/dts/pxa25x.dtsi

[PATCH v3 0/4] PXA cpufreq conversion to clock API

2016-10-31 Thread Robert Jarzmik
reviewed and go in first as a prequisite Since previous iteration, 2 and 3 were amended per Viresh's suggestion. Robert Jarzmik (4): cpufreq: pxa: use generic platdev driver for device-tree ARM: dts: pxa: add pxa25x cpu operating points ARM: dts: pxa: add pxa27x cpu operating p

Re: [PATCH 5/9] ASoC: pxa: switch to new ac97 bus support

2016-10-31 Thread Robert Jarzmik
Robert Jarzmik writes: > Switch to the new ac97 bus support in sound/ac97 instead of the legacy > snd_ac97 one. > > Signed-off-by: Robert Jarzmik I realized this one impacts sound/arm/pxa2xx-ac97.c. This deserves a v2, with this patch being split into 2 pieces : - one for pxa

[PATCH v2] ARM: pxa: em-x270: use the new pxa_camera platform_data

2016-10-29 Thread Robert Jarzmik
pxa_camera has transitioned from a soc_camera driver to a standalone v4l2 driver. Amend the device declaration accordingly. Signed-off-by: Robert Jarzmik --- Since v1: add regulator platform_device and missing include --- arch/arm/mach-pxa/em-x270.c | 89

[PATCH v2] ARM: pxa: remove duplicated include from spitz.c

2016-10-29 Thread Robert Jarzmik
ker [amended commit message and 2 comments] Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/corgi.c | 1 - arch/arm/mach-pxa/spitz.c | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c index 10bfdb169366..183cd3446f25 100644 --- a/arch/

Re: [PATCH 7/9] Input: wm97xx: split out touchscreen registering

2016-10-27 Thread Robert Jarzmik
Charles Keepax writes: > On Wed, Oct 26, 2016 at 09:41:45PM +0200, Robert Jarzmik wrote: >> diff --git a/drivers/input/touchscreen/wm97xx-core.c >> b/drivers/input/touchscreen/wm97xx-core.c >> index 83cf11312fd9..50a110e2988b 100644 > >> +static void wm97xx_re

[PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-10-26 Thread Robert Jarzmik
withstand the new AC97 bus model, where codecs are discovered on runtime. Signed-off-by: Robert Jarzmik --- drivers/mfd/Kconfig| 14 +++ drivers/mfd/Makefile | 1 + drivers/mfd/wm97xx-core.c | 282 + include/linux/mfd/wm97xx.h | 31 + 4

[PATCH 7/9] Input: wm97xx: split out touchscreen registering

2016-10-26 Thread Robert Jarzmik
specific from the remaining part. This is only code shuffling, there is no functional change. Signed-off-by: Robert Jarzmik --- drivers/input/touchscreen/wm97xx-core.c | 193 ++-- 1 file changed, 112 insertions(+), 81 deletions(-) diff --git a/drivers/input/touchscreen

[PATCH 4/9] ASoC: wm9713: add ac97 new bus support

2016-10-26 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9713.c | 37 ++--- 2 files changed, 28 insertions(+), 12 deletions(-) diff

[PATCH 3/9] ASoC: add new ac97 bus support

2016-10-26 Thread Robert Jarzmik
Add the new ac97 bus support, with ac97 bus automatic probing. Signed-off-by: Robert Jarzmik --- sound/Kconfig | 2 ++ sound/Makefile| 1 + sound/soc/Kconfig | 4 3 files changed, 7 insertions(+) diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e050ae6..c7e1cbe84951 100644

Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core

2016-10-26 Thread Robert Jarzmik
Greg Kroah-Hartman writes: > On Thu, Oct 06, 2016 at 08:25:35AM +0200, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > From: Sergey Yanovich >> > >> > pxa2xx-uart was a separate uart platform driver. It was declaring >> > the same d

[PATCH 5/9] ASoC: pxa: switch to new ac97 bus support

2016-10-26 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- include/sound/pxa2xx-lib.h | 15 +-- sound/arm/Kconfig | 1 - sound/arm/pxa2xx-ac97-lib.c | 39 +++ sound/soc/pxa

[PATCH 9/9] Input: wm97xx: add new AC97 bus support

2016-10-26 Thread Robert Jarzmik
l" as the touchscreen driver. This was tested on the pxa architecture with a pxa270 + wm9713 + the mioa701 touchscreen. Signed-off-by: Robert Jarzmik --- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/wm97xx-core.c | 56 - 2 files c

[PATCH 1/9] ALSA: ac97: split out the generic ac97 registers

2016-10-26 Thread Robert Jarzmik
efinition which would come with ac97_codec.h by "chance". - don't have to have snd_a97_*() functions, as they rely on struct snd_ac97. - don't want the struct snd_ac97_bus_ops, there is a new one Signed-off-by: Robert Jarzmik --- Since v1: improve commit message to explai

[PATCH 2/9] ALSA: ac97: add an ac97 bus

2016-10-26 Thread Robert Jarzmik
drvdata(ac97_codec_dev2dev(adev), data); +} + +void *snd_ac97_codec_get_platdata(const struct ac97_codec_device *adev); + +#endif diff --git a/include/sound/ac97/compat.h b/include/sound/ac97/compat.h new file mode 100644 index ..d876464bf7e4 --- /dev/null +++ b/include/sound/ac97/co

[PATCH 6/9] power_supply: wm97xx_battery: use power_supply_get_drvdata

2016-10-26 Thread Robert Jarzmik
As the power supply framework provides a way to store and retrieve private supply data, use it. In the process, change the platform data for wm97xx_battery from a container of a single struct wm97xx_batt_pdata to the direct point to wm97xx_batt_pdata. Signed-off-by: Robert Jarzmik --- drivers

[PATCH 0/9] AC97 device/driver model revamp

2016-10-26 Thread Robert Jarzmik
dependency on 2/9, so it probably can't fit in this next-cycle - 9/9: this last one depends on all the patches before, so it can't fit in this next-cycle As a sum-up, I'd like to push for review for this -next cycle at least the patches 1, 2, 3, 5, 6 and 9. Happy re

[PATCH v2 5/5] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

2016-10-23 Thread Robert Jarzmik
CPU core turbo frequency or the CPU core run frequency This transfer is a prequel to shrink the code in pxa2xx-cpufreq.c, so that it can become, at least in devicetree builds, the casual cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- Since v1: fixed pxa25x CCCR settings added

[PATCH v2 2/5] clk: pxa: core pll is not affected by t bit

2016-10-23 Thread Robert Jarzmik
The t bit of clkfcfg doesn't affect the core pll clock, but it makes core clock select between core pll clock and core run clock. As such remove it from the core pll rate reporting function, while it remains in clk_pxa27x_core_get_parent(). Signed-off-by: Robert Jarzmik --- drivers/clk/px

[PATCH v2 3/5] clk: pxa: b bit of clkcfg means fast bus

2016-10-23 Thread Robert Jarzmik
The meaning of this bit was inverted : - when set to 0, system bus clock is half of the CPU run clock - when set to 1, system bus clock is the CPU run clock Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa27x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 4/5] clk: pxa: export core clocks

2016-10-23 Thread Robert Jarzmik
pxaxxx_get_clk_frequency_khz() needs several clocks to be available through clk_get(), ie. the cpu clocks, system bus clock and memory clocks. Add the missing clkdev so that their rate can be acquired. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa25x.c | 9 ++--- drivers/clk

[PATCH v2 1/5] clk: pxa: remove unused variables

2016-10-23 Thread Robert Jarzmik
This is a cleanup patch to remove unused values not used in their respective functions. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa27x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/clk/pxa/clk-pxa27x.c b/drivers/clk/pxa/clk-pxa27x.c index

[PATCH v2 0/5] Make pxa core clocks settable

2016-10-23 Thread Robert Jarzmik
ter, especially when the "run" clock will become settable as well, but that's another work which is not necessary today. As for quicker review, the diff with the former submission in drivers/clk/pxa is in [1]. Cheers. -- Robert Robert Jarzmik (5): clk: pxa: remove unused variables

Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API

2016-10-22 Thread Robert Jarzmik
Viresh Kumar writes: > On 15-10-16, 21:57, Robert Jarzmik wrote: >> As the clock settings have been introduced into the clock pxa drivers, >> which are now available to change the CPU clock by themselves, remove >> the clock handling from this driver, and rely on pxa clock d

[PATCH] serial: 8250: pxa: add devicetree earlyconsole

2016-10-21 Thread Robert Jarzmik
Transfer the device-tree pxa uart handling from 8250_of to the new 8250_pxa. As a corollary, add the early console definition into 8250_pxa. This enables to have the same uart node for the early console and the normal uart. Signed-off-by: Robert Jarzmik --- drivers/tty/serial/8250/8250_of.c

Re: [PATCH v2 1/4] cpufreq: pxa: use generic platdev driver for device-tree

2016-10-21 Thread Robert Jarzmik
Viresh Kumar writes: > On 19-10-16, 22:06, Robert Jarzmik wrote: >> Viresh Kumar writes: >> >> >> >> + { .compatible = "marvell,pxa250", }, >> >> >> + { .compatible = "marvell,pxa270&q

Re: [PATCH] Revert "dmaengine: pxa_dma: add support for legacy transition"

2016-10-20 Thread Robert Jarzmik
Arnd Bergmann writes: > On Tuesday, October 18, 2016 8:46:32 AM CEST Robert Jarzmik wrote: >> This reverts commit c91134d9194478144ba579ca6efeddf628055650. >> >> The conversion of the pxa architecture is now finished for all >> drivers, so this functions has ful

[PATCH] net: smc91x: fix neponset breakage by pxa u16 writes

2016-10-19 Thread Robert Jarzmik
wrongly removed include. Fixes: d09d747ae4c2 ("net: smc91x: isolate u16 writes alignment workaround") Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc91x.h b/drivers/net/ethernet/s

Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

2016-10-19 Thread Robert Jarzmik
Stephen Boyd writes: > On 10/18, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> Hi Michael and Stephen, >> >> I'm planing on sending a v2 next week with minor corrections, mostly in the >> data >> tables (pxa25x_freqs and pxa27x_freqs), a

Re: [PATCH v2 1/4] cpufreq: pxa: use generic platdev driver for device-tree

2016-10-19 Thread Robert Jarzmik
Viresh Kumar writes: >> >> + { .compatible = "marvell,pxa250", }, >> >> + { .compatible = "marvell,pxa270", }, >> >> >> >> { .compatible = "samsung,exynos3250", }, >> >> { .compatible = "samsung,exynos4210", }, >> > >> > Isn't there a race between cpufreq-dt and the platform driver to >> >

Re: [PATCH v2 1/4] cpufreq: pxa: use generic platdev driver for device-tree

2016-10-18 Thread Robert Jarzmik
Viresh Kumar writes: > On 15-10-16, 21:57, Robert Jarzmik wrote: >> For device-tree based pxa25x and pxa27x platforms, cpufreq-dt driver is >> doing the job as well as pxa2xx-cpufreq, so add these platforms to the >> compatibility list. >> >> This won't wor

Re: [PATCH v2 2/4] ARM: dts: pxa: add pxa25x cpu operating points

2016-10-18 Thread Robert Jarzmik
Viresh Kumar writes: > On 15-10-16, 21:57, Robert Jarzmik wrote: >> Add the relevant data taken from the PXA 25x Electrical, Mechanical, and >> Thermal Specfication. This will be input data for cpufreq-dt driver. >> >> Signed-off-by: Robert Jarzmik >> --- >&

Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

2016-10-18 Thread Robert Jarzmik
Robert Jarzmik writes: > This is the initial stage to transfer the pxa25x and pxa27x CPU clocks > handling from cpufreq to the clock API. More precisely, the clocks > transferred are : > - cpll : core pll, known also as the CPU core turbo frequency > - core : core, known also as

Re: [PATCH 1/2] media: platform: pxa_camera: add missing sensor power on

2016-10-17 Thread Robert Jarzmik
Robert Jarzmik writes: > During sensors binding, there is a window where the sensor is switched > off, while there is a call it to set a new format, which can end up in > an access to the sensor, especially an I2C based sensor. > > Remove this window by activating the sensor. Hi

Re: [PATCH] ARM: pxa: fix pxa25x interrupt init

2016-10-17 Thread Robert Jarzmik
Robert Jarzmik writes: > In the device-tree case, the root interrupt controller cannot be > accessed through the 6th coprocessor, contrary to pxa27x and pxa3xx > architectures. > > Fix it to behave as in non-devicetree builds. > > Fixes: 32f17997c130 ("ARM: pxa: remove

[PATCH] Revert "dmaengine: pxa_dma: add support for legacy transition"

2016-10-17 Thread Robert Jarzmik
This reverts commit c91134d9194478144ba579ca6efeddf628055650. The conversion of the pxa architecture is now finished for all drivers, so this functions has fullfilled its purpose and can now be removed. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 28

[PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-10-17 Thread Robert Jarzmik
king for object files both in source tree and potential destination tree. Signed-off-by: Robert Jarzmik --- scripts/tags.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index b3775a9604ea..c0220fa05617 100755 --- a/scripts/tags.sh +++ b/

[PATCH v3 4/4] net: smsc91x: add u16 workaround for pxa platforms

2016-10-17 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik Cc: Jeremy Linton --- Since v1: rename dt property to pxa-u16-align4 change the binding documentation file --- Documentation/devicetree

[PATCH v3 3/4] net: smc91x: take into account half-word workaround

2016-10-17 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- Since v1: rename dt property to pxa

[PATCH v3 1/4] ARM: pxa: enhance smc91x platform data

2016-10-17 Thread Robert Jarzmik
Instead of having the smc91x driver relying on machine_is_*() calls, provide this data through platform data, ie. idp, mainstone and stargate. This way, the driver doesn't need anymore machine_is_*() calls, which wouldn't work anymore with a device-tree build. Signed-off-by: Robe

[PATCH v3 0/4] support smc91x on mainstone and devicetree

2016-10-17 Thread Robert Jarzmik
to work on a device-tree build, exaclty as it's been working for years with the legacy arch/arm/mach-pxa/mainstone.c definition. As a sum up, this extends an existing mechanism to device-tree based pxa platforms. Cheers. -- Robert Robert Jarzmik (4): ARM: pxa: enhance smc91x platform data

[PATCH v3 2/4] net: smc91x: isolate u16 writes alignment workaround

2016-10-17 Thread Robert Jarzmik
pes. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik -- Since v2: fixed arch/mn10300 case removed machine_is_*() calls --- arch/mn10300/unit-asb2303/include/unit/smc9.h | 2

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-16 Thread Robert Jarzmik
Robert Jarzmik writes: > diff --git a/drivers/net/ethernet/smsc/smc91x.h > b/drivers/net/ethernet/smsc/smc91x.h > index ea8465467469..dff165ed106d 100644 > --- a/drivers/net/ethernet/smsc/smc91x.h > +++ b/drivers/net/ethernet/smsc/smc91x.h And there is also the specific case

Re: [PATCH v2 0/4] PXA cpufreq conversion to clock API

2016-10-15 Thread Robert Jarzmik
Russell King - ARM Linux writes: > On Sat, Oct 15, 2016 at 09:57:26PM +0200, Robert Jarzmik wrote: >> Hi, >> >> This serie is a preparation to shift the cpufreq of pxa2xx platforms to >> clocks >> API. >> >> The first 3 patches are review and me

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-15 Thread Robert Jarzmik
Sorry David, I just noticed you weren't in the "To:" of this serie, but I won't forget you for the v3 I need to release anyway (https://lkml.org/lkml/2016/10/15/104). Robert Jarzmik writes: > + lp->half_word_align4 = > + machine_is_mainst

[PATCH v2 4/4] cpufreq: pxa: convert to clock API

2016-10-15 Thread Robert Jarzmik
As the clock settings have been introduced into the clock pxa drivers, which are now available to change the CPU clock by themselves, remove the clock handling from this driver, and rely on pxa clock drivers. Signed-off-by: Robert Jarzmik --- Since v1: added !OF Kconfig dependency --- drivers

[PATCH v2 3/4] ARM: dts: pxa: add pxa27x cpu operating points

2016-10-15 Thread Robert Jarzmik
Add the relevant data taken from the PXA27x Electrical, Mechanical, and Thermal Specfication. This will be input data for cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi | 40 1 file changed, 40 insertions(+) diff

[PATCH v2 1/4] cpufreq: pxa: use generic platdev driver for device-tree

2016-10-15 Thread Robert Jarzmik
For device-tree based pxa25x and pxa27x platforms, cpufreq-dt driver is doing the job as well as pxa2xx-cpufreq, so add these platforms to the compatibility list. This won't work for legacy non device-tree platforms where pxa2xx-cpufreq is still required. Signed-off-by: Robert Ja

[PATCH v2 2/4] ARM: dts: pxa: add pxa25x cpu operating points

2016-10-15 Thread Robert Jarzmik
Add the relevant data taken from the PXA 25x Electrical, Mechanical, and Thermal Specfication. This will be input data for cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa25x.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm

[PATCH v2 0/4] PXA cpufreq conversion to clock API

2016-10-15 Thread Robert Jarzmik
in first as a prequisite Robert Jarzmik (4): cpufreq: pxa: use generic platdev driver for device-tree ARM: dts: pxa: add pxa25x cpu operating points ARM: dts: pxa: add pxa27x cpu operating points cpufreq: pxa: convert to clock API arch/arm/boot/dts/pxa25x.dtsi| 25 + arch

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

2016-10-15 Thread Robert Jarzmik
Robert Jarzmik writes: >> In that case, what about making this driver depends_on !CONFIG_OF ? So >> that the DT users don't use it anymore. > Good idea, let me try it. > I'll see if it actually works before make another iteration of this patch. Okay, it works all

[PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-15 Thread Robert Jarzmik
pes. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 6 ++- drivers/net/ethernet/smsc/smc91x.h | 78 +- 2 fi

[PATCH v2 2/3] net: smc91x: take into account half-word workaround

2016-10-15 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- Since v1: rename dt property to pxa

[PATCH v2 3/3] net: smsc91x: add u16 workaround for pxa platforms

2016-10-15 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik Cc: Jeremy Linton --- Since v1: rename dt property to pxa-u16-align4 change the binding documentation file --- Documentation/devicetree

[PATCH v2 0/3] support smc91x on mainstone and devicetree

2016-10-15 Thread Robert Jarzmik
to work on a device-tree build, exaclty as it's been working for years with the legacy arch/arm/mach-pxa/mainstone.c definition. Cheers. -- Robert Robert Jarzmik (3): net: smc91x: isolate u16 writes alignment workaround net: smc91x: take into account half-word workaround net: smsc91x: a

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-13 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Sun, 9 Oct 2016 22:33:45 +0200 > >> Writes to u16 has a special handling on 3 PXA platforms, where the >> hardware wiring forces these writes to be u32 aligned. >> >> This patch isolates this handling

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

2016-10-12 Thread Robert Jarzmik
Viresh Kumar writes: >> >> PXA architecture have both legacy platform_data based configurations and >> >> new >> >> devicetree based ones. >> > >> > I don't see any platform data specific code in this driver. What am I >> > missing ? >> >> In a legacy platform, ie. without devicetree, we have C

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

2016-10-12 Thread Robert Jarzmik
Viresh Kumar writes: > On 12-10-16, 08:22, Robert Jarzmik wrote: >> Viresh Kumar writes: >> >> > On 10-10-16, 22:09, Robert Jarzmik wrote: >> >> As the clock settings have been introduced into the clock pxa drivers, >> >> which are now availab

Re: [PATCH 6/6] cpufreq: pxa: convert to clock API

2016-10-11 Thread Robert Jarzmik
Viresh Kumar writes: > On 10-10-16, 22:09, Robert Jarzmik wrote: >> As the clock settings have been introduced into the clock pxa drivers, >> which are now available to change the CPU clock by themselves, remove >> the clock handling from this driver, and rely on pxa clock d

[PATCH 4/6] clk: pxa: export core clocks

2016-10-10 Thread Robert Jarzmik
pxaxxx_get_clk_frequency_khz() needs several clocks to be available through clk_get(), ie. the cpu clocks, system bus clock and memory clocks. Add the missing clkdev so that their rate can be acquired. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa25x.c | 9 ++--- drivers/clk

[PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

2016-10-10 Thread Robert Jarzmik
CPU core turbo frequency or the CPU core run frequency This transfer is a prequel to shrink the code in pxa2xx-cpufreq.c, so that it can become, at least in devicetree builds, the casual cpufreq-dt driver. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa.c| 128

[PATCH 6/6] cpufreq: pxa: convert to clock API

2016-10-10 Thread Robert Jarzmik
As the clock settings have been introduced into the clock pxa drivers, which are now available to change the CPU clock by themselves, remove the clock handling from this driver, and rely on pxa clock drivers. Signed-off-by: Robert Jarzmik --- drivers/cpufreq/pxa2xx-cpufreq.c | 191

[PATCH 3/6] clk: pxa: b bit of clkcfg means fast bus

2016-10-10 Thread Robert Jarzmik
The meaning of this bit was inverted : - when set to 0, system bus clock is half of the CPU run clock - when set to 1, system bus clock is the CPU run clock Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa27x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 2/6] clk: pxa: core pll is not affected by t bit

2016-10-10 Thread Robert Jarzmik
The t bit of clkfcfg doesn't affect the core pll clock, but it makes core clock select between core pll clock and core run clock. As such remove it from the core pll rate reporting function, while it remains in clk_pxa27x_core_get_parent(). Signed-off-by: Robert Jarzmik --- drivers/clk/px

[PATCH 1/6] clk: pxa: remove unused variables

2016-10-10 Thread Robert Jarzmik
This is a cleanup patch to remove unused values not used in their respective functions. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa27x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/clk/pxa/clk-pxa27x.c b/drivers/clk/pxa/clk-pxa27x.c index

<    1   2   3   4   5   6   7   8   9   10   >