On Fri, Oct 2, 2020 at 5:00 AM John Garry wrote:
>
> On 07/05/2020 15:08, Ian Rogers wrote:
>
> Hi Ian,
>
> I was wondering if you ever tested commit 2440689d62e9 ("perf
> metricgroup: Remove duped metric group events") for when we have a
> metric which alia
$(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC)
> > -Wl,--build-id=sha1 -o $@ -x c -
> > +$(OUTPUT)buildid-ex-md5:
> > + $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC)
> > -Wl,--build-id=md5 -o $@ -x c -
> > +endif
>
> Can we just build t
On 02/10/2020 14:07, Masami Hiramatsu wrote:
> On Thu, 1 Oct 2020 09:56:41 +0100
> Colin King wrote:
>
>> From: Colin Ian King
>>
>> More recent libc implementations are now using openat/openat2 system
>> calls so also add do_sys_openat2 to the t
On Thu, Oct 1, 2020 at 3:25 AM Jiri Olsa wrote:
>
> On Thu, Oct 01, 2020 at 11:25:34AM +0200, Jiri Olsa wrote:
> > On Wed, Sep 30, 2020 at 07:00:05PM -0700, Ian Rogers wrote:
> > > On Wed, Sep 30, 2020 at 10:15 AM Jiri Olsa wrote:
> > > >
> > > > Ad
On 01/10/2020 15:44, Steven Rostedt wrote:
> On Thu, 1 Oct 2020 09:56:41 +0100
> Colin King wrote:
>
>> From: Colin Ian King
>>
>> More recent libc implementations are now using openat/openat2 system
>> calls so also add do_sys_openat2 to the tracing so that th
.../tools/perf/buildid-ex-md5
> 1805c738c8f3ec0f47b7ea09080c28f34d18a82b /usr/lib64/ld-2.31.so
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/perf/util/dso.c | 2 +-
> tools/perf/util/dso.h | 1 -
> tools/perf/util/dsos.c | 6 --
>
have correct
> build id data and will be usable for debuginfod processing
> if needed (coming in following patches).
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/lib/perf/include/perf/event.h | 12 +++-
> tools/perf/util/build-id.c
On Wed, Sep 30, 2020 at 10:15 AM Jiri Olsa wrote:
>
> Passing build_id object to dso__build_id_equal, so we can
> properly check build id with different size than sha1.
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/perf/util/dso.c|
On Wed, Sep 30, 2020 at 10:15 AM Jiri Olsa wrote:
>
> Passing build_id object to dso__set_build_id, so it's easier
> to initialize dos's build id object.
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/perf/util/dso.c| 4 ++--
>
d85ebfff7
>
> instead of:
> a50e350e97c43b4708d09bcd85ebfff7
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/perf/builtin-buildid-cache.c| 6 ++--
> tools/perf/tests/sdt.c| 2 +-
> tools/perf/util/ann
On Wed, Sep 30, 2020 at 10:15 AM Jiri Olsa wrote:
>
> Passing build id object to sysfs__read_build_id function,
> so it can populate the size of the build_id object.
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/perf/util/build-id.c
On Wed, Sep 30, 2020 at 10:15 AM Jiri Olsa wrote:
>
> Passing build_id object to filename__read_build_id function,
> so it can populate the size of the build_id object.
>
> Changing filename__read_build_id code for both elf/non-elf
> code.
>
> Signed-off-by: Jiri Ols
is is preparatory change for following patches,
> and there's no functional change.
>
> Signed-off-by: Jiri Olsa
Acked-by: Ian Rogers
This reads a little funny but makes sense in the context of the rest
of the patch set.
Thanks,
Ian
> ---
> tools/perf/builtin-buildid-cache.c
On Wed, Sep 30, 2020 at 10:15 AM Jiri Olsa wrote:
>
> Adding test for build id cache that adds binary
> with sha1 and md5 build ids and verifies it's
> added properly.
>
> The test updates build id cache with perf record
> and perf buildid-cache -a.
>
> Signed-off-by
Hi,
static analysis with Coverity has found a null pointer dereference issue
with the following commit:
commit c620b772152b8274031083bdb2e11c963e596c5c
Author: Ariel Levkovich
Date: Thu Apr 30 05:54:08 2020 +0300
net/mlx5: Refactor tc flow attributes structure
The analysis is as
ould
generate the changes.
I believe Kajol Jain has some unmerged changes because there's a worry
about the interaction with the scripts and assumptions in jevents.
Having access to the scripts would mean that we could fix whatever
issues there would be.
Thanks,
Ian
...@kernel.org/
Signed-off-by: Ian Rogers
---
tools/perf/util/parse-events.c | 4 ++--
tools/perf/util/parse-events.h | 2 +-
tools/perf/util/parse-events.y | 8
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
On Wed, Sep 23, 2020 at 4:37 PM Nick Desaulniers
wrote:
>
> On Wed, Sep 23, 2020 at 2:07 PM 'Ian Rogers' via Clang Built Linux
> wrote:
> >
> > Ensure 'st' is initialized before an error branch is taken.
> > Fixes test "67: Parse and process metrics"
t; +
> + rblist__init(_events);
> + ret = test_expand_events(evlist, _events);
> + evlist__delete(evlist);
> + return ret;
> +}
> +
> +static int expand_group_events(void)
> +{
> + int ret;
> + struct evlist *evlist;
> +
ild-id injection took: 18.441 msec (+- 0.106 msec)
> Average time per event: 1.808 usec (+- 0.010 usec)
> Average build-id-all injection took: 13.451 msec (+- 0.132 msec)
> Average time per event: 1.319 usec (+- 0.013 usec)
>
> Signed-off-by: Namhyung Kim
Acked-by: Ian Roger
e --buildid-all option too.
>
> Original-patch-by: Stephane Eranian
> Signed-off-by: Namhyung Kim
Acked-by: Ian Rogers
Thanks,
Ian
> ---
> tools/perf/Documentation/perf-inject.txt | 6 +-
> tools/perf/builtin-inject.c | 112 ++-
> 2
On Wed, Sep 23, 2020 at 1:05 AM Namhyung Kim wrote:
>
> Sometimes I can see perf record piped with perf inject take long time
> processing build-id. So add inject-build-id benchmark to the
> internals benchmark suite to measure its overhead regularly.
>
> It runs perf inject command internally
perf.c:539:3
Fixes: commit f5a56570a3f2 ("perf test: Fix memory leaks in parse-metric test")
Signed-off-by: Ian Rogers
---
tools/perf/tests/parse-metric.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.
atch on latest perf/core, it seemed OK.
>
> # git log --oneline
> 4cbdb1c21926 (HEAD -> perf/core) perf vendor events: Update CascadelakeX
> events to v1.08
> b1f815c479c1 (tag: perf-tools-tests-v5.10-2020-09-10, origin/perf/core) perf
> vendor events power9:
> Add hv_24
On Thu, Sep 17, 2020 at 6:47 PM Namhyung Kim wrote:
>
> Hi Arnaldo,
>
> On Fri, Sep 18, 2020 at 5:39 AM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Thu, Sep 17, 2020 at 01:18:07PM -0700, Ian Rogers escreveu:
> > > A metric like DRAM_BW_Use has on SkylakeX eve
> - "perf list []
> [hw|sw|cache|tracepoint|pmu|sdt|metric|metricgroup|event_glob]",
> + "perf list []
> [hw|sw|cache|tracepoint|pmu|sdt|metric|metricgroup|pfm|event_glob]",
Should this be "#ifdef HAVE_LIBPFM" to avoid advertis
for the MSVC code generation team as
well as the (interim) team for the Linux tools team that i built and lead last
year. He has inherited the various efforts my team was working on and is the
right contact going forward to collaborate on Linux compiler and tools efforts.
ian Bearman
Principal Software
On 22/09/2020 13:43, Jim Quinlan wrote:
> On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring wrote:
>>
>>> The error return ret is not being check with an if statement and
>>
>> Wording alternative:
>> The return value from a call of the function “brcm_phy_start” was not
>> checked and
>>
>>
>>> V2:
I believe these patches should have gone directly to me and not various
other folk.
Colin
On 22/09/2020 08:27, Piyush Goyal wrote:
> Exercise shmat syscall with invalid flags resulting in more kernel
> coverage.
>
> Signed-off-by: Piyush Goyal
> ---
> stress-shm-sysv.c | 14 ++
>
}
>
> Currently, our STB upstream suspend/resume is not functional yet and
> this is how this omission slipped by testing.
>
> Thanks,
> Jim Quinlan
> Broadcom STB
>
> On Mon, Sep 21, 2020 at 3:43 PM Florian Fainelli wrote:
>>
>> On 9/21/20 7:40 AM, Colin
On 18/09/2020 19:00, Dan Carpenter wrote:
> Smatch just ignores these because they're often done deliberately.
>
> regards,
> dan carpenter
>
And I ignore fixing them when coverity reports them because life is too
short.
Colin
On 18/09/2020 17:22, Guido Günther wrote:
> Hi,
> On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently a null pointer check on pointer mode is passing mode to
>> function drm_mode_vrefresh and this causes a null pointe
Should be ok. I cherry-picked the patch on to a local checkout of
perf/urgent and sent as an in-reply-to here:
https://lore.kernel.org/lkml/20200917190026.gb1426...@kernel.org/T/#m6c12d6a224540ed5f222e58fff9807f1cdc4238f
Thanks,
Ian
On Thu, Sep 17, 2020 at 12:00 PM Arnaldo Carvalho de Melo
uot;).
Fixes: ded80bda8bc9 ("perf expr: Migrate expr ids table to a hashmap").
Reported-by: Jin Yao
Signed-off-by: Ian Rogers
---
tools/perf/util/metricgroup.c | 75 ++-
1 file changed, 56 insertions(+), 19 deletions(-)
diff --git a/tools/perf/util/metricgr
On Wed, Sep 16, 2020 at 12:12 AM Namhyung Kim wrote:
>
> Hello Ian and David,
>
> Thank you for the good suggestions!
>
> On Wed, Sep 16, 2020 at 4:56 AM David Malcolm wrote:
> > Some ideas (with the caveat that I'm a GCC developer, and not a regular
> > on LKML):
;
> > + event->mmap3.pid = machine->pid;
> > +
> > + memcpy(event->mmap3.filename, pos->dso->long_name,
> > pos->dso->long_name_len + 1);
> > +
> >
ry allocation is a request to own the memory.
There was a talk about GCC's -fanalyzer option doing malloc/free
checking at Linux plumbers 2 weeks ago:
https://linuxplumbersconf.org/event/7/contributions/721/attachments/542/961/2020-LPC-analyzer-talk.pdf
I added David Malcolm, the LPC presenter,
On 15/09/2020 18:12, Sean Young wrote:
> On Tue, Sep 15, 2020 at 04:36:08PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently the LIRC_GET_MIN_TIMEOUT is checking for a null dev->max_timeout
>> and then accessing dev->min_timeout, hence we may
-config,percore,aux-output,aux-sample-size'
The 01.org version of this from:
https://download.01.org/perfmon/TMA_Metrics.xlsx
is:
UNC_ARB_TRK_OCCUPANCY.DATA_READ / UNC_ARB_TRK_OCCUPANCY.DATA_READ:c1
It seems that :c1 has been translated into thresh=1 but that thresh
doesn't exist as a format option (just "cmask
uld avoid
> a lot of that penalty, by avoiding having to parse the perf.data file
> and leveraging the fact that the buildid may be in memory already.
> Although my concern on
> this has to do with large pages and the impact they have on alignment
> of sections in memory. I think Ian
On Mon, Sep 14, 2020 at 2:51 PM Arnaldo Carvalho de Melo
wrote:
>
> Em Mon, Sep 14, 2020 at 06:46:55PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Sep 11, 2020 at 07:56:54PM -0700, Ian Rogers escreveu:
> > > If events in a group explicitly set a frequency
ere are some workarounds like
commit c8f6ae1fb28d (perf inject jit: Remove //anon mmap events).
Perhaps these events can switch to reporting the length the mmap
requested rather than the length of the vma?
I could imagine that changes here could be interesting to folks doing
CHERI or hypervisors, for example, they may want more address bits.
BPF has stack traces with elements of buildid + offset. Using these in
perf samples would avoid the need for mmap events, synthesis, etc. but
at the cost of larger and possibly slower stack traces. Perhaps we
should just remove the idea of mmap events altogether?
Thanks,
Ian
Memory sanitizer warns if a write is performed where the memory
being read for the write is uninitialized. Avoid this warning by
initializing the memory.
Signed-off-by: Ian Rogers
---
tools/perf/bench/sched-messaging.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Fri, Sep 11, 2020 at 3:34 PM Ian Rogers wrote:
>
> On Fri, Sep 4, 2020 at 11:51 AM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Fri, Sep 04, 2020 at 03:50:13PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Sep 04, 2020 at 03:48:03PM -0300, Arnaldo Ca
the problem by preventing override for
events with attr->sample_period != 0 by the time
perf_evsel__config() is invoked. This seems to have been the
intent of the author.
Signed-off-by: Stephane Eranian
Reviewed-by: Ian Rogers
Signed-off-by: Ian Rogers
---
tools/perf/util/evsel.c | 3 +--
1 file chan
pling configuration")
Signed-off-by: Ian Rogers
---
tools/perf/util/record.c | 34 ++
1 file changed, 26 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c
index a4cc11592f6b..ea9aa1d7cf50 100644
--- a/tools/perf/util/reco
Add test that a sibling with leader sampling doesn't have its period
cleared.
Signed-off-by: Ian Rogers
---
tools/perf/tests/attr/README | 1 +
tools/perf/tests/attr/test-record-group2 | 29
2 files changed, 30 insertions(+)
create mode 100644 tools/perf
igned-off-by: David Sharp
Signed-off-by: Ian Rogers
---
tools/perf/util/evsel.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index fd865002cbbd..3e985016da7e 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/uti
.
David Sharp (1):
perf record: Set PERF_RECORD_PERIOD if attr->freq is set.
Ian Rogers (2):
perf record: Don't clear event's period if set by a term
perf test: Leader sampling shouldn't clear sample period
Stephane Eranian (1):
perf record: Prevent override of attr->sample_
On Fri, Sep 4, 2020 at 11:51 AM Arnaldo Carvalho de Melo
wrote:
>
> Em Fri, Sep 04, 2020 at 03:50:13PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Sep 04, 2020 at 03:48:03PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Sep 04, 2020 at 09:22:10AM -0700
Hi,
Static analysis with Coverity has detected an issue with the following
commit:
commit 30deae31eab501f568aadea45cfb3258b9e522f5
Author: Darrick J. Wong
Date: Wed Aug 26 10:48:50 2020 -0700
xfs: support inode btree blockcounts in online repair
the analysis is as follows:
830
t; As a workaround, let's disable GCOV build for broken GCC 10 version.
>>
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1891288
>> [2] https://lore.kernel.org/lkml/20200827133932.3338519-1-l...@kernel.org
>> Cc: Colin Ian King
>> Signed-off-by: Leon Romano
On Wed, Sep 9, 2020 at 10:51 PM Namhyung Kim wrote:
>
> On Thu, Sep 10, 2020 at 12:26 PM Ian Rogers wrote:
> >
> > A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/
> > and uncore_imc/case_count_write/. These events open 6 events per s
2e9 ("perf metricgroup: Remove duped metric group events").
Fixes: ded80bda8bc9 ("perf expr: Migrate expr ids table to a hashmap").
Reported-by: Jin Yao
Signed-off-by: Ian Rogers
---
tools/perf/util/metricgroup.c | 75 ++-
1 file change
ant not to get too distracted
by desires for better syntax, as this change makes a benefit in a way
that works with the existing flags. If it is accepted, the man pages
need to be updated.
Thanks,
Ian
On Wed, Sep 9, 2020 at 10:52 AM Ian Rogers wrote:
>
> On Wed, Sep 9, 2020 at 2:53 AM Namhyung Kim wrote:
> >
> > Hi Ian,
> >
> > On Wed, Sep 9, 2020 at 5:02 PM Ian Rogers wrote:
> > >
> > > A metric like DRAM_BW_Use has on SkylakeX events
>
Add missing character.
Signed-off-by: Ian Rogers
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 8831b964288f..662f4e8777d5 100644
--- a/tools/perf/util/metricgroup.c
+++ b
der computation
that was broken in the same commits.
Erroneous duplication introduced in:
commit 2440689d62e9 ("perf metricgroup: Remove duped metric group events").
Fixes: ded80bda8bc9 ("perf expr: Migrate expr ids table to a hashmap").
Reported-by: Jin Yao
Signed-off-by: Ian
No need to set os.evsel twice.
Signed-off-by: Ian Rogers
---
tools/perf/util/stat-display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 493ec372fdec..4b57c0c07632 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools
On Wed, Sep 9, 2020 at 2:53 AM Namhyung Kim wrote:
>
> Hi Ian,
>
> On Wed, Sep 9, 2020 at 5:02 PM Ian Rogers wrote:
> >
> > A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/
> > and uncore_imc/case_count_write/. These events open 6 events
On Wed, Sep 9, 2020 at 1:33 AM Jin, Yao wrote:
>
>
>
> On 9/9/2020 4:02 PM, Ian Rogers wrote:
> > A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/
> > and uncore_imc/case_count_write/. These events open 6 events per socket
> > wit
Add missing character.
Signed-off-by: Ian Rogers
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index d216a161f41c..050f3404c137 100644
--- a/tools/perf/util/metricgroup.c
+++ b
uot;).
Fixes: ded80bda8bc9 ("perf expr: Migrate expr ids table to a hashmap").
Reported-by: Jin, Yao
Signed-off-by: Ian Rogers
---
tools/perf/util/metricgroup.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/u
No need to set os.evsel twice.
Signed-off-by: Ian Rogers
---
tools/perf/util/stat-display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 493ec372fdec..4b57c0c07632 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 93921baa3f6ff77e57d7e772165aa7bd709b5387
Gitweb:
https://git.kernel.org/tip/93921baa3f6ff77e57d7e772165aa7bd709b5387
Author:Colin Ian King
AuthorDate:Mon, 10 Aug 2020 08:55:08 +01:00
On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote:
>
> On Thu, Sep 03, 2020 at 10:41:14PM -0700, Ian Rogers wrote:
> > On Wed, Jul 29, 2020 at 4:24 PM Ian Rogers wrote:
> > >
> > > On Tue, Jul 28, 2020 at 9:10 AM Jiri Olsa wrote:
> > > >
> > > &g
[I have posted these patches previously, but that was over a year ago.
--IA]
A couple of minor changes to the wiimote core module. They do not
change functionality of the driver:
1) HID: wiimote: make handlers[] const
2) HID: wiimote: narrow spinlock range in wiimote_hid_event()
In `wiimote_hid_event()`, the `wdata->state.lock` spinlock does not need
to be held while searching `handlers[]` for a suitable handler function.
Change it so the spinlock is only held during the call to the handler
function itself.
Signed-off-by: Ian Abbott
---
drivers/hid/hid-wiimote-cor
The `handlers[]` array contents are never modified, so use the `const`
qualifier.
Signed-off-by: Ian Abbott
---
drivers/hid/hid-wiimote-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
index
On Thu, Aug 27, 2020 at 12:00 AM kajoljain wrote:
>
>
>
> On 8/26/20 9:27 PM, Jiri Olsa wrote:
> > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote:
> >> This patch resolves some undefined behavior where variables in
> >> expr_id_data were accessed (
On Wed, Sep 2, 2020 at 12:48 PM Rob Herring wrote:
>
> On Wed, Sep 2, 2020 at 12:07 PM Ian Rogers wrote:
> >
> > On Fri, Aug 28, 2020 at 1:56 PM Rob Herring wrote:
> > >
> > > x86 and arm64 can both support direct access of event counters in
> > >
On Thu, Sep 3, 2020 at 11:27 AM Kim Phillips wrote:
>
> On 9/3/20 1:19 AM, Ian Rogers wrote:
> > On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips wrote:
> >> The nps1_die_to_dram event may need perf stat's --metric-no-group
> >> switch if the number of available data fab
On Tue, Aug 4, 2020 at 8:50 AM Ian Rogers wrote:
>
> On Tue, Aug 4, 2020 at 7:49 AM Adrian Hunter wrote:
> >
> > On 4/08/20 4:33 pm, Ian Rogers wrote:
> > > On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter
> > > wrote:
> > >>
> > >&g
On Wed, Jul 29, 2020 at 4:24 PM Ian Rogers wrote:
>
> On Tue, Jul 28, 2020 at 9:10 AM Jiri Olsa wrote:
> >
> > On Tue, Jul 28, 2020 at 05:59:46PM +0200, Jiri Olsa wrote:
> > > On Tue, Jul 28, 2020 at 01:57:31AM -0700, Ian Rogers wrote:
> > > > From: S
On Wed, Jul 29, 2020 at 2:43 PM Ian Rogers wrote:
>
> On Wed, Jul 29, 2020 at 11:52 AM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers escreveu:
> > > From: David Sharp
> > >
> > > evsel__config()
On Thu, Sep 3, 2020 at 11:44 AM Arnaldo Carvalho de Melo
wrote:
>
> Hi Ian,
>
> Please check that this is ok with you,
>
> Thanks,
>
> - Arnaldo
Thanks Arnaldo, this looks good to me! There is a separate issue, the
casts are necessary as we have PE_VALUEs that ar
On Thu, Sep 3, 2020 at 8:21 PM Namhyung Kim wrote:
>
> I found some memory leaks while reading the metric code. Some are
> real and others only occur in the error path.
Thanks Namhyung! Is it possible to get test coverage?
Ian
> Cc: Kajol Jain
> Cc: John Garry
> Cc: I
On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote:
>
> The new string should have enough space for the original string and
> the back slashes IMHO.
>
> Cc: John Garry
> Cc: Kajol Jain
> Cc: Ian Rogers
> Signed-off-by: Namhyung Kim
Reviewed-by: Ian Rogers
Definitely
On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips wrote:
>
> This enables zen3 users by reusing mostly-compatible zen2 events
> until the official public list of zen3 events is published in a
> future PPR.
>
> Signed-off-by: Kim Phillips
Acked-by: Ian Rogers
Thanks!
Ian
> Cc:
t; Cc: Alexander Shishkin
> Cc: Jiri Olsa
> Cc: Namhyung Kim
> Cc: Vijay Thakkar
> Cc: Andi Kleen
> Cc: John Garry
> Cc: Kan Liang
> Cc: Yunfeng Ye
> Cc: Jin Yao
> Cc: "Martin Liška"
> Cc: Borislav Petkov
> Cc: Jon Grimm
> Cc: Martin Jambor
Performance counter stats for 'sleep 1':
>
> 0 cpu/event=0x94/u
>190,744 cpu/event=0x94,umask=0xff/u
>
> Signed-off-by: Kim Phillips
Acked-by: Ian Rogers
Thanks,
Ian
> Cc: Peter Zijlstra
> Cc: Ingo Molnar
> Cc: Arnaldo Carvalho de Melo
R) for AMD Family 17h Model 01h, Revision
> B1 Processors Rev 1.14 - April 15, 2017
>
> But e.g., are included in this 2019 version of the PPR:
>
> Processor Programming Reference (PPR) for AMD Family 17h Model 18h, Revision
> B1 Processors Rev. 3.14 - Sep 26, 2019
>
> Signed-o
On 02/09/2020 20:03, Markus Elfring wrote:
>> Currently when an xa_alloc failure occurs the error exit path leaks
>> the allocated object mc. Fix this by adding an error return path
>> that frees mc and rename error exit paths err3 to err4 and err2 to err3.
>
> I propose to choose further
6 width = READ_ONCE(pc->pmc_width);
> +
> + evcnt <<= 64 - width;
> + evcnt >>= 64 - width;
> + cnt += evcnt;
> + } else
> + return -1;
> +
> +
On 02/09/2020 17:43, Gustavo A. R. Silva wrote:
> On Wed, Sep 02, 2020 at 09:29:31AM -0700, Randy Dunlap wrote:
>> On 9/2/20 9:23 AM, Gustavo A. R. Silva wrote:
>>> A few months ago, commit e132fc6bb89b ("power: supply: charger-manager:
>>> Make decisions focussed on battery status")
>>> changed
lti-threaded synthesize benchmark")
> Signed-off-by: YueHaibing
Acked-by: Ian Rogers
Thanks!
Ian
> ---
> tools/perf/bench/synthesize.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/synthesize.c b/tools/perf/bench/synthesi
On 02/09/2020 12:13, David Laight wrote:
> From: Colin Ian King
>> Sent: 02 September 2020 11:27
>>
>> On 14/03/2020 10:23, Rafael J. Wysocki wrote:
>>> On Thursday, March 12, 2020 12:13:45 PM CET Colin King wrote:
>>>> From: Colin Ian King
>>>
On 14/03/2020 10:23, Rafael J. Wysocki wrote:
> On Thursday, March 12, 2020 12:13:45 PM CET Colin King wrote:
>> From: Colin Ian King
>>
>> Reading ACPI data on ARM64 at a non-aligned offset from
>> /sys/firmware/acpi/tables/data/BERT will cause a splat because
>&
63): []
> _raw_spin_unlock_irqrestore+0x8e/0xb0
> hardirqs last disabled at (326464): []
> _raw_spin_lock_irqsave+0x34/0xa0
> hardirqs last disabled at (326464): []
> _raw_spin_lock_irqsave+0x34/0xa0
> softirqs last enabled at (320794): []
> __do_softirq+0x931/0xbc4
> softir
On Wed, Aug 26, 2020 at 7:06 PM Paul A. Clarke wrote:
>
> On Wed, Aug 26, 2020 at 09:26:40AM -0700, Ian Rogers wrote:
> > On Fri, Aug 14, 2020 at 5:43 AM Arnaldo Carvalho de Melo
> > wrote:
> > > Em Fri, Aug 14, 2020 at 11:20:42AM +0530, kajoljain escreveu:
> > &
On Fri, Aug 14, 2020 at 5:43 AM Arnaldo Carvalho de Melo
wrote:
>
> Em Fri, Aug 14, 2020 at 11:20:42AM +0530, kajoljain escreveu:
> >
> >
> > On 8/14/20 9:13 AM, Ian Rogers wrote:
> > > On Thu, Aug 13, 2020 at 3:21 PM Paul A. Clarke wrote:
> > >>
&
On Wed, Aug 26, 2020 at 4:34 AM Jiri Olsa wrote:
>
> On Tue, Aug 25, 2020 at 09:29:09PM -0700, Ian Rogers wrote:
> > This patch resolves some undefined behavior where variables in
> > expr_id_data were accessed (for debugging) without being defined. To
> > better enforce t
This patch resolves some undefined behavior where variables in
expr_id_data were accessed (for debugging) without being defined. To
better enforce the tagged union behavior, the struct is moved into
expr.c and accessors provided. Tag values (kinds) are explicitly
identified.
Signed-off-by: Ian
With a fake_pmu the pmu_info isn't populated by perf_pmu__check_alias.
In this case, don't try to copy the uninitialized values to the evsel.
Signed-off-by: Ian Rogers
---
tools/perf/util/parse-events.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff
This patch resolves some undefined behavior where variables in
expr_id_data were accessed (for debugging) without being defined. To
better enforce the tagged union behavior, the struct is moved into
expr.c and accessors provided. Tag values (kinds) are explicitly
identified.
Signed-off-by: Ian
The marco map_for_each_event() loops over that
> array tests for members metric_expr/metric_name/metric_group
> being non-NULL. Adding this element fixes the issue.
>
> Output after:
> [root@t35lp46 perf]# ./perf test
* multiple reads on the status register to achieve this).
*/
while (--loops) {
status = inb(dev->iobase + DAQP_STATUS_REG);
--
-=( Ian Abbott || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 0
;
> Signed-off-by: Matthew Wilcox (Oracle)
Acked-by: Ian Kent
Thanks Matthew, I certainly want to know about changes to autofs
made by others so thanks for sending this to me.
At the same time I need to send my patches via someone else as
Linus asked me to do ages ago now.
So, once again Andrew,
Hi,
static analysis with Coverity has detected a duplicated assignment issue
with the following commit:
commit 2d4bcbed5b7d53e19fc158885e7340b464b64507
Author: Carl Huang
Date: Mon Aug 17 13:31:51 2020 +0300
ath11k: initialize wmi config based on hw_params
The analysis is as follows:
Hi,
static analysis with coverity has found a buffer overflow issue with the
brcmstb driver, I believe it may have been introduced with the following
commit:
commit a7c25759d8d84b64c437a78f05df7314b02934e5
Author: Markus Mayer
Date: Tue Apr 2 16:01:00 2019 -0700
memory: brcmstb: dpfe:
301 - 400 of 7811 matches
Mail list logo
