Hi Pramod,
On 9/15/2016 7:28 PM, Pramod Gurav wrote:
On 15 September 2016 at 15:49, Ulf Hansson wrote:
On 15 September 2016 at 09:59, Pramod Gurav wrote:
On 9 September 2016 at 15:48, Georgi Djakov wrote:
On 09/08/2016 11:02 AM, Adrian Hunter wrote:
On 01/09/16 17:23, Pramod Gurav wrote:
Hi Ulf,
On 9/23/2016 3:37 PM, Ulf Hansson wrote:
[...]
Is there anything else needed in msm sdhci driver so that the auto
tuning is taken care of?
I am not familiar with any other than sdhci-esdhc-imx which supports
the SDHCI_TUNING_MODE_3. I may be wrong though.
In the sdhci-esdhc-imx ca
On 3/7/2019 11:46 PM, Sowjanya Komatineni wrote:
On 3/6/2019 6:30 PM, Adrian Hunter wrote:
On 2/03/19 7:20 AM, Sowjanya Komatineni wrote:
This patch adds a quirk for setting CMD_TIMING to 1 in descriptor for
DCMD with R1B response type to allow the command to be sent to device
during data act
On 3/14/2019 3:15 AM, Sowjanya Komatineni wrote:
This patch adds update_dcmd_desc interface to cqhci_host_ops to
allow hosts to update any of the DCMD task descriptor attributes
and parameters.
Tested-by: Jon Hunter
Signed-off-by: Sowjanya Komatineni
Thanks,
Reviewed-by: Ritesh Harjani
thru NVQUIRK_CQHCI_DCMD_R1B_CMD_TIMING
for Tegra186 and also implements update_dcmd_desc of cqhci_host_ops
interface to set CMD_TIMING bit depending on the NVQUIRK.
Tested-by: Jon Hunter
Signed-off-by: Sowjanya Komatineni
Thanks,
Reviewed-by: Ritesh Harjani
---
drivers/mmc/host/sdhci
On 5/29/20 5:41 PM, Stephen Rothwell wrote:
Hi all,
Commit
560d6b3da024 ("ext4: mballoc: fix possible NULL ptr & remove BUG_ONs from
DOUBLE_CHECK")
is missing a Signed-off-by from its author.
My bad. I guess it got missed due to the three dotted lines.
https://patchwork.ozlabs.org/pr
Implement ext4_mb_discard_preallocations_should_retry()
which we will need in later patches to add more logic
like check for sequence number match to see if we should
retry for block allocation or not.
There should be no functionality change in this patch.
Signed-off-by: Ritesh Harjani
---
fs
y/blob/master/tools/test_mballoc.sh
[2]:
https://lkml.kernel.org/linux-ext4/cover.1589086800.git.rite...@linux.ibm.com/
Ritesh Harjani (5):
ext4: mballoc: Add blocks to PA list under same spinlock after allocating
blocks
ext4: mballoc: Refactor ext4_mb_discard_preallocations()
ext4: mballoc:
() which should be
called when without holding ext4_lock_group().
Also in further patches we hold the spinlock (ext4_lock_group()) while
doing any calculations which involves grp->bb_free or grp->bb_fragments.
Signed-off-by: Ritesh Harjani
---
fs/ext4/mballoc.
eturn -ENOSPC error. (Since the seq counter for all of
those will match as no block allocation/discard was done during that
duration).
Signed-off-by: Ritesh Harjani
---
fs/ext4/mballoc.c | 56 ++-
1 file changed, 51 insertions(+), 5 deletions(-)
diff
ch
could be freed from the PA
Signed-off-by: Ritesh Harjani
---
fs/ext4/mballoc.c | 97 ++-
1 file changed, 62 insertions(+), 35 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 33a69424942c..decc5168d126 100644
--- a/fs/ext4/mballo
may
not have considered blocks about to be discarded from PA lists).
So during retry attempt to allocate blocks we will use ext4_lock_group()
for checking if the group is good or not.
Signed-off-by: Ritesh Harjani
---
fs/ext4/ext4.h | 2 ++
fs/ext4/mballoc.c | 13
On 8/3/20 4:31 AM, Dave Chinner wrote:
On Wed, Jul 29, 2020 at 02:15:18PM +0530, Ritesh Harjani wrote:
For systems which do not have CONFIG_PREEMPT set and
if there is a heavy multi-threaded load/store operation happening
on pmem + sometimes along with device latencies, softlockup warnings
-off-by: Ritesh Harjani
---
fs/ext4/ext4.h | 1 +
fs/ext4/file.c | 2 +-
fs/ext4/inode.c | 8 +++-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 42f5060f3cdf..9a2138afc751 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -3232,6
ops,
will be better here. We could check for overwrite in ext4_dax_write_iter(),
like how we do for DIO writes. Thoughts?
3. This problem was reported by Dan Williams at [1]
Links
==
[1]: https://lore.kernel.org/linux-ext4/20190802144304.gp25...@quack2.suse.cz/T/
Ritesh Harjani (1):
On 8/20/20 6:23 PM, Jan Kara wrote:
On Thu 20-08-20 17:06:28, Ritesh Harjani wrote:
Currently in case of DAX, we are starting a transaction
everytime for IOMAP_WRITE case. This can be optimized
away in case of an overwrite (where the blocks were already
allocated). This could give a
On 8/4/20 3:21 AM, Dave Chinner wrote:
On Mon, Aug 03, 2020 at 12:44:04PM +0530, Ritesh Harjani wrote:
On 8/3/20 4:31 AM, Dave Chinner wrote:
On Wed, Jul 29, 2020 at 02:15:18PM +0530, Ritesh Harjani wrote:
For systems which do not have CONFIG_PREEMPT set and
if there is a heavy multi
On 8/10/20 7:51 AM, Xu Wang wrote:
seq_puts is a lot cheaper than seq_printf, so use that to print
literal strings.
Signed-off-by: Xu Wang
Looks good to me.
Reviewed-by: Ritesh Harjani
task_struct addr in lx-ps cmd seems helpful
TASK PIDCOMM
0x82c2b8c0 0 swapper/0
0x888a0ba20040 1 systemd
0x888a0ba24040 2 kthreadd
0x888a0ba28040 3 rcu_gp
Signed-off-by: Ritesh Harjani
---
scripts/gdb/linux/tasks.py | 9 +
1 file
I was using these structs info internally in my gdb scripts.
So sending it out for merge to upstream.
Ritesh Harjani (2):
proc: Add struct mount & struct super_block addr in lx-mounts command
tasks: Add task_struct addr for lx-ps cmd
scripts/gdb/linux/lists.py
0x888a0bb51000 devtmpfs devtmpfs /dev rw ,relatime 0 0
Signed-off-by: Ritesh Harjani
---
scripts/gdb/linux/proc.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
index 6a56bba233a9..c16fab981bdd 100644
On 8/18/20 11:07 AM, Jan Kiszka wrote:
On 18.08.20 06:04, Ritesh Harjani wrote:
This is many times found useful while debugging some FS related issue.
mount super_block fstype devname pathname options
0x888a0bfa4b40 0x888a0bfc1000 rootfs none / rw 0 0
On 8/18/20 11:10 AM, Jan Kiszka wrote:
On 18.08.20 06:04, Ritesh Harjani wrote:
task_struct addr in lx-ps cmd seems helpful
TASK PIDCOMM
0x82c2b8c0 0 swapper/0
0x888a0ba20040 1 systemd
0x888a0ba24040 2 kthreadd
0x888a0ba28040 3 rcu_gp
I was using these structs info internally in my gdb scripts.
So sending it out for merge to upstream.
Patch-2 is just adding some headers and improves spacing.
--
2.25.4
0x888a0bb51000 devtmpfs /dev devtmpfs rw,relatime 0 0
Signed-off-by: Ritesh Harjani
---
scripts/gdb/linux/proc.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
index 6a56bba233a9..09cd871925a5 100644
--- a
3 rcu_gp
Signed-off-by: Ritesh Harjani
---
scripts/gdb/linux/tasks.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
index 0301dc1e0138..17ec19e9b5bf 100644
--- a/scripts/gdb/linux/tasks.py
+++ b/scripts/gdb
On 8/19/20 8:24 AM, Wang Hai wrote:
Remove linux/fiemap.h which is included more than once
Reported-by: Hulk Robot
Signed-off-by: Wang Hai
LGTM, please feel free to add,
Reviewed-by: Ritesh Harjani
---
fs/ext2/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2
On 3/19/21 7:22 AM, Shiyang Ruan wrote:
From: Shiyang Ruan
This patchset is attempt to add CoW support for fsdax, and take XFS,
which has both reflink and fsdax feature, as an example.
Thanks for the patchset. I have tried reviewing the series from logical
correctness and to some extent f
: Shiyang Ruan
Reviewed-by: Christoph Hellwig
---
fs/dax.c | 152 ++-
1 file changed, 84 insertions(+), 68 deletions(-)
Refactoring & the changes looks good to me.
Feel free to add.
Reviewed-by: Ritesh Harjani
1 file changed, 12 insertions(+), 4 deletions(-)
Like the naming convention. It is consistent with
dax_direct_access() function.
Changes looks good to me. Feel free to add.
Reviewed-by: Ritesh Harjani
On 3/19/21 7:22 AM, Shiyang Ruan wrote:
The core logic in the two dax page fault functions is similar. So, move
the logic into a common helper function. Also, to facilitate the
addition of new features, such as CoW, switch-case is no longer used to
handle different iomap types.
Signed-off-by:
On 3/19/21 7:22 AM, Shiyang Ruan wrote:
In the case where the iomap is a write operation and iomap is not equal
to srcmap after iomap_begin, we consider it is a CoW operation.
The destance extent which iomap indicated is new allocated extent.
So, it is needed to copy the data from srcmap to n
On 21/03/27 04:00PM, Bhaskar Chowdhury wrote:
> This patch series fixed few mundane typos in the below specific files.
>
> Bhaskar Chowdhury (8):
> EXT4: migrate.c: Fixed few typos
> EXT4: namei.c: Fixed a typo
> EXT4: inline.c: A typo fixed
> Fix a typo
> EXT4: indirect.c: A trivial typo
> + if (!sync)
> + insert_flags |= DAX_IF_DIRTY;
> + if (iomap->flags & IOMAP_F_SHARED)
> + insert_flags |= DAX_IF_COW;
> + }
> +
> + entry = dax_insert_entry(xas, vmf, entry, pfn, 0, insert_flags);
>
> if (write && srcmap->addr != iomap->addr) {
> err = dax_iomap_cow_copy(pos, size, size, srcmap, kaddr, false);
>
Rest looks good to me. Please feel free to add
Reviewed-by: Ritesh Harjani
sorry about changing my email in between of this code review.
I am planning to use above gmail id as primary account for all upstream work
from now.
> --
> 2.30.1
>
>
>
, kaddr + offset, size);
}
dax_read_unlock(id);
return rc < 0 ? rc : size;
Other than that looks good.
Feel free to add.
Reviewed-by: Ritesh Harjani
On 21/03/19 09:52AM, Shiyang Ruan wrote:
> Some operations, such as comparing a range of data in two files under
> fsdax mode, requires nested iomap_open()/iomap_end() on two file. Thus,
> we introduce iomap_apply2() to accept arguments from two files and
> iomap_actor2_t for actions on two files.
On 21/03/19 09:52AM, Shiyang Ruan wrote:
> With dax we cannot deal with readpage() etc. So, we create a dax
> comparison funciton which is similar with
> vfs_dedupe_file_range_compare().
> And introduce dax_remap_file_range_prep() for filesystem use.
>
> Signed-off-by: Goldwyn Rodrigues
> Signed-o
gt; Cc: Andreas Dilger
> Signed-off-by: Yang Guo
> Signed-off-by: Shaokun Zhang
> ---
> fs/ext4/inode.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
Thanks for the patch. Changes looks good and trivial.
Feel free to add -
Reviewed-by: Ritesh Harjani
Hi Joonsoo,
I think you will be loosing the benefit of below patch with your changes.
I am no expert here so please bear with me. I tried explaining in the
inline comments, let me know if I am wrong.
commit 026b08147923142e925a7d0aaa39038055ae0156
Author: Tomasz Stanislawski
Date: Wed Jun 12 1
Hi Joonsoo,
CC'ing the developer of the patch (Tomasz Stanislawski)
On Fri, May 30, 2014 at 8:16 PM, Joonsoo Kim wrote:
> 2014-05-30 19:40 GMT+09:00 Ritesh Harjani :
>> Hi Joonsoo,
>>
>> I think you will be loosing the benefit of below patch with your changes.
>&g
Hi Greg,
Thanks for reviewing.
On Wed, Jun 4, 2014 at 11:21 PM, Greg KH wrote:
> On Wed, Jun 04, 2014 at 01:41:46PM +0530, ritesh.harj...@gmail.com wrote:
>> From: Ritesh Harjani
>>
>> This patch moves out *mapping pointer of dma_iommu_mapping
>> from arch/arm/incl
Hi Greg,
On Thu, Jun 5, 2014 at 12:29 AM, Greg KH wrote:
> On Thu, Jun 05, 2014 at 12:16:28AM +0530, Ritesh Harjani wrote:
>> Hi Greg,
>>
>> Thanks for reviewing.
>>
>> On Wed, Jun 4, 2014 at 11:21 PM, Greg KH wrote:
>> > On Wed, Jun 04, 2014 at 01:41:
On Thu, Mar 26, 2015 at 6:04 AM, David Rientjes wrote:
> On Thu, 26 Mar 2015, Ritesh Harjani wrote:
>
>> > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> > index 83cd5ac..3f1ac51 100644
>> > --- a/arch/arm/mm/dma-mapping.c
>
Hi
On Mon, Mar 23, 2015 at 12:57 PM, Tomasz Figa wrote:
> IOMMU should be able to use single pages as well as bigger blocks, so if
> higher order allocations fail, we should not affect state of the system,
> with events such as OOM killer, but rather fall back to order 0
> allocations.
>
> This p
//Then it crashes while
//doing inode->i_uid
Reported-by: Guang Yuan Wu
Tested-by: Guang Yuan Wu
Acked-by: Jeff Layton
Signed-off-by: Ritesh Harjani
---
fs/namei.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/fs/nam
Change is_async member of struct dio from int to bool.
Found this during code review.
Signed-off-by: Ritesh Harjani
---
fs/direct-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index ae196784f487..b139876653ef 100644
--- a/fs/direct-io.c
w-dioread-nolock-1M.pg
Ritesh Harjani (2):
ext4: Add ext4_ilock & ext4_iunlock API
ext4: Improve DIO writes locking sequence
fs/ext4/ext4.h| 33 ++
fs/ext4/extents.c | 16 +--
fs/ext4/file.c| 260 --
fs/ext4/inode.c | 4 +-
fs/ex
condition here.
2. Added ext4_extending_io API. This checks if the IO
is extending the file.
Now we only check for
unaligned_io, extend, dioread_nolock & overwrite.
Signed-off-by: Ritesh Harjani
---
fs/ext4/file.c | 213 -
1 file changed, 159 insert
"xfs: fix AIM7 regression")
Signed-off-by: Ritesh Harjani
---
fs/ext4/ext4.h| 33 +
fs/ext4/extents.c | 16 ++--
fs/ext4/file.c| 63 +--
fs/ext4/inode.c | 4 +--
fs/ext4/ioctl.c | 16 ++--
f
I think we have still not taken this patch. Al?
On 10/15/19 9:37 AM, Ritesh Harjani wrote:
ping!!
On 9/27/19 10:12 AM, Ritesh Harjani wrote:
d_is_negative can race with d_instantiate_new()
-> __d_set_inode_and_type().
For e.g. in use cases where Thread-1 is creating
symlink (do
On 10/23/19 1:41 AM, Al Viro wrote:
On Tue, Oct 22, 2019 at 03:37:36PM +0100, Al Viro wrote:
On Tue, Oct 22, 2019 at 07:08:54PM +0530, Ritesh Harjani wrote:
I think we have still not taken this patch. Al?
or, for that matter, any callers of filename_lookup() assuming that the
lack of
ping!!
On 9/27/19 10:12 AM, Ritesh Harjani wrote:
d_is_negative can race with d_instantiate_new()
-> __d_set_inode_and_type().
For e.g. in use cases where Thread-1 is creating
symlink (doing d_instantiate_new()) & Thread-2 is doing
cat of that symlink while doing lookup_fast (via REF-wa
On 2/14/2019 9:40 PM, Chao Yu wrote:
On 2019-2-14 15:46, Sahitya Tummala wrote:
On Wed, Feb 13, 2019 at 11:25:31AM +0800, Chao Yu wrote:
On 2019/2/4 16:06, Sahitya Tummala wrote:
Fix below warning coming because of using mutex lock in atomic context.
BUG: sleeping function called from inval
Hi Laura,
On 2/19/2019 12:59 AM, Laura Abbott wrote:
Hi,
Fedora got report of a panic when I accidentally left debugging enabled
on a build https://bugzilla.redhat.com/show_bug.cgi?id=1677438
It looks like a panic from code in CONFIG_FAIL_MMC_REQUEST from the
cqhci driver because there isn't a
On 2/15/2019 2:40 PM, Chao Yu wrote:
On 2019/2/15 12:28, Ritesh Harjani wrote:
On 2/14/2019 9:40 PM, Chao Yu wrote:
On 2019-2-14 15:46, Sahitya Tummala wrote:
On Wed, Feb 13, 2019 at 11:25:31AM +0800, Chao Yu wrote:
On 2019/2/4 16:06, Sahitya Tummala wrote:
Fix below warning coming
On 3/6/2019 6:30 PM, Adrian Hunter wrote:
On 2/03/19 7:20 AM, Sowjanya Komatineni wrote:
This patch adds a quirk for setting CMD_TIMING to 1 in descriptor
for DCMD with R1B response type to allow the command to be sent to
device during data activity or busy time.
Tegra186 CQHCI host has bug w
On 4/12/2018 8:38 PM, Miklos Szeredi wrote:
Implement FS_IOC_GETFLAGS and FS_IOC_SETFLAGS.
Needs vfs_ioctl() exported to modules.
Do you think if it is better to separate out ovl implementation and
export of vfs_ioctl method ?
Probably there are other users which should be using vfs_ioctl met
re+0x5c // mutex_lock(&dqopt->dqio_mutex);
dqget+0x238
__dquot_initialize+0xd4
dquot_initialize+0x10
dquot_file_open+0x34
f2fs_file_open+0x6c
do_dentry_open+0x1e4
vfs_open+0x6c
path_openat+0xa20
do_filp_open+0x4c
do_sys_open+0x178
Signed-off-by: Ritesh Harjani
---
f
ota. Commit details
in next patch contains the call stack.
Since I did not had the quota enabled on f2fs configuration, I could not test
this on my setup yet.
Could the community kindly review and let me know if the patch
is correct or not ?
Ritesh Harjani (1):
f2fs: Set GF_NOFS
Kill an unused extern entry from quota.h
which is leftover of below patch.
[f32764bd2: quota: Convert quota statistics to generic percpu_counter]
Signed-off-by: Ritesh Harjani
---
include/linux/quota.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/quota.h b/include/linux
Hi Georgi,
I collected some info on this problem. May be below info might help you.
I think "Reset 0x1" problem is occurring because of below call stack.
SDHCI_RESET_ALL to SDHCI_SOFTWARE_RESET register will anyway trigger the
sdhci_msm_pwr_irq.
But I think the problem is that the above occu
On 1/17/2017 6:37 AM, Jeremy McNicoll wrote:
On Tue, Jan 10, 2017 at 12:30:44PM +0530, Ritesh Harjani wrote:
Hi,
Resending this patch series, as no one could review it -possibly due to
holidays during that time.
This patch series mainly provides enhanced strobe support to sdhci-msm driver
Hi Shawn,
On 1/10/2017 2:45 PM, Shawn Lin wrote:
On 2017/1/10 14:41, Ritesh Harjani wrote:
From: Sahitya Tummala
Add new host operation ->platform_dumpregs to provide a
mechanism through which host drivers can dump platform
specific registers in addition to SDHC registers
during er
think this patch should be fine to
avoid the error message on reboot.
On 12/3/2016 2:24 PM, Ritesh Harjani wrote:
On 12/1/2016 11:38 PM, Georgi Djakov wrote:
On 11/29/2016 05:40 AM, Ritesh Harjani wrote:
Hi Georgi,
On 11/28/2016 11:09 PM, Georgi Djakov wrote:
On apq8016, apq8084 and ap
this issue.
# [5.854979] mmc0: mmc_runtime_suspend
[5.854982] mmc1: mmc_runtime_suspend
[5.957925] mmc1: Reset 0x1 never completed.
[6.071244] mmc0: Reset 0x1 never completed.
Regards
Ritesh
On 1/18/2017 2:46 PM, Ritesh Harjani wrote:
Hi Georgi,
Sorry for delaying this.
I did
Hi Adrian,
Thanks for reviewing.
On 1/19/2017 3:40 PM, Adrian Hunter wrote:
On 10/01/17 09:00, Ritesh Harjani wrote:
Clear SDHCI_HS400_TUNING flag after platform_execute_tuning
so that platform_execute_tuning may use it if needed.
Sorry for the slow reply.
platform_execute_tuning() should
Hi Jeremy,
Thanks for the review.
On 1/14/2017 3:51 AM, Jeremy McNicoll wrote:
On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote:
From: Sahitya Tummala
Add new host operation ->platform_dumpregs to provide a
mechanism through which host drivers can dump platform
speci
Hi Jeremy,
On 1/14/2017 4:01 AM, Jeremy McNicoll wrote:
On Fri, Dec 30, 2016 at 05:02:10PM +0530, Ritesh Harjani wrote:
From: Sahitya Tummala
Implement ->platform_dumpregs host operation to print the
platform specific registers in addition to standard SDHC
register during error conditi
://lkml.org/lkml/2017/1/10/70
[2]:- https://lkml.org/lkml/2017/1/19/153
[3]:- https://lkml.org/lkml/2017/1/20/542
Ritesh Harjani (2):
mmc: sdhci-msm: Remove platform_execute_tuning from sdhci_msm_ops
mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence
drivers/mmc/host/sdhci-msm.c | 21
This removes CDC init sequence comments which are
not useful anyway.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index b3e8f44
platform_execute_tuning should not really exist as it does not
do anything useful.
So remove this ops and directly plug sdhci_msm_execute_tuning
with mmc_host_ops.
Also in case of HS400 tuning clear SDHCI_HS400_TUNING flag once
HS400 related mode selection is done.
Signed-off-by: Ritesh Harjani
Hi Stephen,
On 1/20/2017 11:12 PM, Stephen Boyd wrote:
On 01/09/2017 11:00 PM, Ritesh Harjani wrote:
From: Subhash Jadavani
Program CORE_CSR_CDC_DELAY_CFG for hardware recommended 1.25ns delay.
We may see data CRC errors if it's programmed for any other delay
value.
Signed-off-by: Su
From: Sahitya Tummala
Implement ->platform_dumpregs host operation to print the
platform specific registers in addition to standard SDHC
register during error conditions.
Signed-off-by: Sahitya Tummala
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c |
(->platform_dumpregs)
for sdhci-msm.
Patch 3 :- Adds more logs for data errors to aid debugging.
Ritesh Harjani (1):
mmc: sdhci: Add more debug info in case of data error
Sahitya Tummala (2):
mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.
mmc: sdhci-msm: Implem
From: Sahitya Tummala
Add new host operation ->platform_dumpregs to provide a
mechanism through which host drivers can dump platform
specific registers in addition to SDHC registers
during error conditions.
Signed-off-by: Sahitya Tummala
Signed-off-by: Ritesh Harjani
---
drivers/mmc/h
print error log message and dump sdhc registers for debugging
purpose in case of data errors (except when tuning commands
generate CRC/timeout/end bit errors).
Signed-off-by: Ritesh Harjani
Signed-off-by: Asutosh Das
---
drivers/mmc/host/sdhci.c | 21 +++--
1 file changed, 19
Gopalakrishnan
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 5a37c29..a028568 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers
Factor out msm_set/get_clock_rate_for_bus_mode for it's later
use in changing the tuning sequence for selecting HS400
bus speed mode.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 64 +++-
1 file changed, 40 insertions(+), 24 dele
This factors out sdhci_msm_hc_select_mode to later use
it during enhanced_strobe mode select.
It also further breaks sdhci_msm_hc_select_mode
into separate functions for configuring HS400 mode
or other modes.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 201
Factor out sdhci_msm_hs400 used for DLL calibration in HS400
modes. This function will be needed for enhanced_strobe as well.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a
that ->platform_execute_tuning (underlying platform driver) can
know about HS400 tuning.
Patch 7 :- Implements an additional step as per HPG for HS400 tuning.
Patch 8 :- Implements enhanced strobe functionality in sdhci-msm driver.
Ritesh Harjani (6):
mmc: sdhci-msm: Fac
From: Subhash Jadavani
Program CORE_CSR_CDC_DELAY_CFG for hardware recommended 1.25ns delay.
We may see data CRC errors if it's programmed for any other delay
value.
Signed-off-by: Subhash Jadavani
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 2 +-
1 file chang
During tuning execution for HS400 mode, HW sequence recommends
to select MCLK_SEL/2(0x3) in VENDOR_SPEC & sdhc msm clock at GCC
to be 400MHZ (nearest supported clk). Add this change in tuning
sequence during HS400 tuning.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c
Clear SDHCI_HS400_TUNING flag after platform_execute_tuning
so that platform_execute_tuning may use it if needed.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host
This provides enhanced_strobe mode feature support in sdhci-msm
driver.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci
On 1/20/2017 2:23 AM, Ulf Hansson wrote:
On 10 January 2017 at 08:00, Ritesh Harjani wrote:
Hi,
Resending this patch series, as no one could review it -possibly due to
holidays during that time.
This patch series mainly provides enhanced strobe support to sdhci-msm driver
along with some
Hi Adrian,
On 1/19/2017 4:25 PM, Adrian Hunter wrote:
On 10/01/17 08:41, Ritesh Harjani wrote:
From: Sahitya Tummala
Implement ->platform_dumpregs host operation to print the
platform specific registers in addition to standard SDHC
register during error conditions.
You could add an exam
On 1/19/2017 4:13 PM, Adrian Hunter wrote:
On 18/01/17 09:57, Ritesh Harjani wrote:
Hi Shawn,
On 1/10/2017 2:45 PM, Shawn Lin wrote:
On 2017/1/10 14:41, Ritesh Harjani wrote:
From: Sahitya Tummala
Add new host operation ->platform_dumpregs to provide a
mechanism through which host driv
Hi Adrian,
Thanks for reviewing.
On 1/19/2017 5:24 PM, Adrian Hunter wrote:
On 10/01/17 08:41, Ritesh Harjani wrote:
print error log message and dump sdhc registers for debugging
purpose in case of data errors (except when tuning commands
generate CRC/timeout/end bit errors).
It is a bit
Some controllers may need to configure few registers based on enhanced
strobe mode while configuring to HS400 timing, thus make
ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/core/mmc.c | 8 +++-
1 file changed, 7
Signed-off-by: Ritesh Harjani
---
drivers/mmc/core/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 543eadd..125f8a9 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -1139,6 +1139,9 @@ void mmc_set_clock
Hi,
Patch series is to enable enhanced strobe feature for sdhci-msm driver.
But there are also some changes done in core layer for this.
This was tested on msm8996 based interal target with emmc-5.1 card.
Ritesh Harjani (4):
mmc: core: Return from mmc_set_clock if hz is already set to
This provide support for enhanced_strobe feature to sdhci-msm.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index
Currently mmc_select_hs400es is not setting the desired frequency
before sending switch command. This makes CMD13 to timeout on
some controllers.
Thus add a change to set the desired HS400 frequency
in mmc_select_hs400es when the timing is switched to HS400.
Signed-off-by: Ritesh Harjani
Hi Shawn,
On 12/20/2016 12:59 PM, Shawn Lin wrote:
On 2016/12/20 13:53, Ritesh Harjani wrote:
Currently mmc_select_hs400es is not setting the desired frequency
before sending switch command. This makes CMD13 to timeout on
some controllers.
Thus add a change to set the desired HS400 frequency
Hi Shawn,
On 12/20/2016 4:33 PM, Shawn Lin wrote:
On 2016/12/20 18:33, Ritesh Harjani wrote:
Hi Shawn,
On 12/20/2016 12:59 PM, Shawn Lin wrote:
On 2016/12/20 13:53, Ritesh Harjani wrote:
Currently mmc_select_hs400es is not setting the desired frequency
before sending switch command. This
Minor comments.
On 12/9/2016 1:43 AM, Jens Axboe wrote:
Takes a list of requests, and dispatches it. Moves any residual
requests to the dispatch list.
Signed-off-by: Jens Axboe
---
block/blk-mq.c | 85 --
block/blk-mq.h | 1 +
2 files c
acceptable or not ?
Regards
Ritesh
On 12/20/2016 11:23 AM, Ritesh Harjani wrote:
Some controllers may need to configure few registers based on enhanced
strobe mode while configuring to HS400 timing, thus make
ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es.
Signed-off-by
Factor out msm_set/get_clock_rate_for_bus_mode for it's later
use in changing the tuning sequence for selecting HS400
bus speed mode.
Signed-off-by: Ritesh Harjani
---
drivers/mmc/host/sdhci-msm.c | 64 +++-
1 file changed, 40 insertions(+), 24 dele
tuning.
Patch 7 :- Implements an additional step as per HPG for HS400 tuning.
Patch 8 :- Implements enhanced strobe functionality in sdhci-msm driver.
Ritesh Harjani (6):
mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode
mmc: sdhci-msm: Factor out function to set/get msm clock rate
mmc: sd
1 - 100 of 181 matches
Mail list logo
