trouble with v4l-dvb compilation, compat.h: redefinition of 'usb_endpoint_type'

2009-03-27 Thread Alexey Klimov
Hello, I went to /usr/src/linux and run git pull (so i get 2.6.29-git1), and make new kernel. Then i updated v4l-dvb repository(hg pull, hg update) and configured to compile, for example dsbr100 radio driver. I get such message: tux v4l-dvb # make make -C /w/new/v4l-dvb/v4l make[1]: Entering

[patch review] gspca - mr97310a: return error instead of -1 in sd_mod_init

2009-03-27 Thread Alexey Klimov
Hello, Jean-Francois What do you think about such small cleanup ? --- Patch reformats sd_mod_init in the way to make it return error code from usb_register instead of -1. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 56cf0f1772f7 linux/drivers/media/video/gspca/mr97310a.c

Re: [question] about open/release and vidioc_g_input/vidioc_s_input functions

2009-03-27 Thread Alexey Klimov
On Fri, Mar 27, 2009 at 7:50 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Friday 27 March 2009 17:44:05 Alexey Klimov wrote: Hello, Hans On Tue, 2009-03-24 at 08:06 +0100, Hans Verkuil wrote: On Tuesday 24 March 2009 00:14:07 Alexey Klimov wrote: Hello, all ... static int

[patch 1/2] v4l2-dev.c: return 0 for NULL open and release callbacks

2009-03-29 Thread Alexey Klimov
hverk...@xs4all.nl Patch allows v4l2_open and v4l2_release functions return 0 if open and release driver callbacks set to NULL. This will be used in radio drivers. Priority: normal Signed-off-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r

[patch 2/2 review] pci-isa radios: remove open and release functions

2009-03-29 Thread Alexey Klimov
From: Alexey Klimov klimov.li...@gmail.com Patch removes empty open and release functions in pci and isa radio drivers, setting them to NULL. V4L module doesn't call for them due to previous patch. Priority: normal Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r a38076781c9a

[review] dsbr100 radio: convert to to v4l2_device

2009-03-30 Thread Alexey Klimov
Hello, Hans and Douglas, and others This is review version for dsbr100 radio. Hans, if you can a bit of free time to look and make comments it will be very good. I'm still confused about messages like v4l2_err and about unplugging procedure. I tested it with my radio device and it

Re: [review] dsbr100 radio: convert to to v4l2_device

2009-03-31 Thread Alexey Klimov
Hello, Hans Thanks for review. On Tue, Mar 31, 2009 at 2:13 AM, Hans Verkuil hverk...@xs4all.nl wrote: I'm still confused about messages like v4l2_err and about unplugging procedure. For a simple device like this unregistering the v4l2_device in the disconnect is OK. Although the best

Re: About the radio-si470x driver for I2C interface

2009-03-31 Thread Alexey Klimov
Hello On Tue, Mar 10, 2009 at 3:20 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Mon, 9 Mar 2009 23:33:38 +0100 Tobias Lorenz tobias.lor...@gmx.net wrote: Hi, The proper way is to break radio-si470x into two parts:     - A i2c adapter driver (similar to what we have on

Re: trouble with v4l-dvb compilation, compat.h: redefinition of 'usb_endpoint_type'

2009-03-31 Thread Alexey Klimov
On Fri, Mar 27, 2009 at 7:44 PM, Alexey Klimov klimov.li...@gmail.com wrote: Hello, I went to /usr/src/linux and run git pull (so i get 2.6.29-git1), and make new kernel. Then i updated v4l-dvb repository(hg pull, hg update) and configured to compile, for example dsbr100 radio driver. I get

[patch review] radio-si470x: fix possible bug with freeing memory order

2009-03-31 Thread Alexey Klimov
radio-buffer before allocation memory for this. -- Patch fixes cleanup procedure in si470x_usb_driver_probe. Add new label err_video and change order of freeing memory. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 5567e82c34a0 linux/drivers/media/radio/radio-si470x.c --- a/linux

Re: [patch review] radio-si470x: fix possible bug with freeing memory order

2009-04-01 Thread Alexey Klimov
or Mauro to decide. On Wednesday 01 April 2009 02:01:04 Alexey Klimov wrote: Hello, all There is probably bug when cleanup occurs in si470x_usb_driver_probe. We do kmalloc for radio-buffer and when it's fail we kfree(radio-buffer). The same with si470x_get_all_registers

[RFC] BKL in open functions in drivers

2009-04-01 Thread Alexey Klimov
Hello, Few days ago Alessio Igor Boganiabog...@texware.it sent me patch that removes BKLs like lock/unlock_kernel() in open call and place mutex there in media/radio/radio-mr800.c. This patch broke the driver, so we figured out new approah. We added one more mutex lock that was used in open call.

Re: [RFC] BKL in open functions in drivers

2009-04-02 Thread Alexey Klimov
On Thu, Apr 2, 2009 at 11:29 AM, Hans Verkuil hverk...@xs4all.nl wrote: [...] So, questions are: 1) What for is lock/unlock_kernel() used in open? It's pointless. Just remove it. Actually, i can see lock/unlock_kernel() in open in other V4L drivers too. What for is it used in other

[patch 1/2] dsbr100 radio: convert to to v4l2_device

2009-04-03 Thread Alexey Klimov
dsbr100: convert to v4l2_device. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r f86c84534cb4 linux/drivers/media/radio/dsbr100.c --- a/linux/drivers/media/radio/dsbr100.c Sun Mar 29 22:54:35 2009 -0300 +++ b/linux/drivers/media/radio/dsbr100.c Tue Mar 31 15:54:36 2009

[patch 2/2] radio-mr800: convert to to v4l2_device

2009-04-03 Thread Alexey Klimov
radio-mr800: convert to to v4l2_device. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 4cd17f5a20cc linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Thu Apr 02 20:50:21 2009 -0300 +++ b/linux/drivers/media/radio/radio-mr800.c Sat Apr 04 01

Re: Topro 6800 webcam driver

2009-04-07 Thread Alexey Klimov
On Tue, 2009-04-07 at 15:13 +0400, Andrey Panin wrote: On 097, 04 07, 2009 at 11:41:32AM +0200, Anders Blomdell wrote: snip +static const struct sd_desc sd_desc = { + .name = MODULE_NAME, + .ctrls = sd_ctrls, + .nctrls = ARRAY_SIZE(sd_ctrls), + .config = sd_config, +

Re: [PATCH] usb: add reset endpoint operations

2009-04-08 Thread Alexey Klimov
(added linux-media maillist) Hello, David On Wed, Apr 8, 2009 at 9:36 PM, David Vrabel david.vra...@csr.com wrote: Wireless USB endpoint state has a sequence number and a current window and not just a single toggle bit.  So allow HCDs to provide a endpoint_reset method and call this or clear

Re: [PATCH] usb: add reset endpoint operations

2009-04-08 Thread Alexey Klimov
On Thu, Apr 9, 2009 at 3:40 AM, Greg KH gre...@suse.de wrote: On Thu, Apr 09, 2009 at 03:36:51AM +0400, Alexey Klimov wrote: (added linux-media maillist) Hello, David On Wed, Apr 8, 2009 at 9:36 PM, David Vrabel david.vra...@csr.com wrote: Wireless USB endpoint state has a sequence number

Re: About the radio-si470x driver for I2C interface

2009-04-12 Thread Alexey Klimov
Hello, Tobias On Mon, Apr 13, 2009 at 12:56 AM, Tobias Lorenz tobias.lor...@gmx.net wrote: Hi Joonyoung, Hi Alexey, I've split the driver into a couple of segments: - radio-si470x-common.c is for common functions - radio-si470x-usb.c are the usb support functions - radio-si470x-i2c.c

[patch review] av7110_hw: fix compile warning

2009-04-19 Thread Alexey Klimov
One more warning fix. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r cda79523a93c linux/drivers/media/dvb/ttpci/av7110_hw.c --- a/linux/drivers/media/dvb/ttpci/av7110_hw.c Thu Apr 16 18:30:38 2009 +0200 +++ b/linux/drivers/media/dvb/ttpci/av7110_hw.c Mon Apr 20 00:17:51 2009 +0400

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-19 Thread Alexey Klimov
On Sun, Apr 19, 2009 at 10:18 PM, Hans Verkuil hverk...@xs4all.nl wrote: This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:        Sun Apr 19 19:00:03 CEST 2009 path:        

Re: [PATCH 2/5] V4L2 patches for Intel Moorestown Camera Imaging Drivers

2009-04-30 Thread Alexey Klimov
Hello, do you mind if i make few comments? Really, looks like http://patchwork.kernel.org/project/linux-media/list/ didnt catch your [1/5] patch. On Thu, Apr 30, 2009 at 12:22 PM, Zhang, Xiaolin xiaolin.zh...@intel.com wrote: From d8f37b4340ea4cfd28d6e620f1b3224d946b9fab Mon Sep 17 00:00:00

Re: [PATCH] radio_si470x: Drop unused label

2009-04-30 Thread Alexey Klimov
(added Tobias and Mauro on c/c) On Thu, Apr 30, 2009 at 6:16 PM, Nicola Soranzo nsora...@tiscali.it wrote: Fix this warning: /home/nicola/v4l-dvb/v4l/radio-si470x.c: In function 'si470x_fops_release': /home/nicola/v4l-dvb/v4l/radio-si470x.c:1218: warning: label 'unlock' defined but not used

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-30 Thread Alexey Klimov
Hello, On Mon, Apr 20, 2009 at 3:59 AM, Mike Isely is...@isely.net wrote: On Mon, 20 Apr 2009, Alexey Klimov wrote:   [...] When trying to compile v4l-dvb tree under 2.6.30-rc2 (up-to-date) i have such error with pvr2 module:   CC [M]  /w/new/v4l-dvb/v4l/pvrusb2-hdw.o /w/new/v4l-dvb/v4l

Re: [PATCH 2/5] V4L2 patches for Intel Moorestown Camera Imaging Drivers

2009-05-01 Thread Alexey Klimov
Hello, Xiaolin On Fri, May 1, 2009 at 6:57 PM, Zhang, Xiaolin xiaolin.zh...@intel.com wrote: No mind, welcome any comments. Oops, i already did. Probably comments are lost in big letter, please find them :) I am working on this issue why the first patch -isp drive can't send it out.

Re: [PATCH] zoran: Fix /|| typo

2009-05-02 Thread Alexey Klimov
Hello, Roel On Sun, May 3, 2009 at 12:52 AM, Roel Kluin roel.kl...@gmail.com wrote: Fix /|| typo diff --git a/drivers/media/video/zoran/zoran_card.c b/drivers/media/video/zoran/zoran_card.c index ea6c577..ea9de8b 100644 --- a/drivers/media/video/zoran/zoran_card.c +++

[questions] dmesg: Non-NULL drvdata on register

2009-05-04 Thread Alexey Klimov
Hello, Not so many time ago i noticed such line in dmesg: radio-mr800 2-1:1.0: Non-NULL drvdata on register Quick review showed that it appears in usb_amradio_probe fucntions. Then i found such code in v4l2_device_register() function (v4l2-device.c file): /* Set name to driver name + device

Re: [questions] dmesg: Non-NULL drvdata on register

2009-05-04 Thread Alexey Klimov
On Mon, May 4, 2009 at 5:03 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hello, Not so many time ago i noticed such line in dmesg: radio-mr800 2-1:1.0: Non-NULL drvdata on register Quick review showed that it appears in usb_amradio_probe fucntions. Then i found such code in

Re: [patch 1/4] radio-mr800.c: missing mutex include

2009-05-13 Thread Alexey Klimov
    /* for KERNEL_VERSION MACRO */ +#include linux/mutex.h  /* driver and module definitions */  #define DRIVER_AUTHOR Alexey Klimov klimov.li...@gmail.com _ There was discussion about this patch. http://www.mail-archive.com/linux-media@vger.kernel.org/msg03556.html Well, i'm not against this patch. -- Best

Re: v4l-dvb and old kernels

2009-05-26 Thread Alexey Klimov
Hello, Antonio On Tue, May 26, 2009 at 5:03 PM, Antonio Beamud Montero antonio.bea...@gmail.com wrote: It would compile today's snapshot of v4l-dvb with an old kernel version (for example 2.6.16)? (or is better to upgrade the kernel?) Not long time ago v4l-dvb community had discussions about

Probably strange bug with usb radio-mr800

2009-05-27 Thread Alexey Klimov
Hello, Doing some improvements in media/radio/radio-mr800.c i see very strange situation. I made simple patch that removed usb_amradio_open function. There is no need in this function (no need to start/set frequency radio in open procedure, and also removed lock/unlock_kernel() calls). Here is

[patch review 1/4] dsbr100: remove radio-users counter

2009-05-28 Thread Alexey Klimov
Patch removes radio-users counter because it is not in use. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 315bc4b65b4f linux/drivers/media/radio/dsbr100.c --- a/linux/drivers/media/radio/dsbr100.c Sun May 17 12:28:55 2009 + +++ b/linux/drivers/media/radio/dsbr100.c

[patch review 2/4] dsbr100: remove usb_dsbr100_open/close calls

2009-05-28 Thread Alexey Klimov
Patch removes usb_dsbr100_open and usb_dsbr100_close calls. 1. No need to start, set frequency, adjust parameters in open call. 2. This patch tackles issue with lock/unlock_kernel() in open call. 3. With this patch feature Mute on exit? in gnomeradio works. Signed-off-by: Alexey Klimov klimov.li

[patch review 4/4] dsbr100: change radio-muted to radio-status, update suspend/resume

2009-05-28 Thread Alexey Klimov
Patch renames radio-muted to radio-status, add defines for that variable, and fixes suspend/resume procedure. Radio-status set to STOPPED in usb_dsbr100_probe because of removing open call. Also, patch increases driver version. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r

Re: Probably strange bug with usb radio-mr800

2009-06-04 Thread Alexey Klimov
Is there any ideas about different behaviour of device on 32- and 64-bit platforms with the same usb bulk messages? Any input is welcome. On Wed, May 27, 2009 at 9:51 PM, Alexey Klimovklimov.li...@gmail.com wrote: [...] So, the same messages to device works fine with radio on 32bit machine

Re: Probably strange bug with usb radio-mr800

2009-06-05 Thread Alexey Klimov
On Fri, Jun 5, 2009 at 2:53 AM, Greg KHgre...@suse.de wrote: On Fri, Jun 05, 2009 at 02:43:04AM +0400, Alexey Klimov wrote: Is there any ideas about different behaviour of device on 32- and 64-bit platforms with the same usb bulk messages? No, there should be no difference. Have you run

Re: [PATCH 5/9] V4L2: Added Timberdale Logiwin driver

2009-06-06 Thread Alexey Klimov
Hello, Richard i have only two small suggestions. On Fri, Jun 5, 2009 at 5:40 PM, Richard Röjforsrichard.rojfors@mocean-labs.com wrote: V4L2 video capture driver for the logiwin IP on the Timberdale FPGA. The driver uses the Timberdale DMA engine Signed-off-by: Richard Röjfors

Re: Probably strange bug with usb radio-mr800

2009-06-07 Thread Alexey Klimov
Hello, On Sun, Jun 7, 2009 at 1:07 AM, Oliver Neukumoli...@neukum.org wrote: Am Freitag, 5. Juni 2009 00:43:04 schrieb Alexey Klimov: Is there any ideas about different behaviour of device on 32- and 64-bit platforms with the same usb bulk messages? Any input is welcome. Are you running

[patch review] gspca - stv06xx: remove needless if check and goto

2009-06-09 Thread Alexey Klimov
Hello, Jean-Francois and Erik André What do you think about such small change? Looks like the code doesn't need if-check and goto here in stv06xx_stopN function. The code after label out does this. -- Patch removes needless if check and goto. Signed-off-by: Alexey Klimov klimov.li

Re: [patch 1/6] radio-mr800.c: missing mutex include

2009-06-10 Thread Alexey Klimov
On Wed, Jun 10, 2009 at 11:44 PM, a...@linux-foundation.org wrote: From: Alessio Igor Bogani abog...@texware.it radio-mr800.c uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it already includes, the right thing is to include it directly. It

Re: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-11 Thread Alexey Klimov
Hello, Very small suggestion, please see below. On Thu, Jun 11, 2009 at 9:00 PM, m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com Re-sending since previous one missed a file (vpfe_types.h) VPFE Capture bridge driver This is version, v2 of vpfe

Re: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-11 Thread Alexey Klimov
Hello, On Thu, Jun 11, 2009 at 9:00 PM, m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com common voss module for video drivers This is a new module added for vpss library functions that are used for configuring vpss system module. All video drivers

Re: [PATCH] USB interrupt support for radio-si470x FM radio driver

2009-06-16 Thread Alexey Klimov
Hello, Edouard (add Tobias and Douglas on c/c) On Tue, Jun 16, 2009 at 5:11 PM, Edouard Lafargueedou...@lafargue.name wrote: Please find below my attempt at removing 'manual' polling from the radio-si470x USB FM radio driver, by moving to URB interrupt callback handlers. This code

Re: [PATCH / resubmit] USB interrupt support for radio-si470x FM radio driver

2009-06-16 Thread Alexey Klimov
On Wed, Jun 17, 2009 at 12:05 AM, Edouard Lafargueedou...@lafargue.name wrote: Hello Alexey, Hello Edouard Many thanks for your comments. I have cleaned up my code/patch along your guidelines, removed all the remaining code that was not used anymore, checked that all buffers get deallocated

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-17 Thread Alexey Klimov
Hello, very small comments, see below please On Thu, Jun 18, 2009 at 12:11 AM, m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com snip +static int vpfe_enable_clock(struct vpfe_device *vpfe_dev) +{ +       struct vpfe_config *vpfe_cfg = vpfe_dev-cfg; +       int

Re: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-17 Thread Alexey Klimov
Hello, one more small comment On Thu, Jun 18, 2009 at 12:11 AM, m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com DM355 CCDC hw module Adds ccdc hw module for DM355 CCDC. This registers with the bridge driver a set of hw_ops for configuring the CCDC for a specific

Re: [PATCH 4/11 - v3] dm644x ccdc module for vpfe capture driver

2009-06-17 Thread Alexey Klimov
On Thu, Jun 18, 2009 at 12:11 AM, m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com DM644x CCDC hw module This is the hw module for DM644x CCDC. This registers with the vpfe capture driver and provides a set of hw_ops to configure CCDC for a specific decoder device

Re: Gadmei 380 on kernel 2.6.28.4

2009-10-19 Thread Alexey Klimov
Hello Ming-Ching, On Mon, Oct 19, 2009 at 10:28 AM, Ming-Ching Tiew mct...@yahoo.com wrote: Message below :- From: Ming-Ching Tiew mct...@yahoo.com Subject: Re: Gadmei 380 on kernel 2.6.28.4 To: linux-media@vger.kernel.org Date: Monday, October 12, 2009, 8:31 AM I did a dmesg, include

[patch] radio-mr800 - autosuspend for radio-mr800 driver

2009-11-09 Thread Alexey Klimov
From: Oliver Neukum oli...@neukum.org Patch adds autosuspend support for mr800 radio driver. Priority: normal Signed-off-by: Oliver Neukum oli...@neukum.org Acked-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 19c0469c02c3 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media

Re: Radio application using V4L2 on console?

2009-12-10 Thread Alexey Klimov
On Thu, Dec 10, 2009 at 11:27 AM, Joonyoung Shim jy0922.s...@samsung.com wrote: Hi, all. I just wonder there is any radio application using the V4L2 on console. I found only the Kradio app of KDE, but the KDE is difficult to use the embedded system. I am testing using my simple radio test

Re: [PATCH 3/4 v12] TVP7002 driver for DM365

2009-12-17 Thread Alexey Klimov
Hello, On Thu, Dec 17, 2009 at 12:32 AM, santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Implemented using the V4L2 DV presets API. Removed shadow register values.

Re: [PATCH 3/4 v13] TVP7002 driver for DM365

2009-12-19 Thread Alexey Klimov
Hello, On Fri, Dec 18, 2009 at 8:07 PM, santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Implemented using the V4L2 DV presets API. Removed shadow register values.

Re: [PATCH 2/2] [ARM] samsung-rotator: Add Samsung S3C/S5P rotator driver

2009-12-23 Thread Alexey Klimov
Hello, On Wed, Dec 23, 2009 at 1:08 PM, Pawel Osciak p.osc...@samsung.com wrote: The rotator device present on Samsung S3C and S5P series SoCs allows image rotation and flipping. It requires contiguous memory buffers to operate, as it does not have scatter-gather support. It is also an example

Re: [PATCHv2] Add Freescale MC44S803 tuner driver

2009-01-14 Thread Alexey Klimov
On Wed, Jan 14, 2009 at 9:04 PM, Jochen Friedrich joc...@scram.de wrote: Signed-off-by: Jochen Friedrich joc...@scram.de --- Changes since v1: - rebase against official linux tree. v1 was based against a local tree and didn't apply cleanly. drivers/media/common/tuners/Kconfig |

[PATCH] radio-mr800: fix radio-muted and radio-stereo

2009-01-23 Thread Alexey Klimov
Ellingsworth da...@identd.dyndns.org for pointing to this weak place in driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 6a6eb9efc6cd linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Fri Jan 23 22:35:12 2009 -0200 +++ b/linux/drivers/media

[patch review] em28xx: correct mailing list

2009-01-24 Thread Alexey Klimov
Hello all I'm not sure is this patch really suitable. But looks that main development mail-list moved to linux-media.. --- Correct mailing list in 3 places in em28xx-cards.c Move to linux-media on vger.kernel.org. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 6a6eb9efc6cd linux

Re: [OMAPZOOM][PATCH v2 2/6] Increase isp workaround buffer size for 8MP sensor.

2009-01-31 Thread Alexey Klimov
Hello, Dominic May i ask few questions ? Well, looks like it's unrelated to your patch. Lines that don't looks okay to me appear in your patch. On Fri, 2009-01-30 at 17:45 -0600, Dominic Curran wrote: From: Dominic Curran dcur...@ti.com Subject: [OMAPZOOM][PATCH v2 2/6] Increase isp workaround

Re: [REVIEW PATCH 2/2] OMAP3EVM Multi-Media Daughter Card Support

2009-01-31 Thread Alexey Klimov
Hello, Vaibhav May i tell few suggestions ? On Fri, 2009-01-30 at 00:52 +0530, hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com This is second version of OMAP3EVM Mulit-Media/Mass Market Daughter Card support. Fixes: - Cleaned unused header files, struct formating, and

Re: [REVIEW PATCH 13/14] OMAP: CAM: Add DW9710 Lens Driver

2009-02-01 Thread Alexey Klimov
Hello, guys Sorry me, answering to old letter. May i suggest two small points described below ? On Mon, 2009-01-12 at 20:03 -0600, Aguirre Rodriguez, Sergio Alberto wrote: This adds the DW9710 Lens driver Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/Kconfig

[patch review 1/8] radio-mr800: codingstyle cleanups

2009-02-02 Thread Alexey Klimov
Cleanups of many if-check constructions. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 1dce9d4e2179 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Sun Feb 01 11:40:27 2009 -0200 +++ b/linux/drivers/media/radio/radio-mr800.c Mon Feb 02

[patch review 3/8] radio-mr800: add more dev_err messages in probe

2009-02-02 Thread Alexey Klimov
Patch adds 3 dev_err messages in usb_amradio_probe() function. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r c9f51bda84de linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:53:50 2009 +0300 +++ b/linux/drivers/media/radio/radio

[patch review 6/8] radio-mr800: add stereo support

2009-02-02 Thread Alexey Klimov
Patch introduces new amradio_set_stereo function. Driver calls this func to make stereo radio reception. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 34b045702595 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Tue Feb 03 03:02:39 2009

[PATCH] radio-si470x Documentation: add note about mplayer

2009-02-02 Thread Alexey Klimov
to the radio with this radio device. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r aba639a17195 linux/Documentation/video4linux/si470x.txt --- a/linux/Documentation/video4linux/si470x.txtMon Feb 02 21:09:06 2009 +0300 +++ b/linux/Documentation/video4linux/si470x.txtTue

Re: [patch review 6/8] radio-mr800: add stereo support

2009-02-04 Thread Alexey Klimov
Reformatted patch, version 2. Corrects checking of returned value after usb_bulk_msg. --- Patch introduces new amradio_set_stereo function. Driver calls this func to make stereo radio reception. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 34b045702595 linux/drivers/media

[patch review 9/8] radio-mr800: fix checking of retval after usb_bulk_msg

2009-02-04 Thread Alexey Klimov
Patch corrects checking of returned value after usb_bulk_msg. Now we also check if number of transferred bytes equals to BUFFER_LENGTH. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 2876e91adef9 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800

Re: [PATCH] Mantis Bug (was Technisat HD2 cannot szap/scan)

2009-02-05 Thread Alexey Klimov
Hello, i'm sorry to bother you with this small thing. On Thu, 2009-02-05 at 13:34 +0100, Hans Werner wrote: Hi, checked it again. Your lnbp21 patch definitely kills S2 tuning on the Terratec Cinergy S2 PCI HD. mfg Edgar ( gimli ) Hucek I looked at it again and here is a

Re: [REVIEW][PATCH] LV8093: Add driver for LV8093 lens actuator.

2009-02-05 Thread Alexey Klimov
Hello, Dominic May i make few comments ? On Wed, 2009-02-04 at 12:40 -0600, Dominic Curran wrote: Hi Below is a new driver for the LV8093 lens actuator. Of course all comments are welcome, however I have a specific issue that i am concerned about... The lens position cannot be read back

[patch review] em28xx-audio: replace printk with em28xx_errdev

2009-02-08 Thread Alexey Klimov
Hello all, i hope this patch will be useful. Probably this change should looks like: printk(KERN_ERR em28xx-audio.c:..) but i suppose that em28xx_errdev is better. -- Patch removes printk and place em28xx_errdev macros to provide information about driver name to dmesg. Signed-off-by: Alexey

Re: [PATCH][RESEND 2] Added support for AVerMedia Cardbus Hybrid remote control

2009-02-11 Thread Alexey Klimov
On Wed, 2009-02-11 at 15:47 +0100, Oldrich Jedlicka wrote: Hi, please have a look at the attached patch. Signed-off-by: Oldřich Jedlička oldium@seznam.cz Thanks, Oldřich. Hello, Oldrich I tried to find your patch(this and from 1 Feb) on patchwork.kernel.org and failed :( Probably

Re: [PATCH] Add support for GeoVision GV-800(S)

2009-03-02 Thread Alexey Klimov
On Mon, Mar 2, 2009 at 8:54 PM, Bruno Christo brunochri...@gmail.com wrote: Hi Nicola, 2009/3/2 Nicola Soranzo nsora...@tiscali.it: Hi Bruno, it look like that your e-mail program is line wrapping your patch. Please read email-clients.txt in Linux Documentation and resubmit the patch,

Re: [PATCH 4/9] omap3isp: Add ISP frontend (CCDC)

2009-03-03 Thread Alexey Klimov
On Tue, 2009-03-03 at 12:06 +0200, Sakari Ailus wrote: Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/isp/ispccdc.c | 1568 + drivers/media/video/isp/ispccdc.h | 203 + 2 files changed, 1771

Re: [PATCH 5/9] omap3isp: Add ISP backend (PRV and RSZ)

2009-03-03 Thread Alexey Klimov
On Tue, 2009-03-03 at 12:06 +0200, Sakari Ailus wrote: Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/isp/isppreview.c | 1896 ++ drivers/media/video/isp/isppreview.h | 350 +++

Re: [PATCH 9/9] omap34xxcam: Add camera driver

2009-03-07 Thread Alexey Klimov
Hello, Sakari Ailus On Thu, 2009-03-05 at 16:09 +0200, Sakari Ailus wrote: Alexey Klimov wrote: +static int vidioc_g_fmt_vid_cap(struct file *file, void *fh, + struct v4l2_format *f) +{ + struct omap34xxcam_fh *ofh = fh; + struct omap34xxcam_videodev *vdev

Re: [PATCH 1/9] omap3isp: Add ISP main driver and register definitions

2009-03-07 Thread Alexey Klimov
On Thu, 2009-03-05 at 13:34 +0200, Sakari Ailus wrote: Thanks for the comments, Alexey! Alexey Klimov wrote: +static int isp_probe(struct platform_device *pdev) +{ + struct isp_device *isp; + int ret_err = 0; + int i; + + isp = kzalloc(sizeof(*isp), GFP_KERNEL); + if (!isp

Re: [PATCH 4/5] OMAP3430SDP: Add support for Camera Kit v3

2009-03-07 Thread Alexey Klimov
Hello, all On Fri, 2009-03-06 at 10:54 +0900, DongSoo(Nathaniel) Kim wrote: Hi Alexey, On Fri, Mar 6, 2009 at 7:05 AM, Alexey Klimov klimov.li...@gmail.com wrote: Hello, all On Thu, Mar 5, 2009 at 7:42 PM, Curran, Dominic dcur...@ti.com wrote: Hi Kim -Original Message

[patch review] radio-terratec: remove unused delay.h

2009-03-10 Thread Alexey Klimov
Hello, all I don't know if this patch okay, so it should be tested/reviewed. Anyway, compilation process shows no warnings. --- Patch removes linux/delay.h which hadn't been used. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 615fb8f01610 linux/drivers/media/radio/radio

[patch] radio-rtrack2: fix double mutex_unlock

2009-03-10 Thread Alexey Klimov
Patch fixes double mutex unlocking. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 615fb8f01610 linux/drivers/media/radio/radio-rtrack2.c --- a/linux/drivers/media/radio/radio-rtrack2.c Tue Mar 10 02:33:02 2009 -0300 +++ b/linux/drivers/media/radio/radio-rtrack2.c Tue Mar 10 09

Re: [PATCH 1/1] siano: add high level SDIO interface driver for SMS based cards

2009-03-12 Thread Alexey Klimov
Hello, Uri On Thu, 2009-03-12 at 06:52 -0700, Uri Shkolnik wrote: # HG changeset patch # User Uri Shkolnik u...@siano-ms.com # Date 1236865697 -7200 # Node ID 7352ee1288f651d19d58c7bb479a98f070ad98e6 # Parent 3392722cc5b687586c4d898b73050ab6e59bf401 siano: add high level SDIO interface

[patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Alexey Klimov
Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? --- Patch divides/separates radio drivers in Kconfig in 3 groups - ISA, PCI and others. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 626c136ec221 linux/drivers

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Alexey Klimov
.. endif # RADIO_ADAPTERS_ISA and don't touch other drivers. That looks fine for me. --- Patch divides/separates radio drivers in Kconfig in 3 groups - ISA, PCI and others. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 626c136ec221 linux/drivers/media/radio

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Alexey Klimov
On Thu, Mar 19, 2009 at 5:03 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Thu, 19 Mar 2009 16:03:20 +0300 Alexey Klimov klimov.li...@gmail.com wrote: Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? Frankly, I

Re: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-03-20 Thread Alexey Klimov
snip Hello again, my previous message due to bad connection was send with no end. Sorry about that. +               vout-vid = k; +               vid_dev-vouts[k] = vout; +               vout-vid_info.vid_dev = vid_dev; +               vout-vid_info.overlays[0] = vid_dev-overlays[k + 1]; +  

Re: patchwork tool

2009-03-26 Thread Alexey Klimov
On Thu, Mar 26, 2009 at 12:54 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Thu, 26 Mar 2009 11:22:26 +0200 vas...@gmail.com wrote: On Thu, Mar 26, 2009 at 10:34 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Thu, 26 Mar 2009 01:19:08 +0200 vas...@gmail.com

[patch review 00/02] driver for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
-mr800.c and radio-keene.c. Also may be the second patch should go through Jiri Kosina tree, i'm not sure how procedures work for such cases. Previous time Mauro sent patch with usb-quirks to Jiri. Best regards, Alexey Klimov. -- To unsubscribe from this list: send the line unsubscribe linux-media

[patch review 01/02] add driver for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this thing only deals with initialization and frequency setting. Signed-off-by: Alexey Klimov klimov.li

[patch review 02/02] usb hid quirks for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
Don't let Masterkit MA901 USB radio be handled by usb hid drivers. This device will be handled by radio-ma901.c driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5de3bb3..8e06569 100644 --- a/drivers/hid/hid-core.c

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-12 Thread Alexey Klimov
weeks ago. Driver is rather small (first working version) but i hope to add more features there in future. Best regards and wishes, Alexey Klimov -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

2012-11-16 Thread Alexey Klimov
Hi Sylwester, On Fri, Nov 16, 2012 at 2:05 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: This patch adds V4L2 driver for Samsung S3C244X/S3C64XX SoC series camera interface. The driver exposes a subdev device node for CAMIF pixel resolution and crop control and two video

[patch] MAINTAINERS: add an entry for radio-mr800 driver

2012-11-16 Thread Alexey Klimov
This patch adds MAINTAINERS entry for radio-mr800 usb radio driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/MAINTAINERS b/MAINTAINERS index f4b3aa8..e1d9e38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4909,6 +4909,13 @@ S: Maintained F: Documentation/serial

Re: [PATCH v3 5/6] Add a V4L2 driver for SI476X MFD

2012-11-16 Thread Alexey Klimov
Hello Andrey, On Tue, Oct 23, 2012 at 10:44 PM, Andrey Smirnov andrey.smir...@convergeddevices.net wrote: This commit adds a driver that exposes all the radio related functionality of the Si476x series of chips via the V4L2 subsystem. Signed-off-by: Andrey Smirnov

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-25 Thread Alexey Klimov
Hi Hans, On Fri, Nov 23, 2012 at 2:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Alexey, On Mon November 12 2012 19:41:57 Alexey Klimov wrote: Hi Mauro, Hans, all, On Fri, Nov 2, 2012 at 6:34 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Fri, 2 Nov 2012 14:47:49 +0100 Hans

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

2012-11-25 Thread Alexey Klimov
Hi Sylwester, On Sat, Nov 17, 2012 at 2:39 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Alexey, On 11/16/2012 03:10 PM, Alexey Klimov wrote: +static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp *vp) +{ + unsigned int ip_rev = camif-variant

Re: [patch review 01/02] add driver for Masterkit MA901 usb radio

2012-11-26 Thread Alexey Klimov
Hi Hans, On Fri, Nov 23, 2012 at 3:42 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Alexey, Some (small) comments below... On Mon October 29 2012 02:41:10 Alexey Klimov wrote: This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-26 Thread Alexey Klimov
Hi Hans, On Mon, Nov 26, 2012 at 6:15 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Mon 26 November 2012 00:18:30 Alexey Klimov wrote: Hi Hans, On Fri, Nov 23, 2012 at 2:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Alexey, On Mon November 12 2012 19:41:57 Alexey Klimov wrote: Hi

[patch 00/03 v2] driver for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
() - added maintainers entry patch Best regards, Alexey Klimov -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 01/03 v2] media: add driver for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this thing only deals with initialization and frequency setting. Signed-off-by: Alexey Klimov klimov.li

[patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
Don't let Masterkit MA901 USB radio be handled by usb hid drivers. This device will be handled by radio-ma901.c driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5de3bb3..8e06569 100644 --- a/drivers/hid/hid-core.c

[patch 03/03 v2] MAINTAINERS: add entry for radio-ma901 driver

2012-11-27 Thread Alexey Klimov
This patch adds MAINTAINERS entry for radio-ma901 usb radio driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/MAINTAINERS b/MAINTAINERS index b623679..a36b29c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4723,6 +4723,13 @@ Q: http://patchwork.linuxtv.org/project

[patch] MAINTAINERS: add entry for dsbr100 usb radio driver

2012-11-28 Thread Alexey Klimov
This patch adds MAINTAINERS entry for dsbr100 usb radio driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/MAINTAINERS b/MAINTAINERS index a36b29c..38da55f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2528,6 +2528,13 @@ S: Supported F: drivers/gpu/drm/exynos

Re: [PATCH] [media] v4l: Add mt9v034 sensor driver

2012-11-30 Thread Alexey Klimov
Hi Enric, May i ask about mt9v034_probe() and mt9v034_remove()? On Fri, Oct 5, 2012 at 2:34 PM, Enric Balletbo i Serra eballe...@gmail.com wrote: From: Enric Balletbo i Serra eballe...@iseebcn.com The MT9V034 is a parallel wide VGA sensor from Aptina (formerly Micron) controlled through I2C.

  1   2   >