Re: [PATCH 0/6] R-Car DU: Fix IOMMU operation when connected to VSP

2016-09-07 Thread Magnus Damm
Hi Laurent, Thanks for your help with this. Good to see that the DU driver is getting closer to work with the IPMMU hardware! Please see below for some feedback from me. On Fri, Aug 19, 2016 at 5:39 PM, Laurent Pinchart wrote: > Hello, > > This patch series fixes the rcar-du-drm driver to suppor

Re: [PATCH] media: platform: Renesas IMR driver

2017-03-05 Thread Magnus Damm
Hi Sergei, Thanks for your efforts with this driver. Nice to see that V2 is getting in better shape. In the future, would it be possible for you to include the patch version number in the [PATCH] tag somehow? On Fri, Mar 3, 2017 at 9:03 PM, Sergei Shtylyov wrote: > On 03/03/2017 02:58 PM, Geert

Re: [PATCH 3/3] ARM: switch mackerel to dynamically manage the platform camera

2011-03-16 Thread Magnus Damm
On Tue, Feb 22, 2011 at 6:57 PM, Guennadi Liakhovetski wrote: > Use soc_camera_platform helper functions to dynamically manage the > camera device. > > Signed-off-by: Guennadi Liakhovetski > --- >  arch/arm/mach-shmobile/board-mackerel.c |   28 +++- >  1 files changed, 7 i

Re: [PATCH] soc-camera: Add mt9t112 camera support

2009-11-25 Thread Magnus Damm
On Thu, Nov 19, 2009 at 6:15 PM, Kuninori Morimoto wrote: > Signed-off-by: Kuninori Morimoto > --- >>> Guennadi > > I add new number in v4l2-chip-ident.h > Is it OK for you ? > > This camera is very picky. > So, it have a lot of constant value. > > The register of mt9t112 and mt9t111 are same. >

Re: [PATCH] soc-camera: Add mt9t112 camera support

2009-11-25 Thread Magnus Damm
Hey Morimoto-san, On Thu, Nov 26, 2009 at 9:50 AM, Kuninori Morimoto wrote: >> Do you have any mt9t112 platform data for the ecovec board? I'd like >> to try out this patch but I don't know which board specific parts that >> are missing! > > Yes I have. > I attached it. > This platform patch is b

Re: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page aligned physical address

2009-12-01 Thread Magnus Damm
On Wed, Dec 2, 2009 at 12:30 AM, wrote: > From: Muralidharan Karicheri > > If a USERPTR address that is not aligned to page boundary is passed to the > videobuf_dma_contig_user_get() function, it saves a page aligned address to > the dma_handle. This is not correct. This issue is observed when u

Re: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page aligned physical address

2009-12-04 Thread Magnus Damm
Hi again Murali, Thanks for your work on this. On Thu, Dec 3, 2009 at 12:48 AM, Karicheri, Muralidharan wrote: > Magnus, > >>Thanks for the patch. For non-page aligned user space pointers I agree >>that a fix is needed. Don't you think the while loop in >>videobuf_dma_contig_user_get() also need

Re: [PATCH - v1] V4L-Fix videobuf_dma_contig_user_get() for non-aligned offsets

2009-12-09 Thread Magnus Damm
s observed when using USERPTR > IO machism for buffer exchange. > > Updates from last version:- > > Adding offset for size calculation as per comment from Magnus Damm. This > ensures the last page is also included for checking if memory is > contiguous. > > Signed-off-by:

[PATCH] sh_mobile_ceu_camera: Add physical address alignment checks

2009-12-09 Thread Magnus Damm
From: Magnus Damm Make sure physical addresses are 32-bit aligned in the SuperH Mobile CEU driver. The lowest two bits of the address registers are fixed to zero so frame buffers have to bit 32-bit aligned. The V4L2 mmap() case is using dma_alloc_coherent() for this driver which will return

[PATCH] sh_mobile_ceu_camera: Remove frame size page alignment

2009-12-09 Thread Magnus Damm
From: Magnus Damm This patch updates the SuperH Mobile CEU driver to not page align the frame size. Useful in the case of USERPTR with non-page aligned frame sizes and offsets. Signed-off-by: Magnus Damm --- drivers/media/video/sh_mobile_ceu_camera.c |5 ++--- 1 file changed, 2

Re: [PATCH] sh_mobile_ceu_camera: Remove frame size page alignment

2009-12-10 Thread Magnus Damm
On Thu, Dec 10, 2009 at 10:06 PM, Guennadi Liakhovetski wrote: > On Wed, 9 Dec 2009, Magnus Damm wrote: > >> From: Magnus Damm >> >> This patch updates the SuperH Mobile CEU driver to >> not page align the frame size. Useful in the case of >> USERPTR with non-

[PATCH] sh_mobile_ceu_camera: Add physical address alignment checks V2

2009-12-11 Thread Magnus Damm
From: Magnus Damm Make sure physical addresses are 32-bit aligned in the SuperH Mobile CEU driver V2. The lowest two bits of the frame address registers are fixed to zero so frame buffers have to be 32-bit aligned. The V4L2 mmap() case is using dma_alloc_coherent() for this driver which will

Re: [PATCH 3/3] ARM: switch mackerel to dynamically manage the platform camera

2011-03-22 Thread Magnus Damm
On Mon, Mar 21, 2011 at 10:22 PM, Guennadi Liakhovetski wrote: > On Wed, 16 Mar 2011, Magnus Damm wrote: > >> On Tue, Feb 22, 2011 at 6:57 PM, Guennadi Liakhovetski >> wrote: >> > Use soc_camera_platform helper functions to dynamically manage the >> > ca

Re: [PATCH 3/3] ARM: switch mackerel to dynamically manage the platform camera

2011-03-22 Thread Magnus Damm
On Mon, Mar 21, 2011 at 10:22 PM, Guennadi Liakhovetski wrote: > On Wed, 16 Mar 2011, Magnus Damm wrote: > >> On Tue, Feb 22, 2011 at 6:57 PM, Guennadi Liakhovetski >> wrote: >> > Use soc_camera_platform helper functions to dynamically manage the >> > ca

[PATCH] videobuf-dma-contig: zero copy USERPTR V3 comments

2009-05-12 Thread Magnus Damm
From: Magnus Damm This patch adds function descriptions to V3 of the V4L2 videobuf-dma-contig USERPTR zero copy patch. Signed-off-by: Magnus Damm --- drivers/media/video/videobuf-dma-contig.c | 16 1 file changed, 16 insertions(+) --- 0005/drivers/media/video/videobuf-dma

Re: [PATCH] videobuf-dma-contig: zero copy USERPTR support V3

2009-05-12 Thread Magnus Damm
On Mon, May 11, 2009 at 10:36 PM, Mauro Carvalho Chehab wrote: > Em Fri, 8 May 2009 13:06:58 -0700 > Andrew Morton escreveu: > >> On Fri, 08 May 2009 17:53:10 +0900 >> Magnus Damm wrote: >> >> > From: Magnus Damm >> > >> > This is V3 o

Re: [PATCH 0/3] Convert SuperH camera-enabled platforms to soc-camera as platform_device

2009-05-21 Thread Magnus Damm
not tried capturing with that board though. Thanks for your help! Acked-by: Magnus Damm -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-14 Thread Magnus Damm
On Wed, Jun 10, 2009 at 5:55 AM, wrote: > From: Muralidharan Karicheri > > re-sending with RFC in the header > > This patch adds support for setting bus parameters such as bus type > (BT.656, BT.1120 etc), width (example 10 bit raw image data bus) > and polarities (vsync, hsync, field etc) in sub

Re: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-15 Thread Magnus Damm
On Tue, Jun 16, 2009 at 1:01 AM, Karicheri, Muralidharan wrote: >>> + >>> +struct v4l2_subdev_bus { >>> +       enum v4l2_subdev_bus_type type; >>> +       u8 width; >>> +       /* 0 - active low, 1 - active high */ >>> +       unsigned pol_vsync:1; >>> +       /* 0 - active low, 1 - active high */

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-17 Thread Magnus Damm
On Mon, Jun 15, 2009 at 12:33 AM, Guennadi Liakhovetski wrote: > On Fri, 12 Jun 2009, Hans Verkuil wrote: > >> On Friday 12 June 2009 14:59:03 Guennadi Liakhovetski wrote: >> > On Fri, 12 Jun 2009, Hans Verkuil wrote: >> > >> > > > 1. it is very unusual that the board designer has to mandate what

Re: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-17 Thread Magnus Damm
On Tue, Jun 16, 2009 at 11:33 PM, Karicheri, Muralidharan wrote: > > >>> >>> [MK]In that case can't the driver just ignore the field polarity? I >>assume that drivers implement the parameter that has support in hardware. >>So it is not an issue. >> >>No, because the same driver runs on hardware th

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-18 Thread Magnus Damm
On Wed, Jun 17, 2009 at 5:33 PM, Hans Verkuil wrote: >> I think automatic negotiation is a good thing if it is implemented >> correctly. >> >> Actually, i think modelling software after hardware is a good thing >> and from that perspective the soc_camera was (and still is) a very >> good fit for ou

Re: Linux Plumbers Conference 2009: V4L2 API discussions

2009-08-04 Thread Magnus Damm
On Wed, Aug 5, 2009 at 5:14 AM, Karicheri, Muralidharan wrote: > 2) Previewer & Resizer driver. I am working with Vaibhav who had worked on an > RFC for this. The previewer and resizer devices are doing memory to memory > operations. Also should be flexible to use these hardware with capture driv

Re: Linux Plumbers Conference 2009: V4L2 API discussions

2009-08-04 Thread Magnus Damm
On Wed, Aug 5, 2009 at 12:06 PM, Hiremath, Vaibhav wrote: >> -Original Message- >> From: Magnus Damm [mailto:magnus.d...@gmail.com] >> Sent: Wednesday, August 05, 2009 8:01 AM >> To: Karicheri, Muralidharan >> Cc: Hiremath, Vaibhav; Hans Verkuil; linux-med

Re: POLL: for/against dropping support for kernels < 2.6.22

2009-02-26 Thread Magnus Damm
On Sun, Feb 22, 2009 at 7:15 PM, Hans Verkuil wrote: > Should we drop support for kernels <2.6.22 in our v4l-dvb repository? > > _: Yes > _: No Yes. > Optional question: > > Why: Focus on moving forward instead of looking backwards. Keeping user space compatibilty is of course a good idea, but

Re: [PATCH 0/5] soc-camera: convert to platform device

2009-04-17 Thread Magnus Damm
Hi Guennadi, On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski wrote: > This patch series is a preparation for the v4l2-subdev conversion. Please, > review and test. My current patch-stack in the form of a > (manually-created) quilt-series is at > http://www.open-technology.de/download/20090

Re: [PATCH 0/5] soc-camera: convert to platform device

2009-04-17 Thread Magnus Damm
On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski wrote: > On Fri, 17 Apr 2009, Magnus Damm wrote: >> On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski >> wrote: >> > This patch series is a preparation for the v4l2-subdev conversion. Please, >> > review

Re: [PATCH 0/5] soc-camera: convert to platform device

2009-04-20 Thread Magnus Damm
Hi Morimoto-san, On Mon, Apr 20, 2009 at 9:12 AM, Kuninori Morimoto wrote: > > Hi Magnus > >> >> > http://www.open-technology.de/download/20090415/ based on linux-next >> >> > history branch, commit ID in -base file. Don't be surprised, that >> >> > patch-set also contains a few not directly

Re: [PATCH 0/5] soc-camera: convert to platform device

2009-04-20 Thread Magnus Damm
On Fri, Apr 17, 2009 at 7:43 PM, Guennadi Liakhovetski wrote: > On Fri, 17 Apr 2009, Magnus Damm wrote: >> On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski >> wrote: >> > On Fri, 17 Apr 2009, Magnus Damm wrote: >> >> On Wed, Apr 15, 2009 at 9:17 PM

Re: [PATCH 0/5] soc-camera: convert to platform device

2009-04-20 Thread Magnus Damm
On Mon, Apr 20, 2009 at 4:22 PM, Guennadi Liakhovetski wrote: > On Mon, 20 Apr 2009, Magnus Damm wrote: >> On Fri, Apr 17, 2009 at 7:43 PM, Guennadi Liakhovetski >> wrote: >> > On Fri, 17 Apr 2009, Magnus Damm wrote: >> >> On Fri, Apr 17, 2009 at 4:51 PM

Re: [PATCH 0/5] soc-camera: convert to platform device

2009-04-20 Thread Magnus Damm
On Mon, Apr 20, 2009 at 5:14 PM, Guennadi Liakhovetski wrote: > On Mon, 20 Apr 2009, Magnus Damm wrote: >> Can you please test on your Migo-R board? I'd be happy to assist you >> in setting up your environment. > > I did test it and it worked - exactly as you say - wit

[PATCH][RFC] videobuf-dma-config: zero copy USERPTR support

2009-04-20 Thread Magnus Damm
From: Magnus Damm Zero copy video frame capture from user space using V4L2 USERPTR. This patch adds USERPTR support to the videobuf-dma-contig buffer code. Since videobuf-dma-contig is designed to handle physically contiguous memory, this patch modifies the videobuf-dma-contig code to only

[PATCH] videobuf-dma-contig: remove sync operation

2009-04-28 Thread Magnus Damm
From: Magnus Damm Remove the videobuf-dma-contig sync operation. Sync is only needed for noncoherent buffers, and since videobuf-dma-contig is built on coherent memory allocators the memory is by definition always in sync. Reported-by: Matthieu CASTET Signed-off-by: Magnus Damm --- Thanks

[PATCH] videobuf-dma-contig: zero copy USERPTR support V2

2009-04-28 Thread Magnus Damm
From: Magnus Damm This is V2 of the V4L2 videobuf-dma-contig USERPTR zero copy patch. Since videobuf-dma-contig is designed to handle physically contiguous memory, this patch modifies the videobuf-dma-contig code to only accept a pointer to physically contiguous memory. For now only VM_PFNMAP

Re: [PATCH] videobuf-dma-contig: zero copy USERPTR support V2

2009-04-30 Thread Magnus Damm
On Tue, Apr 28, 2009 at 6:01 PM, Magnus Damm wrote: > This is V2 of the V4L2 videobuf-dma-contig USERPTR zero copy patch. I guess the V4L2 specific bits are pretty simple. As for the minor mm modifications below, > --- 0001/mm/memory.c > +++ work/mm/memory.c    2009-04-28 14:56:43.

Re: [patch 1/3] mm: introduce follow_pte()

2009-05-08 Thread Magnus Damm
wait for them. > > Magnus, the actual conversion of your code should be trivial, could > you respin it on top of these three patches using follow_pfn() then? So I tested the patches in -mm (1/3, 2/3, 3/3) together with the zero copy patch and everything seems fine. Feel free to a

[PATCH] videobuf-dma-contig: zero copy USERPTR support V3

2009-05-08 Thread Magnus Damm
From: Magnus Damm This is V3 of the V4L2 videobuf-dma-contig USERPTR zero copy patch. Since videobuf-dma-contig is designed to handle physically contiguous memory, this patch modifies the videobuf-dma-contig code to only accept a user space pointer to physically contiguous memory. For now only

[PATCH] V4L/DVB: soc-camera: module_put() fix

2010-07-05 Thread Magnus Damm
From: Magnus Damm Avoid calling module_put() if try_module_get() has been skipped. Signed-off-by: Magnus Damm --- drivers/media/video/soc_camera.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- 0001/drivers/media/video/soc_camera.c +++ work/drivers/media/video/soc_camera.c

[PATCH] soc-camera: return -ENODEV is sensor is missing

2010-02-09 Thread Magnus Damm
From: Magnus Damm Update the soc-camera i2c code to return -ENODEV if a camera sensor is missing instead of -ENOMEM. Signed-off-by: Magnus Damm --- drivers/media/video/soc_camera.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) --- 0001/drivers/media/video/soc_camera.c

Re: [PATCH 1/3 v2] V4L: SuperH Video Output Unit (VOU) driver

2010-03-18 Thread Magnus Damm
Hey Guennadi, On Thu, Mar 18, 2010 at 7:28 PM, Guennadi Liakhovetski wrote: > A number of SuperH SoCs, including sh7724, include a Video Output Unit. This > patch adds a video (V4L2) output driver for it. The driver uses v4l2-subdev > and > mediabus APIs to interface to TV encoders. > > Signed-o

Re: [PATCH/RFC v2 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based format API

2011-08-28 Thread Magnus Damm
On Fri, Aug 19, 2011 at 6:37 PM, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart > --- >  arch/arm/mach-shmobile/board-ag5evm.c   |    2 +- >  arch/arm/mach-shmobile/board-ap4evb.c   |    4 +- >  arch/arm/mach-shmobile/board-mackerel.c |    4 +- >  drivers/video/sh_mobile_lcdcfb.c      

Re: acks needed

2011-09-28 Thread Magnus Damm
ags anymore > http://patchwork.linuxtv.org/patch/7523/ They all look fine to me, thanks. Please note that I have not performed any kind of testing of the patches above, but as usual I expect you to fix up eventual issues by yourself. =) Acked-by: Magnus Damm -- To unsubscribe from this list:

[PATCH/RFC] v4l: vsp1: Use FCP device for DisplayList and VB2 queue

2016-10-27 Thread Magnus Damm
From: Magnus Damm Incrementally fix up parts of the code not yet covered by the IOMMU patches by Laurent: [PATCH 0/6] R-Car DU: Fix IOMMU operation when connected to VSP This patch simply uses the recently introduced function rcar_fcp_get_device() on the VSP device to retrieve the FCP device

Re: [PATCH 14/15] ARM: shmobile: Remove AP4EVB board support

2013-06-16 Thread Magnus Damm
On Mon, Jun 17, 2013 at 3:12 PM, Guennadi Liakhovetski wrote: > On Mon, 17 Jun 2013, Magnus Damm wrote: > > [snip] > >> So Guennadi, if you want to keep this board then you have to step up >> and fix things. If not then there is no point in keeping it. > > Ok, after

Re: [PATCH v2 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-24 Thread Magnus Damm
Hi Sergei, On Fri, Apr 19, 2013 at 11:31 PM, Sergei Shtylyov wrote: > From: Vladimir Barinov > > Add Renesas R-Car VIN (Video In) V4L2 driver. > > Based on the patch by Phil Edworthy . > > Signed-off-by: Vladimir Barinov > [Sergei: removed deprecated IRQF_DISABLED flag.] > Signed-off-by: Sergei

Re: [PATCH] sh_mobile_ceu_camera: NV12/21/16/61 are added only once.

2009-01-22 Thread Magnus Damm
On Fri, Jan 23, 2009 at 9:28 AM, Kuninori Morimoto wrote: > NV12/21/16/61 had been added every time > UYVY/VYUY/YUYV/YVYU appears on get_formats. > This patch modify this problem. That's one way to do it. Every similar driver has to do the same thing. Yuck. Or we could have a better translation

Re: [PATCH] sh_mobile_ceu_camera: NV12/21/16/61 are added only once.

2009-02-06 Thread Magnus Damm
On Fri, Feb 6, 2009 at 8:21 AM, Guennadi Liakhovetski wrote: > On Fri, 23 Jan 2009, Magnus Damm wrote: >> On Fri, Jan 23, 2009 at 9:28 AM, Kuninori Morimoto >> wrote: >> > NV12/21/16/61 had been added every time >> > UYVY/VYUY/YUYV/YVYU appears on get_formats. &g

Re: soc-camera : sh_mobile_ceu_camera race on free_buffer ?

2009-02-13 Thread Magnus Damm
Hi Matthieu, [CC Morimoto-san] [Changed list to linux-media] On Tue, Jan 20, 2009 at 6:27 PM, Matthieu CASTET wrote: > Magnus Damm a écrit : >> On Mon, Jan 19, 2009 at 11:02 PM, Matthieu CASTET >>> But we didn't do stop_capture, so as far I understand the controller is &g

Re: [PATCH 2/2] soc-camera: configure drivers with a default format on open

2009-02-23 Thread Magnus Damm
On Fri, Feb 20, 2009 at 12:20 AM, Guennadi Liakhovetski wrote: > Currently soc-camera doesn't set up any image format without an explicit > S_FMT. > It seems this should be supported, since, for example, capture-example.c from > v4l2-apps by default doesn't issue an S_FMT. This patch configures a

Re: About the specific setting for lens

2009-02-24 Thread Magnus Damm
On Tue, Feb 24, 2009 at 10:17 PM, Guennadi Liakhovetski wrote: > On Mon, 23 Feb 2009, morimoto.kunin...@renesas.com wrote: > >> >> Dear Guennadi. >> >> Now MigoR and AP325 board have ov772x camera. >> However, the lens used is different. >> >> And I have a specific good setting value >> for the le

Re: [PATCH v2 2/2] sh_mobile_ceu: Add field signal operation

2009-02-26 Thread Magnus Damm
On Thu, Feb 5, 2009 at 5:04 PM, Guennadi Liakhovetski wrote: > On Tue, 3 Feb 2009, Kuninori Morimoto wrote: > >> sh_mobile_ceu can support "field signal" from external module. >> To support this operation, SH_CEU_FLAG_USE_FLDID_{HIGH, LOW} >> are added to header. > > I never dealt with interlaced