Rajendra,
Few bugs in the code
1) curr_level of the shared_resource is not updated in update_resource_level
2) resource_request invokes spin_lock_irqsave and then if it is a request for a
new device it invokes get_user().
get_user() calls kmalloc with GFP_KERNEL. So it can
-Original Message-
From: Dasgupta, Romit [mailto:[EMAIL PROTECTED]
Sent: Friday, October 17, 2008 11:47 AM
To: Nayak, Rajendra; linux-omap@vger.kernel.org
Subject: RE: [PATCH 01/04] OMAP3 SRF: Generic shared resource f/w
Rajendra,
Few bugs in the code
1)
Remove CONFIG_OMAP_SYSOFFMODE flag and do the full initialization of voltage
controller . Enabling automatic sending of OFF command and selecting wether
SYS_OFF_MODE signal is used should be determined dynamically. Hence they are
now not set in the initialization.
The sleep voltage for OFF mode
1) curr_level of the shared_resource is not updated in
update_resource_level
Yes, its not. Its done as part of the platform specific change_level call.
[Romit] Kindly see below. I was thinking that it is better that we do not
access any fields of struct shared_resource from outside this file.
-Original Message-
From: Dasgupta, Romit [mailto:[EMAIL PROTECTED]
Sent: Friday, October 17, 2008 1:06 PM
To: Nayak, Rajendra; linux-omap@vger.kernel.org
Subject: RE: [PATCH 01/04] OMAP3 SRF: Generic shared resource f/w
1) curr_level of the shared_resource is not updated in
Hi Lauri,
I think we should merge your patch along with the SO patch also, so in the
event of a spurious interrupt, it won't wedge the whole system. One
question though:
On Wed, 15 Oct 2008, Lauri Leukkunen wrote:
This prevents spurious interrupts from repeating unacked and
thus locking
Ergo the observation that the TWL5030 ES1.0
parts seem to mis-identify themselves.
The delta TRM between TWL4030 and TWL5030 has a note, which says,
The part code number is meaning less when accessed through the I2C;
which means, over JTAG, the ID code should reflect 0x0009802F.
I have not
On Thu, Oct 16, 2008 at 04:09:47PM -0700, ext David Brownell wrote:
On Wednesday 15 October 2008, Peter 'p2' De Schrijver wrote:
--- /dev/null
+++ b/arch/arm/mach-omap2/twl4030-generic-scripts.h
@@ -0,0 +1,8 @@
+#ifndef __TWL4030_GENERIC_SCRIPTS_H
+#define __TWL4030_GENERIC_SCRIPTS_H
On Thu, Oct 16, 2008 at 01:46:08PM -0700, David Brownell wrote:
On Thursday 16 October 2008, Koen Kooi wrote:
The MUSB transceiver-level issues I was aware of (mostly
on Overo, but minor glitches on Beagle) now seem to be
fixed by the combination of the IRQ patches I sent last
week,
Some more points can be noted
resource_init function is not prefixed by __init
1) curr_level of the shared_resource is not updated in
update_resource_level
Yes, its not. Its done as part of the platform specific
change_level call.
[Romit] Kindly see below. I was thinking that it is
+ */
+int set_latency(struct shared_resource *resp, u32 latency)
+{
+ u8 *pm_qos_req_added;
+
+ if (resp-curr_level == latency)
+ return 0;
+ else
+ /* Update the resources current level */
+ resp-curr_level = latency;
+
[Romit] I think this
And finally, you had proposed to move to mutex instead of spin locks. Are you
sure that we would do a resource_request or request_release from an interrupt
context? If unsure maybe we can keep using spin locks and move to using
GFP_ATOMIC. You may decide.
--
To unsubscribe from this list: send
One final point
+int set_pd_latency(struct shared_resource *resp, u32 latency)
+{
+ u32 pd_lat_level, ind;
+ struct pd_latency_db *pd_lat_db;
+ struct powerdomain *pwrdm;
+
+ pd_lat_db = resp-resource_data;
+ pwrdm = pd_lat_db-pd;
+ pd_lat_level = PD_LATENCY_OFF;
+ /*
Hi,
With latest linux-omap kernel, the dpll4_ck rate is a bit funny:
~ # cat /debug/clock/virt_26m_ck/osc_sys_ck/sys_ck/rate
1300
~ # cat /debug/clock/virt_26m_ck/osc_sys_ck/sys_ck/dpll4_ck/rate
3224773576
~ #
cat /debug/clock/virt_26m_ck/osc_sys_ck/sys_ck/dpll4_ck/dpll4_m4_ck/rate
On Fri, 2008-10-17 at 14:08 +0300, ext Tomi Valkeinen wrote:
Hi,
With latest linux-omap kernel, the dpll4_ck rate is a bit funny:
~ # cat /debug/clock/virt_26m_ck/osc_sys_ck/sys_ck/rate
1300
~ # cat /debug/clock/virt_26m_ck/osc_sys_ck/sys_ck/dpll4_ck/rate
3224773576
The reason
From: Madhusudhan Chikkature [EMAIL PROTECTED]
This patch provides the BQ27000 slave interface driver.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
Acked-by: Evgeniy Polyakov [EMAIL PROTECTED]
---
drivers/w1/slaves/Kconfig |7 ++
drivers/w1/slaves/Makefile |2
From: Madhusudhan Chikkature [EMAIL PROTECTED]
This patch adds a brief documentation about omap2430/3430 HDQ/1-wire driver.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
Acked-by: Evgeniy Polyakov [EMAIL PROTECTED]
---
Documentation/w1/masters/omap-hdq | 46
From: Madhusudhan Chikkature [EMAIL PROTECTED]
The HDQ/1-Wire module of TI OMAP2430/3430 platforms implement the hardware
protocol of the master functions of the Benchmark HDQ and the Dallas
Semiconductor 1-Wire protocols. These protocols use a single wire for
communication between the master
* Jarkko Nikula [EMAIL PROTECTED] [080930 04:52]:
On Mon, 29 Sep 2008 23:21:00 +0100
ext Ben Dooks [EMAIL PROTECTED] wrote:
On Thu, Sep 25, 2008 at 10:53:47AM +0300, Tony Lindgren wrote:
From: Jarkko Nikula [EMAIL PROTECTED]
If there is a signal pending and
* Ben Dooks [EMAIL PROTECTED] [080929 15:26]:
On Thu, Sep 25, 2008 at 10:53:49AM +0300, Tony Lindgren wrote:
From: Syed Mohammed Khasim [EMAIL PROTECTED]
Omap2430 has additional support for high-speed I2C.
This patch moves I2C speed parameter (from module) to platform data.
Also
* Ben Dooks [EMAIL PROTECTED] [080929 15:28]:
On Thu, Sep 25, 2008 at 10:53:51AM +0300, Tony Lindgren wrote:
From: Chandra shekhar [EMAIL PROTECTED]
Not very informative description in here. At lease you could have
copied the subject?
Here's this one updated.
Tony
Signed-off-by:
* Ben Dooks [EMAIL PROTECTED] [080929 15:30]:
On Thu, Sep 25, 2008 at 10:53:52AM +0300, Tony Lindgren wrote:
From: Paul Walmsley [EMAIL PROTECTED]
Mark functions called only at init time as __init.
surely these should be __devinit in case of hotplugged-ness?
Here's this one fixed.
* Paul Walmsley [EMAIL PROTECTED] [080929 22:36]:
On Mon, 29 Sep 2008, Paul Walmsley wrote:
Hello Ben, David,
On Mon, 29 Sep 2008, David Brownell wrote:
On Monday 29 September 2008, Ben Dooks wrote:
-static void __exit omap_i2c_exit_driver(void)
+static void __devexit
* Ben Dooks [EMAIL PROTECTED] [080929 15:31]:
On Thu, Sep 25, 2008 at 10:53:54AM +0300, Tony Lindgren wrote:
Minor checkpatch and formatting clean-up. Also update copyrights.
looks ok, assuming it doesn't get broken by any changes
from the review comments i've made earlier in the series.
Hi,
This patch fixes this warning which, as Tomi Valkeinen pointed out, is
really an error.
CC arch/arm/mach-omap2/clock34xx.o
arch/arm/mach-omap2/clock34xx.c: In function 'omap3_noncore_dpll_enable':
arch/arm/mach-omap2/clock34xx.c:290: warning: 'rate' is used uninitialized in
this
* Tony Lindgren [EMAIL PROTECTED] [080929 22:33]:
* Ben Dooks [EMAIL PROTECTED] [080930 01:23]:
On Thu, Sep 25, 2008 at 10:53:46AM +0300, Tony Lindgren wrote:
Hi all,
Here's a repost of the whole series, the first series had a compile
error starting with one of the patches. Sorry
* Tony Lindgren [EMAIL PROTECTED] [081017 08:40]:
* Ben Dooks [EMAIL PROTECTED] [080929 15:30]:
On Thu, Sep 25, 2008 at 10:53:52AM +0300, Tony Lindgren wrote:
From: Paul Walmsley [EMAIL PROTECTED]
Mark functions called only at init time as __init.
surely these should be __devinit
Hi,
I got the lastest code on Oct 16 via:
git clone git://source.mvista.com/git/linux-omap-2.6.git
cd linux-omap-2.6
make omap3_beagle_defconfig
make uImage CROSS_COMPILE=arm-angstrom-linux-gnueabi- CC=ccache
arm-angstrom-linux-gnueabi-gcc-4.2.1+csl-arm-2007q3-53
Hi,
I got the lastest code on Oct 16 via:
git clone git://source.mvista.com/git/linux-omap-2.6.git
cd linux-omap-2.6
make omap3_beagle_defconfig
make uImage CROSS_COMPILE=arm-angstrom-linux-gnueabi- CC=ccache
arm-angstrom-linux-gnueabi-gcc-4.2.1+csl-arm-2007q3-53
The previous driver for bq27x00 batteries was a real
ifdef mess. The following patches separate common code
and create separate drivers for bq27200 and bq27000.
The code looks much cleaner, but we had to keep a global
static pointer to hold the i2c_client (bq27200) or the
w1 device (bq27000).
If
put common code into a separate file and link it to new
drivers which will come in later patches.
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/power/bq27x00.c | 190 +++
drivers/power/bq27x00.h | 54 +
2 files changed, 244
The old driver was an ifdef mess. Writing separate drivers
using common 'library-like' code seemed to be a better choice.
The old driver is then deleted and Makefile/Kconfig are changed
to make place for new bq27200 and bq27000 drivers.
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
Create a separate driver for bq27000 chip. On a later patch,
the old file and cold will be remove and Makefile/Kconfig
updated
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/power/bq27000.c | 173 +++
1 files changed, 173 insertions(+), 0
Create a separate driver for bq27200 chip. On a later patch,
the old file and cold will be remove and Makefile/Kconfig
updated.
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/power/bq27200.c | 202 +++
1 files changed, 202 insertions(+), 0
up to 1000mhz it's Fast Mode+, not highspeed.
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/busses/i2c-omap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index a999606..53d6244 100644
---
* Gadiyar, Anand [EMAIL PROTECTED] [081017 12:01]:
Hi,
I got the lastest code on Oct 16 via:
git clone git://source.mvista.com/git/linux-omap-2.6.git
cd linux-omap-2.6
make omap3_beagle_defconfig
make uImage CROSS_COMPILE=arm-angstrom-linux-gnueabi- CC=ccache
On Fri, 17 Oct 2008, Paul Walmsley wrote:
+ ldrne \irqnr, [\base, #INTCPS_SIR_IRQ_OFFSET]
+#if defined(CONFIG_ARCH_OMAP34XX)
+ mov \irqstat, \irqnr
+ bic \irqstat, \irqstat, #0x7f /* check for spurious flag */
According to Table 10-14 in the TRM,
* Paul Walmsley [EMAIL PROTECTED] [081017 01:30]:
Hi Lauri,
I think we should merge your patch along with the SO patch also, so in the
event of a spurious interrupt, it won't wedge the whole system. One
question though:
On Wed, 15 Oct 2008, Lauri Leukkunen wrote:
This prevents
* Felipe Balbi [EMAIL PROTECTED] [081003 01:02]:
On Fri, Oct 03, 2008 at 12:03:33AM -0700, David Brownell wrote:
From: David Brownell [EMAIL PROTECTED]
Various cleanups to the OMAP EHCI bus glue:
- Whitespace fixes.
- Busy-wait loops should really have timeouts, but lacking
I'm curious ... has anyone signed up to make the twl4030 code
plug into the drivers/regulator framework?
I noticed that for example on Beagle, most of the regulators
are unneeded and should probably be disabled. (I'll guess
the same is true on Overo, but less so on Labrador and so on.)
Doing
* arun c [EMAIL PROTECTED] [080918 05:49]:
As sugested by RMK
Pushing today.
Tony
Signed-off-by: Arun C [EMAIL PROTECTED]
---
arch/arm/plat-omap/include/mach/omapfb.h |4 ++--
drivers/video/omap/omapfb_main.c |6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
Hi Felipe,
On Sat, Oct 18, 2008 at 12:00:44AM +0300, Felipe Balbi wrote:
The previous driver for bq27x00 batteries was a real
ifdef mess. The following patches separate common code
and create separate drivers for bq27200 and bq27000.
The code looks much cleaner, but we had to keep a global
* Arun KS [EMAIL PROTECTED] [080924 22:32]:
Hi,
Please ignore all the previous patches I have send.
I did some modifications and here are the final series.
Patch 1 : Adds mux settings required for mspi1 and gpio_85.
Patch 2 : Adds support for ads7846 touchscreen driver on omap2evm.
Patch
* Arun KS [EMAIL PROTECTED] [080925 00:34]:
Adding MCBSP port 1, 3, 4 and 5 ports mux settings for 2430.
Pushing.
Tony
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mux.c | 24
arch/arm/plat-omap/include/mach/mux.h | 24
On Sat, Oct 18, 2008 at 01:40:06AM +0400, Anton Vorontsov wrote:
One thing though: we can't delete the old driver now. I'm about
to send a pull request to Linus. Though I think we can hurry up and
merge the new driver for 2.6.28, but delete the old one in 2.6.29.
This means that you might
On Sat, Oct 18, 2008 at 12:09:55AM +0300, Felipe Balbi wrote:
up to 1000mhz it's Fast Mode+, not highspeed.
mill-hz? 1MHz or 1000kHz.
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/busses/i2c-omap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
* Felipe Balbi [EMAIL PROTECTED] [080930 11:49]:
That cast was annyoing for quite a while. Now
omap_ctrl_base_get() returns void __iomem *
and __raw_read/write friends uses void __iomem *
so there's no need for casting.
Pushing the board-3430sdp.c changes, board-ldp.c is already fixed.
Tony
* Tony Lindgren [EMAIL PROTECTED] [081002 23:22]:
* Peter Ujfalusi [EMAIL PROTECTED] [081002 16:03]:
Hello,
the diff between l-o and mainline are these commits regarding to
omap-keypad.c:
commit fdee8764947cde1e6933e7d981ce5b9de00e83e6
Author: Tony Lindgren [EMAIL PROTECTED]
* Timo Karjalainen [EMAIL PROTECTED] [081002 02:09]:
This patch fixes two problems in LM8323 PWM control. One is that
locking is needed when setting and reading pwm-desired_brightness
asynchronously. The other is that LM8323 may stop a PWM script only
after the current instruction has
Hi Rick,
On Fri, 17 Oct 2008, Rick Bronson wrote:
This patch fixes this warning which, as Tomi Valkeinen pointed out, is
really an error.
thanks for the patch - but _omap3_noncore_dpll_bypass() and
_omap3_noncore_dpll_lock() don't return rates. Will post a patch to fix
this bug shortly.
Commit 8b1f0bd44fe490ec631230c8c040753a2bda8caa introduced a bug that
caused non-CORE DPLL rates to be incorrectly set on boot in
omap3_noncore_dpll_enable(). Debugged by Tomi Valkeinen
[EMAIL PROTECTED] - thanks Tomi.
Also fix omap3_noncore_dpll_set_rate() to assign clk-rate after a
DPLL
* vimal singh [EMAIL PROTECTED] [081006 23:11]:
Moving NAND_BLOCK_SIZE definition to board-3430sdp-flash.c
Hmm, looks like this reverts some earlier mistake, pushing.
Tony
Signed-off-by: Vimal Singh [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-3430sdp-flash.c |2 ++
* Sanjeev Premi [EMAIL PROTECTED] [081010 06:51]:
Fix these compiler warnings:
smartreflex.c:126: warning: initialization makes integer from pointer without
a cast
smartreflex.c:134: warning: initialization makes integer from pointer without
a cast
Refreshed after updates from Felipe.
* Sanjeev Premi [EMAIL PROTECTED] [081010 07:06]:
Signed-off-by: Sanjeev Premi [EMAIL PROTECTED]
Pushing.
Tony
---
arch/arm/mach-omap2/smartreflex.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c
* Felipe Balbi [EMAIL PROTECTED] [081013 09:02]:
num_eps is 16, not 32.
Pushing.
Tony
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-n800-usb.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-n800-usb.c
* Paul Walmsley [EMAIL PROTECTED] [081017 15:19]:
Commit 8b1f0bd44fe490ec631230c8c040753a2bda8caa introduced a bug that
caused non-CORE DPLL rates to be incorrectly set on boot in
omap3_noncore_dpll_enable(). Debugged by Tomi Valkeinen
[EMAIL PROTECTED] - thanks Tomi.
Also fix
From: Vikram Pandita [EMAIL PROTECTED]
Fix following bootup crash on LDP platform by enabling T2 USB driver for MUSB
Backtrace:
[c001b9ac] (musb_platform_init+0x0/0x120) from [c001b0a8]
(musb_probe+0x208/0xb0c)
r5: r4:c0222ad4
[c001aea0] (musb_probe+0x0/0xb0c) from [c0142e80]
On Fri, Oct 17, 2008 at 10:51:24PM +0100, Ben Dooks wrote:
On Sat, Oct 18, 2008 at 12:09:55AM +0300, Felipe Balbi wrote:
up to 1000mhz it's Fast Mode+, not highspeed.
mill-hz? 1MHz or 1000kHz.
hehe, typo :-)
Thanks
--
balbi
--
To unsubscribe from this list: send the line unsubscribe
On Sat, Oct 18, 2008 at 04:38:04AM +0530, Pandita, Vikram wrote:
From: Vikram Pandita [EMAIL PROTECTED]
Fix following bootup crash on LDP platform by enabling T2 USB driver for MUSB
Backtrace:
[c001b9ac] (musb_platform_init+0x0/0x120) from [c001b0a8]
(musb_probe+0x208/0xb0c)
59 matches
Mail list logo
