Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-12-22 Thread Srikar
Updated version of patch of this is available at https://patchwork.kernel.org/patch/424731/ On 11/30/2010 07:39 PM, ext Tony Lindgren wrote: * Mark Brown broo...@opensource.wolfsonmicro.com [101129 10:27]: On Mon, Nov 29, 2010 at 10:18:31AM -0800, Tony Lindgren wrote: * Mark Brown

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-30 Thread Tony Lindgren
* Mark Brown broo...@opensource.wolfsonmicro.com [101129 10:27]: On Mon, Nov 29, 2010 at 10:18:31AM -0800, Tony Lindgren wrote: * Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]: Yeah. Some of it will need to be __devinitdata for hotpluggable things but most of it should

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-29 Thread Tony Lindgren
* Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]: On Fri, Nov 26, 2010 at 09:45:17AM -0800, Tony Lindgren wrote: By the way, all the board specific data should be __initdata eventually. Now we're hogging memory for the regulators for all the boards compiled in.. Yeah.

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-29 Thread Mark Brown
On Mon, Nov 29, 2010 at 10:18:31AM -0800, Tony Lindgren wrote: * Mark Brown broo...@opensource.wolfsonmicro.com [101127 02:10]: Yeah. Some of it will need to be __devinitdata for hotpluggable things but most of it should be __initdata. I'll update the regulator API to copy the

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-27 Thread Mark Brown
On Fri, Nov 26, 2010 at 09:45:17AM -0800, Tony Lindgren wrote: By the way, all the board specific data should be __initdata eventually. Now we're hogging memory for the regulators for all the boards compiled in.. Yeah. Some of it will need to be __devinitdata for hotpluggable things but most

RE: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread ext-srikar.1.bhavanarayana
...@opensource.wolfsonmicro.com] Sent: Thursday, November 25, 2010 6:11 PM To: Bhavanarayana Srikar.1 (EXT-Elektrobit/Helsinki) Cc: t...@atomide.com; li...@arm.linux.org.uk; linux-omap@vger.kernel.org Subject: Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51 On Thu, Nov 25, 2010 at 05:52:23PM

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Srikar
On 11/25/2010 06:11 PM, ext Mark Brown wrote: On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = { +{ +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) The ifdefs here aren't really saving much... Currently

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Mark Brown
On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote: On 11/25/2010 06:11 PM, ext Mark Brown wrote: On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = { + { +#if defined(CONFIG_FB_OMAP2) ||

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Tony Lindgren
* Mark Brown broo...@opensource.wolfsonmicro.com [101126 04:50]: On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote: On 11/25/2010 06:11 PM, ext Mark Brown wrote: On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = {

[PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-25 Thread Srikar
To support tvout on rx51,added the venc vdac regulator consumer supply data and also intialised the vdac regulator with vdac regulator consumer supply data which enables the power supply to venc through twl4030 on rx51 Signed-off-by: Srikar ext-srikar.1.bhavanaray...@nokia.com ---

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-25 Thread Mark Brown
On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = { + { +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) The ifdefs here aren't really saving much... + .supply = vdda_dac, + .dev