Re: Suspend broken on 3.3?

2012-04-12 Thread Raja, Govindraj
On Thu, Apr 12, 2012 at 1:04 AM, Paul Walmsley p...@pwsan.com wrote: Hi a few brief comments based on a quick scan: On Wed, 11 Apr 2012, Raja, Govindraj wrote: Here is the patch [1] to do the same. - I don't see where it affects I/O wakeups for the UART.  If I/O wakeups are still set on

Re: Suspend broken on 3.3?

2012-04-11 Thread Raja, Govindraj
On Tue, Apr 10, 2012 at 11:33 PM, Kevin Hilman khil...@ti.com wrote: Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] Just to summarize on how the behavior should be IIUC

Re: Suspend broken on 3.3?

2012-04-11 Thread Paul Walmsley
Hi a few brief comments based on a quick scan: On Wed, 11 Apr 2012, Raja, Govindraj wrote: Here is the patch [1] to do the same. - I don't see where it affects I/O wakeups for the UART. If I/O wakeups are still set on the UART pads, won't that still wake the chip up from suspend, even if

Re: Suspend broken on 3.3?

2012-04-10 Thread Raja, Govindraj
Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] I don't understand why a user would ever want to disable dynamic wakeups on an in-use serial port via the sysfs power/wakeup file.  (Disabling wakeups from suspend is a

Re: Suspend broken on 3.3?

2012-04-10 Thread Kevin Hilman
Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] I don't understand why a user would ever want to disable dynamic wakeups on an in-use serial port via the sysfs

Re: Suspend broken on 3.3?

2012-04-09 Thread Raja, Govindraj
Hi Kevin / Paul, On Fri, Apr 6, 2012 at 7:51 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: On Wed, 4 Apr 2012, Raja, Govindraj wrote: On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now

Re: Suspend broken on 3.3?

2012-04-09 Thread Kevin Hilman
Raja, Govindraj govindraj.r...@ti.com writes: [...] So incase of uart wakeups are disabled and uart tx/rx is requested can we prevent MPU from low power state. I think that would be a mistake. The main point of disabling UART wakeups is to save power by preventing unwanted wakups on UARTs

Re: Suspend broken on 3.3?

2012-04-09 Thread Paul Walmsley
cc linux-serial Hi On Mon, 9 Apr 2012, Kevin Hilman wrote: Presumably, if a user disables UART wakeups, it means either 1) that UART is not used #1 seems easy enough to handle without the use of power/wakeup. If there are no users of the TTY, then the driver can simply not configure

Re: Suspend broken on 3.3?

2012-04-09 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: [...] I don't understand why a user would ever want to disable dynamic wakeups on an in-use serial port via the sysfs power/wakeup file. (Disabling wakeups from suspend is a different matter, of course.) The OMAP UART driver needs hardware wakeups to

Re: Suspend broken on 3.3?

2012-04-06 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: On Wed, 4 Apr 2012, Raja, Govindraj wrote: On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now what I can think of is to update qos reqest to prevent MPU from transitioning in case

Re: Suspend broken on 3.3?

2012-04-05 Thread Paul Walmsley
On Wed, 4 Apr 2012, Raja, Govindraj wrote: On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now what I can think of is to update qos reqest to prevent MPU from transitioning in case of port activity if wakeup capability

Re: Suspend broken on 3.3?

2012-04-04 Thread Paul Walmsley
Hello Govindraj On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now what I can think of is to update qos reqest to prevent MPU from transitioning in case of port activity if wakeup capability for port is disabled. Haven't been following this thread closely, but this doesn't seem right.

Re: Suspend broken on 3.3?

2012-04-04 Thread Raja, Govindraj
On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: Hello Govindraj On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now what I can think of is to update qos reqest to prevent MPU from transitioning in case of port activity if wakeup capability for port is disabled.

Re: Suspend broken on 3.3?

2012-04-03 Thread Govindraj
...@ti.com, ne...@suse.de Date: Mon, 2 Apr 2012 16:13:13 +0530 Subject: Re: Suspend broken on 3.3? On Fri, Mar 30, 2012 at 5:54 PM, Raja, Govindraj govindraj.r...@ti.com wrote: On Fri, Mar 30, 2012 at 4:34 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja

Re: Suspend broken on 3.3?

2012-04-02 Thread Joe Woodward
: Suspend broken on 3.3? On Fri, Mar 30, 2012 at 5:54 PM, Raja, Govindraj govindraj.r...@ti.com wrote: On Fri, Mar 30, 2012 at 4:34 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc

Re: Suspend broken on 3.3?

2012-03-30 Thread Joe Woodward
: Suspend broken on 3.3? On Thu, Mar 29, 2012 at 5:10 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Joe Woodward j...@terrafix.co.uk To: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com, Raja\\, Govindraj govindraj.r...@ti.com, linux-omap

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
...@ti.com, ne...@suse.de Date: Thu, 29 Mar 2012 19:59:54 +0530 Subject: Re: Suspend broken on 3.3? On Thu, Mar 29, 2012 at 5:10 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Joe Woodward j...@terrafix.co.uk To: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman

Re: Suspend broken on 3.3?

2012-03-30 Thread Joe Woodward
...[snip]... Could you please try attached patch and let me know if this solves the rx issue as well, without using dma mode. Right, I think we've getting closer, but still not quite there... Firstly, the patch adds an include to iomap.h - but this doesn't exist in stock 3.3. Simply

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 2:56 PM, Joe Woodward j...@terrafix.co.uk wrote: ...[snip]... Could you please try attached patch and let me know if this solves the rx issue as well, without using dma mode. Right, I think we've getting closer, but still not quite there... Firstly, the patch

Re: Suspend broken on 3.3?

2012-03-30 Thread Joe Woodward
: Suspend broken on 3.3? On Fri, Mar 30, 2012 at 2:56 PM, Joe Woodward j...@terrafix.co.uk wrote: ...[snip]... Could you please try attached patch and let me know if this solves the rx issue as well, without using dma mode. Right, I think we've getting closer, but still not quite

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
...@ti.com, ne...@suse.de Date: Fri, 30 Mar 2012 15:45:19 +0530 Subject: Re: Suspend broken on 3.3? On Fri, Mar 30, 2012 at 2:56 PM, Joe Woodward j...@terrafix.co.uk wrote: ...[snip]... Could you please try attached patch and let me know if this solves the rx issue as well, without

Re: Suspend broken on 3.3?

2012-03-29 Thread Joe Woodward
: Suspend broken on 3.3? +Paul, NeilBrown who both have worked on/around recent UART breakage since v3.2 Joe Woodward j...@terrafix.co.uk writes: [...] This patch fixes the suspend problem for me, but there is another UART issue... Basically I've got a fairly high speed data source

Re: Suspend broken on 3.3?

2012-03-29 Thread Shubhrajyoti Datta
Hi Joe, After digging a bit further I found that the problem isn't lost characters or character corruption at all... The UART is actually at 430KBaud (not 900KBaud as I mentioned earlier). How did you verify that register read? The data received is very bursty (i.e. sets of messages every

Re: Suspend broken on 3.3?

2012-03-29 Thread Joe Woodward
Hi Joe, After digging a bit further I found that the problem isn't lost characters or character corruption at all... The UART is actually at 460KBaud (not 900KBaud as I mentioned earlier). How did you verify that register read? I actually looked at the setting applied in my code

Re: Suspend broken on 3.3?

2012-03-29 Thread Paul Walmsley
Hello Joe, thanks for reporting this. Some thoughts -- really just pure speculation -- but I hope some of it might be useful for you... On Thu, 29 Mar 2012, Joe Woodward wrote: After digging a bit further I found that the problem isn't lost characters or character corruption at all...

Re: Suspend broken on 3.3?

2012-03-29 Thread Joe Woodward
Hello Joe, thanks for reporting this. Some thoughts -- really just pure speculation -- but I hope some of it might be useful for you... On Thu, 29 Mar 2012, Joe Woodward wrote: After digging a bit further I found that the problem isn't lost characters or character corruption at

Re: Suspend broken on 3.3?

2012-03-29 Thread Joe Woodward
: Suspend broken on 3.3? Hello Joe, thanks for reporting this. Some thoughts -- really just pure speculation -- but I hope some of it might be useful for you... On Thu, 29 Mar 2012, Joe Woodward wrote: After digging a bit further I found that the problem isn't lost characters

Re: Suspend broken on 3.3?

2012-03-29 Thread Raja, Govindraj
ba...@ti.com, ne...@suse.de Date: Thu, 29 Mar 2012 12:27:55 +0100 Subject: Re: Suspend broken on 3.3? Hello Joe, thanks for reporting this.  Some thoughts -- really just pure speculation -- but I hope some of it might be useful for you... On Thu, 29 Mar 2012, Joe Woodward wrote

Re: Suspend broken on 3.3?

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 3:07 AM, Kevin Hilman khil...@ti.com wrote: Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out

Re: Suspend broken on 3.3?

2012-03-28 Thread Joe Woodward
-Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Kevin Hilman khil...@ti.com Cc: Joe Woodward j...@terrafix.co.uk, linux-omap@vger.kernel.org linux-omap@vger.kernel.org, Felipe Balbi ba...@ti.com Date: Wed, 28 Mar 2012 16:29:53 +0530 Subject: Re: Suspend broken on 3.3

Re: Suspend broken on 3.3?

2012-03-28 Thread Kevin Hilman
+Paul, NeilBrown who both have worked on/around recent UART breakage since v3.2 Joe Woodward j...@terrafix.co.uk writes: [...] This patch fixes the suspend problem for me, but there is another UART issue... Basically I've got a fairly high speed data source (in UART terms, 900KBaud)

Re: Suspend broken on 3.3?

2012-03-27 Thread Raja, Govindraj
Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out a GUSMTIX Palo43 carrier board on which to test the Overo OMAP3530 COM and I've found:  - Running a stock 3.3 (with

Re: Suspend broken on 3.3?

2012-03-27 Thread Joe Woodward
...snip... Just to confirm: did the above work for you before v3.3? I've checked and v3.2 works correctly: echo enabled /sys/devices/platform/omap/omap_uart.2/power/wakeup = device wakes from console presses echo disabled /sys/devices/platform/omap/omap_uart.2/power/wakeup = device does

Re: Suspend broken on 3.3?

2012-03-27 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: ...snip... Just to confirm: did the above work for you before v3.3? I've checked and v3.2 works correctly: echo enabled /sys/devices/platform/omap/omap_uart.2/power/wakeup = device wakes from console presses echo disabled

Re: Suspend broken on 3.3?

2012-03-27 Thread Kevin Hilman
Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out a GUSMTIX Palo43 carrier board on which to test the Overo OMAP3530

Re: Suspend broken on 3.3?

2012-03-26 Thread Joe Woodward
-Original Message- From: Kevin Hilman khil...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: linux-omap\@vger.kernel.org linux-omap@vger.kernel.org Date: Thu, 22 Mar 2012 10:33:56 -0700 Subject: Re: Suspend broken on 3.3? Joe Woodward j...@terrafix.co.uk writes: Is system suspend

Re: Suspend broken on 3.3?

2012-03-26 Thread Kevin Hilman
+Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out a GUSMTIX Palo43 carrier board on which to test the Overo OMAP3530 COM and I've found: - Running a stock 3.3 (with absolutely no changes) does indeed suspend correctly. - Running the 3.3

Suspend broken on 3.3?

2012-03-22 Thread Joe Woodward
Is system suspend broken on stock 3.3? I have a working stock 3.2 (with patches to fix runtime_pm for DSS2), and system suspend works just fine! This is running on a variety of GUMSTIX boards (both OMAP3530 and AM3703-based). I've just updated to stock 3.3 and suspend returns immediately when

Re: Suspend broken on 3.3?

2012-03-22 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: Is system suspend broken on stock 3.3? I hope not. :) It *should* work, I'm using it regularily here, and it works for me (I'm sure that's just what you want to hear.) :) I have a working stock 3.2 (with patches to fix runtime_pm for DSS2