Hi,
I am not sure if this is needed. All calls within configure_dispc()
ensure that clocks are enabled before a register write.
The functions which read/write to registers and don't enable/disable
clocks have names which start with a _(for most cases).
Regards,
Archit
Hi,
Tomi Valkeinen wrote:
On Tue, 2011-01-18 at 10:45 +0530, ext Taneja, Archit wrote:
Hi,
I was going through the DSS2 code which sets up the FCLK coming
from PRCM and the DISPC divivors to get the required pixel clock.
The function dss_calc_clock_div() does a brute force search across
Hi,
I was going through the DSS2 code which sets up the FCLK
coming from PRCM and the DISPC divivors to get the required pixel
clock.
The function dss_calc_clock_div() does a brute force search across
all possible values of: a) DPLL divisor whose output goes to DSS, b)
DISPC_DIVISOR.LCD, c)
Hi,
linux-omap-ow...@vger.kernel.org wrote:
Hi,
On Mon, 2010-11-29 at 17:21 +0530, ext Guruswamy Senthilvadivu wrote:
From: Senthilvadivu Guruswamy svad...@ti.com
Database generated for Display Sub System applicable for
OMAP3430-ES2 onwards and OMAP36xx.
dss is also considered as an IP
Hi,
[snip]
I am assuming that you are referring to 'DISPC_IRQ_MASK_ERROR' and the
registering/unregistering of irq masks in manager.c
Not only the irqs, but also, for example, code like this:
if (channel == OMAP_DSS_CHANNEL_LCD ||
channel ==
Hi,
Tomi Valkeinen wrote:
On Thu, 2010-12-02 at 15:17 +0530, ext Taneja, Archit wrote:
Hi,
If you can split this patch into the two parts I suggested (if
that's ok for you, you didn't comment on that one), and check if
there's anything to add to the commit descriptions, I think we can
go
Hi,
Tomi Valkeinen wrote:
On Thu, 2010-12-02 at 16:00 +0530, ext Taneja, Archit wrote:
Hi,
Unfortunately the panel driver for N800 has not been ported to DSS2.
I can possibly try with a 2430sdp, but I don't see the omapdss
platform_device board-2430dsp.c. Are you aware of any omap2 setup
Hi,
Tomi Valkeinen wrote:
Hi,
On Mon, 2010-11-22 at 12:53 +0530, ext Archit Taneja wrote:
From: Sumit Semwal sumit.sem...@ti.com
A new member 'channel' is introduced in omap_dss_device structure to
determine which channel the panel uses. The dss_recheck_connections()
called in
Hi,
Tomi Valkeinen wrote:
On Tue, 2010-11-16 at 12:22 +0100, ext Taneja, Archit wrote:
Hi,
Tomi Valkeinen wrote:
Hi,
[snip]
diff --git a/arch/arm/plat-omap/include/plat/display.h
b/arch/arm/plat-omap/include/plat/display.h
index 586944d..3e6eec1 100644
--- a/arch/arm/plat-omap
Acked-by: Archit Taneja arc...@ti.com
bryan...@canonical.com wrote:
There are 4 duplicated DPI panel drivers in DSS2 display
driver. They are similar and a generic DPI panel driver can
support all them with specific panel configuration. And new
DPI panel driver can be easily supported by
Hi,
Tomi Valkeinen wrote:
Hi,
Tomi Valkeinen wrote:
On Tue, 2010-11-16 at 12:22 +0100, ext Taneja, Archit wrote:
Hi,
Tomi Valkeinen wrote:
Hi,
[snip]
diff --git a/arch/arm/plat-omap/include/plat/display.h
b/arch/arm/plat-omap/include/plat/display.h
index 586944d..3e6eec1
Hi,
Tomi Valkeinen wrote:
Hi,
[snip]
diff --git a/arch/arm/plat-omap/include/plat/display.h
b/arch/arm/plat-omap/include/plat/display.h
index 586944d..3e6eec1 100644
--- a/arch/arm/plat-omap/include/plat/display.h
+++ b/arch/arm/plat-omap/include/plat/display.h
@@ -434,6 +434,7 @@
Hi,
Bryan Wu wrote:
On Mon, Nov 15, 2010 at 12:05 PM, Taneja, Archit
arc...@ti.com wrote:
Hi,
bryan...@canonical.com wrote:
On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen
[snip]
For both panel power on and off some panels require some sleep times:
when powering on, the video
Hi,
Tomi Valkeinen wrote:
Hi,
On Mon, 2010-11-08 at 13:24 +0100, ext Archit Taneja wrote:
From: Sumit Semwal sumit.sem...@ti.com
Introduce new enum members for LCD2 Channel and corresponding Overlay
Manager.
Represent some of the DISPC register defines with channel as a
parameter to
Hi,
bryan...@canonical.com wrote:
On Wed, Nov 10, 2010 at 10:35 PM, Tomi Valkeinen
[snip]
For both panel power on and off some panels require some sleep times:
when powering on, the video interface has to be enabled for some time
before the panel can be enabled, and similarly when
Hi,
I was going through the DSS2 code and was unable to find a place
where we set the 11th bit in DISPC_GFX_ATTRIBUTES or the 19th bit
in DISPC_VIDn_ATTRIBUTES.
Setting these bits ensures that the DISPC FIFO's fill up to the
high threshold value specified by us instead of the preload values.
Is
Hi,
linux-omap-ow...@vger.kernel.org wrote:
Generic panel driver includes the driver and 4 similar panel
configurations. It will match the panel name which is passed
from platform data and setup the right configurations.
With generic panel driver, we can remove those 4 duplicated
panel
Hi,
linux-omap-ow...@vger.kernel.org wrote:
Introduce struct panel config data in panel.h, which will be
used to match the right panel configurations in generic DPI
panel driver and other future dsi panel drivers.
Still keep sharp_ls_panel, since the sharp_ls_panel driver
contains
Hi,
linux-omap-ow...@vger.kernel.org wrote:
Alpha Support
[snip]
+static void _dispc_set_pre_mult_alpha(enum omap_plane plane, bool +enable) {
+if (!dss_has_feature(FEAT_PREMUL_ALPHA))
+return;
+
+BUG_ON(!dss_has_feature(FEAT_GLOBAL_ALPHA_VID1)
+plane
Hi,
Tomi Valkeinen wrote:
On Wed, 2010-11-03 at 08:57 +0100, ext Taneja, Archit wrote:
Hi,
linux-omap-ow...@vger.kernel.org wrote:
Alpha Support
[snip]
+static void _dispc_set_pre_mult_alpha(enum omap_plane plane, bool
+enable) { + if (!dss_has_feature(FEAT_PREMUL_ALPHA
Hi,
linux-omap-ow...@vger.kernel.org wrote:
Introduce some fields in struct panel, which will be used to
match the right panel configurations in generic panel driver.
Still keep sharp_ls_panel, since the sharp_ls_panel driver
contains blacklight control driver code which will be moved
out
Hi,
Bryan Wu bryan...@canonical.com wrote:
There are 4 duplicated panel drivers in DSS2 display driver.
They are similar and generic panel driver can support all
them with specific panel configuration.
And new panel driver can be easily supported by adding panel
configurations into generic
Hi,
Tomi Valkeinen wrote:
Hi,
On Mon, 2010-09-20 at 22:18 +0200, ext Jorge Bustamante wrote:
Hi,
We (TI) have been working on a DSI video mode driver for OMAP4 and I
I hope it's also for OMAP3?
am aware that other people are working with similar drivers. We had to
tweak the code to
Hi,
Command mode panels will work fine with a single VC, I don't think
video mode can run by using only one VC.
Okay, I think we're talking about different VCs =). It's
rather confusing in the TRM. A VC (in DSI packet sense)
refers to the channel ID sent in the packet, and a VC (in
OMAP
Hi,
Tomi Valkeinen wrote:
Hi,
On Tue, 2010-10-05 at 13:55 +0200, ext Archit Taneja wrote:
This patch series which incorporates changes in DSS2 to enable
omap_dss_device instances to use the new Overlay Manager LCD2 in DISPC.
On OMAP4, we have a new DISPC channel for Overlay Manager LCD2.
Hi,
linux-omap-ow...@vger.kernel.org wrote:
I'm using a 2.6.35 kernel, and the generic panel driver.
I see this crash about 25% of the time, so I suspect a race condition.
Is anyone else encountering this?
Steve
Unmounting local filesystems...
Unhandled fault: external abort on
Hi,
Hiremath, Vaibhav wrote:
-Original Message-
From: Taneja, Archit
Sent: Monday, September 27, 2010 12:47 PM
To: Hiremath, Vaibhav
Cc: linux-omap@vger.kernel.org;
linux-me...@vger.kernel.org; Taneja,
Archit
Subject: [PATCH v2 0/2] V4L/DVB: OMAP_VOUT: Allow omap_vout to build
Hi,
Tomi Valkeinen wrote:
Hi,
On Wed, 2010-09-15 at 16:09 +0200, ext arc...@ti.com wrote:
From: Archit Taneja arc...@ti.com
Add dss_features.c and dss_features.h for the dss_features framework
Signed-off-by: Archit Taneja arc...@ti.com
---
snip
+struct omap_dss_features {
+
Hi,
Tomi Valkeinen wrote:
On Thu, 2010-10-07 at 09:37 +0200, ext Taneja, Archit wrote:
Hi,
I only now noticed that you had changed the feature list to a bit array.
It was an array of ints previously. Are you sure 32 features is enough? It
sounds a bit small to me.
Tomi
I
Hi,
linux-omap-ow...@vger.kernel.org wrote:
-Original Message-
From: Guruswamy, Senthilvadivu
Sent: Thursday, October 07, 2010 2:39 PM
To: tomi.valkei...@nokia.com; Hiremath, Vaibhav; linux- o...@vger.kernel.org
Cc: Guruswamy, Senthilvadivu
Subject: [PATCH v4 3/3] OMAP: DSS2:
Hi,
I had a couple of queries regarding the clock structures in the
clock_data.c files:
-I have seen that the name of the structure itself explains the name of the
clock as
given in the TRM.
-The member name also tries to mimic the clock name.
The drivers get the clock struct using the
Hi,
Thanks for this info.
Regards,
Archit
Nayak, Rajendra wrote:
Archit,
-Original Message-
From: Taneja, Archit
Sent: Friday, September 24, 2010 6:11 PM
To: Nayak, Rajendra
Cc: linux-omap@vger.kernel.org; Guruswamy, Senthilvadivu
Subject: Query on clock naming conventions
Any more comments?
Archit
Taneja, Archit wrote:
From: Archit Taneja arc...@ti.com
Calls init functions of dss_features during dss_probe, and
the following features are made omap independent:
- number of managers, overlays
- supported color modes for each overlay
- supported
Hi,
Tomi Valkeinen wrote:
Hi,
On Mon, 2010-09-13 at 07:30 +0200, ext Archit Taneja wrote:
Add dss_features.c and dss_features.h for the dss_features framework
Signed-off-by: Archit Taneja arc...@ti.com
---
drivers/video/omap2/dss/Makefile |2 +-
Hi,
I was reworking some patches, I saw 2 functions in manager.c:
dss_mgr_wait_for_go() and dss_mgr_wait_for_go_ovl() both
define the var enum omap_channel channel; but don't use it.
Is there any reason this is done, or is it just stray code?
Tomi Valkeinen wrote:
On Mon, 2010-09-13 at 07:30
Hi,
Tomi Valkeinen wrote:
Hi,
On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote:
Add dss_features.c and dss_features.h for the dss_features framework
Signed-off-by: Archit Taneja arc...@ti.com
And some more comments inline
---
drivers/video/omap2/dss/dss_features.c | 197
Hi,
Tomi Valkeinen wrote:
Hi,
On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote:
Add dss_features.c and dss_features.h for the dss_features framework
Signed-off-by: Archit Taneja arc...@ti.com
Would a more static approach be cleaner? I mean something like this (pseudo
code):
Hi,
Tomi Valkeinen wrote:
On Tue, 2010-09-07 at 13:31 +0200, ext Taneja, Archit wrote:
Hi,
Tomi Valkeinen wrote:
Hi,
On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote:
Add dss_features.c and dss_features.h for the dss_features framework
Signed-off-by: Archit Taneja arc
Hi,
Hiremath, Vaibhav wrote:
-Original Message-
From: Taneja, Archit
Sent: Monday, September 06, 2010 9:31 AM
To: Hiremath, Vaibhav
Cc: linux-omap@vger.kernel.org; linux-me...@vger.kernel.org
Subject: RE: [PATCH 0/2] V4L/DVB: OMAP_VOUT: Allow omap_vout to build
without VRFB
Hi
Hi,
Could you comment on the dss_feature patches? I can start reworking the
floating omap4
patches with this finalized :)
Thanks,
Archit
Taneja, Archit wrote:
This is a simple approach to prevent scattered
cpu_is_omap checks in DSS2 by bringing all omap version
specific DSS features
Hi,
Hiremath, Vaibhav wrote:
-Original Message-
From: Taneja, Archit
Sent: Saturday, September 04, 2010 2:12 PM
To: Hiremath, Vaibhav
Cc: linux-omap@vger.kernel.org;
linux-me...@vger.kernel.org; Taneja,
Archit
Subject: [PATCH 0/2] V4L/DVB: OMAP_VOUT: Allow omap_vout to build
Hi Benoit,
Thanks for the comments, ill study how we can leverage the hwmod fw for DSS
features.
Archit
-Original Message-
From: Cousson, Benoit
Sent: Tuesday, August 17, 2010 5:03 PM
To: Taneja, Archit
Cc: Tomi Valkeinen; Semwal, Sumit;
linux-omap@vger.kernel.org; Paul
Hi,
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Tuesday, August 17, 2010 5:10 PM
To: Taneja, Archit
Cc: Semwal, Sumit; linux-omap@vger.kernel.org
Subject: RE: DSS2 patch series
On Tue, 2010-08-17 at 13:16 +0200, ext Taneja, Archit wrote:
Hi
Hi,
Ok. Well, good that it's clear now =).
How do you think we can clean things up?
If I remember right, there's some kind of feature framework
being worked on (or ready?), but I haven't looked at that at
all. That may or may not suit our needs.
But perhaps we could just have a
Hi,
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Thursday, August 05, 2010 1:40 PM
To: Taneja, Archit
Cc: Semwal, Sumit; linux-omap@vger.kernel.org
Subject: RE: DSS2 patch series
On Thu, 2010-08-05 at 09:06 +0200, ext Taneja, Archit wrote:
Hi
Hi,
On Mon, 2010-08-02 at 14:05 +0200, ext Taneja, Archit wrote:
Hi,
On Tue, 2010-07-27 at 10:27 +0200, ext Taneja, Archit wrote:
Hi,
We had pushed three patch series while you were out. We
received some
good comments on them. We wanted to know if you can
point out
Hi,
On Tue, 2010-07-27 at 10:27 +0200, ext Taneja, Archit wrote:
Hi,
We had pushed three patch series while you were out. We
received some
good comments on them. We wanted to know if you can point out more
fixes and susuggestions before we rework them.
https
[snip]
[sp] This explains. And my earlier comment was to update the
description with need for change. I believe quick summary
the discussion above will be good for the patch.
Okay, will do. But what am is supposed to add more in the summary?
Should I add how sysfs_streq is a
-Original Message-
From: Premi, Sanjeev
Sent: Wednesday, July 28, 2010 7:28 PM
To: Taneja, Archit; tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp()
with sysfs_streq() in overlay_manager_store()
-Original
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Taneja, Archit
Sent: Wednesday, July 28, 2010 11:52 AM
To: tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Taneja, Archit
Subject
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Taneja, Archit
Sent: Wednesday, July 28, 2010 11:52 AM
To: tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Taneja, Archit
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Tuesday, July 27, 2010 12:50 PM
To: Taneja, Archit
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] OMAP: DSS2: Fix error path in
omap_dsi_update()
On Wed, 2010-07-14 at 14:11 +0200, ext
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Tuesday, July 27, 2010 1:14 PM
To: Taneja, Archit
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH v2] OMAP: DSS2: Fix error path in
omap_dsi_update()
On Tue, 2010-07-27 at 09:34 +0200, ext
Hi,
We had pushed three patch series while you were out. We received
some good comments on them. We wanted to know if you can point out
more fixes and susuggestions before we rework them.
https://patchwork.kernel.org/patch/111901/
https://patchwork.kernel.org/patch/112648/
Hi,
I had a little query. We check for TX FIFO not full before
sending a short packet in dsi_vc_send_short(), but we
don't have a similar check in dsi_vc_send_long() before
writing to the long packet header.
There is a check of the static fifo size of the channel and
the length of data we are
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Monday, July 26, 2010 3:50 PM
To: Taneja, Archit
Cc: linux-omap@vger.kernel.org
Subject: Re: DSS2: DSI: Check for TX FIFO emptiness when
sending long packets
On Mon, 2010-07-26 at 11:28 +0200
Hi,
-Original Message-
From: Hiremath, Vaibhav
Sent: Friday, July 23, 2010 10:54 AM
To: Taneja, Archit; tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Semwal, Sumit; Mittal, Mukund
Subject: RE: [PATCH 3/5] OMAP: DSS2: Add new overlay object
for Video3 pipeline
-Original Message-
From: Hiremath, Vaibhav
Sent: Friday, July 23, 2010 11:10 AM
To: Taneja, Archit; tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Semwal, Sumit; Mittal,
Mukund; Taneja, Archit
Subject: RE: [PATCH 4/5] OMAP: DSS2: Video3 pipeline IRQs
snap
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Taneja, Archit
Sent: Monday, July 19, 2010 5:26 PM
To: tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Janorkar, Mayuresh; Mittal, Mukund;
Taneja
-Original Message-
From: Premi, Sanjeev
Sent: Wednesday, July 21, 2010 7:47 PM
To: Taneja, Archit; tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Semwal, Sumit; Nilofer,
Samreen; Taneja, Archit
Subject: RE: [PATCH 1/3] OMAP: DSS2: Zorder enum in display.h
Taneja, Archit had written, on 07/14/2010 07:11 AM, the following:
In the case of an error on calling dsi_update_screen_l4(), a
successful framedone callback is still sent to panel-taal. An error
should be returned to taal_update() instead.
Signed-off-by: Archit Taneja arc...@ti.com
Hi,
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Taneja, Archit
Sent: Wednesday, July 14, 2010 12:03 PM
To: tomi.valkei...@nokia.com
Cc: linux-omap@vger.kernel.org; Semwal, Sumit; Guruswamy
On Thu, 2010-07-01 at 12:31 +0200, ext Archit Taneja wrote:
From: Sumit Semwal sumit.sem...@ti.com
Add new Overlay Manager in manager.c, make secondary
channel changes
and update supported displays for the managers in OMAP4
snip
@@ -1471,15 +1471,25 @@ int
Hi,
On Thu, 2010-07-01 at 12:31 +0200, ext Archit Taneja wrote:
From: Semwal, Sumit sumit.sem...@ti.com
Introduce OMAP4 DISPC base address and Secondary LCD Channel
registers, use them in register dumps.
snip
#define DISPC_DIVISOR DISPC_REG(0x0070)
+#define
On Thu, 2010-07-01 at 12:31 +0200, ext Archit Taneja wrote:
From: Sumit Semwal sumit.sem...@ti.com
The addition of the new 2lcd manager requires modifications in the
dss_recheck_connections patch, this function behaves the
same if the
2lcd manager doesn't exist
Here (and also
Hi,
On Thu, 2010-07-01 at 14:28 +0200, ext Taneja, Archit wrote:
On Thu, 2010-07-01 at 12:31 +0200, ext Archit Taneja wrote:
From: Sumit Semwal sumit.sem...@ti.com
The addition of the new 2lcd manager requires
modifications in the
dss_recheck_connections patch
Hi,
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Tuesday, June 22, 2010 3:54 PM
To: Taneja, Archit
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] OMAP: DSS2: DSI: disable manager on framedone
timeout
Hi,
On Mon, 21 Jun 2010, ext
Hi,
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
Sent: Thursday, June 17, 2010 2:22 PM
To: Taneja, Archit
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: DSS2: DSI: disable manager on framedone timeout
Hi,
On Thu, 2010-06-17 at 10:29
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Taneja, Archit
Sent: Thursday, June 17, 2010 2:37 PM
To: Tomi Valkeinen
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH] OMAP: DSS2: DSI: disable manager
69 matches
Mail list logo
